@odoo/o-spreadsheet 17.5.0-alpha.6 → 17.5.0-alpha.7

package/dist/o-spreadsheet.cjs.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.5.0-alpha.6
- * @date 2024-08-19T08:12:01.220Z
- * @hash c067f5d
+ * @version 17.5.0-alpha.7
+ * @date 2024-08-26T13:49:04.156Z
+ * @hash f8d3f23
  */
 
 'use strict';
@@ -267,6 +267,7 @@ const PIVOT_TABLE_CONFIG = {
     bandedRows: true,
     bandedColumns: false,
     styleId: "TableStyleMedium5",
+    automaticAutofill: true,
 };
 
 //------------------------------------------------------------------------------
@@ -2323,7 +2324,6 @@ exports.CommandResult = void 0;
     CommandResult["NoSplitSeparatorInSelection"] = "NoSplitSeparatorInSelection";
     CommandResult["NoActiveSheet"] = "NoActiveSheet";
     CommandResult["InvalidLocale"] = "InvalidLocale";
-    CommandResult["AlreadyInPaintingFormatMode"] = "AlreadyInPaintingFormatMode";
     CommandResult["MoreThanOneRangeSelected"] = "MoreThanOneRangeSelected";
     CommandResult["NoColumnsProvided"] = "NoColumnsProvided";
     CommandResult["ColumnsNotIncludedInZone"] = "ColumnsNotIncludedInZone";
@@ -4640,6 +4640,42 @@ function isOneDimensional(zone) {
     const { numberOfCols, numberOfRows } = zoneToDimension(zone);
     return numberOfCols === 1 || numberOfRows === 1;
 }
+function excludeTopLeft(zone) {
+    const { top, left, bottom, right } = zone;
+    if (getZoneArea(zone) === 1) {
+        return [];
+    }
+    const leftColumnZone = {
+        top: top + 1,
+        bottom,
+        left,
+        right: left,
+    };
+    if (right === left) {
+        return [leftColumnZone];
+    }
+    const rightPartZone = {
+        top,
+        bottom,
+        left: left + 1,
+        right,
+    };
+    if (top === bottom) {
+        return [rightPartZone];
+    }
+    return [leftColumnZone, rightPartZone];
+}
+function aggregatePositionsToZones(positions) {
+    const result = {};
+    for (const position of positions) {
+        result[position.sheetId] ??= [];
+        result[position.sheetId].push(positionToZone(position));
+    }
+    for (const sheetId in result) {
+        result[sheetId] = recomputeZones(result[sheetId]);
+    }
+    return result;
+}
 /**
  * Array of all positions in the zone.
  */
@@ -4814,16 +4850,6 @@ function getZonesRows(zones) {
     }
     return set;
 }
-function unionPositionsToZone(positions) {
-    const zone = { top: Infinity, left: Infinity, bottom: -Infinity, right: -Infinity };
-    for (const { col, row } of positions) {
-        zone.top = Math.min(zone.top, row);
-        zone.left = Math.min(zone.left, col);
-        zone.bottom = Math.max(zone.bottom, row);
-        zone.right = Math.max(zone.right, col);
-    }
-    return zone;
-}
 /**
  * Check if two zones are contiguous, ie. that they share a border
  */
@@ -10979,8 +11005,8 @@ const RANDARRAY = {
         const _min = toNumber(min, this.locale);
         const _max = toNumber(max, this.locale);
         const _whole_number = toBoolean(wholeNumber);
-        assertPositive(_t("The number columns (%s) must be positive.", _cols.toString()), _cols);
-        assertPositive(_t("The number rows (%s) must be positive.", _rows.toString()), _rows);
+        assertPositive(_t("The number of columns (%s) must be positive.", _cols.toString()), _cols);
+        assertPositive(_t("The number of rows (%s) must be positive.", _rows.toString()), _rows);
         assert(() => _min <= _max, _t("The maximum (%s) must be greater than or equal to the minimum (%s).", _max.toString(), _min.toString()));
         if (_whole_number) {
             assert(() => Number.isInteger(_min) && Number.isInteger(_max), _t("The maximum (%s) and minimum (%s) must be integers when whole_number is TRUE.", _max.toString(), _min.toString()));
@@ -11140,6 +11166,32 @@ const SECH = {
     isExported: true,
 };
 // -----------------------------------------------------------------------------
+// SEQUENCE
+// -----------------------------------------------------------------------------
+const SEQUENCE = {
+    description: _t("Returns a sequence of numbers."),
+    args: [
+        arg("rows (number)", _t("The number of rows to return")),
+        arg("columns (number, optional, default=1)", _t("The number of columns to return")),
+        arg("start (number, optional, default=1)", _t("The first number in the sequence")),
+        arg("step (number, optional, default=1)", _t("The amount to increment each value in the sequence")),
+    ],
+    compute: function (rows, columns = { value: 1 }, start = { value: 1 }, step = { value: 1 }) {
+        const _start = toNumber(start, this.locale);
+        const _step = toNumber(step, this.locale);
+        const _rows = toInteger(rows, this.locale);
+        const _columns = toInteger(columns, this.locale);
+        assertPositive(_t("The number of columns (%s) must be positive.", _columns), _columns);
+        assertPositive(_t("The number of rows (%s) must be positive.", _rows), _rows);
+        return generateMatrix(_columns, _rows, (col, row) => {
+            return {
+                value: _start + row * _columns * _step + col * _step,
+            };
+        });
+    },
+    isExported: true,
+};
+// -----------------------------------------------------------------------------
 // SIN
 // -----------------------------------------------------------------------------
 const SIN = {
@@ -11351,6 +11403,7 @@ var math = /*#__PURE__*/Object.freeze({
   ROUNDUP: ROUNDUP,
   SEC: SEC,
   SECH: SECH,
+  SEQUENCE: SEQUENCE,
   SIN: SIN,
   SINH: SINH,
   SQRT: SQRT,
@@ -30636,6 +30689,7 @@ const deleteSheet = {
     execute: (env) => env.askConfirmation(_t("Are you sure you want to delete this sheet?"), () => {
         env.model.dispatch("DELETE_SHEET", { sheetId: env.model.getters.getActiveSheetId() });
     }),
+    icon: "o-spreadsheet-Icon.TRASH",
 };
 const duplicateSheet = {
     name: _t("Duplicate"),
@@ -30648,11 +30702,13 @@ const duplicateSheet = {
         });
         env.model.dispatch("ACTIVATE_SHEET", { sheetIdFrom, sheetIdTo });
     },
+    icon: "o-spreadsheet-Icon.COPY",
 };
 const renameSheet = (args) => {
     return {
         name: _t("Rename"),
         execute: args.renameSheetCallback,
+        icon: "o-spreadsheet-Icon.RENAME_SHEET",
     };
 };
 const sheetMoveRight = {
@@ -30666,6 +30722,7 @@ const sheetMoveRight = {
         sheetId: env.model.getters.getActiveSheetId(),
         delta: 1,
     }),
+    icon: "o-spreadsheet-Icon.MOVE_SHEET_RIGHT",
 };
 const sheetMoveLeft = {
     name: _t("Move left"),
@@ -30677,11 +30734,13 @@ const sheetMoveLeft = {
         sheetId: env.model.getters.getActiveSheetId(),
         delta: -1,
     }),
+    icon: "o-spreadsheet-Icon.MOVE_SHEET_LEFT",
 };
 const hideSheet = {
     name: _t("Hide sheet"),
     isVisible: (env) => env.model.getters.getVisibleSheetIds().length !== 1,
     execute: (env) => env.model.dispatch("HIDE_SHEET", { sheetId: env.model.getters.getActiveSheetId() }),
+    icon: "o-spreadsheet-Icon.HIDE_SHEET",
 };
 
 //------------------------------------------------------------------------------
@@ -39806,7 +39865,6 @@ class FindAndReplaceStore extends SpreadsheetStore {
         searchScope: "activeSheet",
         specificRange: undefined,
     };
-    updateSearchContent = debounce(this._updateSearchContent.bind(this), 200);
     constructor(get) {
         super(get);
         this.initialShowFormulaState = this.model.getters.shouldShowFormulas();
@@ -39815,7 +39873,6 @@ class FindAndReplaceStore extends SpreadsheetStore {
         highlightStore.register(this);
         this.onDispose(() => {
             this.model.dispatch("SET_FORMULA_VISIBILITY", { show: this.initialShowFormulaState });
-            this.updateSearchContent.stopDebounce();
             highlightStore.unRegister(this);
         });
     }
@@ -39829,7 +39886,7 @@ class FindAndReplaceStore extends SpreadsheetStore {
                 return this.specificRangeMatches;
         }
     }
-    _updateSearchContent(toSearch) {
+    updateSearchContent(toSearch) {
         this._updateSearch(toSearch, this.searchOptions);
     }
     updateSearchOptions(searchOptions) {
@@ -39845,9 +39902,6 @@ class FindAndReplaceStore extends SpreadsheetStore {
     selectNextMatch() {
         this.selectNextCell(Direction.next);
     }
-    get pendingSearch() {
-        return this.updateSearchContent.isDebouncePending();
-    }
     handle(cmd) {
         switch (cmd.type) {
             case "SET_FORMULA_VISIBILITY":
@@ -40179,6 +40233,7 @@ class FindAndReplacePanel extends owl.Component {
     searchInput = owl.useRef("searchInput");
     store;
     state;
+    updateSearchContent;
     get hasSearchResult() {
         return this.store.selectedMatchIndex !== null;
     }
@@ -40220,12 +40275,14 @@ class FindAndReplacePanel extends owl.Component {
         this.store = useLocalStore(FindAndReplaceStore);
         this.state = owl.useState({ dataRange: "" });
         owl.onMounted(() => this.searchInput.el?.focus());
+        owl.onWillUnmount(() => this.updateSearchContent.stopDebounce());
+        this.updateSearchContent = debounce(this.store.updateSearchContent, 200);
     }
     onFocusSearch() {
         this.updateDataRange();
     }
     onSearchInput(ev) {
-        this.store.updateSearchContent(ev.target?.value || "");
+        this.updateSearchContent(ev.target.value);
     }
     onKeydownSearch(ev) {
         if (ev.key === "Enter") {
@@ -40264,6 +40321,9 @@ class FindAndReplacePanel extends owl.Component {
         const specificRange = this.env.model.getters.getRangeFromSheetXC(this.env.model.getters.getActiveSheetId(), this.state.dataRange);
         this.store.updateSearchOptions({ specificRange });
     }
+    get pendingSearch() {
+        return this.updateSearchContent.isDebouncePending();
+    }
 }
 
 css /* scss */ `
@@ -40816,34 +40876,9 @@ class CogWheelMenu extends owl.Component {
     }
 }
 
-/** @odoo-module */
-class EditableName extends owl.Component {
-    static template = "o-spreadsheet-EditableName";
-    static props = {
-        name: String,
-        displayName: String,
-        onChanged: Function,
-    };
-    state;
-    setup() {
-        this.state = owl.useState({
-            isEditing: false,
-            name: "",
-        });
-    }
-    rename() {
-        this.state.isEditing = true;
-        this.state.name = this.props.name;
-    }
-    save() {
-        this.props.onChanged(this.state.name.trim());
-        this.state.isEditing = false;
-    }
-}
-
 class PivotTitleSection extends owl.Component {
     static template = "o-spreadsheet-PivotTitleSection";
-    static components = { CogWheelMenu, Section, EditableName };
+    static components = { CogWheelMenu, Section, TextInput };
     static props = {
         pivotId: String,
         flipAxis: Function,
@@ -41410,6 +41445,12 @@ function orderDataEntriesKeys(groups, dimension) {
  * Used to order two values
  */
 function compareDimensionValues(dimension, a, b) {
+    if (a === "null") {
+        return dimension.order === "asc" ? 1 : -1;
+    }
+    if (b === "null") {
+        return dimension.order === "asc" ? -1 : 1;
+    }
     if (dimension.type === "integer" || dimension.type === "date") {
         return dimension.order === "asc" ? Number(a) - Number(b) : Number(b) - Number(a);
     }
@@ -41773,7 +41814,7 @@ class SpreadsheetPivot {
         if (cell.type === CellValueType.error) {
             throw new EvaluationError(_t("The pivot cannot be created because cell %s contains an error", toXC(col, row)));
         }
-        if (cell.type === CellValueType.empty) {
+        if (cell.type === CellValueType.empty || cell.value === "") {
             throw new EvaluationError(_t("The pivot cannot be created because cell %s is empty", toXC(col, row)));
         }
         if (cell.value === "__count") {
@@ -42118,15 +42159,11 @@ class PivotSpreadsheetSidePanel extends owl.Component {
     }
     onSelectionConfirmed() {
         if (this.state.range) {
-            const { sheetName, xc } = splitReference(this.state.range);
-            const sheetId = sheetName
-                ? this.env.model.getters.getSheetIdByName(sheetName)
-                : this.env.model.getters.getActiveSheetId();
-            if (!sheetId) {
+            const range = this.env.model.getters.getRangeFromSheetXC(this.env.model.getters.getActiveSheetId(), this.state.range);
+            if (range.invalidSheetName || range.invalidXc) {
                 return;
             }
-            const zone = toZone(xc);
-            const dataSet = { sheetId, zone };
+            const dataSet = { sheetId: range.sheetId, zone: range.zone };
             this.store.update({ dataSet });
             // Immediately apply the update to recompute the pivot fields
             this.store.applyUpdate();
@@ -43064,10 +43101,6 @@ class TablePanel extends owl.Component {
         });
     }
     onRangeChanged(ranges) {
-        if (!ranges[0] || !ranges[0].match(rangeReference)) {
-            this.state.tableZoneErrors = ["InvalidRange" /* CommandResult.InvalidRange */];
-            return;
-        }
         const sheetId = this.env.model.getters.getActiveSheetId();
         this.state.tableXc = ranges[0];
         const newTableRange = this.env.model.getters.getRangeFromSheetXC(sheetId, this.state.tableXc);
@@ -43107,11 +43140,6 @@ class TablePanel extends owl.Component {
             const newTableRange = updatedTable.range;
             this.state.tableXc = this.env.model.getters.getRangeString(newTableRange, sheetId);
         }
-        else {
-            const oldTableRange = this.props.table.range;
-            this.state.tableXc = this.env.model.getters.getRangeString(oldTableRange, sheetId);
-        }
-        this.state.tableZoneErrors = [];
     }
     deleteTable() {
         const sheetId = this.env.model.getters.getActiveSheetId();
@@ -45200,6 +45228,64 @@ class GridAddRowsFooter extends owl.Component {
     }
 }
 
+class PaintFormatStore extends SpreadsheetStore {
+    mutators = ["activate", "cancel", "pasteFormat"];
+    highlightStore = this.get(HighlightStore);
+    cellClipboardHandler = new CellClipboardHandler(this.getters, this.model.dispatch);
+    status = "inactive";
+    copiedData;
+    constructor(get) {
+        super(get);
+        this.highlightStore.register(this);
+        this.onDispose(() => {
+            this.highlightStore.unRegister(this);
+        });
+    }
+    activate(args) {
+        this.copiedData = this.copyFormats();
+        this.status = args.persistent ? "persistent" : "oneOff";
+    }
+    cancel() {
+        this.status = "inactive";
+        this.copiedData = undefined;
+    }
+    pasteFormat(target) {
+        if (this.copiedData) {
+            const sheetId = this.getters.getActiveSheetId();
+            this.cellClipboardHandler.paste({ zones: target, sheetId }, this.copiedData, {
+                isCutOperation: false,
+                pasteOption: "onlyFormat",
+            });
+        }
+        if (this.status === "oneOff") {
+            this.cancel();
+        }
+    }
+    get isActive() {
+        return this.status !== "inactive";
+    }
+    copyFormats() {
+        const sheetId = this.getters.getActiveSheetId();
+        const zones = this.getters.getSelectedZones();
+        return this.cellClipboardHandler.copy(getClipboardDataPositions(sheetId, zones));
+    }
+    get highlights() {
+        const data = this.copiedData;
+        if (!data) {
+            return [];
+        }
+        return data.zones.map((zone) => ({
+            zone,
+            color: SELECTION_BORDER_COLOR,
+            dashed: true,
+            sheetId: data.sheetId,
+            noFill: true,
+            thinLine: true,
+            interactive: false,
+        }));
+    }
+}
+
 const CURSOR_SVG = /*xml*/ `
 <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="14" height="16"><path d="M6.5.4c1.3-.8 2.9-.1 3.8 1.4l2.9 5.1c.2.4.9 1.6-.4 2.3l-1.6.9 1.8 3.1c.2.4.1 1-.2 1.2l-1.6 1c-.3.1-.9 0-1.1-.4l-1.8-3.1-1.6 1c-.6.4-1.7 0-2.2-.8L0 4.3"/><path fill="#fff" d="M9.1 2a1.4 1.1 60 0 0-1.7-.6L5.5 2.5l.9 1.6-1 .6-.9-1.6-.6.4 1.8 3.1-1.3.7-1.8-3.1-1 .6 3.8 6.6 6.8-3.98M3.9 8.8 10.82 5l.795 1.4-6.81 3.96"/></svg>
 `;
@@ -45346,6 +45432,7 @@ class GridOverlay extends owl.Component {
     gridOverlay = owl.useRef("gridOverlay");
     gridOverlayRect = useAbsoluteBoundingRect(this.gridOverlay);
     cellPopovers;
+    paintFormatStore;
     setup() {
         useCellHovered(this.env, this.gridOverlay, this.props.onCellHovered);
         const resizeObserver = new ResizeObserver(() => {
@@ -45368,6 +45455,7 @@ class GridOverlay extends owl.Component {
             return scrollY > 0;
         });
         this.cellPopovers = useStore(CellPopoverStore);
+        this.paintFormatStore = useStore(PaintFormatStore);
     }
     get gridOverlayEl() {
         if (!this.gridOverlay.el) {
@@ -45379,7 +45467,7 @@ class GridOverlay extends owl.Component {
         return this.props.gridOverlayDimensions;
     }
     get isPaintingFormat() {
-        return this.env.model.getters.isPaintingFormat();
+        return this.paintFormatStore.isActive;
     }
     onMouseDown(ev) {
         if (ev.button > 0) {
@@ -47266,6 +47354,7 @@ class Grid extends owl.Component {
     cellPopovers;
     composerFocusStore;
     DOMFocusableElementStore;
+    paintFormatStore;
     onMouseWheel;
     canvasPosition;
     hoveredCell;
@@ -47283,6 +47372,7 @@ class Grid extends owl.Component {
         this.composerFocusStore = useStore(ComposerFocusStore);
         this.DOMFocusableElementStore = useStore(DOMFocusableElementStore);
         this.sidePanel = useStore(SidePanelStore);
+        this.paintFormatStore = useStore(PaintFormatStore);
         useStore(ArrayFormulaHighlight);
         owl.useChildSubEnv({ getPopoverContainerRect: () => this.getGridRect() });
         owl.useExternalListener(document.body, "cut", this.copy.bind(this, true));
@@ -47359,8 +47449,8 @@ class Grid extends owl.Component {
             else if (this.menuState.isOpen) {
                 this.closeMenu();
             }
-            else if (this.env.model.getters.isPaintingFormat()) {
-                this.env.model.dispatch("CANCEL_PAINT_FORMAT");
+            else if (this.paintFormatStore.isActive) {
+                this.paintFormatStore.cancel();
             }
             else {
                 this.env.model.dispatch("CLEAN_CLIPBOARD_HIGHLIGHT");
@@ -47583,10 +47673,8 @@ class Grid extends owl.Component {
             }
         };
         const onMouseUp = () => {
-            if (this.env.model.getters.isPaintingFormat()) {
-                this.env.model.dispatch("PASTE", {
-                    target: this.env.model.getters.getSelectedZones(),
-                });
+            if (this.paintFormatStore.isActive) {
+                this.paintFormatStore.pasteFormat(this.env.model.getters.getSelectedZones());
             }
         };
         dragAndDropBeyondTheViewport(this.env, onMouseMove, onMouseUp);
@@ -47612,10 +47700,8 @@ class Grid extends owl.Component {
             this.cellPopovers.close();
         }
         updateSelectionWithArrowKeys(ev, this.env.model.selection);
-        if (this.env.model.getters.isPaintingFormat()) {
-            this.env.model.dispatch("PASTE", {
-                target: this.env.model.getters.getSelectedZones(),
-            });
+        if (this.paintFormatStore.isActive) {
+            this.paintFormatStore.pasteFormat(this.env.model.getters.getSelectedZones());
         }
     }
     onKeydown(ev) {
@@ -47844,6 +47930,31 @@ class Grid extends owl.Component {
     }
 }
 
+/** @odoo-module */
+class EditableName extends owl.Component {
+    static template = "o-spreadsheet-EditableName";
+    static props = {
+        name: String,
+        displayName: String,
+        onChanged: Function,
+    };
+    state;
+    setup() {
+        this.state = owl.useState({
+            isEditing: false,
+            name: "",
+        });
+    }
+    rename() {
+        this.state.isEditing = true;
+        this.state.name = this.props.name;
+    }
+    save() {
+        this.props.onChanged(this.state.name.trim());
+        this.state.isEditing = false;
+    }
+}
+
 /**
  * BasePlugin
  *
@@ -49503,6 +49614,8 @@ class ConditionalFormatPlugin extends CorePlugin {
                     "LessThan",
                     "LessThanOrEqual",
                     "NotContains",
+                    "Equal",
+                    "NotEqual",
                 ]), this.checkOperatorArgsNumber(0, ["IsEmpty", "IsNotEmpty"]), this.checkCFValues);
             case "ColorScaleRule": {
                 return this.checkValidations(rule, this.chainValidations(this.checkThresholds(this.checkFormulaCompilation)), this.chainValidations(this.checkThresholds(this.checkNaN), this.batchValidations(this.checkMinBiggerThanMax, this.checkMinBiggerThanMid, this.checkMidBiggerThanMax
@@ -49694,7 +49807,7 @@ class DataValidationPlugin extends CorePlugin {
     allowDispatch(cmd) {
         switch (cmd.type) {
             case "ADD_DATA_VALIDATION_RULE":
-                return this.checkValidations(cmd, this.chainValidations(this.checkCriterionTypeIsValid, this.checkCriterionHasValidNumberOfValues, this.checkCriterionValuesAreValid));
+                return this.checkValidations(cmd, this.chainValidations(this.checkEmptyRange, this.checkCriterionTypeIsValid, this.checkCriterionHasValidNumberOfValues, this.checkCriterionValuesAreValid));
             case "REMOVE_DATA_VALIDATION_RULE":
                 if (!this.rules[cmd.sheetId].find((rule) => rule.id === cmd.id)) {
                     return "UnknownDataValidationRule" /* CommandResult.UnknownDataValidationRule */;
@@ -49822,6 +49935,9 @@ class DataValidationPlugin extends CorePlugin {
             this.dispatch("UPDATE_CELL", { ...position, style });
         }
     }
+    checkEmptyRange(cmd) {
+        return cmd.ranges.length ? "Success" /* CommandResult.Success */ : "EmptyRange" /* CommandResult.EmptyRange */;
+    }
     import(data) {
         for (const sheet of data.sheets) {
             this.rules[sheet.id] = [];
@@ -50052,7 +50168,10 @@ class HeaderSizePlugin extends CorePlugin {
     handle(cmd) {
         switch (cmd.type) {
             case "CREATE_SHEET": {
-                this.history.update("sizes", cmd.sheetId, { COL: [], ROW: [] });
+                this.history.update("sizes", cmd.sheetId, {
+                    COL: Array(this.getters.getNumberCols(cmd.sheetId)).fill(undefined),
+                    ROW: Array(this.getters.getNumberRows(cmd.sheetId)).fill(undefined),
+                });
                 break;
             }
             case "DUPLICATE_SHEET":
@@ -53123,6 +53242,9 @@ class PivotCorePlugin extends CorePlugin {
                 if (deepEquals(cmd.pivot, this.pivots[cmd.pivotId]?.definition)) {
                     return "NoChanges" /* CommandResult.NoChanges */;
                 }
+                if (cmd.pivot.name === "") {
+                    return "EmptyName" /* CommandResult.EmptyName */;
+                }
                 break;
             }
             case "RENAME_PIVOT":
@@ -54701,47 +54823,47 @@ class SpreadingRelation {
      * | 4 |   | E |   |
      * -----------------
      * ```
-     * We will have `resultsToArrayFormulas` looking like:
-     * - (B2) --> (A2, B1)  meaning B2 can be the result of A2 OR B1
-     * - (C2) --> (A2)      meaning C2 is the result of A2
-     * - (B3) --> (B1)      meaning B3 is the result of B1
-     * - (B4) --> (B1)      meaning B4 is the result of B1
+     * We have `resultsToArrayFormulas` is an R-tree looking like:
+     * - (A2:C2) --> A2     meaning values in A2:C2 are the result of A2
+     * - (B1:B4) --> B1     meaning values in B1:B4 are the result of B1
+     *
+     * Note that B2 is part of both zones because it can be the result of
+     * A2 or B1.
+     * Using an R-tree allows for fast insertions while still having
+     * a relatively fast lookup.
      *
-     * We will have `arrayFormulasToResults` looking like:
-     * - (A2) --> (B2, C2)      meaning A2 spreads on B2 and C2
-     * - (B1) --> (B2, B3, B4)  meaning B1 spreads on B2, B3 and B4
+     * We have `arrayFormulasToResults` looking like:
+     * - (A2) --> A2:C2     meaning A2 spreads on the zone A2:C2
+     * - (B1) --> B1:B4     meaning B1 spreads on the zone B1:B4
      *
      */
-    resultsToArrayFormulas = new PositionMap();
+    resultsToArrayFormulas = new SpreadsheetRTree();
     arrayFormulasToResults = new PositionMap();
-    getFormulaPositionsSpreadingOn(resultPosition) {
-        return this.resultsToArrayFormulas.get(resultPosition) || EMPTY_ARRAY;
+    searchFormulaPositionsSpreadingOn(sheetId, zone) {
+        return (this.resultsToArrayFormulas.search({ sheetId, zone }).map((node) => node.data) || EMPTY_ARRAY);
     }
-    getArrayResultPositions(formulasPosition) {
-        return this.arrayFormulasToResults.get(formulasPosition) || EMPTY_ARRAY;
+    getArrayResultZone(formulasPosition) {
+        return this.arrayFormulasToResults.get(formulasPosition);
     }
     /**
      * Remove a node, also remove it from other nodes adjacency list
      */
     removeNode(position) {
-        this.resultsToArrayFormulas.delete(position);
+        this.resultsToArrayFormulas.remove({
+            boundingBox: { sheetId: position.sheetId, zone: positionToZone(position) },
+            data: position,
+        });
         this.arrayFormulasToResults.delete(position);
     }
     /**
      * Create a spreading relation between two cells
      */
-    addRelation({ arrayFormulaPosition, resultPosition, }) {
-        if (!this.resultsToArrayFormulas.has(resultPosition)) {
-            this.resultsToArrayFormulas.set(resultPosition, []);
-        }
-        this.resultsToArrayFormulas.get(resultPosition)?.push(arrayFormulaPosition);
-        if (!this.arrayFormulasToResults.has(arrayFormulaPosition)) {
-            this.arrayFormulasToResults.set(arrayFormulaPosition, []);
-        }
-        this.arrayFormulasToResults.get(arrayFormulaPosition)?.push(resultPosition);
-    }
-    hasArrayFormulaResult(position) {
-        return this.resultsToArrayFormulas.has(position);
+    addRelation({ arrayFormulaPosition, resultZone: resultPosition, }) {
+        this.resultsToArrayFormulas.insert({
+            boundingBox: { sheetId: arrayFormulaPosition.sheetId, zone: resultPosition },
+            data: arrayFormulaPosition,
+        });
+        this.arrayFormulasToResults.set(arrayFormulaPosition, resultPosition);
     }
     isArrayFormula(position) {
         return this.arrayFormulasToResults.has(position);
@@ -54769,7 +54891,8 @@ class Evaluator {
         return this.evaluatedCells.get(position) || EMPTY_CELL;
     }
     getSpreadZone(position, options = { ignoreSpillError: false }) {
-        if (!this.spreadingRelations.isArrayFormula(position)) {
+        const spreadZone = this.spreadingRelations.getArrayResultZone(position);
+        if (!spreadZone) {
             return undefined;
         }
         const evaluatedCell = this.evaluatedCells.get(position);
@@ -54777,8 +54900,7 @@ class Evaluator {
             !(options.ignoreSpillError && evaluatedCell?.value === CellErrorType.SpilledBlocked)) {
             return positionToZone(position);
         }
-        const spreadPositions = Array.from(this.spreadingRelations.getArrayResultPositions(position));
-        return union(positionToZone(position), unionPositionsToZone(spreadPositions));
+        return union(positionToZone(position), spreadZone);
     }
     getEvaluatedPositions() {
         return this.evaluatedCells.keys();
@@ -54787,10 +54909,12 @@ class Evaluator {
         return this.evaluatedCells.keysForSheet(sheetId);
     }
     getArrayFormulaSpreadingOn(position) {
-        if (!this.spreadingRelations.hasArrayFormulaResult(position)) {
+        const hasArrayFormulaResult = this.getEvaluatedCell(position).type !== CellValueType.empty &&
+            !this.getters.getCell(position)?.isFormula;
+        if (!hasArrayFormulaResult) {
             return this.spreadingRelations.isArrayFormula(position) ? position : undefined;
         }
-        const arrayFormulas = this.spreadingRelations.getFormulaPositionsSpreadingOn(position);
+        const arrayFormulas = this.spreadingRelations.searchFormulaPositionsSpreadingOn(position.sheetId, positionToZone(position));
         return Array.from(arrayFormulas).find((position) => !this.blockedArrayFormulas.has(position));
     }
     updateDependencies(position) {
@@ -54854,7 +54978,12 @@ class Evaluator {
                 impactedPositions.add(position);
             }
         }
-        impactedPositions.addMany(this.getArrayFormulasBlockedBy(impactedPositions));
+        const zonesBySheetIds = aggregatePositionsToZones(impactedPositions);
+        for (const sheetId in zonesBySheetIds) {
+            for (const zone of zonesBySheetIds[sheetId]) {
+                impactedPositions.addMany(this.getArrayFormulasBlockedBy(sheetId, zone));
+            }
+        }
         return impactedPositions;
     }
     buildDependencyGraph() {
@@ -54906,19 +55035,14 @@ class Evaluator {
      * Return the position of formulas blocked by the given positions
      * as well as all their dependencies.
      */
-    getArrayFormulasBlockedBy(positions) {
+    getArrayFormulasBlockedBy(sheetId, zone) {
         const arrayFormulaPositions = this.createEmptyPositionSet();
-        for (const position of positions) {
-            if (!this.spreadingRelations.hasArrayFormulaResult(position)) {
-                continue;
-            }
-            const arrayFormulas = this.spreadingRelations.getFormulaPositionsSpreadingOn(position);
-            arrayFormulaPositions.addMany(arrayFormulas);
-            const arrayFormulaPosition = this.getArrayFormulaSpreadingOn(position);
-            if (arrayFormulaPosition) {
-                // ignore the formula spreading on the position. Keep only the blocked ones
-                arrayFormulaPositions.delete(arrayFormulaPosition);
-            }
+        const arrayFormulas = this.spreadingRelations.searchFormulaPositionsSpreadingOn(sheetId, zone);
+        arrayFormulaPositions.addMany(arrayFormulas);
+        const spilledPositions = [...arrayFormulas].filter((position) => !this.blockedArrayFormulas.has(position));
+        if (spilledPositions.length) {
+            // ignore the formula spreading on the position. Keep only the blocked ones
+            arrayFormulaPositions.deleteMany(spilledPositions);
         }
         arrayFormulaPositions.addMany(this.getCellsDependingOn(arrayFormulaPositions));
         return arrayFormulaPositions;
@@ -54996,37 +55120,24 @@ class Evaluator {
         this.assertSheetHasEnoughSpaceToSpreadFormulaResult(formulaPosition, formulaReturn);
         const nbColumns = formulaReturn.length;
         const nbRows = formulaReturn[0].length;
-        forEachSpreadPositionInMatrix(nbColumns, nbRows, this.updateSpreadRelation(formulaPosition));
+        const resultZone = {
+            top: formulaPosition.row,
+            bottom: formulaPosition.row + nbRows - 1,
+            left: formulaPosition.col,
+            right: formulaPosition.col + nbColumns - 1,
+        };
+        this.spreadingRelations.addRelation({ resultZone, arrayFormulaPosition: formulaPosition });
         this.assertNoMergedCellsInSpreadZone(formulaPosition, formulaReturn);
         forEachSpreadPositionInMatrix(nbColumns, nbRows, this.checkCollision(formulaPosition));
         forEachSpreadPositionInMatrix(nbColumns, nbRows, 
         // thanks to the isMatrix check above, we know that formulaReturn is MatrixFunctionReturn
         this.spreadValues(formulaPosition, formulaReturn));
-        this.invalidatePositionsDependingOnSpread(formulaPosition, nbColumns, nbRows);
+        this.invalidatePositionsDependingOnSpread(formulaPosition.sheetId, resultZone);
         return createEvaluatedCell(nullValueToZeroValue(formulaReturn[0][0]), this.getters.getLocale(), cellData);
     }
-    invalidatePositionsDependingOnSpread(arrayFormulaPosition, nbColumns, nbRows) {
+    invalidatePositionsDependingOnSpread(sheetId, resultZone) {
         // the result matrix is split in 2 zones to exclude the array formula position
-        const top = arrayFormulaPosition.row;
-        const left = arrayFormulaPosition.col;
-        const bottom = top + nbRows - 1;
-        const leftColumnZone = {
-            top: top + 1,
-            bottom,
-            left,
-            right: left,
-        };
-        const rightPartZone = {
-            top,
-            bottom,
-            left: left + 1,
-            right: left + nbColumns - 1,
-        };
-        const sheetId = arrayFormulaPosition.sheetId;
-        const invalidatedPositions = this.formulaDependencies().getCellsDependingOn([
-            { sheetId, zone: rightPartZone },
-            { sheetId, zone: leftColumnZone },
-        ]);
+        const invalidatedPositions = this.formulaDependencies().getCellsDependingOn(excludeTopLeft(resultZone).map((zone) => ({ sheetId, zone })));
         this.nextPositionsToUpdate.addMany(invalidatedPositions);
     }
     assertSheetHasEnoughSpaceToSpreadFormulaResult({ sheetId, col, row }, matrixResult) {
@@ -55057,14 +55168,6 @@ class Evaluator {
         }
         throw new SplillBlockedError(_t("Merged cells found in the spill zone. Please unmerge cells before using array formulas."));
     }
-    updateSpreadRelation({ sheetId, col, row, }) {
-        const arrayFormulaPosition = { sheetId, col, row };
-        const updateSpreadRelation = (i, j) => {
-            const position = { sheetId, col: i + col, row: j + row };
-            this.spreadingRelations.addRelation({ resultPosition: position, arrayFormulaPosition });
-        };
-        return updateSpreadRelation;
-    }
     checkCollision(formulaPosition) {
         const { sheetId, col, row } = formulaPosition;
         const checkCollision = (i, j) => {
@@ -55089,22 +55192,25 @@ class Evaluator {
         return spreadValues;
     }
     invalidateSpreading(position) {
-        if (!this.spreadingRelations.isArrayFormula(position)) {
+        const zone = this.spreadingRelations.getArrayResultZone(position);
+        if (!zone) {
             return;
         }
-        const invalidated = this.createEmptyPositionSet();
-        for (const child of this.spreadingRelations.getArrayResultPositions(position)) {
-            const content = this.getters.getCell(child)?.content;
-            if (content) {
-                // there's no point at re-evaluating overlapping array formulas,
-                // there's still a collision
-                continue;
+        for (let col = zone.left; col <= zone.right; col++) {
+            for (let row = zone.top; row <= zone.bottom; row++) {
+                const resultPosition = { sheetId: position.sheetId, col, row };
+                const content = this.getters.getCell(resultPosition)?.content;
+                if (content) {
+                    // there's no point at re-evaluating overlapping array formulas,
+                    // there's still a collision
+                    continue;
+                }
+                this.evaluatedCells.delete(resultPosition);
             }
-            invalidated.add(child);
-            this.evaluatedCells.delete(child);
         }
-        this.nextPositionsToUpdate.addMany(this.getCellsDependingOn(invalidated));
-        this.nextPositionsToUpdate.addMany(this.getArrayFormulasBlockedBy(invalidated));
+        const sheetId = position.sheetId;
+        this.invalidatePositionsDependingOnSpread(sheetId, zone);
+        this.nextPositionsToUpdate.addMany(this.getArrayFormulasBlockedBy(sheetId, zone));
     }
     // ----------------------------------------------------------
     //                 COMMON FUNCTIONALITY
@@ -55284,9 +55390,10 @@ class EvaluationPlugin extends UIPlugin {
                 if (!("content" in cmd || "format" in cmd) || this.shouldRebuildDependenciesGraph) {
                     return;
                 }
-                this.positionsToUpdate.push(cmd);
+                const position = { sheetId: cmd.sheetId, row: cmd.row, col: cmd.col };
+                this.positionsToUpdate.push(position);
                 if ("content" in cmd) {
-                    this.evaluator.updateDependencies(cmd);
+                    this.evaluator.updateDependencies(position);
                 }
                 break;
             case "EVALUATE_CELLS":
@@ -56572,10 +56679,6 @@ class PivotUIPlugin extends UIPlugin {
                 this.setupPivot(cmd.pivotId, { recreate: true });
                 break;
             }
-            case "REMOVE_PIVOT": {
-                delete this.pivots[cmd.pivotId];
-                break;
-            }
             case "DELETE_SHEET":
             case "UPDATE_CELL": {
                 this.unusedPivots = undefined;
@@ -56717,6 +56820,9 @@ class PivotUIPlugin extends UIPlugin {
         }
     }
     getPivot(pivotId) {
+        if (!this.getters.isExistingPivot(pivotId)) {
+            throw new Error(`pivot ${pivotId} not found`);
+        }
         return this.pivots[pivotId];
     }
     isPivotUnused(pivotId) {
@@ -58799,7 +58905,7 @@ class InsertPivotPlugin extends UIPlugin {
             sheetId,
             col,
             row,
-            content: `=PIVOT("${pivotFormulaId}")`,
+            content: `=PIVOT(${pivotFormulaId})`,
         });
         const zone = {
             left: col,
@@ -60123,10 +60229,8 @@ class ClipboardPlugin extends UIPlugin {
         "getClipboardId",
         "getClipboardTextContent",
         "isCutOperation",
-        "isPaintingFormat",
     ];
     status = "invisible";
-    paintFormatStatus = "inactive";
     originSheetId;
     copiedData;
     _isCutOperation = false;
@@ -60141,14 +60245,14 @@ class ClipboardPlugin extends UIPlugin {
                 return this.isCutAllowedOn(zones);
             case "PASTE_FROM_OS_CLIPBOARD": {
                 const copiedData = this.convertOSClipboardData(cmd.clipboardContent[ClipboardMIMEType.PlainText] ?? "");
-                const pasteOption = cmd.pasteOption || (this.paintFormatStatus !== "inactive" ? "onlyFormat" : undefined);
+                const pasteOption = cmd.pasteOption;
                 return this.isPasteAllowed(cmd.target, copiedData, { pasteOption, isCutOperation: false });
             }
             case "PASTE": {
                 if (!this.copiedData) {
                     return "EmptyClipboard" /* CommandResult.EmptyClipboard */;
                 }
-                const pasteOption = cmd.pasteOption || (this.paintFormatStatus !== "inactive" ? "onlyFormat" : undefined);
+                const pasteOption = cmd.pasteOption;
                 return this.isPasteAllowed(cmd.target, this.copiedData, {
                     pasteOption: pasteOption,
                     isCutOperation: this._isCutOperation,
@@ -60178,12 +60282,6 @@ class ClipboardPlugin extends UIPlugin {
                 const copiedData = this.copy(cut);
                 return this.isPasteAllowed(paste, copiedData, { isCutOperation: true });
             }
-            case "ACTIVATE_PAINT_FORMAT": {
-                if (this.paintFormatStatus !== "inactive") {
-                    return "AlreadyInPaintingFormatMode" /* CommandResult.AlreadyInPaintingFormatMode */;
-                }
-                return "Success" /* CommandResult.Success */;
-            }
         }
         return "Success" /* CommandResult.Success */;
     }
@@ -60205,7 +60303,7 @@ class ClipboardPlugin extends UIPlugin {
                 else {
                     this.copiedData = this.convertOSClipboardData(cmd.clipboardContent[ClipboardMIMEType.PlainText] ?? "");
                 }
-                const pasteOption = cmd.pasteOption || (this.paintFormatStatus !== "inactive" ? "onlyFormat" : undefined);
+                const pasteOption = cmd.pasteOption;
                 this.paste(cmd.target, this.copiedData, {
                     pasteOption,
                     selectTarget: true,
@@ -60215,18 +60313,16 @@ class ClipboardPlugin extends UIPlugin {
                 break;
             }
             case "PASTE": {
-                const pasteOption = cmd.pasteOption || (this.paintFormatStatus !== "inactive" ? "onlyFormat" : undefined);
+                const pasteOption = cmd.pasteOption;
                 this.paste(cmd.target, this.copiedData, {
                     pasteOption,
                     selectTarget: true,
                     isCutOperation: this._isCutOperation,
                 });
-                if (this.paintFormatStatus === "oneOff") {
-                    this.paintFormatStatus = "inactive";
-                }
                 this.status = "invisible";
                 if (this._isCutOperation) {
                     this.copiedData = undefined;
+                    this._isCutOperation = false;
                 }
                 break;
             }
@@ -60322,18 +60418,6 @@ class ClipboardPlugin extends UIPlugin {
                 });
                 break;
             }
-            case "ACTIVATE_PAINT_FORMAT": {
-                const zones = this.getters.getSelectedZones();
-                this.copiedData = this.copy(zones);
-                this.status = "visible";
-                if (cmd.persistent) {
-                    this.paintFormatStatus = "persistent";
-                }
-                else {
-                    this.paintFormatStatus = "oneOff";
-                }
-                break;
-            }
             case "DELETE_SHEET":
                 if (this._isCutOperation !== true) {
                     return;
@@ -60343,11 +60427,6 @@ class ClipboardPlugin extends UIPlugin {
                     this.status = "invisible";
                 }
                 break;
-            case "CANCEL_PAINT_FORMAT": {
-                this.paintFormatStatus = "inactive";
-                this.status = "invisible";
-                break;
-            }
             default:
                 if (isCoreCommand(cmd)) {
                     this.status = "invisible";
@@ -60563,7 +60642,7 @@ class ClipboardPlugin extends UIPlugin {
         }
         const cells = this.copiedData.cells;
         if (cells.length === 1 && cells[0].length === 1) {
-            return this.getters.getCellText(cells[0][0].position);
+            return `<div data-clipboard-id="${this.clipboardId}">${this.getters.getCellText(cells[0][0].position)}</div>`;
         }
         if (!cells[0][0]) {
             return "";
@@ -60587,9 +60666,6 @@ class ClipboardPlugin extends UIPlugin {
     isCutOperation() {
         return this._isCutOperation ?? false;
     }
-    isPaintingFormat() {
-        return this.paintFormatStatus !== "inactive";
-    }
     // ---------------------------------------------------------------------------
     // Private methods
     // ---------------------------------------------------------------------------
@@ -64494,18 +64570,22 @@ class PaintFormatButton extends owl.Component {
     static props = {
         class: { type: String, optional: true },
     };
+    paintFormatStore;
+    setup() {
+        this.paintFormatStore = useStore(PaintFormatStore);
+    }
     get isActive() {
-        return this.env.model.getters.isPaintingFormat();
+        return this.paintFormatStore.isActive;
     }
     onDblClick() {
-        this.env.model.dispatch("ACTIVATE_PAINT_FORMAT", { persistent: true });
+        this.paintFormatStore.activate({ persistent: true });
     }
     togglePaintFormat() {
         if (this.isActive) {
-            this.env.model.dispatch("CANCEL_PAINT_FORMAT");
+            this.paintFormatStore.cancel();
         }
         else {
-            this.env.model.dispatch("ACTIVATE_PAINT_FORMAT", { persistent: false });
+            this.paintFormatStore.activate({ persistent: false });
         }
     }
 }
@@ -68956,6 +69036,7 @@ class Model extends EventBus {
             case 0 /* Status.Ready */:
                 const result = this.checkDispatchAllowed(command);
                 if (!result.isSuccessful) {
+                    this.trigger("update");
                     return result;
                 }
                 this.status = 1 /* Status.Running */;
@@ -69275,6 +69356,7 @@ const components = {
     PivotTitleSection,
     CogWheelMenu,
     TextInput,
+    SidePanelCollapsible,
 };
 const hooks = {
     useDragAndDropListItems,
@@ -69361,6 +69443,6 @@ exports.tokenColors = tokenColors;
 exports.tokenize = tokenize;
 
 
-__info__.version = "17.5.0-alpha.6";
-__info__.date = "2024-08-19T08:12:01.220Z";
-__info__.hash = "c067f5d";
+__info__.version = "17.5.0-alpha.7";
+__info__.date = "2024-08-26T13:49:04.156Z";
+__info__.hash = "f8d3f23";