@odoo/o-spreadsheet 17.4.8 → 17.4.10

package/dist/o-spreadsheet.esm.js

@@ -2,13 +2,118 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.4.8
- * @date 2024-09-17T08:10:18.777Z
- * @hash caad8bd
+ * @version 17.4.10
+ * @date 2024-10-24T08:54:56.262Z
+ * @hash c82d9c1
  */
 
 import { useEnv, useSubEnv, onWillUnmount, useComponent, status, Component, useRef, onMounted, useEffect, useState, onPatched, onWillPatch, onWillUpdateProps, useExternalListener, onWillStart, xml, useChildSubEnv, markRaw, toRaw } from '@odoo/owl';
 
+function createActions(menuItems) {
+    return menuItems.map(createAction).sort((a, b) => a.sequence - b.sequence);
+}
+let nextItemId = 1;
+function createAction(item) {
+    const name = item.name;
+    const children = item.children;
+    const description = item.description;
+    const icon = item.icon;
+    const secondaryIcon = item.secondaryIcon;
+    const itemId = item.id || nextItemId++;
+    return {
+        id: itemId.toString(),
+        name: typeof name === "function" ? name : () => name,
+        isVisible: item.isVisible ? item.isVisible : () => true,
+        isEnabled: item.isEnabled ? item.isEnabled : () => true,
+        isActive: item.isActive,
+        execute: item.execute,
+        children: children
+            ? (env) => {
+                return children
+                    .map((child) => (typeof child === "function" ? child(env) : child))
+                    .flat()
+                    .map(createAction);
+            }
+            : () => [],
+        isReadonlyAllowed: item.isReadonlyAllowed || false,
+        separator: item.separator || false,
+        icon: typeof icon === "function" ? icon : () => icon || "",
+        secondaryIcon: typeof secondaryIcon === "function" ? secondaryIcon : () => secondaryIcon || "",
+        description: typeof description === "function" ? description : () => description || "",
+        textColor: item.textColor,
+        sequence: item.sequence || 0,
+        onStartHover: item.onStartHover,
+        onStopHover: item.onStopHover,
+    };
+}
+
+/**
+ * Registry
+ *
+ * The Registry class is basically just a mapping from a string key to an object.
+ * It is really not much more than an object. It is however useful for the
+ * following reasons:
+ *
+ * 1. it let us react and execute code when someone add something to the registry
+ *   (for example, the FunctionRegistry subclass this for this purpose)
+ * 2. it throws an error when the get operation fails
+ * 3. it provides a chained API to add items to the registry.
+ */
+class Registry {
+    content = {};
+    /**
+     * Add an item to the registry
+     *
+     * Note that this also returns the registry, so another add method call can
+     * be chained
+     */
+    add(key, value) {
+        this.content[key] = value;
+        return this;
+    }
+    /**
+     * Get an item from the registry
+     */
+    get(key) {
+        /**
+         * Note: key in {} is ~12 times slower than {}[key].
+         * So, we check the absence of key only when the direct access returns
+         * a falsy value. It's done to ensure that the registry can contains falsy values
+         */
+        const content = this.content[key];
+        if (!content) {
+            if (!(key in this.content)) {
+                throw new Error(`Cannot find ${key} in this registry!`);
+            }
+        }
+        return content;
+    }
+    /**
+     * Check if the key is already in the registry
+     */
+    contains(key) {
+        return key in this.content;
+    }
+    /**
+     * Get a list of all elements in the registry
+     */
+    getAll() {
+        return Object.values(this.content);
+    }
+    /**
+     * Get a list of all keys in the registry
+     */
+    getKeys() {
+        return Object.keys(this.content);
+    }
+    /**
+     * Remove an item from the registry
+     */
+    remove(key) {
+        delete this.content[key];
+    }
+}
+
 const CANVAS_SHIFT = 0.5;
 // Colors
 const HIGHLIGHT_COLOR = "#37A850";
@@ -165,7 +270,7 @@ const DEFAULT_STYLE = {
     underline: false,
     fontSize: 10,
     fillColor: "",
-    textColor: "#000000",
+    textColor: "",
 };
 const DEFAULT_VERTICAL_ALIGN = DEFAULT_STYLE.verticalAlign;
 const DEFAULT_WRAPPING_MODE = DEFAULT_STYLE.wrapping;
@@ -5397,110 +5502,6 @@ class UuidGenerator {
     }
 }
 
-function createActions(menuItems) {
-    return menuItems.map(createAction).sort((a, b) => a.sequence - b.sequence);
-}
-const uuidGenerator$1 = new UuidGenerator();
-function createAction(item) {
-    const name = item.name;
-    const children = item.children;
-    const description = item.description;
-    const icon = item.icon;
-    const secondaryIcon = item.secondaryIcon;
-    return {
-        id: item.id || uuidGenerator$1.uuidv4(),
-        name: typeof name === "function" ? name : () => name,
-        isVisible: item.isVisible ? item.isVisible : () => true,
-        isEnabled: item.isEnabled ? item.isEnabled : () => true,
-        isActive: item.isActive,
-        execute: item.execute,
-        children: children
-            ? (env) => {
-                return children
-                    .map((child) => (typeof child === "function" ? child(env) : child))
-                    .flat()
-                    .map(createAction);
-            }
-            : () => [],
-        isReadonlyAllowed: item.isReadonlyAllowed || false,
-        separator: item.separator || false,
-        icon: typeof icon === "function" ? icon : () => icon || "",
-        secondaryIcon: typeof secondaryIcon === "function" ? secondaryIcon : () => secondaryIcon || "",
-        description: typeof description === "function" ? description : () => description || "",
-        textColor: item.textColor,
-        sequence: item.sequence || 0,
-        onStartHover: item.onStartHover,
-        onStopHover: item.onStopHover,
-    };
-}
-
-/**
- * Registry
- *
- * The Registry class is basically just a mapping from a string key to an object.
- * It is really not much more than an object. It is however useful for the
- * following reasons:
- *
- * 1. it let us react and execute code when someone add something to the registry
- *   (for example, the FunctionRegistry subclass this for this purpose)
- * 2. it throws an error when the get operation fails
- * 3. it provides a chained API to add items to the registry.
- */
-class Registry {
-    content = {};
-    /**
-     * Add an item to the registry
-     *
-     * Note that this also returns the registry, so another add method call can
-     * be chained
-     */
-    add(key, value) {
-        this.content[key] = value;
-        return this;
-    }
-    /**
-     * Get an item from the registry
-     */
-    get(key) {
-        /**
-         * Note: key in {} is ~12 times slower than {}[key].
-         * So, we check the absence of key only when the direct access returns
-         * a falsy value. It's done to ensure that the registry can contains falsy values
-         */
-        const content = this.content[key];
-        if (!content) {
-            if (!(key in this.content)) {
-                throw new Error(`Cannot find ${key} in this registry!`);
-            }
-        }
-        return content;
-    }
-    /**
-     * Check if the key is already in the registry
-     */
-    contains(key) {
-        return key in this.content;
-    }
-    /**
-     * Get a list of all elements in the registry
-     */
-    getAll() {
-        return Object.values(this.content);
-    }
-    /**
-     * Get a list of all keys in the registry
-     */
-    getKeys() {
-        return Object.keys(this.content);
-    }
-    /**
-     * Remove an item from the registry
-     */
-    remove(key) {
-        delete this.content[key];
-    }
-}
-
 function getClipboardDataPositions(sheetId, zones) {
     const lefts = new Set(zones.map((z) => z.left));
     const rights = new Set(zones.map((z) => z.right));
@@ -7279,31 +7280,34 @@ class TableClipboardHandler extends AbstractCellClipboardHandler {
             for (let col of columnsIndexes) {
                 const position = { col, row, sheetId };
                 const table = this.getters.getTable(position);
-                if (!table || copiedTablesIds.has(table.id)) {
+                if (!table) {
                     tableCellsInRow.push({});
                     continue;
                 }
                 const coreTable = this.getters.getCoreTable(position);
                 const tableZone = coreTable?.range.zone;
+                let copiedTable = undefined;
                 // Copy whole table
-                if (coreTable && tableZone && zones.some((z) => isZoneInside(tableZone, z))) {
-                    copiedTablesIds.add(coreTable.id);
+                if (!copiedTablesIds.has(table.id) &&
+                    coreTable &&
+                    tableZone &&
+                    zones.some((z) => isZoneInside(tableZone, z))) {
+                    copiedTablesIds.add(table.id);
                     const values = [];
                     for (const col of range(tableZone.left, tableZone.right + 1)) {
                         values.push(this.getters.getFilterHiddenValues({ sheetId, col, row: tableZone.top }));
                     }
-                    tableCellsInRow.push({
-                        table: {
-                            range: coreTable.range,
-                            config: coreTable.config,
-                            type: coreTable.type,
-                        },
-                    });
-                }
-                // Copy only style of cell
-                else if (table) {
-                    tableCellsInRow.push({ style: this.getTableStyleToCopy(position) });
+                    copiedTable = {
+                        range: coreTable.range,
+                        config: coreTable.config,
+                        type: coreTable.type,
+                    };
                 }
+                tableCellsInRow.push({
+                    table: copiedTable,
+                    style: this.getTableStyleToCopy(position),
+                    isWholeTableCopied: copiedTablesIds.has(table.id),
+                });
             }
         }
         return {
@@ -7384,11 +7388,14 @@ class TableClipboardHandler extends AbstractCellClipboardHandler {
                 tableType: tableCell.table.type,
             });
         }
-        // Do not paste table style if we're inside another table
         // We cannot check for dynamic tables, because at this point the paste can have changed the evaluation, and the
         // dynamic tables are not yet computed
-        if (!this.getters.getCoreTable(position)) {
-            if (tableCell.style?.style && options?.pasteOption !== "asValue") {
+        if (this.getters.getCoreTable(position) || options?.pasteOption === "asValue") {
+            return;
+        }
+        if ((!options?.pasteOption && !tableCell.isWholeTableCopied) ||
+            options?.pasteOption === "onlyFormat") {
+            if (tableCell.style?.style) {
                 this.dispatch("UPDATE_CELL", { ...position, style: tableCell.style.style });
             }
             if (tableCell.style?.border) {
@@ -10616,67 +10623,108 @@ const chartShowValuesPlugin = {
         ctx.save();
         ctx.textAlign = "center";
         ctx.textBaseline = "middle";
-        ctx.fillStyle = chartFontColor(options.background);
-        ctx.strokeStyle = chartFontColor(ctx.fillStyle);
-        chart._metasets.forEach(function (dataset) {
-            switch (dataset.type) {
-                case "doughnut":
-                case "pie": {
-                    for (let i = 0; i < dataset._parsed.length; i++) {
-                        const bar = dataset.data[i];
-                        const { startAngle, endAngle, innerRadius, outerRadius } = bar;
-                        const midAngle = (startAngle + endAngle) / 2;
-                        const midRadius = (innerRadius + outerRadius) / 2;
-                        const x = bar.x + midRadius * Math.cos(midAngle);
-                        const y = bar.y + midRadius * Math.sin(midAngle) + 7;
-                        ctx.fillStyle = chartFontColor(bar.options.backgroundColor);
-                        ctx.strokeStyle = chartFontColor(ctx.fillStyle);
-                        const value = options.callback(dataset._parsed[i]);
-                        ctx.strokeText(value, x, y);
-                        ctx.fillText(value, x, y);
-                    }
-                    break;
-                }
-                case "bar":
-                case "line": {
-                    const yOffset = dataset.type === "bar" && !options.horizontal ? 0 : 3;
-                    for (let i = 0; i < dataset._parsed.length; i++) {
-                        const point = dataset.data[i];
-                        const value = options.horizontal ? dataset._parsed[i].x : dataset._parsed[i].y;
-                        const displayedValue = options.callback(value - 0);
-                        let xPosition = 0, yPosition = 0;
-                        if (options.horizontal) {
-                            yPosition = point.y;
-                            if (value < 0) {
-                                ctx.textAlign = "right";
-                                xPosition = point.x - yOffset;
-                            }
-                            else {
-                                ctx.textAlign = "left";
-                                xPosition = point.x + yOffset;
-                            }
-                        }
-                        else {
-                            xPosition = point.x;
-                            if (value < 0) {
-                                ctx.textBaseline = "top";
-                                yPosition = point.y + yOffset;
-                            }
-                            else {
-                                ctx.textBaseline = "bottom";
-                                yPosition = point.y - yOffset;
-                            }
-                        }
-                        ctx.strokeText(displayedValue, xPosition, yPosition);
-                        ctx.fillText(displayedValue, xPosition, yPosition);
-                    }
-                    break;
-                }
-            }
-        });
+        ctx.miterLimit = 1; // Avoid sharp artifacts on strokeText
+        switch (chart.config.type) {
+            case "pie":
+            case "doughnut":
+                drawPieChartValues(chart, options, ctx);
+                break;
+            case "bar":
+            case "line":
+                options.horizontal
+                    ? drawHorizontalBarChartValues(chart, options, ctx)
+                    : drawLineOrBarChartValues(chart, options, ctx);
+                break;
+        }
         ctx.restore();
     },
 };
+function drawTextWithBackground(text, x, y, ctx) {
+    ctx.lineWidth = 3; // Stroke the text with a big lineWidth width to have some kind of background
+    ctx.strokeText(text, x, y);
+    ctx.lineWidth = 1;
+    ctx.fillText(text, x, y);
+}
+function drawLineOrBarChartValues(chart, options, ctx) {
+    const yMax = chart.chartArea.bottom;
+    const yMin = chart.chartArea.top;
+    const textsPositions = {};
+    for (const dataset of chart._metasets) {
+        for (let i = 0; i < dataset._parsed.length; i++) {
+            const value = dataset._parsed[i].y;
+            const point = dataset.data[i];
+            const xPosition = point.x;
+            let yPosition = 0;
+            if (chart.config.type === "line") {
+                yPosition = point.y - 10;
+            }
+            else {
+                yPosition = value < 0 ? point.y - point.height / 2 : point.y + point.height / 2;
+            }
+            yPosition = Math.min(yPosition, yMax);
+            yPosition = Math.max(yPosition, yMin);
+            // Avoid overlapping texts with same X
+            if (!textsPositions[xPosition]) {
+                textsPositions[xPosition] = [];
+            }
+            for (const otherPosition of textsPositions[xPosition] || []) {
+                if (Math.abs(otherPosition - yPosition) < 13) {
+                    yPosition = otherPosition - 13;
+                }
+            }
+            textsPositions[xPosition].push(yPosition);
+            ctx.fillStyle = point.options.backgroundColor;
+            ctx.strokeStyle = options.background || "#ffffff";
+            drawTextWithBackground(options.callback(value - 0), xPosition, yPosition, ctx);
+        }
+    }
+}
+function drawHorizontalBarChartValues(chart, options, ctx) {
+    const xMax = chart.chartArea.right;
+    const xMin = chart.chartArea.left;
+    const textsPositions = {};
+    for (const dataset of chart._metasets) {
+        for (let i = 0; i < dataset._parsed.length; i++) {
+            const value = dataset._parsed[i].x;
+            const displayValue = options.callback(value - 0);
+            const point = dataset.data[i];
+            const yPosition = point.y;
+            let xPosition = value < 0 ? point.x + point.width / 2 : point.x - point.width / 2;
+            xPosition = Math.min(xPosition, xMax);
+            xPosition = Math.max(xPosition, xMin);
+            // Avoid overlapping texts with same Y
+            if (!textsPositions[yPosition]) {
+                textsPositions[yPosition] = [];
+            }
+            const textWidth = computeTextWidth(ctx, displayValue, { fontSize: 12 }, "px");
+            for (const otherPosition of textsPositions[yPosition]) {
+                if (Math.abs(otherPosition - xPosition) < textWidth) {
+                    xPosition = otherPosition + textWidth + 3;
+                }
+            }
+            textsPositions[yPosition].push(xPosition);
+            ctx.fillStyle = point.options.backgroundColor;
+            ctx.strokeStyle = options.background || "#ffffff";
+            drawTextWithBackground(displayValue, xPosition, yPosition, ctx);
+        }
+    }
+}
+function drawPieChartValues(chart, options, ctx) {
+    for (const dataset of chart._metasets) {
+        for (let i = 0; i < dataset._parsed.length; i++) {
+            const bar = dataset.data[i];
+            const { startAngle, endAngle, innerRadius, outerRadius } = bar;
+            const midAngle = (startAngle + endAngle) / 2;
+            const midRadius = (innerRadius + outerRadius) / 2;
+            const x = bar.x + midRadius * Math.cos(midAngle);
+            const y = bar.y + midRadius * Math.sin(midAngle) + 7;
+            ctx.fillStyle = chartFontColor(options.background);
+            ctx.strokeStyle = options.background || "#ffffff";
+            const value = options.callback(dataset._parsed[i]);
+            drawTextWithBackground(value, x, y, ctx);
+        }
+    }
+}
 
 /** This is a chartJS plugin that will draw connector lines between the bars of a Waterfall chart */
 const waterfallLinesPlugin = {
@@ -19154,9 +19202,10 @@ const PIVOT_VALUE = {
             return error;
         }
         if (!pivot.areDomainArgsFieldsValid(domainArgs)) {
+            const suggestion = _t("Consider using a dynamic pivot formula: %s. Or re-insert the static pivot from the Data menu.", `=PIVOT(${_pivotFormulaId})`);
             return {
                 value: CellErrorType.GenericError,
-                message: _t("Dimensions don't match the pivot definition"),
+                message: _t("Dimensions don't match the pivot definition") + ". " + suggestion,
             };
         }
         const domain = pivot.parseArgsToPivotDomain(domainArgs);
@@ -19183,9 +19232,10 @@ const PIVOT_HEADER = {
             return error;
         }
         if (!pivot.areDomainArgsFieldsValid(domainArgs)) {
+            const suggestion = _t("Consider using a dynamic pivot formula: %s. Or re-insert the static pivot from the Data menu.", `=PIVOT(${_pivotFormulaId})`);
             return {
                 value: CellErrorType.GenericError,
-                message: _t("Dimensions don't match the pivot definition"),
+                message: _t("Dimensions don't match the pivot definition") + ". " + suggestion,
             };
         }
         const domain = pivot.parseArgsToPivotDomain(domainArgs);
@@ -22361,6 +22411,7 @@ function insertTokenAfterArgSeparator(tokenAtCursor, value) {
         // replace the whole token
         start = tokenAtCursor.start;
     }
+    this.composer.stopComposerRangeSelection();
     this.composer.changeComposerCursorSelection(start, end);
     this.composer.replaceComposerCursorSelection(value);
 }
@@ -22378,6 +22429,7 @@ function insertTokenAfterLeftParenthesis(tokenAtCursor, value) {
         // replace the whole token
         start = tokenAtCursor.start;
     }
+    this.composer.stopComposerRangeSelection();
     this.composer.changeComposerCursorSelection(start, end);
     this.composer.replaceComposerCursorSelection(value);
 }
@@ -23402,7 +23454,7 @@ function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, tr
                         const xLabel = tooltipItem.dataset?.label || tooltipItem.label;
                         // tooltipItem.parsed can be an object or a number for pie charts
                         let yLabel = horizontalChart ? tooltipItem.parsed.x : tooltipItem.parsed.y;
-                        if (!yLabel) {
+                        if (yLabel === undefined || yLabel === null) {
                             yLabel = tooltipItem.parsed;
                         }
                         const toolTipFormat = !format && Math.abs(yLabel) >= 1000 ? "#,##" : format;
@@ -37193,6 +37245,8 @@ class PivotSidePanelStore extends SpreadsheetStore {
     mutators = ["reset", "deferUpdates", "applyUpdate", "discardPendingUpdate", "update"];
     updatesAreDeferred = false;
     draft = null;
+    notification = this.get(NotificationStore);
+    alreadyNotified = false;
     constructor(get, pivotId) {
         super(get);
         this.pivotId = pivotId;
@@ -37299,6 +37353,16 @@ class PivotSidePanelStore extends SpreadsheetStore {
                 pivot: this.draft,
             });
             this.draft = null;
+            if (!this.alreadyNotified && !this.isDynamicPivotInViewport()) {
+                const formulaId = this.getters.getPivotFormulaId(this.pivotId);
+                const pivotExample = `=PIVOT(${formulaId})`;
+                this.alreadyNotified = true;
+                this.notification.notifyUser({
+                    type: "info",
+                    text: _t("Pivot updates only work with dynamic pivot tables. Use %s or re-insert the static pivot from the Data menu.", pivotExample),
+                    sticky: false,
+                });
+            }
         }
     }
     discardPendingUpdate() {
@@ -37329,15 +37393,22 @@ class PivotSidePanelStore extends SpreadsheetStore {
             return;
         }
         const cleanedWithGranularity = this.addDefaultDateTimeGranularity(this.fields, cleanedDefinition);
-        if (this.updatesAreDeferred) {
-            this.draft = cleanedWithGranularity;
+        this.draft = cleanedWithGranularity;
+        if (!this.updatesAreDeferred) {
+            this.applyUpdate();
         }
-        else {
-            this.model.dispatch("UPDATE_PIVOT", {
-                pivotId: this.pivotId,
-                pivot: cleanedWithGranularity,
-            });
+    }
+    isDynamicPivotInViewport() {
+        const sheetId = this.getters.getActiveSheetId();
+        for (const col of this.getters.getSheetViewVisibleCols()) {
+            for (const row of this.getters.getSheetViewVisibleRows()) {
+                const isDynamicPivot = this.getters.isSpillPivotFormula({ sheetId, col, row });
+                if (isDynamicPivot) {
+                    return true;
+                }
+            }
         }
+        return false;
     }
     addDefaultDateTimeGranularity(fields, definition) {
         const { columns, rows } = definition;
@@ -46500,7 +46571,7 @@ function load(data, verboseImport) {
     if (!data) {
         return createEmptyWorkbookData();
     }
-    console.group("Loading data");
+    console.debug("### Loading data ###");
     const start = performance.now();
     if (data["[Content_Types].xml"]) {
         const reader = new XlsxReader(data);
@@ -46514,13 +46585,13 @@ function load(data, verboseImport) {
     // apply migrations, if needed
     if ("version" in data) {
         if (data.version < CURRENT_VERSION) {
-            console.info("Migrating data from version", data.version);
+            console.debug("Migrating data from version", data.version);
             data = migrate(data);
         }
     }
     data = repairData(data);
-    console.info("Data loaded in", performance.now() - start, "ms");
-    console.groupEnd();
+    console.debug("Data loaded in", performance.now() - start, "ms");
+    console.debug("###");
     return data;
 }
 function migrate(data) {
@@ -46529,7 +46600,7 @@ function migrate(data) {
     for (let i = index; i < MIGRATIONS.length; i++) {
         data = MIGRATIONS[i].applyMigration(data);
     }
-    console.info("Data migrated in", performance.now() - start, "ms");
+    console.debug("Data migrated in", performance.now() - start, "ms");
     return data;
 }
 const MIGRATIONS = [
@@ -52428,7 +52499,7 @@ class PivotCorePlugin extends CorePlugin {
             case "DUPLICATE_PIVOT": {
                 const { pivotId, newPivotId } = cmd;
                 const pivot = deepCopy(this.getPivotCore(pivotId).definition);
-                pivot.name = _t("%s (copy)", pivot.name);
+                pivot.name = cmd.duplicatedPivotName ?? pivot.name + " (copy)";
                 this.addPivot(newPivotId, pivot);
                 break;
             }
@@ -54089,7 +54160,7 @@ class Evaluator {
         cellsToCompute.addMany(arrayFormulasPositions);
         cellsToCompute.addMany(this.getCellsDependingOn(arrayFormulasPositions));
         this.evaluate(cellsToCompute);
-        console.info("evaluate Cells", performance.now() - start, "ms");
+        console.debug("evaluate Cells", performance.now() - start, "ms");
     }
     getArrayFormulasImpactedByChangesOf(positions) {
         const impactedPositions = this.createEmptyPositionSet();
@@ -54128,7 +54199,7 @@ class Evaluator {
         const start = performance.now();
         this.evaluatedCells = new PositionMap();
         this.evaluate(this.getAllCells());
-        console.info("evaluate all cells", performance.now() - start, "ms");
+        console.debug("evaluate all cells", performance.now() - start, "ms");
     }
     evaluateFormulaResult(sheetId, formulaString) {
         try {
@@ -57278,7 +57349,7 @@ class Session extends EventBus {
             this.onMessageReceived(message);
         }
         this.isReplayingInitialRevisions = false;
-        console.info("Replayed", numberOfCommands, "commands in", performance.now() - start, "ms");
+        console.debug("Replayed", numberOfCommands, "commands in", performance.now() - start, "ms");
     }
     /**
      * Notify the server that the user client left the collaborative session
@@ -57517,6 +57588,7 @@ class Session extends EventBus {
             case "REMOTE_REVISION":
             case "REVISION_REDONE":
             case "REVISION_UNDONE":
+            case "SNAPSHOT_CREATED":
                 return this.processedRevisions.has(message.nextRevisionId);
             default:
                 return false;
@@ -58032,12 +58104,13 @@ class InsertPivotPlugin extends UIPlugin {
         this.dispatch("DUPLICATE_PIVOT", {
             pivotId,
             newPivotId,
+            duplicatedPivotName: _t("%s (copy)", this.getters.getPivotCoreDefinition(pivotId).name),
         });
         const activeSheetId = this.getters.getActiveSheetId();
         const position = this.getters.getSheetIds().indexOf(activeSheetId) + 1;
         const formulaId = this.getters.getPivotFormulaId(newPivotId);
         const newPivotName = this.getters.getPivotName(newPivotId);
-        this.dispatch("CREATE_SHEET", {
+        const result = this.dispatch("CREATE_SHEET", {
             sheetId: newSheetId,
             name: this.getPivotDuplicateSheetName(_t("%(newPivotName)s (Pivot #%(formulaId)s)", {
                 newPivotName,
@@ -58045,20 +58118,23 @@ class InsertPivotPlugin extends UIPlugin {
             })),
             position,
         });
-        this.dispatch("ACTIVATE_SHEET", { sheetIdFrom: activeSheetId, sheetIdTo: newSheetId });
-        this.dispatch("UPDATE_CELL", {
-            sheetId: newSheetId,
-            col: 0,
-            row: 0,
-            content: `=PIVOT(${formulaId})`,
-        });
+        if (result.isSuccessful) {
+            this.dispatch("ACTIVATE_SHEET", { sheetIdFrom: activeSheetId, sheetIdTo: newSheetId });
+            this.dispatch("UPDATE_CELL", {
+                sheetId: newSheetId,
+                col: 0,
+                row: 0,
+                content: `=PIVOT(${formulaId})`,
+            });
+        }
     }
     getPivotDuplicateSheetName(pivotName) {
         let i = 1;
         const names = this.getters.getSheetIds().map((id) => this.getters.getSheetName(id));
-        let name = pivotName;
+        const sanitizedName = pivotName.replace(new RegExp(FORBIDDEN_IN_EXCEL_REGEX, "g"), " ");
+        let name = sanitizedName;
         while (names.includes(name)) {
-            name = `${pivotName} (${i})`;
+            name = `${sanitizedName} (${i})`;
             i++;
         }
         return name;
@@ -58639,9 +58715,12 @@ const invalidateTableStyleCommands = [
     "HIDE_COLUMNS_ROWS",
     "UNHIDE_COLUMNS_ROWS",
     "UNFOLD_HEADER_GROUP",
+    "UNGROUP_HEADERS",
     "FOLD_HEADER_GROUP",
     "FOLD_ALL_HEADER_GROUPS",
     "UNFOLD_ALL_HEADER_GROUPS",
+    "FOLD_HEADER_GROUPS_IN_ZONE",
+    "UNFOLD_HEADER_GROUPS_IN_ZONE",
     "CREATE_TABLE",
     "UPDATE_TABLE",
     "UPDATE_FILTER",
@@ -59957,6 +60036,8 @@ class FilterEvaluationPlugin extends UIPlugin {
             case "UNFOLD_HEADER_GROUP":
             case "FOLD_ALL_HEADER_GROUPS":
             case "UNFOLD_ALL_HEADER_GROUPS":
+            case "FOLD_HEADER_GROUPS_IN_ZONE":
+            case "UNFOLD_HEADER_GROUPS_IN_ZONE":
                 this.updateHiddenRows(cmd.sheetId);
                 break;
             case "UPDATE_FILTER":
@@ -65903,7 +65984,9 @@ class StateObserver {
  * The value does not matter, it can be hardcoded.
  */
 const catAxId = 17781237;
+const secondaryCatAxId = 17781238;
 const valAxId = 88853993;
+const secondaryValAxId = 88853994;
 function createChart(chart, chartSheetIndex, data) {
     const namespaces = [
         ["xmlns:r", RELATIONSHIP_NSR],
@@ -66219,8 +66302,8 @@ function addComboChart(chart) {
       <!-- each data marker in the series does not have a different color -->
       <c:varyColors val="0"/>
       ${barDataSetNode}
-      <c:axId val="${catAxId + (useRightAxisForBarSerie ? 1 : 0)}" />
-      <c:axId val="${valAxId + (useRightAxisForBarSerie ? 1 : 0)}" />
+      <c:axId val="${useRightAxisForBarSerie ? secondaryCatAxId : catAxId}" />
+      <c:axId val="${useRightAxisForBarSerie ? secondaryValAxId : valAxId}" />
     </c:barChart>
     ${leftDataSetsNodes.length
         ? escapeXml /*xml*/ `
@@ -66241,21 +66324,21 @@ function addComboChart(chart) {
           <!-- each data marker in the series does not have a different color -->
           <c:varyColors val="0"/>
           ${joinXmlNodes(rightDataSetsNodes)}
-          <c:axId val="${catAxId + 1}" />
-          <c:axId val="${valAxId + 1}" />
+          <c:axId val="${secondaryCatAxId}" />
+          <c:axId val="${secondaryValAxId}" />
         </c:lineChart>
       `
         : ""}
     ${!useRightAxisForBarSerie || leftDataSetsNodes.length
         ? escapeXml /*xml*/ `
-        ${addAx("b", "c:catAx", catAxId + 1, valAxId + 1, chart.axesDesign?.x?.title, chart.fontColor, leftDataSetsNodes.length ? 1 : 0)}
-        ${addAx("r", "c:valAx", valAxId + 1, catAxId + 1, chart.axesDesign?.y1?.title, chart.fontColor)}
+        ${addAx("b", "c:catAx", catAxId, valAxId, chart.axesDesign?.x?.title, chart.fontColor, leftDataSetsNodes.length ? 1 : 0)}
+        ${addAx("l", "c:valAx", valAxId, catAxId, chart.axesDesign?.y?.title, chart.fontColor)}
       `
         : ""}
     ${useRightAxisForBarSerie || rightDataSetsNodes.length
         ? escapeXml /*xml*/ `
-        ${addAx("b", "c:catAx", catAxId, valAxId, chart.axesDesign?.x?.title, chart.fontColor, leftDataSetsNodes.length || !useRightAxisForBarSerie ? 1 : 0)}
-        ${addAx("l", "c:valAx", valAxId, catAxId, chart.axesDesign?.y?.title, chart.fontColor)}
+        ${addAx("b", "c:catAx", secondaryCatAxId, secondaryValAxId, chart.axesDesign?.x?.title, chart.fontColor, leftDataSetsNodes.length || !useRightAxisForBarSerie ? 1 : 0)}
+        ${addAx("r", "c:valAx", secondaryValAxId, secondaryCatAxId, chart.axesDesign?.y1?.title, chart.fontColor)}
       `
         : ""}
   `;
@@ -67276,6 +67359,15 @@ function addTableColumns(table, sheetData) {
             ["id", i + 1], // id cannot be 0
             ["name", colName],
         ];
+        if (table.config.totalRow) {
+            // Note: To be 100% complete, we could also add a `totalsRowLabel` attribute for total strings, and a tag
+            // `<totalsRowFormula>` for the formula of the total. But those doesn't seem to be mandatory for Excel.
+            const colTotalXc = toXC(tableZone.left + i, tableZone.bottom);
+            const colTotalContent = sheetData.cells[colTotalXc]?.content;
+            if (colTotalContent?.startsWith("=")) {
+                colAttributes.push(["totalsRowFunction", "custom"]);
+            }
+        }
         columns.push(escapeXml /*xml*/ `<tableColumn ${formatAttributes(colAttributes)}/>`);
     }
     return escapeXml /*xml*/ `
@@ -67370,8 +67462,9 @@ function addRows(construct, data, sheet) {
                 }
                 else if (cell.content && cell.content !== "") {
                     const isTableHeader = isCellTableHeader(c, r, sheet);
+                    const isTableTotal = isCellTableTotal(c, r, sheet);
                     const isPlainText = !!(cell.format && data.formats[cell.format] === PLAIN_TEXT_FORMAT);
-                    ({ attrs: additionalAttrs, node: cellNode } = addContent(cell.content, construct.sharedStrings, isTableHeader || isPlainText));
+                    ({ attrs: additionalAttrs, node: cellNode } = addContent(cell.content, construct.sharedStrings, isTableHeader || isTableTotal || isPlainText));
                 }
                 attributes.push(...additionalAttrs);
                 // prettier-ignore
@@ -67405,6 +67498,16 @@ function isCellTableHeader(col, row, sheet) {
         return isInside(col, row, headerZone);
     });
 }
+function isCellTableTotal(col, row, sheet) {
+    return sheet.tables.some((table) => {
+        if (!table.config.totalRow) {
+            return false;
+        }
+        const zone = toZone(table.range);
+        const totalZone = { ...zone, top: zone.bottom };
+        return isInside(col, row, totalZone);
+    });
+}
 function addHyperlinks(construct, data, sheetIndex) {
     const sheet = data.sheets[sheetIndex];
     const cells = sheet.cells;
@@ -67856,7 +67959,7 @@ class Model extends EventBus {
     coreHandlers = [];
     constructor(data = {}, config = {}, stateUpdateMessages = [], uuidGenerator = new UuidGenerator(), verboseImport = true) {
         const start = performance.now();
-        console.group("Model creation");
+        console.debug("##### Model creation #####");
         super();
         setDefaultTranslationMethod();
         stateUpdateMessages = repairInitialMessages(data, stateUpdateMessages);
@@ -67883,7 +67986,6 @@ class Model extends EventBus {
             isReadonly: () => this.config.mode === "readonly" || this.config.mode === "dashboard",
             isDashboard: () => this.config.mode === "dashboard",
         };
-        this.uuidGenerator.setIsFastStrategy(true);
         // Initiate stream processor
         this.selection = new SelectionStreamProcessorImpl(this.getters);
         this.coreHandlers.push(this.range);
@@ -67929,16 +68031,16 @@ class Model extends EventBus {
         this.joinSession();
         if (config.snapshotRequested) {
             const startSnapshot = performance.now();
-            console.info("Snapshot requested");
+            console.debug("Snapshot requested");
             this.session.snapshot(this.exportData());
             this.garbageCollectExternalResources();
-            console.info("Snapshot taken in", performance.now() - startSnapshot, "ms");
+            console.debug("Snapshot taken in", performance.now() - startSnapshot, "ms");
         }
         // mark all models as "raw", so they will not be turned into reactive objects
         // by owl, since we do not rely on reactivity
         markRaw(this);
-        console.info("Model created in", performance.now() - start, "ms");
-        console.groupEnd();
+        console.debug("Model created in", performance.now() - start, "ms");
+        console.debug("######");
     }
     joinSession() {
         this.session.join(this.config.client);
@@ -68161,7 +68263,7 @@ class Model extends EventBus {
                     this.finalize();
                     const time = performance.now() - start;
                     if (time > 5) {
-                        console.info(type, time, "ms");
+                        console.debug(type, time, "ms");
                     }
                 });
                 this.session.save(command, commands, changes);
@@ -68504,6 +68606,6 @@ const constants = {
 export { AbstractCellClipboardHandler, AbstractChart, AbstractFigureClipboardHandler, CellErrorType, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, PivotRuntimeDefinition, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, SpreadsheetPivotTable, UIPlugin, __info__, addFunction, addRenderingLayer, astToFormula, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, stores, tokenColors, tokenize };
 
 
-__info__.version = "17.4.8";
-__info__.date = "2024-09-17T08:10:18.777Z";
-__info__.hash = "caad8bd";
+__info__.version = "17.4.10";
+__info__.date = "2024-10-24T08:54:56.262Z";
+__info__.hash = "c82d9c1";