@odoo/o-spreadsheet 17.4.32 → 17.4.33

package/dist/o-spreadsheet.cjs.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.4.32
- * @date 2025-04-25T08:06:59.937Z
- * @hash c370ddf
+ * @version 17.4.33
+ * @date 2025-05-02T12:30:31.263Z
+ * @hash 3ba00e6
  */
 
 'use strict';
@@ -2362,6 +2362,7 @@ exports.CommandResult = void 0;
     CommandResult["InvalidTableResize"] = "InvalidTableResize";
     CommandResult["PivotIdNotFound"] = "PivotIdNotFound";
     CommandResult["EmptyName"] = "EmptyName";
+    CommandResult["InvalidPivotDataSet"] = "InvalidPivotDataSet";
 })(exports.CommandResult || (exports.CommandResult = {}));
 
 const PLAIN_TEXT_FORMAT = "@"; // see OpenXML spec §18.8.31
@@ -12243,6 +12244,7 @@ class ChartJsComponent extends owl.Component {
     canvas = owl.useRef("graphContainer");
     chart;
     currentRuntime;
+    currentDevicePixelRatio = window.devicePixelRatio;
     get background() {
         return this.chartRuntime.background;
     }
@@ -12276,11 +12278,11 @@ class ChartJsComponent extends owl.Component {
                 }
                 this.currentRuntime = runtime;
             }
+            else if (this.currentDevicePixelRatio !== window.devicePixelRatio) {
+                this.currentDevicePixelRatio = window.devicePixelRatio;
+                this.updateChartJs(deepCopy(this.currentRuntime));
+            }
         });
-        owl.useEffect(() => {
-            this.currentRuntime = this.chartRuntime;
-            this.updateChartJs(deepCopy(this.currentRuntime));
-        }, () => [window.devicePixelRatio]);
     }
     createChart(chartData) {
         const canvas = this.canvas.el;
@@ -22742,18 +22744,28 @@ linkMenuRegistry.add("sheet", {
 function useInterval(callback, delay) {
     let intervalId;
     const { setInterval, clearInterval } = window;
+    const pause = () => {
+        clearInterval(intervalId);
+        intervalId = undefined;
+    };
+    const safeCallback = () => {
+        try {
+            callback();
+        }
+        catch (e) {
+            pause();
+            throw e;
+        }
+    };
     owl.useEffect(() => {
-        intervalId = setInterval(callback, delay);
+        intervalId = setInterval(safeCallback, delay);
         return () => clearInterval(intervalId);
     }, () => [delay]);
     return {
-        pause: () => {
-            clearInterval(intervalId);
-            intervalId = undefined;
-        },
+        pause,
         resume: () => {
             if (intervalId === undefined) {
-                intervalId = setInterval(callback, delay);
+                intervalId = setInterval(safeCallback, delay);
             }
         },
     };
@@ -25336,9 +25348,6 @@ class BarChart extends AbstractChart {
         };
     }
     getDefinitionForExcel() {
-        // Excel does not support aggregating labels
-        if (this.aggregated)
-            return undefined;
         const dataSets = this.dataSets
             .map((ds) => toExcelDataset(this.getters, ds))
             .filter((ds) => ds.range !== "" && ds.range !== CellErrorType.InvalidReference);
@@ -26415,9 +26424,6 @@ class LineChart extends AbstractChart {
         return new LineChart(definition, this.sheetId, this.getters);
     }
     getDefinitionForExcel() {
-        // Excel does not support aggregating labels
-        if (this.aggregated)
-            return undefined;
         const dataSets = this.dataSets
             .map((ds) => toExcelDataset(this.getters, ds))
             .filter((ds) => ds.range !== "" && ds.range !== CellErrorType.InvalidReference);
@@ -26528,9 +26534,6 @@ class PieChart extends AbstractChart {
         return new PieChart(definition, sheetId, this.getters);
     }
     getDefinitionForExcel() {
-        // Excel does not support aggregating labels
-        if (this.aggregated)
-            return undefined;
         const dataSets = this.dataSets
             .map((ds) => toExcelDataset(this.getters, ds))
             .filter((ds) => ds.range !== "" && ds.range !== CellErrorType.InvalidReference);
@@ -41000,7 +41003,7 @@ css /* scss */ `
     position: absolute;
     top: 0;
     left: ${HEADER_WIDTH}px;
-    right: 0;
+    right: ${SCROLLBAR_WIDTH}px;
     height: ${HEADER_HEIGHT}px;
     &.o-dragging {
       cursor: grabbing;
@@ -41166,9 +41169,8 @@ css /* scss */ `
     position: absolute;
     top: ${HEADER_HEIGHT}px;
     left: 0;
-    right: 0;
+    bottom: ${SCROLLBAR_WIDTH}px;
     width: ${HEADER_WIDTH}px;
-    height: calc(100% - ${HEADER_HEIGHT + SCROLLBAR_WIDTH}px);
     &.o-dragging {
       cursor: grabbing;
     }
@@ -53133,6 +53135,15 @@ function adaptPivotRange(range, applyChange) {
     }
 }
 class SpreadsheetPivotCorePlugin extends CorePlugin {
+    allowDispatch(cmd) {
+        switch (cmd.type) {
+            case "ADD_PIVOT":
+            case "UPDATE_PIVOT":
+                const definition = cmd.pivot;
+                return this.checkDataSetValidity(definition);
+        }
+        return "Success" /* CommandResult.Success */;
+    }
     adaptRanges(applyChange) {
         for (const pivotId of this.getters.getPivotIds()) {
             const definition = this.getters.getPivotCoreDefinition(pivotId);
@@ -53151,6 +53162,16 @@ class SpreadsheetPivotCorePlugin extends CorePlugin {
             }
         }
     }
+    checkDataSetValidity(definition) {
+        if (definition.type === "SPREADSHEET" && definition.dataSet) {
+            const { zone, sheetId } = definition.dataSet;
+            if (!sheetId || !this.getters.tryGetSheet(sheetId) || !zone || !isZoneValid(zone)) {
+                return "InvalidDataSet" /* CommandResult.InvalidDataSet */;
+            }
+            return this.getters.checkZonesExistInSheet(sheetId, [zone]);
+        }
+        return "Success" /* CommandResult.Success */;
+    }
 }
 
 class TableStylePlugin extends CorePlugin {
@@ -55986,7 +56007,7 @@ class DynamicTablesPlugin extends UIPlugin {
     tables = {};
     handle(cmd) {
         if (invalidateEvaluationCommands.has(cmd.type) ||
-            (cmd.type === "UPDATE_CELL" && "content" in cmd) ||
+            (cmd.type === "UPDATE_CELL" && ("content" in cmd || "format" in cmd)) ||
             cmd.type === "EVALUATE_CELLS") {
             this.tables = {};
             return;
@@ -59123,7 +59144,7 @@ class TableComputedStylePlugin extends UIPlugin {
     tableStyles = {};
     handle(cmd) {
         if (invalidateEvaluationCommands.has(cmd.type) ||
-            (cmd.type === "UPDATE_CELL" && "content" in cmd) ||
+            (cmd.type === "UPDATE_CELL" && ("content" in cmd || "format" in cmd)) ||
             cmd.type === "EVALUATE_CELLS") {
             this.tableStyles = {};
             return;
@@ -61094,6 +61115,8 @@ class GridSelectionPlugin extends UIPlugin {
             });
             this.selectCell(col, row);
         }
+        const { col, row } = this.gridSelection.anchor.cell;
+        this.moveClient({ sheetId: this.activeSheet.id, col, row });
     }
     /**
      * Ensure selections are not outside sheet boundaries.
@@ -61826,8 +61849,11 @@ class SheetViewPlugin extends UIPlugin {
             case "REMOVE_TABLE":
             case "UPDATE_TABLE":
             case "UPDATE_FILTER":
-                this.sheetsWithDirtyViewports.add(cmd.sheetId);
-                break;
+            case "UNFREEZE_ROWS":
+            case "UNFREEZE_COLUMNS":
+            case "FREEZE_COLUMNS":
+            case "FREEZE_ROWS":
+            case "UNFREEZE_COLUMNS_ROWS":
             case "REMOVE_COLUMNS_ROWS":
             case "RESIZE_COLUMNS_ROWS":
             case "HIDE_COLUMNS_ROWS":
@@ -61840,11 +61866,9 @@ class SheetViewPlugin extends UIPlugin {
             case "FOLD_HEADER_GROUPS_IN_ZONE":
             case "UNFOLD_HEADER_GROUPS_IN_ZONE":
             case "UNFOLD_ALL_HEADER_GROUPS":
-            case "FOLD_ALL_HEADER_GROUPS": {
-                const sheetId = "sheetId" in cmd ? cmd.sheetId : this.getters.getActiveSheetId();
-                this.sheetsWithDirtyViewports.add(sheetId);
+            case "FOLD_ALL_HEADER_GROUPS":
+                this.sheetsWithDirtyViewports.add(cmd.sheetId);
                 break;
-            }
             case "UPDATE_CELL":
                 // update cell content or format can change hidden rows because of data filters
                 if ("content" in cmd || "format" in cmd || cmd.style?.fontSize !== undefined) {
@@ -61860,13 +61884,6 @@ class SheetViewPlugin extends UIPlugin {
             case "ACTIVATE_SHEET":
                 this.sheetsWithDirtyViewports.add(cmd.sheetIdTo);
                 break;
-            case "UNFREEZE_ROWS":
-            case "UNFREEZE_COLUMNS":
-            case "FREEZE_COLUMNS":
-            case "FREEZE_ROWS":
-            case "UNFREEZE_COLUMNS_ROWS":
-                this.resetViewports(this.getters.getActiveSheetId());
-                break;
             case "DELETE_SHEET":
                 this.sheetsWithDirtyViewports.delete(cmd.sheetId);
                 break;
@@ -63022,7 +63039,7 @@ class AggregateStatisticsStore extends SpreadsheetStore {
     }
     handle(cmd) {
         if (invalidateEvaluationCommands.has(cmd.type) ||
-            (cmd.type === "UPDATE_CELL" && "content" in cmd)) {
+            (cmd.type === "UPDATE_CELL" && ("content" in cmd || "format" in cmd))) {
             this.isDirty = true;
         }
         switch (cmd.type) {
@@ -69389,6 +69406,6 @@ exports.tokenColors = tokenColors;
 exports.tokenize = tokenize;
 
 
-__info__.version = "17.4.32";
-__info__.date = "2025-04-25T08:06:59.937Z";
-__info__.hash = "c370ddf";
+__info__.version = "17.4.33";
+__info__.date = "2025-05-02T12:30:31.263Z";
+__info__.hash = "3ba00e6";

package/dist/o-spreadsheet.d.ts

@@ -1462,7 +1462,8 @@ declare const enum CommandResult {
     SheetIsHidden = "SheetIsHidden",
     InvalidTableResize = "InvalidTableResize",
     PivotIdNotFound = "PivotIdNotFound",
-    EmptyName = "EmptyName"
+    EmptyName = "EmptyName",
+    InvalidPivotDataSet = "InvalidPivotDataSet"
 }
 interface CommandHandler<T> {
     allowDispatch(command: T): CommandResult | CommandResult[];
@@ -7989,6 +7990,7 @@ declare class ChartJsComponent extends Component<Props$J, SpreadsheetChildEnv> {
     private canvas;
     private chart?;
     private currentRuntime;
+    private currentDevicePixelRatio;
     get background(): string;
     get canvasStyle(): string;
     get chartRuntime(): ChartJSRuntime;

package/dist/o-spreadsheet.esm.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.4.32
- * @date 2025-04-25T08:06:59.937Z
- * @hash c370ddf
+ * @version 17.4.33
+ * @date 2025-05-02T12:30:31.263Z
+ * @hash 3ba00e6
  */
 
 import { useEnv, useSubEnv, onWillUnmount, useComponent, status, Component, useRef, onMounted, useEffect, useState, onPatched, onWillPatch, onWillUpdateProps, useExternalListener, onWillStart, xml, useChildSubEnv, markRaw, toRaw } from '@odoo/owl';
@@ -2360,6 +2360,7 @@ var CommandResult;
     CommandResult["InvalidTableResize"] = "InvalidTableResize";
     CommandResult["PivotIdNotFound"] = "PivotIdNotFound";
     CommandResult["EmptyName"] = "EmptyName";
+    CommandResult["InvalidPivotDataSet"] = "InvalidPivotDataSet";
 })(CommandResult || (CommandResult = {}));
 
 const PLAIN_TEXT_FORMAT = "@"; // see OpenXML spec §18.8.31
@@ -12241,6 +12242,7 @@ class ChartJsComponent extends Component {
     canvas = useRef("graphContainer");
     chart;
     currentRuntime;
+    currentDevicePixelRatio = window.devicePixelRatio;
     get background() {
         return this.chartRuntime.background;
     }
@@ -12274,11 +12276,11 @@ class ChartJsComponent extends Component {
                 }
                 this.currentRuntime = runtime;
             }
+            else if (this.currentDevicePixelRatio !== window.devicePixelRatio) {
+                this.currentDevicePixelRatio = window.devicePixelRatio;
+                this.updateChartJs(deepCopy(this.currentRuntime));
+            }
         });
-        useEffect(() => {
-            this.currentRuntime = this.chartRuntime;
-            this.updateChartJs(deepCopy(this.currentRuntime));
-        }, () => [window.devicePixelRatio]);
     }
     createChart(chartData) {
         const canvas = this.canvas.el;
@@ -22740,18 +22742,28 @@ linkMenuRegistry.add("sheet", {
 function useInterval(callback, delay) {
     let intervalId;
     const { setInterval, clearInterval } = window;
+    const pause = () => {
+        clearInterval(intervalId);
+        intervalId = undefined;
+    };
+    const safeCallback = () => {
+        try {
+            callback();
+        }
+        catch (e) {
+            pause();
+            throw e;
+        }
+    };
     useEffect(() => {
-        intervalId = setInterval(callback, delay);
+        intervalId = setInterval(safeCallback, delay);
         return () => clearInterval(intervalId);
     }, () => [delay]);
     return {
-        pause: () => {
-            clearInterval(intervalId);
-            intervalId = undefined;
-        },
+        pause,
         resume: () => {
             if (intervalId === undefined) {
-                intervalId = setInterval(callback, delay);
+                intervalId = setInterval(safeCallback, delay);
             }
         },
     };
@@ -25334,9 +25346,6 @@ class BarChart extends AbstractChart {
         };
     }
     getDefinitionForExcel() {
-        // Excel does not support aggregating labels
-        if (this.aggregated)
-            return undefined;
         const dataSets = this.dataSets
             .map((ds) => toExcelDataset(this.getters, ds))
             .filter((ds) => ds.range !== "" && ds.range !== CellErrorType.InvalidReference);
@@ -26413,9 +26422,6 @@ class LineChart extends AbstractChart {
         return new LineChart(definition, this.sheetId, this.getters);
     }
     getDefinitionForExcel() {
-        // Excel does not support aggregating labels
-        if (this.aggregated)
-            return undefined;
         const dataSets = this.dataSets
             .map((ds) => toExcelDataset(this.getters, ds))
             .filter((ds) => ds.range !== "" && ds.range !== CellErrorType.InvalidReference);
@@ -26526,9 +26532,6 @@ class PieChart extends AbstractChart {
         return new PieChart(definition, sheetId, this.getters);
     }
     getDefinitionForExcel() {
-        // Excel does not support aggregating labels
-        if (this.aggregated)
-            return undefined;
         const dataSets = this.dataSets
             .map((ds) => toExcelDataset(this.getters, ds))
             .filter((ds) => ds.range !== "" && ds.range !== CellErrorType.InvalidReference);
@@ -40998,7 +41001,7 @@ css /* scss */ `
     position: absolute;
     top: 0;
     left: ${HEADER_WIDTH}px;
-    right: 0;
+    right: ${SCROLLBAR_WIDTH}px;
     height: ${HEADER_HEIGHT}px;
     &.o-dragging {
       cursor: grabbing;
@@ -41164,9 +41167,8 @@ css /* scss */ `
     position: absolute;
     top: ${HEADER_HEIGHT}px;
     left: 0;
-    right: 0;
+    bottom: ${SCROLLBAR_WIDTH}px;
     width: ${HEADER_WIDTH}px;
-    height: calc(100% - ${HEADER_HEIGHT + SCROLLBAR_WIDTH}px);
     &.o-dragging {
       cursor: grabbing;
     }
@@ -53131,6 +53133,15 @@ function adaptPivotRange(range, applyChange) {
     }
 }
 class SpreadsheetPivotCorePlugin extends CorePlugin {
+    allowDispatch(cmd) {
+        switch (cmd.type) {
+            case "ADD_PIVOT":
+            case "UPDATE_PIVOT":
+                const definition = cmd.pivot;
+                return this.checkDataSetValidity(definition);
+        }
+        return "Success" /* CommandResult.Success */;
+    }
     adaptRanges(applyChange) {
         for (const pivotId of this.getters.getPivotIds()) {
             const definition = this.getters.getPivotCoreDefinition(pivotId);
@@ -53149,6 +53160,16 @@ class SpreadsheetPivotCorePlugin extends CorePlugin {
             }
         }
     }
+    checkDataSetValidity(definition) {
+        if (definition.type === "SPREADSHEET" && definition.dataSet) {
+            const { zone, sheetId } = definition.dataSet;
+            if (!sheetId || !this.getters.tryGetSheet(sheetId) || !zone || !isZoneValid(zone)) {
+                return "InvalidDataSet" /* CommandResult.InvalidDataSet */;
+            }
+            return this.getters.checkZonesExistInSheet(sheetId, [zone]);
+        }
+        return "Success" /* CommandResult.Success */;
+    }
 }
 
 class TableStylePlugin extends CorePlugin {
@@ -55984,7 +56005,7 @@ class DynamicTablesPlugin extends UIPlugin {
     tables = {};
     handle(cmd) {
         if (invalidateEvaluationCommands.has(cmd.type) ||
-            (cmd.type === "UPDATE_CELL" && "content" in cmd) ||
+            (cmd.type === "UPDATE_CELL" && ("content" in cmd || "format" in cmd)) ||
             cmd.type === "EVALUATE_CELLS") {
             this.tables = {};
             return;
@@ -59121,7 +59142,7 @@ class TableComputedStylePlugin extends UIPlugin {
     tableStyles = {};
     handle(cmd) {
         if (invalidateEvaluationCommands.has(cmd.type) ||
-            (cmd.type === "UPDATE_CELL" && "content" in cmd) ||
+            (cmd.type === "UPDATE_CELL" && ("content" in cmd || "format" in cmd)) ||
             cmd.type === "EVALUATE_CELLS") {
             this.tableStyles = {};
             return;
@@ -61092,6 +61113,8 @@ class GridSelectionPlugin extends UIPlugin {
             });
             this.selectCell(col, row);
         }
+        const { col, row } = this.gridSelection.anchor.cell;
+        this.moveClient({ sheetId: this.activeSheet.id, col, row });
     }
     /**
      * Ensure selections are not outside sheet boundaries.
@@ -61824,8 +61847,11 @@ class SheetViewPlugin extends UIPlugin {
             case "REMOVE_TABLE":
             case "UPDATE_TABLE":
             case "UPDATE_FILTER":
-                this.sheetsWithDirtyViewports.add(cmd.sheetId);
-                break;
+            case "UNFREEZE_ROWS":
+            case "UNFREEZE_COLUMNS":
+            case "FREEZE_COLUMNS":
+            case "FREEZE_ROWS":
+            case "UNFREEZE_COLUMNS_ROWS":
             case "REMOVE_COLUMNS_ROWS":
             case "RESIZE_COLUMNS_ROWS":
             case "HIDE_COLUMNS_ROWS":
@@ -61838,11 +61864,9 @@ class SheetViewPlugin extends UIPlugin {
             case "FOLD_HEADER_GROUPS_IN_ZONE":
             case "UNFOLD_HEADER_GROUPS_IN_ZONE":
             case "UNFOLD_ALL_HEADER_GROUPS":
-            case "FOLD_ALL_HEADER_GROUPS": {
-                const sheetId = "sheetId" in cmd ? cmd.sheetId : this.getters.getActiveSheetId();
-                this.sheetsWithDirtyViewports.add(sheetId);
+            case "FOLD_ALL_HEADER_GROUPS":
+                this.sheetsWithDirtyViewports.add(cmd.sheetId);
                 break;
-            }
             case "UPDATE_CELL":
                 // update cell content or format can change hidden rows because of data filters
                 if ("content" in cmd || "format" in cmd || cmd.style?.fontSize !== undefined) {
@@ -61858,13 +61882,6 @@ class SheetViewPlugin extends UIPlugin {
             case "ACTIVATE_SHEET":
                 this.sheetsWithDirtyViewports.add(cmd.sheetIdTo);
                 break;
-            case "UNFREEZE_ROWS":
-            case "UNFREEZE_COLUMNS":
-            case "FREEZE_COLUMNS":
-            case "FREEZE_ROWS":
-            case "UNFREEZE_COLUMNS_ROWS":
-                this.resetViewports(this.getters.getActiveSheetId());
-                break;
             case "DELETE_SHEET":
                 this.sheetsWithDirtyViewports.delete(cmd.sheetId);
                 break;
@@ -63020,7 +63037,7 @@ class AggregateStatisticsStore extends SpreadsheetStore {
     }
     handle(cmd) {
         if (invalidateEvaluationCommands.has(cmd.type) ||
-            (cmd.type === "UPDATE_CELL" && "content" in cmd)) {
+            (cmd.type === "UPDATE_CELL" && ("content" in cmd || "format" in cmd))) {
             this.isDirty = true;
         }
         switch (cmd.type) {
@@ -69344,6 +69361,6 @@ const constants = {
 export { AbstractCellClipboardHandler, AbstractChart, AbstractFigureClipboardHandler, CellErrorType, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, PivotRuntimeDefinition, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, SpreadsheetPivotTable, UIPlugin, __info__, addFunction, addRenderingLayer, astToFormula, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, stores, tokenColors, tokenize };
 
 
-__info__.version = "17.4.32";
-__info__.date = "2025-04-25T08:06:59.937Z";
-__info__.hash = "c370ddf";
+__info__.version = "17.4.33";
+__info__.date = "2025-05-02T12:30:31.263Z";
+__info__.hash = "3ba00e6";