@odoo/o-spreadsheet 17.4.14 → 17.4.16

package/dist/o-spreadsheet.cjs.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.4.14
- * @date 2024-11-28T09:08:12.462Z
- * @hash 81bf386
+ * @version 17.4.16
+ * @date 2024-12-19T07:50:04.021Z
+ * @hash 6b827fc
  */
 
 'use strict';
@@ -306,8 +306,8 @@ const LINE_FILL_TRANSPARENCY = 0.4;
 const DEBOUNCE_TIME = 200;
 const MESSAGE_VERSION = 1;
 // Sheets
-const FORBIDDEN_SHEET_CHARS = ["'", "*", "?", "/", "\\", "[", "]"];
-const FORBIDDEN_IN_EXCEL_REGEX = /'|\*|\?|\/|\\|\[|\]/;
+const FORBIDDEN_SHEETNAME_CHARS = ["'", "*", "?", "/", "\\", "[", "]"];
+const FORBIDDEN_SHEETNAME_CHARS_IN_EXCEL_REGEX = /'|\*|\?|\/|\\|\[|\]/;
 // Cells
 const FORMULA_REF_IDENTIFIER = "|";
 // Components
@@ -353,6 +353,7 @@ const PIVOT_TABLE_CONFIG = {
 //------------------------------------------------------------------------------
 // Miscellaneous
 //------------------------------------------------------------------------------
+const sanitizeSheetNameRegex = new RegExp(FORBIDDEN_SHEETNAME_CHARS_IN_EXCEL_REGEX, "g");
 /**
  * Remove quotes from a quoted string
  * ```js
@@ -448,6 +449,10 @@ function getCanonicalSheetName(sheetName) {
     }
     return sheetName;
 }
+/** Replace the excel-excluded characters of a sheetName */
+function sanitizeSheetName(sheetName, replacementChar = " ") {
+    return sheetName.replace(sanitizeSheetNameRegex, replacementChar);
+}
 function clip(val, min, max) {
     return val < min ? min : val > max ? max : val;
 }
@@ -763,6 +768,7 @@ function removeFalsyAttributes(obj) {
  * https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions/Character_Classes
  */
 const whiteSpaceSpecialCharacters = [
+    " ",
     "\t",
     "\f",
     "\v",
@@ -777,17 +783,15 @@ const whiteSpaceSpecialCharacters = [
     String.fromCharCode(parseInt("3000", 16)),
     String.fromCharCode(parseInt("feff", 16)),
 ];
-const whiteSpaceRegexp = new RegExp(whiteSpaceSpecialCharacters.join("|") + "|(\r\n|\r|\n)", "g");
+const whiteSpaceRegexp = new RegExp(whiteSpaceSpecialCharacters.join("|"), "g");
+const newLineRegexp = /(\r\n|\r)/g;
 /**
- * Replace all the special spaces in a string (non-breaking, tabs, ...) by normal spaces, and all the
- * different newlines types by \n.
+ * Replace all different newlines characters by \n
  */
-function replaceSpecialSpaces(text) {
+function replaceNewLines(text) {
     if (!text)
         return "";
-    if (!whiteSpaceRegexp.test(text))
-        return text;
-    return text.replace(whiteSpaceRegexp, (match, newLine) => (newLine ? NEWLINE : " "));
+    return text.replace(newLineRegexp, NEWLINE);
 }
 /**
  * Determine if the numbers are consecutive.
@@ -5679,7 +5683,7 @@ class BorderClipboardHandler extends AbstractCellClipboardHandler {
 const POSTFIX_UNARY_OPERATORS = ["%"];
 const OPERATORS = "+,-,*,/,:,=,<>,>=,>,<=,<,^,&".split(",").concat(POSTFIX_UNARY_OPERATORS);
 function tokenize(str, locale = DEFAULT_LOCALE) {
-    str = replaceSpecialSpaces(str);
+    str = replaceNewLines(str);
     const chars = new TokenizingChars(str);
     const result = [];
     while (!chars.isOver()) {
@@ -5826,12 +5830,12 @@ function tokenizeSpace(chars) {
     if (length) {
         return { type: "SPACE", value: NEWLINE.repeat(length) };
     }
-    while (chars.current === " ") {
-        length++;
-        chars.shift();
+    let spaces = "";
+    while (chars.current && chars.current.match(whiteSpaceRegexp)) {
+        spaces += chars.shift();
     }
-    if (length) {
-        return { type: "SPACE", value: " ".repeat(length) };
+    if (spaces) {
+        return { type: "SPACE", value: spaces };
     }
     return null;
 }
@@ -38561,6 +38565,7 @@ css /* scss */ `
     }
   }
 `;
+const DEFAULT_TABLE_STYLE_COLOR = "#3C78D8";
 class TableStyleEditorPanel extends owl.Component {
     static template = "o-spreadsheet-TableStyleEditorPanel";
     static components = { Section, RoundColorPicker, TableStylePreview };
@@ -38579,7 +38584,7 @@ class TableStyleEditorPanel extends owl.Component {
             : null;
         return {
             pickerOpened: false,
-            primaryColor: editedStyle?.primaryColor || "#3C78D8",
+            primaryColor: editedStyle?.primaryColor || DEFAULT_TABLE_STYLE_COLOR,
             selectedTemplateName: editedStyle?.templateName || "lightColoredText",
             styleName: editedStyle?.displayName || this.env.model.getters.getNewCustomTableStyleName(),
         };
@@ -38588,7 +38593,7 @@ class TableStyleEditorPanel extends owl.Component {
         this.state.pickerOpened = !this.state.pickerOpened;
     }
     onColorPicked(color) {
-        this.state.primaryColor = color;
+        this.state.primaryColor = isColorValid(color) ? color : DEFAULT_TABLE_STYLE_COLOR;
         this.state.pickerOpened = false;
     }
     onTemplatePicked(templateName) {
@@ -39935,6 +39940,7 @@ class FiguresContainer extends owl.Component {
         draggedFigure: undefined,
         horizontalSnap: undefined,
         verticalSnap: undefined,
+        cancelDnd: undefined,
     });
     setup() {
         owl.onMounted(() => {
@@ -39947,12 +39953,28 @@ class FiguresContainer extends owl.Component {
             // new rendering
             this.render();
         });
+        owl.onWillUpdateProps(() => {
+            const sheetId = this.env.model.getters.getActiveSheetId();
+            const draggedFigureId = this.dnd.draggedFigure?.id;
+            if (draggedFigureId && !this.env.model.getters.getFigure(sheetId, draggedFigureId)) {
+                if (this.dnd.cancelDnd) {
+                    this.dnd.cancelDnd();
+                }
+                this.dnd.draggedFigure = undefined;
+                this.dnd.horizontalSnap = undefined;
+                this.dnd.verticalSnap = undefined;
+                this.dnd.cancelDnd = undefined;
+            }
+        });
     }
     getVisibleFigures() {
         const visibleFigures = this.env.model.getters.getVisibleFigures();
         if (this.dnd.draggedFigure &&
             !visibleFigures.some((figure) => figure.id === this.dnd.draggedFigure?.id)) {
-            visibleFigures.push(this.env.model.getters.getFigure(this.env.model.getters.getActiveSheetId(), this.dnd.draggedFigure?.id));
+            const draggedFigure = this.env.model.getters.getFigure(this.env.model.getters.getActiveSheetId(), this.dnd.draggedFigure?.id);
+            if (draggedFigure) {
+                visibleFigures.push(draggedFigure);
+            }
         }
         return visibleFigures;
     }
@@ -40071,7 +40093,7 @@ class FiguresContainer extends owl.Component {
             this.dnd.verticalSnap = undefined;
             this.env.model.dispatch("UPDATE_FIGURE", { sheetId, id: figure.id, x, y });
         };
-        startDnd(onMouseMove, onMouseUp);
+        this.dnd.cancelDnd = startDnd(onMouseMove, onMouseUp);
     }
     /**
      * Initialize the resize of a figure with mouse movements
@@ -40119,7 +40141,7 @@ class FiguresContainer extends owl.Component {
             this.dnd.horizontalSnap = undefined;
             this.dnd.verticalSnap = undefined;
         };
-        startDnd(onMouseMove, onMouseUp);
+        this.dnd.cancelDnd = startDnd(onMouseMove, onMouseUp);
     }
     getOtherFigures(figId) {
         return this.getVisibleFigures().filter((f) => f.id !== figId);
@@ -46727,13 +46749,12 @@ const MIGRATIONS = [
         to: 8,
         applyMigration(data) {
             const namesTaken = [];
-            const globalForbiddenInExcel = new RegExp(FORBIDDEN_IN_EXCEL_REGEX, "g");
             for (let sheet of data.sheets || []) {
                 if (!sheet.name) {
                     continue;
                 }
                 const oldName = sheet.name;
-                const escapedName = oldName.replace(globalForbiddenInExcel, "_");
+                const escapedName = sanitizeSheetName(oldName, "_");
                 let i = 1;
                 let newName = escapedName;
                 while (namesTaken.includes(newName)) {
@@ -48232,7 +48253,7 @@ class CellPlugin extends CorePlugin {
         const before = this.getters.getCell({ sheetId, col, row });
         const hasContent = "content" in after || "formula" in after;
         // Compute the new cell properties
-        const afterContent = hasContent ? replaceSpecialSpaces(after?.content) : before?.content || "";
+        const afterContent = hasContent ? replaceNewLines(after?.content) : before?.content || "";
         let style;
         if (after.style !== undefined) {
             style = after.style || undefined;
@@ -51093,6 +51114,9 @@ class SheetPlugin extends CorePlugin {
         };
     }
     getUnboundedZone(sheetId, zone) {
+        if (zone.bottom === undefined || zone.right === undefined) {
+            return zone;
+        }
         const isFullRow = zone.left === 0 && zone.right === this.getNumberCols(sheetId) - 1;
         const isFullCol = zone.top === 0 && zone.bottom === this.getNumberRows(sheetId) - 1;
         return {
@@ -51258,7 +51282,7 @@ class SheetPlugin extends CorePlugin {
         if (orderedSheetIds.find((id) => sheets[id]?.name.toLowerCase() === name && id !== cmd.sheetId)) {
             return "DuplicatedSheetName" /* CommandResult.DuplicatedSheetName */;
         }
-        if (FORBIDDEN_IN_EXCEL_REGEX.test(name)) {
+        if (FORBIDDEN_SHEETNAME_CHARS_IN_EXCEL_REGEX.test(name)) {
             return "ForbiddenCharactersInSheetName" /* CommandResult.ForbiddenCharactersInSheetName */;
         }
         return "Success" /* CommandResult.Success */;
@@ -56047,11 +56071,13 @@ class PivotUIPlugin extends UIPlugin {
             return EMPTY_PIVOT_CELL;
         }
         if (functionName === "PIVOT") {
-            const includeTotal = args[2] === false ? false : undefined;
-            const includeColumnHeaders = args[3] === false ? false : undefined;
+            const includeTotal = toScalar(args[2]);
+            const shouldIncludeTotal = includeTotal === undefined ? true : toBoolean(includeTotal);
+            const includeColumnHeaders = toScalar(args[3]);
+            const shouldIncludeColumnHeaders = includeColumnHeaders === undefined ? true : toBoolean(includeColumnHeaders);
             const pivotCells = pivot
                 .getTableStructure()
-                .getPivotCells(includeTotal, includeColumnHeaders);
+                .getPivotCells(shouldIncludeTotal, shouldIncludeColumnHeaders);
             const pivotCol = position.col - mainPosition.col;
             const pivotRow = position.row - mainPosition.row;
             return pivotCells[pivotCol][pivotRow];
@@ -58156,7 +58182,7 @@ class InsertPivotPlugin extends UIPlugin {
     getPivotDuplicateSheetName(pivotName) {
         let i = 1;
         const names = this.getters.getSheetIds().map((id) => this.getters.getSheetName(id));
-        const sanitizedName = pivotName.replace(new RegExp(FORBIDDEN_IN_EXCEL_REGEX, "g"), " ");
+        const sanitizedName = sanitizeSheetName(pivotName);
         let name = sanitizedName;
         while (names.includes(name)) {
             name = `${sanitizedName} (${i})`;
@@ -61300,6 +61326,7 @@ class SheetViewPlugin extends UIPlugin {
                 break;
             case "DELETE_SHEET":
                 this.cleanViewports();
+                this.sheetsWithDirtyViewports.delete(cmd.sheetId);
                 break;
             case "ACTIVATE_SHEET":
                 this.sheetsWithDirtyViewports.add(cmd.sheetIdTo);
@@ -62197,7 +62224,7 @@ function interactiveRenameSheet(env, sheetId, name, errorCallback) {
         env.raiseError(_t("A sheet with the name %s already exists. Please select another name.", name), errorCallback);
     }
     else if (result.reasons.includes("ForbiddenCharactersInSheetName" /* CommandResult.ForbiddenCharactersInSheetName */)) {
-        env.raiseError(_t("Some used characters are not allowed in a sheet name (Forbidden characters are %s).", FORBIDDEN_SHEET_CHARS.join(" ")), errorCallback);
+        env.raiseError(_t("Some used characters are not allowed in a sheet name (Forbidden characters are %s).", FORBIDDEN_SHEETNAME_CHARS.join(" ")), errorCallback);
     }
 }
 
@@ -63456,7 +63483,7 @@ class ActionButton extends owl.Component {
     setup() {
         owl.onWillUpdateProps((nextProps) => {
             if (nextProps.action !== this.props.action) {
-                this.actionButton = createAction(this.props.action);
+                this.actionButton = createAction(nextProps.action);
             }
         });
     }
@@ -63723,7 +63750,6 @@ css /* scss */ `
     height: fit-content;
     margin-top: -1px;
     border: 1px solid;
-    z-index: ${ComponentsImportance.TopBarComposer};
 
     .o-composer:empty:not(:focus):not(.active)::before {
       content: url("data:image/svg+xml,${encodeURIComponent(FX_SVG)}");
@@ -63765,6 +63791,7 @@ class TopBarComposer extends owl.Component {
         }
         return cssPropertiesToCss({
             "border-color": SELECTION_BORDER_COLOR,
+            "z-index": String(ComponentsImportance.TopBarComposer),
         });
     }
     get delimitation() {
@@ -68589,6 +68616,7 @@ const helpers = {
     createPivotFormula,
     areDomainArgsFieldsValid,
     formatTickValue,
+    sanitizeSheetName,
 };
 const links = {
     isMarkdownLink,
@@ -68719,6 +68747,6 @@ exports.tokenColors = tokenColors;
 exports.tokenize = tokenize;
 
 
-__info__.version = "17.4.14";
-__info__.date = "2024-11-28T09:08:12.462Z";
-__info__.hash = "81bf386";
+__info__.version = "17.4.16";
+__info__.date = "2024-12-19T07:50:04.021Z";
+__info__.hash = "6b827fc";

package/dist/o-spreadsheet.d.ts

@@ -5548,6 +5548,8 @@ declare function createCurrencyFormat(currency: Partial<Currency>): Format;
  */
 declare function deepCopy<T>(obj: T): T;
 declare function unquote(string: string, quoteChar?: "'" | '"'): string;
+/** Replace the excel-excluded characters of a sheetName */
+declare function sanitizeSheetName(sheetName: string, replacementChar?: string): string;
 declare function isMarkdownLink(str: string): boolean;
 /**
  * Build a markdown link from a label and an url
@@ -8283,6 +8285,7 @@ interface DndState {
     draggedFigure?: Figure;
     horizontalSnap?: Snap<HFigureAxisType>;
     verticalSnap?: Snap<VFigureAxisType>;
+    cancelDnd: (() => void) | undefined;
 }
 /**
  * Each figure ⭐ is positioned inside a container `div` placed and sized
@@ -11531,6 +11534,7 @@ declare const helpers: {
     createPivotFormula: typeof createPivotFormula;
     areDomainArgsFieldsValid: typeof areDomainArgsFieldsValid;
     formatTickValue: typeof formatTickValue;
+    sanitizeSheetName: typeof sanitizeSheetName;
 };
 declare const links: {
     isMarkdownLink: typeof isMarkdownLink;

package/dist/o-spreadsheet.esm.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.4.14
- * @date 2024-11-28T09:08:12.462Z
- * @hash 81bf386
+ * @version 17.4.16
+ * @date 2024-12-19T07:50:04.021Z
+ * @hash 6b827fc
  */
 
 import { useEnv, useSubEnv, onWillUnmount, useComponent, status, Component, useRef, onMounted, useEffect, useState, onPatched, onWillPatch, onWillUpdateProps, useExternalListener, onWillStart, xml, useChildSubEnv, markRaw, toRaw } from '@odoo/owl';
@@ -304,8 +304,8 @@ const LINE_FILL_TRANSPARENCY = 0.4;
 const DEBOUNCE_TIME = 200;
 const MESSAGE_VERSION = 1;
 // Sheets
-const FORBIDDEN_SHEET_CHARS = ["'", "*", "?", "/", "\\", "[", "]"];
-const FORBIDDEN_IN_EXCEL_REGEX = /'|\*|\?|\/|\\|\[|\]/;
+const FORBIDDEN_SHEETNAME_CHARS = ["'", "*", "?", "/", "\\", "[", "]"];
+const FORBIDDEN_SHEETNAME_CHARS_IN_EXCEL_REGEX = /'|\*|\?|\/|\\|\[|\]/;
 // Cells
 const FORMULA_REF_IDENTIFIER = "|";
 // Components
@@ -351,6 +351,7 @@ const PIVOT_TABLE_CONFIG = {
 //------------------------------------------------------------------------------
 // Miscellaneous
 //------------------------------------------------------------------------------
+const sanitizeSheetNameRegex = new RegExp(FORBIDDEN_SHEETNAME_CHARS_IN_EXCEL_REGEX, "g");
 /**
  * Remove quotes from a quoted string
  * ```js
@@ -446,6 +447,10 @@ function getCanonicalSheetName(sheetName) {
     }
     return sheetName;
 }
+/** Replace the excel-excluded characters of a sheetName */
+function sanitizeSheetName(sheetName, replacementChar = " ") {
+    return sheetName.replace(sanitizeSheetNameRegex, replacementChar);
+}
 function clip(val, min, max) {
     return val < min ? min : val > max ? max : val;
 }
@@ -761,6 +766,7 @@ function removeFalsyAttributes(obj) {
  * https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions/Character_Classes
  */
 const whiteSpaceSpecialCharacters = [
+    " ",
     "\t",
     "\f",
     "\v",
@@ -775,17 +781,15 @@ const whiteSpaceSpecialCharacters = [
     String.fromCharCode(parseInt("3000", 16)),
     String.fromCharCode(parseInt("feff", 16)),
 ];
-const whiteSpaceRegexp = new RegExp(whiteSpaceSpecialCharacters.join("|") + "|(\r\n|\r|\n)", "g");
+const whiteSpaceRegexp = new RegExp(whiteSpaceSpecialCharacters.join("|"), "g");
+const newLineRegexp = /(\r\n|\r)/g;
 /**
- * Replace all the special spaces in a string (non-breaking, tabs, ...) by normal spaces, and all the
- * different newlines types by \n.
+ * Replace all different newlines characters by \n
  */
-function replaceSpecialSpaces(text) {
+function replaceNewLines(text) {
     if (!text)
         return "";
-    if (!whiteSpaceRegexp.test(text))
-        return text;
-    return text.replace(whiteSpaceRegexp, (match, newLine) => (newLine ? NEWLINE : " "));
+    return text.replace(newLineRegexp, NEWLINE);
 }
 /**
  * Determine if the numbers are consecutive.
@@ -5677,7 +5681,7 @@ class BorderClipboardHandler extends AbstractCellClipboardHandler {
 const POSTFIX_UNARY_OPERATORS = ["%"];
 const OPERATORS = "+,-,*,/,:,=,<>,>=,>,<=,<,^,&".split(",").concat(POSTFIX_UNARY_OPERATORS);
 function tokenize(str, locale = DEFAULT_LOCALE) {
-    str = replaceSpecialSpaces(str);
+    str = replaceNewLines(str);
     const chars = new TokenizingChars(str);
     const result = [];
     while (!chars.isOver()) {
@@ -5824,12 +5828,12 @@ function tokenizeSpace(chars) {
     if (length) {
         return { type: "SPACE", value: NEWLINE.repeat(length) };
     }
-    while (chars.current === " ") {
-        length++;
-        chars.shift();
+    let spaces = "";
+    while (chars.current && chars.current.match(whiteSpaceRegexp)) {
+        spaces += chars.shift();
     }
-    if (length) {
-        return { type: "SPACE", value: " ".repeat(length) };
+    if (spaces) {
+        return { type: "SPACE", value: spaces };
     }
     return null;
 }
@@ -38559,6 +38563,7 @@ css /* scss */ `
     }
   }
 `;
+const DEFAULT_TABLE_STYLE_COLOR = "#3C78D8";
 class TableStyleEditorPanel extends Component {
     static template = "o-spreadsheet-TableStyleEditorPanel";
     static components = { Section, RoundColorPicker, TableStylePreview };
@@ -38577,7 +38582,7 @@ class TableStyleEditorPanel extends Component {
             : null;
         return {
             pickerOpened: false,
-            primaryColor: editedStyle?.primaryColor || "#3C78D8",
+            primaryColor: editedStyle?.primaryColor || DEFAULT_TABLE_STYLE_COLOR,
             selectedTemplateName: editedStyle?.templateName || "lightColoredText",
             styleName: editedStyle?.displayName || this.env.model.getters.getNewCustomTableStyleName(),
         };
@@ -38586,7 +38591,7 @@ class TableStyleEditorPanel extends Component {
         this.state.pickerOpened = !this.state.pickerOpened;
     }
     onColorPicked(color) {
-        this.state.primaryColor = color;
+        this.state.primaryColor = isColorValid(color) ? color : DEFAULT_TABLE_STYLE_COLOR;
         this.state.pickerOpened = false;
     }
     onTemplatePicked(templateName) {
@@ -39933,6 +39938,7 @@ class FiguresContainer extends Component {
         draggedFigure: undefined,
         horizontalSnap: undefined,
         verticalSnap: undefined,
+        cancelDnd: undefined,
     });
     setup() {
         onMounted(() => {
@@ -39945,12 +39951,28 @@ class FiguresContainer extends Component {
             // new rendering
             this.render();
         });
+        onWillUpdateProps(() => {
+            const sheetId = this.env.model.getters.getActiveSheetId();
+            const draggedFigureId = this.dnd.draggedFigure?.id;
+            if (draggedFigureId && !this.env.model.getters.getFigure(sheetId, draggedFigureId)) {
+                if (this.dnd.cancelDnd) {
+                    this.dnd.cancelDnd();
+                }
+                this.dnd.draggedFigure = undefined;
+                this.dnd.horizontalSnap = undefined;
+                this.dnd.verticalSnap = undefined;
+                this.dnd.cancelDnd = undefined;
+            }
+        });
     }
     getVisibleFigures() {
         const visibleFigures = this.env.model.getters.getVisibleFigures();
         if (this.dnd.draggedFigure &&
             !visibleFigures.some((figure) => figure.id === this.dnd.draggedFigure?.id)) {
-            visibleFigures.push(this.env.model.getters.getFigure(this.env.model.getters.getActiveSheetId(), this.dnd.draggedFigure?.id));
+            const draggedFigure = this.env.model.getters.getFigure(this.env.model.getters.getActiveSheetId(), this.dnd.draggedFigure?.id);
+            if (draggedFigure) {
+                visibleFigures.push(draggedFigure);
+            }
         }
         return visibleFigures;
     }
@@ -40069,7 +40091,7 @@ class FiguresContainer extends Component {
             this.dnd.verticalSnap = undefined;
             this.env.model.dispatch("UPDATE_FIGURE", { sheetId, id: figure.id, x, y });
         };
-        startDnd(onMouseMove, onMouseUp);
+        this.dnd.cancelDnd = startDnd(onMouseMove, onMouseUp);
     }
     /**
      * Initialize the resize of a figure with mouse movements
@@ -40117,7 +40139,7 @@ class FiguresContainer extends Component {
             this.dnd.horizontalSnap = undefined;
             this.dnd.verticalSnap = undefined;
         };
-        startDnd(onMouseMove, onMouseUp);
+        this.dnd.cancelDnd = startDnd(onMouseMove, onMouseUp);
     }
     getOtherFigures(figId) {
         return this.getVisibleFigures().filter((f) => f.id !== figId);
@@ -46725,13 +46747,12 @@ const MIGRATIONS = [
         to: 8,
         applyMigration(data) {
             const namesTaken = [];
-            const globalForbiddenInExcel = new RegExp(FORBIDDEN_IN_EXCEL_REGEX, "g");
             for (let sheet of data.sheets || []) {
                 if (!sheet.name) {
                     continue;
                 }
                 const oldName = sheet.name;
-                const escapedName = oldName.replace(globalForbiddenInExcel, "_");
+                const escapedName = sanitizeSheetName(oldName, "_");
                 let i = 1;
                 let newName = escapedName;
                 while (namesTaken.includes(newName)) {
@@ -48230,7 +48251,7 @@ class CellPlugin extends CorePlugin {
         const before = this.getters.getCell({ sheetId, col, row });
         const hasContent = "content" in after || "formula" in after;
         // Compute the new cell properties
-        const afterContent = hasContent ? replaceSpecialSpaces(after?.content) : before?.content || "";
+        const afterContent = hasContent ? replaceNewLines(after?.content) : before?.content || "";
         let style;
         if (after.style !== undefined) {
             style = after.style || undefined;
@@ -51091,6 +51112,9 @@ class SheetPlugin extends CorePlugin {
         };
     }
     getUnboundedZone(sheetId, zone) {
+        if (zone.bottom === undefined || zone.right === undefined) {
+            return zone;
+        }
         const isFullRow = zone.left === 0 && zone.right === this.getNumberCols(sheetId) - 1;
         const isFullCol = zone.top === 0 && zone.bottom === this.getNumberRows(sheetId) - 1;
         return {
@@ -51256,7 +51280,7 @@ class SheetPlugin extends CorePlugin {
         if (orderedSheetIds.find((id) => sheets[id]?.name.toLowerCase() === name && id !== cmd.sheetId)) {
             return "DuplicatedSheetName" /* CommandResult.DuplicatedSheetName */;
         }
-        if (FORBIDDEN_IN_EXCEL_REGEX.test(name)) {
+        if (FORBIDDEN_SHEETNAME_CHARS_IN_EXCEL_REGEX.test(name)) {
             return "ForbiddenCharactersInSheetName" /* CommandResult.ForbiddenCharactersInSheetName */;
         }
         return "Success" /* CommandResult.Success */;
@@ -56045,11 +56069,13 @@ class PivotUIPlugin extends UIPlugin {
             return EMPTY_PIVOT_CELL;
         }
         if (functionName === "PIVOT") {
-            const includeTotal = args[2] === false ? false : undefined;
-            const includeColumnHeaders = args[3] === false ? false : undefined;
+            const includeTotal = toScalar(args[2]);
+            const shouldIncludeTotal = includeTotal === undefined ? true : toBoolean(includeTotal);
+            const includeColumnHeaders = toScalar(args[3]);
+            const shouldIncludeColumnHeaders = includeColumnHeaders === undefined ? true : toBoolean(includeColumnHeaders);
             const pivotCells = pivot
                 .getTableStructure()
-                .getPivotCells(includeTotal, includeColumnHeaders);
+                .getPivotCells(shouldIncludeTotal, shouldIncludeColumnHeaders);
             const pivotCol = position.col - mainPosition.col;
             const pivotRow = position.row - mainPosition.row;
             return pivotCells[pivotCol][pivotRow];
@@ -58154,7 +58180,7 @@ class InsertPivotPlugin extends UIPlugin {
     getPivotDuplicateSheetName(pivotName) {
         let i = 1;
         const names = this.getters.getSheetIds().map((id) => this.getters.getSheetName(id));
-        const sanitizedName = pivotName.replace(new RegExp(FORBIDDEN_IN_EXCEL_REGEX, "g"), " ");
+        const sanitizedName = sanitizeSheetName(pivotName);
         let name = sanitizedName;
         while (names.includes(name)) {
             name = `${sanitizedName} (${i})`;
@@ -61298,6 +61324,7 @@ class SheetViewPlugin extends UIPlugin {
                 break;
             case "DELETE_SHEET":
                 this.cleanViewports();
+                this.sheetsWithDirtyViewports.delete(cmd.sheetId);
                 break;
             case "ACTIVATE_SHEET":
                 this.sheetsWithDirtyViewports.add(cmd.sheetIdTo);
@@ -62195,7 +62222,7 @@ function interactiveRenameSheet(env, sheetId, name, errorCallback) {
         env.raiseError(_t("A sheet with the name %s already exists. Please select another name.", name), errorCallback);
     }
     else if (result.reasons.includes("ForbiddenCharactersInSheetName" /* CommandResult.ForbiddenCharactersInSheetName */)) {
-        env.raiseError(_t("Some used characters are not allowed in a sheet name (Forbidden characters are %s).", FORBIDDEN_SHEET_CHARS.join(" ")), errorCallback);
+        env.raiseError(_t("Some used characters are not allowed in a sheet name (Forbidden characters are %s).", FORBIDDEN_SHEETNAME_CHARS.join(" ")), errorCallback);
     }
 }
 
@@ -63454,7 +63481,7 @@ class ActionButton extends Component {
     setup() {
         onWillUpdateProps((nextProps) => {
             if (nextProps.action !== this.props.action) {
-                this.actionButton = createAction(this.props.action);
+                this.actionButton = createAction(nextProps.action);
             }
         });
     }
@@ -63721,7 +63748,6 @@ css /* scss */ `
     height: fit-content;
     margin-top: -1px;
     border: 1px solid;
-    z-index: ${ComponentsImportance.TopBarComposer};
 
     .o-composer:empty:not(:focus):not(.active)::before {
       content: url("data:image/svg+xml,${encodeURIComponent(FX_SVG)}");
@@ -63763,6 +63789,7 @@ class TopBarComposer extends Component {
         }
         return cssPropertiesToCss({
             "border-color": SELECTION_BORDER_COLOR,
+            "z-index": String(ComponentsImportance.TopBarComposer),
         });
     }
     get delimitation() {
@@ -68587,6 +68614,7 @@ const helpers = {
     createPivotFormula,
     areDomainArgsFieldsValid,
     formatTickValue,
+    sanitizeSheetName,
 };
 const links = {
     isMarkdownLink,
@@ -68674,6 +68702,6 @@ const constants = {
 export { AbstractCellClipboardHandler, AbstractChart, AbstractFigureClipboardHandler, CellErrorType, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, PivotRuntimeDefinition, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, SpreadsheetPivotTable, UIPlugin, __info__, addFunction, addRenderingLayer, astToFormula, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, stores, tokenColors, tokenize };
 
 
-__info__.version = "17.4.14";
-__info__.date = "2024-11-28T09:08:12.462Z";
-__info__.hash = "81bf386";
+__info__.version = "17.4.16";
+__info__.date = "2024-12-19T07:50:04.021Z";
+__info__.hash = "6b827fc";