@odoo/o-spreadsheet 17.4.12 → 17.4.13

package/dist/o-spreadsheet.cjs.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.4.12
- * @date 2024-11-13T15:06:56.109Z
- * @hash 5cde4be
+ * @version 17.4.13
+ * @date 2024-11-22T14:17:01.675Z
+ * @hash a5e4e16
  */
 
 'use strict';
@@ -3136,7 +3136,9 @@ function linearSearch(data, target, mode, numberOfValues, getValueInData, revers
             return reverseSearch ? numberOfValues - i - 1 : i;
         }
     }
-    return reverseSearch ? numberOfValues - closestMatchIndex - 1 : closestMatchIndex;
+    return reverseSearch && closestMatchIndex !== -1
+        ? numberOfValues - closestMatchIndex - 1
+        : closestMatchIndex;
 }
 /**
  * Normalize a value.
@@ -54281,6 +54283,9 @@ class Evaluator {
             }
             for (let i = 0; i < positions.length; ++i) {
                 const position = positions[i];
+                if (this.nextPositionsToUpdate.has(position)) {
+                    continue;
+                }
                 const evaluatedCell = this.computeCell(position);
                 if (evaluatedCell !== EMPTY_CELL) {
                     this.evaluatedCells.set(position, evaluatedCell);
@@ -54288,6 +54293,9 @@ class Evaluator {
             }
             onIterationEndEvaluationRegistry.getAll().forEach((callback) => callback(this.getters));
         }
+        if (currentIteration >= MAX_ITERATION) {
+            console.warn("Maximum iteration reached while evaluating cells");
+        }
     }
     computeCell(position) {
         const evaluation = this.evaluatedCells.get(position);
@@ -54322,7 +54330,6 @@ class Evaluator {
         }
         finally {
             this.cellsBeingComputed.delete(cellId);
-            this.nextPositionsToUpdate.delete(position);
         }
     }
     computeAndSave(position) {
@@ -54373,6 +54380,7 @@ class Evaluator {
             { sheetId, zone: rightPartZone },
             { sheetId, zone: leftColumnZone },
         ]);
+        invalidatedPositions.delete(arrayFormulaPosition);
         this.nextPositionsToUpdate.addMany(invalidatedPositions);
     }
     assertSheetHasEnoughSpaceToSpreadFormulaResult({ sheetId, col, row }, matrixResult) {
@@ -55431,25 +55439,11 @@ class EvaluationDataValidationPlugin extends UIPlugin {
         }
         switch (cmd.type) {
             case "ADD_DATA_VALIDATION_RULE":
-                const ranges = cmd.ranges.map((range) => this.getters.getRangeFromRangeData(range));
-                if (cmd.rule.criterion.type === "isBoolean") {
-                    this.setContentToBooleanCells({ ...cmd.rule, ranges });
-                }
-                delete this.validationResults[cmd.sheetId];
-                break;
             case "REMOVE_DATA_VALIDATION_RULE":
                 delete this.validationResults[cmd.sheetId];
                 break;
         }
     }
-    setContentToBooleanCells(rule) {
-        for (const position of getCellPositionsInRanges(rule.ranges)) {
-            const evaluatedCell = this.getters.getEvaluatedCell(position);
-            if (evaluatedCell.type !== CellValueType.boolean) {
-                this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
-            }
-        }
-    }
     isDataValidationInvalid(cellPosition) {
         return !this.getValidationResultForCell(cellPosition).isValid;
     }
@@ -57381,7 +57375,7 @@ class Session extends EventBus {
      * Notify the server that the user client left the collaborative session
      */
     async leave(data) {
-        if (Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
+        if (data && Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
             await this.snapshot(data());
         }
         delete this.clients[this.clientId];
@@ -58852,6 +58846,42 @@ class CellComputedStylePlugin extends UIPlugin {
     }
 }
 
+class DataValidationInsertionPlugin extends UIPlugin {
+    handle(cmd) {
+        switch (cmd.type) {
+            case "ADD_DATA_VALIDATION_RULE":
+                if (cmd.rule.criterion.type === "isBoolean") {
+                    const ranges = cmd.ranges.map((range) => this.getters.getRangeFromRangeData(range));
+                    for (const position of getCellPositionsInRanges(ranges)) {
+                        const cell = this.getters.getCell(position);
+                        const evaluatedCell = this.getters.getEvaluatedCell(position);
+                        if (!cell?.content) {
+                            this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                            // In this case, a cell has been updated in the core plugin but
+                            // not yet evaluated. This can occur after a paste operation.
+                        }
+                        else if (cell?.content && evaluatedCell.type === CellValueType.empty) {
+                            let value;
+                            if (cell.content.startsWith("=")) {
+                                const result = this.getters.evaluateFormula(position.sheetId, cell.content);
+                                value = (isMatrix(result) ? result[0][0] : result)?.toString();
+                            }
+                            else {
+                                value = cell.content;
+                            }
+                            if (!value || !isBoolean(value)) {
+                                this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                            }
+                        }
+                        else if (evaluatedCell.type !== CellValueType.boolean) {
+                            this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                        }
+                    }
+                }
+        }
+    }
+}
+
 const genericRepeatsTransforms = [
     repeatSheetDependantCommand,
     repeatTargetDependantCommand,
@@ -61917,7 +61947,8 @@ const featurePluginRegistry = new Registry()
     .add("history", HistoryPlugin)
     .add("data_cleanup", DataCleanupPlugin)
     .add("table_autofill", TableAutofillPlugin)
-    .add("table_ui_resize", TableResizeUI);
+    .add("table_ui_resize", TableResizeUI)
+    .add("datavalidation_insert", DataValidationInsertionPlugin);
 // Plugins which have a state, but which should not be shared in collaborative
 const statefulUIPluginRegistry = new Registry()
     .add("selection", GridSelectionPlugin)
@@ -68079,7 +68110,8 @@ class Model extends EventBus {
         this.session.join(this.config.client);
     }
     async leaveSession() {
-        await this.session.leave(lazy(() => this.exportData()));
+        const snapshot = this.getters.isReadonly() ? undefined : lazy(() => this.exportData());
+        await this.session.leave(snapshot);
     }
     setupUiPlugin(Plugin) {
         const plugin = new Plugin(this.uiPluginConfig);
@@ -68682,6 +68714,6 @@ exports.tokenColors = tokenColors;
 exports.tokenize = tokenize;
 
 
-__info__.version = "17.4.12";
-__info__.date = "2024-11-13T15:06:56.109Z";
-__info__.hash = "5cde4be";
+__info__.version = "17.4.13";
+__info__.date = "2024-11-22T14:17:01.675Z";
+__info__.hash = "a5e4e16";

package/dist/o-spreadsheet.d.ts

@@ -3868,7 +3868,7 @@ declare class Session extends EventBus<CollaborativeEvent> {
     /**
      * Notify the server that the user client left the collaborative session
      */
-    leave(data: Lazy<WorkbookData>): Promise<void>;
+    leave(data?: Lazy<WorkbookData>): Promise<void>;
     /**
      * Send a snapshot of the spreadsheet to the collaboration server
      */
@@ -4128,7 +4128,6 @@ declare class EvaluationDataValidationPlugin extends UIPlugin {
     static getters: readonly ["getDataValidationInvalidCriterionValueMessage", "getInvalidDataValidationMessage", "getValidationResultForCellValue", "isCellValidCheckbox", "isDataValidationInvalid"];
     validationResults: Record<UID, SheetValidationResult>;
     handle(cmd: CoreViewCommand): void;
-    private setContentToBooleanCells;
     isDataValidationInvalid(cellPosition: CellPosition): boolean;
     getInvalidDataValidationMessage(cellPosition: CellPosition): string | undefined;
     /**

package/dist/o-spreadsheet.esm.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.4.12
- * @date 2024-11-13T15:06:56.109Z
- * @hash 5cde4be
+ * @version 17.4.13
+ * @date 2024-11-22T14:17:01.675Z
+ * @hash a5e4e16
  */
 
 import { useEnv, useSubEnv, onWillUnmount, useComponent, status, Component, useRef, onMounted, useEffect, useState, onPatched, onWillPatch, onWillUpdateProps, useExternalListener, onWillStart, xml, useChildSubEnv, markRaw, toRaw } from '@odoo/owl';
@@ -3134,7 +3134,9 @@ function linearSearch(data, target, mode, numberOfValues, getValueInData, revers
             return reverseSearch ? numberOfValues - i - 1 : i;
         }
     }
-    return reverseSearch ? numberOfValues - closestMatchIndex - 1 : closestMatchIndex;
+    return reverseSearch && closestMatchIndex !== -1
+        ? numberOfValues - closestMatchIndex - 1
+        : closestMatchIndex;
 }
 /**
  * Normalize a value.
@@ -54279,6 +54281,9 @@ class Evaluator {
             }
             for (let i = 0; i < positions.length; ++i) {
                 const position = positions[i];
+                if (this.nextPositionsToUpdate.has(position)) {
+                    continue;
+                }
                 const evaluatedCell = this.computeCell(position);
                 if (evaluatedCell !== EMPTY_CELL) {
                     this.evaluatedCells.set(position, evaluatedCell);
@@ -54286,6 +54291,9 @@ class Evaluator {
             }
             onIterationEndEvaluationRegistry.getAll().forEach((callback) => callback(this.getters));
         }
+        if (currentIteration >= MAX_ITERATION) {
+            console.warn("Maximum iteration reached while evaluating cells");
+        }
     }
     computeCell(position) {
         const evaluation = this.evaluatedCells.get(position);
@@ -54320,7 +54328,6 @@ class Evaluator {
         }
         finally {
             this.cellsBeingComputed.delete(cellId);
-            this.nextPositionsToUpdate.delete(position);
         }
     }
     computeAndSave(position) {
@@ -54371,6 +54378,7 @@ class Evaluator {
             { sheetId, zone: rightPartZone },
             { sheetId, zone: leftColumnZone },
         ]);
+        invalidatedPositions.delete(arrayFormulaPosition);
         this.nextPositionsToUpdate.addMany(invalidatedPositions);
     }
     assertSheetHasEnoughSpaceToSpreadFormulaResult({ sheetId, col, row }, matrixResult) {
@@ -55429,25 +55437,11 @@ class EvaluationDataValidationPlugin extends UIPlugin {
         }
         switch (cmd.type) {
             case "ADD_DATA_VALIDATION_RULE":
-                const ranges = cmd.ranges.map((range) => this.getters.getRangeFromRangeData(range));
-                if (cmd.rule.criterion.type === "isBoolean") {
-                    this.setContentToBooleanCells({ ...cmd.rule, ranges });
-                }
-                delete this.validationResults[cmd.sheetId];
-                break;
             case "REMOVE_DATA_VALIDATION_RULE":
                 delete this.validationResults[cmd.sheetId];
                 break;
         }
     }
-    setContentToBooleanCells(rule) {
-        for (const position of getCellPositionsInRanges(rule.ranges)) {
-            const evaluatedCell = this.getters.getEvaluatedCell(position);
-            if (evaluatedCell.type !== CellValueType.boolean) {
-                this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
-            }
-        }
-    }
     isDataValidationInvalid(cellPosition) {
         return !this.getValidationResultForCell(cellPosition).isValid;
     }
@@ -57379,7 +57373,7 @@ class Session extends EventBus {
      * Notify the server that the user client left the collaborative session
      */
     async leave(data) {
-        if (Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
+        if (data && Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
             await this.snapshot(data());
         }
         delete this.clients[this.clientId];
@@ -58850,6 +58844,42 @@ class CellComputedStylePlugin extends UIPlugin {
     }
 }
 
+class DataValidationInsertionPlugin extends UIPlugin {
+    handle(cmd) {
+        switch (cmd.type) {
+            case "ADD_DATA_VALIDATION_RULE":
+                if (cmd.rule.criterion.type === "isBoolean") {
+                    const ranges = cmd.ranges.map((range) => this.getters.getRangeFromRangeData(range));
+                    for (const position of getCellPositionsInRanges(ranges)) {
+                        const cell = this.getters.getCell(position);
+                        const evaluatedCell = this.getters.getEvaluatedCell(position);
+                        if (!cell?.content) {
+                            this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                            // In this case, a cell has been updated in the core plugin but
+                            // not yet evaluated. This can occur after a paste operation.
+                        }
+                        else if (cell?.content && evaluatedCell.type === CellValueType.empty) {
+                            let value;
+                            if (cell.content.startsWith("=")) {
+                                const result = this.getters.evaluateFormula(position.sheetId, cell.content);
+                                value = (isMatrix(result) ? result[0][0] : result)?.toString();
+                            }
+                            else {
+                                value = cell.content;
+                            }
+                            if (!value || !isBoolean(value)) {
+                                this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                            }
+                        }
+                        else if (evaluatedCell.type !== CellValueType.boolean) {
+                            this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                        }
+                    }
+                }
+        }
+    }
+}
+
 const genericRepeatsTransforms = [
     repeatSheetDependantCommand,
     repeatTargetDependantCommand,
@@ -61915,7 +61945,8 @@ const featurePluginRegistry = new Registry()
     .add("history", HistoryPlugin)
     .add("data_cleanup", DataCleanupPlugin)
     .add("table_autofill", TableAutofillPlugin)
-    .add("table_ui_resize", TableResizeUI);
+    .add("table_ui_resize", TableResizeUI)
+    .add("datavalidation_insert", DataValidationInsertionPlugin);
 // Plugins which have a state, but which should not be shared in collaborative
 const statefulUIPluginRegistry = new Registry()
     .add("selection", GridSelectionPlugin)
@@ -68077,7 +68108,8 @@ class Model extends EventBus {
         this.session.join(this.config.client);
     }
     async leaveSession() {
-        await this.session.leave(lazy(() => this.exportData()));
+        const snapshot = this.getters.isReadonly() ? undefined : lazy(() => this.exportData());
+        await this.session.leave(snapshot);
     }
     setupUiPlugin(Plugin) {
         const plugin = new Plugin(this.uiPluginConfig);
@@ -68637,6 +68669,6 @@ const constants = {
 export { AbstractCellClipboardHandler, AbstractChart, AbstractFigureClipboardHandler, CellErrorType, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, PivotRuntimeDefinition, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, SpreadsheetPivotTable, UIPlugin, __info__, addFunction, addRenderingLayer, astToFormula, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, stores, tokenColors, tokenize };
 
 
-__info__.version = "17.4.12";
-__info__.date = "2024-11-13T15:06:56.109Z";
-__info__.hash = "5cde4be";
+__info__.version = "17.4.13";
+__info__.date = "2024-11-22T14:17:01.675Z";
+__info__.hash = "a5e4e16";

package/dist/o-spreadsheet.iife.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.4.12
- * @date 2024-11-13T15:06:56.109Z
- * @hash 5cde4be
+ * @version 17.4.13
+ * @date 2024-11-22T14:17:01.675Z
+ * @hash a5e4e16
  */
 
 (function (exports, owl) {
@@ -3135,7 +3135,9 @@
               return reverseSearch ? numberOfValues - i - 1 : i;
           }
       }
-      return reverseSearch ? numberOfValues - closestMatchIndex - 1 : closestMatchIndex;
+      return reverseSearch && closestMatchIndex !== -1
+          ? numberOfValues - closestMatchIndex - 1
+          : closestMatchIndex;
   }
   /**
    * Normalize a value.
@@ -54280,6 +54282,9 @@ stores.inject(MyMetaStore, storeInstance);
               }
               for (let i = 0; i < positions.length; ++i) {
                   const position = positions[i];
+                  if (this.nextPositionsToUpdate.has(position)) {
+                      continue;
+                  }
                   const evaluatedCell = this.computeCell(position);
                   if (evaluatedCell !== EMPTY_CELL) {
                       this.evaluatedCells.set(position, evaluatedCell);
@@ -54287,6 +54292,9 @@ stores.inject(MyMetaStore, storeInstance);
               }
               onIterationEndEvaluationRegistry.getAll().forEach((callback) => callback(this.getters));
           }
+          if (currentIteration >= MAX_ITERATION) {
+              console.warn("Maximum iteration reached while evaluating cells");
+          }
       }
       computeCell(position) {
           const evaluation = this.evaluatedCells.get(position);
@@ -54321,7 +54329,6 @@ stores.inject(MyMetaStore, storeInstance);
           }
           finally {
               this.cellsBeingComputed.delete(cellId);
-              this.nextPositionsToUpdate.delete(position);
           }
       }
       computeAndSave(position) {
@@ -54372,6 +54379,7 @@ stores.inject(MyMetaStore, storeInstance);
               { sheetId, zone: rightPartZone },
               { sheetId, zone: leftColumnZone },
           ]);
+          invalidatedPositions.delete(arrayFormulaPosition);
           this.nextPositionsToUpdate.addMany(invalidatedPositions);
       }
       assertSheetHasEnoughSpaceToSpreadFormulaResult({ sheetId, col, row }, matrixResult) {
@@ -55430,25 +55438,11 @@ stores.inject(MyMetaStore, storeInstance);
           }
           switch (cmd.type) {
               case "ADD_DATA_VALIDATION_RULE":
-                  const ranges = cmd.ranges.map((range) => this.getters.getRangeFromRangeData(range));
-                  if (cmd.rule.criterion.type === "isBoolean") {
-                      this.setContentToBooleanCells({ ...cmd.rule, ranges });
-                  }
-                  delete this.validationResults[cmd.sheetId];
-                  break;
               case "REMOVE_DATA_VALIDATION_RULE":
                   delete this.validationResults[cmd.sheetId];
                   break;
           }
       }
-      setContentToBooleanCells(rule) {
-          for (const position of getCellPositionsInRanges(rule.ranges)) {
-              const evaluatedCell = this.getters.getEvaluatedCell(position);
-              if (evaluatedCell.type !== CellValueType.boolean) {
-                  this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
-              }
-          }
-      }
       isDataValidationInvalid(cellPosition) {
           return !this.getValidationResultForCell(cellPosition).isValid;
       }
@@ -57380,7 +57374,7 @@ stores.inject(MyMetaStore, storeInstance);
        * Notify the server that the user client left the collaborative session
        */
       async leave(data) {
-          if (Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
+          if (data && Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
               await this.snapshot(data());
           }
           delete this.clients[this.clientId];
@@ -58851,6 +58845,42 @@ stores.inject(MyMetaStore, storeInstance);
       }
   }
 
+  class DataValidationInsertionPlugin extends UIPlugin {
+      handle(cmd) {
+          switch (cmd.type) {
+              case "ADD_DATA_VALIDATION_RULE":
+                  if (cmd.rule.criterion.type === "isBoolean") {
+                      const ranges = cmd.ranges.map((range) => this.getters.getRangeFromRangeData(range));
+                      for (const position of getCellPositionsInRanges(ranges)) {
+                          const cell = this.getters.getCell(position);
+                          const evaluatedCell = this.getters.getEvaluatedCell(position);
+                          if (!cell?.content) {
+                              this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                              // In this case, a cell has been updated in the core plugin but
+                              // not yet evaluated. This can occur after a paste operation.
+                          }
+                          else if (cell?.content && evaluatedCell.type === CellValueType.empty) {
+                              let value;
+                              if (cell.content.startsWith("=")) {
+                                  const result = this.getters.evaluateFormula(position.sheetId, cell.content);
+                                  value = (isMatrix(result) ? result[0][0] : result)?.toString();
+                              }
+                              else {
+                                  value = cell.content;
+                              }
+                              if (!value || !isBoolean(value)) {
+                                  this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                              }
+                          }
+                          else if (evaluatedCell.type !== CellValueType.boolean) {
+                              this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                          }
+                      }
+                  }
+          }
+      }
+  }
+
   const genericRepeatsTransforms = [
       repeatSheetDependantCommand,
       repeatTargetDependantCommand,
@@ -61916,7 +61946,8 @@ stores.inject(MyMetaStore, storeInstance);
       .add("history", HistoryPlugin)
       .add("data_cleanup", DataCleanupPlugin)
       .add("table_autofill", TableAutofillPlugin)
-      .add("table_ui_resize", TableResizeUI);
+      .add("table_ui_resize", TableResizeUI)
+      .add("datavalidation_insert", DataValidationInsertionPlugin);
   // Plugins which have a state, but which should not be shared in collaborative
   const statefulUIPluginRegistry = new Registry()
       .add("selection", GridSelectionPlugin)
@@ -68078,7 +68109,8 @@ stores.inject(MyMetaStore, storeInstance);
           this.session.join(this.config.client);
       }
       async leaveSession() {
-          await this.session.leave(lazy(() => this.exportData()));
+          const snapshot = this.getters.isReadonly() ? undefined : lazy(() => this.exportData());
+          await this.session.leave(snapshot);
       }
       setupUiPlugin(Plugin) {
           const plugin = new Plugin(this.uiPluginConfig);
@@ -68681,9 +68713,9 @@ stores.inject(MyMetaStore, storeInstance);
   exports.tokenize = tokenize;
 
 
-  __info__.version = "17.4.12";
-  __info__.date = "2024-11-13T15:06:56.109Z";
-  __info__.hash = "5cde4be";
+  __info__.version = "17.4.13";
+  __info__.date = "2024-11-22T14:17:01.675Z";
+  __info__.hash = "a5e4e16";
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);