@odoo/o-spreadsheet 17.4.11 → 17.4.13

package/dist/o-spreadsheet.cjs.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.4.11
- * @date 2024-11-08T12:15:26.239Z
- * @hash 2eb3f1c
+ * @version 17.4.13
+ * @date 2024-11-22T14:17:01.675Z
+ * @hash a5e4e16
  */
 
 'use strict';
@@ -3136,7 +3136,9 @@ function linearSearch(data, target, mode, numberOfValues, getValueInData, revers
             return reverseSearch ? numberOfValues - i - 1 : i;
         }
     }
-    return reverseSearch ? numberOfValues - closestMatchIndex - 1 : closestMatchIndex;
+    return reverseSearch && closestMatchIndex !== -1
+        ? numberOfValues - closestMatchIndex - 1
+        : closestMatchIndex;
 }
 /**
  * Normalize a value.
@@ -23489,11 +23491,14 @@ function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, tr
 function getChartLabelFormat(getters, range) {
     if (!range)
         return undefined;
-    return getters.getEvaluatedCell({
-        sheetId: range.sheetId,
-        col: range.zone.left,
-        row: range.zone.top,
-    }).format;
+    const { sheetId, zone: { left, top, bottom }, } = range;
+    for (let row = top; row <= bottom; row++) {
+        const format = getters.getEvaluatedCell({ sheetId, col: left, row }).format;
+        if (format) {
+            return format;
+        }
+    }
+    return undefined;
 }
 function getChartLabelValues(getters, dataSets, labelRange) {
     let labels = { values: [], formattedValues: [] };
@@ -24032,11 +24037,7 @@ function canBeDateChart(labelRange, getters) {
     if (!labelRange || !canBeLinearChart(labelRange, getters)) {
         return false;
     }
-    const labelFormat = getters.getEvaluatedCell({
-        sheetId: labelRange.sheetId,
-        col: labelRange.zone.left,
-        row: labelRange.zone.top,
-    }).format;
+    const labelFormat = getChartLabelFormat(getters, labelRange);
     return Boolean(labelFormat && timeFormatLuxonCompatible.test(labelFormat));
 }
 function canBeLinearChart(labelRange, getters) {
@@ -32069,6 +32070,7 @@ class ColorPicker extends owl.Component {
         currentColor: { type: String, optional: true },
         maxHeight: { type: Number, optional: true },
         anchorRect: Object,
+        disableNoColor: { type: Boolean, optional: true },
     };
     static defaultProps = { currentColor: "" };
     static components = { Popover };
@@ -32294,6 +32296,7 @@ class RoundColorPicker extends owl.Component {
         currentColor: { type: String, optional: true },
         title: { type: String, optional: true },
         onColorPicked: Function,
+        disableNoColor: { type: Boolean, optional: true },
     };
     colorPickerButtonRef = owl.useRef("colorPickerButton");
     state;
@@ -34355,6 +34358,9 @@ class ConditionalFormattingEditor extends owl.Component {
         }
     }
     setColorScaleColor(target, color) {
+        if (!isColorValid(color)) {
+            return;
+        }
         const point = this.state.rules.colorScale[target];
         if (point) {
             point.color = Number.parseInt(color.substr(1), 16);
@@ -54277,6 +54283,9 @@ class Evaluator {
             }
             for (let i = 0; i < positions.length; ++i) {
                 const position = positions[i];
+                if (this.nextPositionsToUpdate.has(position)) {
+                    continue;
+                }
                 const evaluatedCell = this.computeCell(position);
                 if (evaluatedCell !== EMPTY_CELL) {
                     this.evaluatedCells.set(position, evaluatedCell);
@@ -54284,6 +54293,9 @@ class Evaluator {
             }
             onIterationEndEvaluationRegistry.getAll().forEach((callback) => callback(this.getters));
         }
+        if (currentIteration >= MAX_ITERATION) {
+            console.warn("Maximum iteration reached while evaluating cells");
+        }
     }
     computeCell(position) {
         const evaluation = this.evaluatedCells.get(position);
@@ -54318,7 +54330,6 @@ class Evaluator {
         }
         finally {
             this.cellsBeingComputed.delete(cellId);
-            this.nextPositionsToUpdate.delete(position);
         }
     }
     computeAndSave(position) {
@@ -54369,6 +54380,7 @@ class Evaluator {
             { sheetId, zone: rightPartZone },
             { sheetId, zone: leftColumnZone },
         ]);
+        invalidatedPositions.delete(arrayFormulaPosition);
         this.nextPositionsToUpdate.addMany(invalidatedPositions);
     }
     assertSheetHasEnoughSpaceToSpreadFormulaResult({ sheetId, col, row }, matrixResult) {
@@ -55427,25 +55439,11 @@ class EvaluationDataValidationPlugin extends UIPlugin {
         }
         switch (cmd.type) {
             case "ADD_DATA_VALIDATION_RULE":
-                const ranges = cmd.ranges.map((range) => this.getters.getRangeFromRangeData(range));
-                if (cmd.rule.criterion.type === "isBoolean") {
-                    this.setContentToBooleanCells({ ...cmd.rule, ranges });
-                }
-                delete this.validationResults[cmd.sheetId];
-                break;
             case "REMOVE_DATA_VALIDATION_RULE":
                 delete this.validationResults[cmd.sheetId];
                 break;
         }
     }
-    setContentToBooleanCells(rule) {
-        for (const position of getCellPositionsInRanges(rule.ranges)) {
-            const evaluatedCell = this.getters.getEvaluatedCell(position);
-            if (evaluatedCell.type !== CellValueType.boolean) {
-                this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
-            }
-        }
-    }
     isDataValidationInvalid(cellPosition) {
         return !this.getValidationResultForCell(cellPosition).isValid;
     }
@@ -57377,7 +57375,7 @@ class Session extends EventBus {
      * Notify the server that the user client left the collaborative session
      */
     async leave(data) {
-        if (Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
+        if (data && Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
             await this.snapshot(data());
         }
         delete this.clients[this.clientId];
@@ -58848,6 +58846,42 @@ class CellComputedStylePlugin extends UIPlugin {
     }
 }
 
+class DataValidationInsertionPlugin extends UIPlugin {
+    handle(cmd) {
+        switch (cmd.type) {
+            case "ADD_DATA_VALIDATION_RULE":
+                if (cmd.rule.criterion.type === "isBoolean") {
+                    const ranges = cmd.ranges.map((range) => this.getters.getRangeFromRangeData(range));
+                    for (const position of getCellPositionsInRanges(ranges)) {
+                        const cell = this.getters.getCell(position);
+                        const evaluatedCell = this.getters.getEvaluatedCell(position);
+                        if (!cell?.content) {
+                            this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                            // In this case, a cell has been updated in the core plugin but
+                            // not yet evaluated. This can occur after a paste operation.
+                        }
+                        else if (cell?.content && evaluatedCell.type === CellValueType.empty) {
+                            let value;
+                            if (cell.content.startsWith("=")) {
+                                const result = this.getters.evaluateFormula(position.sheetId, cell.content);
+                                value = (isMatrix(result) ? result[0][0] : result)?.toString();
+                            }
+                            else {
+                                value = cell.content;
+                            }
+                            if (!value || !isBoolean(value)) {
+                                this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                            }
+                        }
+                        else if (evaluatedCell.type !== CellValueType.boolean) {
+                            this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                        }
+                    }
+                }
+        }
+    }
+}
+
 const genericRepeatsTransforms = [
     repeatSheetDependantCommand,
     repeatTargetDependantCommand,
@@ -61913,7 +61947,8 @@ const featurePluginRegistry = new Registry()
     .add("history", HistoryPlugin)
     .add("data_cleanup", DataCleanupPlugin)
     .add("table_autofill", TableAutofillPlugin)
-    .add("table_ui_resize", TableResizeUI);
+    .add("table_ui_resize", TableResizeUI)
+    .add("datavalidation_insert", DataValidationInsertionPlugin);
 // Plugins which have a state, but which should not be shared in collaborative
 const statefulUIPluginRegistry = new Registry()
     .add("selection", GridSelectionPlugin)
@@ -68075,7 +68110,8 @@ class Model extends EventBus {
         this.session.join(this.config.client);
     }
     async leaveSession() {
-        await this.session.leave(lazy(() => this.exportData()));
+        const snapshot = this.getters.isReadonly() ? undefined : lazy(() => this.exportData());
+        await this.session.leave(snapshot);
     }
     setupUiPlugin(Plugin) {
         const plugin = new Plugin(this.uiPluginConfig);
@@ -68678,6 +68714,6 @@ exports.tokenColors = tokenColors;
 exports.tokenize = tokenize;
 
 
-__info__.version = "17.4.11";
-__info__.date = "2024-11-08T12:15:26.239Z";
-__info__.hash = "2eb3f1c";
+__info__.version = "17.4.13";
+__info__.date = "2024-11-22T14:17:01.675Z";
+__info__.hash = "a5e4e16";

package/dist/o-spreadsheet.d.ts

@@ -3868,7 +3868,7 @@ declare class Session extends EventBus<CollaborativeEvent> {
     /**
      * Notify the server that the user client left the collaborative session
      */
-    leave(data: Lazy<WorkbookData>): Promise<void>;
+    leave(data?: Lazy<WorkbookData>): Promise<void>;
     /**
      * Send a snapshot of the spreadsheet to the collaboration server
      */
@@ -4128,7 +4128,6 @@ declare class EvaluationDataValidationPlugin extends UIPlugin {
     static getters: readonly ["getDataValidationInvalidCriterionValueMessage", "getInvalidDataValidationMessage", "getValidationResultForCellValue", "isCellValidCheckbox", "isDataValidationInvalid"];
     validationResults: Record<UID, SheetValidationResult>;
     handle(cmd: CoreViewCommand): void;
-    private setContentToBooleanCells;
     isDataValidationInvalid(cellPosition: CellPosition): boolean;
     getInvalidDataValidationMessage(cellPosition: CellPosition): string | undefined;
     /**
@@ -6887,6 +6886,7 @@ interface ColorPickerProps {
     maxHeight?: Pixel;
     onColorPicked: (color: Color) => void;
     currentColor: Color;
+    disableNoColor?: boolean;
 }
 declare class ColorPicker extends Component<ColorPickerProps, SpreadsheetChildEnv> {
     static template: string;
@@ -6901,6 +6901,10 @@ declare class ColorPicker extends Component<ColorPickerProps, SpreadsheetChildEn
             optional: boolean;
         };
         anchorRect: ObjectConstructor;
+        disableNoColor: {
+            type: BooleanConstructor;
+            optional: boolean;
+        };
     };
     static defaultProps: {
         currentColor: string;
@@ -6984,6 +6988,7 @@ interface Props$U {
     currentColor?: string;
     onColorPicked: (color: string) => void;
     title?: string;
+    disableNoColor?: boolean;
 }
 declare class RoundColorPicker extends Component<Props$U, SpreadsheetChildEnv> {
     static template: string;
@@ -7002,6 +7007,10 @@ declare class RoundColorPicker extends Component<Props$U, SpreadsheetChildEnv> {
             optional: boolean;
         };
         onColorPicked: FunctionConstructor;
+        disableNoColor: {
+            type: BooleanConstructor;
+            optional: boolean;
+        };
     };
     colorPickerButtonRef: {
         el: HTMLElement | null;

package/dist/o-spreadsheet.esm.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.4.11
- * @date 2024-11-08T12:15:26.239Z
- * @hash 2eb3f1c
+ * @version 17.4.13
+ * @date 2024-11-22T14:17:01.675Z
+ * @hash a5e4e16
  */
 
 import { useEnv, useSubEnv, onWillUnmount, useComponent, status, Component, useRef, onMounted, useEffect, useState, onPatched, onWillPatch, onWillUpdateProps, useExternalListener, onWillStart, xml, useChildSubEnv, markRaw, toRaw } from '@odoo/owl';
@@ -3134,7 +3134,9 @@ function linearSearch(data, target, mode, numberOfValues, getValueInData, revers
             return reverseSearch ? numberOfValues - i - 1 : i;
         }
     }
-    return reverseSearch ? numberOfValues - closestMatchIndex - 1 : closestMatchIndex;
+    return reverseSearch && closestMatchIndex !== -1
+        ? numberOfValues - closestMatchIndex - 1
+        : closestMatchIndex;
 }
 /**
  * Normalize a value.
@@ -23487,11 +23489,14 @@ function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, tr
 function getChartLabelFormat(getters, range) {
     if (!range)
         return undefined;
-    return getters.getEvaluatedCell({
-        sheetId: range.sheetId,
-        col: range.zone.left,
-        row: range.zone.top,
-    }).format;
+    const { sheetId, zone: { left, top, bottom }, } = range;
+    for (let row = top; row <= bottom; row++) {
+        const format = getters.getEvaluatedCell({ sheetId, col: left, row }).format;
+        if (format) {
+            return format;
+        }
+    }
+    return undefined;
 }
 function getChartLabelValues(getters, dataSets, labelRange) {
     let labels = { values: [], formattedValues: [] };
@@ -24030,11 +24035,7 @@ function canBeDateChart(labelRange, getters) {
     if (!labelRange || !canBeLinearChart(labelRange, getters)) {
         return false;
     }
-    const labelFormat = getters.getEvaluatedCell({
-        sheetId: labelRange.sheetId,
-        col: labelRange.zone.left,
-        row: labelRange.zone.top,
-    }).format;
+    const labelFormat = getChartLabelFormat(getters, labelRange);
     return Boolean(labelFormat && timeFormatLuxonCompatible.test(labelFormat));
 }
 function canBeLinearChart(labelRange, getters) {
@@ -32067,6 +32068,7 @@ class ColorPicker extends Component {
         currentColor: { type: String, optional: true },
         maxHeight: { type: Number, optional: true },
         anchorRect: Object,
+        disableNoColor: { type: Boolean, optional: true },
     };
     static defaultProps = { currentColor: "" };
     static components = { Popover };
@@ -32292,6 +32294,7 @@ class RoundColorPicker extends Component {
         currentColor: { type: String, optional: true },
         title: { type: String, optional: true },
         onColorPicked: Function,
+        disableNoColor: { type: Boolean, optional: true },
     };
     colorPickerButtonRef = useRef("colorPickerButton");
     state;
@@ -34353,6 +34356,9 @@ class ConditionalFormattingEditor extends Component {
         }
     }
     setColorScaleColor(target, color) {
+        if (!isColorValid(color)) {
+            return;
+        }
         const point = this.state.rules.colorScale[target];
         if (point) {
             point.color = Number.parseInt(color.substr(1), 16);
@@ -54275,6 +54281,9 @@ class Evaluator {
             }
             for (let i = 0; i < positions.length; ++i) {
                 const position = positions[i];
+                if (this.nextPositionsToUpdate.has(position)) {
+                    continue;
+                }
                 const evaluatedCell = this.computeCell(position);
                 if (evaluatedCell !== EMPTY_CELL) {
                     this.evaluatedCells.set(position, evaluatedCell);
@@ -54282,6 +54291,9 @@ class Evaluator {
             }
             onIterationEndEvaluationRegistry.getAll().forEach((callback) => callback(this.getters));
         }
+        if (currentIteration >= MAX_ITERATION) {
+            console.warn("Maximum iteration reached while evaluating cells");
+        }
     }
     computeCell(position) {
         const evaluation = this.evaluatedCells.get(position);
@@ -54316,7 +54328,6 @@ class Evaluator {
         }
         finally {
             this.cellsBeingComputed.delete(cellId);
-            this.nextPositionsToUpdate.delete(position);
         }
     }
     computeAndSave(position) {
@@ -54367,6 +54378,7 @@ class Evaluator {
             { sheetId, zone: rightPartZone },
             { sheetId, zone: leftColumnZone },
         ]);
+        invalidatedPositions.delete(arrayFormulaPosition);
         this.nextPositionsToUpdate.addMany(invalidatedPositions);
     }
     assertSheetHasEnoughSpaceToSpreadFormulaResult({ sheetId, col, row }, matrixResult) {
@@ -55425,25 +55437,11 @@ class EvaluationDataValidationPlugin extends UIPlugin {
         }
         switch (cmd.type) {
             case "ADD_DATA_VALIDATION_RULE":
-                const ranges = cmd.ranges.map((range) => this.getters.getRangeFromRangeData(range));
-                if (cmd.rule.criterion.type === "isBoolean") {
-                    this.setContentToBooleanCells({ ...cmd.rule, ranges });
-                }
-                delete this.validationResults[cmd.sheetId];
-                break;
             case "REMOVE_DATA_VALIDATION_RULE":
                 delete this.validationResults[cmd.sheetId];
                 break;
         }
     }
-    setContentToBooleanCells(rule) {
-        for (const position of getCellPositionsInRanges(rule.ranges)) {
-            const evaluatedCell = this.getters.getEvaluatedCell(position);
-            if (evaluatedCell.type !== CellValueType.boolean) {
-                this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
-            }
-        }
-    }
     isDataValidationInvalid(cellPosition) {
         return !this.getValidationResultForCell(cellPosition).isValid;
     }
@@ -57375,7 +57373,7 @@ class Session extends EventBus {
      * Notify the server that the user client left the collaborative session
      */
     async leave(data) {
-        if (Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
+        if (data && Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
             await this.snapshot(data());
         }
         delete this.clients[this.clientId];
@@ -58846,6 +58844,42 @@ class CellComputedStylePlugin extends UIPlugin {
     }
 }
 
+class DataValidationInsertionPlugin extends UIPlugin {
+    handle(cmd) {
+        switch (cmd.type) {
+            case "ADD_DATA_VALIDATION_RULE":
+                if (cmd.rule.criterion.type === "isBoolean") {
+                    const ranges = cmd.ranges.map((range) => this.getters.getRangeFromRangeData(range));
+                    for (const position of getCellPositionsInRanges(ranges)) {
+                        const cell = this.getters.getCell(position);
+                        const evaluatedCell = this.getters.getEvaluatedCell(position);
+                        if (!cell?.content) {
+                            this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                            // In this case, a cell has been updated in the core plugin but
+                            // not yet evaluated. This can occur after a paste operation.
+                        }
+                        else if (cell?.content && evaluatedCell.type === CellValueType.empty) {
+                            let value;
+                            if (cell.content.startsWith("=")) {
+                                const result = this.getters.evaluateFormula(position.sheetId, cell.content);
+                                value = (isMatrix(result) ? result[0][0] : result)?.toString();
+                            }
+                            else {
+                                value = cell.content;
+                            }
+                            if (!value || !isBoolean(value)) {
+                                this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                            }
+                        }
+                        else if (evaluatedCell.type !== CellValueType.boolean) {
+                            this.dispatch("UPDATE_CELL", { ...position, content: "FALSE" });
+                        }
+                    }
+                }
+        }
+    }
+}
+
 const genericRepeatsTransforms = [
     repeatSheetDependantCommand,
     repeatTargetDependantCommand,
@@ -61911,7 +61945,8 @@ const featurePluginRegistry = new Registry()
     .add("history", HistoryPlugin)
     .add("data_cleanup", DataCleanupPlugin)
     .add("table_autofill", TableAutofillPlugin)
-    .add("table_ui_resize", TableResizeUI);
+    .add("table_ui_resize", TableResizeUI)
+    .add("datavalidation_insert", DataValidationInsertionPlugin);
 // Plugins which have a state, but which should not be shared in collaborative
 const statefulUIPluginRegistry = new Registry()
     .add("selection", GridSelectionPlugin)
@@ -68073,7 +68108,8 @@ class Model extends EventBus {
         this.session.join(this.config.client);
     }
     async leaveSession() {
-        await this.session.leave(lazy(() => this.exportData()));
+        const snapshot = this.getters.isReadonly() ? undefined : lazy(() => this.exportData());
+        await this.session.leave(snapshot);
     }
     setupUiPlugin(Plugin) {
         const plugin = new Plugin(this.uiPluginConfig);
@@ -68633,6 +68669,6 @@ const constants = {
 export { AbstractCellClipboardHandler, AbstractChart, AbstractFigureClipboardHandler, CellErrorType, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, PivotRuntimeDefinition, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, SpreadsheetPivotTable, UIPlugin, __info__, addFunction, addRenderingLayer, astToFormula, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, stores, tokenColors, tokenize };
 
 
-__info__.version = "17.4.11";
-__info__.date = "2024-11-08T12:15:26.239Z";
-__info__.hash = "2eb3f1c";
+__info__.version = "17.4.13";
+__info__.date = "2024-11-22T14:17:01.675Z";
+__info__.hash = "a5e4e16";