@odoo/o-spreadsheet 17.3.2 → 17.3.4

package/dist/o-spreadsheet.iife.js

@@ -3,9 +3,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.3.2
- * @date 2024-06-10T09:38:56.657Z
- * @hash c3b358f
+ * @version 17.3.4
+ * @date 2024-06-21T20:00:08.515Z
+ * @hash 6efbf3b
  */
 
 (function (exports, owl) {
@@ -2780,7 +2780,7 @@
           return false;
       }
       if (typeof operand === "number" && operator === "=") {
-          return toString(value) === toString(operand);
+          return value.toString() === operand.toString();
       }
       if (operator === "<>" || operator === "=") {
           let result;
@@ -2840,14 +2840,13 @@
       if (countArg % 2 === 1) {
           throw new EvaluationError(_t("Function [[FUNCTION_NAME]] expects criteria_range and criterion to be in pairs."));
       }
-      const dimRow = args[0].length;
-      const dimCol = args[0][0].length;
+      const firstArg = toMatrix(args[0]);
+      const dimRow = firstArg.length;
+      const dimCol = firstArg[0].length;
       let predicates = [];
       for (let i = 0; i < countArg - 1; i += 2) {
-          const criteriaRange = args[i];
-          if (!isMatrix(criteriaRange) ||
-              criteriaRange.length !== dimRow ||
-              criteriaRange[0].length !== dimCol) {
+          const criteriaRange = toMatrix(args[i]);
+          if (criteriaRange.length !== dimRow || criteriaRange[0].length !== dimCol) {
               throw new EvaluationError(_t("Function [[FUNCTION_NAME]] expects criteria_range to have the same dimension"));
           }
           const description = toString(args[i + 1]);
@@ -2861,7 +2860,7 @@
           for (let j = 0; j < dimCol; j++) {
               let validatedPredicates = true;
               for (let k = 0; k < countArg - 1; k += 2) {
-                  const criteriaValue = args[k][i][j].value;
+                  const criteriaValue = toMatrix(args[k])[i][j].value;
                   const criterion = predicates[k / 2];
                   validatedPredicates = evaluatePredicate(criteriaValue ?? undefined, criterion);
                   if (!validatedPredicates) {
@@ -9461,10 +9460,8 @@ stores.inject(MyMetaStore, storeInstance);
               const refRange = this.getters.getRangeFromSheetXC(activeSheetId, xc);
               return isEqual(this.getters.expandZone(activeSheetId, refRange.zone), oldZone);
           });
-          // this function assumes that the previous range is always found because
-          // it's called when changing a highlight, which exists by definition
           if (!previousRefToken) {
-              throw new Error("Previous range not found");
+              return;
           }
           const previousRange = this.getters.getRangeFromSheetXC(activeSheetId, previousRefToken.value);
           this.selectionStart = previousRefToken.start;
@@ -10989,6 +10986,9 @@ stores.inject(MyMetaStore, storeInstance);
       if (types.some((t) => t.startsWith("RANGE"))) {
           result.acceptMatrix = true;
       }
+      if (types.every((t) => t.startsWith("RANGE"))) {
+          result.acceptMatrixOnly = true;
+      }
       return result;
   }
   /**
@@ -11270,11 +11270,16 @@ stores.inject(MyMetaStore, storeInstance);
       compute: function (array, ...columns) {
           const _array = toMatrix(array);
           const _columns = flattenRowFirst(columns, (item) => toInteger(item?.value, this.locale));
-          assert(() => _columns.every((col) => col > 0 && col <= _array.length), _t("The columns arguments must be between 1 and %s (got %s).", _array.length.toString(), (_columns.find((col) => col <= 0 || col > _array.length) || 0).toString()));
+          const argOutOfRange = _columns.filter((col) => col === 0 || _array.length < Math.abs(col));
+          assert(() => argOutOfRange.length === 0, _t("The columns arguments must be between -%s and %s (got %s), excluding 0.", _array.length.toString(), _array.length.toString(), argOutOfRange.join(",")));
           const result = Array(_columns.length);
           for (let col = 0; col < _columns.length; col++) {
-              const colIndex = _columns[col] - 1; // -1 because columns arguments are 1-indexed
-              result[col] = _array[colIndex];
+              if (_columns[col] > 0) {
+                  result[col] = _array[_columns[col] - 1]; // -1 because columns arguments are 1-indexed
+              }
+              else {
+                  result[col] = _array[_array.length + _columns[col]];
+              }
           }
           return result;
       },
@@ -11295,8 +11300,14 @@ stores.inject(MyMetaStore, storeInstance);
           const _array = toMatrix(array);
           const _rows = flattenRowFirst(rows, (item) => toInteger(item?.value, this.locale));
           const _nbColumns = _array.length;
-          assert(() => _rows.every((row) => row > 0 && row <= _array[0].length), _t("The rows arguments must be between 1 and %s (got %s).", _array[0].length.toString(), (_rows.find((row) => row <= 0 || row > _array[0].length) || 0).toString()));
-          return generateMatrix(_nbColumns, _rows.length, (col, row) => _array[col][_rows[row] - 1]); // -1 because rows arguments are 1-indexed
+          const argOutOfRange = _rows.filter((row) => row === 0 || _array[0].length < Math.abs(row));
+          assert(() => argOutOfRange.length === 0, _t("The rows arguments must be between -%s and %s (got %s), excluding 0.", _array[0].length.toString(), _array[0].length.toString(), argOutOfRange.join(",")));
+          return generateMatrix(_nbColumns, _rows.length, (col, row) => {
+              if (_rows[row] > 0) {
+                  return _array[col][_rows[row] - 1]; // -1 because columns arguments are 1-indexed
+              }
+              return _array[col][_array[col].length + _rows[row]];
+          });
       },
       isExported: true,
   };
@@ -19763,6 +19774,9 @@ stores.inject(MyMetaStore, storeInstance);
                   }
                   args[i] = arg[0][0];
               }
+              if (!isMatrix(arg) && argDefinition.acceptMatrixOnly) {
+                  throw new BadExpressionError(_t("Function [[FUNCTION_NAME]] expects the parameter '%s' to be reference to a cell or range.", (i + 1).toString()));
+              }
           }
           return descr.compute.apply(this, args);
       }
@@ -21357,12 +21371,6 @@ stores.inject(MyMetaStore, storeInstance);
                   // detect when an argument need to be evaluated as a meta argument
                   const isMeta = argTypes.includes("META");
                   const hasRange = argTypes.some((t) => isRangeType(t));
-                  const isRangeOnly = argTypes.every((t) => isRangeType(t));
-                  if (isRangeOnly) {
-                      if (!isRangeInput(currentArg)) {
-                          throw new BadExpressionError(_t("Function %(function_name)s expects the parameter %(arg_index)s to be a reference to a cell or a range.", { function_name: functionName, arg_index: i + 1 }));
-                      }
-                  }
                   compiledArgs.push(compileAST(currentArg, isMeta, hasRange));
               }
               return compiledArgs;
@@ -21527,16 +21535,6 @@ stores.inject(MyMetaStore, storeInstance);
   function isRangeType(type) {
       return type.startsWith("RANGE");
   }
-  function isRangeInput(arg) {
-      if (arg.type === "REFERENCE") {
-          return true;
-      }
-      if (arg.type === "FUNCALL") {
-          const fnDef = functions$1[arg.value.toUpperCase()];
-          return fnDef && isRangeType(fnDef.returns[0]);
-      }
-      return false;
-  }
 
   const functions = functionRegistry.content;
   function isExportableToExcel(tokens) {
@@ -21965,7 +21963,9 @@ stores.inject(MyMetaStore, storeInstance);
           if (!groupByField) {
               return;
           }
-          return dataSource.getPossibleFieldValues(groupByField.split(":")[0]).map(({ value, label }) => {
+          return dataSource
+              .getPossibleFieldValues(groupByField.toString().split(":")[0])
+              .map(({ value, label }) => {
               const isString = typeof value === "string";
               const text = isString ? `"${value}"` : value.toString();
               const color = isString ? tokenColors.STRING : tokenColors.NUMBER;
@@ -25451,7 +25451,7 @@ stores.inject(MyMetaStore, storeInstance);
               if (!anchor)
                   return;
               const propsMaxSize = { width: this.props.maxWidth, height: this.props.maxHeight };
-              const elDims = {
+              let elDims = {
                   width: el.getBoundingClientRect().width,
                   height: el.getBoundingClientRect().height,
               };
@@ -25459,7 +25459,14 @@ stores.inject(MyMetaStore, storeInstance);
               const popoverPositionHelper = this.props.positioning === "BottomLeft"
                   ? new BottomLeftPopoverContext(anchor, this.containerRect, propsMaxSize, spreadsheetRect)
                   : new TopRightPopoverContext(anchor, this.containerRect, propsMaxSize, spreadsheetRect);
-              const style = popoverPositionHelper.getCss(elDims, this.props.verticalOffset);
+              el.style["max-height"] = popoverPositionHelper.getMaxHeight(elDims.height) + "px";
+              el.style["max-width"] = popoverPositionHelper.getMaxWidth(elDims.width) + "px";
+              // Re-compute the dimensions after setting the max-width and max-height
+              elDims = {
+                  width: el.getBoundingClientRect().width,
+                  height: el.getBoundingClientRect().height,
+              };
+              let style = popoverPositionHelper.getCss(elDims, this.props.verticalOffset);
               for (const property of Object.keys(style)) {
                   el.style[property] = style[property];
               }
@@ -25522,8 +25529,6 @@ stores.inject(MyMetaStore, storeInstance);
           const shouldRenderAtRight = this.shouldRenderAtRight(elDims.width);
           verticalOffset = shouldRenderAtBottom ? verticalOffset : -verticalOffset;
           const cssProperties = {
-              "max-height": maxHeight + "px",
-              "max-width": maxWidth + "px",
               top: this.getTopCoordinate(actualHeight, shouldRenderAtBottom) -
                   this.spreadsheetOffset.y -
                   verticalOffset +
@@ -31337,10 +31342,8 @@ stores.inject(MyMetaStore, storeInstance);
 
   class AxisDesignEditor extends owl.Component {
       static template = "o-spreadsheet-AxisDesignEditor";
-      static components = {
-          Section,
-          ChartTitle,
-      };
+      static components = { Section, ChartTitle };
+      static props = { figureId: String, definition: Object, updateChart: Function, axesList: Array };
       state = owl.useState({ currentAxis: "x" });
       get axisTitleStyle() {
           const axisDesign = this.props.definition.axesDesign?.[this.state.currentAxis] ?? {};
@@ -31491,6 +31494,12 @@ stores.inject(MyMetaStore, storeInstance);
           AxisDesignEditor,
           RoundColorPicker,
       };
+      static props = {
+          figureId: String,
+          definition: Object,
+          canUpdateChart: Function,
+          updateChart: Function,
+      };
       state = owl.useState({ index: 0 });
       get axesList() {
           const { useLeftAxis, useRightAxis } = getDefinedAxis(this.props.definition);
@@ -31672,14 +31681,6 @@ stores.inject(MyMetaStore, storeInstance);
           const cancelledReasons = [...(this.state.sectionRuleDispatchResult?.reasons || [])];
           return cancelledReasons.map((error) => ChartTerms.Errors[error] || ChartTerms.Errors.Unexpected);
       }
-      updateBackgroundColor(color) {
-          this.props.updateChart(this.props.figureId, {
-              background: color,
-          });
-      }
-      updateTitle(content) {
-          this.props.updateChart(this.props.figureId, { title: { text: content } });
-      }
       isRangeMinInvalid() {
           return !!(this.state.sectionRuleDispatchResult?.isCancelledBecause("EmptyGaugeRangeMin" /* CommandResult.EmptyGaugeRangeMin */) ||
               this.state.sectionRuleDispatchResult?.isCancelledBecause("GaugeRangeMinNaN" /* CommandResult.GaugeRangeMinNaN */) ||
@@ -31719,9 +31720,6 @@ stores.inject(MyMetaStore, storeInstance);
               sectionRule,
           });
       }
-      get backgroundColorTitle() {
-          return ChartTerms.BackgroundColor;
-      }
   }
 
   class LineConfigPanel extends GenericChartConfigPanel {
@@ -31904,9 +31902,6 @@ stores.inject(MyMetaStore, storeInstance);
       get humanizeNumbersLabel() {
           return _t("Humanize numbers");
       }
-      updateTitle(content) {
-          this.props.updateChart(this.props.figureId, { title: { text: content } });
-      }
       updateHumanizeNumbers(humanize) {
           this.props.updateChart(this.props.figureId, { humanize });
       }
@@ -31929,9 +31924,6 @@ stores.inject(MyMetaStore, storeInstance);
                   break;
           }
       }
-      get backgroundColorTitle() {
-          return ChartTerms.BackgroundColor;
-      }
   }
 
   class WaterfallChartDesignPanel extends owl.Component {
@@ -33432,13 +33424,17 @@ stores.inject(MyMetaStore, storeInstance);
           class: { type: String, optional: true },
       };
       static components = { Menu };
+      menuId = new UuidGenerator().uuidv4();
       selectRef = owl.useRef("select");
       selectRect = useAbsoluteBoundingRect(this.selectRef);
       state = owl.useState({
           isMenuOpen: false,
       });
-      onClick() {
-          this.state.isMenuOpen = true;
+      onClick(ev) {
+          if (ev.closedMenuId === this.menuId) {
+              return;
+          }
+          this.state.isMenuOpen = !this.state.isMenuOpen;
       }
       onMenuClosed() {
           this.state.isMenuOpen = false;
@@ -33446,7 +33442,7 @@ stores.inject(MyMetaStore, storeInstance);
       get menuPosition() {
           return {
               x: this.selectRect.x,
-              y: this.selectRect.y,
+              y: this.selectRect.y + this.selectRect.height,
           };
       }
   }
@@ -34386,9 +34382,9 @@ stores.inject(MyMetaStore, storeInstance);
       static props = {
           onCloseSidePanel: Function,
       };
-      dataRange = "";
       searchInput = owl.useRef("searchInput");
       store;
+      state;
       get hasSearchResult() {
           return this.store.selectedMatchIndex !== null;
       }
@@ -34418,6 +34414,7 @@ stores.inject(MyMetaStore, storeInstance);
       }
       setup() {
           this.store = useLocalStore(FindAndReplaceStore);
+          this.state = owl.useState({ dataRange: "" });
           owl.onMounted(() => this.searchInput.el?.focus());
       }
       onFocusSearch() {
@@ -34454,13 +34451,13 @@ stores.inject(MyMetaStore, storeInstance);
           this.store.updateSearchOptions({ searchScope });
       }
       onSearchRangeChanged(ranges) {
-          this.dataRange = ranges[0];
+          this.state.dataRange = ranges[0];
       }
       updateDataRange() {
-          if (!this.dataRange || this.searchOptions.searchScope !== "specificRange") {
+          if (!this.state.dataRange || this.searchOptions.searchScope !== "specificRange") {
               return;
           }
-          const specificRange = this.env.model.getters.getRangeFromSheetXC(this.env.model.getters.getActiveSheetId(), this.dataRange);
+          const specificRange = this.env.model.getters.getRangeFromSheetXC(this.env.model.getters.getActiveSheetId(), this.state.dataRange);
           this.store.updateSearchOptions({ specificRange });
       }
   }
@@ -34926,7 +34923,7 @@ stores.inject(MyMetaStore, storeInstance);
   function createPivotDimension(fields, dimension) {
       const field = fields[dimension.name];
       const type = field?.type ?? "integer";
-      const granularity = field && isDateField(field) ? dimension.granularity ?? "month_number" : undefined;
+      const granularity = field && isDateField(field) ? dimension.granularity : undefined;
       return {
           /**
            * Get the display name of the dimension
@@ -35329,10 +35326,13 @@ stores.inject(MyMetaStore, storeInstance);
   }
 
   function createDate(dimension, value, locale) {
-      const granularity = dimension.granularity || "month_number";
-      if (!(granularity in MAP_VALUE_DIMENSION_DATE)) {
+      const granularity = dimension.granularity;
+      if (!granularity || !(granularity in MAP_VALUE_DIMENSION_DATE)) {
           throw new Error(`Unknown date granularity: ${granularity}`);
       }
+      if (value === null) {
+          return null;
+      }
       if (!MAP_VALUE_DIMENSION_DATE[granularity].set.has(value)) {
           MAP_VALUE_DIMENSION_DATE[granularity].set.add(value);
           const date = toJsDate(value, locale);
@@ -35559,7 +35559,8 @@ stores.inject(MyMetaStore, storeInstance);
           if (!finalCell) {
               return { value: "" };
           }
-          if (finalCell.value === null) {
+          // Value can be null but stringified (e.g. an empty date, as for now every date is stringified)
+          if (finalCell.value === null || finalCell.value === `${null}`) {
               return { value: _t("(Undefined)") };
           }
           if (dimension.type === "date") {
@@ -35595,10 +35596,15 @@ stores.inject(MyMetaStore, storeInstance);
           if (!operator) {
               throw new Error(`Aggregator ${aggregator} does not exist`);
           }
-          return {
-              value: values.length ? operator.fn([values], this.getters.getLocale()) : "",
-              format: operator.format(values[0]),
-          };
+          try {
+              return {
+                  value: values.length ? operator.fn([values], this.getters.getLocale()) : "",
+                  format: operator.format(values[0]),
+              };
+          }
+          catch (e) {
+              return handleError(e, aggregator.toUpperCase());
+          }
       }
       getPossibleFieldValues(groupBy) {
           //TODO This method should be implemented for the autocomplete feature
@@ -36131,6 +36137,7 @@ stores.inject(MyMetaStore, storeInstance);
   class RemoveDuplicatesPanel extends owl.Component {
       static template = "o-spreadsheet-RemoveDuplicatesPanel";
       static components = { ValidationMessages, Section, Checkbox };
+      static props = { onCloseSidePanel: Function };
       state = owl.useState({
           hasHeader: false,
           columns: {},
@@ -38555,7 +38562,7 @@ stores.inject(MyMetaStore, storeInstance);
           });
       }
       getContainerRect(container) {
-          const { width: viewWidth, height: viewHeight } = this.env.model.getters.getMainViewportRect();
+          const { width: viewWidth, height: viewHeight } = this.env.model.getters.getSheetViewDimension();
           const { x: viewportX, y: viewportY } = this.env.model.getters.getMainViewportCoordinates();
           const x = ["bottomRight", "topRight"].includes(container) ? viewportX : 0;
           const width = viewWidth - x;
@@ -51160,22 +51167,6 @@ stores.inject(MyMetaStore, storeInstance);
                   this.addPivotFormula(cellPosition, formulaId, pivotCell);
               }
           }
-          const pivotZone = {
-              top: position.row,
-              bottom: position.row + pivotCells[0].length - 1,
-              left: position.col,
-              right: position.col + pivotCells.length - 1,
-          };
-          const numberOfHeaders = table.columns.length - 1;
-          const cmdContent = {
-              sheetId: position.sheetId,
-              ranges: [this.getters.getRangeDataFromZone(position.sheetId, pivotZone)],
-              config: { ...PIVOT_TABLE_CONFIG, numberOfHeaders },
-              tableType: "static",
-          };
-          if (this.canDispatch("CREATE_TABLE", cmdContent).isSuccessful) {
-              this.dispatch("CREATE_TABLE", cmdContent);
-          }
       }
       resizeSheet(sheetId, { col, row }, table) {
           const colLimit = table.getNumberOfDataColumns() + 1; // +1 for the Top-Left
@@ -52855,7 +52846,6 @@ stores.inject(MyMetaStore, storeInstance);
           if (!this.blockedArrayFormulas.has(position)) {
               this.invalidateSpreading(position);
           }
-          this.spreadingRelations.removeNode(position);
           const cell = this.getters.getCell(position);
           if (cell === undefined) {
               return EMPTY_CELL;
@@ -52897,6 +52887,7 @@ stores.inject(MyMetaStore, storeInstance);
           this.assertSheetHasEnoughSpaceToSpreadFormulaResult(formulaPosition, formulaReturn);
           const nbColumns = formulaReturn.length;
           const nbRows = formulaReturn[0].length;
+          this.spreadingRelations.removeNode(formulaPosition);
           forEachSpreadPositionInMatrix(nbColumns, nbRows, this.updateSpreadRelation(formulaPosition));
           this.assertNoMergedCellsInSpreadZone(formulaPosition, formulaReturn);
           forEachSpreadPositionInMatrix(nbColumns, nbRows, this.checkCollision(formulaPosition));
@@ -55901,7 +55892,10 @@ stores.inject(MyMetaStore, storeInstance);
       /**
        * Notify the server that the user client left the collaborative session
        */
-      leave() {
+      leave(data) {
+          if (Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
+              this.snapshot(data);
+          }
           delete this.clients[this.clientId];
           this.transportService.leave(this.clientId);
           this.transportService.sendMessage({
@@ -55914,6 +55908,9 @@ stores.inject(MyMetaStore, storeInstance);
        * Send a snapshot of the spreadsheet to the collaboration server
        */
       snapshot(data) {
+          if (this.pendingMessages.length !== 0) {
+              return;
+          }
           const snapshotId = this.uuidGenerator.uuidv4();
           this.transportService.sendMessage({
               type: "SNAPSHOT",
@@ -66401,7 +66398,7 @@ stores.inject(MyMetaStore, storeInstance);
           this.session.join(this.config.client);
       }
       leaveSession() {
-          this.session.leave();
+          this.session.leave(this.exportData());
       }
       setupUiPlugin(Plugin) {
           const plugin = new Plugin(this.uiPluginConfig);
@@ -66992,9 +66989,9 @@ stores.inject(MyMetaStore, storeInstance);
   exports.tokenize = tokenize;
 
 
-  __info__.version = "17.3.2";
-  __info__.date = "2024-06-10T09:38:56.657Z";
-  __info__.hash = "c3b358f";
+  __info__.version = "17.3.4";
+  __info__.date = "2024-06-21T20:00:08.515Z";
+  __info__.hash = "6efbf3b";
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);