@odoo/o-spreadsheet 17.3.2 → 17.3.3

package/dist/o-spreadsheet.cjs.js

@@ -3,9 +3,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.3.2
- * @date 2024-06-10T09:38:56.657Z
- * @hash c3b358f
+ * @version 17.3.3
+ * @date 2024-06-14T10:02:58.082Z
+ * @hash c690e9f
  */
 
 'use strict';
@@ -2781,7 +2781,7 @@ function evaluatePredicate(value, criterion) {
         return false;
     }
     if (typeof operand === "number" && operator === "=") {
-        return toString(value) === toString(operand);
+        return value.toString() === operand.toString();
     }
     if (operator === "<>" || operator === "=") {
         let result;
@@ -2841,14 +2841,13 @@ function visitMatchingRanges(args, cb, locale, isQuery = false) {
     if (countArg % 2 === 1) {
         throw new EvaluationError(_t("Function [[FUNCTION_NAME]] expects criteria_range and criterion to be in pairs."));
     }
-    const dimRow = args[0].length;
-    const dimCol = args[0][0].length;
+    const firstArg = toMatrix(args[0]);
+    const dimRow = firstArg.length;
+    const dimCol = firstArg[0].length;
     let predicates = [];
     for (let i = 0; i < countArg - 1; i += 2) {
-        const criteriaRange = args[i];
-        if (!isMatrix(criteriaRange) ||
-            criteriaRange.length !== dimRow ||
-            criteriaRange[0].length !== dimCol) {
+        const criteriaRange = toMatrix(args[i]);
+        if (criteriaRange.length !== dimRow || criteriaRange[0].length !== dimCol) {
             throw new EvaluationError(_t("Function [[FUNCTION_NAME]] expects criteria_range to have the same dimension"));
         }
         const description = toString(args[i + 1]);
@@ -2862,7 +2861,7 @@ function visitMatchingRanges(args, cb, locale, isQuery = false) {
         for (let j = 0; j < dimCol; j++) {
             let validatedPredicates = true;
             for (let k = 0; k < countArg - 1; k += 2) {
-                const criteriaValue = args[k][i][j].value;
+                const criteriaValue = toMatrix(args[k])[i][j].value;
                 const criterion = predicates[k / 2];
                 validatedPredicates = evaluatePredicate(criteriaValue ?? undefined, criterion);
                 if (!validatedPredicates) {
@@ -10990,6 +10989,9 @@ function makeArg(str, description) {
     if (types.some((t) => t.startsWith("RANGE"))) {
         result.acceptMatrix = true;
     }
+    if (types.every((t) => t.startsWith("RANGE"))) {
+        result.acceptMatrixOnly = true;
+    }
     return result;
 }
 /**
@@ -11271,11 +11273,16 @@ const CHOOSECOLS = {
     compute: function (array, ...columns) {
         const _array = toMatrix(array);
         const _columns = flattenRowFirst(columns, (item) => toInteger(item?.value, this.locale));
-        assert(() => _columns.every((col) => col > 0 && col <= _array.length), _t("The columns arguments must be between 1 and %s (got %s).", _array.length.toString(), (_columns.find((col) => col <= 0 || col > _array.length) || 0).toString()));
+        const argOutOfRange = _columns.filter((col) => col === 0 || _array.length < Math.abs(col));
+        assert(() => argOutOfRange.length === 0, _t("The columns arguments must be between -%s and %s (got %s), excluding 0.", _array.length.toString(), _array.length.toString(), argOutOfRange.join(",")));
         const result = Array(_columns.length);
         for (let col = 0; col < _columns.length; col++) {
-            const colIndex = _columns[col] - 1; // -1 because columns arguments are 1-indexed
-            result[col] = _array[colIndex];
+            if (_columns[col] > 0) {
+                result[col] = _array[_columns[col] - 1]; // -1 because columns arguments are 1-indexed
+            }
+            else {
+                result[col] = _array[_array.length + _columns[col]];
+            }
         }
         return result;
     },
@@ -11296,8 +11303,14 @@ const CHOOSEROWS = {
         const _array = toMatrix(array);
         const _rows = flattenRowFirst(rows, (item) => toInteger(item?.value, this.locale));
         const _nbColumns = _array.length;
-        assert(() => _rows.every((row) => row > 0 && row <= _array[0].length), _t("The rows arguments must be between 1 and %s (got %s).", _array[0].length.toString(), (_rows.find((row) => row <= 0 || row > _array[0].length) || 0).toString()));
-        return generateMatrix(_nbColumns, _rows.length, (col, row) => _array[col][_rows[row] - 1]); // -1 because rows arguments are 1-indexed
+        const argOutOfRange = _rows.filter((row) => row === 0 || _array[0].length < Math.abs(row));
+        assert(() => argOutOfRange.length === 0, _t("The rows arguments must be between -%s and %s (got %s), excluding 0.", _array[0].length.toString(), _array[0].length.toString(), argOutOfRange.join(",")));
+        return generateMatrix(_nbColumns, _rows.length, (col, row) => {
+            if (_rows[row] > 0) {
+                return _array[col][_rows[row] - 1]; // -1 because columns arguments are 1-indexed
+            }
+            return _array[col][_array[col].length + _rows[row]];
+        });
     },
     isExported: true,
 };
@@ -19764,6 +19777,9 @@ function addInputHandling(descr) {
                 }
                 args[i] = arg[0][0];
             }
+            if (!isMatrix(arg) && argDefinition.acceptMatrixOnly) {
+                throw new BadExpressionError(_t("Function [[FUNCTION_NAME]] expects the parameter '%s' to be reference to a cell or range.", (i + 1).toString()));
+            }
         }
         return descr.compute.apply(this, args);
     }
@@ -21358,12 +21374,6 @@ function compileTokens(tokens) {
                 // detect when an argument need to be evaluated as a meta argument
                 const isMeta = argTypes.includes("META");
                 const hasRange = argTypes.some((t) => isRangeType(t));
-                const isRangeOnly = argTypes.every((t) => isRangeType(t));
-                if (isRangeOnly) {
-                    if (!isRangeInput(currentArg)) {
-                        throw new BadExpressionError(_t("Function %(function_name)s expects the parameter %(arg_index)s to be a reference to a cell or a range.", { function_name: functionName, arg_index: i + 1 }));
-                    }
-                }
                 compiledArgs.push(compileAST(currentArg, isMeta, hasRange));
             }
             return compiledArgs;
@@ -21528,16 +21538,6 @@ function assertEnoughArgs(ast) {
 function isRangeType(type) {
     return type.startsWith("RANGE");
 }
-function isRangeInput(arg) {
-    if (arg.type === "REFERENCE") {
-        return true;
-    }
-    if (arg.type === "FUNCALL") {
-        const fnDef = functions$1[arg.value.toUpperCase()];
-        return fnDef && isRangeType(fnDef.returns[0]);
-    }
-    return false;
-}
 
 const functions = functionRegistry.content;
 function isExportableToExcel(tokens) {
@@ -21966,7 +21966,9 @@ autoCompleteProviders.add("pivot_group_values", {
         if (!groupByField) {
             return;
         }
-        return dataSource.getPossibleFieldValues(groupByField.split(":")[0]).map(({ value, label }) => {
+        return dataSource
+            .getPossibleFieldValues(groupByField.toString().split(":")[0])
+            .map(({ value, label }) => {
             const isString = typeof value === "string";
             const text = isString ? `"${value}"` : value.toString();
             const color = isString ? tokenColors.STRING : tokenColors.NUMBER;
@@ -25452,7 +25454,7 @@ class Popover extends owl.Component {
             if (!anchor)
                 return;
             const propsMaxSize = { width: this.props.maxWidth, height: this.props.maxHeight };
-            const elDims = {
+            let elDims = {
                 width: el.getBoundingClientRect().width,
                 height: el.getBoundingClientRect().height,
             };
@@ -25460,7 +25462,14 @@ class Popover extends owl.Component {
             const popoverPositionHelper = this.props.positioning === "BottomLeft"
                 ? new BottomLeftPopoverContext(anchor, this.containerRect, propsMaxSize, spreadsheetRect)
                 : new TopRightPopoverContext(anchor, this.containerRect, propsMaxSize, spreadsheetRect);
-            const style = popoverPositionHelper.getCss(elDims, this.props.verticalOffset);
+            el.style["max-height"] = popoverPositionHelper.getMaxHeight(elDims.height) + "px";
+            el.style["max-width"] = popoverPositionHelper.getMaxWidth(elDims.width) + "px";
+            // Re-compute the dimensions after setting the max-width and max-height
+            elDims = {
+                width: el.getBoundingClientRect().width,
+                height: el.getBoundingClientRect().height,
+            };
+            let style = popoverPositionHelper.getCss(elDims, this.props.verticalOffset);
             for (const property of Object.keys(style)) {
                 el.style[property] = style[property];
             }
@@ -25523,8 +25532,6 @@ class PopoverPositionContext {
         const shouldRenderAtRight = this.shouldRenderAtRight(elDims.width);
         verticalOffset = shouldRenderAtBottom ? verticalOffset : -verticalOffset;
         const cssProperties = {
-            "max-height": maxHeight + "px",
-            "max-width": maxWidth + "px",
             top: this.getTopCoordinate(actualHeight, shouldRenderAtBottom) -
                 this.spreadsheetOffset.y -
                 verticalOffset +
@@ -31338,10 +31345,8 @@ class ChartTitle extends owl.Component {
 
 class AxisDesignEditor extends owl.Component {
     static template = "o-spreadsheet-AxisDesignEditor";
-    static components = {
-        Section,
-        ChartTitle,
-    };
+    static components = { Section, ChartTitle };
+    static props = { figureId: String, definition: Object, updateChart: Function, axesList: Array };
     state = owl.useState({ currentAxis: "x" });
     get axisTitleStyle() {
         const axisDesign = this.props.definition.axesDesign?.[this.state.currentAxis] ?? {};
@@ -31492,6 +31497,12 @@ class ChartWithAxisDesignPanel extends owl.Component {
         AxisDesignEditor,
         RoundColorPicker,
     };
+    static props = {
+        figureId: String,
+        definition: Object,
+        canUpdateChart: Function,
+        updateChart: Function,
+    };
     state = owl.useState({ index: 0 });
     get axesList() {
         const { useLeftAxis, useRightAxis } = getDefinedAxis(this.props.definition);
@@ -31673,14 +31684,6 @@ class GaugeChartDesignPanel extends owl.Component {
         const cancelledReasons = [...(this.state.sectionRuleDispatchResult?.reasons || [])];
         return cancelledReasons.map((error) => ChartTerms.Errors[error] || ChartTerms.Errors.Unexpected);
     }
-    updateBackgroundColor(color) {
-        this.props.updateChart(this.props.figureId, {
-            background: color,
-        });
-    }
-    updateTitle(content) {
-        this.props.updateChart(this.props.figureId, { title: { text: content } });
-    }
     isRangeMinInvalid() {
         return !!(this.state.sectionRuleDispatchResult?.isCancelledBecause("EmptyGaugeRangeMin" /* CommandResult.EmptyGaugeRangeMin */) ||
             this.state.sectionRuleDispatchResult?.isCancelledBecause("GaugeRangeMinNaN" /* CommandResult.GaugeRangeMinNaN */) ||
@@ -31720,9 +31723,6 @@ class GaugeChartDesignPanel extends owl.Component {
             sectionRule,
         });
     }
-    get backgroundColorTitle() {
-        return ChartTerms.BackgroundColor;
-    }
 }
 
 class LineConfigPanel extends GenericChartConfigPanel {
@@ -31905,9 +31905,6 @@ class ScorecardChartDesignPanel extends owl.Component {
     get humanizeNumbersLabel() {
         return _t("Humanize numbers");
     }
-    updateTitle(content) {
-        this.props.updateChart(this.props.figureId, { title: { text: content } });
-    }
     updateHumanizeNumbers(humanize) {
         this.props.updateChart(this.props.figureId, { humanize });
     }
@@ -31930,9 +31927,6 @@ class ScorecardChartDesignPanel extends owl.Component {
                 break;
         }
     }
-    get backgroundColorTitle() {
-        return ChartTerms.BackgroundColor;
-    }
 }
 
 class WaterfallChartDesignPanel extends owl.Component {
@@ -33433,13 +33427,17 @@ class SelectMenu extends owl.Component {
         class: { type: String, optional: true },
     };
     static components = { Menu };
+    menuId = new UuidGenerator().uuidv4();
     selectRef = owl.useRef("select");
     selectRect = useAbsoluteBoundingRect(this.selectRef);
     state = owl.useState({
         isMenuOpen: false,
     });
-    onClick() {
-        this.state.isMenuOpen = true;
+    onClick(ev) {
+        if (ev.closedMenuId === this.menuId) {
+            return;
+        }
+        this.state.isMenuOpen = !this.state.isMenuOpen;
     }
     onMenuClosed() {
         this.state.isMenuOpen = false;
@@ -33447,7 +33445,7 @@ class SelectMenu extends owl.Component {
     get menuPosition() {
         return {
             x: this.selectRect.x,
-            y: this.selectRect.y,
+            y: this.selectRect.y + this.selectRect.height,
         };
     }
 }
@@ -34387,9 +34385,9 @@ class FindAndReplacePanel extends owl.Component {
     static props = {
         onCloseSidePanel: Function,
     };
-    dataRange = "";
     searchInput = owl.useRef("searchInput");
     store;
+    state;
     get hasSearchResult() {
         return this.store.selectedMatchIndex !== null;
     }
@@ -34419,6 +34417,7 @@ class FindAndReplacePanel extends owl.Component {
     }
     setup() {
         this.store = useLocalStore(FindAndReplaceStore);
+        this.state = owl.useState({ dataRange: "" });
         owl.onMounted(() => this.searchInput.el?.focus());
     }
     onFocusSearch() {
@@ -34455,13 +34454,13 @@ class FindAndReplacePanel extends owl.Component {
         this.store.updateSearchOptions({ searchScope });
     }
     onSearchRangeChanged(ranges) {
-        this.dataRange = ranges[0];
+        this.state.dataRange = ranges[0];
     }
     updateDataRange() {
-        if (!this.dataRange || this.searchOptions.searchScope !== "specificRange") {
+        if (!this.state.dataRange || this.searchOptions.searchScope !== "specificRange") {
             return;
         }
-        const specificRange = this.env.model.getters.getRangeFromSheetXC(this.env.model.getters.getActiveSheetId(), this.dataRange);
+        const specificRange = this.env.model.getters.getRangeFromSheetXC(this.env.model.getters.getActiveSheetId(), this.state.dataRange);
         this.store.updateSearchOptions({ specificRange });
     }
 }
@@ -36132,6 +36131,7 @@ css /* scss */ `
 class RemoveDuplicatesPanel extends owl.Component {
     static template = "o-spreadsheet-RemoveDuplicatesPanel";
     static components = { ValidationMessages, Section, Checkbox };
+    static props = { onCloseSidePanel: Function };
     state = owl.useState({
         hasHeader: false,
         columns: {},
@@ -38556,7 +38556,7 @@ class FiguresContainer extends owl.Component {
         });
     }
     getContainerRect(container) {
-        const { width: viewWidth, height: viewHeight } = this.env.model.getters.getMainViewportRect();
+        const { width: viewWidth, height: viewHeight } = this.env.model.getters.getSheetViewDimension();
         const { x: viewportX, y: viewportY } = this.env.model.getters.getMainViewportCoordinates();
         const x = ["bottomRight", "topRight"].includes(container) ? viewportX : 0;
         const width = viewWidth - x;
@@ -51161,22 +51161,6 @@ class PivotCorePlugin extends CorePlugin {
                 this.addPivotFormula(cellPosition, formulaId, pivotCell);
             }
         }
-        const pivotZone = {
-            top: position.row,
-            bottom: position.row + pivotCells[0].length - 1,
-            left: position.col,
-            right: position.col + pivotCells.length - 1,
-        };
-        const numberOfHeaders = table.columns.length - 1;
-        const cmdContent = {
-            sheetId: position.sheetId,
-            ranges: [this.getters.getRangeDataFromZone(position.sheetId, pivotZone)],
-            config: { ...PIVOT_TABLE_CONFIG, numberOfHeaders },
-            tableType: "static",
-        };
-        if (this.canDispatch("CREATE_TABLE", cmdContent).isSuccessful) {
-            this.dispatch("CREATE_TABLE", cmdContent);
-        }
     }
     resizeSheet(sheetId, { col, row }, table) {
         const colLimit = table.getNumberOfDataColumns() + 1; // +1 for the Top-Left
@@ -55902,7 +55886,10 @@ class Session extends EventBus {
     /**
      * Notify the server that the user client left the collaborative session
      */
-    leave() {
+    leave(data) {
+        if (Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
+            this.snapshot(data);
+        }
         delete this.clients[this.clientId];
         this.transportService.leave(this.clientId);
         this.transportService.sendMessage({
@@ -55915,6 +55902,9 @@ class Session extends EventBus {
      * Send a snapshot of the spreadsheet to the collaboration server
      */
     snapshot(data) {
+        if (this.pendingMessages.length !== 0) {
+            return;
+        }
         const snapshotId = this.uuidGenerator.uuidv4();
         this.transportService.sendMessage({
             type: "SNAPSHOT",
@@ -66402,7 +66392,7 @@ class Model extends EventBus {
         this.session.join(this.config.client);
     }
     leaveSession() {
-        this.session.leave();
+        this.session.leave(this.exportData());
     }
     setupUiPlugin(Plugin) {
         const plugin = new Plugin(this.uiPluginConfig);
@@ -66993,6 +66983,6 @@ exports.tokenColors = tokenColors;
 exports.tokenize = tokenize;
 
 
-__info__.version = "17.3.2";
-__info__.date = "2024-06-10T09:38:56.657Z";
-__info__.hash = "c3b358f";
+__info__.version = "17.3.3";
+__info__.date = "2024-06-14T10:02:58.082Z";
+__info__.hash = "c690e9f";

package/dist/o-spreadsheet.d.ts

@@ -3800,7 +3800,7 @@ declare class Session extends EventBus<CollaborativeEvent> {
     /**
      * Notify the server that the user client left the collaborative session
      */
-    leave(): void;
+    leave(data: WorkbookData): void;
     /**
      * Send a snapshot of the spreadsheet to the collaboration server
      */
@@ -5144,6 +5144,7 @@ type Getters = {
 type ArgType = "ANY" | "BOOLEAN" | "NUMBER" | "STRING" | "DATE" | "RANGE" | "RANGE<BOOLEAN>" | "RANGE<NUMBER>" | "RANGE<DATE>" | "RANGE<STRING>" | "RANGE<ANY>" | "META";
 interface ArgDefinition {
     acceptMatrix?: boolean;
+    acceptMatrixOnly?: boolean;
     repeating?: boolean;
     optional?: boolean;
     description: string;
@@ -6986,6 +6987,12 @@ declare class AxisDesignEditor extends Component<Props$O, SpreadsheetChildEnv> {
         Section: typeof Section;
         ChartTitle: typeof ChartTitle;
     };
+    static props: {
+        figureId: StringConstructor;
+        definition: ObjectConstructor;
+        updateChart: FunctionConstructor;
+        axesList: ArrayConstructor;
+    };
     state: {
         currentAxis: string;
     };
@@ -7049,6 +7056,12 @@ declare class ChartWithAxisDesignPanel extends Component<Props$M, SpreadsheetChi
         AxisDesignEditor: typeof AxisDesignEditor;
         RoundColorPicker: typeof RoundColorPicker;
     };
+    static props: {
+        figureId: StringConstructor;
+        definition: ObjectConstructor;
+        canUpdateChart: FunctionConstructor;
+        updateChart: FunctionConstructor;
+    };
     private state;
     get axesList(): AxisDefinition[];
     updateLegendPosition(ev: any): void;
@@ -7120,8 +7133,6 @@ declare class GaugeChartDesignPanel extends Component<Props$K, SpreadsheetChildE
     protected state: PanelState;
     setup(): void;
     get designErrorMessages(): string[];
-    updateBackgroundColor(color: Color): void;
-    updateTitle(content: string): void;
     isRangeMinInvalid(): boolean;
     isRangeMaxInvalid(): boolean;
     get isLowerInflectionPointInvalid(): boolean;
@@ -7129,7 +7140,6 @@ declare class GaugeChartDesignPanel extends Component<Props$K, SpreadsheetChildE
     updateSectionColor(target: string, color: Color): void;
     updateSectionRule(sectionRule: SectionRule): void;
     canUpdateSectionRule(sectionRule: SectionRule): void;
-    get backgroundColorTitle(): string;
 }
 
 declare class LineConfigPanel extends GenericChartConfigPanel {
@@ -7210,12 +7220,10 @@ declare class ScorecardChartDesignPanel extends Component<Props$I, SpreadsheetCh
     };
     get colorsSectionTitle(): string;
     get humanizeNumbersLabel(): string;
-    updateTitle(content: string): void;
     updateHumanizeNumbers(humanize: boolean): void;
     translate(term: any): string;
     updateBaselineDescr(ev: any): void;
     setColor(color: Color, colorPickerId: ColorPickerId): void;
-    get backgroundColorTitle(): string;
 }
 
 interface ChartSidePanel {