@odoo/o-spreadsheet 17.3.0-alpha.1 → 17.3.0-alpha.2

package/dist/o-spreadsheet.cjs.js

@@ -3,9 +3,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.3.0-alpha.1
- * @date 2024-03-25T09:43:36.072Z
- * @hash 4095c41
+ * @version 17.3.0-alpha.2
+ * @date 2024-04-05T14:01:07.060Z
+ * @hash 8c5a229
  */
 
 'use strict';
@@ -466,7 +466,7 @@ function getItemId(item, itemsDic) {
     }
     // Generate new Id if the item didn't exist in the dictionary
     const ids = Object.keys(itemsDic);
-    const maxId = ids.length === 0 ? 0 : Math.max(...ids.map((id) => parseInt(id, 10)));
+    const maxId = ids.length === 0 ? 0 : largeMax(ids.map((id) => parseInt(id, 10)));
     itemsDic[maxId + 1] = item;
     return maxId + 1;
 }
@@ -484,7 +484,7 @@ function debounce(func, wait, immediate) {
     let timeout = undefined;
     const debounced = function () {
         const context = this;
-        const args = arguments;
+        const args = Array.from(arguments);
         function later() {
             timeout = undefined;
             if (!immediate) {
@@ -686,6 +686,34 @@ function getSearchRegex(searchStr, searchOptions) {
     }
     return RegExp(searchValue, flags);
 }
+/**
+ * Alternative to Math.max that works with large arrays.
+ * Typically useful for arrays bigger than 100k elements.
+ */
+function largeMax(array) {
+    let len = array.length;
+    if (len < 100_000)
+        return Math.max(...array);
+    let max = -Infinity;
+    while (len--) {
+        max = array[len] > max ? array[len] : max;
+    }
+    return max;
+}
+/**
+ * Alternative to Math.min that works with large arrays.
+ * Typically useful for arrays bigger than 100k elements.
+ */
+function largeMin(array) {
+    let len = array.length;
+    if (len < 100_000)
+        return Math.min(...array);
+    let min = +Infinity;
+    while (len--) {
+        min = array[len] < min ? array[len] : min;
+    }
+    return min;
+}
 
 const RBA_REGEX = /rgba?\(|\s+|\)/gi;
 const HEX_MATCH = /^#([A-F\d]{2}){3,4}$/;
@@ -2088,6 +2116,7 @@ exports.CommandResult = void 0;
     CommandResult["InvalidCopyPasteSelection"] = "InvalidCopyPasteSelection";
     CommandResult["NoChanges"] = "NoChanges";
     CommandResult["InvalidInputId"] = "InvalidInputId";
+    CommandResult["SheetIsHidden"] = "SheetIsHidden";
 })(exports.CommandResult || (exports.CommandResult = {}));
 
 const PLAIN_TEXT_FORMAT = "@"; // see OpenXML spec §18.8.31
@@ -4559,8 +4588,9 @@ function computeTextLinesHeight(textLineHeight, numberOfLines = 1) {
  * Get the default height of the cell given its style.
  */
 function getDefaultCellHeight(ctx, cell, colSize) {
-    if (!cell || !cell.content)
+    if (!cell || (!cell.isFormula && !cell.content)) {
         return DEFAULT_CELL_HEIGHT;
+    }
     const maxWidth = cell.style?.wrapping === "wrap" ? colSize - 2 * MIN_CELL_TEXT_MARGIN : undefined;
     const numberOfLines = cell.isFormula
         ? 1
@@ -6994,10 +7024,17 @@ urlRegistry.add("sheet_URL", {
     },
     open(url, env) {
         const sheetId = parseSheetUrl(url);
-        env.model.dispatch("ACTIVATE_SHEET", {
+        const result = env.model.dispatch("ACTIVATE_SHEET", {
             sheetIdFrom: env.model.getters.getActiveSheetId(),
             sheetIdTo: sheetId,
         });
+        if (result.isCancelledBecause("SheetIsHidden" /* CommandResult.SheetIsHidden */)) {
+            env.notifyUser({
+                type: "warning",
+                sticky: false,
+                text: _t("Cannot open the link because the linked sheet is hidden."),
+            });
+        }
     },
     sequence: 0,
 });
@@ -7113,7 +7150,7 @@ function textCell(value, format, formattedValue) {
 }
 function numberCell(value, format, formattedValue) {
     return {
-        value: value || 0,
+        value: value || 0, // necessary to avoid "-0" and NaN values,
         format,
         formattedValue,
         type: CellValueType.number,
@@ -9957,11 +9994,11 @@ autoCompleteProviders.add("dataValidation", {
         }
         else {
             const range = this.getters.getRangeFromSheetXC(position.sheetId, rule.criterion.values[0]);
-            values = this.getters
+            values = Array.from(new Set(this.getters
                 .getRangeValues(range)
                 .filter(isNotNull)
                 .map((value) => value.toString())
-                .filter((val) => val !== "");
+                .filter((val) => val !== "")));
         }
         return values.map((value) => ({ text: value }));
     },
@@ -19408,10 +19445,10 @@ function aggregateDataForLabels(labels, datasets) {
         }
     }
     return {
-        labels: Object.keys(labelMap),
+        labels: Array.from(labelSet),
         dataSetsValues: datasets.map((dataset, indexOfDataset) => ({
             ...dataset,
-            data: Object.values(labelMap).map((dataOfLabel) => dataOfLabel[indexOfDataset]),
+            data: Array.from(labelSet).map((label) => labelMap[label][indexOfDataset]),
         })),
     };
 }
@@ -19430,8 +19467,8 @@ function truncateLabel(label) {
 function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale }) {
     const options = {
         // https://www.chartjs.org/docs/latest/general/responsive.html
-        responsive: true,
-        maintainAspectRatio: false,
+        responsive: true, // will resize when its container is resized
+        maintainAspectRatio: false, // doesn't maintain the aspect ration (width/height =2 by default) so the user has the choice of the exact layout
         layout: {
             padding: { left: 20, right: 20, top: chart.title ? 10 : 25, bottom: 10 },
         },
@@ -19477,7 +19514,7 @@ function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale })
             labels: labels.map(truncateLabel),
             datasets: [],
         },
-        platform: undefined,
+        platform: undefined, // This key is optional and will be set by chart.js
         plugins: [],
     };
 }
@@ -19754,7 +19791,7 @@ function getBarConfiguration(chart, labels, localeFormat) {
         },
         y: {
             position: chart.verticalAxisPosition,
-            beginAtZero: true,
+            beginAtZero: true, // the origin of the y axis is always zero
             ticks: {
                 color: fontColor,
                 callback: (value) => {
@@ -19805,6 +19842,204 @@ function createBarChartRuntime(chart, getters) {
     return { chartJsConfig: config, background: chart.background || BACKGROUND_CHART_COLOR };
 }
 
+class ComboChart extends AbstractChart {
+    useBothYAxis;
+    dataSets;
+    labelRange;
+    background;
+    verticalAxisPosition;
+    legendPosition;
+    aggregated;
+    dataSetsHaveTitle;
+    type = "combo";
+    constructor(definition, sheetId, getters) {
+        super(definition, sheetId, getters);
+        this.dataSets = createDataSets(getters, definition.dataSets, sheetId, definition.dataSetsHaveTitle);
+        this.labelRange = createRange(getters, sheetId, definition.labelRange);
+        this.background = definition.background;
+        this.verticalAxisPosition = definition.verticalAxisPosition;
+        this.legendPosition = definition.legendPosition;
+        this.aggregated = definition.aggregated;
+        this.dataSetsHaveTitle = definition.dataSetsHaveTitle;
+        this.useBothYAxis = definition.useBothYAxis;
+    }
+    static transformDefinition(definition, executed) {
+        return transformChartDefinitionWithDataSetsWithZone(definition, executed);
+    }
+    static validateChartDefinition(validator, definition) {
+        return validator.checkValidations(definition, checkDataset, checkLabelRange);
+    }
+    getContextCreation() {
+        return {
+            background: this.background,
+            title: this.title,
+            range: this.dataSets.map((ds) => this.getters.getRangeString(ds.dataRange, this.sheetId)),
+            auxiliaryRange: this.labelRange
+                ? this.getters.getRangeString(this.labelRange, this.sheetId)
+                : undefined,
+            aggregated: this.aggregated,
+        };
+    }
+    getDefinition() {
+        return this.getDefinitionWithSpecificDataSets(this.dataSets, this.labelRange);
+    }
+    getDefinitionWithSpecificDataSets(dataSets, labelRange, targetSheetId) {
+        return {
+            type: "combo",
+            dataSetsHaveTitle: dataSets.length ? Boolean(dataSets[0].labelCell) : false,
+            background: this.background,
+            dataSets: dataSets.map((ds) => this.getters.getRangeString(ds.dataRange, targetSheetId || this.sheetId)),
+            legendPosition: this.legendPosition,
+            verticalAxisPosition: this.verticalAxisPosition,
+            labelRange: labelRange
+                ? this.getters.getRangeString(labelRange, targetSheetId || this.sheetId)
+                : undefined,
+            title: this.title,
+            aggregated: this.aggregated,
+            useBothYAxis: this.useBothYAxis,
+        };
+    }
+    getDefinitionForExcel() {
+        // Excel does not support aggregating labels
+        if (this.aggregated) {
+            return undefined;
+        }
+        const dataSets = this.dataSets
+            .map((ds) => toExcelDataset(this.getters, ds))
+            .filter((ds) => ds.range !== "" && ds.range !== CellErrorType.InvalidReference);
+        const labelRange = toExcelLabelRange(this.getters, this.labelRange, shouldRemoveFirstLabel(this.labelRange, this.dataSets[0], this.dataSetsHaveTitle));
+        return {
+            ...this.getDefinition(),
+            backgroundColor: toXlsxHexColor(this.background || BACKGROUND_CHART_COLOR),
+            fontColor: toXlsxHexColor(chartFontColor(this.background)),
+            dataSets,
+            labelRange,
+        };
+    }
+    updateRanges(applyChange) {
+        const { dataSets, labelRange, isStale } = updateChartRangesWithDataSets(this.getters, applyChange, this.dataSets, this.labelRange);
+        if (!isStale) {
+            return this;
+        }
+        const definition = this.getDefinitionWithSpecificDataSets(dataSets, labelRange);
+        return new ComboChart(definition, this.sheetId, this.getters);
+    }
+    static getDefinitionFromContextCreation(context) {
+        return {
+            background: context.background,
+            dataSets: context.range ? context.range : [],
+            dataSetsHaveTitle: false,
+            aggregated: context.aggregated,
+            legendPosition: "top",
+            title: context.title || "",
+            verticalAxisPosition: "left",
+            labelRange: context.auxiliaryRange || undefined,
+            type: "combo",
+            useBothYAxis: false,
+        };
+    }
+    copyForSheetId(sheetId) {
+        const dataSets = copyDataSetsWithNewSheetId(this.sheetId, sheetId, this.dataSets);
+        const labelRange = copyLabelRangeWithNewSheetId(this.sheetId, sheetId, this.labelRange);
+        const definition = this.getDefinitionWithSpecificDataSets(dataSets, labelRange, sheetId);
+        return new ComboChart(definition, sheetId, this.getters);
+    }
+    copyInSheetId(sheetId) {
+        const definition = this.getDefinitionWithSpecificDataSets(this.dataSets, this.labelRange, sheetId);
+        return new ComboChart(definition, sheetId, this.getters);
+    }
+}
+function createComboChartRuntime(chart, getters) {
+    const dataSetFormat = getChartDatasetFormat(getters, chart.dataSets);
+    const locale = getters.getLocale();
+    const labelValues = getChartLabelValues(getters, chart.dataSets, chart.labelRange);
+    let labels = labelValues.formattedValues;
+    let dataSetsValues = getChartDatasetValues(getters, chart.dataSets);
+    if (chart.dataSetsHaveTitle &&
+        dataSetsValues[0] &&
+        labels.length > dataSetsValues[0].data.length) {
+        labels.shift();
+    }
+    ({ labels, dataSetsValues } = filterEmptyDataPoints(labels, dataSetsValues));
+    if (chart.aggregated) {
+        ({ labels, dataSetsValues } = aggregateDataForLabels(labels, dataSetsValues));
+    }
+    const localeFormat = { format: dataSetFormat, locale };
+    const fontColor = chartFontColor(chart.background);
+    const config = getDefaultChartJsRuntime(chart, labels, fontColor, localeFormat);
+    const legend = {
+        labels: { color: fontColor },
+    };
+    if ((!chart.labelRange && chart.dataSets.length === 1) || chart.legendPosition === "none") {
+        legend.display = false;
+    }
+    else {
+        legend.position = chart.legendPosition;
+    }
+    config.options.plugins.legend = { ...config.options.plugins?.legend, ...legend };
+    config.options.layout = {
+        padding: { left: 20, right: 20, top: chart.title ? 10 : 25, bottom: 10 },
+    };
+    config.options.scales = {
+        x: {
+            ticks: {
+                padding: 5,
+                color: fontColor,
+            },
+        },
+    };
+    const verticalAxis = {
+        beginAtZero: true, // the origin of the y axis is always zero
+        ticks: {
+            color: fontColor,
+            callback: (value) => {
+                value = Number(value);
+                if (isNaN(value))
+                    return value;
+                const { locale, format } = localeFormat;
+                return formatValue(value, {
+                    locale,
+                    format: !format && Math.abs(value) >= 1000 ? "#,##" : format,
+                });
+            },
+        },
+    };
+    if (chart.useBothYAxis) {
+        config.options.scales.y = {
+            ...verticalAxis,
+            position: "left",
+        };
+        config.options.scales.y1 = {
+            ...verticalAxis,
+            position: "right",
+            grid: {
+                display: false,
+            },
+        };
+    }
+    else {
+        config.options.scales.y = {
+            ...verticalAxis,
+            position: chart.verticalAxisPosition,
+        };
+    }
+    const colors = new ChartColors();
+    for (let [index, { label, data }] of dataSetsValues.entries()) {
+        const color = colors.next();
+        const dataset = {
+            label,
+            data,
+            borderColor: color,
+            backgroundColor: color,
+            yAxisID: index > 0 && chart.useBothYAxis ? "y1" : "y",
+            type: index === 0 ? "bar" : "line",
+            order: -index,
+        };
+        config.data.datasets.push(dataset);
+    }
+    return { chartJsConfig: config, background: chart.background || BACKGROUND_CHART_COLOR };
+}
+
 function isDataRangeValid(definition) {
     return definition.dataRange && !rangeReference.test(definition.dataRange)
         ? "InvalidGaugeDataRange" /* CommandResult.InvalidGaugeDataRange */
@@ -20143,7 +20378,7 @@ function getBestTimeUnitForScale(labels, format, locale) {
         return undefined;
     }
     const labelsTimestamps = labelDates.map((date) => date.getTime());
-    const period = Math.max(...labelsTimestamps) - Math.min(...labelsTimestamps);
+    const period = largeMax(labelsTimestamps) - largeMin(labelsTimestamps);
     const minUnit = getFormatMinDisplayUnit(format);
     if (UNIT_LENGTH.second >= UNIT_LENGTH[minUnit] && Milliseconds.inSeconds(period) < 180) {
         return "second";
@@ -20275,7 +20510,7 @@ function getLineOrScatterConfiguration(chart, labels, localeFormat) {
         },
         y: {
             position: chart.verticalAxisPosition,
-            beginAtZero: true,
+            beginAtZero: true, // the origin of the y axis is always zero
             ticks: {
                 color: fontColor,
                 callback: (value) => {
@@ -20361,7 +20596,7 @@ function createLineOrScatterChartRuntime(chart, getters) {
         const dataset = {
             label,
             data,
-            tension: 0,
+            tension: 0, // 0 -> render straight lines, which is much faster
             borderColor: color,
             backgroundColor,
             pointBackgroundColor: color,
@@ -20583,7 +20818,7 @@ class PieChart extends AbstractChart {
             ...this.getDefinition(),
             backgroundColor: toXlsxHexColor(this.background || BACKGROUND_CHART_COLOR),
             fontColor: toXlsxHexColor(chartFontColor(this.background)),
-            verticalAxisPosition: "left",
+            verticalAxisPosition: "left", //TODO ExcelChartDefinition should be adapted, but can be done later
             dataSets,
             labelRange,
         };
@@ -20631,7 +20866,7 @@ function getPieConfiguration(chart, labels, localeFormat) {
 }
 function getPieColors(colors, dataSetsValues) {
     const pieColors = [];
-    const maxLength = Math.max(...dataSetsValues.map((ds) => ds.data.length));
+    const maxLength = largeMax(dataSetsValues.map((ds) => ds.data.length));
     for (let i = 0; i <= maxLength; i++) {
         pieColors.push(colors.next());
     }
@@ -20800,7 +21035,7 @@ function createScatterChartRuntime(chart, getters) {
     configOptions.elements = {
         point: {
             radius: 3,
-            hoverRadius: 3,
+            hoverRadius: 3, // chartJS seems bugged, the point starts with the "hoverRadius" value
             hitRadius: 8,
         },
     };
@@ -20840,6 +21075,16 @@ chartRegistry.add("bar", {
     name: _t("Bar"),
     sequence: 10,
 });
+chartRegistry.add("combo", {
+    match: (type) => type === "combo",
+    createChart: (definition, sheetId, getters) => new ComboChart(definition, sheetId, getters),
+    getChartRuntime: createComboChartRuntime,
+    validateChartDefinition: (validator, definition) => ComboChart.validateChartDefinition(validator, definition),
+    transformDefinition: (definition, executed) => ComboChart.transformDefinition(definition, executed),
+    getChartDefinitionFromContextCreation: (context) => ComboChart.getDefinitionFromContextCreation(context),
+    name: _t("Combo"),
+    sequence: 15,
+});
 chartRegistry.add("line", {
     match: (type) => type === "line",
     createChart: (definition, sheetId, getters) => new LineChart(definition, sheetId, getters),
@@ -20893,6 +21138,7 @@ chartRegistry.add("scatter", {
 const chartComponentRegistry = new Registry();
 chartComponentRegistry.add("line", ChartJsComponent);
 chartComponentRegistry.add("bar", ChartJsComponent);
+chartComponentRegistry.add("combo", ChartJsComponent);
 chartComponentRegistry.add("pie", ChartJsComponent);
 chartComponentRegistry.add("gauge", GaugeChartComponent);
 chartComponentRegistry.add("scatter", ChartJsComponent);
@@ -23151,7 +23397,7 @@ const lightTemplateWithHeader = (colorSet) => ({
         style: { fillColor: colorSet.highlight, textColor: "#FFFFFF" },
         border: { bottom: { color: colorSet.highlight, style: "thin" } },
     },
-    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } },
+    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } }, // @compatibility: should be double line
     firstRowStripe: { border: { bottom: { color: colorSet.highlight, style: "thin" } } },
     secondRowStripe: { border: { bottom: { color: colorSet.highlight, style: "thin" } } },
 });
@@ -23169,7 +23415,7 @@ const lightTemplateAllBorders = (colorSet) => ({
         },
     },
     headerRow: { border: { bottom: { color: colorSet.highlight, style: "medium" } } },
-    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } },
+    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } }, // @compatibility: should be double line
     firstRowStripe: { style: { fillColor: colorSet.light } },
     firstColumnStripe: { style: { fillColor: colorSet.light } },
 });
@@ -23188,7 +23434,7 @@ const mediumTemplateBandedBorders = (colorSet) => ({
     headerRow: {
         style: { fillColor: colorSet.highlight, textColor: "#FFFFFF" },
     },
-    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } },
+    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } }, // @compatibility: should be double line
     firstRowStripe: { style: { fillColor: colorSet.light } },
     firstColumnStripe: { style: { fillColor: colorSet.light } },
 });
@@ -23224,7 +23470,7 @@ const mediumTemplateMinimalBorders = (colorSet) => ({
             bottom: { color: "#000000", style: "medium" },
         },
     },
-    totalRow: { border: { top: { color: "#000000", style: "medium" } } },
+    totalRow: { border: { top: { color: "#000000", style: "medium" } } }, // @compatibility: should be double line
     headerRow: {
         style: { fillColor: colorSet.highlight, textColor: "#FFFFFF" },
         border: { bottom: { color: "#000000", style: "medium" } },
@@ -23248,7 +23494,7 @@ const mediumTemplateAllBorders = (colorSet) => ({
         },
         style: { fillColor: colorSet.light },
     },
-    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } },
+    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } }, // @compatibility: should be double line
     firstRowStripe: { style: { fillColor: colorSet.medium } },
     firstColumnStripe: { style: { fillColor: colorSet.medium } },
 });
@@ -23279,7 +23525,7 @@ const darkTemplateNoBorders = (colorSet) => ({
     category: "dark",
     colorName: colorSet.name,
     wholeTable: { style: { fillColor: colorSet.light } },
-    totalRow: { border: { top: { color: "#000000", style: "medium" } } },
+    totalRow: { border: { top: { color: "#000000", style: "medium" } } }, // @compatibility: should be double line
     headerRow: { style: { fillColor: colorSet.highlight, textColor: "#FFFFFF" } },
     firstRowStripe: { style: { fillColor: colorSet.medium } },
     firstColumnStripe: { style: { fillColor: colorSet.medium } },
@@ -23444,8 +23690,8 @@ const DELETE_CONTENT_ROWS_NAME = (env) => {
     let last;
     const activesRows = env.model.getters.getActiveRows();
     if (activesRows.size !== 0) {
-        first = Math.min(...activesRows);
-        last = Math.max(...activesRows);
+        first = largeMin([...activesRows]);
+        last = largeMax([...activesRows]);
     }
     else {
         const zone = env.model.getters.getSelectedZones()[0];
@@ -23473,8 +23719,8 @@ const DELETE_CONTENT_COLUMNS_NAME = (env) => {
     let last;
     const activeCols = env.model.getters.getActiveCols();
     if (activeCols.size !== 0) {
-        first = Math.min(...activeCols);
-        last = Math.max(...activeCols);
+        first = largeMin([...activeCols]);
+        last = largeMax([...activeCols]);
     }
     else {
         const zone = env.model.getters.getSelectedZones()[0];
@@ -23502,8 +23748,8 @@ const REMOVE_ROWS_NAME = (env) => {
     let last;
     const activesRows = env.model.getters.getActiveRows();
     if (activesRows.size !== 0) {
-        first = Math.min(...activesRows);
-        last = Math.max(...activesRows);
+        first = largeMin([...activesRows]);
+        last = largeMax([...activesRows]);
     }
     else {
         const zone = env.model.getters.getSelectedZones()[0];
@@ -23544,8 +23790,8 @@ const REMOVE_COLUMNS_NAME = (env) => {
     let last;
     const activeCols = env.model.getters.getActiveCols();
     if (activeCols.size !== 0) {
-        first = Math.min(...activeCols);
-        last = Math.max(...activeCols);
+        first = largeMin([...activeCols]);
+        last = largeMax([...activeCols]);
     }
     else {
         const zone = env.model.getters.getSelectedZones()[0];
@@ -23586,7 +23832,7 @@ const INSERT_ROWS_BEFORE_ACTION = (env) => {
     let row;
     let quantity;
     if (activeRows.size) {
-        row = Math.min(...activeRows);
+        row = largeMin([...activeRows]);
         quantity = activeRows.size;
     }
     else {
@@ -23607,7 +23853,7 @@ const INSERT_ROWS_AFTER_ACTION = (env) => {
     let row;
     let quantity;
     if (activeRows.size) {
-        row = Math.max(...activeRows);
+        row = largeMax([...activeRows]);
         quantity = activeRows.size;
     }
     else {
@@ -23628,7 +23874,7 @@ const INSERT_COLUMNS_BEFORE_ACTION = (env) => {
     let column;
     let quantity;
     if (activeCols.size) {
-        column = Math.min(...activeCols);
+        column = largeMin([...activeCols]);
         quantity = activeCols.size;
     }
     else {
@@ -23649,7 +23895,7 @@ const INSERT_COLUMNS_AFTER_ACTION = (env) => {
     let column;
     let quantity;
     if (activeCols.size) {
-        column = Math.max(...activeCols);
+        column = largeMax([...activeCols]);
         quantity = activeCols.size;
     }
     else {
@@ -27255,6 +27501,22 @@ class BarChartDesignPanel extends LineBarPieDesignPanel {
     static template = "o-spreadsheet-BarChartDesignPanel";
 }
 
+class ComboChartConfigPanel extends LineBarPieConfigPanel {
+    static template = "o-spreadsheet-ComboChartConfigPanel";
+    get shouldUseRightAxis() {
+        return _t("Use right axis for line series");
+    }
+    onUpdateUseRightAxis(useBothYAxis) {
+        this.props.updateChart(this.props.figureId, {
+            useBothYAxis,
+        });
+    }
+}
+
+class ComboChartDesignPanel extends LineBarPieDesignPanel {
+    static template = "o-spreadsheet-ComboChartDesignPanel";
+}
+
 class GaugeChartConfigPanel extends owl.Component {
     static template = "o-spreadsheet-GaugeChartConfigPanel";
     static components = { ChartErrorSection, ChartDataSeries };
@@ -27612,6 +27874,10 @@ chartSidePanelComponentRegistry
     .add("bar", {
     configuration: BarConfigPanel,
     design: BarChartDesignPanel,
+})
+    .add("combo", {
+    configuration: ComboChartConfigPanel,
+    design: ComboChartDesignPanel,
 })
     .add("pie", {
     configuration: LineBarPieConfigPanel,
@@ -30252,7 +30518,11 @@ class SplitIntoColumnsPanel extends owl.Component {
         const composerStore = useStore(ComposerStore);
         // The feature makes no sense if we are editing a cell, because then the selection isn't active
         // Stop the edition when the panel is mounted, and close the panel if the user start editing a cell
-        owl.useEffect(this.props.onCloseSidePanel, () => [composerStore.editionMode]);
+        owl.useEffect((editionMode) => {
+            if (editionMode !== "inactive") {
+                this.props.onCloseSidePanel();
+            }
+        }, () => [composerStore.editionMode]);
         owl.onMounted(() => {
             composerStore.stopEdition();
         });
@@ -31961,6 +32231,9 @@ class FunctionDescriptionProvider extends owl.Component {
             this.assistantState.allowCellSelectionBehind = false;
         }, 2000);
     }
+    get formulaArgSeparator() {
+        return this.env.model.getters.getLocale().formulaArgSeparator + " ";
+    }
 }
 
 const functions$2 = functionRegistry.content;
@@ -32120,6 +32393,12 @@ class Composer extends owl.Component {
         owl.useEffect(() => {
             this.processContent();
         });
+        owl.onPatched(() => {
+            // Required because typing '=SUM' and double-clicking another cell leaves ShowProvider/ShowDescription true
+            if (this.composerStore.editionMode === "inactive") {
+                this.processTokenAtCursor();
+            }
+        });
     }
     // ---------------------------------------------------------------------------
     // Handlers
@@ -34099,11 +34378,6 @@ css /* scss */ `
       height: 10000px;
       background-color: ${SELECTION_BORDER_COLOR};
     }
-    .o-unhide-buttons {
-      width: fit-content;
-      gap: 5px;
-      transform: translate(-50%, 0);
-    }
     .o-unhide:hover {
       z-index: ${ComponentsImportance.Grid + 1};
       background-color: lightgrey;
@@ -34265,10 +34539,6 @@ css /* scss */ `
       height: 1px;
       background-color: ${SELECTION_BORDER_COLOR};
     }
-    .o-unhide-buttons {
-      height: fit-content;
-      transform: translate(0, -50%);
-    }
     .o-unhide:hover {
       z-index: ${ComponentsImportance.Grid + 1};
       background-color: lightgrey;
@@ -35476,7 +35746,7 @@ class VerticalScrollBar extends owl.Component {
     onScroll(offset) {
         const { scrollX } = this.env.model.getters.getActiveSheetDOMScrollInfo();
         this.env.model.dispatch("SET_VIEWPORT_OFFSET", {
-            offsetX: scrollX,
+            offsetX: scrollX, // offsetX is the same
             offsetY: offset,
         });
     }
@@ -35764,8 +36034,8 @@ class Grid extends owl.Component {
         "Ctrl+Shift+L": () => this.setHorizontalAlign("left"),
         "Ctrl+Shift+R": () => this.setHorizontalAlign("right"),
         "Ctrl+Shift+V": () => PASTE_AS_VALUE_ACTION(this.env),
-        "Ctrl+Shift+<": () => this.clearFormatting(),
-        "Ctrl+<": () => this.clearFormatting(),
+        "Ctrl+Shift+<": () => this.clearFormatting(), // for qwerty
+        "Ctrl+<": () => this.clearFormatting(), // for azerty
         "Ctrl+Shift+ ": () => {
             this.env.model.selection.selectAll();
         },
@@ -36201,6 +36471,7 @@ const XLSX_CHART_TYPES = [
     "surfaceChart",
     "surface3DChart",
     "bubbleChart",
+    "comboChart",
 ];
 
 /** In XLSX color format (no #)  */
@@ -36532,10 +36803,10 @@ function convertCFCellIsOperator(xlsxCfOperator) {
 const CF_TYPE_CONVERSION_MAP = {
     aboveAverage: undefined,
     expression: undefined,
-    cellIs: undefined,
-    colorScale: undefined,
+    cellIs: undefined, // exist but isn't an operator in o_spreadsheet
+    colorScale: undefined, // exist but isn't an operator in o_spreadsheet
     dataBar: undefined,
-    iconSet: undefined,
+    iconSet: undefined, // exist but isn't an operator in o_spreadsheet
     top10: undefined,
     uniqueValues: undefined,
     duplicateValues: undefined,
@@ -36612,6 +36883,7 @@ const CHART_TYPE_CONVERSION_MAP = {
     surfaceChart: undefined,
     surface3DChart: undefined,
     bubbleChart: undefined,
+    comboChart: "combo",
 };
 /** Conversion map for the SUBTOTAL(index, formula) function in xlsx, index <=> actual function*/
 const SUBTOTAL_FUNCTION_CONVERSION_MAP = {
@@ -36770,7 +37042,7 @@ const XLSX_INDEXED_COLORS = {
     61: "993366",
     62: "333399",
     63: "333333",
-    64: "000000",
+    64: "000000", // system foreground
     65: "FFFFFF", // system background
 };
 const IMAGE_MIMETYPE_TO_EXTENSION_MAPPING = {
@@ -37962,7 +38234,7 @@ function convertHyperlink(link, cellValue, warningManager) {
 function getSheetDims(sheet) {
     const dims = [0, 0];
     for (let row of sheet.rows) {
-        dims[0] = Math.max(dims[0], ...row.cells.map((cell) => toCartesian(cell.xc).col));
+        dims[0] = Math.max(dims[0], largeMax(row.cells.map((cell) => toCartesian(cell.xc).col)));
         dims[1] = Math.max(dims[1], row.index);
     }
     dims[0] = Math.max(dims[0], EXCEL_IMPORT_DEFAULT_NUMBER_OF_COLS);
@@ -38828,6 +39100,9 @@ class XlsxChartExtractor extends XlsxBaseExtractor {
             if (!CHART_TYPE_CONVERSION_MAP[chartType]) {
                 throw new Error(`Unsupported chart type ${chartType}`);
             }
+            if (CHART_TYPE_CONVERSION_MAP[chartType] === "combo") {
+                return this.extractComboChart(rootChartElement);
+            }
             // Title can be separated into multiple xml elements (for styling and such), we only import the text
             const chartTitle = this.mapOnElements({ parent: rootChartElement, query: "c:title a:t" }, (textElement) => {
                 return textElement.textContent || "";
@@ -38856,6 +39131,37 @@ class XlsxChartExtractor extends XlsxBaseExtractor {
             };
         })[0];
     }
+    extractComboChart(chartElement) {
+        // Title can be separated into multiple xml elements (for styling and such), we only import the text
+        const chartTitle = this.mapOnElements({ parent: chartElement, query: "c:title a:t" }, (textElement) => {
+            return textElement.textContent || "";
+        }).join("");
+        const barChartGrouping = this.extractChildAttr(chartElement, "c:grouping", "val", {
+            default: "clustered",
+        }).asString();
+        return {
+            title: chartTitle,
+            type: "combo",
+            dataSets: [
+                ...this.extractChartDatasets(this.querySelector(chartElement, `c:barChart`)),
+                ...this.extractChartDatasets(this.querySelector(chartElement, `c:lineChart`)),
+            ],
+            labelRange: this.extractChildTextContent(chartElement, "c:ser c:cat c:f"),
+            backgroundColor: this.extractChildAttr(chartElement, "c:chartSpace > c:spPr a:srgbClr", "val", {
+                default: "ffffff",
+            }).asString(),
+            verticalAxisPosition: this.extractChildAttr(chartElement, "c:valAx > c:axPos", "val", {
+                default: "l",
+            }).asString() === "r"
+                ? "right"
+                : "left",
+            legendPosition: DRAWING_LEGEND_POSITION_CONVERSION_MAP[this.extractChildAttr(chartElement, "c:legendPos", "val", {
+                default: "b",
+            }).asString()],
+            stacked: barChartGrouping === "stacked",
+            fontColor: "000000",
+        };
+    }
     extractChartDatasets(chartElement) {
         return this.mapOnElements({ parent: chartElement, query: "c:ser" }, (chartDataElement) => {
             return {
@@ -38873,12 +39179,21 @@ class XlsxChartExtractor extends XlsxBaseExtractor {
         if (!plotAreaElement) {
             throw new Error("Missing plot area in the chart definition.");
         }
+        let globalTag = undefined;
         for (let child of plotAreaElement.children) {
             const tag = removeTagEscapedNamespaces(child.tagName);
             if (XLSX_CHART_TYPES.some((chartType) => chartType === tag)) {
-                return tag;
+                if (!globalTag) {
+                    globalTag = tag;
+                }
+                else if (globalTag !== tag) {
+                    globalTag = "comboChart";
+                }
             }
         }
+        if (globalTag) {
+            return globalTag;
+        }
         throw new Error("Unknown chart type");
     }
 }
@@ -42469,6 +42784,9 @@ class DataValidationPlugin extends CorePlugin {
         if (newRule.criterion.type === "isBoolean") {
             this.setCenterStyleToBooleanCells(newRule);
         }
+        else if (newRule.criterion.type === "isValueInList") {
+            newRule.criterion.values = Array.from(new Set(newRule.criterion.values));
+        }
         const adaptedRules = this.removeRangesFromRules(sheetId, newRule.ranges, rules);
         const ruleIndex = adaptedRules.findIndex((rule) => rule.id === newRule.id);
         if (ruleIndex !== -1) {
@@ -42865,7 +43183,7 @@ class HeaderVisibilityPlugin extends CorePlugin {
                 if (hiddenElements.size >= elements) {
                     return "TooManyHiddenElements" /* CommandResult.TooManyHiddenElements */;
                 }
-                else if (Math.min(...cmd.elements) < 0 || Math.max(...cmd.elements) > elements) {
+                else if (largeMin(cmd.elements) < 0 || largeMax(cmd.elements) > elements) {
                     return "InvalidHeaderIndex" /* CommandResult.InvalidHeaderIndex */;
                 }
                 else {
@@ -43194,7 +43512,6 @@ class MergePlugin extends CorePlugin {
         "isInSameMerge",
         "isMergeHidden",
         "getMainCellPosition",
-        "getBottomLeftCell",
         "expandZone",
         "doesIntersectMerge",
         "doesColumnsHaveCommonMerges",
@@ -43376,13 +43693,6 @@ class MergePlugin extends CorePlugin {
         const mergeTopLeftPos = this.getMerge(position).topLeft;
         return { sheetId: position.sheetId, col: mergeTopLeftPos.col, row: mergeTopLeftPos.row };
     }
-    getBottomLeftCell(position) {
-        if (!this.isInMerge(position)) {
-            return position;
-        }
-        const { bottom, left } = this.getMerge(position);
-        return { sheetId: position.sheetId, col: left, row: bottom };
-    }
     isMergeHidden(sheetId, merge) {
         const hiddenColsGroups = this.getters.getHiddenColsGroups(sheetId);
         const hiddenRowsGroups = this.getters.getHiddenRowsGroups(sheetId);
@@ -43683,8 +43993,8 @@ class RangeAdapter {
                     let newRange = range;
                     let changeType = "NONE";
                     for (let group of groups) {
-                        const min = Math.min(...group);
-                        const max = Math.max(...group);
+                        const min = largeMin(group);
+                        const max = largeMax(group);
                         if (range.zone[start] <= min && min <= range.zone[end]) {
                             const toRemove = Math.min(range.zone[end], max) - min + 1;
                             changeType = "RESIZE";
@@ -44066,7 +44376,6 @@ class SheetPlugin extends CorePlugin {
         "getSheetIds",
         "getVisibleSheetIds",
         "isSheetVisible",
-        "getEvaluationSheets",
         "doesHeaderExist",
         "doesHeadersExist",
         "getCell",
@@ -44133,8 +44442,8 @@ class SheetPlugin extends CorePlugin {
                 }
                 return "Success" /* CommandResult.Success */;
             case "REMOVE_COLUMNS_ROWS": {
-                const min = Math.min(...cmd.elements);
-                const max = Math.max(...cmd.elements);
+                const min = largeMin(cmd.elements);
+                const max = largeMax(cmd.elements);
                 if (min < 0 || !this.doesHeaderExist(cmd.sheetId, cmd.dimension, max)) {
                     return "InvalidHeaderIndex" /* CommandResult.InvalidHeaderIndex */;
                 }
@@ -44325,9 +44634,6 @@ class SheetPlugin extends CorePlugin {
     getVisibleSheetIds() {
         return this.orderedSheetIds.filter(this.isSheetVisible.bind(this));
     }
-    getEvaluationSheets() {
-        return this.sheets;
-    }
     doesHeaderExist(sheetId, dimension, index) {
         return dimension === "COL"
             ? index >= 0 && index < this.getNumberCols(sheetId)
@@ -44336,13 +44642,6 @@ class SheetPlugin extends CorePlugin {
     doesHeadersExist(sheetId, dimension, headerIndexes) {
         return headerIndexes.every((index) => this.doesHeaderExist(sheetId, dimension, index));
     }
-    getRow(sheetId, index) {
-        const row = this.getSheet(sheetId).rows[index];
-        if (!row) {
-            throw new Error(`Row ${row} not found.`);
-        }
-        return row;
-    }
     getCell({ sheetId, col, row }) {
         const sheet = this.tryGetSheet(sheetId);
         const cellId = sheet?.rows[row]?.cells[col];
@@ -45911,12 +46210,6 @@ class CompilationParametersBuilder {
                 : _t("Function %s expects its parameters to be single values or single cell references, not ranges.", functionName.toString()));
         }
         const position = { sheetId: range.sheetId, col: range.zone.left, row: range.zone.top };
-        return this.readCell(position);
-    }
-    readCell(position) {
-        if (!this.getters.tryGetSheet(position.sheetId)) {
-            throw new EvaluationError(_t("Invalid sheet name"));
-        }
         return this.computeCell(position);
     }
     /**
@@ -45952,7 +46245,7 @@ class CompilationParametersBuilder {
             matrix[colIndex] = new Array(height);
             for (let row = _zone.top; row <= _zone.bottom; row++) {
                 const rowIndex = row - _zone.top;
-                matrix[colIndex][rowIndex] = this.readCell({ sheetId, col, row });
+                matrix[colIndex][rowIndex] = this.computeCell({ sheetId, col, row });
             }
         }
         this.rangeCache[cacheKey] = matrix;
@@ -47060,15 +47353,15 @@ class Evaluator {
     getEvaluatedCell(position) {
         return this.evaluatedCells.get(position) || EMPTY_CELL;
     }
-    getSpreadPositionsOf(position) {
+    getSpreadZone(position) {
         if (!this.spreadingRelations.isArrayFormula(position)) {
-            return [];
+            return undefined;
         }
         if (this.evaluatedCells.get(position)?.type === CellValueType.error) {
-            return [position];
+            return positionToZone(position);
         }
         const spreadPositions = Array.from(this.spreadingRelations.getArrayResultPositions(position));
-        return [position, ...spreadPositions];
+        return union(positionToZone(position), unionPositionsToZone(spreadPositions));
     }
     getEvaluatedPositions() {
         return this.evaluatedCells.keys();
@@ -47473,7 +47766,7 @@ class EvaluationPlugin extends UIPlugin {
         "getEvaluatedCell",
         "getEvaluatedCells",
         "getEvaluatedCellsInZone",
-        "getSpreadPositionsOf",
+        "getSpreadZone",
         "getArrayFormulaSpreadingOn",
         "isEmpty",
     ];
@@ -47579,8 +47872,11 @@ class EvaluationPlugin extends UIPlugin {
     getEvaluatedCellsInZone(sheetId, zone) {
         return positions(zone).map(({ col, row }) => this.getters.getEvaluatedCell({ sheetId, col, row }));
     }
-    getSpreadPositionsOf(position) {
-        return this.evaluator.getSpreadPositionsOf(position);
+    /**
+     * Return the spread zone the position is part of, if any
+     */
+    getSpreadZone(position) {
+        return this.evaluator.getSpreadZone(position);
     }
     getArrayFormulaSpreadingOn(position) {
         return this.evaluator.getArrayFormulaSpreadingOn(position);
@@ -47620,7 +47916,7 @@ class EvaluationPlugin extends UIPlugin {
                 ? getItemId(newFormat, data.formats)
                 : exportedCellData.format;
             let content;
-            if (formulaCell instanceof FormulaCellWithDependencies) {
+            if (isFormula && formulaCell instanceof FormulaCellWithDependencies) {
                 content = formulaCell.contentWithFixedReferences;
             }
             else {
@@ -47668,17 +47964,17 @@ function isBadExpression(tokens) {
  */
 function sortWithClusters(colorsToSort) {
     const clusters = [
-        { leadColor: rgba(255, 0, 0), colors: [] },
-        { leadColor: rgba(255, 128, 0), colors: [] },
-        { leadColor: rgba(128, 128, 0), colors: [] },
-        { leadColor: rgba(128, 255, 0), colors: [] },
-        { leadColor: rgba(0, 255, 0), colors: [] },
-        { leadColor: rgba(0, 255, 128), colors: [] },
-        { leadColor: rgba(0, 255, 255), colors: [] },
-        { leadColor: rgba(0, 127, 255), colors: [] },
-        { leadColor: rgba(0, 0, 255), colors: [] },
-        { leadColor: rgba(127, 0, 255), colors: [] },
-        { leadColor: rgba(128, 0, 128), colors: [] },
+        { leadColor: rgba(255, 0, 0), colors: [] }, // red
+        { leadColor: rgba(255, 128, 0), colors: [] }, // orange
+        { leadColor: rgba(128, 128, 0), colors: [] }, // yellow
+        { leadColor: rgba(128, 255, 0), colors: [] }, // chartreuse
+        { leadColor: rgba(0, 255, 0), colors: [] }, // green
+        { leadColor: rgba(0, 255, 128), colors: [] }, // spring green
+        { leadColor: rgba(0, 255, 255), colors: [] }, // cyan
+        { leadColor: rgba(0, 127, 255), colors: [] }, // azure
+        { leadColor: rgba(0, 0, 255), colors: [] }, // blue
+        { leadColor: rgba(127, 0, 255), colors: [] }, // violet
+        { leadColor: rgba(128, 0, 128), colors: [] }, // magenta
         { leadColor: rgba(255, 0, 128), colors: [] }, // rose
     ];
     for (const color of colorsToSort.map(colorToRGBA)) {
@@ -48069,13 +48365,13 @@ class EvaluationConditionalFormatPlugin extends UIPlugin {
             .map((cell) => cell.value);
         switch (threshold.type) {
             case "value":
-                const result = functionName === "max" ? Math.max(...rangeValues) : Math.min(...rangeValues);
+                const result = functionName === "max" ? largeMax(rangeValues) : largeMin(rangeValues);
                 return result;
             case "number":
                 return Number(threshold.value);
             case "percentage":
-                const min = Math.min(...rangeValues);
-                const max = Math.max(...rangeValues);
+                const min = largeMin(rangeValues);
+                const max = largeMax(rangeValues);
                 const delta = max - min;
                 return min + (delta * Number(threshold.value)) / 100;
             case "percentile":
@@ -48542,8 +48838,8 @@ class DynamicTablesPlugin extends UIPlugin {
         else if (deepEquals(parentSpreadingCell, topLeft) && getZoneArea(unionZone) === 1) {
             return true;
         }
-        const spreadPositions = this.getters.getSpreadPositionsOf(parentSpreadingCell);
-        return deepEquals(unionZone, unionPositionsToZone(spreadPositions));
+        const zone = this.getters.getSpreadZone(parentSpreadingCell);
+        return deepEquals(unionZone, zone);
     }
     coreTableToTable(sheetId, table) {
         if (table.type !== "dynamic") {
@@ -48551,8 +48847,7 @@ class DynamicTablesPlugin extends UIPlugin {
         }
         const tableZone = table.range.zone;
         const tablePosition = { sheetId, col: tableZone.left, row: tableZone.top };
-        const spreadPositions = this.getters.getSpreadPositionsOf(tablePosition);
-        const zone = spreadPositions.length ? unionPositionsToZone(spreadPositions) : table.range.zone;
+        const zone = this.getters.getSpreadZone(tablePosition) ?? table.range.zone;
         const range = this.getters.getRangeFromZone(sheetId, zone);
         const filters = this.getDynamicTableFilters(sheetId, table, zone);
         return { id: table.id, range, filters, config: table.config };
@@ -49002,8 +49297,7 @@ class AutofillPlugin extends UIPlugin {
         let row = zone.bottom;
         if (col > 0) {
             let leftPosition = { sheetId, col: col - 1, row };
-            while (this.getters.getCorrespondingFormulaCell(leftPosition) ||
-                this.getters.getCell(leftPosition)?.content) {
+            while (this.getters.getEvaluatedCell(leftPosition).type !== CellValueType.empty) {
                 row += 1;
                 leftPosition = { sheetId, col: col - 1, row };
             }
@@ -49012,8 +49306,7 @@ class AutofillPlugin extends UIPlugin {
             col = zone.right;
             if (col <= this.getters.getNumberCols(sheetId)) {
                 let rightPosition = { sheetId, col: col + 1, row };
-                while (this.getters.getCorrespondingFormulaCell(rightPosition) ||
-                    this.getters.getCell(rightPosition)?.content) {
+                while (this.getters.getEvaluatedCell(rightPosition).type !== CellValueType.empty) {
                     row += 1;
                     rightPosition = { sheetId, col: col + 1, row };
                 }
@@ -49323,13 +49616,13 @@ class AutomaticSumPlugin extends UIPlugin {
         const cells = this.getters.getEvaluatedCellsInZone(sheet.id, zone);
         const cellPositions = range(end, -1, -1);
         const invalidCells = cellPositions.filter((position) => cells[position] && !cells[position].isAutoSummable);
-        const maxValidPosition = Math.max(...invalidCells);
+        const maxValidPosition = largeMax(invalidCells);
         const numberSequences = groupConsecutive(cellPositions.filter((position) => this.isNumber(cells[position])));
         const firstSequence = numberSequences[0] || [];
-        if (Math.max(...firstSequence) < maxValidPosition) {
+        if (largeMax(firstSequence) < maxValidPosition) {
             return Infinity;
         }
-        return Math.min(...firstSequence);
+        return largeMin(firstSequence);
     }
     shouldFindData(sheetId, zone) {
         return this.getters.isEmpty(sheetId, zone) || this.getters.isSingleCellOrMerge(sheetId, zone);
@@ -50904,8 +51197,6 @@ class SheetUIPlugin extends UIPlugin {
     static getters = [
         "doesCellHaveGridIcon",
         "getCellWidth",
-        "getCellComputedBorder",
-        "getCellComputedStyle",
         "getTextWidth",
         "getCellText",
         "getCellMultiLineText",
@@ -50949,7 +51240,7 @@ class SheetUIPlugin extends UIPlugin {
     // Getters
     // ---------------------------------------------------------------------------
     getCellWidth(position) {
-        const style = this.getCellComputedStyle(position);
+        const style = this.getters.getCellComputedStyle(position);
         let contentWidth = 0;
         const content = this.getters.getEvaluatedCell(position).formattedValue;
         if (content) {
@@ -51042,35 +51333,12 @@ class SheetUIPlugin extends UIPlugin {
      */
     isCellEmpty(position) {
         const mainPosition = this.getters.getMainCellPosition(position);
-        return !(this.getters.getCorrespondingFormulaCell(mainPosition) ||
-            this.getters.getCell(mainPosition)?.content);
-    }
-    getCellComputedBorder(position) {
-        const cellBorder = this.getters.getCellBorder(position) || {};
-        const cellTableBorder = this.getters.getCellTableBorder(position) || {};
-        // Use removeFalsyAttributes to avoid overwriting borders with undefined values
-        const border = { ...cellTableBorder, ...removeFalsyAttributes(cellBorder) };
-        return isObjectEmptyRecursive(border) ? null : border;
-    }
-    getCellComputedStyle(position) {
-        const cell = this.getters.getCell(position);
-        const cfStyle = this.getters.getCellConditionalFormatStyle(position);
-        const tableStyle = this.getters.getCellTableStyle(position);
-        const computedStyle = {
-            ...removeFalsyAttributes(tableStyle),
-            ...removeFalsyAttributes(cell?.style),
-            ...removeFalsyAttributes(cfStyle),
-        };
-        const evaluatedCell = this.getters.getEvaluatedCell(position);
-        if (evaluatedCell.link && !computedStyle.textColor) {
-            computedStyle.textColor = LINK_COLOR;
-        }
-        return computedStyle;
+        return this.getters.getEvaluatedCell(mainPosition).type === CellValueType.empty;
     }
     getColMaxWidth(sheetId, index) {
         const cellsPositions = positions(this.getters.getColsZone(sheetId, index, index));
         const sizes = cellsPositions.map((position) => this.getCellWidth({ sheetId, ...position }));
-        return Math.max(0, ...sizes);
+        return Math.max(0, largeMax(sizes));
     }
     /**
      * Check that any "sheetId" in the command matches an existing
@@ -51099,6 +51367,236 @@ class SheetUIPlugin extends UIPlugin {
     }
 }
 
+class TableStylePlugin extends UIPlugin {
+    static getters = ["getCellTableStyle", "getCellTableBorder"];
+    tableStyles = {};
+    handle(cmd) {
+        if (invalidateEvaluationCommands.has(cmd.type) ||
+            (cmd.type === "UPDATE_CELL" && "content" in cmd) ||
+            cmd.type === "EVALUATE_CELLS") {
+            this.tableStyles = {};
+            return;
+        }
+        if (doesCommandInvalidatesTableStyle(cmd)) {
+            delete this.tableStyles[cmd.sheetId];
+            return;
+        }
+    }
+    finalize() {
+        for (const sheetId of this.getters.getSheetIds()) {
+            if (!this.tableStyles[sheetId]) {
+                this.tableStyles[sheetId] = {};
+            }
+            for (const table of this.getters.getTables(sheetId)) {
+                if (!this.tableStyles[sheetId][table.id]) {
+                    this.tableStyles[sheetId][table.id] = this.computeTableStyle(sheetId, table);
+                }
+            }
+        }
+    }
+    getCellTableStyle(position) {
+        const table = this.getters.getTable(position);
+        if (!table) {
+            return undefined;
+        }
+        return this.tableStyles[position.sheetId][table.id]().styles[position.col]?.[position.row];
+    }
+    getCellTableBorder(position) {
+        const table = this.getters.getTable(position);
+        if (!table) {
+            return undefined;
+        }
+        return this.tableStyles[position.sheetId][table.id]().borders[position.col]?.[position.row];
+    }
+    computeTableStyle(sheetId, table) {
+        return lazy(() => {
+            const { config, numberOfCols, numberOfRows } = this.getTableRuntimeConfig(sheetId, table);
+            const relativeTableStyle = getComputedTableStyle(config, numberOfCols, numberOfRows);
+            // Return the style with sheet coordinates instead of tables coordinates
+            const mapping = this.getTableMapping(sheetId, table);
+            const absoluteTableStyle = { borders: {}, styles: {} };
+            for (let col = 0; col < numberOfCols; col++) {
+                const colInSheet = mapping.colMapping[col];
+                absoluteTableStyle.borders[colInSheet] = {};
+                absoluteTableStyle.styles[colInSheet] = {};
+                for (let row = 0; row < numberOfRows; row++) {
+                    const rowInSheet = mapping.rowMapping[row];
+                    absoluteTableStyle.borders[colInSheet][rowInSheet] = relativeTableStyle.borders[col][row];
+                    absoluteTableStyle.styles[colInSheet][rowInSheet] = relativeTableStyle.styles[col][row];
+                }
+            }
+            return absoluteTableStyle;
+        });
+    }
+    /**
+     * Get the actual table config that will be used to compute the table style. It is different from
+     * the config of the table because of hidden rows and columns in the sheet. For example remove the
+     * hidden rows from config.numberOfHeaders.
+     */
+    getTableRuntimeConfig(sheetId, table) {
+        const tableZone = table.range.zone;
+        const config = { ...table.config };
+        let numberOfCols = tableZone.right - tableZone.left + 1;
+        let numberOfRows = tableZone.bottom - tableZone.top + 1;
+        for (let row = tableZone.top; row <= tableZone.bottom; row++) {
+            if (!this.getters.isRowHidden(sheetId, row)) {
+                continue;
+            }
+            numberOfRows--;
+            if (row - tableZone.top < table.config.numberOfHeaders) {
+                config.numberOfHeaders--;
+                if (config.numberOfHeaders < 0) {
+                    config.numberOfHeaders = 0;
+                }
+            }
+            if (row === tableZone.bottom) {
+                config.totalRow = false;
+            }
+        }
+        for (let col = tableZone.left; col <= tableZone.right; col++) {
+            if (!this.getters.isColHidden(sheetId, col)) {
+                continue;
+            }
+            numberOfCols--;
+            if (col === tableZone.left) {
+                config.firstColumn = false;
+            }
+            if (col === tableZone.right) {
+                config.lastColumn = false;
+            }
+        }
+        return {
+            config,
+            numberOfCols,
+            numberOfRows,
+        };
+    }
+    /**
+     * Get a mapping: relative col/row position in the table <=> col/row in the sheet
+     */
+    getTableMapping(sheetId, table) {
+        const colMapping = {};
+        const rowMapping = {};
+        let colOffset = 0;
+        let rowOffset = 0;
+        const tableZone = table.range.zone;
+        for (let col = tableZone.left; col <= tableZone.right; col++) {
+            if (this.getters.isColHidden(sheetId, col)) {
+                continue;
+            }
+            colMapping[colOffset] = col;
+            colOffset++;
+            for (let row = tableZone.top; row <= tableZone.bottom; row++) {
+                if (this.getters.isRowHidden(sheetId, row)) {
+                    continue;
+                }
+                rowMapping[rowOffset] = row;
+                rowOffset++;
+            }
+        }
+        return {
+            colMapping,
+            rowMapping,
+        };
+    }
+}
+const invalidateTableStyleCommands = [
+    "HIDE_COLUMNS_ROWS",
+    "UNHIDE_COLUMNS_ROWS",
+    "UNFOLD_HEADER_GROUP",
+    "FOLD_HEADER_GROUP",
+    "FOLD_ALL_HEADER_GROUPS",
+    "UNFOLD_ALL_HEADER_GROUPS",
+    "CREATE_TABLE",
+    "UPDATE_TABLE",
+    "UPDATE_FILTER",
+];
+const invalidateTableStyleCommandsSet = new Set(invalidateTableStyleCommands);
+function doesCommandInvalidatesTableStyle(cmd) {
+    return invalidateTableStyleCommandsSet.has(cmd.type);
+}
+
+class CellComputedStylePlugin extends UIPlugin {
+    static getters = ["getCellComputedBorder", "getCellComputedStyle"];
+    styles = {};
+    borders = {};
+    handle(cmd) {
+        if (invalidateEvaluationCommands.has(cmd.type) ||
+            cmd.type === "UPDATE_CELL" ||
+            cmd.type === "EVALUATE_CELLS") {
+            this.styles = {};
+            this.borders = {};
+            return;
+        }
+        if (doesCommandInvalidatesTableStyle(cmd)) {
+            delete this.styles[cmd.sheetId];
+            delete this.borders[cmd.sheetId];
+            return;
+        }
+        if (invalidateCFEvaluationCommands.has(cmd.type)) {
+            this.styles = {};
+            return;
+        }
+    }
+    getCellComputedBorder(position) {
+        const { sheetId, row, col } = position;
+        if (this.borders[sheetId]?.[row]?.[col] !== undefined) {
+            return this.borders[sheetId][row][col];
+        }
+        if (!this.borders[sheetId]) {
+            this.borders[sheetId] = {};
+        }
+        if (!this.borders[sheetId][row]) {
+            this.borders[sheetId][row] = {};
+        }
+        if (!this.borders[sheetId][row][col]) {
+            this.borders[sheetId][row][col] = this.computeCellBorder(position);
+        }
+        return this.borders[sheetId][row][col];
+    }
+    getCellComputedStyle(position) {
+        const { sheetId, row, col } = position;
+        if (this.styles[sheetId]?.[row]?.[col] !== undefined) {
+            return this.styles[sheetId][row][col];
+        }
+        if (!this.styles[sheetId]) {
+            this.styles[sheetId] = {};
+        }
+        if (!this.styles[sheetId][row]) {
+            this.styles[sheetId][row] = {};
+        }
+        if (!this.styles[sheetId][row][col]) {
+            this.styles[sheetId][row][col] = this.computeCellStyle(position);
+        }
+        return this.styles[sheetId][row][col];
+    }
+    computeCellBorder(position) {
+        const cellBorder = this.getters.getCellBorder(position) || {};
+        const cellTableBorder = this.getters.getCellTableBorder(position) || {};
+        // Use removeFalsyAttributes to avoid overwriting borders with undefined values
+        const border = {
+            ...removeFalsyAttributes(cellTableBorder),
+            ...removeFalsyAttributes(cellBorder),
+        };
+        return isObjectEmptyRecursive(border) ? null : border;
+    }
+    computeCellStyle(position) {
+        const cell = this.getters.getCell(position);
+        const cfStyle = this.getters.getCellConditionalFormatStyle(position);
+        const tableStyle = this.getters.getCellTableStyle(position);
+        const computedStyle = {
+            ...removeFalsyAttributes(tableStyle),
+            ...removeFalsyAttributes(cell?.style),
+            ...removeFalsyAttributes(cfStyle),
+        };
+        const evaluatedCell = this.getters.getEvaluatedCell(position);
+        if (evaluatedCell.link && !computedStyle.textColor) {
+            computedStyle.textColor = LINK_COLOR;
+        }
+        return computedStyle;
+    }
+}
+
 const genericRepeatsTransforms = [
     repeatSheetDependantCommand,
     repeatTargetDependantCommand,
@@ -51676,148 +52174,6 @@ class TableAutofillPlugin extends UIPlugin {
     }
 }
 
-class TableStylePlugin extends UIPlugin {
-    static getters = ["getCellTableStyle", "getCellTableBorder"];
-    tableStyles = {};
-    handle(cmd) {
-        if (invalidateEvaluationCommands.has(cmd.type) ||
-            (cmd.type === "UPDATE_CELL" && "content" in cmd) ||
-            cmd.type === "EVALUATE_CELLS") {
-            this.tableStyles = {};
-            return;
-        }
-        switch (cmd.type) {
-            case "HIDE_COLUMNS_ROWS":
-            case "UNHIDE_COLUMNS_ROWS":
-            case "UNFOLD_HEADER_GROUP":
-            case "FOLD_HEADER_GROUP":
-            case "FOLD_ALL_HEADER_GROUPS":
-            case "UNFOLD_ALL_HEADER_GROUPS":
-            case "UPDATE_TABLE":
-            case "UPDATE_FILTER":
-                delete this.tableStyles[cmd.sheetId];
-                break;
-        }
-    }
-    finalize() {
-        for (const sheetId of this.getters.getSheetIds()) {
-            if (!this.tableStyles[sheetId]) {
-                this.tableStyles[sheetId] = {};
-            }
-            for (const table of this.getters.getTables(sheetId)) {
-                if (!this.tableStyles[sheetId][table.id]) {
-                    this.tableStyles[sheetId][table.id] = this.computeTableStyle(sheetId, table);
-                }
-            }
-        }
-    }
-    getCellTableStyle(position) {
-        const table = this.getters.getTable(position);
-        if (!table) {
-            return undefined;
-        }
-        return this.tableStyles[position.sheetId][table.id]().styles[position.col]?.[position.row];
-    }
-    getCellTableBorder(position) {
-        const table = this.getters.getTable(position);
-        if (!table) {
-            return undefined;
-        }
-        return this.tableStyles[position.sheetId][table.id]().borders[position.col]?.[position.row];
-    }
-    computeTableStyle(sheetId, table) {
-        return lazy(() => {
-            const { config, numberOfCols, numberOfRows } = this.getTableRuntimeConfig(sheetId, table);
-            const relativeTableStyle = getComputedTableStyle(config, numberOfCols, numberOfRows);
-            // Return the style with sheet coordinates instead of tables coordinates
-            const mapping = this.getTableMapping(sheetId, table);
-            const absoluteTableStyle = { borders: {}, styles: {} };
-            for (let col = 0; col < numberOfCols; col++) {
-                const colInSheet = mapping.colMapping[col];
-                absoluteTableStyle.borders[colInSheet] = {};
-                absoluteTableStyle.styles[colInSheet] = {};
-                for (let row = 0; row < numberOfRows; row++) {
-                    const rowInSheet = mapping.rowMapping[row];
-                    absoluteTableStyle.borders[colInSheet][rowInSheet] = relativeTableStyle.borders[col][row];
-                    absoluteTableStyle.styles[colInSheet][rowInSheet] = relativeTableStyle.styles[col][row];
-                }
-            }
-            return absoluteTableStyle;
-        });
-    }
-    /**
-     * Get the actual table config that will be used to compute the table style. It is different from
-     * the config of the table because of hidden rows and columns in the sheet. For example remove the
-     * hidden rows from config.numberOfHeaders.
-     */
-    getTableRuntimeConfig(sheetId, table) {
-        const tableZone = table.range.zone;
-        const config = { ...table.config };
-        let numberOfCols = tableZone.right - tableZone.left + 1;
-        let numberOfRows = tableZone.bottom - tableZone.top + 1;
-        for (let row = tableZone.top; row <= tableZone.bottom; row++) {
-            if (!this.getters.isRowHidden(sheetId, row)) {
-                continue;
-            }
-            numberOfRows--;
-            if (row - tableZone.top < table.config.numberOfHeaders) {
-                config.numberOfHeaders--;
-                if (config.numberOfHeaders < 0) {
-                    config.numberOfHeaders = 0;
-                }
-            }
-            if (row === tableZone.bottom) {
-                config.totalRow = false;
-            }
-        }
-        for (let col = tableZone.left; col <= tableZone.right; col++) {
-            if (!this.getters.isColHidden(sheetId, col)) {
-                continue;
-            }
-            numberOfCols--;
-            if (col === tableZone.left) {
-                config.firstColumn = false;
-            }
-            if (col === tableZone.right) {
-                config.lastColumn = false;
-            }
-        }
-        return {
-            config,
-            numberOfCols,
-            numberOfRows,
-        };
-    }
-    /**
-     * Get a mapping: relative col/row position in the table <=> col/row in the sheet
-     */
-    getTableMapping(sheetId, table) {
-        const colMapping = {};
-        const rowMapping = {};
-        let colOffset = 0;
-        let rowOffset = 0;
-        const tableZone = table.range.zone;
-        for (let col = tableZone.left; col <= tableZone.right; col++) {
-            if (this.getters.isColHidden(sheetId, col)) {
-                continue;
-            }
-            colMapping[colOffset] = col;
-            colOffset++;
-            for (let row = tableZone.top; row <= tableZone.bottom; row++) {
-                if (this.getters.isRowHidden(sheetId, row)) {
-                    continue;
-                }
-                rowMapping[rowOffset] = row;
-                rowOffset++;
-            }
-        }
-        return {
-            colMapping,
-            rowMapping,
-        };
-    }
-}
-
 /**
  * Clipboard Plugin
  *
@@ -52527,38 +52883,6 @@ class FilterEvaluationPlugin extends UIPlugin {
     }
 }
 
-const selectionStatisticFunctions = [
-    {
-        name: _t("Sum"),
-        types: [CellValueType.number],
-        compute: (values, locale) => sum([[values]], locale),
-    },
-    {
-        name: _t("Avg"),
-        types: [CellValueType.number],
-        compute: (values, locale) => average([[values]], locale),
-    },
-    {
-        name: _t("Min"),
-        types: [CellValueType.number],
-        compute: (values, locale) => min([[values]], locale),
-    },
-    {
-        name: _t("Max"),
-        types: [CellValueType.number],
-        compute: (values, locale) => max([[values]], locale),
-    },
-    {
-        name: _t("Count"),
-        types: [CellValueType.number, CellValueType.text, CellValueType.boolean, CellValueType.error],
-        compute: (values) => countAny([[values]]),
-    },
-    {
-        name: _t("Count Numbers"),
-        types: [CellValueType.number, CellValueType.text, CellValueType.boolean, CellValueType.error],
-        compute: (values, locale) => countNumbers([[values]], locale),
-    },
-];
 /**
  * SelectionPlugin
  */
@@ -52574,8 +52898,6 @@ class GridSelectionPlugin extends UIPlugin {
         "getSelectedZones",
         "getSelectedZone",
         "getSelectedCells",
-        "getStatisticFnResults",
-        "getAggregate",
         "getSelectedFigureId",
         "getSelection",
         "getActivePosition",
@@ -52610,7 +52932,10 @@ class GridSelectionPlugin extends UIPlugin {
         switch (cmd.type) {
             case "ACTIVATE_SHEET":
                 try {
-                    this.getters.getSheet(cmd.sheetIdTo);
+                    const sheet = this.getters.getSheet(cmd.sheetIdTo);
+                    if (!sheet.isVisible) {
+                        return "SheetIsHidden" /* CommandResult.SheetIsHidden */;
+                    }
                     break;
                 }
                 catch (error) {
@@ -52859,52 +53184,6 @@ class GridSelectionPlugin extends UIPlugin {
                 : this.getters.getNextVisibleCellPosition({ sheetId, col: 0, row: 0 });
         }
     }
-    getStatisticFnResults() {
-        const sheetId = this.getters.getActiveSheetId();
-        const cells = new Set();
-        for (const zone of this.gridSelection.zones) {
-            for (const { col, row } of positions(zone)) {
-                if (this.getters.isRowHidden(sheetId, row) || this.getters.isColHidden(sheetId, col)) {
-                    continue; // Skip hidden cells
-                }
-                const evaluatedCell = this.getters.getEvaluatedCell({ sheetId, col, row });
-                if (evaluatedCell.type !== CellValueType.empty) {
-                    cells.add(evaluatedCell);
-                }
-            }
-        }
-        const locale = this.getters.getLocale();
-        let statisticFnResults = {};
-        for (let fn of selectionStatisticFunctions) {
-            // We don't want to display statistical information when there is no interest:
-            // We set the statistical result to undefined if the data handled by the selection
-            // does not match the data handled by the function.
-            // Ex: if there are only texts in the selection, we prefer that the SUM result
-            // be displayed as undefined rather than 0.
-            let fnResult = undefined;
-            const evaluatedCells = [...cells].filter((c) => fn.types.includes(c.type));
-            if (evaluatedCells.length) {
-                fnResult = fn.compute(evaluatedCells, locale);
-            }
-            statisticFnResults[fn.name] = fnResult;
-        }
-        return statisticFnResults;
-    }
-    getAggregate() {
-        let aggregate = 0;
-        let n = 0;
-        const sheetId = this.getters.getActiveSheetId();
-        const cellPositions = this.gridSelection.zones.map(positions).flat();
-        for (const { col, row } of cellPositions) {
-            const cell = this.getters.getEvaluatedCell({ sheetId, col, row });
-            if (cell.type === CellValueType.number) {
-                n++;
-                aggregate += cell.value;
-            }
-        }
-        const locale = this.getters.getLocale();
-        return n < 2 ? null : formatValue(aggregate, { locale });
-    }
     isSelected(zone) {
         return !!this.getters.getSelectedZones().find((z) => isEqual(z, zone));
     }
@@ -52946,9 +53225,6 @@ class GridSelectionPlugin extends UIPlugin {
     // Other
     // ---------------------------------------------------------------------------
     activateSheet(sheetIdFrom, sheetIdTo) {
-        if (!this.getters.isSheetVisible(sheetIdTo)) {
-            this.dispatch("SHOW_SHEET", { sheetId: sheetIdTo });
-        }
         this.setActiveSheet(sheetIdTo);
         this.sheetsData[sheetIdFrom] = {
             gridSelection: deepCopy(this.gridSelection),
@@ -53955,7 +54231,7 @@ class SheetViewPlugin extends UIPlugin {
      * column of the current viewport
      */
     getColDimensionsInViewport(sheetId, col) {
-        const left = Math.min(...this.getters.getSheetViewVisibleCols());
+        const left = largeMin(this.getters.getSheetViewVisibleCols());
         const start = this.getters.getColRowOffsetInViewport("COL", left, col);
         const size = this.getters.getColSize(sheetId, col);
         const isColHidden = this.getters.isColHidden(sheetId, col);
@@ -53970,7 +54246,7 @@ class SheetViewPlugin extends UIPlugin {
      * of the current viewport
      */
     getRowDimensionsInViewport(sheetId, row) {
-        const top = Math.min(...this.getters.getSheetViewVisibleRows());
+        const top = largeMin(this.getters.getSheetViewVisibleRows());
         const start = this.getters.getColRowOffsetInViewport("ROW", top, row);
         const size = this.getters.getRowSize(sheetId, row);
         const isRowHidden = this.getters.isRowHidden(sheetId, row);
@@ -54322,6 +54598,7 @@ const statefulUIPluginRegistry = new Registry()
     .add("evaluation_filter", FilterEvaluationPlugin)
     .add("header_visibility_ui", HeaderVisibilityUIPlugin)
     .add("table_style", TableStylePlugin)
+    .add("cell_computed_style", CellComputedStylePlugin)
     .add("header_positions", HeaderPositionsUIPlugin)
     .add("viewport", SheetViewPlugin)
     .add("clipboard", ClipboardPlugin);
@@ -54382,6 +54659,38 @@ class ImageProvider {
     }
 }
 
+class ArrayFormulaHighlight extends SpreadsheetStore {
+    highlightStore = this.get(HighlightStore);
+    constructor(get) {
+        super(get);
+        this.highlightStore.register(this);
+    }
+    get highlights() {
+        const zone = this.getHighlightZone();
+        if (!zone) {
+            return [];
+        }
+        const sheetId = this.model.getters.getActiveSheetId();
+        return [
+            {
+                sheetId,
+                zone,
+                color: "#17A2B8",
+                noFill: true,
+                thinLine: true,
+            },
+        ];
+    }
+    getHighlightZone() {
+        const position = this.model.getters.getActivePosition();
+        const spreader = this.model.getters.getArrayFormulaSpreadingOn(position);
+        const spreadZone = spreader
+            ? this.model.getters.getSpreadZone(spreader)
+            : this.model.getters.getSpreadZone(position);
+        return spreadZone;
+    }
+}
+
 const RIPPLE_KEY_FRAMES = [
     { transform: "scale(0)" },
     { transform: "scale(0.8)", offset: 0.33 },
@@ -54684,12 +54993,14 @@ class BottomBarSheet extends owl.Component {
         this.editionState = "initializing";
     }
     stopEdition() {
-        if (!this.state.isEditing)
+        const input = this.sheetNameRef.el;
+        if (!this.state.isEditing || !input)
             return;
         this.state.isEditing = false;
         this.editionState = "initializing";
-        this.sheetNameRef.el?.blur();
+        input.blur();
         const inputValue = this.getInputContent() || "";
+        input.innerText = inputValue;
         interactiveRenameSheet(this.env, this.props.sheetId, inputValue, () => this.startEdition());
     }
     cancelEdition() {
@@ -54733,6 +55044,115 @@ class BottomBarSheet extends owl.Component {
     }
 }
 
+const selectionStatisticFunctions = [
+    {
+        name: _t("Sum"),
+        types: [CellValueType.number],
+        compute: (values, locale) => sum([[values]], locale),
+    },
+    {
+        name: _t("Avg"),
+        types: [CellValueType.number],
+        compute: (values, locale) => average([[values]], locale),
+    },
+    {
+        name: _t("Min"),
+        types: [CellValueType.number],
+        compute: (values, locale) => min([[values]], locale),
+    },
+    {
+        name: _t("Max"),
+        types: [CellValueType.number],
+        compute: (values, locale) => max([[values]], locale),
+    },
+    {
+        name: _t("Count"),
+        types: [CellValueType.number, CellValueType.text, CellValueType.boolean, CellValueType.error],
+        compute: (values) => countAny([[values]]),
+    },
+    {
+        name: _t("Count Numbers"),
+        types: [CellValueType.number, CellValueType.text, CellValueType.boolean, CellValueType.error],
+        compute: (values, locale) => countNumbers([[values]], locale),
+    },
+];
+class AggregateStatisticsStore extends SpreadsheetStore {
+    statisticFnResults = this._computeStatisticFnResults();
+    isDirty = false;
+    constructor(get) {
+        super(get);
+        this.model.selection.observe(this, {
+            handleEvent: this.handleEvent.bind(this),
+        });
+    }
+    handle(cmd) {
+        if (invalidateEvaluationCommands.has(cmd.type) ||
+            (cmd.type === "UPDATE_CELL" && "content" in cmd)) {
+            this.isDirty = true;
+        }
+        switch (cmd.type) {
+            case "HIDE_COLUMNS_ROWS":
+            case "UNHIDE_COLUMNS_ROWS":
+            case "GROUP_HEADERS":
+            case "UNGROUP_HEADERS":
+            case "ACTIVATE_SHEET":
+            case "ACTIVATE_NEXT_SHEET":
+            case "ACTIVATE_PREVIOUS_SHEET":
+            case "EVALUATE_CELLS":
+            case "UNDO":
+            case "REDO":
+                this.isDirty = true;
+        }
+    }
+    finalize() {
+        if (this.isDirty) {
+            this.isDirty = false;
+            this.statisticFnResults = this._computeStatisticFnResults();
+        }
+    }
+    handleEvent() {
+        if (this.getters.isGridSelectionActive()) {
+            this.statisticFnResults = this._computeStatisticFnResults();
+        }
+    }
+    _computeStatisticFnResults() {
+        const getters = this.getters;
+        const sheetId = getters.getActiveSheetId();
+        const cells = new Set();
+        const zones = getters.getSelectedZones();
+        for (const zone of zones) {
+            for (let col = zone.left; col <= zone.right; col++) {
+                for (let row = zone.top; row <= zone.bottom; row++) {
+                    if (getters.isRowHidden(sheetId, row) || getters.isColHidden(sheetId, col)) {
+                        continue; // Skip hidden cells
+                    }
+                    const evaluatedCell = getters.getEvaluatedCell({ sheetId, col, row });
+                    if (evaluatedCell.type !== CellValueType.empty) {
+                        cells.add(evaluatedCell);
+                    }
+                }
+            }
+        }
+        const locale = getters.getLocale();
+        let statisticFnResults = {};
+        const cellsArray = [...cells];
+        for (let fn of selectionStatisticFunctions) {
+            // We don't want to display statistical information when there is no interest:
+            // We set the statistical result to undefined if the data handled by the selection
+            // does not match the data handled by the function.
+            // Ex: if there are only texts in the selection, we prefer that the SUM result
+            // be displayed as undefined rather than 0.
+            let fnResult = undefined;
+            const evaluatedCells = cellsArray.filter((c) => fn.types.includes(c.type));
+            if (evaluatedCells.length) {
+                fnResult = fn.compute(evaluatedCells, locale);
+            }
+            statisticFnResults[fn.name] = fnResult;
+        }
+        return statisticFnResults;
+    }
+}
+
 // -----------------------------------------------------------------------------
 // SpreadSheet
 // -----------------------------------------------------------------------------
@@ -54748,40 +55168,38 @@ css /* scss */ `
   }
 `;
 class BottomBarStatistic extends owl.Component {
-    static template = "o-spreadsheet-BottomBarStatisic";
+    static template = "o-spreadsheet-BottomBarStatistic";
     static props = {
         openContextMenu: Function,
         closeContextMenu: Function,
     };
     static components = { Ripple };
     selectedStatisticFn = "";
-    statisticFnResults = {};
+    store;
     setup() {
-        this.statisticFnResults = this.env.model.getters.getStatisticFnResults();
+        this.store = useStore(AggregateStatisticsStore);
         owl.onWillUpdateProps(() => {
-            const newStatisticFnResults = this.env.model.getters.getStatisticFnResults();
-            if (!deepEquals(newStatisticFnResults, this.statisticFnResults)) {
+            if (Object.values(this.store.statisticFnResults).every((result) => result === undefined)) {
                 this.props.closeContextMenu();
             }
-            this.statisticFnResults = newStatisticFnResults;
         });
     }
     getSelectedStatistic() {
         // don't display button if no function has a result
-        if (Object.values(this.statisticFnResults).every((result) => result === undefined)) {
+        if (Object.values(this.store.statisticFnResults).every((result) => result === undefined)) {
             return undefined;
         }
         if (this.selectedStatisticFn === "") {
-            this.selectedStatisticFn = Object.keys(this.statisticFnResults)[0];
+            this.selectedStatisticFn = Object.keys(this.store.statisticFnResults)[0];
         }
-        return this.getComposedFnName(this.selectedStatisticFn, this.statisticFnResults[this.selectedStatisticFn]);
+        return this.getComposedFnName(this.selectedStatisticFn);
     }
     listSelectionStatistics(ev) {
         const registry = new MenuItemRegistry();
         let i = 0;
-        for (let [fnName, fnValue] of Object.entries(this.statisticFnResults)) {
+        for (let [fnName] of Object.entries(this.store.statisticFnResults)) {
             registry.add(fnName, {
-                name: this.getComposedFnName(fnName, fnValue),
+                name: () => this.getComposedFnName(fnName),
                 sequence: i,
                 isReadonlyAllowed: true,
                 execute: () => {
@@ -54794,8 +55212,9 @@ class BottomBarStatistic extends owl.Component {
         const { top, left, width } = target.getBoundingClientRect();
         this.props.openContextMenu(left + width, top, registry);
     }
-    getComposedFnName(fnName, fnValue) {
+    getComposedFnName(fnName) {
         const locale = this.env.model.getters.getLocale();
+        const fnValue = this.store.statisticFnResults[fnName];
         return fnName + ": " + (fnValue !== undefined ? formatValue(fnValue, { locale }) : "__");
     }
 }
@@ -54904,10 +55323,14 @@ class BottomBar extends owl.Component {
                 name: sheet.name,
                 sequence: i,
                 isReadonlyAllowed: true,
-                textColor: sheet.isVisible ? undefined : "grey",
+                textColor: sheet.isVisible ? undefined : "#808080",
                 execute: (env) => {
+                    if (!this.env.model.getters.isSheetVisible(sheetId)) {
+                        this.env.model.dispatch("SHOW_SHEET", { sheetId });
+                    }
                     env.model.dispatch("ACTIVATE_SHEET", { sheetIdFrom: from, sheetIdTo: sheetId });
                 },
+                isEnabled: (env) => (env.model.getters.isReadonly() ? sheet.isVisible : true),
             });
             i++;
         }
@@ -54980,7 +55403,7 @@ class BottomBar extends owl.Component {
         this.sheetListRef.el.scrollTo({ top: 0, left: scroll, behavior: "smooth" });
     }
     onSheetMouseDown(sheetId, event) {
-        if (event.button !== 0)
+        if (event.button !== 0 || this.env.model.getters.isReadonly())
             return;
         this.closeMenu();
         const visibleSheets = this.getVisibleSheets();
@@ -55016,7 +55439,7 @@ class BottomBar extends owl.Component {
             .map((sheetEl) => sheetEl.getBoundingClientRect())
             .map((rect) => ({
             x: rect.x,
-            width: rect.width - 1,
+            width: rect.width - 1, // -1 to compensate negative margin
             y: rect.y,
             height: rect.height,
         }));
@@ -55243,7 +55666,7 @@ class RowGroup extends AbstractHeaderGroup {
         }
         return cssPropertiesToCss({
             top: `${groupBox.headerRect.height / 2}px`,
-            left: `calc(50% - 1px)`,
+            left: `calc(50% - 1px)`, // -1px: we want the border to be on the center
             width: `30%`,
             height: `calc(100% - ${groupBox.headerRect.height / 2}px)`,
             "border-left": `1px solid ${HEADER_GROUPING_BORDER_COLOR}`,
@@ -55295,7 +55718,7 @@ class ColGroup extends AbstractHeaderGroup {
             return "";
         }
         return cssPropertiesToCss({
-            top: `calc(50% - 1px)`,
+            top: `calc(50% - 1px)`, // -1px: we want the border to be on the center
             left: `${groupBox.headerRect.width / 2}px`,
             width: `calc(100% - ${groupBox.headerRect.width / 2}px)`,
             height: `30%`,
@@ -56386,7 +56809,7 @@ css /* scss */ `
     }
     .o-disabled {
       opacity: 0.4;
-      pointer: default;
+      cursor: default;
       pointer-events: none;
     }
 
@@ -56552,7 +56975,7 @@ css /* scss */ `
 
   .o-number-input {
     /* Remove number input arrows */
-    -moz-appearance: textfield;
+    appearance: textfield;
     &::-webkit-outer-spin-button,
     &::-webkit-inner-spin-button {
       -webkit-appearance: none;
@@ -56595,6 +57018,7 @@ class Spreadsheet extends owl.Component {
         this.notificationStore = useStore(NotificationStore);
         this.composerFocusStore = useStore(ComposerFocusStore);
         this.sidePanel = useStore(SidePanelStore);
+        useStore(ArrayFormulaHighlight);
         this.keyDownMapping = {
             "CTRL+H": () => this.sidePanel.toggle("FindAndReplace", {}),
             "CTRL+F": () => this.sidePanel.toggle("FindAndReplace", {}),
@@ -56697,7 +57121,7 @@ class Spreadsheet extends owl.Component {
         const gridColSize = GROUP_LAYER_WIDTH * this.rowLayers.length;
         const gridRowSize = GROUP_LAYER_WIDTH * this.colLayers.length;
         return cssPropertiesToCss({
-            "grid-template-columns": `${gridColSize ? gridColSize + 2 : 0}px auto`,
+            "grid-template-columns": `${gridColSize ? gridColSize + 2 : 0}px auto`, // +2: margins
             "grid-template-rows": `${gridRowSize ? gridRowSize + 2 : 0}px auto`,
         });
     }
@@ -57429,14 +57853,6 @@ class SelectiveHistory {
         this.revertBefore(operationId);
         this.tree.drop(operationId);
     }
-    getRevertedExecution() {
-        const data = [];
-        const operations = this.tree.revertedExecution(this.HEAD_BRANCH);
-        for (const { operation } of operations) {
-            data.push(operation.data);
-        }
-        return data;
-    }
     /**
      * Revert the state as it was *before* the given operation was executed.
      */
@@ -58225,6 +58641,9 @@ function createChart(chart, chartSheetIndex, data) {
         case "bar":
             plot = addBarChart(chart.data);
             break;
+        case "combo":
+            plot = addComboChart(chart.data);
+            break;
         case "line":
             plot = addLineChart(chart.data);
             break;
@@ -58387,6 +58806,79 @@ function addBarChart(chart) {
     ${addAx(axisPos, "c:valAx", valAxId, catAxId, { fontColor: chart.fontColor })}
   `;
 }
+function addComboChart(chart) {
+    // gapWitdh and overlap that define the space between clusters (in %) and the overlap between datasets (from -100: completely scattered to 100, completely overlapped)
+    // see gapWidth : https://c-rex.net/projects/samples/ooxml/e1/Part4/OOXML_P4_DOCX_gapWidth_topic_ID0EFVEQB.html#topic_ID0EFVEQB
+    // see overlap : https://c-rex.net/projects/samples/ooxml/e1/Part4/OOXML_P4_DOCX_overlap_topic_ID0ELYQQB.html#topic_ID0ELYQQB
+    //
+    // overlap and gapWitdh seems to be by default at -20 and 20 in chart.js.
+    // See https://www.chartjs.org/docs/latest/charts/bar.html and https://www.chartjs.org/docs/latest/charts/bar.html#barpercentage-vs-categorypercentage
+    const colors = new ChartColors();
+    const dataSetsNodes = [];
+    for (const [dsIndex, dataset] of Object.entries(chart.dataSets)) {
+        const color = toXlsxHexColor(colors.next());
+        const dataShapeProperty = shapeProperty({
+            backgroundColor: color,
+            line: { color },
+        });
+        dataSetsNodes.push(dsIndex === "0"
+            ? escapeXml /*xml*/ `
+      <c:ser>
+        <c:idx val="${dsIndex}"/>
+        <c:order val="${dsIndex}"/>
+        ${dataset.label ? escapeXml /*xml*/ `<c:tx>${stringRef(dataset.label)}</c:tx>` : ""}
+        ${dataShapeProperty}
+        ${chart.labelRange ? escapeXml /*xml*/ `<c:cat>${stringRef(chart.labelRange)}</c:cat>` : ""} <!-- x-coordinate values -->
+        <c:val> <!-- x-coordinate values -->
+          ${numberRef(dataset.range)}
+        </c:val>
+      </c:ser>
+      `
+            : escapeXml /*xml*/ `
+      <c:ser>
+        <c:idx val="${dsIndex}"/>
+        <c:order val="${dsIndex}"/>
+        <c:smooth val="0"/>
+        <c:marker>
+          <c:symbol val="circle" />
+          <c:size val="5"/>
+        </c:marker>
+        ${dataset.label ? escapeXml `<c:tx>${stringRef(dataset.label)}</c:tx>` : ""}
+        ${dataShapeProperty}
+        ${chart.labelRange ? escapeXml `<c:cat>${stringRef(chart.labelRange)}</c:cat>` : ""} <!-- x-coordinate values -->
+        <c:val> <!-- x-coordinate values -->
+          ${numberRef(dataset.range)}
+        </c:val>
+      </c:ser>
+      `);
+    }
+    // Excel does not support this feature
+    const axisPos = chart.verticalAxisPosition === "left" ? "l" : "r";
+    const overlap = chart.stacked ? 100 : -20;
+    return escapeXml /*xml*/ `
+    <c:barChart>
+      <c:barDir val="col"/>
+      <c:grouping val="clustered"/>
+      <c:overlap val="${overlap}"/>
+      <c:gapWidth val="70"/>
+      <!-- each data marker in the series does not have a different color -->
+      <c:varyColors val="0"/>
+      ${dataSetsNodes[0]}
+      <c:axId val="${catAxId}" />
+      <c:axId val="${valAxId}" />
+    </c:barChart>
+    <c:lineChart>
+      <c:grouping val="standard"/>
+      <!-- each data marker in the series does not have a different color -->
+      <c:varyColors val="0"/>
+      ${joinXmlNodes(dataSetsNodes.slice(1))}
+      <c:axId val="${catAxId}" />
+      <c:axId val="${valAxId}" />
+    </c:lineChart>
+    ${addAx("b", "c:catAx", catAxId, valAxId, { fontColor: chart.fontColor })}
+    ${addAx(axisPos, "c:valAx", valAxId, catAxId, { fontColor: chart.fontColor })}
+  `;
+}
 function addLineChart(chart) {
     const colors = new ChartColors();
     const dataSetsNodes = [];
@@ -58434,7 +58926,7 @@ function addLineChart(chart) {
 }
 function addDoughnutChart(chart, chartSheetIndex, data, { holeSize } = { holeSize: 50 }) {
     const colors = new ChartColors();
-    const maxLength = Math.max(...chart.dataSets.map((ds) => getRangeSize(ds.range, chartSheetIndex, data)));
+    const maxLength = largeMax(chart.dataSets.map((ds) => getRangeSize(ds.range, chartSheetIndex, data)));
     const doughnutColors = range(0, maxLength).map(() => toXlsxHexColor(colors.next()));
     const dataSetsNodes = [];
     for (const [dsIndex, dataset] of Object.entries(chart.dataSets).reverse()) {
@@ -59312,7 +59804,7 @@ function addTableColumns(table, sheetData) {
         const colHeaderXc = toXC(tableZone.left + i, tableZone.top);
         const colName = sheetData.cells[colHeaderXc]?.content || `col${i}`;
         const colAttributes = [
-            ["id", i + 1],
+            ["id", i + 1], // id cannot be 0
             ["name", colName],
         ];
         columns.push(escapeXml /*xml*/ `<tableColumn ${formatAttributes(colAttributes)}/>`);
@@ -59528,6 +60020,7 @@ function addSheetViews(sheet) {
  * https://www.ecma-international.org/publications-and-standards/standards/ecma-376/
  */
 function getXLSX(data) {
+    data = fixLengthySheetNames(data);
     const files = [];
     const construct = getDefaultXLSXStructure();
     files.push(createWorkbook(data, construct));
@@ -59775,6 +60268,40 @@ function createRelRoot() {
   `;
     return createXMLFile(parseXML(xml), "_rels/.rels");
 }
+/**
+ * Excel sheet names are maximum 31 characters while o-spreadsheet do not have this limit.
+ * This method converts the sheet names to be within the 31 characters limit.
+ * The cells/charts referencing this sheet will be updated accordingly.
+ */
+function fixLengthySheetNames(data) {
+    const nameMapping = {};
+    const newNames = new Set();
+    for (const sheet of data.sheets) {
+        let newName = sheet.name.slice(0, 31);
+        let i = 1;
+        while (newNames.has(newName)) {
+            newName = newName.slice(0, 31 - String(i).length) + i++;
+        }
+        newNames.add(newName);
+        if (newName !== sheet.name) {
+            nameMapping[sheet.name] = newName;
+            sheet.name = newName;
+        }
+    }
+    if (!Object.keys(nameMapping).length) {
+        return data;
+    }
+    const sheetWithNewNames = Object.keys(nameMapping).sort((a, b) => b.length - a.length);
+    let stringifiedData = JSON.stringify(data);
+    for (const sheetName of sheetWithNewNames) {
+        const regex = new RegExp(`'?${escapeRegExp(sheetName)}'?!`, "g");
+        stringifiedData = stringifiedData.replaceAll(regex, (match) => {
+            const newName = nameMapping[sheetName];
+            return match.replace(sheetName, newName);
+        });
+    }
+    return JSON.parse(stringifiedData);
+}
 
 var Status;
 (function (Status) {
@@ -60464,6 +60991,6 @@ exports.tokenColors = tokenColors;
 exports.tokenize = tokenize;
 
 
-__info__.version = "17.3.0-alpha.1";
-__info__.date = "2024-03-25T09:43:36.072Z";
-__info__.hash = "4095c41";
+__info__.version = "17.3.0-alpha.2";
+__info__.date = "2024-04-05T14:01:07.060Z";
+__info__.hash = "8c5a229";