@odoo/o-spreadsheet 17.2.3 → 17.2.4

package/dist/o-spreadsheet.cjs.js

@@ -3,9 +3,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.2.3
- * @date 2024-04-10T12:28:36.552Z
- * @hash ab5e22d
+ * @version 17.2.4
+ * @date 2024-04-18T16:41:38.407Z
+ * @hash 0c66038
  */
 
 'use strict';
@@ -2509,6 +2509,15 @@ function matrixMap(matrix, fn) {
     }
     return generateMatrix(matrix.length, matrix[0].length, (col, row) => fn(matrix[col][row]));
 }
+function matrixForEach(matrix, fn) {
+    const numberOfCols = matrix.length;
+    const numberOfRows = matrix[0]?.length ?? 0;
+    for (let col = 0; col < numberOfCols; col++) {
+        for (let row = 0; row < numberOfRows; row++) {
+            fn(matrix[col][row]);
+        }
+    }
+}
 function transposeMatrix(matrix) {
     if (!matrix.length) {
         return [];
@@ -18636,7 +18645,7 @@ class FunctionRegistry extends Registry {
         }
         const descr = addMetaInfoFromArg(addDescr);
         validateArguments(descr.args);
-        this.mapping[name] = addErrorHandling(addResultHandling(addInputHandling(descr)), name);
+        this.mapping[name] = addErrorHandling(addResultHandling(addInputHandling(descr), name), name);
         super.add(name, descr);
         return this;
     }
@@ -18675,9 +18684,7 @@ function handleError(e, functionName) {
     // so we fallback to a generic error
     if (hasStringValue(e) && isEvaluationError(e.value)) {
         if (hasStringMessage(e)) {
-            if (e.message?.includes("[[FUNCTION_NAME]]")) {
-                e.message = e.message.replace("[[FUNCTION_NAME]]", functionName);
-            }
+            replaceFunctionNamePlaceholder(e, functionName);
         }
         return e;
     }
@@ -18692,21 +18699,29 @@ function hasStringMessage(obj) {
     return (obj?.message !== undefined &&
         typeof obj.message === "string");
 }
-function addResultHandling(compute) {
-    return function (...args) {
+function addResultHandling(compute, functionName) {
+    return function computeWithResultHandling(...args) {
         const result = compute.apply(this, args);
         if (!isMatrix(result)) {
             if (typeof result === "object" && result !== null && "value" in result) {
+                replaceFunctionNamePlaceholder(result, functionName);
                 return result;
             }
             return { value: result };
         }
         if (typeof result[0][0] === "object" && result[0][0] !== null && "value" in result[0][0]) {
+            matrixForEach(result, (result) => replaceFunctionNamePlaceholder(result, functionName));
             return result;
         }
         return matrixMap(result, (row) => ({ value: row }));
     };
 }
+function replaceFunctionNamePlaceholder(fPayload, functionName) {
+    // for performance reasons: change in place and only if needed
+    if (fPayload.message?.includes("[[FUNCTION_NAME]]")) {
+        fPayload.message = fPayload.message.replace("[[FUNCTION_NAME]]", functionName);
+    }
+}
 const functionRegistry = new FunctionRegistry();
 for (let category of categories) {
     const fns = category.functions;
@@ -19474,7 +19489,7 @@ function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale })
                         const xLabel = tooltipItem.dataset?.label || tooltipItem.label;
                         // tooltipItem.parsed.y can be an object or a number for pie charts
                         const yLabel = tooltipItem.parsed.y ?? tooltipItem.parsed;
-                        const toolTipFormat = !format && yLabel > 1000 ? "#,##" : format;
+                        const toolTipFormat = !format && Math.abs(yLabel) >= 1000 ? "#,##" : format;
                         const yLabelStr = formatValue(yLabel, { format: toolTipFormat, locale });
                         return xLabel ? `${xLabel}: ${yLabelStr}` : yLabelStr;
                     },
@@ -19774,7 +19789,10 @@ function getBarConfiguration(chart, labels, localeFormat) {
                     if (isNaN(value))
                         return value;
                     const { locale, format } = localeFormat;
-                    return formatValue(value, { locale, format: !format && value > 1000 ? "#,##" : format });
+                    return formatValue(value, {
+                        locale,
+                        format: !format && Math.abs(value) >= 1000 ? "#,##" : format,
+                    });
                 },
             },
         },
@@ -20295,7 +20313,10 @@ function getLineOrScatterConfiguration(chart, labels, localeFormat) {
                     if (isNaN(value))
                         return value;
                     const { locale, format } = localeFormat;
-                    return formatValue(value, { locale, format: !format && value > 1000 ? "#,##" : format });
+                    return formatValue(value, {
+                        locale,
+                        format: !format && Math.abs(value) >= 1000 ? "#,##" : format,
+                    });
                 },
             },
         },
@@ -20635,7 +20656,7 @@ function getPieConfiguration(chart, labels, localeFormat) {
         const percentage = calculatePercentage(data, dataIndex);
         const xLabel = tooltipItem.label || tooltipItem.dataset.label;
         const yLabel = tooltipItem.parsed.y ?? tooltipItem.parsed;
-        const toolTipFormat = !format && yLabel > 1000 ? "#,##" : format;
+        const toolTipFormat = !format && yLabel >= 1000 ? "#,##" : format;
         const yLabelStr = formatValue(yLabel, { format: toolTipFormat, locale });
         return xLabel ? `${xLabel}: ${yLabelStr} (${percentage}%)` : `${yLabelStr} (${percentage}%)`;
     };
@@ -22887,6 +22908,7 @@ class LinkEditor extends owl.Component {
                     this.save();
                 }
                 ev.stopPropagation();
+                ev.preventDefault();
                 break;
             case "Escape":
                 this.cancel();
@@ -33163,6 +33185,10 @@ css /*SCSS*/ `
       height: 0px;
     }
   }
+  .o-figure-container {
+    -webkit-user-select: none; // safari
+    user-select: none;
+  }
 `;
 /**
  * Each figure ⭐ is positioned inside a container `div` placed and sized
@@ -52086,7 +52112,7 @@ class FilterEvaluationPlugin extends UIPlugin {
         "isFilterActive",
     ];
     filterValues = {};
-    hiddenRows = new Set();
+    hiddenRows = {};
     isEvaluationDirty = false;
     allowDispatch(cmd) {
         switch (cmd.type) {
@@ -52130,11 +52156,11 @@ class FilterEvaluationPlugin extends UIPlugin {
             case "UNFOLD_HEADER_GROUP":
             case "FOLD_ALL_HEADER_GROUPS":
             case "UNFOLD_ALL_HEADER_GROUPS":
-                this.updateHiddenRows();
+                this.updateHiddenRows(cmd.sheetId);
                 break;
             case "UPDATE_FILTER":
                 this.updateFilter(cmd);
-                this.updateHiddenRows();
+                this.updateHiddenRows(cmd.sheetId);
                 break;
             case "DUPLICATE_SHEET":
                 const filterValues = {};
@@ -52154,15 +52180,14 @@ class FilterEvaluationPlugin extends UIPlugin {
     }
     finalize() {
         if (this.isEvaluationDirty) {
-            this.updateHiddenRows();
+            for (const sheetId of this.getters.getSheetIds()) {
+                this.updateHiddenRows(sheetId);
+            }
             this.isEvaluationDirty = false;
         }
     }
     isRowFiltered(sheetId, row) {
-        if (sheetId !== this.getters.getActiveSheetId()) {
-            return false;
-        }
-        return this.hiddenRows.has(row);
+        return !!this.hiddenRows[sheetId]?.has(row);
     }
     getFilterHiddenValues(position) {
         const id = this.getters.getFilterId(position);
@@ -52189,8 +52214,7 @@ class FilterEvaluationPlugin extends UIPlugin {
             this.filterValues[sheetId] = {};
         this.filterValues[sheetId][id] = hiddenValues;
     }
-    updateHiddenRows() {
-        const sheetId = this.getters.getActiveSheetId();
+    updateHiddenRows(sheetId) {
         const filters = this.getters
             .getFilters(sheetId)
             .sort((filter1, filter2) => filter1.rangeWithHeaders.zone.top - filter2.rangeWithHeaders.zone.top);
@@ -52212,7 +52236,7 @@ class FilterEvaluationPlugin extends UIPlugin {
                 }
             }
         }
-        this.hiddenRows = hiddenRows;
+        this.hiddenRows[sheetId] = hiddenRows;
     }
     getCellValueAsString(sheetId, col, row) {
         const value = this.getters.getEvaluatedCell({ sheetId, col, row }).formattedValue;
@@ -53331,13 +53355,14 @@ class SheetViewPlugin extends UIPlugin {
         }
     }
     handleEvent(event) {
+        const sheetId = this.getters.getActiveSheetId();
         if (event.options.scrollIntoView) {
             let { col, row } = findCellInNewZone(event.previousAnchor.zone, event.anchor.zone);
             if (event.mode === "updateAnchor") {
                 const oldZone = event.previousAnchor.zone;
                 const newZone = event.anchor.zone;
                 // altering a zone should not move the viewport in a dimension that wasn't changed
-                const { top, bottom, left, right } = this.getters.getActiveMainViewport();
+                const { top, bottom, left, right } = this.getMainInternalViewport(sheetId);
                 if (oldZone.left === newZone.left && oldZone.right === newZone.right) {
                     col = left > col || col > right ? left : col;
                 }
@@ -53345,7 +53370,6 @@ class SheetViewPlugin extends UIPlugin {
                     row = top > row || row > bottom ? top : row;
                 }
             }
-            const sheetId = this.getters.getActiveSheetId();
             col = Math.min(col, this.getters.getNumberCols(sheetId) - 1);
             row = Math.min(row, this.getters.getNumberRows(sheetId) - 1);
             if (!this.sheetsWithDirtyViewports.has(sheetId)) {
@@ -53382,16 +53406,16 @@ class SheetViewPlugin extends UIPlugin {
                 this.setSheetViewOffset(cmd.offsetX, cmd.offsetY);
                 break;
             case "SHIFT_VIEWPORT_DOWN":
-                const { top } = this.getActiveMainViewport();
                 const sheetId = this.getters.getActiveSheetId();
-                const shiftedOffsetY = this.clipOffsetY(this.getters.getRowDimensions(sheetId, top).start + this.sheetViewHeight);
-                this.shiftVertically(shiftedOffsetY);
+                const { top, viewportHeight, offsetCorrectionY } = this.getMainInternalViewport(sheetId);
+                const topRowDims = this.getters.getRowDimensions(sheetId, top);
+                this.shiftVertically(topRowDims.start + viewportHeight - offsetCorrectionY);
                 break;
             case "SHIFT_VIEWPORT_UP": {
-                const { top } = this.getActiveMainViewport();
                 const sheetId = this.getters.getActiveSheetId();
-                const shiftedOffsetY = this.clipOffsetY(this.getters.getRowDimensions(sheetId, top).end - this.sheetViewHeight);
-                this.shiftVertically(shiftedOffsetY);
+                const { top, viewportHeight, offsetCorrectionY } = this.getMainInternalViewport(sheetId);
+                const topRowDims = this.getters.getRowDimensions(sheetId, top);
+                this.shiftVertically(topRowDims.end - offsetCorrectionY - viewportHeight);
                 break;
             }
             case "REMOVE_TABLE":
@@ -53814,17 +53838,6 @@ class SheetViewPlugin extends UIPlugin {
         const { maxOffsetX, maxOffsetY } = this.getMaximumSheetOffset();
         Object.values(this.getSubViewports(sheetId)).forEach((viewport) => viewport.setViewportOffset(clip(offsetX, 0, maxOffsetX), clip(offsetY, 0, maxOffsetY)));
     }
-    /**
-     * Clip the vertical offset within the allowed range.
-     * Not above the sheet, nor below the sheet.
-     */
-    clipOffsetY(offsetY) {
-        const { height } = this.getMainViewportRect();
-        const maxOffset = height - this.sheetViewHeight;
-        offsetY = Math.min(offsetY, maxOffset);
-        offsetY = Math.max(offsetY, 0);
-        return offsetY;
-    }
     getViewportOffset(sheetId) {
         return {
             x: this.viewports[sheetId]?.bottomRight.offsetScrollbarX || 0,
@@ -53880,12 +53893,15 @@ class SheetViewPlugin extends UIPlugin {
      * viewport top.
      */
     shiftVertically(offset) {
-        const { top } = this.getActiveMainViewport();
+        const sheetId = this.getters.getActiveSheetId();
+        const { top } = this.getMainInternalViewport(sheetId);
         const { scrollX } = this.getActiveSheetScrollInfo();
         this.setSheetViewOffset(scrollX, offset);
         const { anchor } = this.getters.getSelection();
-        const deltaRow = this.getActiveMainViewport().top - top;
-        this.selection.selectCell(anchor.cell.col, anchor.cell.row + deltaRow);
+        if (anchor.cell.row >= this.getters.getPaneDivisions(sheetId).ySplit) {
+            const deltaRow = this.getMainInternalViewport(sheetId).top - top;
+            this.selection.selectCell(anchor.cell.col, anchor.cell.row + deltaRow);
+        }
     }
     getVisibleFigures() {
         const sheetId = this.getters.getActiveSheetId();
@@ -54804,7 +54820,6 @@ css /* scss */ `
     cursor: pointer;
   }
 `;
-let tKey = 1;
 class SpreadsheetDashboard extends owl.Component {
     static template = "o-spreadsheet-SpreadsheetDashboard";
     static props = {};
@@ -54883,13 +54898,9 @@ class SpreadsheetDashboard extends owl.Component {
                     coordinates: rect,
                     position: { col, row },
                     action,
-                    // we can't rely on position only because a row or a column could
-                    // be inserted at any time.
-                    tKey: `${tKey}-${col}-${row}`,
                 });
             }
         }
-        tKey++;
         return cells;
     }
     getClickableAction(position) {
@@ -60229,6 +60240,6 @@ exports.tokenColors = tokenColors;
 exports.tokenize = tokenize;
 
 
-__info__.version = "17.2.3";
-__info__.date = "2024-04-10T12:28:36.552Z";
-__info__.hash = "ab5e22d";
+__info__.version = "17.2.4";
+__info__.date = "2024-04-18T16:41:38.407Z";
+__info__.hash = "0c66038";

package/dist/o-spreadsheet.d.ts

@@ -4151,7 +4151,7 @@ declare class ClipboardPlugin extends UIPlugin {
 declare class FilterEvaluationPlugin extends UIPlugin {
     static getters: readonly ["getFilterHiddenValues", "getFirstTableInSelection", "isRowFiltered", "isFilterActive"];
     private filterValues;
-    hiddenRows: Set<number>;
+    hiddenRows: Record<UID, Set<number> | undefined>;
     isEvaluationDirty: boolean;
     allowDispatch(cmd: LocalCommand): CommandResult;
     handle(cmd: Command): void;
@@ -4288,8 +4288,8 @@ declare class InternalViewport {
     canScrollHorizontally: boolean;
     viewportWidth: Pixel;
     viewportHeight: Pixel;
-    private offsetCorrectionX;
-    private offsetCorrectionY;
+    offsetCorrectionX: Pixel;
+    offsetCorrectionY: Pixel;
     constructor(getters: Getters, sheetId: UID, boundaries: Zone, sizeInGrid: DOMDimension, options: {
         canScrollVertically: boolean;
         canScrollHorizontally: boolean;
@@ -4494,11 +4494,6 @@ declare class SheetViewPlugin extends UIPlugin {
     private resizeSheetView;
     private recomputeViewports;
     private setSheetViewOffset;
-    /**
-     * Clip the vertical offset within the allowed range.
-     * Not above the sheet, nor below the sheet.
-     */
-    private clipOffsetY;
     private getViewportOffset;
     private resetViewports;
     /**
@@ -8316,7 +8311,6 @@ interface ClickableCell {
     coordinates: Rect;
     position: Position$1;
     action: (position: CellPosition, env: SpreadsheetChildEnv) => void;
-    tKey: string;
 }
 declare class SpreadsheetDashboard extends Component<Props$8, SpreadsheetChildEnv> {
     static template: string;

package/dist/o-spreadsheet.esm.js

@@ -3,9 +3,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.2.3
- * @date 2024-04-10T12:28:36.552Z
- * @hash ab5e22d
+ * @version 17.2.4
+ * @date 2024-04-18T16:41:38.407Z
+ * @hash 0c66038
  */
 
 import { reactive, useEnv, useSubEnv, useState, onWillUnmount, markRaw, toRaw, Component, useRef, onMounted, useEffect, onPatched, useComponent, onWillPatch, onWillUpdateProps, useExternalListener, onWillStart, xml, useChildSubEnv } from '@odoo/owl';
@@ -2507,6 +2507,15 @@ function matrixMap(matrix, fn) {
     }
     return generateMatrix(matrix.length, matrix[0].length, (col, row) => fn(matrix[col][row]));
 }
+function matrixForEach(matrix, fn) {
+    const numberOfCols = matrix.length;
+    const numberOfRows = matrix[0]?.length ?? 0;
+    for (let col = 0; col < numberOfCols; col++) {
+        for (let row = 0; row < numberOfRows; row++) {
+            fn(matrix[col][row]);
+        }
+    }
+}
 function transposeMatrix(matrix) {
     if (!matrix.length) {
         return [];
@@ -18634,7 +18643,7 @@ class FunctionRegistry extends Registry {
         }
         const descr = addMetaInfoFromArg(addDescr);
         validateArguments(descr.args);
-        this.mapping[name] = addErrorHandling(addResultHandling(addInputHandling(descr)), name);
+        this.mapping[name] = addErrorHandling(addResultHandling(addInputHandling(descr), name), name);
         super.add(name, descr);
         return this;
     }
@@ -18673,9 +18682,7 @@ function handleError(e, functionName) {
     // so we fallback to a generic error
     if (hasStringValue(e) && isEvaluationError(e.value)) {
         if (hasStringMessage(e)) {
-            if (e.message?.includes("[[FUNCTION_NAME]]")) {
-                e.message = e.message.replace("[[FUNCTION_NAME]]", functionName);
-            }
+            replaceFunctionNamePlaceholder(e, functionName);
         }
         return e;
     }
@@ -18690,21 +18697,29 @@ function hasStringMessage(obj) {
     return (obj?.message !== undefined &&
         typeof obj.message === "string");
 }
-function addResultHandling(compute) {
-    return function (...args) {
+function addResultHandling(compute, functionName) {
+    return function computeWithResultHandling(...args) {
         const result = compute.apply(this, args);
         if (!isMatrix(result)) {
             if (typeof result === "object" && result !== null && "value" in result) {
+                replaceFunctionNamePlaceholder(result, functionName);
                 return result;
             }
             return { value: result };
         }
         if (typeof result[0][0] === "object" && result[0][0] !== null && "value" in result[0][0]) {
+            matrixForEach(result, (result) => replaceFunctionNamePlaceholder(result, functionName));
             return result;
         }
         return matrixMap(result, (row) => ({ value: row }));
     };
 }
+function replaceFunctionNamePlaceholder(fPayload, functionName) {
+    // for performance reasons: change in place and only if needed
+    if (fPayload.message?.includes("[[FUNCTION_NAME]]")) {
+        fPayload.message = fPayload.message.replace("[[FUNCTION_NAME]]", functionName);
+    }
+}
 const functionRegistry = new FunctionRegistry();
 for (let category of categories) {
     const fns = category.functions;
@@ -19472,7 +19487,7 @@ function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale })
                         const xLabel = tooltipItem.dataset?.label || tooltipItem.label;
                         // tooltipItem.parsed.y can be an object or a number for pie charts
                         const yLabel = tooltipItem.parsed.y ?? tooltipItem.parsed;
-                        const toolTipFormat = !format && yLabel > 1000 ? "#,##" : format;
+                        const toolTipFormat = !format && Math.abs(yLabel) >= 1000 ? "#,##" : format;
                         const yLabelStr = formatValue(yLabel, { format: toolTipFormat, locale });
                         return xLabel ? `${xLabel}: ${yLabelStr}` : yLabelStr;
                     },
@@ -19772,7 +19787,10 @@ function getBarConfiguration(chart, labels, localeFormat) {
                     if (isNaN(value))
                         return value;
                     const { locale, format } = localeFormat;
-                    return formatValue(value, { locale, format: !format && value > 1000 ? "#,##" : format });
+                    return formatValue(value, {
+                        locale,
+                        format: !format && Math.abs(value) >= 1000 ? "#,##" : format,
+                    });
                 },
             },
         },
@@ -20293,7 +20311,10 @@ function getLineOrScatterConfiguration(chart, labels, localeFormat) {
                     if (isNaN(value))
                         return value;
                     const { locale, format } = localeFormat;
-                    return formatValue(value, { locale, format: !format && value > 1000 ? "#,##" : format });
+                    return formatValue(value, {
+                        locale,
+                        format: !format && Math.abs(value) >= 1000 ? "#,##" : format,
+                    });
                 },
             },
         },
@@ -20633,7 +20654,7 @@ function getPieConfiguration(chart, labels, localeFormat) {
         const percentage = calculatePercentage(data, dataIndex);
         const xLabel = tooltipItem.label || tooltipItem.dataset.label;
         const yLabel = tooltipItem.parsed.y ?? tooltipItem.parsed;
-        const toolTipFormat = !format && yLabel > 1000 ? "#,##" : format;
+        const toolTipFormat = !format && yLabel >= 1000 ? "#,##" : format;
         const yLabelStr = formatValue(yLabel, { format: toolTipFormat, locale });
         return xLabel ? `${xLabel}: ${yLabelStr} (${percentage}%)` : `${yLabelStr} (${percentage}%)`;
     };
@@ -22885,6 +22906,7 @@ class LinkEditor extends Component {
                     this.save();
                 }
                 ev.stopPropagation();
+                ev.preventDefault();
                 break;
             case "Escape":
                 this.cancel();
@@ -33161,6 +33183,10 @@ css /*SCSS*/ `
       height: 0px;
     }
   }
+  .o-figure-container {
+    -webkit-user-select: none; // safari
+    user-select: none;
+  }
 `;
 /**
  * Each figure ⭐ is positioned inside a container `div` placed and sized
@@ -52084,7 +52110,7 @@ class FilterEvaluationPlugin extends UIPlugin {
         "isFilterActive",
     ];
     filterValues = {};
-    hiddenRows = new Set();
+    hiddenRows = {};
     isEvaluationDirty = false;
     allowDispatch(cmd) {
         switch (cmd.type) {
@@ -52128,11 +52154,11 @@ class FilterEvaluationPlugin extends UIPlugin {
             case "UNFOLD_HEADER_GROUP":
             case "FOLD_ALL_HEADER_GROUPS":
             case "UNFOLD_ALL_HEADER_GROUPS":
-                this.updateHiddenRows();
+                this.updateHiddenRows(cmd.sheetId);
                 break;
             case "UPDATE_FILTER":
                 this.updateFilter(cmd);
-                this.updateHiddenRows();
+                this.updateHiddenRows(cmd.sheetId);
                 break;
             case "DUPLICATE_SHEET":
                 const filterValues = {};
@@ -52152,15 +52178,14 @@ class FilterEvaluationPlugin extends UIPlugin {
     }
     finalize() {
         if (this.isEvaluationDirty) {
-            this.updateHiddenRows();
+            for (const sheetId of this.getters.getSheetIds()) {
+                this.updateHiddenRows(sheetId);
+            }
             this.isEvaluationDirty = false;
         }
     }
     isRowFiltered(sheetId, row) {
-        if (sheetId !== this.getters.getActiveSheetId()) {
-            return false;
-        }
-        return this.hiddenRows.has(row);
+        return !!this.hiddenRows[sheetId]?.has(row);
     }
     getFilterHiddenValues(position) {
         const id = this.getters.getFilterId(position);
@@ -52187,8 +52212,7 @@ class FilterEvaluationPlugin extends UIPlugin {
             this.filterValues[sheetId] = {};
         this.filterValues[sheetId][id] = hiddenValues;
     }
-    updateHiddenRows() {
-        const sheetId = this.getters.getActiveSheetId();
+    updateHiddenRows(sheetId) {
         const filters = this.getters
             .getFilters(sheetId)
             .sort((filter1, filter2) => filter1.rangeWithHeaders.zone.top - filter2.rangeWithHeaders.zone.top);
@@ -52210,7 +52234,7 @@ class FilterEvaluationPlugin extends UIPlugin {
                 }
             }
         }
-        this.hiddenRows = hiddenRows;
+        this.hiddenRows[sheetId] = hiddenRows;
     }
     getCellValueAsString(sheetId, col, row) {
         const value = this.getters.getEvaluatedCell({ sheetId, col, row }).formattedValue;
@@ -53329,13 +53353,14 @@ class SheetViewPlugin extends UIPlugin {
         }
     }
     handleEvent(event) {
+        const sheetId = this.getters.getActiveSheetId();
         if (event.options.scrollIntoView) {
             let { col, row } = findCellInNewZone(event.previousAnchor.zone, event.anchor.zone);
             if (event.mode === "updateAnchor") {
                 const oldZone = event.previousAnchor.zone;
                 const newZone = event.anchor.zone;
                 // altering a zone should not move the viewport in a dimension that wasn't changed
-                const { top, bottom, left, right } = this.getters.getActiveMainViewport();
+                const { top, bottom, left, right } = this.getMainInternalViewport(sheetId);
                 if (oldZone.left === newZone.left && oldZone.right === newZone.right) {
                     col = left > col || col > right ? left : col;
                 }
@@ -53343,7 +53368,6 @@ class SheetViewPlugin extends UIPlugin {
                     row = top > row || row > bottom ? top : row;
                 }
             }
-            const sheetId = this.getters.getActiveSheetId();
             col = Math.min(col, this.getters.getNumberCols(sheetId) - 1);
             row = Math.min(row, this.getters.getNumberRows(sheetId) - 1);
             if (!this.sheetsWithDirtyViewports.has(sheetId)) {
@@ -53380,16 +53404,16 @@ class SheetViewPlugin extends UIPlugin {
                 this.setSheetViewOffset(cmd.offsetX, cmd.offsetY);
                 break;
             case "SHIFT_VIEWPORT_DOWN":
-                const { top } = this.getActiveMainViewport();
                 const sheetId = this.getters.getActiveSheetId();
-                const shiftedOffsetY = this.clipOffsetY(this.getters.getRowDimensions(sheetId, top).start + this.sheetViewHeight);
-                this.shiftVertically(shiftedOffsetY);
+                const { top, viewportHeight, offsetCorrectionY } = this.getMainInternalViewport(sheetId);
+                const topRowDims = this.getters.getRowDimensions(sheetId, top);
+                this.shiftVertically(topRowDims.start + viewportHeight - offsetCorrectionY);
                 break;
             case "SHIFT_VIEWPORT_UP": {
-                const { top } = this.getActiveMainViewport();
                 const sheetId = this.getters.getActiveSheetId();
-                const shiftedOffsetY = this.clipOffsetY(this.getters.getRowDimensions(sheetId, top).end - this.sheetViewHeight);
-                this.shiftVertically(shiftedOffsetY);
+                const { top, viewportHeight, offsetCorrectionY } = this.getMainInternalViewport(sheetId);
+                const topRowDims = this.getters.getRowDimensions(sheetId, top);
+                this.shiftVertically(topRowDims.end - offsetCorrectionY - viewportHeight);
                 break;
             }
             case "REMOVE_TABLE":
@@ -53812,17 +53836,6 @@ class SheetViewPlugin extends UIPlugin {
         const { maxOffsetX, maxOffsetY } = this.getMaximumSheetOffset();
         Object.values(this.getSubViewports(sheetId)).forEach((viewport) => viewport.setViewportOffset(clip(offsetX, 0, maxOffsetX), clip(offsetY, 0, maxOffsetY)));
     }
-    /**
-     * Clip the vertical offset within the allowed range.
-     * Not above the sheet, nor below the sheet.
-     */
-    clipOffsetY(offsetY) {
-        const { height } = this.getMainViewportRect();
-        const maxOffset = height - this.sheetViewHeight;
-        offsetY = Math.min(offsetY, maxOffset);
-        offsetY = Math.max(offsetY, 0);
-        return offsetY;
-    }
     getViewportOffset(sheetId) {
         return {
             x: this.viewports[sheetId]?.bottomRight.offsetScrollbarX || 0,
@@ -53878,12 +53891,15 @@ class SheetViewPlugin extends UIPlugin {
      * viewport top.
      */
     shiftVertically(offset) {
-        const { top } = this.getActiveMainViewport();
+        const sheetId = this.getters.getActiveSheetId();
+        const { top } = this.getMainInternalViewport(sheetId);
         const { scrollX } = this.getActiveSheetScrollInfo();
         this.setSheetViewOffset(scrollX, offset);
         const { anchor } = this.getters.getSelection();
-        const deltaRow = this.getActiveMainViewport().top - top;
-        this.selection.selectCell(anchor.cell.col, anchor.cell.row + deltaRow);
+        if (anchor.cell.row >= this.getters.getPaneDivisions(sheetId).ySplit) {
+            const deltaRow = this.getMainInternalViewport(sheetId).top - top;
+            this.selection.selectCell(anchor.cell.col, anchor.cell.row + deltaRow);
+        }
     }
     getVisibleFigures() {
         const sheetId = this.getters.getActiveSheetId();
@@ -54802,7 +54818,6 @@ css /* scss */ `
     cursor: pointer;
   }
 `;
-let tKey = 1;
 class SpreadsheetDashboard extends Component {
     static template = "o-spreadsheet-SpreadsheetDashboard";
     static props = {};
@@ -54881,13 +54896,9 @@ class SpreadsheetDashboard extends Component {
                     coordinates: rect,
                     position: { col, row },
                     action,
-                    // we can't rely on position only because a row or a column could
-                    // be inserted at any time.
-                    tKey: `${tKey}-${col}-${row}`,
                 });
             }
         }
-        tKey++;
         return cells;
     }
     getClickableAction(position) {
@@ -60186,6 +60197,6 @@ const constants = {
 export { AbstractCellClipboardHandler, AbstractChart, AbstractFigureClipboardHandler, CellErrorType, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, UIPlugin, __info__, addFunction, addRenderingLayer, astToFormula, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, stores, tokenColors, tokenize };
 
 
-__info__.version = "17.2.3";
-__info__.date = "2024-04-10T12:28:36.552Z";
-__info__.hash = "ab5e22d";
+__info__.version = "17.2.4";
+__info__.date = "2024-04-18T16:41:38.407Z";
+__info__.hash = "0c66038";