@odoo/o-spreadsheet 17.2.17 → 17.2.19

package/dist/o-spreadsheet.cjs.js

@@ -3,9 +3,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.2.17
- * @date 2024-07-18T14:23:50.417Z
- * @hash 9e0ea24
+ * @version 17.2.19
+ * @date 2024-08-02T08:22:56.367Z
+ * @hash c5ae261
  */
 
 'use strict';
@@ -487,7 +487,7 @@ function debounce(func, wait, immediate) {
     let timeout = undefined;
     const debounced = function () {
         const context = this;
-        const args = arguments;
+        const args = Array.from(arguments);
         function later() {
             timeout = undefined;
             if (!immediate) {
@@ -715,7 +715,7 @@ function getSearchRegex(searchStr, searchOptions) {
  */
 function largeMax(array) {
     let len = array.length;
-    if (len < 100000)
+    if (len < 100_000)
         return Math.max(...array);
     let max = -Infinity;
     while (len--) {
@@ -729,7 +729,7 @@ function largeMax(array) {
  */
 function largeMin(array) {
     let len = array.length;
-    if (len < 100000)
+    if (len < 100_000)
         return Math.min(...array);
     let min = +Infinity;
     while (len--) {
@@ -2670,13 +2670,16 @@ const wildcardToRegExp = memoize(function wildcardToRegExp(operand) {
     }
     return new RegExp("^" + exp + "$", "i");
 });
-function evaluatePredicate(value = "", criterion) {
+function evaluatePredicate(value = "", criterion, locale) {
     const { operator, operand } = criterion;
     if (operand === undefined || value === null || operand === null) {
         return false;
     }
     if (typeof operand === "number" && operator === "=") {
-        return value.toString() === operand.toString();
+        if (typeof value === "string" && (isNumber(value, locale) || isDateTime(value, locale))) {
+            return toNumber(value, locale) === operand;
+        }
+        return value === operand;
     }
     if (operator === "<>" || operator === "=") {
         let result;
@@ -2758,7 +2761,7 @@ function visitMatchingRanges(args, cb, locale, isQuery = false) {
             for (let k = 0; k < countArg - 1; k += 2) {
                 const criteriaValue = toMatrix(args[k])[i][j].value;
                 const criterion = predicates[k / 2];
-                validatedPredicates = evaluatePredicate(criteriaValue ?? undefined, criterion);
+                validatedPredicates = evaluatePredicate(criteriaValue ?? undefined, criterion, locale);
                 if (!validatedPredicates) {
                     break;
                 }
@@ -7182,7 +7185,7 @@ function textCell(value, format, formattedValue) {
 }
 function numberCell(value, format, formattedValue) {
     return {
-        value: value || 0,
+        value: value || 0, // necessary to avoid "-0" and NaN values,
         format,
         formattedValue,
         type: CellValueType.number,
@@ -19630,8 +19633,8 @@ function truncateLabel(label) {
 function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, truncateLabels = true }) {
     const options = {
         // https://www.chartjs.org/docs/latest/general/responsive.html
-        responsive: true,
-        maintainAspectRatio: false,
+        responsive: true, // will resize when its container is resized
+        maintainAspectRatio: false, // doesn't maintain the aspect ration (width/height =2 by default) so the user has the choice of the exact layout
         layout: {
             padding: { left: 20, right: 20, top: chart.title ? 10 : 25, bottom: 10 },
         },
@@ -19677,7 +19680,7 @@ function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, tr
             labels: truncateLabels ? labels.map(truncateLabel) : labels,
             datasets: [],
         },
-        platform: undefined,
+        platform: undefined, // This key is optional and will be set by chart.js
         plugins: [],
     };
 }
@@ -19954,7 +19957,7 @@ function getBarConfiguration(chart, labels, localeFormat) {
         },
         y: {
             position: chart.verticalAxisPosition,
-            beginAtZero: true,
+            beginAtZero: true, // the origin of the y axis is always zero
             ticks: {
                 color: fontColor,
                 callback: (value) => {
@@ -20478,7 +20481,7 @@ function getLineOrScatterConfiguration(chart, labels, options) {
         },
         y: {
             position: chart.verticalAxisPosition,
-            beginAtZero: true,
+            beginAtZero: true, // the origin of the y axis is always zero
             ticks: {
                 color: fontColor,
                 callback: (value) => {
@@ -20568,7 +20571,7 @@ function createLineOrScatterChartRuntime(chart, getters) {
         const dataset = {
             label,
             data,
-            tension: 0,
+            tension: 0, // 0 -> render straight lines, which is much faster
             borderColor: color,
             backgroundColor,
             pointBackgroundColor: color,
@@ -20790,7 +20793,7 @@ class PieChart extends AbstractChart {
             ...this.getDefinition(),
             backgroundColor: toXlsxHexColor(this.background || BACKGROUND_CHART_COLOR),
             fontColor: toXlsxHexColor(chartFontColor(this.background)),
-            verticalAxisPosition: "left",
+            verticalAxisPosition: "left", //TODO ExcelChartDefinition should be adapted, but can be done later
             dataSets,
             labelRange,
         };
@@ -23357,7 +23360,7 @@ const lightTemplateWithHeader = (colorSet) => ({
         style: { fillColor: colorSet.highlight, textColor: "#FFFFFF" },
         border: { bottom: { color: colorSet.highlight, style: "thin" } },
     },
-    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } },
+    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } }, // @compatibility: should be double line
     firstRowStripe: { border: { bottom: { color: colorSet.highlight, style: "thin" } } },
     secondRowStripe: { border: { bottom: { color: colorSet.highlight, style: "thin" } } },
 });
@@ -23375,7 +23378,7 @@ const lightTemplateAllBorders = (colorSet) => ({
         },
     },
     headerRow: { border: { bottom: { color: colorSet.highlight, style: "medium" } } },
-    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } },
+    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } }, // @compatibility: should be double line
     firstRowStripe: { style: { fillColor: colorSet.light } },
     firstColumnStripe: { style: { fillColor: colorSet.light } },
 });
@@ -23394,7 +23397,7 @@ const mediumTemplateBandedBorders = (colorSet) => ({
     headerRow: {
         style: { fillColor: colorSet.highlight, textColor: "#FFFFFF" },
     },
-    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } },
+    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } }, // @compatibility: should be double line
     firstRowStripe: { style: { fillColor: colorSet.light } },
     firstColumnStripe: { style: { fillColor: colorSet.light } },
 });
@@ -23430,7 +23433,7 @@ const mediumTemplateMinimalBorders = (colorSet) => ({
             bottom: { color: "#000000", style: "medium" },
         },
     },
-    totalRow: { border: { top: { color: "#000000", style: "medium" } } },
+    totalRow: { border: { top: { color: "#000000", style: "medium" } } }, // @compatibility: should be double line
     headerRow: {
         style: { fillColor: colorSet.highlight, textColor: "#FFFFFF" },
         border: { bottom: { color: "#000000", style: "medium" } },
@@ -23454,7 +23457,7 @@ const mediumTemplateAllBorders = (colorSet) => ({
         },
         style: { fillColor: colorSet.light },
     },
-    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } },
+    totalRow: { border: { top: { color: colorSet.highlight, style: "medium" } } }, // @compatibility: should be double line
     firstRowStripe: { style: { fillColor: colorSet.medium } },
     firstColumnStripe: { style: { fillColor: colorSet.medium } },
 });
@@ -23485,7 +23488,7 @@ const darkTemplateNoBorders = (colorSet) => ({
     category: "dark",
     colorName: colorSet.name,
     wholeTable: { style: { fillColor: colorSet.light } },
-    totalRow: { border: { top: { color: "#000000", style: "medium" } } },
+    totalRow: { border: { top: { color: "#000000", style: "medium" } } }, // @compatibility: should be double line
     headerRow: { style: { fillColor: colorSet.highlight, textColor: "#FFFFFF" } },
     firstRowStripe: { style: { fillColor: colorSet.medium } },
     firstColumnStripe: { style: { fillColor: colorSet.medium } },
@@ -32257,7 +32260,9 @@ class Composer extends owl.Component {
         argToFocus: 0,
     });
     compositionActive = false;
+    spreadsheetRect = useSpreadsheetRect();
     get assistantStyle() {
+        const composerRect = this.composerRef.el.getBoundingClientRect();
         const assistantStyle = {};
         assistantStyle["min-width"] = `${this.props.rect?.width || ASSISTANT_WIDTH}px`;
         const proposals = this.autoCompleteState.provider?.proposals;
@@ -32284,6 +32289,9 @@ class Composer extends owl.Component {
         }
         else if (this.props.delimitation) {
             assistantStyle["max-height"] = `${this.props.delimitation.height}px`;
+            if (composerRect.left + ASSISTANT_WIDTH > this.spreadsheetRect.width) {
+                assistantStyle.right = `0px`;
+            }
         }
         return cssPropertiesToCss(assistantStyle);
     }
@@ -33846,10 +33854,13 @@ function useCellHovered(env, gridRef, callback) {
         row: undefined,
     };
     const { Date } = window;
-    let x = 0;
-    let y = 0;
+    let x = undefined;
+    let y = undefined;
     let lastMoved = 0;
     function getPosition() {
+        if (x === undefined || y === undefined) {
+            return { col: -1, row: -1 };
+        }
         const col = env.model.getters.getColIndex(x);
         const row = env.model.getters.getRowIndex(y);
         return { col, row };
@@ -35680,7 +35691,7 @@ class VerticalScrollBar extends owl.Component {
     onScroll(offset) {
         const { scrollX } = this.env.model.getters.getActiveSheetDOMScrollInfo();
         this.env.model.dispatch("SET_VIEWPORT_OFFSET", {
-            offsetX: scrollX,
+            offsetX: scrollX, // offsetX is the same
             offsetY: offset,
         });
     }
@@ -35969,8 +35980,8 @@ class Grid extends owl.Component {
         "Ctrl+Shift+L": () => this.setHorizontalAlign("left"),
         "Ctrl+Shift+R": () => this.setHorizontalAlign("right"),
         "Ctrl+Shift+V": () => PASTE_AS_VALUE_ACTION(this.env),
-        "Ctrl+Shift+<": () => this.clearFormatting(),
-        "Ctrl+<": () => this.clearFormatting(),
+        "Ctrl+Shift+<": () => this.clearFormatting(), // for qwerty
+        "Ctrl+<": () => this.clearFormatting(), // for azerty
         "Ctrl+Shift+ ": () => {
             this.env.model.selection.selectAll();
         },
@@ -36771,10 +36782,10 @@ function convertCFCellIsOperator(xlsxCfOperator) {
 const CF_TYPE_CONVERSION_MAP = {
     aboveAverage: undefined,
     expression: undefined,
-    cellIs: undefined,
-    colorScale: undefined,
+    cellIs: undefined, // exist but isn't an operator in o_spreadsheet
+    colorScale: undefined, // exist but isn't an operator in o_spreadsheet
     dataBar: undefined,
-    iconSet: undefined,
+    iconSet: undefined, // exist but isn't an operator in o_spreadsheet
     top10: undefined,
     uniqueValues: undefined,
     duplicateValues: undefined,
@@ -37009,7 +37020,7 @@ const XLSX_INDEXED_COLORS = {
     61: "993366",
     62: "333399",
     63: "333333",
-    64: "000000",
+    64: "000000", // system foreground
     65: "FFFFFF", // system background
 };
 const IMAGE_MIMETYPE_TO_EXTENSION_MAPPING = {
@@ -40652,12 +40663,13 @@ class BordersPlugin extends CorePlugin {
                 this.clearBorders(cmd.sheetId, cmd.target);
                 break;
             case "REMOVE_COLUMNS_ROWS":
-                for (let el of [...cmd.elements].sort((a, b) => b - a)) {
+                const elements = [...cmd.elements].sort((a, b) => b - a);
+                for (const group of groupConsecutive(elements)) {
                     if (cmd.dimension === "COL") {
-                        this.shiftBordersHorizontally(cmd.sheetId, el + 1, -1);
+                        this.shiftBordersHorizontally(cmd.sheetId, group[group.length - 1] + 1, -group.length);
                     }
                     else {
-                        this.shiftBordersVertically(cmd.sheetId, el + 1, -1);
+                        this.shiftBordersVertically(cmd.sheetId, group[group.length - 1] + 1, -group.length);
                     }
                 }
                 break;
@@ -45022,12 +45034,7 @@ class SheetPlugin extends CorePlugin {
                         });
                     }
                     if (colIndex > deletedColumn) {
-                        this.dispatch("UPDATE_CELL_POSITION", {
-                            sheetId: sheet.id,
-                            cellId: cellId,
-                            col: colIndex - 1,
-                            row: rowIndex,
-                        });
+                        this.setNewPosition(cellId, sheet.id, colIndex - 1, rowIndex);
                     }
                 }
             }
@@ -45037,7 +45044,7 @@ class SheetPlugin extends CorePlugin {
      * Move the cells after a column or rows insertion
      */
     moveCellsOnAddition(sheet, addedElement, quantity, dimension) {
-        const commands = [];
+        const updates = [];
         for (let rowIndex = 0; rowIndex < sheet.rows.length; rowIndex++) {
             const row = sheet.rows[rowIndex];
             if (dimension !== "rows" || rowIndex >= addedElement) {
@@ -45046,20 +45053,20 @@ class SheetPlugin extends CorePlugin {
                     const cellId = row.cells[i];
                     if (cellId) {
                         if (dimension === "rows" || colIndex >= addedElement) {
-                            commands.push({
-                                type: "UPDATE_CELL_POSITION",
+                            updates.push({
                                 sheetId: sheet.id,
                                 cellId: cellId,
                                 col: colIndex + (dimension === "columns" ? quantity : 0),
                                 row: rowIndex + (dimension === "rows" ? quantity : 0),
+                                type: "UPDATE_CELL_POSITION",
                             });
                         }
                     }
                 }
             }
         }
-        for (let cmd of commands.reverse()) {
-            this.dispatch(cmd.type, cmd);
+        for (let update of updates.reverse()) {
+            this.updateCellPosition(update);
         }
     }
     /**
@@ -45092,12 +45099,7 @@ class SheetPlugin extends CorePlugin {
                     const colIndex = Number(i);
                     const cellId = row.cells[i];
                     if (cellId) {
-                        this.dispatch("UPDATE_CELL_POSITION", {
-                            sheetId: sheet.id,
-                            cellId: cellId,
-                            col: colIndex,
-                            row: rowIndex - numberRows,
-                        });
+                        this.setNewPosition(cellId, sheet.id, colIndex, rowIndex - numberRows);
                     }
                 }
             }
@@ -48290,17 +48292,17 @@ function isBadExpression(tokens) {
  */
 function sortWithClusters(colorsToSort) {
     const clusters = [
-        { leadColor: rgba(255, 0, 0), colors: [] },
-        { leadColor: rgba(255, 128, 0), colors: [] },
-        { leadColor: rgba(128, 128, 0), colors: [] },
-        { leadColor: rgba(128, 255, 0), colors: [] },
-        { leadColor: rgba(0, 255, 0), colors: [] },
-        { leadColor: rgba(0, 255, 128), colors: [] },
-        { leadColor: rgba(0, 255, 255), colors: [] },
-        { leadColor: rgba(0, 127, 255), colors: [] },
-        { leadColor: rgba(0, 0, 255), colors: [] },
-        { leadColor: rgba(127, 0, 255), colors: [] },
-        { leadColor: rgba(128, 0, 128), colors: [] },
+        { leadColor: rgba(255, 0, 0), colors: [] }, // red
+        { leadColor: rgba(255, 128, 0), colors: [] }, // orange
+        { leadColor: rgba(128, 128, 0), colors: [] }, // yellow
+        { leadColor: rgba(128, 255, 0), colors: [] }, // chartreuse
+        { leadColor: rgba(0, 255, 0), colors: [] }, // green
+        { leadColor: rgba(0, 255, 128), colors: [] }, // spring green
+        { leadColor: rgba(0, 255, 255), colors: [] }, // cyan
+        { leadColor: rgba(0, 127, 255), colors: [] }, // azure
+        { leadColor: rgba(0, 0, 255), colors: [] }, // blue
+        { leadColor: rgba(127, 0, 255), colors: [] }, // violet
+        { leadColor: rgba(128, 0, 128), colors: [] }, // magenta
         { leadColor: rgba(255, 0, 128), colors: [] }, // rose
     ];
     for (const color of colorsToSort.map(colorToRGBA)) {
@@ -55421,7 +55423,7 @@ class BottomBar extends owl.Component {
             .map((sheetEl) => sheetEl.getBoundingClientRect())
             .map((rect) => ({
             x: rect.x,
-            width: rect.width - 1,
+            width: rect.width - 1, // -1 to compensate negative margin
             y: rect.y,
             height: rect.height,
         }));
@@ -55643,7 +55645,7 @@ class RowGroup extends AbstractHeaderGroup {
         }
         return cssPropertiesToCss({
             top: `${groupBox.headerRect.height / 2}px`,
-            left: `calc(50% - 1px)`,
+            left: `calc(50% - 1px)`, // -1px: we want the border to be on the center
             width: `30%`,
             height: `calc(100% - ${groupBox.headerRect.height / 2}px)`,
             "border-left": `1px solid ${HEADER_GROUPING_BORDER_COLOR}`,
@@ -55695,7 +55697,7 @@ class ColGroup extends AbstractHeaderGroup {
             return "";
         }
         return cssPropertiesToCss({
-            top: `calc(50% - 1px)`,
+            top: `calc(50% - 1px)`, // -1px: we want the border to be on the center
             left: `${groupBox.headerRect.width / 2}px`,
             width: `calc(100% - ${groupBox.headerRect.width / 2}px)`,
             height: `30%`,
@@ -57113,7 +57115,7 @@ class Spreadsheet extends owl.Component {
         const gridColSize = GROUP_LAYER_WIDTH * this.rowLayers.length;
         const gridRowSize = GROUP_LAYER_WIDTH * this.colLayers.length;
         return cssPropertiesToCss({
-            "grid-template-columns": `${gridColSize ? gridColSize + 2 : 0}px auto`,
+            "grid-template-columns": `${gridColSize ? gridColSize + 2 : 0}px auto`, // +2: margins
             "grid-template-rows": `${gridRowSize ? gridRowSize + 2 : 0}px auto`,
         });
     }
@@ -58563,7 +58565,7 @@ class SelectionStreamProcessorImpl {
 }
 
 class StateObserver {
-    changes = [];
+    changes;
     commands = [];
     /**
      * Record the changes which could happen in the given callback, save them in a
@@ -58595,7 +58597,7 @@ class StateObserver {
         if (value[key] === val) {
             return;
         }
-        this.changes.push({
+        this.changes?.push({
             path: args,
             before: value[key],
             after: val,
@@ -59726,7 +59728,7 @@ function addTableColumns(table, sheetData) {
         const colHeaderXc = toXC(tableZone.left + i, tableZone.top);
         const colName = sheetData.cells[colHeaderXc]?.content || `col${i}`;
         const colAttributes = [
-            ["id", i + 1],
+            ["id", i + 1], // id cannot be 0
             ["name", colName],
         ];
         columns.push(escapeXml /*xml*/ `<tableColumn ${formatAttributes(colAttributes)}/>`);
@@ -60883,6 +60885,6 @@ exports.tokenColors = tokenColors;
 exports.tokenize = tokenize;
 
 
-__info__.version = "17.2.17";
-__info__.date = "2024-07-18T14:23:50.417Z";
-__info__.hash = "9e0ea24";
+__info__.version = "17.2.19";
+__info__.date = "2024-08-02T08:22:56.367Z";
+__info__.hash = "c5ae261";

package/dist/o-spreadsheet.d.ts

@@ -6759,6 +6759,7 @@ declare class Composer extends Component<ComposerProps, SpreadsheetChildEnv> {
     autoCompleteState: AutoCompleteState;
     functionDescriptionState: FunctionDescriptionState;
     private compositionActive;
+    private spreadsheetRect;
     get assistantStyle(): string;
     shouldProcessInputEvents: boolean;
     tokens: EnrichedToken[];
@@ -9058,7 +9059,7 @@ declare class Spreadsheet extends Component<SpreadsheetProps, SpreadsheetChildEn
     private notificationStore;
     private composerFocusStore;
     get model(): Model;
-    getStyle(): string;
+    getStyle(): "grid-template-rows: auto;" | "grid-template-rows: 63px auto 37px";
     setup(): void;
     private bindModelEvents;
     private unbindModelEvents;