@odoo/o-spreadsheet 17.2.0-alpha.4 → 17.2.0-alpha.5

package/dist/o-spreadsheet.cjs.js

@@ -3,9 +3,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.2.0-alpha.4
- * @date 2024-02-09T13:10:23.460Z
- * @hash 1b33cf4
+ * @version 17.2.0-alpha.5
+ * @date 2024-02-16T14:27:52.323Z
+ * @hash 0c69dd8
  */
 
 'use strict';
@@ -455,8 +455,8 @@ function isObjectEmptyRecursive(argument) {
  * If the given item does not exist in the dictionary, it creates one with a new id.
  */
 function getItemId(item, itemsDic) {
-    for (let [key, value] of Object.entries(itemsDic)) {
-        if (deepEquals(value, item)) {
+    for (const key in itemsDic) {
+        if (deepEquals(itemsDic[key], item)) {
             return parseInt(key, 10);
         }
     }
@@ -560,11 +560,13 @@ function deepEquals(o1, o2) {
     if (typeof o1 !== "object")
         return o1 === o2;
     // Objects can have different keys if the values are undefined
-    const keys = new Set();
-    Object.keys(o1).forEach((key) => keys.add(key));
-    Object.keys(o2).forEach((key) => keys.add(key));
-    for (let key of keys) {
-        if (typeof o1[key] !== typeof o1[key])
+    for (const key in o2) {
+        if (!(key in o1) && o2[key] !== undefined) {
+            return false;
+        }
+    }
+    for (const key in o1) {
+        if (typeof o1[key] !== typeof o2[key])
             return false;
         if (typeof o1[key] === "object") {
             if (!deepEquals(o1[key], o2[key]))
@@ -634,18 +636,18 @@ function isConsecutive(iterable) {
     return true;
 }
 class JetSet extends Set {
-    add(...iterable) {
+    addMany(iterable) {
         for (const element of iterable) {
             super.add(element);
         }
         return this;
     }
-    delete(...iterable) {
-        let deleted = false;
+    deleteMany(iterable) {
+        let wasDeleted = false;
         for (const element of iterable) {
-            deleted ||= super.delete(element);
+            wasDeleted ||= super.delete(element);
         }
-        return deleted;
+        return wasDeleted;
     }
 }
 /**
@@ -1947,7 +1949,7 @@ class DispatchResult {
      * Static helper which returns a successful DispatchResult
      */
     static get Success() {
-        return new DispatchResult();
+        return SUCCESS;
     }
     get isSuccessful() {
         return this.reasons.length === 0;
@@ -1960,6 +1962,7 @@ class DispatchResult {
         return this.reasons.includes(reason);
     }
 }
+const SUCCESS = new DispatchResult();
 exports.CommandResult = void 0;
 (function (CommandResult) {
     CommandResult["Success"] = "Success";
@@ -2266,7 +2269,7 @@ const normalizeString = memoize(function normalizeString(str) {
         .normalize("NFD")
         .replace(/[\u0300-\u036f]/g, "");
 });
-const expectBooleanValueError = (value) => _t("The function [[FUNCTION_NAME]] expects a boolean value, but '%s' is a text, and cannot be coerced to a number.", value);
+const expectBooleanValueError = (value) => _t("The function [[FUNCTION_NAME]] expects a boolean value, but '%s' is a text, and cannot be coerced to a boolean.", value);
 function toBoolean(data) {
     const value = toValue(data);
     switch (typeof value) {
@@ -7530,6 +7533,9 @@ class DependencyContainer {
      * Also useful for mocking a store.
      */
     inject(Store, instance) {
+        if (this.dependencies.has(Store) && this.dependencies.get(Store) !== instance) {
+            throw new Error(`Store ${Store.name} already has an instance`);
+        }
         this.dependencies.set(Store, instance);
     }
     /**
@@ -11358,8 +11364,10 @@ class ChartFigure extends owl.Component {
     };
     static components = {};
     onDoubleClick() {
-        this.env.model.dispatch("SELECT_FIGURE", { id: this.props.figure.id });
-        this.env.openSidePanel("ChartPanel");
+        const result = this.env.model.dispatch("SELECT_FIGURE", { id: this.props.figure.id });
+        if (result.isSuccessful) {
+            this.env.openSidePanel("ChartPanel");
+        }
     }
     get chartType() {
         return this.env.model.getters.getChartType(this.props.figure.id);
@@ -13916,6 +13924,12 @@ const INSERT_LINK = (env) => {
     let { col, row } = env.model.getters.getActivePosition();
     env.getStore(CellPopoverStore).open({ col, row }, "LinkEditor");
 };
+const INSERT_LINK_NAME = (env) => {
+    const sheetId = env.model.getters.getActiveSheetId();
+    const { col, row } = env.model.getters.getActivePosition();
+    const cell = env.model.getters.getEvaluatedCell({ sheetId, col, row });
+    return cell && cell.link ? _t("Edit link") : _t("Insert link");
+};
 //------------------------------------------------------------------------------
 // Filters action
 //------------------------------------------------------------------------------
@@ -21722,6 +21736,68 @@ const INDEX = {
     isExported: true,
 };
 // -----------------------------------------------------------------------------
+// INDEX
+// -----------------------------------------------------------------------------
+const INDIRECT = {
+    description: _t("Returns the content of a cell, specified by a string."),
+    args: [
+        arg("reference (string)", _t("The range of cells from which the values are returned.")),
+        arg("use_a1_notation (boolean, default=TRUE)", _t("A boolean indicating whether to use A1 style notation (TRUE) or R1C1 style notation (FALSE).")),
+    ],
+    returns: ["ANY"],
+    compute: function (reference, useA1Notation = { value: true }) {
+        let _reference = reference?.value?.toString();
+        if (!_reference) {
+            throw new InvalidReferenceError(_t("Reference should be defined."));
+        }
+        const _useA1Notation = toBoolean(useA1Notation);
+        if (!_useA1Notation) {
+            throw new EvaluationError(_t("R1C1 notation is not supported."));
+        }
+        const sheetId = this.__originSheetId;
+        let originPosition;
+        const __originCellXC = this.__originCellXC?.();
+        if (__originCellXC) {
+            const cellZone = toZone(__originCellXC);
+            originPosition = {
+                sheetId,
+                col: cellZone.left,
+                row: cellZone.top,
+            };
+            // The following line is used to reset the dependencies of the cell, to avoid
+            // keeping dependencies from previous evaluation of the INDIRECT formula (i.e.
+            // in case the reference has been changed).
+            this.updateDependencies?.(originPosition);
+        }
+        const range = this.getters.getRangeFromSheetXC(sheetId, _reference);
+        if (range === undefined || range.invalidXc || range.invalidSheetName) {
+            throw new InvalidReferenceError();
+        }
+        if (originPosition) {
+            this.addDependencies?.(originPosition, [range]);
+        }
+        const values = [];
+        for (let col = range.zone.left; col <= range.zone.right; col++) {
+            const colValues = [];
+            for (let row = range.zone.top; row <= range.zone.bottom; row++) {
+                const position = { sheetId: range.sheetId, col, row };
+                // The below 'value' is typed as CellValue because the evaluateFormula will have to
+                // evaluate a string containing the A1 reference of a single cell, so this will
+                // return a CellValue.
+                const value = this.getters.evaluateFormula(range.sheetId, toXC(col, row));
+                const evaluatedCell = this.getters.getEvaluatedCell(position);
+                colValues.push({
+                    ...evaluatedCell,
+                    value,
+                });
+            }
+            values.push(colValues);
+        }
+        return values.length === 1 && values[0].length === 1 ? values[0][0] : values;
+    },
+    isExported: true,
+};
+// -----------------------------------------------------------------------------
 // LOOKUP
 // -----------------------------------------------------------------------------
 const LOOKUP = {
@@ -21927,6 +22003,7 @@ var lookup = /*#__PURE__*/Object.freeze({
   COLUMNS: COLUMNS,
   HLOOKUP: HLOOKUP,
   INDEX: INDEX,
+  INDIRECT: INDIRECT,
   LOOKUP: LOOKUP,
   MATCH: MATCH,
   ROW: ROW,
@@ -22902,7 +22979,7 @@ const insertImage = {
 };
 const insertFunction = {
     name: _t("Function"),
-    icon: "o-spreadsheet-Icon.SHOW_HIDE_FORMULA",
+    icon: "o-spreadsheet-Icon.FORMULA",
 };
 const insertFunctionSum = {
     name: _t("SUM"),
@@ -23124,7 +23201,7 @@ cellMenuRegistry
 })
     .add("insert_link", {
     ...insertLink,
-    name: _t("Insert link"),
+    name: INSERT_LINK_NAME,
     sequence: 150,
     separator: true,
 });
@@ -23789,9 +23866,7 @@ const freezeCurrentCol = {
     isReadonlyAllowed: true,
 };
 const viewGridlines = {
-    name: (env) => env.model.getters.getGridLinesVisibility(env.model.getters.getActiveSheetId())
-        ? _t("Hide gridlines")
-        : _t("Show gridlines"),
+    name: _t("Gridlines"),
     execute: (env) => {
         const sheetId = env.model.getters.getActiveSheetId();
         env.model.dispatch("SET_GRID_LINES_VISIBILITY", {
@@ -23799,13 +23874,16 @@ const viewGridlines = {
             areGridLinesVisible: !env.model.getters.getGridLinesVisibility(sheetId),
         });
     },
-    icon: "o-spreadsheet-Icon.SHOW_HIDE_GRID",
+    isActive: (env) => {
+        const sheetId = env.model.getters.getActiveSheetId();
+        return env.model.getters.getGridLinesVisibility(sheetId);
+    },
 };
 const viewFormulas = {
-    name: (env) => env.model.getters.shouldShowFormulas() ? "Hide formulas" : _t("Show formulas"),
+    name: _t("Formulas"),
+    isActive: (env) => env.model.getters.shouldShowFormulas(),
     execute: (env) => env.model.dispatch("SET_FORMULA_VISIBILITY", { show: !env.model.getters.shouldShowFormulas() }),
     isReadonlyAllowed: true,
-    icon: "o-spreadsheet-Icon.SHOW_HIDE_FORMULA",
 };
 const createRemoveFilter = {
     name: (env) => selectionContainsFilter(env) ? _t("Remove selected filters") : _t("Create filter"),
@@ -24362,13 +24440,18 @@ topbarMenuRegistry
     isVisible: (env) => canUngroupHeaders(env, "ROW"),
     sequence: 20,
 })
-    .addChild("view_gridlines", ["view"], {
+    .addChild("show", ["view"], {
+    name: _t("Show"),
+    sequence: 1,
+    icon: "o-spreadsheet-Icon.SHOW",
+})
+    .addChild("view_gridlines", ["view", "show"], {
     ...viewGridlines,
-    sequence: 15,
+    sequence: 5,
 })
-    .addChild("view_formulas", ["view"], {
+    .addChild("view_formulas", ["view", "show"], {
     ...viewFormulas,
-    sequence: 20,
+    sequence: 10,
 })
     // ---------------------------------------------------------------------
     // INSERT MENU ITEMS
@@ -25351,6 +25434,17 @@ class TextValueProvider extends owl.Component {
         onValueSelected: Function,
         onValueHovered: Function,
     };
+    autoCompleteListRef = owl.useRef("autoCompleteList");
+    setup() {
+        owl.useEffect(() => {
+            const selectedIndex = this.props.selectedIndex;
+            if (selectedIndex === undefined) {
+                return;
+            }
+            const selectedElement = this.autoCompleteListRef.el?.children[selectedIndex];
+            selectedElement?.scrollIntoView?.({ block: "nearest" });
+        }, () => [this.props.selectedIndex, this.autoCompleteListRef.el]);
+    }
 }
 
 class ContentEditableHelper {
@@ -25795,6 +25889,7 @@ css /* scss */ `
       position: absolute;
       margin: 1px 4px;
       pointer-events: none;
+      overflow: auto;
 
       .o-semi-bold {
         /** FIXME: to remove in favor of Bootstrap
@@ -25854,7 +25949,10 @@ class Composer extends owl.Component {
         if (this.props.delimitation && this.props.rect) {
             const { x: cellX, y: cellY, height: cellHeight } = this.props.rect;
             const remainingHeight = this.props.delimitation.height - (cellY + cellHeight);
+            assistantStyle["max-height"] = `${remainingHeight}px`;
             if (cellY > remainingHeight) {
+                const availableSpaceAbove = cellY;
+                assistantStyle["max-height"] = `${availableSpaceAbove}px`;
                 // render top
                 // We compensate 2 px of margin on the assistant style + 1px for design reasons
                 assistantStyle.top = `-3px`;
@@ -29459,6 +29557,34 @@ class VerticalScrollBar extends owl.Component {
     }
 }
 
+class SidePanelStore extends SpreadsheetStore {
+    isOpen = false;
+    panelProps = {};
+    componentTag = "";
+    open(componentTag, panelProps = {}) {
+        if (this.isOpen && componentTag !== this.componentTag) {
+            this.panelProps?.onCloseSidePanel?.();
+        }
+        this.componentTag = componentTag;
+        this.panelProps = panelProps;
+        this.isOpen = true;
+    }
+    toggle(componentTag, panelProps) {
+        if (this.isOpen && componentTag === this.componentTag) {
+            this.close();
+        }
+        else {
+            this.open(componentTag, panelProps);
+        }
+    }
+    close() {
+        this.panelProps.onCloseSidePanel?.();
+        this.isOpen = false;
+        this.panelProps = {};
+        this.componentTag = "";
+    }
+}
+
 const registries$1 = {
     ROW: rowMenuRegistry,
     COL: colMenuRegistry,
@@ -29472,7 +29598,6 @@ const registries$1 = {
 class Grid extends owl.Component {
     static template = "o-spreadsheet-Grid";
     static props = {
-        sidePanelIsOpen: Boolean,
         exposeFocus: Function,
     };
     static components = {
@@ -29501,6 +29626,7 @@ class Grid extends owl.Component {
     onMouseWheel;
     canvasPosition;
     hoveredCell;
+    sidePanel;
     setup() {
         this.highlightStore = useStore(HighlightStore);
         this.menuState = owl.useState({
@@ -29514,6 +29640,7 @@ class Grid extends owl.Component {
         this.composerStore = useStore(ComposerStore);
         this.composerFocusStore = useStore(ComposerFocusStore);
         this.DOMFocusableElementStore = useStore(DOMFocusableElementStore);
+        this.sidePanel = useStore(SidePanelStore);
         owl.useChildSubEnv({ getPopoverContainerRect: () => this.getGridRect() });
         owl.useExternalListener(document.body, "cut", this.copy.bind(this, true));
         owl.useExternalListener(document.body, "copy", this.copy.bind(this, false));
@@ -29526,6 +29653,11 @@ class Grid extends owl.Component {
             this.hoveredCell.clear();
         });
         this.cellPopovers = useStore(CellPopoverStore);
+        owl.useEffect(() => {
+            if (!this.sidePanel.isOpen) {
+                this.DOMFocusableElementStore.focus();
+            }
+        }, () => [this.sidePanel.isOpen]);
     }
     onCellHovered({ col, row }) {
         this.hoveredCell.hover({ col, row });
@@ -30902,6 +31034,7 @@ class Checkbox extends owl.Component {
         value: { type: Boolean, optional: true },
         className: { type: String, optional: true },
         name: { type: String, optional: true },
+        title: { type: String, optional: true },
         onChange: Function,
     };
     static defaultProps = { value: false };
@@ -31913,6 +32046,35 @@ chartSidePanelComponentRegistry
     design: ScorecardChartDesignPanel,
 });
 
+class MainChartPanelStore extends SpreadsheetStore {
+    sidePanel = this.get(SidePanelStore);
+    figureId;
+    panel = "configuration";
+    constructor(get, figureId) {
+        super(get);
+        this.figureId = figureId;
+    }
+    handle(cmd) {
+        switch (cmd.type) {
+            case "DELETE_FIGURE":
+                if (this.sidePanel.componentTag === "ChartPanel" && this.figureId === cmd.id) {
+                    this.sidePanel.close();
+                }
+                break;
+            case "SELECT_FIGURE":
+                if (cmd.id) {
+                    this.figureId = cmd.id;
+                }
+                else if (this.sidePanel.componentTag === "ChartPanel") {
+                    this.sidePanel.close();
+                }
+        }
+    }
+    activatePanel(panel) {
+        this.panel = panel;
+    }
+}
+
 css /* scss */ `
   .o-chart {
     .o-panel {
@@ -31941,37 +32103,19 @@ class ChartPanel extends owl.Component {
     static template = "o-spreadsheet-ChartPanel";
     static components = { Section };
     static props = { onCloseSidePanel: Function };
-    state;
+    store;
     get figureId() {
-        return this.state.figureId;
+        return this.store.figureId;
     }
     setup() {
-        const selectedFigureId = this.env.model.getters.getSelectedFigureId();
-        if (!selectedFigureId) {
-            this.props.onCloseSidePanel();
-            return;
-        }
-        this.state = owl.useState({
-            panel: "configuration",
-            figureId: selectedFigureId,
-        });
-        owl.onWillUpdateProps(() => {
-            const selectedFigureId = this.env.model.getters.getSelectedFigureId();
-            if (selectedFigureId && selectedFigureId !== this.state.figureId) {
-                this.state.figureId = selectedFigureId;
-            }
-            if (!this.env.model.getters.isChartDefined(this.figureId)) {
-                this.props.onCloseSidePanel();
-                return;
-            }
-        });
+        this.store = useLocalStore(MainChartPanelStore, this.env.model.getters.getSelectedFigureId());
     }
     updateChart(figureId, updateDefinition) {
         if (figureId !== this.figureId) {
             return;
         }
         const definition = {
-            ...this.getChartDefinition(),
+            ...this.getChartDefinition(this.figureId),
             ...updateDefinition,
         };
         return this.env.model.dispatch("UPDATE_CHART", {
@@ -31985,7 +32129,7 @@ class ChartPanel extends owl.Component {
             return;
         }
         const definition = {
-            ...this.getChartDefinition(),
+            ...this.getChartDefinition(this.figureId),
             ...updateDefinition,
         };
         return this.env.model.canDispatch("UPDATE_CHART", {
@@ -31995,6 +32139,9 @@ class ChartPanel extends owl.Component {
         });
     }
     onTypeChange(type) {
+        if (!this.figureId) {
+            return;
+        }
         const context = this.env.model.getters.getContextCreationChart(this.figureId);
         if (!context) {
             throw new Error("Chart not defined.");
@@ -32007,6 +32154,9 @@ class ChartPanel extends owl.Component {
         });
     }
     get chartPanel() {
+        if (!this.figureId) {
+            throw new Error("Chart not defined.");
+        }
         const type = this.env.model.getters.getChartType(this.figureId);
         if (!type) {
             throw new Error("Chart not defined.");
@@ -32017,15 +32167,12 @@ class ChartPanel extends owl.Component {
         }
         return chartPanel;
     }
-    getChartDefinition(figureId = this.figureId) {
+    getChartDefinition(figureId) {
         return this.env.model.getters.getChartDefinition(figureId);
     }
     get chartTypes() {
         return getChartTypes();
     }
-    activatePanel(panel) {
-        this.state.panel = panel;
-    }
 }
 
 const BORDER_COLOR = "#8B008B";
@@ -32119,7 +32266,7 @@ class FindAndReplaceStore extends SpreadsheetStore {
     }
     finalize() {
         if (this.isSearchDirty) {
-            this.refreshSearch();
+            this.refreshSearch(false);
             this.isSearchDirty = false;
         }
     }
@@ -32151,10 +32298,10 @@ class FindAndReplaceStore extends SpreadsheetStore {
     /**
      * refresh the matches according to the current search options
      */
-    refreshSearch() {
+    refreshSearch(jumpToMatchSheet = true) {
         this.selectedMatchIndex = null;
         this.findMatches();
-        this.selectNextCell(Direction.current);
+        this.selectNextCell(Direction.current, jumpToMatchSheet);
     }
     getSheetsInSearchOrder() {
         switch (this.searchOptions.searchScope) {
@@ -32224,7 +32371,7 @@ class FindAndReplaceStore extends SpreadsheetStore {
      * It is also used to keep coherence between the selected searchMatch
      * and selectedMatchIndex.
      */
-    selectNextCell(indexChange) {
+    selectNextCell(indexChange, jumpToMatchSheet = true) {
         const matches = this.searchMatches;
         if (!matches.length) {
             this.selectedMatchIndex = null;
@@ -32250,7 +32397,7 @@ class FindAndReplaceStore extends SpreadsheetStore {
         this.selectedMatchIndex = nextIndex;
         const selectedMatch = matches[nextIndex];
         // Switch to the sheet where the match is located
-        if (this.getters.getActiveSheetId() !== selectedMatch.sheetId) {
+        if (jumpToMatchSheet && this.getters.getActiveSheetId() !== selectedMatch.sheetId) {
             this.model.dispatch("ACTIVATE_SHEET", {
                 sheetIdFrom: this.getters.getActiveSheetId(),
                 sheetIdTo: selectedMatch.sheetId,
@@ -36967,22 +37114,7 @@ class BordersPlugin extends CorePlugin {
         }
     }
     export(data) {
-        // Borders
-        let borderId = 0;
         const borders = {};
-        /**
-         * Get the id of the given border. If the border does not exist, it creates
-         * one.
-         */
-        function getBorderId(border) {
-            for (let [key, value] of Object.entries(borders)) {
-                if (deepEquals(value, border)) {
-                    return parseInt(key, 10);
-                }
-            }
-            borders[++borderId] = border;
-            return borderId;
-        }
         for (let sheet of data.sheets) {
             for (let col = 0; col < sheet.colNumber; col++) {
                 for (let row = 0; row < sheet.rowNumber; row++) {
@@ -36990,7 +37122,7 @@ class BordersPlugin extends CorePlugin {
                     if (border) {
                         const xc = toXC(col, row);
                         const cell = sheet.cells[xc];
-                        const borderId = getBorderId(border);
+                        const borderId = getItemId(border, borders);
                         if (cell) {
                             cell.border = borderId;
                         }
@@ -37687,9 +37819,9 @@ class CellPlugin extends CorePlugin {
     allowDispatch(cmd) {
         switch (cmd.type) {
             case "UPDATE_CELL":
-                return this.checkCellOutOfSheet(cmd);
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
             case "CLEAR_CELL":
-                return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
             default:
                 return "Success" /* CommandResult.Success */;
         }
@@ -37859,8 +37991,8 @@ class CellPlugin extends CorePlugin {
     }
     removeDefaultStyleValues(style) {
         const cleanedStyle = { ...style };
-        for (const [property, defaultValue] of Object.entries(DEFAULT_STYLE)) {
-            if (cleanedStyle[property] === defaultValue) {
+        for (const property in DEFAULT_STYLE) {
+            if (cleanedStyle[property] === DEFAULT_STYLE[property]) {
                 delete cleanedStyle[property];
             }
         }
@@ -38016,10 +38148,7 @@ class CellPlugin extends CorePlugin {
         else {
             style = before ? before.style : undefined;
         }
-        const locale = this.getters.getLocale();
-        let format = ("format" in after ? after.format : before && before.format) ||
-            detectDateFormat(afterContent, locale) ||
-            detectNumberFormat(afterContent);
+        const format = "format" in after ? after.format : before && before.format;
         /* Read the following IF as:
          * we need to remove the cell if it is completely empty, but we can know if it completely empty if:
          * - the command says the new content is empty and has no border/format/style
@@ -38060,6 +38189,7 @@ class CellPlugin extends CorePlugin {
     }
     createLiteralCell(id, content, format, style) {
         const locale = this.getters.getLocale();
+        format = format || detectDateFormat(content, locale) || detectNumberFormat(content);
         if (format !== PLAIN_TEXT_FORMAT && !isEvaluationError(content)) {
             content = toString(parseLiteral(content, locale));
         }
@@ -38132,6 +38262,18 @@ class CellPlugin extends CorePlugin {
         }
         return "Success" /* CommandResult.Success */;
     }
+    checkUselessUpdateCell(cmd) {
+        const cell = this.getters.getCell(cmd);
+        const hasContent = "content" in cmd || "formula" in cmd;
+        const hasStyle = "style" in cmd;
+        const hasFormat = "format" in cmd;
+        if ((!hasContent || cell?.content === cmd.content) &&
+            (!hasStyle || deepEquals(cell?.style, cmd.style)) &&
+            (!hasFormat || cell?.format === cmd.format)) {
+            return "NoChanges" /* CommandResult.NoChanges */;
+        }
+        return "Success" /* CommandResult.Success */;
+    }
 }
 class FormulaCellWithDependencies {
     id;
@@ -42947,7 +43089,15 @@ class SpreadsheetRTree {
         if (!this.rTrees[sheetId]) {
             return;
         }
-        this.rTrees[sheetId].remove(item, deepEquals);
+        this.rTrees[sheetId].remove(item, this.rtreeItemComparer);
+    }
+    rtreeItemComparer(left, right) {
+        return (left.data == right.data &&
+            left.boundingBox.sheetId === right.boundingBox.sheetId &&
+            left.boundingBox?.zone.left === right.boundingBox.zone.left &&
+            left.boundingBox?.zone.top === right.boundingBox.zone.top &&
+            left.boundingBox?.zone.right === right.boundingBox.zone.right &&
+            left.boundingBox?.zone.bottom === right.boundingBox.zone.bottom);
     }
 }
 /**
@@ -43025,7 +43175,7 @@ class FormulaDependencyGraph {
         const queue = Array.from(ranges).reverse();
         while (queue.length > 0) {
             const range = queue.pop();
-            visited.add(...this.encoder.encodeBoundingBox(range));
+            visited.addMany(this.encoder.encodeBoundingBox(range));
             const impactedPositionIds = this.rTree.search(range).map((dep) => dep.data);
             for (const positionId of impactedPositionIds) {
                 if (!visited.has(positionId)) {
@@ -43033,7 +43183,7 @@ class FormulaDependencyGraph {
                 }
             }
         }
-        visited.delete(...ranges.flatMap((r) => this.encoder.encodeBoundingBox(r)));
+        visited.deleteMany(ranges.flatMap((r) => this.encoder.encodeBoundingBox(r)));
         return visited;
     }
 }
@@ -43119,6 +43269,7 @@ const EMPTY_ARRAY = [];
 const MAX_ITERATION = 30;
 const ERROR_CYCLE_CELL = createEvaluatedCell(new CircularDependencyError());
 const EMPTY_CELL = createEvaluatedCell({ value: null });
+const EVAL_CONTEXT_INDEX = 2;
 class Evaluator {
     context;
     getters;
@@ -43164,17 +43315,24 @@ class Evaluator {
         const dependencies = this.getDirectDependencies(positionId);
         this.formulaDependencies().addDependencies(positionId, dependencies);
     }
+    addDependencies(position, dependencies) {
+        const positionId = this.encoder.encode(position);
+        this.formulaDependencies().addDependencies(positionId, dependencies);
+    }
     updateCompilationParameters() {
         // rebuild the compilation parameters (with a clean cache)
         this.compilationParams = buildCompilationParameters(this.context, this.getters, this.computeAndSave.bind(this));
+        this.compilationParams[EVAL_CONTEXT_INDEX].updateDependencies =
+            this.updateDependencies.bind(this);
+        this.compilationParams[EVAL_CONTEXT_INDEX].addDependencies = this.addDependencies.bind(this);
     }
     evaluateCells(positions) {
         const cells = positions.map((p) => this.encoder.encode(p));
         const cellsToCompute = new JetSet(cells);
         const arrayFormulasPositionIds = this.getArrayFormulasImpactedByChangesOf(cells);
-        cellsToCompute.add(...this.getCellsDependingOn(cells));
-        cellsToCompute.add(...arrayFormulasPositionIds);
-        cellsToCompute.add(...this.getCellsDependingOn(arrayFormulasPositionIds));
+        cellsToCompute.addMany(this.getCellsDependingOn(cells));
+        cellsToCompute.addMany(arrayFormulasPositionIds);
+        cellsToCompute.addMany(this.getCellsDependingOn(arrayFormulasPositionIds));
         this.evaluate(cellsToCompute);
     }
     getArrayFormulasImpactedByChangesOf(positionIds) {
@@ -43188,7 +43346,7 @@ class Evaluator {
             }
             if (!content) {
                 // The previous content could have blocked some array formulas
-                impactedPositionIds.add(...this.getArrayFormulasBlockedByOrSpreadingOn(positionId));
+                impactedPositionIds.addMany(this.getArrayFormulasBlockedByOrSpreadingOn(positionId));
             }
         }
         return impactedPositionIds;
@@ -43240,7 +43398,7 @@ class Evaluator {
         }
         const arrayFormulas = this.spreadingRelations.getFormulaPositionsSpreadingOn(positionId);
         const cells = new JetSet(arrayFormulas);
-        cells.add(...this.getCellsDependingOn(arrayFormulas));
+        cells.addMany(this.getCellsDependingOn(arrayFormulas));
         return cells;
     }
     nextPositionsToUpdate = new JetSet();
@@ -43368,7 +43526,7 @@ class Evaluator {
             this.setEvaluatedCell(positionId, evaluatedCell);
             // check if formula dependencies present in the spread zone
             // if so, they need to be recomputed
-            this.nextPositionsToUpdate.add(...this.getCellsDependingOn([positionId]));
+            this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([positionId]));
         };
     }
     invalidateSpreading(positionId) {
@@ -43383,8 +43541,8 @@ class Evaluator {
                 continue;
             }
             this.evaluatedCells.delete(child);
-            this.nextPositionsToUpdate.add(...this.getCellsDependingOn([child]));
-            this.nextPositionsToUpdate.add(...this.getArrayFormulasBlockedByOrSpreadingOn(child));
+            this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([child]));
+            this.nextPositionsToUpdate.addMany(this.getArrayFormulasBlockedByOrSpreadingOn(child));
         }
         this.spreadingRelations.removeNode(positionId);
     }
@@ -43513,15 +43671,15 @@ class PositionBitsEncoder {
     }
 }
 function updateEvalContextAndExecute(compiledFormula, compilationParams, sheetId, cellId) {
-    compilationParams[2].__originCellXC = lazy(() => {
+    compilationParams[EVAL_CONTEXT_INDEX].__originCellXC = lazy(() => {
         if (!cellId) {
             return undefined;
         }
         // compute the value lazily for performance reasons
-        const position = compilationParams[2].getters.getCellPosition(cellId);
+        const position = compilationParams[EVAL_CONTEXT_INDEX].getters.getCellPosition(cellId);
         return toXC(position.col, position.row);
     });
-    compilationParams[2].__originSheetId = sheetId;
+    compilationParams[EVAL_CONTEXT_INDEX].__originSheetId = sheetId;
     return compiledFormula.execute(compiledFormula.dependencies, ...compilationParams);
 }
 
@@ -43851,8 +44009,13 @@ function colorDistance(color1, color2) {
  */
 class CustomColorsPlugin extends UIPlugin {
     customColors = {};
+    configCustomColors;
     shouldUpdateColors = false;
     static getters = ["getCustomColors"];
+    constructor(config) {
+        super(config);
+        this.configCustomColors = config.customColors;
+    }
     handle(cmd) {
         switch (cmd.type) {
             case "UPDATE_CELL":
@@ -43874,7 +44037,7 @@ class CustomColorsPlugin extends UIPlugin {
         }
     }
     getCustomColors() {
-        let usedColors = [];
+        let usedColors = this.configCustomColors;
         for (const sheetId of this.getters.getSheetIds()) {
             usedColors = usedColors.concat(this.getColorsFromCells(sheetId), this.getFormattingColors(sheetId), this.getChartColors(sheetId));
         }
@@ -46847,7 +47010,7 @@ class SheetUIPlugin extends UIPlugin {
         "getCellText",
         "getCellMultiLineText",
         "getContiguousZone",
-        "isCellEmpty",
+        "isEvaluatedCellEmpty",
     ];
     ctx = document.createElement("canvas").getContext("2d");
     // ---------------------------------------------------------------------------
@@ -46975,14 +47138,26 @@ class SheetUIPlugin extends UIPlugin {
         return zone;
     }
     /**
-     * Check if a cell is empty. If the cell is part of a merge,
-     * check if the merge containing the cell is empty.
+     * Checks if a cell evaluated value is empty. If the cell is part of a merge,
+     * the check applies to the main cell of the merge.
      */
-    isCellEmpty(position) {
+    //TODORAR this does not fit the new scheme where a cell with an empty string is not empty anymore
+    // this means the navigation was acually altered with the recent change
+    // remove the getter and put it back in selection processor as nobody uses it
+    isEvaluatedCellEmpty(position) {
         const mainPosition = this.getters.getMainCellPosition(position);
         const cell = this.getters.getEvaluatedCell(mainPosition);
         return cell.type === CellValueType.empty;
     }
+    /**
+     * Checks if a cell is empty (i.e. does not have a content or a formula does not spread over it).
+     * If the cell is part of a merge, the check applies to the main cell of the merge.
+     */
+    isCellEmpty(position) {
+        const mainPosition = this.getters.getMainCellPosition(position);
+        return !(this.getters.getCorrespondingFormulaCell(mainPosition) ||
+            this.getters.getCell(mainPosition)?.content);
+    }
     getColMaxWidth(sheetId, index) {
         const cellsPositions = positions(this.getters.getColsZone(sheetId, index, index));
         const sizes = cellsPositions.map((position) => this.getCellWidth({ sheetId, ...position }));
@@ -51517,7 +51692,7 @@ class FindAndReplacePanel extends owl.Component {
         if (ev.key === "Enter") {
             ev.preventDefault();
             ev.stopPropagation();
-            this.store.selectNextMatch();
+            ev.shiftKey ? this.store.selectPreviousMatch() : this.store.selectNextMatch();
         }
     }
     onKeydownReplace(ev) {
@@ -53213,22 +53388,20 @@ css /* scss */ `
 `;
 class SidePanel extends owl.Component {
     static template = "o-spreadsheet-SidePanel";
-    static props = {
-        component: String,
-        panelProps: { type: Object, optional: true },
-        onCloseSidePanel: Function,
-    };
-    state;
+    static props = {};
+    sidePanelStore;
     setup() {
-        this.state = owl.useState({
-            panel: sidePanelRegistry.get(this.props.component),
-        });
-        owl.onWillUpdateProps((nextProps) => (this.state.panel = sidePanelRegistry.get(nextProps.component)));
+        this.sidePanelStore = useStore(SidePanelStore);
+    }
+    get panel() {
+        return sidePanelRegistry.get(this.sidePanelStore.componentTag);
+    }
+    close() {
+        this.sidePanelStore.close();
     }
     getTitle() {
-        return typeof this.state.panel.title === "function"
-            ? this.state.panel.title(this.env)
-            : this.state.panel.title;
+        const panel = this.panel;
+        return typeof panel.title === "function" ? panel.title(this.env) : panel.title;
     }
 }
 
@@ -54162,10 +54335,13 @@ class Spreadsheet extends owl.Component {
     }
     setup() {
         const stores = useStoreProvider();
-        this.sidePanel = owl.useState({ isOpen: false, panelProps: {} });
+        stores.inject(ModelStore, this.model);
+        this.notificationStore = useStore(NotificationStore);
+        this.composerFocusStore = useStore(ComposerFocusStore);
+        this.sidePanel = useStore(SidePanelStore);
         this.keyDownMapping = {
-            "CTRL+H": () => this.toggleSidePanel("FindAndReplace", {}),
-            "CTRL+F": () => this.toggleSidePanel("FindAndReplace", {}),
+            "CTRL+H": () => this.sidePanel.toggle("FindAndReplace", {}),
+            "CTRL+F": () => this.sidePanel.toggle("FindAndReplace", {}),
         };
         const fileStore = this.model.config.external.fileStore;
         owl.useSubEnv({
@@ -54174,11 +54350,10 @@ class Spreadsheet extends owl.Component {
             loadCurrencies: this.model.config.external.loadCurrencies,
             loadLocales: this.model.config.external.loadLocales,
             isDashboard: () => this.model.getters.isDashboard(),
-            openSidePanel: this.openSidePanel.bind(this),
-            toggleSidePanel: this.toggleSidePanel.bind(this),
+            openSidePanel: this.sidePanel.open.bind(this.sidePanel),
+            toggleSidePanel: this.sidePanel.toggle.bind(this.sidePanel),
             clipboard: this.env.clipboard || instantiateClipboard(),
             startCellEdition: (content) => this.composerFocusStore.focusGridComposerCell(content),
-            //TODORAR: make a store out of this
         });
         owl.useEffect(() => {
             /**
@@ -54207,9 +54382,6 @@ class Spreadsheet extends owl.Component {
         owl.onPatched(() => {
             this.checkViewportSize();
         });
-        stores.inject(ModelStore, this.model);
-        this.notificationStore = useStore(NotificationStore);
-        this.composerFocusStore = useStore(ComposerFocusStore);
     }
     bindModelEvents() {
         this.model.on("update", this, () => this.render(true));
@@ -54242,28 +54414,6 @@ class Spreadsheet extends owl.Component {
             this.isViewportTooSmall = false;
         }
     }
-    openSidePanel(panel, panelProps) {
-        if (this.sidePanel.isOpen && panel !== this.sidePanel.component) {
-            this.sidePanel.panelProps?.onCloseSidePanel?.();
-        }
-        this.sidePanel.component = panel;
-        this.sidePanel.panelProps = panelProps;
-        this.sidePanel.isOpen = true;
-    }
-    closeSidePanel() {
-        this.sidePanel.isOpen = false;
-        this.focusGrid();
-        this.sidePanel.panelProps?.onCloseSidePanel?.();
-    }
-    toggleSidePanel(panel, panelProps) {
-        if (this.sidePanel.isOpen && panel === this.sidePanel.component) {
-            this.sidePanel.isOpen = false;
-            this.focusGrid();
-        }
-        else {
-            this.openSidePanel(panel, panelProps);
-        }
-    }
     focusGrid() {
         if (!this._focusGrid) {
             return;
@@ -55692,8 +55842,8 @@ class SelectionStreamProcessorImpl {
         let currentPosition = startPosition;
         // If both the current cell and the next cell are not empty, we want to go to the end of the cluster
         const nextCellPosition = this.getNextCellPosition(startPosition, dim, dir);
-        let mode = !this.getters.isCellEmpty({ ...currentPosition, sheetId }) &&
-            !this.getters.isCellEmpty({ ...nextCellPosition, sheetId })
+        let mode = !this.isCellSkippableInCluster({ ...currentPosition, sheetId }) &&
+            !this.isCellSkippableInCluster({ ...nextCellPosition, sheetId })
             ? "endOfCluster"
             : "nextCluster";
         while (true) {
@@ -55703,7 +55853,7 @@ class SelectionStreamProcessorImpl {
                 currentPosition.row === nextCellPosition.row) {
                 break;
             }
-            const isNextCellEmpty = this.getters.isCellEmpty({ ...nextCellPosition, sheetId });
+            const isNextCellEmpty = this.isCellSkippableInCluster({ ...nextCellPosition, sheetId });
             if (mode === "endOfCluster" && isNextCellEmpty) {
                 break;
             }
@@ -55734,6 +55884,11 @@ class SelectionStreamProcessorImpl {
     getPosition() {
         return { ...this.anchor.cell };
     }
+    isCellSkippableInCluster(position) {
+        const mainPosition = this.getters.getMainCellPosition(position);
+        const cell = this.getters.getEvaluatedCell(mainPosition);
+        return (cell.type === CellValueType.empty || (cell.type === CellValueType.text && cell.value === ""));
+    }
 }
 
 class StateObserver {
@@ -57600,6 +57755,7 @@ class Model extends EventBus {
             snapshotRequested: false,
             notifyUI: (payload) => this.trigger("notify-ui", payload),
             raiseBlockingErrorUI: (text) => this.trigger("raise-error-ui", { text }),
+            customColors: config.customColors || [],
         };
     }
     setupExternalConfig(external) {
@@ -57631,6 +57787,7 @@ class Model extends EventBus {
             uiActions: this.config,
             session: this.session,
             defaultCurrencyFormat: this.config.defaultCurrencyFormat,
+            customColors: this.config.customColors || [],
         };
     }
     // ---------------------------------------------------------------------------
@@ -57930,6 +58087,10 @@ const helpers = {
     deepEquals,
     overlap,
     union,
+    isInside,
+    deepCopy,
+    expandZoneOnInsertion,
+    reduceZoneOnDeletion,
 };
 const links = {
     isMarkdownLink,
@@ -57984,6 +58145,9 @@ const stores = {
     RendererStore,
     SelectionInputStore,
     SpreadsheetStore,
+    useStore,
+    useLocalStore,
+    SidePanelStore,
 };
 function addFunction(functionName, functionDescription) {
     functionRegistry.add(functionName, functionDescription);
@@ -57996,7 +58160,9 @@ const constants = {
     SECONDARY_COLOR,
 };
 
+exports.AbstractCellClipboardHandler = AbstractCellClipboardHandler;
 exports.AbstractChart = AbstractChart;
+exports.AbstractFigureClipboardHandler = AbstractFigureClipboardHandler;
 exports.CellErrorType = CellErrorType;
 exports.CorePlugin = CorePlugin;
 exports.DispatchResult = DispatchResult;
@@ -58036,6 +58202,6 @@ exports.stores = stores;
 exports.tokenize = tokenize;
 
 
-__info__.version = "17.2.0-alpha.4";
-__info__.date = "2024-02-09T13:10:23.460Z";
-__info__.hash = "1b33cf4";
+__info__.version = "17.2.0-alpha.5";
+__info__.date = "2024-02-16T14:27:52.323Z";
+__info__.hash = "0c69dd8";