@odoo/o-spreadsheet 17.1.5 → 17.1.7

package/dist/o-spreadsheet.esm.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.1.5
- * @date 2024-02-16T14:23:54.651Z
- * @hash 29d8ad6
+ * @version 17.1.7
+ * @date 2024-03-12T07:56:10.783Z
+ * @hash 3a9f334
  */
 
 import { Component, useRef, onMounted, useEffect, onWillPatch, useState, onWillUpdateProps, onPatched, useComponent, useExternalListener, onWillUnmount, onWillStart, xml, useChildSubEnv, useSubEnv, markRaw } from '@odoo/owl';
@@ -6098,8 +6098,10 @@ function getGroup(cell, cells, filter) {
         if (x === cell) {
             found = true;
         }
-        const cellValue = evaluateLiteral(x?.content, { locale: DEFAULT_LOCALE });
-        if (filter(cellValue)) {
+        const cellValue = x?.isFormula
+            ? undefined
+            : evaluateLiteral(x?.content, { locale: DEFAULT_LOCALE });
+        if (cellValue && filter(cellValue)) {
             group.push(cellValue);
         }
         else {
@@ -6323,11 +6325,14 @@ function cellTextStyleToCss(style) {
  * Transform CSS properties into a CSS string.
  */
 function cssPropertiesToCss(attributes) {
-    const str = Object.entries(attributes)
-        .filter(([attName, attValue]) => attValue !== undefined)
-        .map(([attName, attValue]) => `${attName}:${attValue};`)
-        .join(" ");
-    return str;
+    let styleStr = "";
+    for (const attName in attributes) {
+        if (!attributes[attName]) {
+            continue;
+        }
+        styleStr += `${attName}:${attributes[attName]}; `;
+    }
+    return styleStr;
 }
 function getElementMargins(el) {
     const style = window.getComputedStyle(el);
@@ -13051,6 +13056,18 @@ const TRUNC = {
     },
     isExported: true,
 };
+// -----------------------------------------------------------------------------
+// INT
+// -----------------------------------------------------------------------------
+const INT = {
+    description: _t("Rounds a number down to the nearest integer that is less than or equal to it."),
+    args: [arg("value (number)", _t("The number to round down to the nearest integer."))],
+    returns: ["NUMBER"],
+    compute: function (value) {
+        return Math.floor(toNumber(value, this.locale));
+    },
+    isExported: true,
+};
 
 var math = /*#__PURE__*/Object.freeze({
   __proto__: null,
@@ -13084,6 +13101,7 @@ var math = /*#__PURE__*/Object.freeze({
   FLOOR: FLOOR,
   FLOOR_MATH: FLOOR_MATH,
   FLOOR_PRECISE: FLOOR_PRECISE,
+  INT: INT,
   ISEVEN: ISEVEN,
   ISODD: ISODD,
   ISO_CEILING: ISO_CEILING,
@@ -18610,10 +18628,11 @@ const DEFAULT_IS_SORTED = true;
 const DEFAULT_MATCH_MODE = 0;
 const DEFAULT_SEARCH_MODE = 1;
 const DEFAULT_ABSOLUTE_RELATIVE_MODE = 1;
-function assertAvailable(variable, searchKey) {
-    if (variable === undefined) {
-        throw new NotAvailableError(_t("Did not find value '%s' in [[FUNCTION_NAME]] evaluation.", toString(searchKey)));
-    }
+function valueNotAvailable(searchKey) {
+    return {
+        value: CellErrorType.NotAvailable,
+        message: _t("Did not find value '%s' in [[FUNCTION_NAME]] evaluation.", toString(searchKey)),
+    };
 }
 // -----------------------------------------------------------------------------
 // ADDRESS
@@ -18710,7 +18729,9 @@ const HLOOKUP = {
             ? dichotomicSearch(range, searchKey, "nextSmaller", "asc", range.length, getValueFromRange)
             : linearSearch(range, searchKey, "strict", range.length, getValueFromRange);
         const col = range[colIndex];
-        assertAvailable(col, searchKey?.value);
+        if (col === undefined) {
+            return valueNotAvailable(searchKey);
+        }
         return col[_index - 1];
     },
     isExported: true,
@@ -18767,11 +18788,11 @@ const LOOKUP = {
             : (range, index) => range[index][0].value;
         const rangeLength = verticalSearch ? nbRow : nbCol;
         const index = dichotomicSearch(searchArray, searchKey, "nextSmaller", "asc", rangeLength, getElement);
-        if (index === -1)
-            assertAvailable(undefined, searchKey?.value);
-        verticalSearch
-            ? assertAvailable(searchArray[0][index], searchKey?.value)
-            : assertAvailable(searchArray[index][nbRow - 1], searchKey?.value);
+        if (index === -1 ||
+            (verticalSearch && searchArray[0][index] === undefined) ||
+            (!verticalSearch && searchArray[index][nbRow - 1] === undefined)) {
+            return valueNotAvailable(searchKey);
+        }
         if (resultRange === undefined) {
             return verticalSearch ? searchArray[nbCol - 1][index] : searchArray[index][nbRow - 1];
         }
@@ -18821,7 +18842,10 @@ const MATCH = {
                 index = dichotomicSearch(range, searchKey, "nextGreater", "desc", rangeLen, getElement);
                 break;
         }
-        assertAvailable(nbCol === 1 ? range[0][index] : range[index], searchKey);
+        if ((nbCol === 1 && range[0][index] === undefined) ||
+            (nbCol !== 1 && range[index] === undefined)) {
+            return valueNotAvailable(searchKey);
+        }
         return index + 1;
     },
     isExported: true,
@@ -18880,7 +18904,9 @@ const VLOOKUP = {
             ? dichotomicSearch(range, searchKey, "nextSmaller", "asc", range[0].length, getValueFromRange)
             : linearSearch(range, searchKey, "strict", range[0].length, getValueFromRange);
         const value = range[_index - 1][rowIndex];
-        assertAvailable(value, searchKey);
+        if (value === undefined) {
+            return valueNotAvailable(searchKey);
+        }
         return value;
     },
     isExported: true,
@@ -18930,7 +18956,9 @@ const XLOOKUP = {
                 ? returnRange.map((col) => [col[index]])
                 : [returnRange[index]];
         }
-        assertAvailable(defaultValue, searchKey);
+        if (defaultValue === undefined) {
+            return valueNotAvailable(searchKey);
+        }
         return [[defaultValue]];
     },
     isExported: true,
@@ -19702,8 +19730,7 @@ class FunctionRegistry extends Registry {
 function addErrorHandling(compute, functionName) {
     return function (...args) {
         try {
-            const computeFormula = compute.bind(this);
-            return computeFormula(...args);
+            return compute.apply(this, args);
         }
         catch (e) {
             return handleError(e, functionName);
@@ -19737,8 +19764,7 @@ function hasStringMessage(obj) {
 }
 function addResultHandling(compute) {
     return function (...args) {
-        const computeResult = compute.bind(this);
-        const result = computeResult(...args);
+        const result = compute.apply(this, args);
         if (!isMatrix(result)) {
             if (typeof result === "object" && result !== null && "value" in result) {
                 return result;
@@ -21705,7 +21731,7 @@ class SelectionInput extends Component {
             ? existingSelectionRanges
             : this.props.ranges().map((xc, id) => ({
                 xc,
-                id,
+                id: id + 1,
                 isFocused: false,
             }));
         return ranges.map((range) => ({
@@ -27745,7 +27771,11 @@ class GridComposer extends Component {
         }
     }
     updateCellReferenceVisibility() {
-        if (this.isCellReferenceVisible || this.env.model.getters.getEditionMode() === "inactive") {
+        if (this.env.model.getters.getEditionMode() === "inactive") {
+            this.isCellReferenceVisible = false;
+            return;
+        }
+        if (this.isCellReferenceVisible) {
             return;
         }
         const sheetId = this.env.model.getters.getActiveSheetId();
@@ -27774,19 +27804,21 @@ class GridCellIcon extends Component {
         slots: Object,
     };
     get iconStyle() {
-        const x = this.getIconHorizontalPosition();
-        const y = this.getIconVerticalPosition();
+        const cellPosition = this.props.cellPosition;
+        const merge = this.env.model.getters.getMerge(cellPosition);
+        const zone = merge || positionToZone(cellPosition);
+        const rect = this.env.model.getters.getVisibleRectWithoutHeaders(zone);
+        const x = this.getIconHorizontalPosition(rect, cellPosition);
+        const y = this.getIconVerticalPosition(rect, cellPosition);
         return cssPropertiesToCss({
             top: `${y + (this.props.offset?.y || 0)}px`,
             left: `${x + (this.props.offset?.x || 0)}px`,
         });
     }
-    getIconVerticalPosition() {
-        const { sheetId, row } = this.props.cellPosition;
-        const merge = this.env.model.getters.getMerge(this.props.cellPosition);
-        const start = this.env.model.getters.getRowDimensionsInViewport(sheetId, row).start;
-        const end = this.env.model.getters.getRowDimensionsInViewport(sheetId, merge ? merge.bottom : row).end;
-        const cell = this.env.model.getters.getCell(this.props.cellPosition);
+    getIconVerticalPosition(rect, cellPosition) {
+        const start = rect.y;
+        const end = rect.y + rect.height;
+        const cell = this.env.model.getters.getCell(cellPosition);
         const align = this.props.verticalAlign || cell?.style?.verticalAlign || DEFAULT_VERTICAL_ALIGN;
         switch (align) {
             case "bottom":
@@ -27798,13 +27830,11 @@ class GridCellIcon extends Component {
                 return end - GRID_ICON_EDGE_LENGTH - centeringOffset;
         }
     }
-    getIconHorizontalPosition() {
-        const { sheetId, col } = this.props.cellPosition;
-        const merge = this.env.model.getters.getMerge(this.props.cellPosition);
-        const start = this.env.model.getters.getColDimensionsInViewport(sheetId, col).start;
-        const end = this.env.model.getters.getColDimensionsInViewport(sheetId, merge ? merge.right : col).end;
-        const cell = this.env.model.getters.getCell(this.props.cellPosition);
-        const evaluatedCell = this.env.model.getters.getEvaluatedCell(this.props.cellPosition);
+    getIconHorizontalPosition(rect, cellPosition) {
+        const start = rect.x;
+        const end = rect.x + rect.width;
+        const cell = this.env.model.getters.getCell(cellPosition);
+        const evaluatedCell = this.env.model.getters.getEvaluatedCell(cellPosition);
         const align = this.props.horizontalAlign || cell?.style?.align || evaluatedCell.defaultAlign;
         switch (align) {
             case "right":
@@ -27888,6 +27918,8 @@ css /* scss */ `
     height: ${CHECKBOX_WIDTH}px;
     accent-color: #808080;
     margin: ${MARGIN}px;
+    /** required to prevent the checkbox position to be sensible to the font-size (affects Firefox) */
+    position: absolute;
   }
 `;
 class DataValidationCheckbox extends Component {
@@ -27906,7 +27938,7 @@ class DataValidationCheckbox extends Component {
     }
     get isDisabled() {
         const cell = this.env.model.getters.getCell(this.props.cellPosition);
-        return !!cell?.isFormula;
+        return this.env.model.getters.isReadonly() || !!cell?.isFormula;
     }
 }
 
@@ -27946,12 +27978,17 @@ class DataValidationOverlay extends Component {
     static props = {};
     static components = { GridCellIcon, DataValidationCheckbox, DataValidationListIcon };
     get checkBoxCellPositions() {
-        return this.env.model.getters.getDataValidationCheckBoxCellPositions();
+        return this.env.model.getters
+            .getVisibleCellPositions()
+            .filter(this.env.model.getters.isCellValidCheckbox);
     }
     get listIconsCellPositions() {
-        return this.env.model.getters.isReadonly()
-            ? []
-            : this.env.model.getters.getDataValidationListCellsPositions();
+        if (this.env.model.getters.isReadonly()) {
+            return [];
+        }
+        return this.env.model.getters
+            .getVisibleCellPositions()
+            .filter(this.env.model.getters.cellHasListDataValidationIcon);
     }
 }
 
@@ -34313,29 +34350,12 @@ const MIGRATIONS = [
         from: 12,
         to: 12.5,
         applyMigration(data) {
-            for (let sheet of data.sheets || []) {
-                let knownDataFilterZones = [];
-                for (let filterTable of sheet.filterTables || []) {
-                    const zone = toZone(filterTable.range);
-                    // See commit message for the details
-                    const intersectZoneIndex = knownDataFilterZones.findIndex((knownZone) => overlap(knownZone, zone));
-                    if (intersectZoneIndex !== -1) {
-                        knownDataFilterZones[intersectZoneIndex] = zone;
-                    }
-                    else {
-                        knownDataFilterZones.push(zone);
-                    }
-                }
-                sheet.filterTables = knownDataFilterZones.map((zone) => ({
-                    range: zoneToXc(zone),
-                }));
-            }
-            return data;
+            return fixOverlappingFilters(data);
         },
     },
     {
         description: "Change Border description structure",
-        from: 12,
+        from: 12.5,
         to: 13,
         applyMigration(data) {
             for (const borderId in data.borders) {
@@ -34366,6 +34386,14 @@ const MIGRATIONS = [
             return data;
         },
     },
+    {
+        description: "Fix datafilter duplication (post saas-16.4)",
+        from: 14,
+        to: 14.5,
+        applyMigration(data) {
+            return fixOverlappingFilters(data);
+        },
+    },
 ];
 /**
  * This function is used to repair faulty data independently of the migration.
@@ -34523,6 +34551,26 @@ function fixChartDefinitions(data, initialMessages) {
     }
     return messages;
 }
+function fixOverlappingFilters(data) {
+    for (let sheet of data.sheets || []) {
+        let knownDataFilterZones = [];
+        for (let filterTable of sheet.filterTables || []) {
+            const zone = toZone(filterTable.range);
+            // See commit message of https://github.com/odoo/o-spreadsheet/pull/3632 of more details
+            const intersectZoneIndex = knownDataFilterZones.findIndex((knownZone) => overlap(knownZone, zone));
+            if (intersectZoneIndex !== -1) {
+                knownDataFilterZones[intersectZoneIndex] = zone;
+            }
+            else {
+                knownDataFilterZones.push(zone);
+            }
+        }
+        sheet.filterTables = knownDataFilterZones.map((zone) => ({
+            range: zoneToXc(zone),
+        }));
+    }
+    return data;
+}
 // -----------------------------------------------------------------------------
 // Helpers
 // -----------------------------------------------------------------------------
@@ -39044,7 +39092,6 @@ class SheetPlugin extends CorePlugin {
         "getNumberHeaders",
         "getGridLinesVisibility",
         "getNextSheetName",
-        "isEmpty",
         "getSheetSize",
         "getSheetZone",
         "getPaneDivisions",
@@ -39419,14 +39466,6 @@ class SheetPlugin extends CorePlugin {
     // ---------------------------------------------------------------------------
     // Row/Col manipulation
     // ---------------------------------------------------------------------------
-    /**
-     * Check if a zone only contains empty cells
-     */
-    isEmpty(sheetId, zone) {
-        return positions(zone)
-            .map(({ col, row }) => this.getCell({ sheetId, col, row }))
-            .every((cell) => !cell || cell.content === "");
-    }
     getCommandZones(cmd) {
         const zones = [];
         if ("zone" in cmd) {
@@ -41541,7 +41580,7 @@ class Evaluator {
                 : evaluateLiteral(cell.content, localeFormat);
         }
         catch (e) {
-            return createEvaluatedCell(e.value, localeFormat, e.message);
+            return createEvaluatedCell(e?.value || CellErrorType.GenericError, localeFormat, e?.message || implementationErrorMessage);
         }
         finally {
             this.cellsBeingComputed.delete(cellId);
@@ -41875,6 +41914,7 @@ class EvaluationPlugin extends UIPlugin {
         "getEvaluatedCellsInZone",
         "getSpreadPositionsOf",
         "getArrayFormulaSpreadingOn",
+        "isEmpty",
     ];
     shouldRebuildDependenciesGraph = true;
     evaluator;
@@ -41980,6 +42020,14 @@ class EvaluationPlugin extends UIPlugin {
     getArrayFormulaSpreadingOn(position) {
         return this.evaluator.getArrayFormulaSpreadingOn(position);
     }
+    /**
+     * Check if a zone only contains empty cells
+     */
+    isEmpty(sheetId, zone) {
+        return positions(zone)
+            .map(({ col, row }) => this.getEvaluatedCell({ sheetId, col, row }))
+            .every((cell) => cell.type === CellValueType.empty);
+    }
     // ---------------------------------------------------------------------------
     // Export
     // ---------------------------------------------------------------------------
@@ -42627,8 +42675,6 @@ const VALID_RESULT = { isValid: true };
 class EvaluationDataValidationPlugin extends UIPlugin {
     static getters = [
         "getDataValidationInvalidCriterionValueMessage",
-        "getDataValidationCheckBoxCellPositions",
-        "getDataValidationListCellsPositions",
         "getInvalidDataValidationMessage",
         "getValidationResultForCellValue",
         "isCellValidCheckbox",
@@ -42692,19 +42738,6 @@ class EvaluationDataValidationPlugin extends UIPlugin {
         const error = this.getRuleErrorForCellValue(cellValue, cellPosition, rule);
         return error ? { error, rule, isValid: false } : VALID_RESULT;
     }
-    getDataValidationCheckBoxCellPositions() {
-        const rules = this.getters
-            .getDataValidationRules(this.getters.getActiveSheetId())
-            .filter((rule) => rule.criterion.type === "isBoolean");
-        return getCellPositionsInRanges(rules.map((rule) => rule.ranges).flat()).filter((position) => this.isCellValidCheckbox(position));
-    }
-    getDataValidationListCellsPositions() {
-        const rules = this.getters
-            .getDataValidationRules(this.getters.getActiveSheetId())
-            .filter((rule) => (rule.criterion.type === "isValueInList" || rule.criterion.type === "isValueInRange") &&
-            rule.criterion.displayStyle === "arrow");
-        return getCellPositionsInRanges(rules.map((rule) => rule.ranges).flat());
-    }
     getValidationResultForCell(cellPosition) {
         const { col, row, sheetId } = cellPosition;
         if (!this.validationResults[sheetId]) {
@@ -45673,6 +45706,8 @@ class FindAndReplacePlugin extends UIPlugin {
                 sheetIdFrom: this.getters.getActiveSheetId(),
                 sheetIdTo: selectedMatch.sheetId,
             });
+            // We do not want to reset the selection at finalize in this case
+            this.isSearchDirty = false;
         }
         // we want grid selection to capture the selection stream
         this.selection.getBackToDefault();
@@ -46974,19 +47009,17 @@ class SelectionInputsManagerPlugin extends UIPlugin {
                 break;
             case "FOCUS_RANGE":
             case "CHANGE_RANGE":
-                if (cmd.id !== this.focusedInputId) {
-                    const input = this.inputs[cmd.id];
-                    const range = input.ranges.find((range) => range.id === cmd.rangeId);
-                    if (this.isRangeValid(range?.xc || "A1")) {
-                        const sheetId = this.getters.getActiveSheetId();
-                        const zone = this.getters.getRangeFromSheetXC(sheetId, range?.xc || "A1").zone;
-                        this.selection.capture(input, { cell: { col: zone.left, row: zone.top }, zone }, {
-                            handleEvent: input.handleEvent.bind(input),
-                            release: () => (this.focusedInputId = null),
-                        });
-                    }
-                    this.focusedInputId = cmd.id;
+                const input = this.inputs[cmd.id];
+                const range = input.ranges.find((range) => range.id === cmd.rangeId);
+                if (range) {
+                    const sheetId = this.getters.getActiveSheetId();
+                    const zone = this.getters.getRangeFromSheetXC(sheetId, range?.xc || "A1").zone;
+                    this.selection.capture(input, { cell: { col: zone.left, row: zone.top }, zone }, {
+                        handleEvent: input.handleEvent.bind(input),
+                        release: () => (this.focusedInputId = null),
+                    });
                 }
+                this.focusedInputId = cmd.id;
                 break;
         }
         this.currentInput?.handle(cmd);
@@ -50405,6 +50438,8 @@ class SheetViewPlugin extends UIPlugin {
         "getEdgeScrollRow",
         "getVisibleFigures",
         "getVisibleRect",
+        "getVisibleRectWithoutHeaders",
+        "getVisibleCellPositions",
         "getColRowOffsetInViewport",
         "getMainViewportCoordinates",
         "getActiveSheetScrollInfo",
@@ -50648,6 +50683,26 @@ class SheetViewPlugin extends UIPlugin {
         const viewports = this.getSubViewports(sheetId);
         return [...new Set(viewports.map((v) => range(v.top, v.bottom + 1)).flat())].filter((row) => !this.getters.isHeaderHidden(sheetId, "ROW", row));
     }
+    /**
+     * Get the positions of all the cells that are visible in the viewport, taking merges into account.
+     */
+    getVisibleCellPositions() {
+        const visibleCols = this.getSheetViewVisibleCols();
+        const visibleRows = this.getSheetViewVisibleRows();
+        const sheetId = this.getters.getActiveSheetId();
+        const positions = [];
+        for (const col of visibleCols) {
+            for (const row of visibleRows) {
+                const position = { sheetId, col, row };
+                const mainPosition = this.getters.getMainCellPosition(position);
+                if (mainPosition.row !== row || mainPosition.col !== col) {
+                    continue;
+                }
+                positions.push(position);
+            }
+        }
+        return positions;
+    }
     /**
      * Return the main viewport maximum size relative to the client size.
      */
@@ -50767,6 +50822,13 @@ class SheetViewPlugin extends UIPlugin {
      * Computes the coordinates and size to draw the zone on the canvas
      */
     getVisibleRect(zone) {
+        const rect = this.getVisibleRectWithoutHeaders(zone);
+        return { ...rect, x: rect.x + this.gridOffsetX, y: rect.y + this.gridOffsetY };
+    }
+    /**
+     * Computes the coordinates and size to draw the zone without taking the grid offset into account
+     */
+    getVisibleRectWithoutHeaders(zone) {
         const sheetId = this.getters.getActiveSheetId();
         const viewportRects = this.getSubViewports(sheetId)
             .map((viewport) => viewport.getRect(zone))
@@ -50778,12 +50840,7 @@ class SheetViewPlugin extends UIPlugin {
         const y = Math.min(...viewportRects.map((rect) => rect.y));
         const width = Math.max(...viewportRects.map((rect) => rect.x + rect.width)) - x;
         const height = Math.max(...viewportRects.map((rect) => rect.y + rect.height)) - y;
-        return {
-            x: x + this.gridOffsetX,
-            y: y + this.gridOffsetY,
-            width,
-            height,
-        };
+        return { x, y, width, height };
     }
     /**
      * Returns the position of the MainViewport relatively to the start of the grid (without headers)
@@ -51007,13 +51064,8 @@ class HeaderPositionsUIPlugin extends UIPlugin {
                 }
                 break;
             case "UPDATE_CELL":
-                if ("content" in cmd || "format" in cmd) {
-                    this.headerPositions = {};
-                    this.isDirty = true;
-                }
-                else {
-                    this.headerPositions[cmd.sheetId] = this.computeHeaderPositionsOfSheet(cmd.sheetId);
-                }
+                this.headerPositions = {};
+                this.isDirty = true;
                 break;
             case "UPDATE_FILTER":
             case "REMOVE_FILTER_TABLE":
@@ -57186,6 +57238,6 @@ const constants = {
 export { AbstractChart, CellErrorType, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, UIPlugin, __info__, addFunction, astToFormula, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, tokenize };
 
 
-__info__.version = "17.1.5";
-__info__.date = "2024-02-16T14:23:54.651Z";
-__info__.hash = "29d8ad6";
+__info__.version = "17.1.7";
+__info__.date = "2024-03-12T07:56:10.783Z";
+__info__.hash = "3a9f334";