@odoo/o-spreadsheet 17.1.4 → 17.1.5

package/dist/o-spreadsheet.iife.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.1.4
- * @date 2024-02-09T13:09:13.430Z
- * @hash 16d3ece
+ * @version 17.1.5
+ * @date 2024-02-16T14:23:54.651Z
+ * @hash 29d8ad6
  */
 
 (function (exports, owl) {
@@ -452,8 +452,8 @@
    * If the given item does not exist in the dictionary, it creates one with a new id.
    */
   function getItemId(item, itemsDic) {
-      for (let [key, value] of Object.entries(itemsDic)) {
-          if (deepEquals(value, item)) {
+      for (const key in itemsDic) {
+          if (deepEquals(itemsDic[key], item)) {
               return parseInt(key, 10);
           }
       }
@@ -552,11 +552,13 @@
       if (typeof o1 !== "object")
           return o1 === o2;
       // Objects can have different keys if the values are undefined
-      const keys = new Set();
-      Object.keys(o1).forEach((key) => keys.add(key));
-      Object.keys(o2).forEach((key) => keys.add(key));
-      for (let key of keys) {
-          if (typeof o1[key] !== typeof o1[key])
+      for (const key in o2) {
+          if (!(key in o1) && o2[key] !== undefined) {
+              return false;
+          }
+      }
+      for (const key in o1) {
+          if (typeof o1[key] !== typeof o2[key])
               return false;
           if (typeof o1[key] === "object") {
               if (!deepEquals(o1[key], o2[key]))
@@ -626,18 +628,18 @@
       return true;
   }
   class JetSet extends Set {
-      add(...iterable) {
+      addMany(iterable) {
           for (const element of iterable) {
               super.add(element);
           }
           return this;
       }
-      delete(...iterable) {
-          let deleted = false;
+      deleteMany(iterable) {
+          let wasDeleted = false;
           for (const element of iterable) {
-              deleted ||= super.delete(element);
+              wasDeleted ||= super.delete(element);
           }
-          return deleted;
+          return wasDeleted;
       }
   }
   /**
@@ -1935,7 +1937,7 @@
        * Static helper which returns a successful DispatchResult
        */
       static get Success() {
-          return new DispatchResult();
+          return SUCCESS;
       }
       get isSuccessful() {
           return this.reasons.length === 0;
@@ -1948,6 +1950,7 @@
           return this.reasons.includes(reason);
       }
   }
+  const SUCCESS = new DispatchResult();
   exports.CommandResult = void 0;
   (function (CommandResult) {
       CommandResult["Success"] = "Success";
@@ -7654,6 +7657,9 @@
       if (locale.formulaArgSeparator === locale.decimalSeparator) {
           return false;
       }
+      if (locale.thousandsSeparator === locale.decimalSeparator) {
+          return false;
+      }
       try {
           formatValue(1, { locale, format: "#,##0.00" });
           formatValue(1, { locale, format: locale.dateFormat });
@@ -7744,7 +7750,7 @@
       if (locale.decimalSeparator === "." || !isNumber(content, locale)) {
           return content;
       }
-      return content.replace(locale.decimalSeparator, ".");
+      return content.replace(locale.thousandsSeparator, "").replace(locale.decimalSeparator, ".");
   }
   /**
    * Change a content string from the given locale to its canonical form (en_US locale). Also convert date string.
@@ -10839,6 +10845,12 @@
       let { col, row } = env.model.getters.getActivePosition();
       env.model.dispatch("OPEN_CELL_POPOVER", { col, row, popoverType: "LinkEditor" });
   };
+  const INSERT_LINK_NAME = (env) => {
+      const sheetId = env.model.getters.getActiveSheetId();
+      const { col, row } = env.model.getters.getActivePosition();
+      const cell = env.model.getters.getEvaluatedCell({ sheetId, col, row });
+      return cell && cell.link ? _t("Edit link") : _t("Insert link");
+  };
   //------------------------------------------------------------------------------
   // Filters action
   //------------------------------------------------------------------------------
@@ -20083,7 +20095,7 @@
   })
       .add("insert_link", {
       ...insertLink,
-      name: _t("Insert link"),
+      name: INSERT_LINK_NAME,
       sequence: 150,
       separator: true,
   });
@@ -26526,6 +26538,17 @@
           onValueSelected: Function,
           onValueHovered: Function,
       };
+      autoCompleteListRef = owl.useRef("autoCompleteList");
+      setup() {
+          owl.useEffect(() => {
+              const selectedIndex = this.props.selectedIndex;
+              if (selectedIndex === undefined) {
+                  return;
+              }
+              const selectedElement = this.autoCompleteListRef.el?.children[selectedIndex];
+              selectedElement?.scrollIntoView?.({ block: "nearest" });
+          }, () => [this.props.selectedIndex, this.autoCompleteListRef.el]);
+      }
   }
 
   class ContentEditableHelper {
@@ -26970,6 +26993,7 @@
       position: absolute;
       margin: 1px 4px;
       pointer-events: none;
+      overflow: auto;
 
       .o-semi-bold {
         /** FIXME: to remove in favor of Bootstrap
@@ -27027,7 +27051,10 @@
           if (this.props.delimitation && this.props.rect) {
               const { x: cellX, y: cellY, height: cellHeight } = this.props.rect;
               const remainingHeight = this.props.delimitation.height - (cellY + cellHeight);
+              assistantStyle["max-height"] = `${remainingHeight}px`;
               if (cellY > remainingHeight) {
+                  const availableSpaceAbove = cellY;
+                  assistantStyle["max-height"] = `${availableSpaceAbove}px`;
                   // render top
                   // We compensate 2 px of margin on the assistant style + 1px for design reasons
                   assistantStyle.top = `-3px`;
@@ -35146,22 +35173,7 @@
           }
       }
       export(data) {
-          // Borders
-          let borderId = 0;
           const borders = {};
-          /**
-           * Get the id of the given border. If the border does not exist, it creates
-           * one.
-           */
-          function getBorderId(border) {
-              for (let [key, value] of Object.entries(borders)) {
-                  if (deepEquals(value, border)) {
-                      return parseInt(key, 10);
-                  }
-              }
-              borders[++borderId] = border;
-              return borderId;
-          }
           for (let sheet of data.sheets) {
               for (let col = 0; col < sheet.colNumber; col++) {
                   for (let row = 0; row < sheet.rowNumber; row++) {
@@ -35169,7 +35181,7 @@
                       if (border) {
                           const xc = toXC(col, row);
                           const cell = sheet.cells[xc];
-                          const borderId = getBorderId(border);
+                          const borderId = getItemId(border, borders);
                           if (cell) {
                               cell.border = borderId;
                           }
@@ -35958,9 +35970,9 @@
       allowDispatch(cmd) {
           switch (cmd.type) {
               case "UPDATE_CELL":
-                  return this.checkCellOutOfSheet(cmd);
+                  return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
               case "CLEAR_CELL":
-                  return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                  return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
               default:
                   return "Success" /* CommandResult.Success */;
           }
@@ -36110,8 +36122,8 @@
       }
       removeDefaultStyleValues(style) {
           const cleanedStyle = { ...style };
-          for (const [property, defaultValue] of Object.entries(DEFAULT_STYLE)) {
-              if (cleanedStyle[property] === defaultValue) {
+          for (const property in DEFAULT_STYLE) {
+              if (cleanedStyle[property] === DEFAULT_STYLE[property]) {
                   delete cleanedStyle[property];
               }
           }
@@ -36267,10 +36279,7 @@
           else {
               style = before ? before.style : undefined;
           }
-          const locale = this.getters.getLocale();
-          let format = ("format" in after ? after.format : before && before.format) ||
-              detectDateFormat(afterContent, locale) ||
-              detectNumberFormat(afterContent);
+          const format = "format" in after ? after.format : before && before.format;
           /* Read the following IF as:
            * we need to remove the cell if it is completely empty, but we can know if it completely empty if:
            * - the command says the new content is empty and has no border/format/style
@@ -36311,6 +36320,7 @@
       }
       createLiteralCell(id, content, format, style) {
           const locale = this.getters.getLocale();
+          format = format || detectDateFormat(content, locale) || detectNumberFormat(content);
           if (format !== PLAIN_TEXT_FORMAT && !isEvaluationError(content)) {
               content = toString(parseLiteral(content, locale));
           }
@@ -36383,6 +36393,18 @@
           }
           return "Success" /* CommandResult.Success */;
       }
+      checkUselessUpdateCell(cmd) {
+          const cell = this.getters.getCell(cmd);
+          const hasContent = "content" in cmd || "formula" in cmd;
+          const hasStyle = "style" in cmd;
+          const hasFormat = "format" in cmd;
+          if ((!hasContent || cell?.content === cmd.content) &&
+              (!hasStyle || deepEquals(cell?.style, cmd.style)) &&
+              (!hasFormat || cell?.format === cmd.format)) {
+              return "NoChanges" /* CommandResult.NoChanges */;
+          }
+          return "Success" /* CommandResult.Success */;
+      }
   }
   class FormulaCellWithDependencies {
       id;
@@ -41167,7 +41189,15 @@
           if (!this.rTrees[sheetId]) {
               return;
           }
-          this.rTrees[sheetId].remove(item, deepEquals);
+          this.rTrees[sheetId].remove(item, this.rtreeItemComparer);
+      }
+      rtreeItemComparer(left, right) {
+          return (left.data == right.data &&
+              left.boundingBox.sheetId === right.boundingBox.sheetId &&
+              left.boundingBox?.zone.left === right.boundingBox.zone.left &&
+              left.boundingBox?.zone.top === right.boundingBox.zone.top &&
+              left.boundingBox?.zone.right === right.boundingBox.zone.right &&
+              left.boundingBox?.zone.bottom === right.boundingBox.zone.bottom);
       }
   }
   /**
@@ -41245,7 +41275,7 @@
           const queue = Array.from(ranges).reverse();
           while (queue.length > 0) {
               const range = queue.pop();
-              visited.add(...this.encoder.encodeBoundingBox(range));
+              visited.addMany(this.encoder.encodeBoundingBox(range));
               const impactedPositionIds = this.rTree.search(range).map((dep) => dep.data);
               for (const positionId of impactedPositionIds) {
                   if (!visited.has(positionId)) {
@@ -41253,7 +41283,7 @@
                   }
               }
           }
-          visited.delete(...ranges.flatMap((r) => this.encoder.encodeBoundingBox(r)));
+          visited.deleteMany(ranges.flatMap((r) => this.encoder.encodeBoundingBox(r)));
           return visited;
       }
   }
@@ -41393,9 +41423,9 @@
           const cells = positions.map((p) => this.encoder.encode(p));
           const cellsToCompute = new JetSet(cells);
           const arrayFormulasPositionIds = this.getArrayFormulasImpactedByChangesOf(cells);
-          cellsToCompute.add(...this.getCellsDependingOn(cells));
-          cellsToCompute.add(...arrayFormulasPositionIds);
-          cellsToCompute.add(...this.getCellsDependingOn(arrayFormulasPositionIds));
+          cellsToCompute.addMany(this.getCellsDependingOn(cells));
+          cellsToCompute.addMany(arrayFormulasPositionIds);
+          cellsToCompute.addMany(this.getCellsDependingOn(arrayFormulasPositionIds));
           this.evaluate(cellsToCompute);
       }
       getArrayFormulasImpactedByChangesOf(positionIds) {
@@ -41409,7 +41439,7 @@
               }
               if (!content) {
                   // The previous content could have blocked some array formulas
-                  impactedPositionIds.add(...this.getArrayFormulasBlockedByOrSpreadingOn(positionId));
+                  impactedPositionIds.addMany(this.getArrayFormulasBlockedByOrSpreadingOn(positionId));
               }
           }
           return impactedPositionIds;
@@ -41461,7 +41491,7 @@
           }
           const arrayFormulas = this.spreadingRelations.getFormulaPositionsSpreadingOn(positionId);
           const cells = new JetSet(arrayFormulas);
-          cells.add(...this.getCellsDependingOn(arrayFormulas));
+          cells.addMany(this.getCellsDependingOn(arrayFormulas));
           return cells;
       }
       nextPositionsToUpdate = new JetSet();
@@ -41599,7 +41629,7 @@
               this.setEvaluatedCell(positionId, evaluatedCell);
               // check if formula dependencies present in the spread zone
               // if so, they need to be recomputed
-              this.nextPositionsToUpdate.add(...this.getCellsDependingOn([positionId]));
+              this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([positionId]));
           };
       }
       invalidateSpreading(positionId) {
@@ -41614,8 +41644,8 @@
                   continue;
               }
               this.evaluatedCells.delete(child);
-              this.nextPositionsToUpdate.add(...this.getCellsDependingOn([child]));
-              this.nextPositionsToUpdate.add(...this.getArrayFormulasBlockedByOrSpreadingOn(child));
+              this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([child]));
+              this.nextPositionsToUpdate.addMany(this.getArrayFormulasBlockedByOrSpreadingOn(child));
           }
           this.spreadingRelations.removeNode(positionId);
       }
@@ -45484,7 +45514,7 @@
       }
       finalize() {
           if (this.isSearchDirty) {
-              this.refreshSearch();
+              this.refreshSearch(false);
               this.isSearchDirty = false;
           }
       }
@@ -45528,10 +45558,10 @@
       /**
        * refresh the matches according to the current search options
        */
-      refreshSearch() {
+      refreshSearch(jumpToMatchSheet = true) {
           this.selectedMatchIndex = null;
           this.findMatches();
-          this.selectNextCell(Direction.current);
+          this.selectNextCell(Direction.current, jumpToMatchSheet);
       }
       /**
        * Updates the regex based on the current searchOptions and
@@ -45613,7 +45643,7 @@
        * It is also used to keep coherence between the selected searchMatch
        * and selectedMatchIndex.
        */
-      selectNextCell(indexChange) {
+      selectNextCell(indexChange, jumpToMatchSheet = true) {
           const matches = this.searchMatches;
           if (!matches.length) {
               this.selectedMatchIndex = null;
@@ -45639,7 +45669,7 @@
           this.selectedMatchIndex = nextIndex;
           const selectedMatch = matches[nextIndex];
           // Switch to the sheet where the match is located
-          if (this.getters.getActiveSheetId() !== selectedMatch.sheetId) {
+          if (jumpToMatchSheet && this.getters.getActiveSheetId() !== selectedMatch.sheetId) {
               this.dispatch("ACTIVATE_SHEET", {
                   sheetIdFrom: this.getters.getActiveSheetId(),
                   sheetIdTo: selectedMatch.sheetId,
@@ -47211,7 +47241,7 @@
           "getCellText",
           "getCellMultiLineText",
           "getContiguousZone",
-          "isCellEmpty",
+          "isEvaluatedCellEmpty",
       ];
       ctx = document.createElement("canvas").getContext("2d");
       // ---------------------------------------------------------------------------
@@ -47339,14 +47369,23 @@
           return zone;
       }
       /**
-       * Check if a cell is empty. If the cell is part of a merge,
-       * check if the merge containing the cell is empty.
+       * Checks if a cell evaluated value is empty. If the cell is part of a merge,
+       * the check applies to the main cell of the merge.
        */
-      isCellEmpty(position) {
+      isEvaluatedCellEmpty(position) {
           const mainPosition = this.getters.getMainCellPosition(position);
           const cell = this.getters.getEvaluatedCell(mainPosition);
           return cell.type === CellValueType.empty;
       }
+      /**
+       * Checks if a cell is empty (i.e. does not have a content or a formula does not spread over it).
+       * If the cell is part of a merge, the check applies to the main cell of the merge.
+       */
+      isCellEmpty(position) {
+          const mainPosition = this.getters.getMainCellPosition(position);
+          return !(this.getters.getCorrespondingFormulaCell(mainPosition) ||
+              this.getters.getCell(mainPosition)?.content);
+      }
       getColMaxWidth(sheetId, index) {
           const cellsPositions = positions(this.getters.getColsZone(sheetId, index, index));
           const sizes = cellsPositions.map((position) => this.getCellWidth({ sheetId, ...position }));
@@ -54888,8 +54927,8 @@
           let currentPosition = startPosition;
           // If both the current cell and the next cell are not empty, we want to go to the end of the cluster
           const nextCellPosition = this.getNextCellPosition(startPosition, dim, dir);
-          let mode = !this.getters.isCellEmpty({ ...currentPosition, sheetId }) &&
-              !this.getters.isCellEmpty({ ...nextCellPosition, sheetId })
+          let mode = !this.getters.isEvaluatedCellEmpty({ ...currentPosition, sheetId }) &&
+              !this.getters.isEvaluatedCellEmpty({ ...nextCellPosition, sheetId })
               ? "endOfCluster"
               : "nextCluster";
           while (true) {
@@ -54899,7 +54938,7 @@
                   currentPosition.row === nextCellPosition.row) {
                   break;
               }
-              const isNextCellEmpty = this.getters.isCellEmpty({ ...nextCellPosition, sheetId });
+              const isNextCellEmpty = this.getters.isEvaluatedCellEmpty({ ...nextCellPosition, sheetId });
               if (mode === "endOfCluster" && isNextCellEmpty) {
                   break;
               }
@@ -57184,9 +57223,9 @@
   exports.tokenize = tokenize;
 
 
-  __info__.version = "17.1.4";
-  __info__.date = "2024-02-09T13:09:13.430Z";
-  __info__.hash = "16d3ece";
+  __info__.version = "17.1.5";
+  __info__.date = "2024-02-16T14:23:54.651Z";
+  __info__.hash = "29d8ad6";
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);