@odoo/o-spreadsheet 17.1.3 → 17.1.5

package/dist/o-spreadsheet.esm.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.1.3
- * @date 2024-02-02T13:46:54.332Z
- * @hash 798f979
+ * @version 17.1.5
+ * @date 2024-02-16T14:23:54.651Z
+ * @hash 29d8ad6
  */
 
 import { Component, useRef, onMounted, useEffect, onWillPatch, useState, onWillUpdateProps, onPatched, useComponent, useExternalListener, onWillUnmount, onWillStart, xml, useChildSubEnv, useSubEnv, markRaw } from '@odoo/owl';
@@ -451,8 +451,8 @@ function isObjectEmptyRecursive(argument) {
  * If the given item does not exist in the dictionary, it creates one with a new id.
  */
 function getItemId(item, itemsDic) {
-    for (let [key, value] of Object.entries(itemsDic)) {
-        if (deepEquals(value, item)) {
+    for (const key in itemsDic) {
+        if (deepEquals(itemsDic[key], item)) {
             return parseInt(key, 10);
         }
     }
@@ -551,11 +551,13 @@ function deepEquals(o1, o2) {
     if (typeof o1 !== "object")
         return o1 === o2;
     // Objects can have different keys if the values are undefined
-    const keys = new Set();
-    Object.keys(o1).forEach((key) => keys.add(key));
-    Object.keys(o2).forEach((key) => keys.add(key));
-    for (let key of keys) {
-        if (typeof o1[key] !== typeof o1[key])
+    for (const key in o2) {
+        if (!(key in o1) && o2[key] !== undefined) {
+            return false;
+        }
+    }
+    for (const key in o1) {
+        if (typeof o1[key] !== typeof o2[key])
             return false;
         if (typeof o1[key] === "object") {
             if (!deepEquals(o1[key], o2[key]))
@@ -625,18 +627,18 @@ function isConsecutive(iterable) {
     return true;
 }
 class JetSet extends Set {
-    add(...iterable) {
+    addMany(iterable) {
         for (const element of iterable) {
             super.add(element);
         }
         return this;
     }
-    delete(...iterable) {
-        let deleted = false;
+    deleteMany(iterable) {
+        let wasDeleted = false;
         for (const element of iterable) {
-            deleted ||= super.delete(element);
+            wasDeleted ||= super.delete(element);
         }
-        return deleted;
+        return wasDeleted;
     }
 }
 /**
@@ -1934,7 +1936,7 @@ class DispatchResult {
      * Static helper which returns a successful DispatchResult
      */
     static get Success() {
-        return new DispatchResult();
+        return SUCCESS;
     }
     get isSuccessful() {
         return this.reasons.length === 0;
@@ -1947,6 +1949,7 @@ class DispatchResult {
         return this.reasons.includes(reason);
     }
 }
+const SUCCESS = new DispatchResult();
 var CommandResult;
 (function (CommandResult) {
     CommandResult["Success"] = "Success";
@@ -2938,6 +2941,9 @@ function formatValue(value, { format, locale }) {
     }
     switch (typeof value) {
         case "string":
+            if (value.includes('\\"')) {
+                return value.replace(/\\"/g, '"');
+            }
             return value;
         case "boolean":
             return value ? "TRUE" : "FALSE";
@@ -4991,14 +4997,8 @@ function createDataSets(getters, dataSetsString, sheetId, dataSetsHaveTitle) {
                     : undefined));
             }
         }
-        else if (zone.left === zone.right && zone.top === zone.bottom) {
-            // A single cell. If it's only the title, the dataset is not added.
-            if (!dataSetsHaveTitle) {
-                dataSets.push(createDataSet(getters, dataSetSheetId, zone, undefined));
-            }
-        }
         else {
-            /* 1 row or 1 column */
+            /* 1 cell, 1 row or 1 column */
             dataSets.push(createDataSet(getters, dataSetSheetId, zone, dataSetsHaveTitle
                 ? {
                     top: zone.top,
@@ -7441,7 +7441,7 @@ function tokenize(str, locale = DEFAULT_LOCALE) {
     while (!chars.isOver()) {
         let token = tokenizeSpace(chars) ||
             tokenizeArgsSeparator(chars, locale) ||
-            tokenizeMisc(chars) ||
+            tokenizeParenthesis(chars) ||
             tokenizeOperator(chars) ||
             tokenizeString(chars) ||
             tokenizeDebugger(chars) ||
@@ -7462,15 +7462,14 @@ function tokenizeDebugger(chars) {
     }
     return null;
 }
-const misc$1 = {
-    "(": "LEFT_PAREN",
-    ")": "RIGHT_PAREN",
+const parenthesis = {
+    "(": { type: "LEFT_PAREN", value: "(" },
+    ")": { type: "RIGHT_PAREN", value: ")" },
 };
-function tokenizeMisc(chars) {
-    if (chars.current in misc$1) {
+function tokenizeParenthesis(chars) {
+    if (chars.current === "(" || chars.current === ")") {
         const value = chars.shift();
-        const type = misc$1[value];
-        return { type, value };
+        return parenthesis[value];
     }
     return null;
 }
@@ -7491,7 +7490,12 @@ function tokenizeOperator(chars) {
     }
     return null;
 }
+const FIRST_POSSIBLE_NUMBER_CHARS = new Set("0123456789");
 function tokenizeNumber(chars, locale) {
+    if (!FIRST_POSSIBLE_NUMBER_CHARS.has(chars.current) &&
+        chars.current !== locale.decimalSeparator) {
+        return null;
+    }
     const match = chars.remaining().match(getFormulaNumberRegex(locale.decimalSeparator));
     if (match) {
         chars.advanceBy(match[0].length);
@@ -7516,7 +7520,7 @@ function tokenizeString(chars) {
     }
     return null;
 }
-const separatorRegexp = /\w|\.|!|\$/;
+const separatorRegexp = /^[\w\.!\$]+/;
 /**
  * A "Symbol" is just basically any word-like element that can appear in a
  * formula, which is not a string. So:
@@ -7556,8 +7560,11 @@ function tokenizeSymbol(chars) {
             };
         }
     }
-    while (chars.current && separatorRegexp.test(chars.current)) {
-        result += chars.shift();
+    const match = chars.remaining().match(separatorRegexp);
+    if (match) {
+        const value = match[0];
+        result += value;
+        chars.advanceBy(value.length);
     }
     if (result.length) {
         const value = result;
@@ -7619,7 +7626,10 @@ class TokenizingChars {
         return this.text.substring(this.currentIndex);
     }
     currentStartsWith(str) {
-        for (let j = 0; j < str.length; j++) {
+        if (this.current !== str[0]) {
+            return false;
+        }
+        for (let j = 1; j < str.length; j++) {
             if (this.text[this.currentIndex + j] !== str[j]) {
                 return false;
             }
@@ -7646,6 +7656,9 @@ function isValidLocale(locale) {
     if (locale.formulaArgSeparator === locale.decimalSeparator) {
         return false;
     }
+    if (locale.thousandsSeparator === locale.decimalSeparator) {
+        return false;
+    }
     try {
         formatValue(1, { locale, format: "#,##0.00" });
         formatValue(1, { locale, format: locale.dateFormat });
@@ -7736,7 +7749,7 @@ function canonicalizeNumberLiteral(content, locale) {
     if (locale.decimalSeparator === "." || !isNumber(content, locale)) {
         return content;
     }
-    return content.replace(locale.decimalSeparator, ".");
+    return content.replace(locale.thousandsSeparator, "").replace(locale.decimalSeparator, ".");
 }
 /**
  * Change a content string from the given locale to its canonical form (en_US locale). Also convert date string.
@@ -8651,7 +8664,7 @@ class BarChart extends AbstractChart {
             return undefined;
         const dataSets = this.dataSets
             .map((ds) => toExcelDataset(this.getters, ds))
-            .filter((ds) => ds.range !== ""); // && range !== CellErrorType.InvalidReference ? show incorrect #ref ?
+            .filter((ds) => ds.range !== "" && ds.range !== CellErrorType.InvalidReference);
         const labelRange = toExcelLabelRange(this.getters, this.labelRange, shouldRemoveFirstLabel(this.labelRange, this.dataSets[0], this.dataSetsHaveTitle));
         return {
             ...this.getDefinition(),
@@ -9229,7 +9242,7 @@ class LineChart extends AbstractChart {
             return undefined;
         const dataSets = this.dataSets
             .map((ds) => toExcelDataset(this.getters, ds))
-            .filter((ds) => ds.range !== ""); // && range !== CellErrorType.InvalidReference ? show incorrect #ref ?
+            .filter((ds) => ds.range !== "" && ds.range !== CellErrorType.InvalidReference);
         const labelRange = toExcelLabelRange(this.getters, this.labelRange, shouldRemoveFirstLabel(this.labelRange, this.dataSets[0], this.dataSetsHaveTitle));
         return {
             ...this.getDefinition(),
@@ -9535,7 +9548,7 @@ class PieChart extends AbstractChart {
             return undefined;
         const dataSets = this.dataSets
             .map((ds) => toExcelDataset(this.getters, ds))
-            .filter((ds) => ds.range !== ""); // && range !== CellErrorType.InvalidReference ? show incorrect #ref ?
+            .filter((ds) => ds.range !== "" && ds.range !== CellErrorType.InvalidReference);
         const labelRange = toExcelLabelRange(this.getters, this.labelRange, shouldRemoveFirstLabel(this.labelRange, this.dataSets[0], this.dataSetsHaveTitle));
         return {
             ...this.getDefinition(),
@@ -10831,6 +10844,12 @@ const INSERT_LINK = (env) => {
     let { col, row } = env.model.getters.getActivePosition();
     env.model.dispatch("OPEN_CELL_POPOVER", { col, row, popoverType: "LinkEditor" });
 };
+const INSERT_LINK_NAME = (env) => {
+    const sheetId = env.model.getters.getActiveSheetId();
+    const { col, row } = env.model.getters.getActivePosition();
+    const cell = env.model.getters.getEvaluatedCell({ sheetId, col, row });
+    return cell && cell.link ? _t("Edit link") : _t("Insert link");
+};
 //------------------------------------------------------------------------------
 // Filters action
 //------------------------------------------------------------------------------
@@ -18682,6 +18701,9 @@ const HLOOKUP = {
     compute: function (searchKey, range, index, isSorted = { value: DEFAULT_IS_SORTED }) {
         const _index = Math.trunc(toNumber(index?.value, this.locale));
         assert(() => 1 <= _index && _index <= range[0].length, _t("[[FUNCTION_NAME]] evaluates to an out of bounds range."));
+        if (searchKey && isEvaluationError(searchKey.value)) {
+            return searchKey;
+        }
         const getValueFromRange = (range, index) => range[index][0].value;
         const _isSorted = toBoolean(isSorted.value);
         const colIndex = _isSorted
@@ -18849,6 +18871,9 @@ const VLOOKUP = {
     compute: function (searchKey, range, index, isSorted = { value: DEFAULT_IS_SORTED }) {
         const _index = Math.trunc(toNumber(index?.value, this.locale));
         assert(() => 1 <= _index && _index <= range.length, _t("[[FUNCTION_NAME]] evaluates to an out of bounds range."));
+        if (searchKey && isEvaluationError(searchKey.value)) {
+            return searchKey;
+        }
         const getValueFromRange = (range, index) => range[0][index].value;
         const _isSorted = toBoolean(isSorted.value);
         const rowIndex = _isSorted
@@ -18888,6 +18913,9 @@ const XLOOKUP = {
         assert(() => lookupDirection === "col"
             ? returnRange[0].length === lookupRange[0].length
             : returnRange.length === lookupRange.length, _t("return_range should have the same dimensions as lookup_range."));
+        if (searchKey && isEvaluationError(searchKey.value)) {
+            return [[searchKey]];
+        }
         const getElement = lookupDirection === "col"
             ? (range, index) => range[0][index].value
             : (range, index) => range[index][0].value;
@@ -20066,7 +20094,7 @@ cellMenuRegistry
 })
     .add("insert_link", {
     ...insertLink,
-    name: _t("Insert link"),
+    name: INSERT_LINK_NAME,
     sequence: 150,
     separator: true,
 });
@@ -26509,6 +26537,17 @@ class TextValueProvider extends Component {
         onValueSelected: Function,
         onValueHovered: Function,
     };
+    autoCompleteListRef = useRef("autoCompleteList");
+    setup() {
+        useEffect(() => {
+            const selectedIndex = this.props.selectedIndex;
+            if (selectedIndex === undefined) {
+                return;
+            }
+            const selectedElement = this.autoCompleteListRef.el?.children[selectedIndex];
+            selectedElement?.scrollIntoView?.({ block: "nearest" });
+        }, () => [this.props.selectedIndex, this.autoCompleteListRef.el]);
+    }
 }
 
 class ContentEditableHelper {
@@ -26953,6 +26992,7 @@ css /* scss */ `
       position: absolute;
       margin: 1px 4px;
       pointer-events: none;
+      overflow: auto;
 
       .o-semi-bold {
         /** FIXME: to remove in favor of Bootstrap
@@ -26969,15 +27009,17 @@ class Composer extends Component {
         focus: {
             validate: (value) => ["inactive", "cellFocus", "contentFocus"].includes(value),
         },
-        onComposerContentFocused: Function,
         inputStyle: { type: String, optional: true },
         rect: { type: Object, optional: true },
         delimitation: { type: Object, optional: true },
-        onComposerUnmounted: { type: Function, optional: true },
+        onComposerCellFocused: { type: Function, optional: true },
+        onComposerContentFocused: Function,
+        isDefaultFocus: { type: Boolean, optional: true },
     };
     static components = { TextValueProvider, FunctionDescriptionProvider };
     static defaultProps = {
         inputStyle: "",
+        isDefaultFocus: false,
     };
     composerRef = useRef("o_composer");
     contentHelper = new ContentEditableHelper(this.composerRef.el);
@@ -27008,7 +27050,10 @@ class Composer extends Component {
         if (this.props.delimitation && this.props.rect) {
             const { x: cellX, y: cellY, height: cellHeight } = this.props.rect;
             const remainingHeight = this.props.delimitation.height - (cellY + cellHeight);
+            assistantStyle["max-height"] = `${remainingHeight}px`;
             if (cellY > remainingHeight) {
+                const availableSpaceAbove = cellY;
+                assistantStyle["max-height"] = `${availableSpaceAbove}px`;
                 // render top
                 // We compensate 2 px of margin on the assistant style + 1px for design reasons
                 assistantStyle.top = `-3px`;
@@ -27034,7 +27079,6 @@ class Composer extends Component {
         F4: this.processF4Key,
         Tab: (ev) => this.processTabKey(ev, "right"),
         "Shift+Tab": (ev) => this.processTabKey(ev, "left"),
-        "Ctrl+ ": this.processSpaceKey,
     };
     keyCodeMapping = {
         NumpadDecimal: this.processNumpadDecimal,
@@ -27042,12 +27086,12 @@ class Composer extends Component {
     setup() {
         onMounted(() => {
             const el = this.composerRef.el;
+            if (this.props.isDefaultFocus) {
+                this.env.focusableElement.setFocusableElement(el);
+            }
             this.contentHelper.updateEl(el);
             this.processTokenAtCursor();
         });
-        onWillUnmount(() => {
-            this.props.onComposerUnmounted?.();
-        });
         useEffect(() => {
             this.processContent();
         });
@@ -27056,7 +27100,8 @@ class Composer extends Component {
     // Handlers
     // ---------------------------------------------------------------------------
     processArrowKeys(ev) {
-        if (this.env.model.getters.isSelectingForComposer()) {
+        if (this.env.model.getters.isSelectingForComposer() ||
+            this.env.model.getters.getEditionMode() === "inactive") {
             this.functionDescriptionState.showDescription = false;
             // Prevent the default content editable behavior which moves the cursor
             ev.preventDefault();
@@ -27099,23 +27144,19 @@ class Composer extends Component {
     processTabKey(ev, direction) {
         ev.preventDefault();
         ev.stopPropagation();
-        const state = this.autoCompleteState;
-        if (state.showProvider && state.selectedIndex !== undefined) {
-            const autoCompleteValue = this.autoCompleteState.values[state.selectedIndex]?.text;
-            if (autoCompleteValue) {
-                this.autoComplete(autoCompleteValue);
-                return;
+        if (this.env.model.getters.getEditionMode() !== "inactive") {
+            const state = this.autoCompleteState;
+            if (state.showProvider && state.selectedIndex !== undefined) {
+                const autoCompleteValue = this.autoCompleteState.values[state.selectedIndex]?.text;
+                if (autoCompleteValue) {
+                    this.autoComplete(autoCompleteValue);
+                    return;
+                }
             }
+            interactiveStopEdition(this.env);
         }
-        interactiveStopEdition(this.env);
         this.env.model.selection.moveAnchorCell(direction, 1);
     }
-    processSpaceKey(ev) {
-        ev.preventDefault();
-        ev.stopPropagation();
-        this.showFunctionAutocomplete("");
-        this.env.model.dispatch("STOP_COMPOSER_RANGE_SELECTION");
-    }
     processEnterKey(ev, direction) {
         ev.preventDefault();
         ev.stopPropagation();
@@ -27177,6 +27218,9 @@ class Composer extends Component {
         this.compositionActive = false;
     }
     onKeydown(ev) {
+        if (this.env.model.getters.getEditionMode() === "inactive") {
+            return;
+        }
         if (ev.key.startsWith("Arrow")) {
             this.processArrowKeys(ev);
             return;
@@ -27190,14 +27234,33 @@ class Composer extends Component {
             ev.stopPropagation();
         }
     }
+    onPaste(ev) {
+        if (this.env.model.getters.getEditionMode() !== "inactive") {
+            ev.stopPropagation();
+        }
+    }
     /*
      * Triggered automatically by the content-editable between the keydown and key up
      * */
     onInput(ev) {
-        if (this.props.focus === "inactive" || !this.shouldProcessInputEvents) {
+        if (!this.shouldProcessInputEvents) {
             return;
         }
-        let content = this.contentHelper.getText();
+        if (ev.inputType === "insertFromPaste" &&
+            this.env.model.getters.getEditionMode() === "inactive") {
+            return;
+        }
+        ev.stopPropagation();
+        let content;
+        if (this.env.model.getters.getEditionMode() === "inactive") {
+            content = ev.data || "";
+        }
+        else {
+            content = this.contentHelper.getText();
+        }
+        if (this.props.focus === "inactive") {
+            return this.props.onComposerCellFocused?.(content);
+        }
         let selection = this.contentHelper.getCurrentSelection();
         this.env.model.dispatch("STOP_COMPOSER_RANGE_SELECTION");
         this.env.model.dispatch("SET_CURRENT_CONTENT", {
@@ -27273,9 +27336,8 @@ class Composer extends Component {
         }
         const newSelection = this.contentHelper.getCurrentSelection();
         this.env.model.dispatch("STOP_COMPOSER_RANGE_SELECTION");
-        if (this.props.focus === "inactive") {
-            this.props.onComposerContentFocused(newSelection);
-        }
+        this.props.onComposerContentFocused();
+        if (this.props.focus === "inactive") ;
         this.env.model.dispatch("CHANGE_COMPOSER_CURSOR_SELECTION", newSelection);
         this.processTokenAtCursor();
     }
@@ -27442,7 +27504,7 @@ class Composer extends Component {
         const highlights = this.env.model.getters.getHighlights();
         const refSheet = sheetName
             ? this.env.model.getters.getSheetIdByName(sheetName)
-            : this.env.model.getters.getCurrentEditedCell().sheetId;
+            : this.env.model.getters.getCurrentEditedCell()?.sheetId;
         const highlight = highlights.find((highlight) => {
             if (highlight.sheetId !== refSheet)
                 return false;
@@ -27569,56 +27631,30 @@ class GridComposer extends Component {
         focus: {
             validate: (value) => ["inactive", "cellFocus", "contentFocus"].includes(value),
         },
-        onComposerUnmounted: Function,
+        onComposerCellFocused: Function,
         onComposerContentFocused: Function,
         gridDims: Object,
     };
     static components = { Composer };
-    gridComposerRef;
-    zone;
-    rect;
+    rect = this.defaultRect;
+    isEditing = false;
     isCellReferenceVisible;
-    composerState;
+    get defaultRect() {
+        return { x: 0, y: 0, width: 0, height: 0 };
+    }
     setup() {
-        this.gridComposerRef = useRef("gridComposer");
-        this.composerState = useState({
-            rect: undefined,
-            delimitation: undefined,
-        });
-        const { sheetId, col, row } = this.env.model.getters.getActivePosition();
-        this.zone = this.env.model.getters.expandZone(sheetId, positionToZone({ col, row }));
-        this.rect = this.env.model.getters.getVisibleRect(this.zone);
-        this.isCellReferenceVisible = false;
-        onMounted(() => {
-            const el = this.gridComposerRef.el;
-            this.composerState.rect = {
-                x: this.rect.x,
-                y: this.rect.y,
-                width: el.clientWidth,
-                height: el.clientHeight,
-            };
-            this.composerState.delimitation = {
-                width: this.props.gridDims.width,
-                height: this.props.gridDims.height,
-            };
-        });
         onWillUpdateProps(() => {
-            if (this.isCellReferenceVisible) {
-                return;
-            }
-            const sheetId = this.env.model.getters.getActiveSheetId();
-            const zone = this.env.model.getters.getSelectedZone();
-            const rect = this.env.model.getters.getVisibleRect(zone);
-            if (!deepEquals(rect, this.rect) ||
-                sheetId !== this.env.model.getters.getCurrentEditedCell().sheetId) {
-                this.isCellReferenceVisible = true;
-            }
+            this.updateComponentPosition();
+            this.updateCellReferenceVisibility();
         });
     }
     get shouldDisplayCellReference() {
         return this.isCellReferenceVisible;
     }
     get cellReference() {
+        if (!this.env.model.getters.getCurrentEditedCell()) {
+            return "";
+        }
         const { col, row, sheetId } = this.env.model.getters.getCurrentEditedCell();
         const prefixSheet = sheetId !== this.env.model.getters.getActiveSheetId();
         return getFullReference(prefixSheet ? this.env.model.getters.getSheetName(sheetId) : undefined, toXC(col, row));
@@ -27630,7 +27666,27 @@ class GridComposer extends Component {
             top: `${top - GRID_CELL_REFERENCE_TOP_OFFSET}px`,
         });
     }
+    get composerProps() {
+        const { width, height } = this.env.model.getters.getSheetViewDimensionWithHeaders();
+        return {
+            rect: { ...this.rect },
+            delimitation: {
+                width,
+                height,
+            },
+            focus: this.props.focus,
+            isDefaultFocus: true,
+            onComposerContentFocused: this.props.onComposerContentFocused,
+            onComposerCellFocused: this.props.onComposerCellFocused,
+        };
+    }
     get containerStyle() {
+        if (this.env.model.getters.getEditionMode() === "inactive" || !this.rect) {
+            return `
+        position: absolute;
+        z-index: -1000;
+      `;
+        }
         const isFormula = this.env.model.getters.getCurrentContent().startsWith("=");
         const cell = this.env.model.getters.getActiveCell();
         const position = this.env.model.getters.getActivePosition();
@@ -27650,6 +27706,8 @@ class GridComposer extends Component {
         if (!isFormula) {
             textAlign = style.align || cell.defaultAlign;
         }
+        const maxHeight = this.props.gridDims.height - this.rect.y;
+        const maxWidth = this.props.gridDims.width - this.rect.x;
         /**
          * min-size is on the container, not the composer element, because we want to have the same size as the cell by default,
          * including all the paddings/margins of the composer
@@ -27661,6 +27719,8 @@ class GridComposer extends Component {
             top: `${top}px`,
             "min-width": `${width + 1}px`,
             "min-height": `${height + 1}px`,
+            "max-width": `${maxWidth}px`,
+            "max-height": `${maxHeight}px`,
             background,
             color,
             "font-size": `${fontSizeInPixels(fontSize)}px`,
@@ -27670,13 +27730,31 @@ class GridComposer extends Component {
             "text-align": textAlign,
         });
     }
-    get composerStyle() {
-        const maxHeight = this.props.gridDims.height - this.rect.y;
-        const maxWidth = this.props.gridDims.width - this.rect.x;
-        return cssPropertiesToCss({
-            "max-width": `${maxWidth}px`,
-            "max-height": `${maxHeight}px`,
-        });
+    updateComponentPosition() {
+        const isEditing = this.env.model.getters.getEditionMode() !== "inactive";
+        if (this.isEditing !== isEditing) {
+            this.isEditing = isEditing;
+            if (!isEditing) {
+                this.rect = this.defaultRect;
+                this.env.focusableElement.focus();
+                return;
+            }
+            const position = this.env.model.getters.getActivePosition();
+            const zone = this.env.model.getters.expandZone(position.sheetId, positionToZone(position));
+            this.rect = this.env.model.getters.getVisibleRect(zone);
+        }
+    }
+    updateCellReferenceVisibility() {
+        if (this.isCellReferenceVisible || this.env.model.getters.getEditionMode() === "inactive") {
+            return;
+        }
+        const sheetId = this.env.model.getters.getActiveSheetId();
+        const zone = this.env.model.getters.getSelectedZone();
+        const rect = this.env.model.getters.getVisibleRect(zone);
+        if (!deepEquals(rect, this.rect) ||
+            sheetId !== this.env.model.getters.getCurrentEditedCell().sheetId) {
+            this.isCellReferenceVisible = true;
+        }
     }
 }
 
@@ -28776,7 +28854,6 @@ class GridOverlay extends Component {
         this.props.onCellDoubleClicked(col, row);
     }
     onContextMenu(ev) {
-        ev.preventDefault();
         const [col, row] = this.getCartesianCoordinates(ev);
         this.props.onCellRightClicked(col, row, { x: ev.clientX, y: ev.clientY });
     }
@@ -29841,7 +29918,6 @@ class Grid extends Component {
     HEADER_WIDTH = HEADER_WIDTH;
     menuState;
     gridRef;
-    hiddenInput;
     onMouseWheel;
     canvasPosition;
     hoveredCell;
@@ -29852,15 +29928,14 @@ class Grid extends Component {
             menuItems: [],
         });
         this.gridRef = useRef("grid");
-        this.hiddenInput = useRef("hiddenInput");
         this.canvasPosition = useAbsoluteBoundingRect(this.gridRef);
         this.hoveredCell = useState({ col: undefined, row: undefined });
         useChildSubEnv({ getPopoverContainerRect: () => this.getGridRect() });
         useExternalListener(document.body, "cut", this.copy.bind(this, true));
         useExternalListener(document.body, "copy", this.copy.bind(this, false));
         useExternalListener(document.body, "paste", this.paste);
-        onMounted(() => this.focus());
-        this.props.exposeFocus(() => this.focus());
+        onMounted(() => this.focusDefaultElement());
+        this.props.exposeFocus(() => this.focusDefaultElement());
         useGridDrawing("canvas", this.env.model, () => this.env.model.getters.getSheetViewDimensionWithHeaders());
         this.onMouseWheel = useWheelHandler((deltaX, deltaY) => {
             this.moveCanvas(deltaX, deltaY);
@@ -29884,7 +29959,7 @@ class Grid extends Component {
         if (this.env.model.getters.hasOpenedPopover()) {
             this.closeOpenedPopover();
         }
-        this.focus();
+        this.focusDefaultElement();
     }
     // this map will handle most of the actions that should happen on key down. The arrow keys are managed in the key
     // down itself
@@ -30063,10 +30138,10 @@ class Grid extends Component {
         "Alt+Shift+ArrowUp": () => this.processHeaderGroupingKey("up"),
         "Alt+Shift+ArrowDown": () => this.processHeaderGroupingKey("down"),
     };
-    focus() {
+    focusDefaultElement() {
         if (!this.env.model.getters.getSelectedFigureId() &&
             this.env.model.getters.getEditionMode() === "inactive") {
-            this.hiddenInput.el?.focus();
+            this.env.focusableElement.focus();
         }
     }
     get gridEl() {
@@ -30202,19 +30277,6 @@ class Grid extends Component {
             return;
         }
     }
-    onInput(ev) {
-        // the user meant to paste in the sheet, not open the composer with the pasted content
-        if (!ev.isComposing && ev.inputType === "insertFromPaste") {
-            return;
-        }
-        if (ev.data) {
-            // if the user types a character on the grid, it means he wants to start composing the selected cell with that
-            // character
-            ev.preventDefault();
-            ev.stopPropagation();
-            this.props.onGridComposerCellFocused(ev.data);
-        }
-    }
     // ---------------------------------------------------------------------------
     // Context Menu
     // ---------------------------------------------------------------------------
@@ -30329,7 +30391,7 @@ class Grid extends Component {
     }
     closeMenu() {
         this.menuState.isOpen = false;
-        this.focus();
+        this.focusDefaultElement();
     }
     processHeaderGroupingKey(direction) {
         if (this.env.model.getters.getSelectedZones().length !== 1) {
@@ -34246,6 +34308,31 @@ const MIGRATIONS = [
             return data;
         },
     },
+    {
+        description: "Fix datafilter duplication",
+        from: 12,
+        to: 12.5,
+        applyMigration(data) {
+            for (let sheet of data.sheets || []) {
+                let knownDataFilterZones = [];
+                for (let filterTable of sheet.filterTables || []) {
+                    const zone = toZone(filterTable.range);
+                    // See commit message for the details
+                    const intersectZoneIndex = knownDataFilterZones.findIndex((knownZone) => overlap(knownZone, zone));
+                    if (intersectZoneIndex !== -1) {
+                        knownDataFilterZones[intersectZoneIndex] = zone;
+                    }
+                    else {
+                        knownDataFilterZones.push(zone);
+                    }
+                }
+                sheet.filterTables = knownDataFilterZones.map((zone) => ({
+                    range: zoneToXc(zone),
+                }));
+            }
+            return data;
+        },
+    },
     {
         description: "Change Border description structure",
         from: 12,
@@ -35085,22 +35172,7 @@ class BordersPlugin extends CorePlugin {
         }
     }
     export(data) {
-        // Borders
-        let borderId = 0;
         const borders = {};
-        /**
-         * Get the id of the given border. If the border does not exist, it creates
-         * one.
-         */
-        function getBorderId(border) {
-            for (let [key, value] of Object.entries(borders)) {
-                if (deepEquals(value, border)) {
-                    return parseInt(key, 10);
-                }
-            }
-            borders[++borderId] = border;
-            return borderId;
-        }
         for (let sheet of data.sheets) {
             for (let col = 0; col < sheet.colNumber; col++) {
                 for (let row = 0; row < sheet.rowNumber; row++) {
@@ -35108,7 +35180,7 @@ class BordersPlugin extends CorePlugin {
                     if (border) {
                         const xc = toXC(col, row);
                         const cell = sheet.cells[xc];
-                        const borderId = getBorderId(border);
+                        const borderId = getItemId(border, borders);
                         if (cell) {
                             cell.border = borderId;
                         }
@@ -35897,9 +35969,9 @@ class CellPlugin extends CorePlugin {
     allowDispatch(cmd) {
         switch (cmd.type) {
             case "UPDATE_CELL":
-                return this.checkCellOutOfSheet(cmd);
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
             case "CLEAR_CELL":
-                return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
             default:
                 return "Success" /* CommandResult.Success */;
         }
@@ -36032,9 +36104,6 @@ class CellPlugin extends CorePlugin {
                     format: cell.format ? getItemId(cell.format, formats) : undefined,
                     content: cell.content || undefined,
                 };
-                if (cell instanceof FormulaCellWithDependencies) {
-                    cells[xc].content = cell.contentWithFixedReferences || undefined;
-                }
             }
             _sheet.cells = cells;
         }
@@ -36052,8 +36121,8 @@ class CellPlugin extends CorePlugin {
     }
     removeDefaultStyleValues(style) {
         const cleanedStyle = { ...style };
-        for (const [property, defaultValue] of Object.entries(DEFAULT_STYLE)) {
-            if (cleanedStyle[property] === defaultValue) {
+        for (const property in DEFAULT_STYLE) {
+            if (cleanedStyle[property] === DEFAULT_STYLE[property]) {
                 delete cleanedStyle[property];
             }
         }
@@ -36209,10 +36278,7 @@ class CellPlugin extends CorePlugin {
         else {
             style = before ? before.style : undefined;
         }
-        const locale = this.getters.getLocale();
-        let format = ("format" in after ? after.format : before && before.format) ||
-            detectDateFormat(afterContent, locale) ||
-            detectNumberFormat(afterContent);
+        const format = "format" in after ? after.format : before && before.format;
         /* Read the following IF as:
          * we need to remove the cell if it is completely empty, but we can know if it completely empty if:
          * - the command says the new content is empty and has no border/format/style
@@ -36253,6 +36319,7 @@ class CellPlugin extends CorePlugin {
     }
     createLiteralCell(id, content, format, style) {
         const locale = this.getters.getLocale();
+        format = format || detectDateFormat(content, locale) || detectNumberFormat(content);
         if (format !== PLAIN_TEXT_FORMAT && !isEvaluationError(content)) {
             content = toString(parseLiteral(content, locale));
         }
@@ -36286,8 +36353,11 @@ class CellPlugin extends CorePlugin {
      * being a computed property to rebuild the dependencies XC.
      */
     createFormulaCellWithDependencies(id, compiledFormula, format, style, sheetId) {
-        const dependencies = compiledFormula.dependencies.map((xc) => this.getters.getRangeFromSheetXC(sheetId, xc));
-        return new FormulaCellWithDependencies(id, compiledFormula, format, style, dependencies, sheetId, this.getters.getRangeString.bind(this));
+        const dependencies = [];
+        for (const xc of compiledFormula.dependencies) {
+            dependencies.push(this.getters.getRangeFromSheetXC(sheetId, xc));
+        }
+        return new FormulaCellWithDependencies(id, compiledFormula, format, style, dependencies, sheetId, this.getters.getRangeString);
     }
     createErrorFormula(id, content, format, style, error) {
         return {
@@ -36322,6 +36392,18 @@ class CellPlugin extends CorePlugin {
         }
         return "Success" /* CommandResult.Success */;
     }
+    checkUselessUpdateCell(cmd) {
+        const cell = this.getters.getCell(cmd);
+        const hasContent = "content" in cmd || "formula" in cmd;
+        const hasStyle = "style" in cmd;
+        const hasFormat = "format" in cmd;
+        if ((!hasContent || cell?.content === cmd.content) &&
+            (!hasStyle || deepEquals(cell?.style, cmd.style)) &&
+            (!hasFormat || cell?.format === cmd.format)) {
+            return "NoChanges" /* CommandResult.NoChanges */;
+        }
+        return "Success" /* CommandResult.Success */;
+    }
 }
 class FormulaCellWithDependencies {
     id;
@@ -36341,7 +36423,7 @@ class FormulaCellWithDependencies {
         const tokens = compiledFormula.tokens.map((token) => {
             if (token.type === "REFERENCE") {
                 const index = rangeIndex++;
-                return new RangeReferenceToken(() => this.getRangeString(dependencies[index], this.sheetId));
+                return new RangeReferenceToken(dependencies, index, this.sheetId, this.getRangeString);
             }
             return token;
         });
@@ -36368,13 +36450,20 @@ class FormulaCellWithDependencies {
     }
 }
 class RangeReferenceToken {
-    getValue;
+    ranges;
+    rangeIndex;
+    sheetId;
+    getRangeString;
     type = "REFERENCE";
-    constructor(getValue) {
-        this.getValue = getValue;
+    constructor(ranges, rangeIndex, sheetId, getRangeString) {
+        this.ranges = ranges;
+        this.rangeIndex = rangeIndex;
+        this.sheetId = sheetId;
+        this.getRangeString = getRangeString;
     }
     get value() {
-        return this.getValue();
+        const range = this.ranges[this.rangeIndex];
+        return this.getRangeString(range, this.sheetId);
     }
 }
 
@@ -41099,7 +41188,15 @@ class SpreadsheetRTree {
         if (!this.rTrees[sheetId]) {
             return;
         }
-        this.rTrees[sheetId].remove(item, deepEquals);
+        this.rTrees[sheetId].remove(item, this.rtreeItemComparer);
+    }
+    rtreeItemComparer(left, right) {
+        return (left.data == right.data &&
+            left.boundingBox.sheetId === right.boundingBox.sheetId &&
+            left.boundingBox?.zone.left === right.boundingBox.zone.left &&
+            left.boundingBox?.zone.top === right.boundingBox.zone.top &&
+            left.boundingBox?.zone.right === right.boundingBox.zone.right &&
+            left.boundingBox?.zone.bottom === right.boundingBox.zone.bottom);
     }
 }
 /**
@@ -41177,7 +41274,7 @@ class FormulaDependencyGraph {
         const queue = Array.from(ranges).reverse();
         while (queue.length > 0) {
             const range = queue.pop();
-            visited.add(...this.encoder.encodeBoundingBox(range));
+            visited.addMany(this.encoder.encodeBoundingBox(range));
             const impactedPositionIds = this.rTree.search(range).map((dep) => dep.data);
             for (const positionId of impactedPositionIds) {
                 if (!visited.has(positionId)) {
@@ -41185,7 +41282,7 @@ class FormulaDependencyGraph {
                 }
             }
         }
-        visited.delete(...ranges.flatMap((r) => this.encoder.encodeBoundingBox(r)));
+        visited.deleteMany(ranges.flatMap((r) => this.encoder.encodeBoundingBox(r)));
         return visited;
     }
 }
@@ -41325,9 +41422,9 @@ class Evaluator {
         const cells = positions.map((p) => this.encoder.encode(p));
         const cellsToCompute = new JetSet(cells);
         const arrayFormulasPositionIds = this.getArrayFormulasImpactedByChangesOf(cells);
-        cellsToCompute.add(...this.getCellsDependingOn(cells));
-        cellsToCompute.add(...arrayFormulasPositionIds);
-        cellsToCompute.add(...this.getCellsDependingOn(arrayFormulasPositionIds));
+        cellsToCompute.addMany(this.getCellsDependingOn(cells));
+        cellsToCompute.addMany(arrayFormulasPositionIds);
+        cellsToCompute.addMany(this.getCellsDependingOn(arrayFormulasPositionIds));
         this.evaluate(cellsToCompute);
     }
     getArrayFormulasImpactedByChangesOf(positionIds) {
@@ -41341,7 +41438,7 @@ class Evaluator {
             }
             if (!content) {
                 // The previous content could have blocked some array formulas
-                impactedPositionIds.add(...this.getArrayFormulasBlockedByOrSpreadingOn(positionId));
+                impactedPositionIds.addMany(this.getArrayFormulasBlockedByOrSpreadingOn(positionId));
             }
         }
         return impactedPositionIds;
@@ -41393,7 +41490,7 @@ class Evaluator {
         }
         const arrayFormulas = this.spreadingRelations.getFormulaPositionsSpreadingOn(positionId);
         const cells = new JetSet(arrayFormulas);
-        cells.add(...this.getCellsDependingOn(arrayFormulas));
+        cells.addMany(this.getCellsDependingOn(arrayFormulas));
         return cells;
     }
     nextPositionsToUpdate = new JetSet();
@@ -41531,7 +41628,7 @@ class Evaluator {
             this.setEvaluatedCell(positionId, evaluatedCell);
             // check if formula dependencies present in the spread zone
             // if so, they need to be recomputed
-            this.nextPositionsToUpdate.add(...this.getCellsDependingOn([positionId]));
+            this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([positionId]));
         };
     }
     invalidateSpreading(positionId) {
@@ -41546,8 +41643,8 @@ class Evaluator {
                 continue;
             }
             this.evaluatedCells.delete(child);
-            this.nextPositionsToUpdate.add(...this.getCellsDependingOn([child]));
-            this.nextPositionsToUpdate.add(...this.getArrayFormulasBlockedByOrSpreadingOn(child));
+            this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([child]));
+            this.nextPositionsToUpdate.addMany(this.getArrayFormulasBlockedByOrSpreadingOn(child));
         }
         this.spreadingRelations.removeNode(positionId);
     }
@@ -41909,7 +42006,13 @@ class EvaluationPlugin extends UIPlugin {
             const format = newFormat
                 ? getItemId(newFormat, data.formats)
                 : exportedCellData.format;
-            const content = !isExported ? newContent : exportedCellData.content;
+            let content;
+            if (formulaCell instanceof FormulaCellWithDependencies) {
+                content = formulaCell.contentWithFixedReferences;
+            }
+            else {
+                content = !isExported ? newContent : exportedCellData.content;
+            }
             exportedSheetData.cells[xc] = { ...exportedCellData, value, isFormula, content, format };
         }
     }
@@ -45410,7 +45513,7 @@ class FindAndReplacePlugin extends UIPlugin {
     }
     finalize() {
         if (this.isSearchDirty) {
-            this.refreshSearch();
+            this.refreshSearch(false);
             this.isSearchDirty = false;
         }
     }
@@ -45454,10 +45557,10 @@ class FindAndReplacePlugin extends UIPlugin {
     /**
      * refresh the matches according to the current search options
      */
-    refreshSearch() {
+    refreshSearch(jumpToMatchSheet = true) {
         this.selectedMatchIndex = null;
         this.findMatches();
-        this.selectNextCell(Direction.current);
+        this.selectNextCell(Direction.current, jumpToMatchSheet);
     }
     /**
      * Updates the regex based on the current searchOptions and
@@ -45539,7 +45642,7 @@ class FindAndReplacePlugin extends UIPlugin {
      * It is also used to keep coherence between the selected searchMatch
      * and selectedMatchIndex.
      */
-    selectNextCell(indexChange) {
+    selectNextCell(indexChange, jumpToMatchSheet = true) {
         const matches = this.searchMatches;
         if (!matches.length) {
             this.selectedMatchIndex = null;
@@ -45565,7 +45668,7 @@ class FindAndReplacePlugin extends UIPlugin {
         this.selectedMatchIndex = nextIndex;
         const selectedMatch = matches[nextIndex];
         // Switch to the sheet where the match is located
-        if (this.getters.getActiveSheetId() !== selectedMatch.sheetId) {
+        if (jumpToMatchSheet && this.getters.getActiveSheetId() !== selectedMatch.sheetId) {
             this.dispatch("ACTIVATE_SHEET", {
                 sheetIdFrom: this.getters.getActiveSheetId(),
                 sheetIdTo: selectedMatch.sheetId,
@@ -47137,7 +47240,7 @@ class SheetUIPlugin extends UIPlugin {
         "getCellText",
         "getCellMultiLineText",
         "getContiguousZone",
-        "isCellEmpty",
+        "isEvaluatedCellEmpty",
     ];
     ctx = document.createElement("canvas").getContext("2d");
     // ---------------------------------------------------------------------------
@@ -47265,14 +47368,23 @@ class SheetUIPlugin extends UIPlugin {
         return zone;
     }
     /**
-     * Check if a cell is empty. If the cell is part of a merge,
-     * check if the merge containing the cell is empty.
+     * Checks if a cell evaluated value is empty. If the cell is part of a merge,
+     * the check applies to the main cell of the merge.
      */
-    isCellEmpty(position) {
+    isEvaluatedCellEmpty(position) {
         const mainPosition = this.getters.getMainCellPosition(position);
         const cell = this.getters.getEvaluatedCell(mainPosition);
         return cell.type === CellValueType.empty;
     }
+    /**
+     * Checks if a cell is empty (i.e. does not have a content or a formula does not spread over it).
+     * If the cell is part of a merge, the check applies to the main cell of the merge.
+     */
+    isCellEmpty(position) {
+        const mainPosition = this.getters.getMainCellPosition(position);
+        return !(this.getters.getCorrespondingFormulaCell(mainPosition) ||
+            this.getters.getCell(mainPosition)?.content);
+    }
     getColMaxWidth(sheetId, index) {
         const cellsPositions = positions(this.getters.getColsZone(sheetId, index, index));
         const sizes = cellsPositions.map((position) => this.getCellWidth({ sheetId, ...position }));
@@ -51093,6 +51205,16 @@ class ImageProvider {
     }
 }
 
+class FocusableElement {
+    focusableElement = undefined;
+    setFocusableElement(element) {
+        this.focusableElement = element;
+    }
+    focus() {
+        this.focusableElement?.focus();
+    }
+}
+
 const RIPPLE_KEY_FRAMES = [
     { transform: "scale(0)" },
     { transform: "scale(0.8)", offset: 0.33 },
@@ -53247,6 +53369,7 @@ class Spreadsheet extends Component {
             toggleSidePanel: this.toggleSidePanel.bind(this),
             clipboard: this.env.clipboard || instantiateClipboard(),
             startCellEdition: (content) => this.onGridComposerCellFocused(content),
+            focusableElement: new FocusableElement(),
         });
         useEffect(() => {
             /**
@@ -53365,16 +53488,17 @@ class Spreadsheet extends Component {
         }
         this.composer.topBarFocus = "contentFocus";
         this.composer.gridFocusMode = "inactive";
-        this.setComposerContent({ selection } || {});
+        this.setComposerContent({ selection });
     }
-    onGridComposerContentFocused() {
+    onGridComposerContentFocused(selection) {
         if (this.model.getters.isReadonly()) {
             return;
         }
         this.composer.topBarFocus = "inactive";
         this.composer.gridFocusMode = "contentFocus";
-        this.setComposerContent({});
+        this.setComposerContent({ selection });
     }
+    // TODO: either both are defined or none of them. change those args to an object
     onGridComposerCellFocused(content, selection) {
         if (this.model.getters.isReadonly()) {
             return;
@@ -54802,8 +54926,8 @@ class SelectionStreamProcessorImpl {
         let currentPosition = startPosition;
         // If both the current cell and the next cell are not empty, we want to go to the end of the cluster
         const nextCellPosition = this.getNextCellPosition(startPosition, dim, dir);
-        let mode = !this.getters.isCellEmpty({ ...currentPosition, sheetId }) &&
-            !this.getters.isCellEmpty({ ...nextCellPosition, sheetId })
+        let mode = !this.getters.isEvaluatedCellEmpty({ ...currentPosition, sheetId }) &&
+            !this.getters.isEvaluatedCellEmpty({ ...nextCellPosition, sheetId })
             ? "endOfCluster"
             : "nextCluster";
         while (true) {
@@ -54813,7 +54937,7 @@ class SelectionStreamProcessorImpl {
                 currentPosition.row === nextCellPosition.row) {
                 break;
             }
-            const isNextCellEmpty = this.getters.isCellEmpty({ ...nextCellPosition, sheetId });
+            const isNextCellEmpty = this.getters.isEvaluatedCellEmpty({ ...nextCellPosition, sheetId });
             if (mode === "endOfCluster" && isNextCellEmpty) {
                 break;
             }
@@ -57062,6 +57186,6 @@ const constants = {
 export { AbstractChart, CellErrorType, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, UIPlugin, __info__, addFunction, astToFormula, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, tokenize };
 
 
-__info__.version = "17.1.3";
-__info__.date = "2024-02-02T13:46:54.332Z";
-__info__.hash = "798f979";
+__info__.version = "17.1.5";
+__info__.date = "2024-02-16T14:23:54.651Z";
+__info__.hash = "29d8ad6";