@odoo/o-spreadsheet 17.1.22 → 17.1.23

package/dist/o-spreadsheet.cjs.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.1.22
- * @date 2024-07-08T05:41:57.737Z
- * @hash da27a94
+ * @version 17.1.23
+ * @date 2024-07-11T06:37:01.931Z
+ * @hash 31e8450
  */
 
 'use strict';
@@ -546,7 +546,7 @@ function getAddHeaderStartIndex(position, base) {
 /**
  * Compares two objects.
  */
-function deepEquals(o1, o2, ignoreFunctions) {
+function deepEquals(o1, o2) {
     if (o1 === o2)
         return true;
     if ((o1 && !o2) || (o2 && !o1))
@@ -562,17 +562,13 @@ function deepEquals(o1, o2, ignoreFunctions) {
         }
     }
     for (const key in o1) {
-        const typeOfO1Key = typeof o1[key];
-        if (typeOfO1Key !== typeof o2[key])
+        if (typeof o1[key] !== typeof o2[key])
             return false;
-        if (typeOfO1Key === "object") {
-            if (!deepEquals(o1[key], o2[key], ignoreFunctions))
+        if (typeof o1[key] === "object") {
+            if (!deepEquals(o1[key], o2[key]))
                 return false;
         }
         else {
-            if (ignoreFunctions && typeOfO1Key === "function") {
-                continue;
-            }
             if (o1[key] !== o2[key])
                 return false;
         }
@@ -643,11 +639,9 @@ class JetSet extends Set {
         return this;
     }
     deleteMany(iterable) {
-        let wasDeleted = false;
         for (const element of iterable) {
-            wasDeleted ||= super.delete(element);
+            super.delete(element);
         }
-        return wasDeleted;
     }
 }
 /**
@@ -2595,6 +2589,9 @@ function getPredicate(descr, isQuery, locale) {
     return result;
 }
 function operandToRegExp(operand) {
+    if (operand === "*") {
+        return /.+/;
+    }
     let exp = "";
     let predecessor = "";
     for (let char of operand) {
@@ -2618,9 +2615,9 @@ function operandToRegExp(operand) {
     }
     return new RegExp("^" + exp + "$", "i");
 }
-function evaluatePredicate(value, criterion) {
+function evaluatePredicate(value = "", criterion) {
     const { operator, operand } = criterion;
-    if (value === undefined || operand === undefined || value === null || operand === null) {
+    if (operand === undefined || value === null || operand === null) {
         return false;
     }
     if (typeof operand === "number" && operator === "=") {
@@ -4854,7 +4851,6 @@ class ChartJsComponent extends owl.Component {
     };
     canvas = owl.useRef("graphContainer");
     chart;
-    currentRuntime;
     get background() {
         return this.chartRuntime.background;
     }
@@ -4871,18 +4867,11 @@ class ChartJsComponent extends owl.Component {
     setup() {
         owl.onMounted(() => {
             const runtime = this.chartRuntime;
-            this.currentRuntime = runtime;
             // Note: chartJS modify the runtime in place, so it's important to give it a copy
             this.createChart(deepCopy(runtime.chartJsConfig));
         });
         owl.onWillUnmount(() => this.chart?.destroy());
-        owl.useEffect(() => {
-            const runtime = this.chartRuntime;
-            if (!deepEquals(runtime, this.currentRuntime, "ignoreFunctions")) {
-                this.currentRuntime = runtime;
-                this.updateChartJs(deepCopy(runtime));
-            }
-        });
+        owl.useEffect(() => this.updateChartJs(deepCopy(this.chartRuntime)), () => [this.chartRuntime]);
     }
     createChart(chartData) {
         const canvas = this.canvas.el;
@@ -8480,7 +8469,7 @@ function truncateLabel(label) {
 /**
  * Get a default chart js configuration
  */
-function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, truncateLabels }) {
+function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, truncateLabels = true }) {
     const options = {
         // https://www.chartjs.org/docs/latest/general/responsive.html
         responsive: true,
@@ -42160,6 +42149,7 @@ class Evaluator {
         }
         finally {
             this.cellsBeingComputed.delete(cellId);
+            this.nextPositionsToUpdate.delete(positionId);
         }
     }
     computeAndSave(position) {
@@ -42188,11 +42178,36 @@ class Evaluator {
         forEachSpreadPositionInMatrix(nbColumns, nbRows, 
         // thanks to the isMatrix check above, we know that formulaReturn is MatrixFunctionReturn
         this.spreadValues(formulaPosition, formulaReturn));
+        this.invalidatePositionsDependingOnSpread(formulaPosition, nbColumns, nbRows);
         return createEvaluatedCell(formulaReturn[0][0].value, {
             format: cellData.format || formulaReturn[0][0]?.format,
             locale: this.getters.getLocale(),
         }, formulaReturn[0][0].message);
     }
+    invalidatePositionsDependingOnSpread(arrayFormulaPosition, nbColumns, nbRows) {
+        // the result matrix is split in 2 zones to exclude the array formula position
+        const top = arrayFormulaPosition.row;
+        const left = arrayFormulaPosition.col;
+        const bottom = top + nbRows - 1;
+        const leftColumnZone = {
+            top: top + 1,
+            bottom,
+            left,
+            right: left,
+        };
+        const rightPartZone = {
+            top,
+            bottom,
+            left: left + 1,
+            right: left + nbColumns - 1,
+        };
+        const sheetId = arrayFormulaPosition.sheetId;
+        const invalidatedPositions = this.formulaDependencies().getCellsDependingOn([
+            { sheetId, zone: rightPartZone },
+            { sheetId, zone: leftColumnZone },
+        ]);
+        this.nextPositionsToUpdate.addMany(invalidatedPositions);
+    }
     assertSheetHasEnoughSpaceToSpreadFormulaResult({ sheetId, col, row }, matrixResult) {
         const numberOfCols = this.getters.getNumberCols(sheetId);
         const numberOfRows = this.getters.getNumberRows(sheetId);
@@ -42241,9 +42256,6 @@ class Evaluator {
             }, matrixResult[i][j].message);
             const positionId = this.encoder.encode(position);
             this.setEvaluatedCell(positionId, evaluatedCell);
-            // check if formula dependencies present in the spread zone
-            // if so, they need to be recomputed
-            this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([positionId]));
         };
     }
     invalidateSpreading(positionId) {
@@ -57867,6 +57879,6 @@ exports.setTranslationMethod = setTranslationMethod;
 exports.tokenize = tokenize;
 
 
-__info__.version = "17.1.22";
-__info__.date = "2024-07-08T05:41:57.737Z";
-__info__.hash = "da27a94";
+__info__.version = "17.1.23";
+__info__.date = "2024-07-11T06:37:01.931Z";
+__info__.hash = "31e8450";

package/dist/o-spreadsheet.d.ts

@@ -985,7 +985,7 @@ declare function lazy<T>(fn: (() => T) | T): Lazy<T>;
 /**
  * Compares two objects.
  */
-declare function deepEquals(o1: any, o2: any, ignoreFunctions?: "ignoreFunctions"): boolean;
+declare function deepEquals(o1: any, o2: any): boolean;
 
 interface ConstructorArgs {
     readonly zone: Readonly<Zone | UnboundedZone>;
@@ -6257,7 +6257,6 @@ declare class ChartJsComponent extends Component<Props$B, SpreadsheetChildEnv> {
     };
     private canvas;
     private chart?;
-    private currentRuntime;
     get background(): string;
     get canvasStyle(): string;
     get chartRuntime(): ChartJSRuntime;

package/dist/o-spreadsheet.esm.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.1.22
- * @date 2024-07-08T05:41:57.737Z
- * @hash da27a94
+ * @version 17.1.23
+ * @date 2024-07-11T06:37:01.931Z
+ * @hash 31e8450
  */
 
 import { Component, useRef, onMounted, onWillUnmount, useEffect, onWillPatch, useState, onWillUpdateProps, onPatched, useComponent, useExternalListener, onWillStart, xml, useChildSubEnv, useSubEnv, markRaw } from '@odoo/owl';
@@ -544,7 +544,7 @@ function getAddHeaderStartIndex(position, base) {
 /**
  * Compares two objects.
  */
-function deepEquals(o1, o2, ignoreFunctions) {
+function deepEquals(o1, o2) {
     if (o1 === o2)
         return true;
     if ((o1 && !o2) || (o2 && !o1))
@@ -560,17 +560,13 @@ function deepEquals(o1, o2, ignoreFunctions) {
         }
     }
     for (const key in o1) {
-        const typeOfO1Key = typeof o1[key];
-        if (typeOfO1Key !== typeof o2[key])
+        if (typeof o1[key] !== typeof o2[key])
             return false;
-        if (typeOfO1Key === "object") {
-            if (!deepEquals(o1[key], o2[key], ignoreFunctions))
+        if (typeof o1[key] === "object") {
+            if (!deepEquals(o1[key], o2[key]))
                 return false;
         }
         else {
-            if (ignoreFunctions && typeOfO1Key === "function") {
-                continue;
-            }
             if (o1[key] !== o2[key])
                 return false;
         }
@@ -641,11 +637,9 @@ class JetSet extends Set {
         return this;
     }
     deleteMany(iterable) {
-        let wasDeleted = false;
         for (const element of iterable) {
-            wasDeleted ||= super.delete(element);
+            super.delete(element);
         }
-        return wasDeleted;
     }
 }
 /**
@@ -2593,6 +2587,9 @@ function getPredicate(descr, isQuery, locale) {
     return result;
 }
 function operandToRegExp(operand) {
+    if (operand === "*") {
+        return /.+/;
+    }
     let exp = "";
     let predecessor = "";
     for (let char of operand) {
@@ -2616,9 +2613,9 @@ function operandToRegExp(operand) {
     }
     return new RegExp("^" + exp + "$", "i");
 }
-function evaluatePredicate(value, criterion) {
+function evaluatePredicate(value = "", criterion) {
     const { operator, operand } = criterion;
-    if (value === undefined || operand === undefined || value === null || operand === null) {
+    if (operand === undefined || value === null || operand === null) {
         return false;
     }
     if (typeof operand === "number" && operator === "=") {
@@ -4852,7 +4849,6 @@ class ChartJsComponent extends Component {
     };
     canvas = useRef("graphContainer");
     chart;
-    currentRuntime;
     get background() {
         return this.chartRuntime.background;
     }
@@ -4869,18 +4865,11 @@ class ChartJsComponent extends Component {
     setup() {
         onMounted(() => {
             const runtime = this.chartRuntime;
-            this.currentRuntime = runtime;
             // Note: chartJS modify the runtime in place, so it's important to give it a copy
             this.createChart(deepCopy(runtime.chartJsConfig));
         });
         onWillUnmount(() => this.chart?.destroy());
-        useEffect(() => {
-            const runtime = this.chartRuntime;
-            if (!deepEquals(runtime, this.currentRuntime, "ignoreFunctions")) {
-                this.currentRuntime = runtime;
-                this.updateChartJs(deepCopy(runtime));
-            }
-        });
+        useEffect(() => this.updateChartJs(deepCopy(this.chartRuntime)), () => [this.chartRuntime]);
     }
     createChart(chartData) {
         const canvas = this.canvas.el;
@@ -8478,7 +8467,7 @@ function truncateLabel(label) {
 /**
  * Get a default chart js configuration
  */
-function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, truncateLabels }) {
+function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, truncateLabels = true }) {
     const options = {
         // https://www.chartjs.org/docs/latest/general/responsive.html
         responsive: true,
@@ -42158,6 +42147,7 @@ class Evaluator {
         }
         finally {
             this.cellsBeingComputed.delete(cellId);
+            this.nextPositionsToUpdate.delete(positionId);
         }
     }
     computeAndSave(position) {
@@ -42186,11 +42176,36 @@ class Evaluator {
         forEachSpreadPositionInMatrix(nbColumns, nbRows, 
         // thanks to the isMatrix check above, we know that formulaReturn is MatrixFunctionReturn
         this.spreadValues(formulaPosition, formulaReturn));
+        this.invalidatePositionsDependingOnSpread(formulaPosition, nbColumns, nbRows);
         return createEvaluatedCell(formulaReturn[0][0].value, {
             format: cellData.format || formulaReturn[0][0]?.format,
             locale: this.getters.getLocale(),
         }, formulaReturn[0][0].message);
     }
+    invalidatePositionsDependingOnSpread(arrayFormulaPosition, nbColumns, nbRows) {
+        // the result matrix is split in 2 zones to exclude the array formula position
+        const top = arrayFormulaPosition.row;
+        const left = arrayFormulaPosition.col;
+        const bottom = top + nbRows - 1;
+        const leftColumnZone = {
+            top: top + 1,
+            bottom,
+            left,
+            right: left,
+        };
+        const rightPartZone = {
+            top,
+            bottom,
+            left: left + 1,
+            right: left + nbColumns - 1,
+        };
+        const sheetId = arrayFormulaPosition.sheetId;
+        const invalidatedPositions = this.formulaDependencies().getCellsDependingOn([
+            { sheetId, zone: rightPartZone },
+            { sheetId, zone: leftColumnZone },
+        ]);
+        this.nextPositionsToUpdate.addMany(invalidatedPositions);
+    }
     assertSheetHasEnoughSpaceToSpreadFormulaResult({ sheetId, col, row }, matrixResult) {
         const numberOfCols = this.getters.getNumberCols(sheetId);
         const numberOfRows = this.getters.getNumberRows(sheetId);
@@ -42239,9 +42254,6 @@ class Evaluator {
             }, matrixResult[i][j].message);
             const positionId = this.encoder.encode(position);
             this.setEvaluatedCell(positionId, evaluatedCell);
-            // check if formula dependencies present in the spread zone
-            // if so, they need to be recomputed
-            this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([positionId]));
         };
     }
     invalidateSpreading(positionId) {
@@ -57829,6 +57841,6 @@ const constants = {
 export { AbstractChart, CellErrorType, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, UIPlugin, __info__, addFunction, astToFormula, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, tokenize };
 
 
-__info__.version = "17.1.22";
-__info__.date = "2024-07-08T05:41:57.737Z";
-__info__.hash = "da27a94";
+__info__.version = "17.1.23";
+__info__.date = "2024-07-11T06:37:01.931Z";
+__info__.hash = "31e8450";

package/dist/o-spreadsheet.iife.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.1.22
- * @date 2024-07-08T05:41:57.737Z
- * @hash da27a94
+ * @version 17.1.23
+ * @date 2024-07-11T06:37:01.931Z
+ * @hash 31e8450
  */
 
 (function (exports, owl) {
@@ -545,7 +545,7 @@
   /**
    * Compares two objects.
    */
-  function deepEquals(o1, o2, ignoreFunctions) {
+  function deepEquals(o1, o2) {
       if (o1 === o2)
           return true;
       if ((o1 && !o2) || (o2 && !o1))
@@ -561,17 +561,13 @@
           }
       }
       for (const key in o1) {
-          const typeOfO1Key = typeof o1[key];
-          if (typeOfO1Key !== typeof o2[key])
+          if (typeof o1[key] !== typeof o2[key])
               return false;
-          if (typeOfO1Key === "object") {
-              if (!deepEquals(o1[key], o2[key], ignoreFunctions))
+          if (typeof o1[key] === "object") {
+              if (!deepEquals(o1[key], o2[key]))
                   return false;
           }
           else {
-              if (ignoreFunctions && typeOfO1Key === "function") {
-                  continue;
-              }
               if (o1[key] !== o2[key])
                   return false;
           }
@@ -642,11 +638,9 @@
           return this;
       }
       deleteMany(iterable) {
-          let wasDeleted = false;
           for (const element of iterable) {
-              wasDeleted ||= super.delete(element);
+              super.delete(element);
           }
-          return wasDeleted;
       }
   }
   /**
@@ -2594,6 +2588,9 @@
       return result;
   }
   function operandToRegExp(operand) {
+      if (operand === "*") {
+          return /.+/;
+      }
       let exp = "";
       let predecessor = "";
       for (let char of operand) {
@@ -2617,9 +2614,9 @@
       }
       return new RegExp("^" + exp + "$", "i");
   }
-  function evaluatePredicate(value, criterion) {
+  function evaluatePredicate(value = "", criterion) {
       const { operator, operand } = criterion;
-      if (value === undefined || operand === undefined || value === null || operand === null) {
+      if (operand === undefined || value === null || operand === null) {
           return false;
       }
       if (typeof operand === "number" && operator === "=") {
@@ -4853,7 +4850,6 @@
       };
       canvas = owl.useRef("graphContainer");
       chart;
-      currentRuntime;
       get background() {
           return this.chartRuntime.background;
       }
@@ -4870,18 +4866,11 @@
       setup() {
           owl.onMounted(() => {
               const runtime = this.chartRuntime;
-              this.currentRuntime = runtime;
               // Note: chartJS modify the runtime in place, so it's important to give it a copy
               this.createChart(deepCopy(runtime.chartJsConfig));
           });
           owl.onWillUnmount(() => this.chart?.destroy());
-          owl.useEffect(() => {
-              const runtime = this.chartRuntime;
-              if (!deepEquals(runtime, this.currentRuntime, "ignoreFunctions")) {
-                  this.currentRuntime = runtime;
-                  this.updateChartJs(deepCopy(runtime));
-              }
-          });
+          owl.useEffect(() => this.updateChartJs(deepCopy(this.chartRuntime)), () => [this.chartRuntime]);
       }
       createChart(chartData) {
           const canvas = this.canvas.el;
@@ -8479,7 +8468,7 @@
   /**
    * Get a default chart js configuration
    */
-  function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, truncateLabels }) {
+  function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, truncateLabels = true }) {
       const options = {
           // https://www.chartjs.org/docs/latest/general/responsive.html
           responsive: true,
@@ -42159,6 +42148,7 @@
           }
           finally {
               this.cellsBeingComputed.delete(cellId);
+              this.nextPositionsToUpdate.delete(positionId);
           }
       }
       computeAndSave(position) {
@@ -42187,11 +42177,36 @@
           forEachSpreadPositionInMatrix(nbColumns, nbRows, 
           // thanks to the isMatrix check above, we know that formulaReturn is MatrixFunctionReturn
           this.spreadValues(formulaPosition, formulaReturn));
+          this.invalidatePositionsDependingOnSpread(formulaPosition, nbColumns, nbRows);
           return createEvaluatedCell(formulaReturn[0][0].value, {
               format: cellData.format || formulaReturn[0][0]?.format,
               locale: this.getters.getLocale(),
           }, formulaReturn[0][0].message);
       }
+      invalidatePositionsDependingOnSpread(arrayFormulaPosition, nbColumns, nbRows) {
+          // the result matrix is split in 2 zones to exclude the array formula position
+          const top = arrayFormulaPosition.row;
+          const left = arrayFormulaPosition.col;
+          const bottom = top + nbRows - 1;
+          const leftColumnZone = {
+              top: top + 1,
+              bottom,
+              left,
+              right: left,
+          };
+          const rightPartZone = {
+              top,
+              bottom,
+              left: left + 1,
+              right: left + nbColumns - 1,
+          };
+          const sheetId = arrayFormulaPosition.sheetId;
+          const invalidatedPositions = this.formulaDependencies().getCellsDependingOn([
+              { sheetId, zone: rightPartZone },
+              { sheetId, zone: leftColumnZone },
+          ]);
+          this.nextPositionsToUpdate.addMany(invalidatedPositions);
+      }
       assertSheetHasEnoughSpaceToSpreadFormulaResult({ sheetId, col, row }, matrixResult) {
           const numberOfCols = this.getters.getNumberCols(sheetId);
           const numberOfRows = this.getters.getNumberRows(sheetId);
@@ -42240,9 +42255,6 @@
               }, matrixResult[i][j].message);
               const positionId = this.encoder.encode(position);
               this.setEvaluatedCell(positionId, evaluatedCell);
-              // check if formula dependencies present in the spread zone
-              // if so, they need to be recomputed
-              this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([positionId]));
           };
       }
       invalidateSpreading(positionId) {
@@ -57866,9 +57878,9 @@
   exports.tokenize = tokenize;
 
 
-  __info__.version = "17.1.22";
-  __info__.date = "2024-07-08T05:41:57.737Z";
-  __info__.hash = "da27a94";
+  __info__.version = "17.1.23";
+  __info__.date = "2024-07-11T06:37:01.931Z";
+  __info__.hash = "31e8450";
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);