@odoo/o-spreadsheet 17.1.16 → 17.1.18

package/dist/o-spreadsheet.iife.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.1.16
- * @date 2024-05-24T11:27:23.083Z
- * @hash 3a41c3a
+ * @version 17.1.18
+ * @date 2024-06-10T09:34:55.045Z
+ * @hash 0e756ce
  */
 
 (function (exports, owl) {
@@ -294,7 +294,10 @@
    * Check if the object is a plain old javascript object.
    */
   function isPlainObject(obj) {
-      return typeof obj === "object" && obj?.constructor === Object;
+      return (typeof obj === "object" &&
+          obj !== null &&
+          // obj.constructor can be undefined when there's no prototype (`Object.create(null, {})`)
+          (obj?.constructor === Object || obj?.constructor === undefined));
   }
   /**
    * Sanitize the name of a sheet, by eventually removing quotes
@@ -2606,7 +2609,7 @@
           return false;
       }
       if (typeof operand === "number" && operator === "=") {
-          return toString(value) === toString(operand);
+          return value.toString() === operand.toString();
       }
       if (operator === "<>" || operator === "=") {
           let result;
@@ -2666,14 +2669,13 @@
       if (countArg % 2 === 1) {
           throw new EvaluationError(_t("Function [[FUNCTION_NAME]] expects criteria_range and criterion to be in pairs."));
       }
-      const dimRow = args[0].length;
-      const dimCol = args[0][0].length;
+      const firstArg = toMatrix(args[0]);
+      const dimRow = firstArg.length;
+      const dimCol = firstArg[0].length;
       let predicates = [];
       for (let i = 0; i < countArg - 1; i += 2) {
-          const criteriaRange = args[i];
-          if (!isMatrix(criteriaRange) ||
-              criteriaRange.length !== dimRow ||
-              criteriaRange[0].length !== dimCol) {
+          const criteriaRange = toMatrix(args[i]);
+          if (criteriaRange.length !== dimRow || criteriaRange[0].length !== dimCol) {
               throw new EvaluationError(_t("Function [[FUNCTION_NAME]] expects criteria_range to have the same dimension"));
           }
           const description = toString(args[i + 1]);
@@ -2683,7 +2685,7 @@
           for (let j = 0; j < dimCol; j++) {
               let validatedPredicates = true;
               for (let k = 0; k < countArg - 1; k += 2) {
-                  const criteriaValue = args[k][i][j].value;
+                  const criteriaValue = toMatrix(args[k])[i][j].value;
                   const criterion = predicates[k / 2];
                   validatedPredicates = evaluatePredicate(criteriaValue ?? undefined, criterion);
                   if (!validatedPredicates) {
@@ -4371,8 +4373,11 @@
   /**
    * Create a range from a xc. If the xc is empty, this function returns undefined.
    */
-  function createRange(getters, sheetId, range) {
-      return range ? getters.getRangeFromSheetXC(sheetId, range) : undefined;
+  function createValidRange(getters, sheetId, xc) {
+      if (!xc)
+          return;
+      const range = getters.getRangeFromSheetXC(sheetId, xc);
+      return !(range.invalidSheetName || range.invalidXc) ? range : undefined;
   }
   /**
    * Spread multiple colrows zone to one row/col zone and add a many new input range as needed.
@@ -5303,8 +5308,8 @@
       type = "scorecard";
       constructor(definition, sheetId, getters) {
           super(definition, sheetId, getters);
-          this.keyValue = createRange(getters, sheetId, definition.keyValue);
-          this.baseline = createRange(getters, sheetId, definition.baseline);
+          this.keyValue = createValidRange(getters, sheetId, definition.keyValue);
+          this.baseline = createValidRange(getters, sheetId, definition.baseline);
           this.baselineMode = definition.baselineMode;
           this.baselineDescr = definition.baselineDescr;
           this.background = definition.background;
@@ -6838,8 +6843,7 @@
    */
   function useSpreadsheetRect() {
       const position = owl.useState({ x: 0, y: 0, width: 0, height: 0 });
-      let spreadsheetElement = document.querySelector(".o-spreadsheet");
-      updatePosition();
+      let spreadsheetElement = null;
       function updatePosition() {
           if (!spreadsheetElement) {
               spreadsheetElement = document.querySelector(".o-spreadsheet");
@@ -8603,7 +8607,7 @@
       if ("chartJsConfig" in runtime) {
           runtime.chartJsConfig.plugins = [backgroundColorChartJSPlugin];
           // @ts-ignore
-          const chart = new window.Chart(canvas, runtime.chartJsConfig);
+          const chart = new window.Chart(canvas, deepCopy(runtime.chartJsConfig));
           const imgContent = chart.toBase64Image();
           chart.destroy();
           div.remove();
@@ -8647,7 +8651,7 @@
       constructor(definition, sheetId, getters) {
           super(definition, sheetId, getters);
           this.dataSets = createDataSets(getters, definition.dataSets, sheetId, definition.dataSetsHaveTitle);
-          this.labelRange = createRange(getters, sheetId, definition.labelRange);
+          this.labelRange = createValidRange(getters, sheetId, definition.labelRange);
           this.background = definition.background;
           this.verticalAxisPosition = definition.verticalAxisPosition;
           this.legendPosition = definition.legendPosition;
@@ -8890,7 +8894,7 @@
       type = "gauge";
       constructor(definition, sheetId, getters) {
           super(definition, sheetId, getters);
-          this.dataRange = createRange(this.getters, this.sheetId, definition.dataRange);
+          this.dataRange = createValidRange(this.getters, this.sheetId, definition.dataRange);
           this.sectionRule = definition.sectionRule;
           this.background = definition.background;
       }
@@ -9224,7 +9228,7 @@
       constructor(definition, sheetId, getters) {
           super(definition, sheetId, getters);
           this.dataSets = createDataSets(this.getters, definition.dataSets, sheetId, definition.dataSetsHaveTitle);
-          this.labelRange = createRange(this.getters, sheetId, definition.labelRange);
+          this.labelRange = createValidRange(this.getters, sheetId, definition.labelRange);
           this.background = definition.background;
           this.verticalAxisPosition = definition.verticalAxisPosition;
           this.legendPosition = definition.legendPosition;
@@ -9544,7 +9548,7 @@
       constructor(definition, sheetId, getters) {
           super(definition, sheetId, getters);
           this.dataSets = createDataSets(getters, definition.dataSets, sheetId, definition.dataSetsHaveTitle);
-          this.labelRange = createRange(getters, sheetId, definition.labelRange);
+          this.labelRange = createValidRange(getters, sheetId, definition.labelRange);
           this.background = definition.background;
           this.legendPosition = definition.legendPosition;
           this.aggregated = definition.aggregated;
@@ -11188,6 +11192,9 @@
       if (types.some((t) => t.startsWith("RANGE"))) {
           result.acceptMatrix = true;
       }
+      if (types.every((t) => t.startsWith("RANGE"))) {
+          result.acceptMatrixOnly = true;
+      }
       return result;
   }
   /**
@@ -11469,11 +11476,16 @@
       compute: function (array, ...columns) {
           const _array = toMatrix(array);
           const _columns = flattenRowFirst(columns, (item) => toInteger(item?.value, this.locale));
-          assert(() => _columns.every((col) => col > 0 && col <= _array.length), _t("The columns arguments must be between 1 and %s (got %s).", _array.length.toString(), (_columns.find((col) => col <= 0 || col > _array.length) || 0).toString()));
+          const argOutOfRange = _columns.filter((col) => col === 0 || _array.length < Math.abs(col));
+          assert(() => argOutOfRange.length === 0, _t("The columns arguments must be between -%s and %s (got %s), excluding 0.", _array.length.toString(), _array.length.toString(), argOutOfRange.join(",")));
           const result = Array(_columns.length);
           for (let col = 0; col < _columns.length; col++) {
-              const colIndex = _columns[col] - 1; // -1 because columns arguments are 1-indexed
-              result[col] = _array[colIndex];
+              if (_columns[col] > 0) {
+                  result[col] = _array[_columns[col] - 1]; // -1 because columns arguments are 1-indexed
+              }
+              else {
+                  result[col] = _array[_array.length + _columns[col]];
+              }
           }
           return result;
       },
@@ -11494,8 +11506,14 @@
           const _array = toMatrix(array);
           const _rows = flattenRowFirst(rows, (item) => toInteger(item?.value, this.locale));
           const _nbColumns = _array.length;
-          assert(() => _rows.every((row) => row > 0 && row <= _array[0].length), _t("The rows arguments must be between 1 and %s (got %s).", _array[0].length.toString(), (_rows.find((row) => row <= 0 || row > _array[0].length) || 0).toString()));
-          return generateMatrix(_nbColumns, _rows.length, (col, row) => _array[col][_rows[row] - 1]); // -1 because rows arguments are 1-indexed
+          const argOutOfRange = _rows.filter((row) => row === 0 || _array[0].length < Math.abs(row));
+          assert(() => argOutOfRange.length === 0, _t("The rows arguments must be between -%s and %s (got %s), excluding 0.", _array[0].length.toString(), _array[0].length.toString(), argOutOfRange.join(",")));
+          return generateMatrix(_nbColumns, _rows.length, (col, row) => {
+              if (_rows[row] > 0) {
+                  return _array[col][_rows[row] - 1]; // -1 because columns arguments are 1-indexed
+              }
+              return _array[col][_array[col].length + _rows[row]];
+          });
       },
       isExported: true,
   };
@@ -12403,7 +12421,7 @@
       compute: function (range, ...args) {
           let uniqueValues = new Set();
           visitMatchingRanges(args, (i, j) => {
-              const data = range[i][j];
+              const data = range[i]?.[j];
               if (isDefined(data)) {
                   uniqueValues.add(data.value);
               }
@@ -13033,7 +13051,7 @@
           }
           let sum = 0;
           visitMatchingRanges([criteriaRange, criterion], (i, j) => {
-              const value = sumRange[i][j].value;
+              const value = sumRange[i]?.[j]?.value;
               if (typeof value === "number") {
                   sum += value;
               }
@@ -13058,7 +13076,7 @@
       compute: function (sumRange, ...criters) {
           let sum = 0;
           visitMatchingRanges(criters, (i, j) => {
-              const value = sumRange[i][j].value;
+              const value = sumRange[i]?.[j]?.value;
               if (typeof value === "number") {
                   sum += value;
               }
@@ -13605,7 +13623,7 @@
           let count = 0;
           let sum = 0;
           visitMatchingRanges([criteriaRange, criterion], (i, j) => {
-              const value = _averageRange[i][j].value;
+              const value = _averageRange[i]?.[j]?.value;
               if (typeof value === "number") {
                   count += 1;
                   sum += value;
@@ -13634,7 +13652,7 @@
           let count = 0;
           let sum = 0;
           visitMatchingRanges(args, (i, j) => {
-              const value = _averageRange[i][j].value;
+              const value = _averageRange[i]?.[j]?.value;
               if (typeof value === "number") {
                   count += 1;
                   sum += value;
@@ -13939,7 +13957,7 @@
       compute: function (range, ...args) {
           let result = -Infinity;
           visitMatchingRanges(args, (i, j) => {
-              const value = range[i][j].value;
+              const value = range[i]?.[j]?.value;
               if (typeof value === "number") {
                   result = result < value ? value : result;
               }
@@ -14022,7 +14040,7 @@
       compute: function (range, ...args) {
           let result = Infinity;
           visitMatchingRanges(args, (i, j) => {
-              const value = range[i][j].value;
+              const value = range[i]?.[j]?.value;
               if (typeof value === "number") {
                   result = result > value ? value : result;
               }
@@ -19799,6 +19817,9 @@
                   }
                   args[i] = arg[0][0];
               }
+              if (!isMatrix(arg) && argDefinition.acceptMatrixOnly) {
+                  throw new BadExpressionError(_t("Function [[FUNCTION_NAME]] expects the parameter '%s' to be reference to a cell or range.", (i + 1).toString()));
+              }
           }
           return descr.compute.apply(this, args);
       }
@@ -22151,7 +22172,7 @@
           }
           const getters = this.env.model.getters;
           const sheetId = getters.getActiveSheetId();
-          const labelRange = createRange(getters, sheetId, this.labelRange);
+          const labelRange = createValidRange(getters, sheetId, this.labelRange);
           const dataSets = createDataSets(getters, this.dataSeriesRanges, sheetId, this.props.definition.dataSetsHaveTitle);
           if (dataSets.length) {
               return dataSets[0].dataRange.zone.top + 1;
@@ -26274,14 +26295,14 @@
       }
       onKeyDown(ev) {
           const figure = this.props.figure;
-          switch (ev.key) {
+          const keyDownShortcut = keyboardEventToShortcutString(ev);
+          switch (keyDownShortcut) {
               case "Delete":
                   this.env.model.dispatch("DELETE_FIGURE", {
                       sheetId: this.env.model.getters.getActiveSheetId(),
                       id: figure.id,
                   });
                   this.props.onFigureDeleted();
-                  ev.stopPropagation();
                   ev.preventDefault();
                   ev.stopPropagation();
                   break;
@@ -26302,7 +26323,22 @@
                       x: figure.x + delta[0],
                       y: figure.y + delta[1],
                   });
+                  ev.preventDefault();
                   ev.stopPropagation();
+                  break;
+              case "Ctrl+A":
+                  // Maybe in the future we will implement a way to select all figures
+                  ev.preventDefault();
+                  ev.stopPropagation();
+                  break;
+              case "Ctrl+Y":
+              case "Ctrl+Z":
+                  if (keyDownShortcut === "Ctrl+Y") {
+                      this.env.model.dispatch("REQUEST_REDO");
+                  }
+                  else if (keyDownShortcut === "Ctrl+Z") {
+                      this.env.model.dispatch("REQUEST_UNDO");
+                  }
                   ev.preventDefault();
                   ev.stopPropagation();
                   break;
@@ -27340,8 +27376,15 @@
       }
       onPaste(ev) {
           if (this.env.model.getters.getEditionMode() !== "inactive") {
+              // let the browser clipboard work
               ev.stopPropagation();
           }
+          else {
+              // the user meant to paste in the sheet, not open the composer with the pasted content
+              // While we're not editing, we still have the focus and should therefore prevent
+              // the native "paste" to occur.
+              ev.preventDefault();
+          }
       }
       /*
        * Triggered automatically by the content-editable between the keydown and key up
@@ -27350,10 +27393,6 @@
           if (!this.shouldProcessInputEvents) {
               return;
           }
-          if (ev.inputType === "insertFromPaste" &&
-              this.env.model.getters.getEditionMode() === "inactive") {
-              return;
-          }
           ev.stopPropagation();
           let content;
           if (this.env.model.getters.getEditionMode() === "inactive") {
@@ -27794,10 +27833,7 @@
       }
       get containerStyle() {
           if (this.env.model.getters.getEditionMode() === "inactive" || !this.rect) {
-              return `
-        position: absolute;
-        z-index: -1000;
-      `;
+              return `z-index: -1000;`;
           }
           const isFormula = this.env.model.getters.getCurrentContent().startsWith("=");
           const cell = this.env.model.getters.getActiveCell();
@@ -35763,12 +35799,6 @@
                   // detect when an argument need to be evaluated as a meta argument
                   const isMeta = argTypes.includes("META");
                   const hasRange = argTypes.some((t) => isRangeType(t));
-                  const isRangeOnly = argTypes.every((t) => isRangeType(t));
-                  if (isRangeOnly) {
-                      if (!isRangeInput(currentArg)) {
-                          throw new BadExpressionError(_t("Function %s expects the parameter %s to be reference to a cell or range, not a %s.", functionName, (i + 1).toString(), currentArg.type.toLowerCase()));
-                      }
-                  }
                   compiledArgs.push(compileAST(currentArg, isMeta, hasRange, {
                       functionName,
                       paramIndex: i + 1,
@@ -35939,16 +35969,6 @@
   function isRangeType(type) {
       return type.startsWith("RANGE");
   }
-  function isRangeInput(arg) {
-      if (arg.type === "REFERENCE") {
-          return true;
-      }
-      if (arg.type === "FUNCALL") {
-          const fnDef = functions$1[arg.value.toUpperCase()];
-          return fnDef && isRangeType(fnDef.returns[0]);
-      }
-      return false;
-  }
 
   /**
    * Add the following information on tokens:
@@ -39061,6 +39081,9 @@
           if (range.invalidXc) {
               return range.invalidXc;
           }
+          if (!this.getters.tryGetSheet(range.sheetId)) {
+              return CellErrorType.InvalidReference;
+          }
           if (range.zone.bottom - range.zone.top < 0 || range.zone.right - range.zone.left < 0) {
               return CellErrorType.InvalidReference;
           }
@@ -42508,16 +42531,22 @@
               let newContent = undefined;
               let newFormat = undefined;
               let isExported = true;
+              const exportedSheetData = data.sheets.find((sheet) => sheet.id === position.sheetId);
               const formulaCell = this.getCorrespondingFormulaCell(position);
               if (formulaCell) {
                   isExported = isExportableToExcel(formulaCell.compiledFormula.tokens);
                   isFormula = isExported;
                   if (!isExported) {
-                      newContent = value.toString();
-                      newFormat = evaluatedCell.format;
+                      // If the cell contains a non-exported formula and that is evaluates to
+                      // nothing* ,we don't export it.
+                      // * non-falsy value are relevant and so are 0 and FALSE, which only leaves
+                      // the empty string.
+                      if (value !== "") {
+                          newContent = value.toString();
+                          newFormat = evaluatedCell.format;
+                      }
                   }
               }
-              const exportedSheetData = data.sheets.find((sheet) => sheet.id === position.sheetId);
               const exportedCellData = exportedSheetData.cells[xc] || {};
               const format = newFormat
                   ? getItemId(newFormat, data.formats)
@@ -52014,9 +52043,11 @@
           if (ev.key === "Enter") {
               ev.preventDefault();
               this.stopEdition();
+              this.env.focusableElement.focus();
           }
           if (ev.key === "Escape") {
               this.cancelEdition();
+              this.env.focusableElement.focus();
           }
       }
       onClickSheetName(ev) {
@@ -56711,7 +56742,11 @@
                   let cellNode = escapeXml ``;
                   // Either formula or static value inside the cell
                   if (cell.isFormula) {
-                      ({ attrs: additionalAttrs, node: cellNode } = addFormula(cell));
+                      const res = addFormula(cell);
+                      if (!res) {
+                          continue;
+                      }
+                      ({ attrs: additionalAttrs, node: cellNode } = res);
                   }
                   else if (cell.content && isMarkdownLink(cell.content)) {
                       const { label } = parseMarkdownLink(cell.content);
@@ -57741,9 +57776,9 @@
   exports.tokenize = tokenize;
 
 
-  __info__.version = "17.1.16";
-  __info__.date = "2024-05-24T11:27:23.083Z";
-  __info__.hash = "3a41c3a";
+  __info__.version = "17.1.18";
+  __info__.date = "2024-06-10T09:34:55.045Z";
+  __info__.hash = "0e756ce";
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);