@odoo/o-spreadsheet 17.0.39 → 17.0.41

package/dist/o-spreadsheet.cjs.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.0.39
- * @date 2024-11-08T12:12:25.844Z
- * @hash 454752f
+ * @version 17.0.41
+ * @date 2024-11-22T14:15:39.629Z
+ * @hash 23f8fc3
  */
 
 'use strict';
@@ -2797,7 +2797,9 @@ function linearSearch(data, target, mode, numberOfValues, getValueInData, revers
             }
         }
     }
-    return reverseSearch ? numberOfValues - closestMatchIndex - 1 : closestMatchIndex;
+    return reverseSearch && closestMatchIndex !== -1
+        ? numberOfValues - closestMatchIndex - 1
+        : closestMatchIndex;
 }
 /**
  * Normalize a value.
@@ -8490,11 +8492,14 @@ function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, tr
 function getChartLabelFormat(getters, range) {
     if (!range)
         return undefined;
-    return getters.getEvaluatedCell({
-        sheetId: range.sheetId,
-        col: range.zone.left,
-        row: range.zone.top,
-    }).format;
+    const { sheetId, zone: { left, top, bottom }, } = range;
+    for (let row = top; row <= bottom; row++) {
+        const format = getters.getEvaluatedCell({ sheetId, col: left, row }).format;
+        if (format) {
+            return format;
+        }
+    }
+    return undefined;
 }
 function getChartLabelValues(getters, dataSets, labelRange) {
     let labels = { values: [], formattedValues: [] };
@@ -9343,11 +9348,7 @@ function canBeDateChart(labelRange, getters) {
     if (!labelRange || !canBeLinearChart(labelRange, getters)) {
         return false;
     }
-    const labelFormat = getters.getEvaluatedCell({
-        sheetId: labelRange.sheetId,
-        col: labelRange.zone.left,
-        row: labelRange.zone.top,
-    }).format;
+    const labelFormat = getChartLabelFormat(getters, labelRange);
     return Boolean(labelFormat && timeFormatLuxonCompatible.test(labelFormat));
 }
 function canBeLinearChart(labelRange, getters) {
@@ -18733,7 +18734,7 @@ const VLOOKUP = {
             ? dichotomicSearch(range, searchKey?.value, "nextSmaller", "asc", range[0].length, getValueFromRange)
             : linearSearch(range, searchKey?.value, "strict", range[0].length, getValueFromRange);
         const value = range[_index - 1][rowIndex];
-        assertAvailable(value, searchKey);
+        assertAvailable(value, searchKey?.value);
         return value;
     },
     isExported: true,
@@ -18781,7 +18782,7 @@ const XLOOKUP = {
                 : [returnRange[index]];
         }
         const _defaultValue = defaultValue?.();
-        assertAvailable(_defaultValue, searchKey);
+        assertAvailable(_defaultValue, searchKey?.value);
         return [[_defaultValue]];
     },
     isExported: true,
@@ -22269,6 +22270,7 @@ ColorPicker.props = {
     currentColor: { type: String, optional: true },
     maxHeight: { type: Number, optional: true },
     anchorRect: Object,
+    disableNoColor: { type: Boolean, optional: true },
 };
 
 css /* scss */ `
@@ -22335,6 +22337,7 @@ ColorPickerWidget.props = {
     disabled: { type: Boolean, optional: true },
     dropdownMaxHeight: { type: Number, optional: true },
     class: { type: String, optional: true },
+    disableNoColor: { type: Boolean, optional: true },
 };
 
 class LineBarPieDesignPanel extends owl.Component {
@@ -23745,6 +23748,9 @@ class ConditionalFormattingEditor extends owl.Component {
         }
     }
     setColorScaleColor(target, color) {
+        if (!isColorValid(color)) {
+            return;
+        }
         const point = this.state.rules.colorScale[target];
         if (point) {
             point.color = Number.parseInt(color.substr(1), 16);
@@ -41679,7 +41685,7 @@ class Evaluator {
         const arrayFormulas = this.spreadingRelations.getFormulaPositionsSpreadingOn(positionId);
         const cells = new JetSet(arrayFormulas);
         const arrayFormulaPositionId = this.getArrayFormulaSpreadingOnId(positionId);
-        if (arrayFormulaPositionId) {
+        if (arrayFormulaPositionId !== undefined) {
             // ignore the formula spreading on the position. Keep only the blocked ones
             cells.delete(arrayFormulaPositionId);
         }
@@ -41702,9 +41708,15 @@ class Evaluator {
             }
             for (let i = 0; i < positionIds.length; ++i) {
                 const cell = positionIds[i];
+                if (this.nextPositionsToUpdate.has(cell)) {
+                    continue;
+                }
                 this.setEvaluatedCell(cell, this.computeCell(cell));
             }
         }
+        if (currentIteration >= MAX_ITERATION) {
+            console.warn("Maximum iteration reached while evaluating cells");
+        }
     }
     setEvaluatedCell(positionId, evaluatedCell) {
         this.evaluatedCells.set(positionId, evaluatedCell);
@@ -41736,7 +41748,6 @@ class Evaluator {
         }
         finally {
             this.cellsBeingComputed.delete(cellId);
-            this.nextPositionsToUpdate.delete(positionId);
         }
     }
     computeAndSave(position) {
@@ -41806,6 +41817,7 @@ class Evaluator {
             { sheetId, zone: rightPartZone },
             { sheetId, zone: leftColumnZone },
         ]);
+        invalidatedPositions.delete(this.encoder.encode(arrayFormulaPosition));
         this.nextPositionsToUpdate.addMany(invalidatedPositions);
     }
     assertSheetHasEnoughSpaceToSpreadFormulaResult({ sheetId, col, row }, matrixResult) {
@@ -44499,7 +44511,7 @@ class Session extends EventBus {
      * Notify the server that the user client left the collaborative session
      */
     async leave(data) {
-        if (Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
+        if (data && Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
             await this.snapshot(data());
         }
         delete this.clients[this.clientId];
@@ -57154,7 +57166,8 @@ class Model extends EventBus {
         this.session.join(this.config.client);
     }
     async leaveSession() {
-        await this.session.leave(lazy(() => this.exportData()));
+        const snapshot = this.getters.isReadonly() ? undefined : lazy(() => this.exportData());
+        await this.session.leave(snapshot);
     }
     setupUiPlugin(Plugin) {
         const plugin = new Plugin(this.uiPluginConfig);
@@ -57657,6 +57670,6 @@ exports.setTranslationMethod = setTranslationMethod;
 exports.tokenize = tokenize;
 
 
-__info__.version = "17.0.39";
-__info__.date = "2024-11-08T12:12:25.844Z";
-__info__.hash = "454752f";
+__info__.version = "17.0.41";
+__info__.date = "2024-11-22T14:15:39.629Z";
+__info__.hash = "23f8fc3";

package/dist/o-spreadsheet.d.ts

@@ -852,7 +852,7 @@ declare class Session extends EventBus<CollaborativeEvent> {
     /**
      * Notify the server that the user client left the collaborative session
      */
-    leave(data: Lazy<WorkbookData>): Promise<void>;
+    leave(data?: Lazy<WorkbookData>): Promise<void>;
     /**
      * Send a snapshot of the spreadsheet to the collaboration server
      */
@@ -5648,6 +5648,7 @@ interface ColorPickerProps {
     maxHeight?: Pixel;
     onColorPicked: (color: Color) => void;
     currentColor: Color;
+    disableNoColor?: boolean;
 }
 declare class ColorPicker extends Component<ColorPickerProps, SpreadsheetChildEnv> {
     static template: string;
@@ -5690,6 +5691,7 @@ interface Props$H {
     disabled?: boolean;
     dropdownMaxHeight?: Pixel;
     class?: string;
+    disableNoColor?: boolean;
 }
 declare class ColorPickerWidget extends Component<Props$H, SpreadsheetChildEnv> {
     static template: string;

package/dist/o-spreadsheet.esm.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.0.39
- * @date 2024-11-08T12:12:25.844Z
- * @hash 454752f
+ * @version 17.0.41
+ * @date 2024-11-22T14:15:39.629Z
+ * @hash 23f8fc3
  */
 
 import { Component, useRef, onMounted, useEffect, onWillPatch, useState, onWillUpdateProps, onPatched, useComponent, useExternalListener, onWillUnmount, onWillStart, xml, useChildSubEnv, useSubEnv, markRaw } from '@odoo/owl';
@@ -2795,7 +2795,9 @@ function linearSearch(data, target, mode, numberOfValues, getValueInData, revers
             }
         }
     }
-    return reverseSearch ? numberOfValues - closestMatchIndex - 1 : closestMatchIndex;
+    return reverseSearch && closestMatchIndex !== -1
+        ? numberOfValues - closestMatchIndex - 1
+        : closestMatchIndex;
 }
 /**
  * Normalize a value.
@@ -8488,11 +8490,14 @@ function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, tr
 function getChartLabelFormat(getters, range) {
     if (!range)
         return undefined;
-    return getters.getEvaluatedCell({
-        sheetId: range.sheetId,
-        col: range.zone.left,
-        row: range.zone.top,
-    }).format;
+    const { sheetId, zone: { left, top, bottom }, } = range;
+    for (let row = top; row <= bottom; row++) {
+        const format = getters.getEvaluatedCell({ sheetId, col: left, row }).format;
+        if (format) {
+            return format;
+        }
+    }
+    return undefined;
 }
 function getChartLabelValues(getters, dataSets, labelRange) {
     let labels = { values: [], formattedValues: [] };
@@ -9341,11 +9346,7 @@ function canBeDateChart(labelRange, getters) {
     if (!labelRange || !canBeLinearChart(labelRange, getters)) {
         return false;
     }
-    const labelFormat = getters.getEvaluatedCell({
-        sheetId: labelRange.sheetId,
-        col: labelRange.zone.left,
-        row: labelRange.zone.top,
-    }).format;
+    const labelFormat = getChartLabelFormat(getters, labelRange);
     return Boolean(labelFormat && timeFormatLuxonCompatible.test(labelFormat));
 }
 function canBeLinearChart(labelRange, getters) {
@@ -18731,7 +18732,7 @@ const VLOOKUP = {
             ? dichotomicSearch(range, searchKey?.value, "nextSmaller", "asc", range[0].length, getValueFromRange)
             : linearSearch(range, searchKey?.value, "strict", range[0].length, getValueFromRange);
         const value = range[_index - 1][rowIndex];
-        assertAvailable(value, searchKey);
+        assertAvailable(value, searchKey?.value);
         return value;
     },
     isExported: true,
@@ -18779,7 +18780,7 @@ const XLOOKUP = {
                 : [returnRange[index]];
         }
         const _defaultValue = defaultValue?.();
-        assertAvailable(_defaultValue, searchKey);
+        assertAvailable(_defaultValue, searchKey?.value);
         return [[_defaultValue]];
     },
     isExported: true,
@@ -22267,6 +22268,7 @@ ColorPicker.props = {
     currentColor: { type: String, optional: true },
     maxHeight: { type: Number, optional: true },
     anchorRect: Object,
+    disableNoColor: { type: Boolean, optional: true },
 };
 
 css /* scss */ `
@@ -22333,6 +22335,7 @@ ColorPickerWidget.props = {
     disabled: { type: Boolean, optional: true },
     dropdownMaxHeight: { type: Number, optional: true },
     class: { type: String, optional: true },
+    disableNoColor: { type: Boolean, optional: true },
 };
 
 class LineBarPieDesignPanel extends Component {
@@ -23743,6 +23746,9 @@ class ConditionalFormattingEditor extends Component {
         }
     }
     setColorScaleColor(target, color) {
+        if (!isColorValid(color)) {
+            return;
+        }
         const point = this.state.rules.colorScale[target];
         if (point) {
             point.color = Number.parseInt(color.substr(1), 16);
@@ -41677,7 +41683,7 @@ class Evaluator {
         const arrayFormulas = this.spreadingRelations.getFormulaPositionsSpreadingOn(positionId);
         const cells = new JetSet(arrayFormulas);
         const arrayFormulaPositionId = this.getArrayFormulaSpreadingOnId(positionId);
-        if (arrayFormulaPositionId) {
+        if (arrayFormulaPositionId !== undefined) {
             // ignore the formula spreading on the position. Keep only the blocked ones
             cells.delete(arrayFormulaPositionId);
         }
@@ -41700,9 +41706,15 @@ class Evaluator {
             }
             for (let i = 0; i < positionIds.length; ++i) {
                 const cell = positionIds[i];
+                if (this.nextPositionsToUpdate.has(cell)) {
+                    continue;
+                }
                 this.setEvaluatedCell(cell, this.computeCell(cell));
             }
         }
+        if (currentIteration >= MAX_ITERATION) {
+            console.warn("Maximum iteration reached while evaluating cells");
+        }
     }
     setEvaluatedCell(positionId, evaluatedCell) {
         this.evaluatedCells.set(positionId, evaluatedCell);
@@ -41734,7 +41746,6 @@ class Evaluator {
         }
         finally {
             this.cellsBeingComputed.delete(cellId);
-            this.nextPositionsToUpdate.delete(positionId);
         }
     }
     computeAndSave(position) {
@@ -41804,6 +41815,7 @@ class Evaluator {
             { sheetId, zone: rightPartZone },
             { sheetId, zone: leftColumnZone },
         ]);
+        invalidatedPositions.delete(this.encoder.encode(arrayFormulaPosition));
         this.nextPositionsToUpdate.addMany(invalidatedPositions);
     }
     assertSheetHasEnoughSpaceToSpreadFormulaResult({ sheetId, col, row }, matrixResult) {
@@ -44497,7 +44509,7 @@ class Session extends EventBus {
      * Notify the server that the user client left the collaborative session
      */
     async leave(data) {
-        if (Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
+        if (data && Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
             await this.snapshot(data());
         }
         delete this.clients[this.clientId];
@@ -57152,7 +57164,8 @@ class Model extends EventBus {
         this.session.join(this.config.client);
     }
     async leaveSession() {
-        await this.session.leave(lazy(() => this.exportData()));
+        const snapshot = this.getters.isReadonly() ? undefined : lazy(() => this.exportData());
+        await this.session.leave(snapshot);
     }
     setupUiPlugin(Plugin) {
         const plugin = new Plugin(this.uiPluginConfig);
@@ -57620,6 +57633,6 @@ const constants = {
 export { AbstractChart, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, UIPlugin, __info__, addFunction, astToFormula, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, tokenize };
 
 
-__info__.version = "17.0.39";
-__info__.date = "2024-11-08T12:12:25.844Z";
-__info__.hash = "454752f";
+__info__.version = "17.0.41";
+__info__.date = "2024-11-22T14:15:39.629Z";
+__info__.hash = "23f8fc3";

package/dist/o-spreadsheet.iife.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.0.39
- * @date 2024-11-08T12:12:25.844Z
- * @hash 454752f
+ * @version 17.0.41
+ * @date 2024-11-22T14:15:39.629Z
+ * @hash 23f8fc3
  */
 
 (function (exports, owl) {
@@ -2796,7 +2796,9 @@
               }
           }
       }
-      return reverseSearch ? numberOfValues - closestMatchIndex - 1 : closestMatchIndex;
+      return reverseSearch && closestMatchIndex !== -1
+          ? numberOfValues - closestMatchIndex - 1
+          : closestMatchIndex;
   }
   /**
    * Normalize a value.
@@ -8489,11 +8491,14 @@
   function getChartLabelFormat(getters, range) {
       if (!range)
           return undefined;
-      return getters.getEvaluatedCell({
-          sheetId: range.sheetId,
-          col: range.zone.left,
-          row: range.zone.top,
-      }).format;
+      const { sheetId, zone: { left, top, bottom }, } = range;
+      for (let row = top; row <= bottom; row++) {
+          const format = getters.getEvaluatedCell({ sheetId, col: left, row }).format;
+          if (format) {
+              return format;
+          }
+      }
+      return undefined;
   }
   function getChartLabelValues(getters, dataSets, labelRange) {
       let labels = { values: [], formattedValues: [] };
@@ -9342,11 +9347,7 @@
       if (!labelRange || !canBeLinearChart(labelRange, getters)) {
           return false;
       }
-      const labelFormat = getters.getEvaluatedCell({
-          sheetId: labelRange.sheetId,
-          col: labelRange.zone.left,
-          row: labelRange.zone.top,
-      }).format;
+      const labelFormat = getChartLabelFormat(getters, labelRange);
       return Boolean(labelFormat && timeFormatLuxonCompatible.test(labelFormat));
   }
   function canBeLinearChart(labelRange, getters) {
@@ -18732,7 +18733,7 @@
               ? dichotomicSearch(range, searchKey?.value, "nextSmaller", "asc", range[0].length, getValueFromRange)
               : linearSearch(range, searchKey?.value, "strict", range[0].length, getValueFromRange);
           const value = range[_index - 1][rowIndex];
-          assertAvailable(value, searchKey);
+          assertAvailable(value, searchKey?.value);
           return value;
       },
       isExported: true,
@@ -18780,7 +18781,7 @@
                   : [returnRange[index]];
           }
           const _defaultValue = defaultValue?.();
-          assertAvailable(_defaultValue, searchKey);
+          assertAvailable(_defaultValue, searchKey?.value);
           return [[_defaultValue]];
       },
       isExported: true,
@@ -22268,6 +22269,7 @@
       currentColor: { type: String, optional: true },
       maxHeight: { type: Number, optional: true },
       anchorRect: Object,
+      disableNoColor: { type: Boolean, optional: true },
   };
 
   css /* scss */ `
@@ -22334,6 +22336,7 @@
       disabled: { type: Boolean, optional: true },
       dropdownMaxHeight: { type: Number, optional: true },
       class: { type: String, optional: true },
+      disableNoColor: { type: Boolean, optional: true },
   };
 
   class LineBarPieDesignPanel extends owl.Component {
@@ -23744,6 +23747,9 @@
           }
       }
       setColorScaleColor(target, color) {
+          if (!isColorValid(color)) {
+              return;
+          }
           const point = this.state.rules.colorScale[target];
           if (point) {
               point.color = Number.parseInt(color.substr(1), 16);
@@ -41678,7 +41684,7 @@
           const arrayFormulas = this.spreadingRelations.getFormulaPositionsSpreadingOn(positionId);
           const cells = new JetSet(arrayFormulas);
           const arrayFormulaPositionId = this.getArrayFormulaSpreadingOnId(positionId);
-          if (arrayFormulaPositionId) {
+          if (arrayFormulaPositionId !== undefined) {
               // ignore the formula spreading on the position. Keep only the blocked ones
               cells.delete(arrayFormulaPositionId);
           }
@@ -41701,9 +41707,15 @@
               }
               for (let i = 0; i < positionIds.length; ++i) {
                   const cell = positionIds[i];
+                  if (this.nextPositionsToUpdate.has(cell)) {
+                      continue;
+                  }
                   this.setEvaluatedCell(cell, this.computeCell(cell));
               }
           }
+          if (currentIteration >= MAX_ITERATION) {
+              console.warn("Maximum iteration reached while evaluating cells");
+          }
       }
       setEvaluatedCell(positionId, evaluatedCell) {
           this.evaluatedCells.set(positionId, evaluatedCell);
@@ -41735,7 +41747,6 @@
           }
           finally {
               this.cellsBeingComputed.delete(cellId);
-              this.nextPositionsToUpdate.delete(positionId);
           }
       }
       computeAndSave(position) {
@@ -41805,6 +41816,7 @@
               { sheetId, zone: rightPartZone },
               { sheetId, zone: leftColumnZone },
           ]);
+          invalidatedPositions.delete(this.encoder.encode(arrayFormulaPosition));
           this.nextPositionsToUpdate.addMany(invalidatedPositions);
       }
       assertSheetHasEnoughSpaceToSpreadFormulaResult({ sheetId, col, row }, matrixResult) {
@@ -44498,7 +44510,7 @@
        * Notify the server that the user client left the collaborative session
        */
       async leave(data) {
-          if (Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
+          if (data && Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
               await this.snapshot(data());
           }
           delete this.clients[this.clientId];
@@ -57153,7 +57165,8 @@
           this.session.join(this.config.client);
       }
       async leaveSession() {
-          await this.session.leave(lazy(() => this.exportData()));
+          const snapshot = this.getters.isReadonly() ? undefined : lazy(() => this.exportData());
+          await this.session.leave(snapshot);
       }
       setupUiPlugin(Plugin) {
           const plugin = new Plugin(this.uiPluginConfig);
@@ -57656,9 +57669,9 @@
   exports.tokenize = tokenize;
 
 
-  __info__.version = "17.0.39";
-  __info__.date = "2024-11-08T12:12:25.844Z";
-  __info__.hash = "454752f";
+  __info__.version = "17.0.41";
+  __info__.date = "2024-11-22T14:15:39.629Z";
+  __info__.hash = "23f8fc3";
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);