@odoo/o-spreadsheet 17.0.32 → 17.0.34

package/dist/o-spreadsheet.iife.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.0.32
- * @date 2024-07-24T10:26:05.203Z
- * @hash 679a547
+ * @version 17.0.34
+ * @date 2024-08-09T12:20:17.042Z
+ * @hash 1573912
  */
 
 (function (exports, owl) {
@@ -593,7 +593,7 @@
       let timeout;
       return function () {
           const context = this;
-          const args = arguments;
+          const args = Array.from(arguments);
           function later() {
               timeout = null;
               if (!immediate) {
@@ -796,7 +796,7 @@
    */
   function largeMax(array) {
       let len = array.length;
-      if (len < 100000)
+      if (len < 100_000)
           return Math.max(...array);
       let max = -Infinity;
       while (len--) {
@@ -810,7 +810,7 @@
    */
   function largeMin(array) {
       let len = array.length;
-      if (len < 100000)
+      if (len < 100_000)
           return Math.min(...array);
       let min = +Infinity;
       while (len--) {
@@ -2565,13 +2565,16 @@
       }
       return new RegExp("^" + exp + "$", "i");
   }
-  function evaluatePredicate(value = "", criterion) {
+  function evaluatePredicate(value = "", criterion, locale) {
       const { operator, operand } = criterion;
       if (operand === undefined || value === null || operand === null) {
           return false;
       }
       if (typeof operand === "number" && operator === "=") {
-          return toString(value) === toString(operand);
+          if (typeof value === "string" && (isNumber(value, locale) || isDateTime(value, locale))) {
+              return toNumber(value, locale) === operand;
+          }
+          return value === operand;
       }
       if (operator === "<>" || operator === "=") {
           let result;
@@ -2650,7 +2653,7 @@
               for (let k = 0; k < countArg - 1; k += 2) {
                   const criteriaValue = args[k][i][j];
                   const criterion = predicates[k / 2];
-                  validatedPredicates = evaluatePredicate(criteriaValue ?? undefined, criterion);
+                  validatedPredicates = evaluatePredicate(criteriaValue ?? undefined, criterion, locale);
                   if (!validatedPredicates) {
                       break;
                   }
@@ -5899,7 +5902,7 @@
   function numberCell(value, localeFormat) {
       return {
           type: CellValueType.number,
-          value: value || 0,
+          value: value || 0, // necessary to avoid "-0" and NaN values,
           format: localeFormat.format,
           isAutoSummable: true,
           defaultAlign: "right",
@@ -8432,8 +8435,8 @@
   function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, truncateLabels = true }) {
       const options = {
           // https://www.chartjs.org/docs/latest/general/responsive.html
-          responsive: true,
-          maintainAspectRatio: false,
+          responsive: true, // will resize when its container is resized
+          maintainAspectRatio: false, // doesn't maintain the aspect ration (width/height =2 by default) so the user has the choice of the exact layout
           layout: {
               padding: { left: 20, right: 20, top: chart.title ? 10 : 25, bottom: 10 },
           },
@@ -8742,7 +8745,7 @@
           },
           y: {
               position: chart.verticalAxisPosition,
-              beginAtZero: true,
+              beginAtZero: true, // the origin of the y axis is always zero
               ticks: {
                   color: fontColor,
                   callback: (value) => {
@@ -9396,7 +9399,7 @@
           },
           y: {
               position: chart.verticalAxisPosition,
-              beginAtZero: true,
+              beginAtZero: true, // the origin of the y axis is always zero
               ticks: {
                   color: fontColor,
                   callback: (value) => {
@@ -9484,7 +9487,7 @@
           const dataset = {
               label,
               data,
-              tension: 0,
+              tension: 0, // 0 -> render straight lines, which is much faster
               borderColor: color,
               backgroundColor,
               pointBackgroundColor: color,
@@ -9595,7 +9598,7 @@
               ...this.getDefinition(),
               backgroundColor: toXlsxHexColor(this.background || BACKGROUND_CHART_COLOR),
               fontColor: toXlsxHexColor(chartFontColor(this.background)),
-              verticalAxisPosition: "left",
+              verticalAxisPosition: "left", //TODO ExcelChartDefinition should be adapted, but can be done later
               dataSets,
               labelRange,
           };
@@ -26699,7 +26702,9 @@
           argToFocus: 0,
       });
       compositionActive = false;
+      spreadsheetRect = useSpreadsheetRect();
       get assistantStyle() {
+          const composerRect = this.composerRef.el.getBoundingClientRect();
           const assistantStyle = {};
           assistantStyle["min-width"] = `${this.props.rect?.width || ASSISTANT_WIDTH}px`;
           if (this.autoCompleteState.type === "function") {
@@ -26722,6 +26727,10 @@
                   assistantStyle.right = `0px`;
               }
           }
+          if (this.props.focus === "contentFocus" &&
+              composerRect.left + ASSISTANT_WIDTH > this.spreadsheetRect.width) {
+              assistantStyle.right = "0px";
+          }
           return cssPropertiesToCss(assistantStyle);
       }
       // we can't allow input events to be triggered while we remove and add back the content of the composer in processContent
@@ -29580,7 +29589,7 @@
       onScroll(offset) {
           const { scrollX } = this.env.model.getters.getActiveSheetDOMScrollInfo();
           this.env.model.dispatch("SET_VIEWPORT_OFFSET", {
-              offsetX: scrollX,
+              offsetX: scrollX, // offsetX is the same
               offsetY: offset,
           });
       }
@@ -29791,8 +29800,8 @@
           "CTRL+SHIFT+L": () => this.setHorizontalAlign("left"),
           "CTRL+SHIFT+R": () => this.setHorizontalAlign("right"),
           "CTRL+SHIFT+V": () => PASTE_VALUE_ACTION(this.env),
-          "CTRL+SHIFT+<": () => this.clearFormatting(),
-          "CTRL+<": () => this.clearFormatting(),
+          "CTRL+SHIFT+<": () => this.clearFormatting(), // for qwerty
+          "CTRL+<": () => this.clearFormatting(), // for azerty
           "CTRL+SHIFT+ ": () => {
               this.env.model.selection.selectAll();
           },
@@ -30606,10 +30615,10 @@
   const CF_TYPE_CONVERSION_MAP = {
       aboveAverage: undefined,
       expression: undefined,
-      cellIs: undefined,
-      colorScale: undefined,
+      cellIs: undefined, // exist but isn't an operator in o_spreadsheet
+      colorScale: undefined, // exist but isn't an operator in o_spreadsheet
       dataBar: undefined,
-      iconSet: undefined,
+      iconSet: undefined, // exist but isn't an operator in o_spreadsheet
       top10: undefined,
       uniqueValues: undefined,
       duplicateValues: undefined,
@@ -30844,7 +30853,7 @@
       61: "993366",
       62: "333399",
       63: "333333",
-      64: "000000",
+      64: "000000", // system foreground
       65: "FFFFFF", // system background
   };
   const IMAGE_MIMETYPE_TO_EXTENSION_MAPPING = {
@@ -34485,12 +34494,13 @@
                   this.clearBorders(cmd.sheetId, cmd.target);
                   break;
               case "REMOVE_COLUMNS_ROWS":
-                  for (let el of [...cmd.elements].sort((a, b) => b - a)) {
+                  const elements = [...cmd.elements].sort((a, b) => b - a);
+                  for (const group of groupConsecutive(elements)) {
                       if (cmd.dimension === "COL") {
-                          this.shiftBordersHorizontally(cmd.sheetId, el + 1, -1);
+                          this.shiftBordersHorizontally(cmd.sheetId, group[group.length - 1] + 1, -group.length);
                       }
                       else {
-                          this.shiftBordersVertically(cmd.sheetId, el + 1, -1);
+                          this.shiftBordersVertically(cmd.sheetId, group[group.length - 1] + 1, -group.length);
                       }
                   }
                   break;
@@ -38651,7 +38661,7 @@
        * @param sheetXC the string description of a range, in the form SheetName!XC:XC
        */
       getRangeFromSheetXC(defaultSheetId, sheetXC) {
-          if (!rangeReference.test(sheetXC)) {
+          if (!rangeReference.test(sheetXC) || !this.getters.tryGetSheet(defaultSheetId)) {
               return new RangeImpl({
                   sheetId: "",
                   zone: { left: -1, top: -1, right: -1, bottom: -1 },
@@ -39551,12 +39561,7 @@
                           });
                       }
                       if (colIndex > deletedColumn) {
-                          this.dispatch("UPDATE_CELL_POSITION", {
-                              sheetId: sheet.id,
-                              cellId: cellId,
-                              col: colIndex - 1,
-                              row: rowIndex,
-                          });
+                          this.setNewPosition(cellId, sheet.id, colIndex - 1, rowIndex);
                       }
                   }
               }
@@ -39566,7 +39571,7 @@
        * Move the cells after a column or rows insertion
        */
       moveCellsOnAddition(sheet, addedElement, quantity, dimension) {
-          const commands = [];
+          const updates = [];
           for (let rowIndex = 0; rowIndex < sheet.rows.length; rowIndex++) {
               const row = sheet.rows[rowIndex];
               if (dimension !== "rows" || rowIndex >= addedElement) {
@@ -39575,20 +39580,20 @@
                       const cellId = row.cells[i];
                       if (cellId) {
                           if (dimension === "rows" || colIndex >= addedElement) {
-                              commands.push({
-                                  type: "UPDATE_CELL_POSITION",
+                              updates.push({
                                   sheetId: sheet.id,
                                   cellId: cellId,
                                   col: colIndex + (dimension === "columns" ? quantity : 0),
                                   row: rowIndex + (dimension === "rows" ? quantity : 0),
+                                  type: "UPDATE_CELL_POSITION",
                               });
                           }
                       }
                   }
               }
           }
-          for (let cmd of commands.reverse()) {
-              this.dispatch(cmd.type, cmd);
+          for (let update of updates.reverse()) {
+              this.updateCellPosition(update);
           }
       }
       /**
@@ -39621,12 +39626,7 @@
                       const colIndex = Number(i);
                       const cellId = row.cells[i];
                       if (cellId) {
-                          this.dispatch("UPDATE_CELL_POSITION", {
-                              sheetId: sheet.id,
-                              cellId: cellId,
-                              col: colIndex,
-                              row: rowIndex - numberRows,
-                          });
+                          this.setNewPosition(cellId, sheet.id, colIndex, rowIndex - numberRows);
                       }
                   }
               }
@@ -41603,15 +41603,16 @@
           this.evaluatedCells = new Map();
           this.evaluate(this.getAllCells());
       }
-      evaluateFormula(sheetId, formulaString) {
-          const compiledFormula = compile(formulaString);
-          const ranges = compiledFormula.dependencies.map((xc) => this.getters.getRangeFromSheetXC(sheetId, xc));
-          this.updateCompilationParameters();
-          const array = compiledFormula.execute(ranges, ...this.compilationParams);
-          if (isMatrix(array)) {
-              return matrixMap(array, (cell) => cell.value);
+      evaluateFormulaResult(sheetId, formulaString) {
+          try {
+              const compiledFormula = compile(formulaString);
+              const ranges = compiledFormula.dependencies.map((xc) => this.getters.getRangeFromSheetXC(sheetId, xc));
+              this.updateCompilationParameters();
+              return compiledFormula.execute(ranges, ...this.compilationParams);
+          }
+          catch (error) {
+              return this.handleError(error);
           }
-          return array.value;
       }
       getAllCells() {
           const positionIds = new JetSet();
@@ -41687,7 +41688,7 @@
                   : evaluateLiteral(cell.content, { format: cell.format, locale: this.getters.getLocale() });
           }
           catch (e) {
-              return this.handleError(e, cell);
+              return this.handleError(e);
           }
           finally {
               this.cellsBeingComputed.delete(cellId);
@@ -41702,7 +41703,7 @@
           }
           return evaluatedCell;
       }
-      handleError(e, cell) {
+      handleError(e) {
           if (!(e instanceof EvaluationError)) {
               e = new EvaluationError(CellErrorType.GenericError, e.message);
           }
@@ -42036,6 +42037,7 @@
   class EvaluationPlugin extends UIPlugin {
       static getters = [
           "evaluateFormula",
+          "evaluateFormulaResult",
           "getCorrespondingFormulaCell",
           "getRangeFormattedValues",
           "getRangeValues",
@@ -42093,12 +42095,14 @@
       // Getters
       // ---------------------------------------------------------------------------
       evaluateFormula(sheetId, formulaString) {
-          try {
-              return this.evaluator.evaluateFormula(sheetId, formulaString);
-          }
-          catch (error) {
-              return error instanceof EvaluationError ? error.errorType : CellErrorType.GenericError;
+          const result = this.evaluateFormulaResult(sheetId, formulaString);
+          if (isMatrix(result)) {
+              return matrixMap(result, (cell) => cell.value);
           }
+          return result.value;
+      }
+      evaluateFormulaResult(sheetId, formulaString) {
+          return this.evaluator.evaluateFormulaResult(sheetId, formulaString);
       }
       /**
        * Return the value of each cell in the range as they are displayed in the grid.
@@ -42239,17 +42243,17 @@
    */
   function sortWithClusters(colorsToSort) {
       const clusters = [
-          { leadColor: rgba(255, 0, 0), colors: [] },
-          { leadColor: rgba(255, 128, 0), colors: [] },
-          { leadColor: rgba(128, 128, 0), colors: [] },
-          { leadColor: rgba(128, 255, 0), colors: [] },
-          { leadColor: rgba(0, 255, 0), colors: [] },
-          { leadColor: rgba(0, 255, 128), colors: [] },
-          { leadColor: rgba(0, 255, 255), colors: [] },
-          { leadColor: rgba(0, 127, 255), colors: [] },
-          { leadColor: rgba(0, 0, 255), colors: [] },
-          { leadColor: rgba(127, 0, 255), colors: [] },
-          { leadColor: rgba(128, 0, 128), colors: [] },
+          { leadColor: rgba(255, 0, 0), colors: [] }, // red
+          { leadColor: rgba(255, 128, 0), colors: [] }, // orange
+          { leadColor: rgba(128, 128, 0), colors: [] }, // yellow
+          { leadColor: rgba(128, 255, 0), colors: [] }, // chartreuse
+          { leadColor: rgba(0, 255, 0), colors: [] }, // green
+          { leadColor: rgba(0, 255, 128), colors: [] }, // spring green
+          { leadColor: rgba(0, 255, 255), colors: [] }, // cyan
+          { leadColor: rgba(0, 127, 255), colors: [] }, // azure
+          { leadColor: rgba(0, 0, 255), colors: [] }, // blue
+          { leadColor: rgba(127, 0, 255), colors: [] }, // violet
+          { leadColor: rgba(128, 0, 128), colors: [] }, // magenta
           { leadColor: rgba(255, 0, 128), colors: [] }, // rose
       ];
       for (const color of colorsToSort.map(colorToRGBA)) {
@@ -45898,6 +45902,7 @@
        * evaluated and updated with the number type.
        */
       setDecimal(sheetId, zones, step) {
+          const positionsByFormat = {};
           // Find the each cell with a number value and get the format
           for (const zone of zones) {
               for (const position of positions(zone)) {
@@ -45907,15 +45912,20 @@
                       // of the format
                       this.getters.getLocale();
                       const newFormat = changeDecimalPlaces(numberFormat, step);
-                      // Apply the new format on the whole zone
-                      this.dispatch("SET_FORMATTING", {
-                          sheetId,
-                          target: [positionToZone(position)],
-                          format: newFormat,
-                      });
+                      positionsByFormat[newFormat] = positionsByFormat[newFormat] || [];
+                      positionsByFormat[newFormat].push(position);
                   }
               }
           }
+          // consolidate all positions with the same format in bigger zones
+          for (const newFormat in positionsByFormat) {
+              const zones = futureRecomputeZones(positionsByFormat[newFormat].map((position) => positionToZone(position)));
+              this.dispatch("SET_FORMATTING", {
+                  sheetId,
+                  format: newFormat,
+                  target: zones,
+              });
+          }
       }
       /**
        * Take a range of cells and return the format of the first cell containing a
@@ -52159,7 +52169,7 @@
               .map((sheetEl) => sheetEl.getBoundingClientRect())
               .map((rect) => ({
               x: rect.x,
-              width: rect.width - 1,
+              width: rect.width - 1, // -1 to compensate negative margin
               y: rect.y,
               height: rect.height,
           }));
@@ -52384,7 +52394,7 @@
           }
           return cssPropertiesToCss({
               top: `${groupBox.headerRect.height / 2}px`,
-              left: `calc(50% - 1px)`,
+              left: `calc(50% - 1px)`, // -1px: we want the border to be on the center
               width: `30%`,
               height: `calc(100% - ${groupBox.headerRect.height / 2}px)`,
               "border-left": `1px solid ${HEADER_GROUPING_BORDER_COLOR}`,
@@ -52436,7 +52446,7 @@
               return "";
           }
           return cssPropertiesToCss({
-              top: `calc(50% - 1px)`,
+              top: `calc(50% - 1px)`, // -1px: we want the border to be on the center
               left: `${groupBox.headerRect.width / 2}px`,
               width: `calc(100% - ${groupBox.headerRect.width / 2}px)`,
               height: `30%`,
@@ -53837,7 +53847,7 @@
           const gridColSize = GROUP_LAYER_WIDTH * this.rowLayers.length;
           const gridRowSize = GROUP_LAYER_WIDTH * this.colLayers.length;
           return cssPropertiesToCss({
-              "grid-template-columns": `${gridColSize ? gridColSize + 2 : 0}px auto`,
+              "grid-template-columns": `${gridColSize ? gridColSize + 2 : 0}px auto`, // +2: margins
               "grid-template-rows": `${gridRowSize ? gridRowSize + 2 : 0}px auto`,
           });
       }
@@ -55340,7 +55350,7 @@
   }
 
   class StateObserver {
-      changes = [];
+      changes;
       commands = [];
       /**
        * Record the changes which could happen in the given callback, save them in a
@@ -55372,7 +55382,7 @@
           if (value[key] === val) {
               return;
           }
-          this.changes.push({
+          this.changes?.push({
               path: args,
               before: value[key],
               after: val,
@@ -56503,7 +56513,7 @@
           const colHeaderXc = toXC(tableZone.left + i, tableZone.top);
           const colName = sheetData.cells[colHeaderXc]?.content || `col${i}`;
           const colAttributes = [
-              ["id", i + 1],
+              ["id", i + 1], // id cannot be 0
               ["name", colName],
           ];
           columns.push(escapeXml /*xml*/ `<tableColumn ${formatAttributes(colAttributes)}/>`);
@@ -57585,9 +57595,9 @@
   exports.tokenize = tokenize;
 
 
-  __info__.version = "17.0.32";
-  __info__.date = "2024-07-24T10:26:05.203Z";
-  __info__.hash = "679a547";
+  __info__.version = "17.0.34";
+  __info__.date = "2024-08-09T12:20:17.042Z";
+  __info__.hash = "1573912";
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);