@odoo/o-spreadsheet 17.0.31 → 17.0.33

package/dist/o-spreadsheet.esm.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.0.31
- * @date 2024-07-18T14:22:00.324Z
- * @hash c64db0d
+ * @version 17.0.33
+ * @date 2024-08-02T08:18:55.061Z
+ * @hash 4ad4049
  */
 
 import { Component, useRef, onMounted, useEffect, onWillPatch, useState, onWillUpdateProps, onPatched, useComponent, useExternalListener, onWillUnmount, onWillStart, xml, useChildSubEnv, useSubEnv, markRaw } from '@odoo/owl';
@@ -592,7 +592,7 @@ function debounce(func, wait, immediate) {
     let timeout;
     return function () {
         const context = this;
-        const args = arguments;
+        const args = Array.from(arguments);
         function later() {
             timeout = null;
             if (!immediate) {
@@ -795,7 +795,7 @@ function isNumberBetween(value, min, max) {
  */
 function largeMax(array) {
     let len = array.length;
-    if (len < 100000)
+    if (len < 100_000)
         return Math.max(...array);
     let max = -Infinity;
     while (len--) {
@@ -809,7 +809,7 @@ function largeMax(array) {
  */
 function largeMin(array) {
     let len = array.length;
-    if (len < 100000)
+    if (len < 100_000)
         return Math.min(...array);
     let min = +Infinity;
     while (len--) {
@@ -2564,13 +2564,16 @@ function operandToRegExp(operand) {
     }
     return new RegExp("^" + exp + "$", "i");
 }
-function evaluatePredicate(value = "", criterion) {
+function evaluatePredicate(value = "", criterion, locale) {
     const { operator, operand } = criterion;
     if (operand === undefined || value === null || operand === null) {
         return false;
     }
     if (typeof operand === "number" && operator === "=") {
-        return toString(value) === toString(operand);
+        if (typeof value === "string" && (isNumber(value, locale) || isDateTime(value, locale))) {
+            return toNumber(value, locale) === operand;
+        }
+        return value === operand;
     }
     if (operator === "<>" || operator === "=") {
         let result;
@@ -2649,7 +2652,7 @@ function visitMatchingRanges(args, cb, locale, isQuery = false) {
             for (let k = 0; k < countArg - 1; k += 2) {
                 const criteriaValue = args[k][i][j];
                 const criterion = predicates[k / 2];
-                validatedPredicates = evaluatePredicate(criteriaValue ?? undefined, criterion);
+                validatedPredicates = evaluatePredicate(criteriaValue ?? undefined, criterion, locale);
                 if (!validatedPredicates) {
                     break;
                 }
@@ -5898,7 +5901,7 @@ function textCell(value, localeFormat) {
 function numberCell(value, localeFormat) {
     return {
         type: CellValueType.number,
-        value: value || 0,
+        value: value || 0, // necessary to avoid "-0" and NaN values,
         format: localeFormat.format,
         isAutoSummable: true,
         defaultAlign: "right",
@@ -8431,8 +8434,8 @@ function truncateLabel(label) {
 function getDefaultChartJsRuntime(chart, labels, fontColor, { format, locale, truncateLabels = true }) {
     const options = {
         // https://www.chartjs.org/docs/latest/general/responsive.html
-        responsive: true,
-        maintainAspectRatio: false,
+        responsive: true, // will resize when its container is resized
+        maintainAspectRatio: false, // doesn't maintain the aspect ration (width/height =2 by default) so the user has the choice of the exact layout
         layout: {
             padding: { left: 20, right: 20, top: chart.title ? 10 : 25, bottom: 10 },
         },
@@ -8741,7 +8744,7 @@ function getBarConfiguration(chart, labels, localeFormat) {
         },
         y: {
             position: chart.verticalAxisPosition,
-            beginAtZero: true,
+            beginAtZero: true, // the origin of the y axis is always zero
             ticks: {
                 color: fontColor,
                 callback: (value) => {
@@ -9395,7 +9398,7 @@ function getLineConfiguration(chart, labels, options) {
         },
         y: {
             position: chart.verticalAxisPosition,
-            beginAtZero: true,
+            beginAtZero: true, // the origin of the y axis is always zero
             ticks: {
                 color: fontColor,
                 callback: (value) => {
@@ -9483,7 +9486,7 @@ function createLineChartRuntime(chart, getters) {
         const dataset = {
             label,
             data,
-            tension: 0,
+            tension: 0, // 0 -> render straight lines, which is much faster
             borderColor: color,
             backgroundColor,
             pointBackgroundColor: color,
@@ -9594,7 +9597,7 @@ class PieChart extends AbstractChart {
             ...this.getDefinition(),
             backgroundColor: toXlsxHexColor(this.background || BACKGROUND_CHART_COLOR),
             fontColor: toXlsxHexColor(chartFontColor(this.background)),
-            verticalAxisPosition: "left",
+            verticalAxisPosition: "left", //TODO ExcelChartDefinition should be adapted, but can be done later
             dataSets,
             labelRange,
         };
@@ -26698,7 +26701,9 @@ class Composer extends Component {
         argToFocus: 0,
     });
     compositionActive = false;
+    spreadsheetRect = useSpreadsheetRect();
     get assistantStyle() {
+        const composerRect = this.composerRef.el.getBoundingClientRect();
         const assistantStyle = {};
         assistantStyle["min-width"] = `${this.props.rect?.width || ASSISTANT_WIDTH}px`;
         if (this.autoCompleteState.type === "function") {
@@ -26721,6 +26726,10 @@ class Composer extends Component {
                 assistantStyle.right = `0px`;
             }
         }
+        if (this.props.focus === "contentFocus" &&
+            composerRect.left + ASSISTANT_WIDTH > this.spreadsheetRect.width) {
+            assistantStyle.right = "0px";
+        }
         return cssPropertiesToCss(assistantStyle);
     }
     // we can't allow input events to be triggered while we remove and add back the content of the composer in processContent
@@ -28369,10 +28378,13 @@ function useCellHovered(env, gridRef, callback) {
         row: undefined,
     };
     const { Date } = window;
-    let x = 0;
-    let y = 0;
+    let x = undefined;
+    let y = undefined;
     let lastMoved = 0;
     function getPosition() {
+        if (x === undefined || y === undefined) {
+            return { col: -1, row: -1 };
+        }
         const col = env.model.getters.getColIndex(x);
         const row = env.model.getters.getRowIndex(y);
         return { col, row };
@@ -29576,7 +29588,7 @@ class VerticalScrollBar extends Component {
     onScroll(offset) {
         const { scrollX } = this.env.model.getters.getActiveSheetDOMScrollInfo();
         this.env.model.dispatch("SET_VIEWPORT_OFFSET", {
-            offsetX: scrollX,
+            offsetX: scrollX, // offsetX is the same
             offsetY: offset,
         });
     }
@@ -29787,8 +29799,8 @@ class Grid extends Component {
         "CTRL+SHIFT+L": () => this.setHorizontalAlign("left"),
         "CTRL+SHIFT+R": () => this.setHorizontalAlign("right"),
         "CTRL+SHIFT+V": () => PASTE_VALUE_ACTION(this.env),
-        "CTRL+SHIFT+<": () => this.clearFormatting(),
-        "CTRL+<": () => this.clearFormatting(),
+        "CTRL+SHIFT+<": () => this.clearFormatting(), // for qwerty
+        "CTRL+<": () => this.clearFormatting(), // for azerty
         "CTRL+SHIFT+ ": () => {
             this.env.model.selection.selectAll();
         },
@@ -30602,10 +30614,10 @@ function convertCFCellIsOperator(xlsxCfOperator) {
 const CF_TYPE_CONVERSION_MAP = {
     aboveAverage: undefined,
     expression: undefined,
-    cellIs: undefined,
-    colorScale: undefined,
+    cellIs: undefined, // exist but isn't an operator in o_spreadsheet
+    colorScale: undefined, // exist but isn't an operator in o_spreadsheet
     dataBar: undefined,
-    iconSet: undefined,
+    iconSet: undefined, // exist but isn't an operator in o_spreadsheet
     top10: undefined,
     uniqueValues: undefined,
     duplicateValues: undefined,
@@ -30840,7 +30852,7 @@ const XLSX_INDEXED_COLORS = {
     61: "993366",
     62: "333399",
     63: "333333",
-    64: "000000",
+    64: "000000", // system foreground
     65: "FFFFFF", // system background
 };
 const IMAGE_MIMETYPE_TO_EXTENSION_MAPPING = {
@@ -34481,12 +34493,13 @@ class BordersPlugin extends CorePlugin {
                 this.clearBorders(cmd.sheetId, cmd.target);
                 break;
             case "REMOVE_COLUMNS_ROWS":
-                for (let el of [...cmd.elements].sort((a, b) => b - a)) {
+                const elements = [...cmd.elements].sort((a, b) => b - a);
+                for (const group of groupConsecutive(elements)) {
                     if (cmd.dimension === "COL") {
-                        this.shiftBordersHorizontally(cmd.sheetId, el + 1, -1);
+                        this.shiftBordersHorizontally(cmd.sheetId, group[group.length - 1] + 1, -group.length);
                     }
                     else {
-                        this.shiftBordersVertically(cmd.sheetId, el + 1, -1);
+                        this.shiftBordersVertically(cmd.sheetId, group[group.length - 1] + 1, -group.length);
                     }
                 }
                 break;
@@ -39547,12 +39560,7 @@ class SheetPlugin extends CorePlugin {
                         });
                     }
                     if (colIndex > deletedColumn) {
-                        this.dispatch("UPDATE_CELL_POSITION", {
-                            sheetId: sheet.id,
-                            cellId: cellId,
-                            col: colIndex - 1,
-                            row: rowIndex,
-                        });
+                        this.setNewPosition(cellId, sheet.id, colIndex - 1, rowIndex);
                     }
                 }
             }
@@ -39562,7 +39570,7 @@ class SheetPlugin extends CorePlugin {
      * Move the cells after a column or rows insertion
      */
     moveCellsOnAddition(sheet, addedElement, quantity, dimension) {
-        const commands = [];
+        const updates = [];
         for (let rowIndex = 0; rowIndex < sheet.rows.length; rowIndex++) {
             const row = sheet.rows[rowIndex];
             if (dimension !== "rows" || rowIndex >= addedElement) {
@@ -39571,20 +39579,20 @@ class SheetPlugin extends CorePlugin {
                     const cellId = row.cells[i];
                     if (cellId) {
                         if (dimension === "rows" || colIndex >= addedElement) {
-                            commands.push({
-                                type: "UPDATE_CELL_POSITION",
+                            updates.push({
                                 sheetId: sheet.id,
                                 cellId: cellId,
                                 col: colIndex + (dimension === "columns" ? quantity : 0),
                                 row: rowIndex + (dimension === "rows" ? quantity : 0),
+                                type: "UPDATE_CELL_POSITION",
                             });
                         }
                     }
                 }
             }
         }
-        for (let cmd of commands.reverse()) {
-            this.dispatch(cmd.type, cmd);
+        for (let update of updates.reverse()) {
+            this.updateCellPosition(update);
         }
     }
     /**
@@ -39617,12 +39625,7 @@ class SheetPlugin extends CorePlugin {
                     const colIndex = Number(i);
                     const cellId = row.cells[i];
                     if (cellId) {
-                        this.dispatch("UPDATE_CELL_POSITION", {
-                            sheetId: sheet.id,
-                            cellId: cellId,
-                            col: colIndex,
-                            row: rowIndex - numberRows,
-                        });
+                        this.setNewPosition(cellId, sheet.id, colIndex, rowIndex - numberRows);
                     }
                 }
             }
@@ -42235,17 +42238,17 @@ function isBadExpression(tokens) {
  */
 function sortWithClusters(colorsToSort) {
     const clusters = [
-        { leadColor: rgba(255, 0, 0), colors: [] },
-        { leadColor: rgba(255, 128, 0), colors: [] },
-        { leadColor: rgba(128, 128, 0), colors: [] },
-        { leadColor: rgba(128, 255, 0), colors: [] },
-        { leadColor: rgba(0, 255, 0), colors: [] },
-        { leadColor: rgba(0, 255, 128), colors: [] },
-        { leadColor: rgba(0, 255, 255), colors: [] },
-        { leadColor: rgba(0, 127, 255), colors: [] },
-        { leadColor: rgba(0, 0, 255), colors: [] },
-        { leadColor: rgba(127, 0, 255), colors: [] },
-        { leadColor: rgba(128, 0, 128), colors: [] },
+        { leadColor: rgba(255, 0, 0), colors: [] }, // red
+        { leadColor: rgba(255, 128, 0), colors: [] }, // orange
+        { leadColor: rgba(128, 128, 0), colors: [] }, // yellow
+        { leadColor: rgba(128, 255, 0), colors: [] }, // chartreuse
+        { leadColor: rgba(0, 255, 0), colors: [] }, // green
+        { leadColor: rgba(0, 255, 128), colors: [] }, // spring green
+        { leadColor: rgba(0, 255, 255), colors: [] }, // cyan
+        { leadColor: rgba(0, 127, 255), colors: [] }, // azure
+        { leadColor: rgba(0, 0, 255), colors: [] }, // blue
+        { leadColor: rgba(127, 0, 255), colors: [] }, // violet
+        { leadColor: rgba(128, 0, 128), colors: [] }, // magenta
         { leadColor: rgba(255, 0, 128), colors: [] }, // rose
     ];
     for (const color of colorsToSort.map(colorToRGBA)) {
@@ -42551,40 +42554,45 @@ class EvaluationConditionalFormatPlugin extends UIPlugin {
     getComputedStyles(sheetId) {
         const computedStyle = {};
         for (let cf of this.getters.getConditionalFormats(sheetId).reverse()) {
-            switch (cf.rule.type) {
-                case "ColorScaleRule":
-                    for (let range of cf.ranges) {
-                        this.applyColorScale(sheetId, range, cf.rule, computedStyle);
-                    }
-                    break;
-                case "CellIsRule":
-                    const formulas = cf.rule.values.map((value) => value.startsWith("=") ? compile(value) : undefined);
-                    for (let ref of cf.ranges) {
-                        const zone = this.getters.getRangeFromSheetXC(sheetId, ref).zone;
-                        for (let row = zone.top; row <= zone.bottom; row++) {
-                            for (let col = zone.left; col <= zone.right; col++) {
-                                const predicate = this.rulePredicate[cf.rule.type];
-                                const target = { sheetId, col, row };
-                                const values = cf.rule.values.map((value, i) => {
-                                    const compiledFormula = formulas[i];
-                                    if (compiledFormula) {
-                                        return this.getters.getTranslatedCellFormula(sheetId, col - zone.left, row - zone.top, {
-                                            ...compiledFormula,
-                                            dependencies: compiledFormula.dependencies.map((d) => this.getters.getRangeFromSheetXC(sheetId, d)),
-                                        });
+            try {
+                switch (cf.rule.type) {
+                    case "ColorScaleRule":
+                        for (let range of cf.ranges) {
+                            this.applyColorScale(sheetId, range, cf.rule, computedStyle);
+                        }
+                        break;
+                    case "CellIsRule":
+                        const formulas = cf.rule.values.map((value) => value.startsWith("=") ? compile(value) : undefined);
+                        for (let ref of cf.ranges) {
+                            const zone = this.getters.getRangeFromSheetXC(sheetId, ref).zone;
+                            for (let row = zone.top; row <= zone.bottom; row++) {
+                                for (let col = zone.left; col <= zone.right; col++) {
+                                    const predicate = this.rulePredicate[cf.rule.type];
+                                    const target = { sheetId, col, row };
+                                    const values = cf.rule.values.map((value, i) => {
+                                        const compiledFormula = formulas[i];
+                                        if (compiledFormula) {
+                                            return this.getters.getTranslatedCellFormula(sheetId, col - zone.left, row - zone.top, {
+                                                ...compiledFormula,
+                                                dependencies: compiledFormula.dependencies.map((d) => this.getters.getRangeFromSheetXC(sheetId, d)),
+                                            });
+                                        }
+                                        return value;
+                                    });
+                                    if (predicate && predicate(target, { ...cf.rule, values })) {
+                                        if (!computedStyle[col])
+                                            computedStyle[col] = [];
+                                        // we must combine all the properties of all the CF rules applied to the given cell
+                                        computedStyle[col][row] = Object.assign(computedStyle[col]?.[row] || {}, cf.rule.style);
                                     }
-                                    return value;
-                                });
-                                if (predicate && predicate(target, { ...cf.rule, values })) {
-                                    if (!computedStyle[col])
-                                        computedStyle[col] = [];
-                                    // we must combine all the properties of all the CF rules applied to the given cell
-                                    computedStyle[col][row] = Object.assign(computedStyle[col]?.[row] || {}, cf.rule.style);
                                 }
                             }
                         }
-                    }
-                    break;
+                        break;
+                }
+            }
+            catch (_) {
+                // we ignore the errors within the evaluation of a rule
             }
         }
         return computedStyle;
@@ -52150,7 +52158,7 @@ class BottomBar extends Component {
             .map((sheetEl) => sheetEl.getBoundingClientRect())
             .map((rect) => ({
             x: rect.x,
-            width: rect.width - 1,
+            width: rect.width - 1, // -1 to compensate negative margin
             y: rect.y,
             height: rect.height,
         }));
@@ -52375,7 +52383,7 @@ class RowGroup extends AbstractHeaderGroup {
         }
         return cssPropertiesToCss({
             top: `${groupBox.headerRect.height / 2}px`,
-            left: `calc(50% - 1px)`,
+            left: `calc(50% - 1px)`, // -1px: we want the border to be on the center
             width: `30%`,
             height: `calc(100% - ${groupBox.headerRect.height / 2}px)`,
             "border-left": `1px solid ${HEADER_GROUPING_BORDER_COLOR}`,
@@ -52427,7 +52435,7 @@ class ColGroup extends AbstractHeaderGroup {
             return "";
         }
         return cssPropertiesToCss({
-            top: `calc(50% - 1px)`,
+            top: `calc(50% - 1px)`, // -1px: we want the border to be on the center
             left: `${groupBox.headerRect.width / 2}px`,
             width: `calc(100% - ${groupBox.headerRect.width / 2}px)`,
             height: `30%`,
@@ -53828,7 +53836,7 @@ class Spreadsheet extends Component {
         const gridColSize = GROUP_LAYER_WIDTH * this.rowLayers.length;
         const gridRowSize = GROUP_LAYER_WIDTH * this.colLayers.length;
         return cssPropertiesToCss({
-            "grid-template-columns": `${gridColSize ? gridColSize + 2 : 0}px auto`,
+            "grid-template-columns": `${gridColSize ? gridColSize + 2 : 0}px auto`, // +2: margins
             "grid-template-rows": `${gridRowSize ? gridRowSize + 2 : 0}px auto`,
         });
     }
@@ -55331,7 +55339,7 @@ class SelectionStreamProcessorImpl {
 }
 
 class StateObserver {
-    changes = [];
+    changes;
     commands = [];
     /**
      * Record the changes which could happen in the given callback, save them in a
@@ -55363,7 +55371,7 @@ class StateObserver {
         if (value[key] === val) {
             return;
         }
-        this.changes.push({
+        this.changes?.push({
             path: args,
             before: value[key],
             after: val,
@@ -56494,7 +56502,7 @@ function addTableColumns(table, sheetData) {
         const colHeaderXc = toXC(tableZone.left + i, tableZone.top);
         const colName = sheetData.cells[colHeaderXc]?.content || `col${i}`;
         const colAttributes = [
-            ["id", i + 1],
+            ["id", i + 1], // id cannot be 0
             ["name", colName],
         ];
         columns.push(escapeXml /*xml*/ `<tableColumn ${formatAttributes(colAttributes)}/>`);
@@ -57541,6 +57549,6 @@ const constants = {
 export { AbstractChart, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, UIPlugin, __info__, addFunction, astToFormula, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, tokenize };
 
 
-__info__.version = "17.0.31";
-__info__.date = "2024-07-18T14:22:00.324Z";
-__info__.hash = "c64db0d";
+__info__.version = "17.0.33";
+__info__.date = "2024-08-02T08:18:55.061Z";
+__info__.hash = "4ad4049";