@odoo/o-spreadsheet 17.0.10 → 17.0.12

package/dist/o-spreadsheet.iife.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.0.10
- * @date 2024-02-02T13:48:28.727Z
- * @hash be06aa9
+ * @version 17.0.12
+ * @date 2024-02-16T14:24:02.984Z
+ * @hash 8fa2bab
  */
 
 (function (exports, owl) {
@@ -551,8 +551,8 @@
    * If the given item does not exist in the dictionary, it creates one with a new id.
    */
   function getItemId(item, itemsDic) {
-      for (let [key, value] of Object.entries(itemsDic)) {
-          if (deepEquals(value, item)) {
+      for (const key in itemsDic) {
+          if (deepEquals(itemsDic[key], item)) {
               return parseInt(key, 10);
           }
       }
@@ -651,11 +651,13 @@
       if (typeof o1 !== "object")
           return o1 === o2;
       // Objects can have different keys if the values are undefined
-      const keys = new Set();
-      Object.keys(o1).forEach((key) => keys.add(key));
-      Object.keys(o2).forEach((key) => keys.add(key));
-      for (let key of keys) {
-          if (typeof o1[key] !== typeof o1[key])
+      for (const key in o2) {
+          if (!(key in o1) && o2[key] !== undefined) {
+              return false;
+          }
+      }
+      for (const key in o1) {
+          if (typeof o1[key] !== typeof o2[key])
               return false;
           if (typeof o1[key] === "object") {
               if (!deepEquals(o1[key], o2[key]))
@@ -725,18 +727,18 @@
       return true;
   }
   class JetSet extends Set {
-      add(...iterable) {
+      addMany(iterable) {
           for (const element of iterable) {
               super.add(element);
           }
           return this;
       }
-      delete(...iterable) {
-          let deleted = false;
+      deleteMany(iterable) {
+          let wasDeleted = false;
           for (const element of iterable) {
-              deleted ||= super.delete(element);
+              wasDeleted ||= super.delete(element);
           }
-          return deleted;
+          return wasDeleted;
       }
   }
   /**
@@ -1995,7 +1997,7 @@
        * Static helper which returns a successful DispatchResult
        */
       static get Success() {
-          return new DispatchResult();
+          return SUCCESS;
       }
       get isSuccessful() {
           return this.reasons.length === 0;
@@ -2008,6 +2010,7 @@
           return this.reasons.includes(reason);
       }
   }
+  const SUCCESS = new DispatchResult();
   exports.CommandResult = void 0;
   (function (CommandResult) {
       CommandResult["Success"] = "Success";
@@ -2889,6 +2892,9 @@
   function formatValue(value, { format, locale }) {
       switch (typeof value) {
           case "string":
+              if (value.includes('\\"')) {
+                  return value.replace(/\\"/g, '"');
+              }
               return value;
           case "boolean":
               return value ? "TRUE" : "FALSE";
@@ -7380,7 +7386,7 @@
       while (!chars.isOver()) {
           let token = tokenizeSpace(chars) ||
               tokenizeArgsSeparator(chars, locale) ||
-              tokenizeMisc(chars) ||
+              tokenizeParenthesis(chars) ||
               tokenizeOperator(chars) ||
               tokenizeString(chars) ||
               tokenizeDebugger(chars) ||
@@ -7401,15 +7407,14 @@
       }
       return null;
   }
-  const misc$1 = {
-      "(": "LEFT_PAREN",
-      ")": "RIGHT_PAREN",
+  const parenthesis = {
+      "(": { type: "LEFT_PAREN", value: "(" },
+      ")": { type: "RIGHT_PAREN", value: ")" },
   };
-  function tokenizeMisc(chars) {
-      if (chars.current in misc$1) {
+  function tokenizeParenthesis(chars) {
+      if (chars.current === "(" || chars.current === ")") {
           const value = chars.shift();
-          const type = misc$1[value];
-          return { type, value };
+          return parenthesis[value];
       }
       return null;
   }
@@ -7430,7 +7435,12 @@
       }
       return null;
   }
+  const FIRST_POSSIBLE_NUMBER_CHARS = new Set("0123456789");
   function tokenizeNumber(chars, locale) {
+      if (!FIRST_POSSIBLE_NUMBER_CHARS.has(chars.current) &&
+          chars.current !== locale.decimalSeparator) {
+          return null;
+      }
       const match = chars.remaining().match(getFormulaNumberRegex(locale.decimalSeparator));
       if (match) {
           chars.advanceBy(match[0].length);
@@ -7455,7 +7465,7 @@
       }
       return null;
   }
-  const separatorRegexp = /\w|\.|!|\$/;
+  const separatorRegexp = /^[\w\.!\$]+/;
   /**
    * A "Symbol" is just basically any word-like element that can appear in a
    * formula, which is not a string. So:
@@ -7495,8 +7505,11 @@
               };
           }
       }
-      while (chars.current && separatorRegexp.test(chars.current)) {
-          result += chars.shift();
+      const match = chars.remaining().match(separatorRegexp);
+      if (match) {
+          const value = match[0];
+          result += value;
+          chars.advanceBy(value.length);
       }
       if (result.length) {
           const value = result;
@@ -7558,7 +7571,10 @@
           return this.text.substring(this.currentIndex);
       }
       currentStartsWith(str) {
-          for (let j = 0; j < str.length; j++) {
+          if (this.current !== str[0]) {
+              return false;
+          }
+          for (let j = 1; j < str.length; j++) {
               if (this.text[this.currentIndex + j] !== str[j]) {
                   return false;
               }
@@ -7585,6 +7601,9 @@
       if (locale.formulaArgSeparator === locale.decimalSeparator) {
           return false;
       }
+      if (locale.thousandsSeparator === locale.decimalSeparator) {
+          return false;
+      }
       try {
           formatValue(1, { locale, format: "#,##0.00" });
           formatValue(1, { locale, format: locale.dateFormat });
@@ -7675,7 +7694,7 @@
       if (locale.decimalSeparator === "." || !isNumber(content, locale)) {
           return content;
       }
-      return content.replace(locale.decimalSeparator, ".");
+      return content.replace(locale.thousandsSeparator, "").replace(locale.decimalSeparator, ".");
   }
   /**
    * Change a content string from the given locale to its canonical form (en_US locale). Also convert date string.
@@ -10747,6 +10766,12 @@
       let { col, row } = env.model.getters.getActivePosition();
       env.model.dispatch("OPEN_CELL_POPOVER", { col, row, popoverType: "LinkEditor" });
   };
+  const INSERT_LINK_NAME = (env) => {
+      const sheetId = env.model.getters.getActiveSheetId();
+      const { col, row } = env.model.getters.getActivePosition();
+      const cell = env.model.getters.getEvaluatedCell({ sheetId, col, row });
+      return cell && cell.link ? _t("Edit link") : _t("Insert link");
+  };
   //------------------------------------------------------------------------------
   // Filters action
   //------------------------------------------------------------------------------
@@ -19778,7 +19803,7 @@
   })
       .add("insert_link", {
       ...insertLink,
-      name: _t("Insert link"),
+      name: INSERT_LINK_NAME,
       sequence: 150,
       separator: true,
   });
@@ -26031,6 +26056,17 @@
 `;
   class TextValueProvider extends owl.Component {
       static template = "o-spreadsheet-TextValueProvider";
+      autoCompleteListRef = owl.useRef("autoCompleteList");
+      setup() {
+          owl.useEffect(() => {
+              const selectedIndex = this.props.selectedIndex;
+              if (selectedIndex === undefined) {
+                  return;
+              }
+              const selectedElement = this.autoCompleteListRef.el?.children[selectedIndex];
+              selectedElement?.scrollIntoView?.({ block: "nearest" });
+          }, () => [this.props.selectedIndex, this.autoCompleteListRef.el]);
+      }
   }
   TextValueProvider.props = {
       values: Array,
@@ -26482,6 +26518,7 @@
       position: absolute;
       margin: 1px 4px;
       pointer-events: none;
+      overflow: auto;
 
       .o-semi-bold {
         /** FIXME: to remove in favor of Bootstrap
@@ -26497,6 +26534,7 @@
       static components = { TextValueProvider, FunctionDescriptionProvider };
       static defaultProps = {
           inputStyle: "",
+          isDefaultFocus: false,
       };
       composerRef = owl.useRef("o_composer");
       contentHelper = new ContentEditableHelper(this.composerRef.el);
@@ -26527,7 +26565,10 @@
           if (this.props.delimitation && this.props.rect) {
               const { x: cellX, y: cellY, height: cellHeight } = this.props.rect;
               const remainingHeight = this.props.delimitation.height - (cellY + cellHeight);
+              assistantStyle["max-height"] = `${remainingHeight}px`;
               if (cellY > remainingHeight) {
+                  const availableSpaceAbove = cellY;
+                  assistantStyle["max-height"] = `${availableSpaceAbove}px`;
                   // render top
                   // We compensate 2 px of margin on the assistant style + 1px for design reasons
                   assistantStyle.top = `-3px`;
@@ -26553,7 +26594,6 @@
           F2: () => console.warn("Not implemented"),
           F4: this.processF4Key,
           Tab: (ev) => this.processTabKey(ev),
-          " ": (ev) => this.processSpaceKey(ev),
       };
       keyCodeMapping = {
           NumpadDecimal: this.processNumpadDecimal,
@@ -26561,12 +26601,12 @@
       setup() {
           owl.onMounted(() => {
               const el = this.composerRef.el;
+              if (this.props.isDefaultFocus) {
+                  this.env.focusableElement.setFocusableElement(el);
+              }
               this.contentHelper.updateEl(el);
               this.processTokenAtCursor();
           });
-          owl.onWillUnmount(() => {
-              this.props.onComposerUnmounted?.();
-          });
           owl.useEffect(() => {
               this.processContent();
           });
@@ -26575,7 +26615,8 @@
       // Handlers
       // ---------------------------------------------------------------------------
       processArrowKeys(ev) {
-          if (this.env.model.getters.isSelectingForComposer()) {
+          if (this.env.model.getters.isSelectingForComposer() ||
+              this.env.model.getters.getEditionMode() === "inactive") {
               this.functionDescriptionState.showDescription = false;
               // Prevent the default content editable behavior which moves the cursor
               ev.preventDefault();
@@ -26618,26 +26659,20 @@
       processTabKey(ev) {
           ev.preventDefault();
           ev.stopPropagation();
-          const state = this.autoCompleteState;
-          if (state.showProvider && state.selectedIndex !== undefined) {
-              const autoCompleteValue = this.autoCompleteState.values[state.selectedIndex]?.text;
-              if (autoCompleteValue) {
-                  this.autoComplete(autoCompleteValue);
-                  return;
+          if (this.env.model.getters.getEditionMode() !== "inactive") {
+              const state = this.autoCompleteState;
+              if (state.showProvider && state.selectedIndex !== undefined) {
+                  const autoCompleteValue = this.autoCompleteState.values[state.selectedIndex]?.text;
+                  if (autoCompleteValue) {
+                      this.autoComplete(autoCompleteValue);
+                      return;
+                  }
               }
+              interactiveStopEdition(this.env);
           }
           const direction = ev.shiftKey ? "left" : "right";
-          interactiveStopEdition(this.env);
           this.env.model.selection.moveAnchorCell(direction, 1);
       }
-      processSpaceKey(ev) {
-          if (ev.ctrlKey) {
-              ev.preventDefault();
-              ev.stopPropagation();
-              this.showFunctionAutocomplete("");
-              this.env.model.dispatch("STOP_COMPOSER_RANGE_SELECTION");
-          }
-      }
       processEnterKey(ev) {
           ev.preventDefault();
           ev.stopPropagation();
@@ -26690,6 +26725,9 @@
           this.compositionActive = false;
       }
       onKeydown(ev) {
+          if (this.env.model.getters.getEditionMode() === "inactive") {
+              return;
+          }
           let handler = this.keyMapping[ev.key] || this.keyCodeMapping[ev.code];
           if (handler) {
               handler.call(this, ev);
@@ -26698,14 +26736,33 @@
               ev.stopPropagation();
           }
       }
+      onPaste(ev) {
+          if (this.env.model.getters.getEditionMode() !== "inactive") {
+              ev.stopPropagation();
+          }
+      }
       /*
        * Triggered automatically by the content-editable between the keydown and key up
        * */
       onInput(ev) {
-          if (this.props.focus === "inactive" || !this.shouldProcessInputEvents) {
+          if (!this.shouldProcessInputEvents) {
               return;
           }
-          let content = this.contentHelper.getText();
+          if (ev.inputType === "insertFromPaste" &&
+              this.env.model.getters.getEditionMode() === "inactive") {
+              return;
+          }
+          ev.stopPropagation();
+          let content;
+          if (this.env.model.getters.getEditionMode() === "inactive") {
+              content = ev.data || "";
+          }
+          else {
+              content = this.contentHelper.getText();
+          }
+          if (this.props.focus === "inactive") {
+              return this.props.onComposerCellFocused?.(content);
+          }
           let selection = this.contentHelper.getCurrentSelection();
           if (ev.inputType === "insertParagraph") {
               const start = Math.min(selection.start, selection.end);
@@ -26787,9 +26844,8 @@
           }
           const newSelection = this.contentHelper.getCurrentSelection();
           this.env.model.dispatch("STOP_COMPOSER_RANGE_SELECTION");
-          if (this.props.focus === "inactive") {
-              this.props.onComposerContentFocused(newSelection);
-          }
+          this.props.onComposerContentFocused();
+          if (this.props.focus === "inactive") ;
           this.env.model.dispatch("CHANGE_COMPOSER_CURSOR_SELECTION", newSelection);
           this.processTokenAtCursor();
       }
@@ -26956,7 +27012,7 @@
           const highlights = this.env.model.getters.getHighlights();
           const refSheet = sheetName
               ? this.env.model.getters.getSheetIdByName(sheetName)
-              : this.env.model.getters.getCurrentEditedCell().sheetId;
+              : this.env.model.getters.getCurrentEditedCell()?.sheetId;
           const highlight = highlights.find((highlight) => {
               if (highlight.sheetId !== refSheet)
                   return false;
@@ -27049,12 +27105,13 @@
       }
   }
   Composer.props = {
-      focus: { validate: (value) => ["inactive", "cellFocus", "contentFocus"].includes(value) },
-      onComposerContentFocused: Function,
       inputStyle: { type: String, optional: true },
       rect: { type: Object, optional: true },
       delimitation: { type: Object, optional: true },
-      onComposerUnmounted: { type: Function, optional: true },
+      focus: { validate: (value) => ["inactive", "cellFocus", "contentFocus"].includes(value) },
+      onComposerCellFocused: { type: Function, optional: true },
+      onComposerContentFocused: Function,
+      isDefaultFocus: { type: Boolean, optional: true },
   };
 
   const COMPOSER_BORDER_WIDTH = 3 * 0.4 * window.devicePixelRatio || 1;
@@ -27088,51 +27145,25 @@
   class GridComposer extends owl.Component {
       static template = "o-spreadsheet-GridComposer";
       static components = { Composer };
-      gridComposerRef;
-      zone;
-      rect;
+      rect = this.defaultRect;
+      isEditing = false;
       isCellReferenceVisible;
-      composerState;
+      get defaultRect() {
+          return { x: 0, y: 0, width: 0, height: 0 };
+      }
       setup() {
-          this.gridComposerRef = owl.useRef("gridComposer");
-          this.composerState = owl.useState({
-              rect: undefined,
-              delimitation: undefined,
-          });
-          const { sheetId, col, row } = this.env.model.getters.getActivePosition();
-          this.zone = this.env.model.getters.expandZone(sheetId, positionToZone({ col, row }));
-          this.rect = this.env.model.getters.getVisibleRect(this.zone);
-          this.isCellReferenceVisible = false;
-          owl.onMounted(() => {
-              const el = this.gridComposerRef.el;
-              this.composerState.rect = {
-                  x: this.rect.x,
-                  y: this.rect.y,
-                  width: el.clientWidth,
-                  height: el.clientHeight,
-              };
-              this.composerState.delimitation = {
-                  width: this.props.gridDims.width,
-                  height: this.props.gridDims.height,
-              };
-          });
           owl.onWillUpdateProps(() => {
-              if (this.isCellReferenceVisible) {
-                  return;
-              }
-              const sheetId = this.env.model.getters.getActiveSheetId();
-              const zone = this.env.model.getters.getSelectedZone();
-              const rect = this.env.model.getters.getVisibleRect(zone);
-              if (!deepEquals(rect, this.rect) ||
-                  sheetId !== this.env.model.getters.getCurrentEditedCell().sheetId) {
-                  this.isCellReferenceVisible = true;
-              }
+              this.updateComponentPosition();
+              this.updateCellReferenceVisibility();
           });
       }
       get shouldDisplayCellReference() {
           return this.isCellReferenceVisible;
       }
       get cellReference() {
+          if (!this.env.model.getters.getCurrentEditedCell()) {
+              return "";
+          }
           const { col, row, sheetId } = this.env.model.getters.getCurrentEditedCell();
           const prefixSheet = sheetId !== this.env.model.getters.getActiveSheetId();
           return `${prefixSheet ? getCanonicalSheetName(this.env.model.getters.getSheetName(sheetId)) + "!" : ""}${toXC(col, row)}`;
@@ -27144,7 +27175,27 @@
               top: `${top - GRID_CELL_REFERENCE_TOP_OFFSET}px`,
           });
       }
+      get composerProps() {
+          const { width, height } = this.env.model.getters.getSheetViewDimensionWithHeaders();
+          return {
+              rect: { ...this.rect },
+              delimitation: {
+                  width,
+                  height,
+              },
+              focus: this.props.focus,
+              isDefaultFocus: true,
+              onComposerContentFocused: this.props.onComposerContentFocused,
+              onComposerCellFocused: this.props.onComposerCellFocused,
+          };
+      }
       get containerStyle() {
+          if (this.env.model.getters.getEditionMode() === "inactive" || !this.rect) {
+              return `
+        position: absolute;
+        z-index: -1000;
+      `;
+          }
           const isFormula = this.env.model.getters.getCurrentContent().startsWith("=");
           const cell = this.env.model.getters.getActiveCell();
           const position = this.env.model.getters.getActivePosition();
@@ -27164,6 +27215,8 @@
           if (!isFormula) {
               textAlign = style.align || cell.defaultAlign;
           }
+          const maxHeight = this.props.gridDims.height - this.rect.y;
+          const maxWidth = this.props.gridDims.width - this.rect.x;
           /**
            * min-size is on the container, not the composer element, because we want to have the same size as the cell by default,
            * including all the paddings/margins of the composer
@@ -27175,6 +27228,8 @@
               top: `${top}px`,
               "min-width": `${width + 1}px`,
               "min-height": `${height + 1}px`,
+              "max-width": `${maxWidth}px`,
+              "max-height": `${maxHeight}px`,
               background,
               color,
               "font-size": `${fontSizeInPixels(fontSize)}px`,
@@ -27184,20 +27239,38 @@
               "text-align": textAlign,
           });
       }
-      get composerStyle() {
-          const maxHeight = this.props.gridDims.height - this.rect.y;
-          const maxWidth = this.props.gridDims.width - this.rect.x;
-          return cssPropertiesToCss({
-              "max-width": `${maxWidth}px`,
-              "max-height": `${maxHeight}px`,
-          });
+      updateComponentPosition() {
+          const isEditing = this.env.model.getters.getEditionMode() !== "inactive";
+          if (this.isEditing !== isEditing) {
+              this.isEditing = isEditing;
+              if (!isEditing) {
+                  this.rect = this.defaultRect;
+                  this.env.focusableElement.focus();
+                  return;
+              }
+              const position = this.env.model.getters.getActivePosition();
+              const zone = this.env.model.getters.expandZone(position.sheetId, positionToZone(position));
+              this.rect = this.env.model.getters.getVisibleRect(zone);
+          }
+      }
+      updateCellReferenceVisibility() {
+          if (this.isCellReferenceVisible || this.env.model.getters.getEditionMode() === "inactive") {
+              return;
+          }
+          const sheetId = this.env.model.getters.getActiveSheetId();
+          const zone = this.env.model.getters.getSelectedZone();
+          const rect = this.env.model.getters.getVisibleRect(zone);
+          if (!deepEquals(rect, this.rect) ||
+              sheetId !== this.env.model.getters.getCurrentEditedCell().sheetId) {
+              this.isCellReferenceVisible = true;
+          }
       }
   }
   GridComposer.props = {
       focus: { validate: (value) => ["inactive", "cellFocus", "contentFocus"].includes(value) },
-      onComposerUnmounted: Function,
       onComposerContentFocused: Function,
       gridDims: Object,
+      onComposerCellFocused: Function,
   };
 
   const CSS$1 = css /* scss */ `
@@ -28288,7 +28361,6 @@
           this.props.onCellDoubleClicked(col, row);
       }
       onContextMenu(ev) {
-          ev.preventDefault();
           const [col, row] = this.getCartesianCoordinates(ev);
           this.props.onCellRightClicked(col, row, { x: ev.clientX, y: ev.clientY });
       }
@@ -29373,7 +29445,6 @@
       HEADER_WIDTH = HEADER_WIDTH;
       menuState;
       gridRef;
-      hiddenInput;
       onMouseWheel;
       canvasPosition;
       hoveredCell;
@@ -29384,17 +29455,16 @@
               menuItems: [],
           });
           this.gridRef = owl.useRef("grid");
-          this.hiddenInput = owl.useRef("hiddenInput");
           this.canvasPosition = useAbsoluteBoundingRect(this.gridRef);
           this.hoveredCell = owl.useState({ col: undefined, row: undefined });
           owl.useChildSubEnv({ getPopoverContainerRect: () => this.getGridRect() });
           owl.useExternalListener(document.body, "cut", this.copy.bind(this, true));
           owl.useExternalListener(document.body, "copy", this.copy.bind(this, false));
           owl.useExternalListener(document.body, "paste", this.paste);
-          owl.onMounted(() => this.focus());
-          this.props.exposeFocus(() => this.focus());
+          owl.onMounted(() => this.focusDefaultElement());
+          this.props.exposeFocus(() => this.focusDefaultElement());
           useGridDrawing("canvas", this.env.model, () => this.env.model.getters.getSheetViewDimensionWithHeaders());
-          owl.useEffect(() => this.focus(), () => [this.env.model.getters.getActiveSheetId()]);
+          owl.useEffect(() => this.focusDefaultElement(), () => [this.env.model.getters.getActiveSheetId()]);
           this.onMouseWheel = useWheelHandler((deltaX, deltaY) => {
               this.moveCanvas(deltaX, deltaY);
               this.hoveredCell.col = undefined;
@@ -29417,7 +29487,7 @@
           if (this.env.model.getters.hasOpenedPopover()) {
               this.closeOpenedPopover();
           }
-          this.focus();
+          this.focusDefaultElement();
       }
       // this map will handle most of the actions that should happen on key down. The arrow keys are managed in the key
       // down itself
@@ -29596,10 +29666,10 @@
           "ALT+SHIFT+ARROWUP": () => this.processHeaderGroupingKey("up"),
           "ALT+SHIFT+ARROWDOWN": () => this.processHeaderGroupingKey("down"),
       };
-      focus() {
+      focusDefaultElement() {
           if (!this.env.model.getters.getSelectedFigureId() &&
               this.env.model.getters.getEditionMode() === "inactive") {
-              this.hiddenInput.el?.focus();
+              this.env.focusableElement.focus();
           }
       }
       get gridEl() {
@@ -29744,19 +29814,6 @@
               return;
           }
       }
-      onInput(ev) {
-          // the user meant to paste in the sheet, not open the composer with the pasted content
-          if (!ev.isComposing && ev.inputType === "insertFromPaste") {
-              return;
-          }
-          if (ev.data) {
-              // if the user types a character on the grid, it means he wants to start composing the selected cell with that
-              // character
-              ev.preventDefault();
-              ev.stopPropagation();
-              this.props.onGridComposerCellFocused(ev.data);
-          }
-      }
       // ---------------------------------------------------------------------------
       // Context Menu
       // ---------------------------------------------------------------------------
@@ -29871,7 +29928,7 @@
       }
       closeMenu() {
           this.menuState.isOpen = false;
-          this.focus();
+          this.focusDefaultElement();
       }
       processHeaderGroupingKey(direction) {
           if (this.env.model.getters.getSelectedZones().length !== 1) {
@@ -33766,6 +33823,31 @@
               return data;
           },
       },
+      {
+          description: "Fix datafilter duplication",
+          from: 12,
+          to: 12.5,
+          applyMigration(data) {
+              for (let sheet of data.sheets || []) {
+                  let knownDataFilterZones = [];
+                  for (let filterTable of sheet.filterTables || []) {
+                      const zone = toZone(filterTable.range);
+                      // See commit message for the details
+                      const intersectZoneIndex = knownDataFilterZones.findIndex((knownZone) => overlap(knownZone, zone));
+                      if (intersectZoneIndex !== -1) {
+                          knownDataFilterZones[intersectZoneIndex] = zone;
+                      }
+                      else {
+                          knownDataFilterZones.push(zone);
+                      }
+                  }
+                  sheet.filterTables = knownDataFilterZones.map((zone) => ({
+                      range: zoneToXc(zone),
+                  }));
+              }
+              return data;
+          },
+      },
       {
           description: "Change Border description structure",
           from: 12,
@@ -34605,22 +34687,7 @@
           }
       }
       export(data) {
-          // Borders
-          let borderId = 0;
           const borders = {};
-          /**
-           * Get the id of the given border. If the border does not exist, it creates
-           * one.
-           */
-          function getBorderId(border) {
-              for (let [key, value] of Object.entries(borders)) {
-                  if (deepEquals(value, border)) {
-                      return parseInt(key, 10);
-                  }
-              }
-              borders[++borderId] = border;
-              return borderId;
-          }
           for (let sheet of data.sheets) {
               for (let col = 0; col < sheet.colNumber; col++) {
                   for (let row = 0; row < sheet.rowNumber; row++) {
@@ -34628,7 +34695,7 @@
                       if (border) {
                           const xc = toXC(col, row);
                           const cell = sheet.cells[xc];
-                          const borderId = getBorderId(border);
+                          const borderId = getItemId(border, borders);
                           if (cell) {
                               cell.border = borderId;
                           }
@@ -35433,9 +35500,9 @@
       allowDispatch(cmd) {
           switch (cmd.type) {
               case "UPDATE_CELL":
-                  return this.checkCellOutOfSheet(cmd);
+                  return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
               case "CLEAR_CELL":
-                  return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                  return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
               default:
                   return "Success" /* CommandResult.Success */;
           }
@@ -35568,9 +35635,6 @@
                       format: cell.format ? getItemId(cell.format, formats) : undefined,
                       content: cell.content || undefined,
                   };
-                  if (cell instanceof FormulaCellWithDependencies) {
-                      cells[xc].content = cell.contentWithFixedReferences || undefined;
-                  }
               }
               _sheet.cells = cells;
           }
@@ -35588,8 +35652,8 @@
       }
       removeDefaultStyleValues(style) {
           const cleanedStyle = { ...style };
-          for (const [property, defaultValue] of Object.entries(DEFAULT_STYLE)) {
-              if (cleanedStyle[property] === defaultValue) {
+          for (const property in DEFAULT_STYLE) {
+              if (cleanedStyle[property] === DEFAULT_STYLE[property]) {
                   delete cleanedStyle[property];
               }
           }
@@ -35746,10 +35810,7 @@
           else {
               style = before ? before.style : undefined;
           }
-          const locale = this.getters.getLocale();
-          let format = ("format" in after ? after.format : before && before.format) ||
-              detectDateFormat(afterContent, locale) ||
-              detectNumberFormat(afterContent);
+          const format = "format" in after ? after.format : before && before.format;
           /* Read the following IF as:
            * we need to remove the cell if it is completely empty, but we can know if it completely empty if:
            * - the command says the new content is empty and has no border/format/style
@@ -35790,12 +35851,11 @@
       }
       createLiteralCell(id, content, format, style) {
           const locale = this.getters.getLocale();
-          content = parseLiteral(content, locale).toString();
           return {
               id,
-              content,
+              content: parseLiteral(content, locale).toString(),
               style,
-              format,
+              format: format || detectDateFormat(content, locale) || detectNumberFormat(content),
               isFormula: false,
           };
       }
@@ -35821,8 +35881,11 @@
        * being a computed property to rebuild the dependencies XC.
        */
       createFormulaCellWithDependencies(id, compiledFormula, format, style, sheetId) {
-          const dependencies = compiledFormula.dependencies.map((xc) => this.getters.getRangeFromSheetXC(sheetId, xc));
-          return new FormulaCellWithDependencies(id, compiledFormula, format, style, dependencies, sheetId, this.getters.getRangeString.bind(this));
+          const dependencies = [];
+          for (const xc of compiledFormula.dependencies) {
+              dependencies.push(this.getters.getRangeFromSheetXC(sheetId, xc));
+          }
+          return new FormulaCellWithDependencies(id, compiledFormula, format, style, dependencies, sheetId, this.getters.getRangeString);
       }
       createErrorFormula(id, content, format, style, error) {
           return {
@@ -35857,6 +35920,18 @@
           }
           return "Success" /* CommandResult.Success */;
       }
+      checkUselessUpdateCell(cmd) {
+          const cell = this.getters.getCell(cmd);
+          const hasContent = "content" in cmd || "formula" in cmd;
+          const hasStyle = "style" in cmd;
+          const hasFormat = "format" in cmd;
+          if ((!hasContent || cell?.content === cmd.content) &&
+              (!hasStyle || deepEquals(cell?.style, cmd.style)) &&
+              (!hasFormat || cell?.format === cmd.format)) {
+              return "NoChanges" /* CommandResult.NoChanges */;
+          }
+          return "Success" /* CommandResult.Success */;
+      }
   }
   class FormulaCellWithDependencies {
       id;
@@ -35876,7 +35951,7 @@
           const tokens = compiledFormula.tokens.map((token) => {
               if (token.type === "REFERENCE") {
                   const index = rangeIndex++;
-                  return new RangeReferenceToken(() => this.getRangeString(dependencies[index], this.sheetId));
+                  return new RangeReferenceToken(dependencies, index, this.sheetId, this.getRangeString);
               }
               return token;
           });
@@ -35903,13 +35978,20 @@
       }
   }
   class RangeReferenceToken {
-      getValue;
+      ranges;
+      rangeIndex;
+      sheetId;
+      getRangeString;
       type = "REFERENCE";
-      constructor(getValue) {
-          this.getValue = getValue;
+      constructor(ranges, rangeIndex, sheetId, getRangeString) {
+          this.ranges = ranges;
+          this.rangeIndex = rangeIndex;
+          this.sheetId = sheetId;
+          this.getRangeString = getRangeString;
       }
       get value() {
-          return this.getValue();
+          const range = this.ranges[this.rangeIndex];
+          return this.getRangeString(range, this.sheetId);
       }
   }
 
@@ -40645,7 +40727,15 @@
           if (!this.rTrees[sheetId]) {
               return;
           }
-          this.rTrees[sheetId].remove(item, deepEquals);
+          this.rTrees[sheetId].remove(item, this.rtreeItemComparer);
+      }
+      rtreeItemComparer(left, right) {
+          return (left.data == right.data &&
+              left.boundingBox.sheetId === right.boundingBox.sheetId &&
+              left.boundingBox?.zone.left === right.boundingBox.zone.left &&
+              left.boundingBox?.zone.top === right.boundingBox.zone.top &&
+              left.boundingBox?.zone.right === right.boundingBox.zone.right &&
+              left.boundingBox?.zone.bottom === right.boundingBox.zone.bottom);
       }
   }
   /**
@@ -40723,7 +40813,7 @@
           const queue = Array.from(ranges).reverse();
           while (queue.length > 0) {
               const range = queue.pop();
-              visited.add(...this.encoder.encodeBoundingBox(range));
+              visited.addMany(this.encoder.encodeBoundingBox(range));
               const impactedPositionIds = this.rTree.search(range).map((dep) => dep.data);
               for (const positionId of impactedPositionIds) {
                   if (!visited.has(positionId)) {
@@ -40731,7 +40821,7 @@
                   }
               }
           }
-          visited.delete(...ranges.flatMap((r) => this.encoder.encodeBoundingBox(r)));
+          visited.deleteMany(ranges.flatMap((r) => this.encoder.encodeBoundingBox(r)));
           return visited;
       }
   }
@@ -40869,9 +40959,9 @@
           const cells = positions.map((p) => this.encoder.encode(p));
           const cellsToCompute = new JetSet(cells);
           const arrayFormulasPositionIds = this.getArrayFormulasImpactedByChangesOf(cells);
-          cellsToCompute.add(...this.getCellsDependingOn(cells));
-          cellsToCompute.add(...arrayFormulasPositionIds);
-          cellsToCompute.add(...this.getCellsDependingOn(arrayFormulasPositionIds));
+          cellsToCompute.addMany(this.getCellsDependingOn(cells));
+          cellsToCompute.addMany(arrayFormulasPositionIds);
+          cellsToCompute.addMany(this.getCellsDependingOn(arrayFormulasPositionIds));
           this.evaluate(cellsToCompute);
       }
       getArrayFormulasImpactedByChangesOf(positionIds) {
@@ -40885,7 +40975,7 @@
               }
               if (!content) {
                   // The previous content could have blocked some array formulas
-                  impactedPositionIds.add(...this.getArrayFormulasBlockedByOrSpreadingOn(positionId));
+                  impactedPositionIds.addMany(this.getArrayFormulasBlockedByOrSpreadingOn(positionId));
               }
           }
           return impactedPositionIds;
@@ -40934,7 +41024,7 @@
           }
           const arrayFormulas = this.spreadingRelations.getFormulaPositionsSpreadingOn(positionId);
           const cells = new JetSet(arrayFormulas);
-          cells.add(...this.getCellsDependingOn(arrayFormulas));
+          cells.addMany(this.getCellsDependingOn(arrayFormulas));
           return cells;
       }
       nextPositionsToUpdate = new JetSet();
@@ -41083,7 +41173,7 @@
               this.setEvaluatedCell(positionId, evaluatedCell);
               // check if formula dependencies present in the spread zone
               // if so, they need to be recomputed
-              this.nextPositionsToUpdate.add(...this.getCellsDependingOn([positionId]));
+              this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([positionId]));
           };
       }
       invalidateSpreading(positionId) {
@@ -41098,8 +41188,8 @@
                   continue;
               }
               this.evaluatedCells.delete(child);
-              this.nextPositionsToUpdate.add(...this.getCellsDependingOn([child]));
-              this.nextPositionsToUpdate.add(...this.getArrayFormulasBlockedByOrSpreadingOn(child));
+              this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([child]));
+              this.nextPositionsToUpdate.addMany(this.getArrayFormulasBlockedByOrSpreadingOn(child));
           }
           this.spreadingRelations.removeNode(positionId);
       }
@@ -41448,7 +41538,13 @@
               const format = newFormat
                   ? getItemId(newFormat, data.formats)
                   : exportedCellData.format;
-              const content = !isExported ? newContent : exportedCellData.content;
+              let content;
+              if (formulaCell instanceof FormulaCellWithDependencies) {
+                  content = this.getters.getFormulaCellContent(exportedSheetData.id, formulaCell.compiledFormula, formulaCell.compiledFormula.dependencies, true);
+              }
+              else {
+                  content = !isExported ? newContent : exportedCellData.content;
+              }
               exportedSheetData.cells[xc] = { ...exportedCellData, value, isFormula, content, format };
           }
       }
@@ -50764,6 +50860,16 @@
       }
   }
 
+  class FocusableElement {
+      focusableElement = undefined;
+      setFocusableElement(element) {
+          this.focusableElement = element;
+      }
+      focus() {
+          this.focusableElement?.focus();
+      }
+  }
+
   const RIPPLE_KEY_FRAMES = [
       { transform: "scale(0)" },
       { transform: "scale(0.8)", offset: 0.33 },
@@ -52920,6 +53026,7 @@
               toggleSidePanel: this.toggleSidePanel.bind(this),
               clipboard: this.env.clipboard || instantiateClipboard(),
               startCellEdition: (content) => this.onGridComposerCellFocused(content),
+              focusableElement: new FocusableElement(),
           });
           owl.useExternalListener(window, "resize", () => this.render(true));
           owl.useExternalListener(window, "beforeunload", this.unbindModelEvents.bind(this));
@@ -53026,16 +53133,17 @@
           }
           this.composer.topBarFocus = "contentFocus";
           this.composer.gridFocusMode = "inactive";
-          this.setComposerContent({ selection } || {});
+          this.setComposerContent({ selection });
       }
-      onGridComposerContentFocused() {
+      onGridComposerContentFocused(selection) {
           if (this.model.getters.isReadonly()) {
               return;
           }
           this.composer.topBarFocus = "inactive";
           this.composer.gridFocusMode = "contentFocus";
-          this.setComposerContent({});
+          this.setComposerContent({ selection });
       }
+      // TODO: either both are defined or none of them. change those args to an object
       onGridComposerCellFocused(content, selection) {
           if (this.model.getters.isReadonly()) {
               return;
@@ -54461,11 +54569,10 @@
        * next cluster if the given cell is outside a cluster or at the border of a cluster in the given direction.
        */
       getEndOfCluster(startPosition, dim, dir) {
-          const sheet = this.getters.getActiveSheet();
           let currentPosition = startPosition;
           // If both the current cell and the next cell are not empty, we want to go to the end of the cluster
           const nextCellPosition = this.getNextCellPosition(startPosition, dim, dir);
-          let mode = !this.isCellEmpty(currentPosition, sheet.id) && !this.isCellEmpty(nextCellPosition, sheet.id)
+          let mode = !this.isEvaluatedCellEmpty(currentPosition) && !this.isEvaluatedCellEmpty(nextCellPosition)
               ? "endOfCluster"
               : "nextCluster";
           while (true) {
@@ -54475,7 +54582,7 @@
                   currentPosition.row === nextCellPosition.row) {
                   break;
               }
-              const isNextCellEmpty = this.isCellEmpty(nextCellPosition, sheet.id);
+              const isNextCellEmpty = this.isEvaluatedCellEmpty(nextCellPosition);
               if (mode === "endOfCluster" && isNextCellEmpty) {
                   break;
               }
@@ -54489,10 +54596,20 @@
           return dim === "cols" ? currentPosition.col : currentPosition.row;
       }
       /**
-       * Check if a cell is empty or undefined in the model. If the cell is part of a merge,
-       * check if the merge containing the cell is empty.
+       * Checks if a cell is empty (i.e. does not have a content). If the cell is part of a merge,
+       * the check applies to the main cell of the merge.
+       */
+      isCellEmpty({ col, row }) {
+          const sheetId = this.getters.getActiveSheetId();
+          const position = this.getters.getMainCellPosition({ sheetId, col, row });
+          return !(this.getters.getCorrespondingFormulaCell(position) || this.getters.getCell(position)?.content);
+      }
+      /**
+       * Checks if a cell evaluated value is empty. If the cell is part of a merge,
+       * the check applies to the main cell of the merge.
        */
-      isCellEmpty({ col, row }, sheetId = this.getters.getActiveSheetId()) {
+      isEvaluatedCellEmpty({ col, row }) {
+          const sheetId = this.getters.getActiveSheetId();
           const position = this.getters.getMainCellPosition({ sheetId, col, row });
           const cell = this.getters.getEvaluatedCell(position);
           return cell.type === CellValueType.empty;
@@ -56798,9 +56915,9 @@
   exports.tokenize = tokenize;
 
 
-  __info__.version = "17.0.10";
-  __info__.date = "2024-02-02T13:48:28.727Z";
-  __info__.hash = "be06aa9";
+  __info__.version = "17.0.12";
+  __info__.date = "2024-02-16T14:24:02.984Z";
+  __info__.hash = "8fa2bab";
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);