@odoo/o-spreadsheet 16.4.28 → 16.4.30

package/dist/o-spreadsheet.cjs.js

@@ -617,7 +617,7 @@ function deepEquals(o1, o2) {
     if (typeof o1 !== typeof o2)
         return false;
     if (typeof o1 !== "object")
-        return o1 === o2;
+        return false;
     // Objects can have different keys if the values are undefined
     const keys = new Set();
     Object.keys(o1).forEach((key) => keys.add(key));
@@ -15801,6 +15801,7 @@ class LinkEditor extends owl.Component {
                     this.save();
                 }
                 ev.stopPropagation();
+                ev.preventDefault();
                 break;
             case "Escape":
                 this.cancel();
@@ -19340,6 +19341,243 @@ function interactiveAddFilter(env, sheetId, target) {
     }
 }
 
+function interactiveFreezeColumnsRows(env, dimension, base) {
+    const sheetId = env.model.getters.getActiveSheetId();
+    const cmd = dimension === "COL" ? "FREEZE_COLUMNS" : "FREEZE_ROWS";
+    const result = env.model.dispatch(cmd, { sheetId, quantity: base });
+    if (result.isCancelledBecause(68 /* CommandResult.MergeOverlap */)) {
+        env.raiseError(MergeErrorMessage);
+    }
+}
+
+const hideCols = {
+    name: HIDE_COLUMNS_NAME,
+    execute: (env) => {
+        const columns = env.model.getters.getElementsFromSelection("COL");
+        env.model.dispatch("HIDE_COLUMNS_ROWS", {
+            sheetId: env.model.getters.getActiveSheetId(),
+            dimension: "COL",
+            elements: columns,
+        });
+    },
+    isVisible: NOT_ALL_VISIBLE_COLS_SELECTED,
+    icon: "o-spreadsheet-Icon.HIDE_COL",
+};
+const unhideCols = {
+    name: _lt("Unhide columns"),
+    execute: (env) => {
+        const columns = env.model.getters.getElementsFromSelection("COL");
+        env.model.dispatch("UNHIDE_COLUMNS_ROWS", {
+            sheetId: env.model.getters.getActiveSheetId(),
+            dimension: "COL",
+            elements: columns,
+        });
+    },
+    isVisible: (env) => {
+        const hiddenCols = env.model.getters
+            .getHiddenColsGroups(env.model.getters.getActiveSheetId())
+            .flat();
+        const currentCols = env.model.getters.getElementsFromSelection("COL");
+        return currentCols.some((col) => hiddenCols.includes(col));
+    },
+};
+const unhideAllCols = {
+    name: _lt("Unhide all columns"),
+    execute: (env) => {
+        const sheetId = env.model.getters.getActiveSheetId();
+        env.model.dispatch("UNHIDE_COLUMNS_ROWS", {
+            sheetId,
+            dimension: "COL",
+            elements: Array.from(Array(env.model.getters.getNumberCols(sheetId)).keys()),
+        });
+    },
+    isVisible: (env) => env.model.getters.getHiddenColsGroups(env.model.getters.getActiveSheetId()).length > 0,
+};
+const hideRows = {
+    name: HIDE_ROWS_NAME,
+    execute: (env) => {
+        const rows = env.model.getters.getElementsFromSelection("ROW");
+        env.model.dispatch("HIDE_COLUMNS_ROWS", {
+            sheetId: env.model.getters.getActiveSheetId(),
+            dimension: "ROW",
+            elements: rows,
+        });
+    },
+    isVisible: NOT_ALL_VISIBLE_ROWS_SELECTED,
+    icon: "o-spreadsheet-Icon.HIDE_ROW",
+};
+const unhideRows = {
+    name: _lt("Unhide rows"),
+    execute: (env) => {
+        const columns = env.model.getters.getElementsFromSelection("ROW");
+        env.model.dispatch("UNHIDE_COLUMNS_ROWS", {
+            sheetId: env.model.getters.getActiveSheetId(),
+            dimension: "ROW",
+            elements: columns,
+        });
+    },
+    isVisible: (env) => {
+        const hiddenRows = env.model.getters
+            .getHiddenRowsGroups(env.model.getters.getActiveSheetId())
+            .flat();
+        const currentRows = env.model.getters.getElementsFromSelection("ROW");
+        return currentRows.some((col) => hiddenRows.includes(col));
+    },
+};
+const unhideAllRows = {
+    name: _lt("Unhide all rows"),
+    execute: (env) => {
+        const sheetId = env.model.getters.getActiveSheetId();
+        env.model.dispatch("UNHIDE_COLUMNS_ROWS", {
+            sheetId,
+            dimension: "ROW",
+            elements: Array.from(Array(env.model.getters.getNumberRows(sheetId)).keys()),
+        });
+    },
+    isVisible: (env) => env.model.getters.getHiddenRowsGroups(env.model.getters.getActiveSheetId()).length > 0,
+};
+const unFreezePane = {
+    name: _lt("Unfreeze"),
+    isVisible: (env) => {
+        const { xSplit, ySplit } = env.model.getters.getPaneDivisions(env.model.getters.getActiveSheetId());
+        return xSplit + ySplit > 0;
+    },
+    execute: (env) => env.model.dispatch("UNFREEZE_COLUMNS_ROWS", {
+        sheetId: env.model.getters.getActiveSheetId(),
+    }),
+    icon: "o-spreadsheet-Icon.UNFREEZE",
+};
+const freezePane = {
+    name: _lt("Freeze"),
+    icon: "o-spreadsheet-Icon.FREEZE",
+};
+const unFreezeRows = {
+    name: _lt("No rows"),
+    execute: (env) => env.model.dispatch("UNFREEZE_ROWS", {
+        sheetId: env.model.getters.getActiveSheetId(),
+    }),
+    isReadonlyAllowed: true,
+    isVisible: (env) => !!env.model.getters.getPaneDivisions(env.model.getters.getActiveSheetId()).ySplit,
+};
+const freezeFirstRow = {
+    name: _lt("1 row"),
+    execute: (env) => interactiveFreezeColumnsRows(env, "ROW", 1),
+    isReadonlyAllowed: true,
+};
+const freezeSecondRow = {
+    name: _lt("2 rows"),
+    execute: (env) => interactiveFreezeColumnsRows(env, "ROW", 2),
+    isReadonlyAllowed: true,
+};
+const freezeCurrentRow = {
+    name: _lt("Up to current row"),
+    execute: (env) => {
+        const { bottom } = env.model.getters.getSelectedZone();
+        interactiveFreezeColumnsRows(env, "ROW", bottom + 1);
+    },
+    isReadonlyAllowed: true,
+};
+const unFreezeCols = {
+    name: _lt("No columns"),
+    execute: (env) => env.model.dispatch("UNFREEZE_COLUMNS", {
+        sheetId: env.model.getters.getActiveSheetId(),
+    }),
+    isReadonlyAllowed: true,
+    isVisible: (env) => !!env.model.getters.getPaneDivisions(env.model.getters.getActiveSheetId()).xSplit,
+};
+const freezeFirstCol = {
+    name: _lt("1 column"),
+    execute: (env) => interactiveFreezeColumnsRows(env, "COL", 1),
+    isReadonlyAllowed: true,
+};
+const freezeSecondCol = {
+    name: _lt("2 columns"),
+    execute: (env) => interactiveFreezeColumnsRows(env, "COL", 2),
+    isReadonlyAllowed: true,
+};
+const freezeCurrentCol = {
+    name: _lt("Up to current column"),
+    execute: (env) => {
+        const { right } = env.model.getters.getSelectedZone();
+        interactiveFreezeColumnsRows(env, "COL", right + 1);
+    },
+    isReadonlyAllowed: true,
+};
+const viewGridlines = {
+    name: (env) => env.model.getters.getGridLinesVisibility(env.model.getters.getActiveSheetId())
+        ? _lt("Hide gridlines")
+        : _lt("Show gridlines"),
+    execute: (env) => {
+        const sheetId = env.model.getters.getActiveSheetId();
+        env.model.dispatch("SET_GRID_LINES_VISIBILITY", {
+            sheetId,
+            areGridLinesVisible: !env.model.getters.getGridLinesVisibility(sheetId),
+        });
+    },
+    icon: "o-spreadsheet-Icon.SHOW_HIDE_GRID",
+};
+const viewFormulas = {
+    name: (env) => env.model.getters.shouldShowFormulas() ? _lt("Hide formulas") : _lt("Show formulas"),
+    execute: (env) => env.model.dispatch("SET_FORMULA_VISIBILITY", { show: !env.model.getters.shouldShowFormulas() }),
+    isReadonlyAllowed: true,
+    icon: "o-spreadsheet-Icon.SHOW_HIDE_FORMULA",
+};
+const createRemoveFilter = {
+    name: (env) => selectionContainsFilter(env) ? _lt("Remove selected filters") : _lt("Create filter"),
+    isActive: (env) => selectionContainsFilter(env),
+    isEnabled: (env) => !cannotCreateFilter(env),
+    execute: (env) => createRemoveFilterAction(env),
+    icon: "o-spreadsheet-Icon.FILTER_ICON_INACTIVE",
+};
+function selectionContainsFilter(env) {
+    const sheetId = env.model.getters.getActiveSheetId();
+    const selectedZones = env.model.getters.getSelectedZones();
+    return env.model.getters.doesZonesContainFilter(sheetId, selectedZones);
+}
+function cannotCreateFilter(env) {
+    return !areZonesContinuous(...env.model.getters.getSelectedZones());
+}
+function createRemoveFilterAction(env) {
+    if (selectionContainsFilter(env)) {
+        env.model.dispatch("REMOVE_FILTER_TABLE", {
+            sheetId: env.model.getters.getActiveSheetId(),
+            target: env.model.getters.getSelectedZones(),
+        });
+        return;
+    }
+    if (cannotCreateFilter(env)) {
+        return;
+    }
+    env.model.selection.selectTableAroundSelection();
+    const sheetId = env.model.getters.getActiveSheetId();
+    const selection = env.model.getters.getSelectedZones();
+    interactiveAddFilter(env, sheetId, selection);
+}
+
+var ACTION_VIEW = /*#__PURE__*/Object.freeze({
+  __proto__: null,
+  hideCols: hideCols,
+  unhideCols: unhideCols,
+  unhideAllCols: unhideAllCols,
+  hideRows: hideRows,
+  unhideRows: unhideRows,
+  unhideAllRows: unhideAllRows,
+  unFreezePane: unFreezePane,
+  freezePane: freezePane,
+  unFreezeRows: unFreezeRows,
+  freezeFirstRow: freezeFirstRow,
+  freezeSecondRow: freezeSecondRow,
+  freezeCurrentRow: freezeCurrentRow,
+  unFreezeCols: unFreezeCols,
+  freezeFirstCol: freezeFirstCol,
+  freezeSecondCol: freezeSecondCol,
+  freezeCurrentCol: freezeCurrentCol,
+  viewGridlines: viewGridlines,
+  viewFormulas: viewFormulas,
+  createRemoveFilter: createRemoveFilter,
+  createRemoveFilterAction: createRemoveFilterAction
+});
+
 const sortRange = {
     name: _lt("Sort range"),
     isVisible: IS_ONLY_ONE_RANGE,
@@ -19363,32 +19601,15 @@ const sortDescending = {
     },
     icon: "o-spreadsheet-Icon.SORT_DESCENDING",
 };
-const addDataFilter = {
-    name: _lt("Create filter"),
-    execute: (env) => {
-        const sheetId = env.model.getters.getActiveSheetId();
-        const selection = env.model.getters.getSelection().zones;
-        interactiveAddFilter(env, sheetId, selection);
-    },
-    isVisible: (env) => !SELECTION_CONTAINS_FILTER(env),
+const addRemoveDataFilter = {
+    name: (env) => SELECTION_CONTAINS_FILTER(env) ? _lt("Remove filter") : _lt("Create filter"),
+    execute: (env) => createRemoveFilterAction(env),
     isEnabled: (env) => {
         const selectedZones = env.model.getters.getSelectedZones();
         return areZonesContinuous(...selectedZones);
     },
     icon: "o-spreadsheet-Icon.MENU_FILTER_ICON",
 };
-const removeDataFilter = {
-    name: _lt("Remove filter"),
-    execute: (env) => {
-        const sheetId = env.model.getters.getActiveSheetId();
-        env.model.dispatch("REMOVE_FILTER_TABLE", {
-            sheetId,
-            target: env.model.getters.getSelectedZones(),
-        });
-    },
-    isVisible: SELECTION_CONTAINS_FILTER,
-    icon: "o-spreadsheet-Icon.MENU_FILTER_ICON",
-};
 const splitToColumns = {
     name: _lt("Split text to columns"),
     sequence: 1,
@@ -19768,242 +19989,6 @@ var ACTION_FORMAT = /*#__PURE__*/Object.freeze({
   clearFormat: clearFormat
 });
 
-function interactiveFreezeColumnsRows(env, dimension, base) {
-    const sheetId = env.model.getters.getActiveSheetId();
-    const cmd = dimension === "COL" ? "FREEZE_COLUMNS" : "FREEZE_ROWS";
-    const result = env.model.dispatch(cmd, { sheetId, quantity: base });
-    if (result.isCancelledBecause(68 /* CommandResult.MergeOverlap */)) {
-        env.raiseError(MergeErrorMessage);
-    }
-}
-
-const hideCols = {
-    name: HIDE_COLUMNS_NAME,
-    execute: (env) => {
-        const columns = env.model.getters.getElementsFromSelection("COL");
-        env.model.dispatch("HIDE_COLUMNS_ROWS", {
-            sheetId: env.model.getters.getActiveSheetId(),
-            dimension: "COL",
-            elements: columns,
-        });
-    },
-    isVisible: NOT_ALL_VISIBLE_COLS_SELECTED,
-    icon: "o-spreadsheet-Icon.HIDE_COL",
-};
-const unhideCols = {
-    name: _lt("Unhide columns"),
-    execute: (env) => {
-        const columns = env.model.getters.getElementsFromSelection("COL");
-        env.model.dispatch("UNHIDE_COLUMNS_ROWS", {
-            sheetId: env.model.getters.getActiveSheetId(),
-            dimension: "COL",
-            elements: columns,
-        });
-    },
-    isVisible: (env) => {
-        const hiddenCols = env.model.getters
-            .getHiddenColsGroups(env.model.getters.getActiveSheetId())
-            .flat();
-        const currentCols = env.model.getters.getElementsFromSelection("COL");
-        return currentCols.some((col) => hiddenCols.includes(col));
-    },
-};
-const unhideAllCols = {
-    name: _lt("Unhide all columns"),
-    execute: (env) => {
-        const sheetId = env.model.getters.getActiveSheetId();
-        env.model.dispatch("UNHIDE_COLUMNS_ROWS", {
-            sheetId,
-            dimension: "COL",
-            elements: Array.from(Array(env.model.getters.getNumberCols(sheetId)).keys()),
-        });
-    },
-    isVisible: (env) => env.model.getters.getHiddenColsGroups(env.model.getters.getActiveSheetId()).length > 0,
-};
-const hideRows = {
-    name: HIDE_ROWS_NAME,
-    execute: (env) => {
-        const rows = env.model.getters.getElementsFromSelection("ROW");
-        env.model.dispatch("HIDE_COLUMNS_ROWS", {
-            sheetId: env.model.getters.getActiveSheetId(),
-            dimension: "ROW",
-            elements: rows,
-        });
-    },
-    isVisible: NOT_ALL_VISIBLE_ROWS_SELECTED,
-    icon: "o-spreadsheet-Icon.HIDE_ROW",
-};
-const unhideRows = {
-    name: _lt("Unhide rows"),
-    execute: (env) => {
-        const columns = env.model.getters.getElementsFromSelection("ROW");
-        env.model.dispatch("UNHIDE_COLUMNS_ROWS", {
-            sheetId: env.model.getters.getActiveSheetId(),
-            dimension: "ROW",
-            elements: columns,
-        });
-    },
-    isVisible: (env) => {
-        const hiddenRows = env.model.getters
-            .getHiddenRowsGroups(env.model.getters.getActiveSheetId())
-            .flat();
-        const currentRows = env.model.getters.getElementsFromSelection("ROW");
-        return currentRows.some((col) => hiddenRows.includes(col));
-    },
-};
-const unhideAllRows = {
-    name: _lt("Unhide all rows"),
-    execute: (env) => {
-        const sheetId = env.model.getters.getActiveSheetId();
-        env.model.dispatch("UNHIDE_COLUMNS_ROWS", {
-            sheetId,
-            dimension: "ROW",
-            elements: Array.from(Array(env.model.getters.getNumberRows(sheetId)).keys()),
-        });
-    },
-    isVisible: (env) => env.model.getters.getHiddenRowsGroups(env.model.getters.getActiveSheetId()).length > 0,
-};
-const unFreezePane = {
-    name: _lt("Unfreeze"),
-    isVisible: (env) => {
-        const { xSplit, ySplit } = env.model.getters.getPaneDivisions(env.model.getters.getActiveSheetId());
-        return xSplit + ySplit > 0;
-    },
-    execute: (env) => env.model.dispatch("UNFREEZE_COLUMNS_ROWS", {
-        sheetId: env.model.getters.getActiveSheetId(),
-    }),
-    icon: "o-spreadsheet-Icon.UNFREEZE",
-};
-const freezePane = {
-    name: _lt("Freeze"),
-    icon: "o-spreadsheet-Icon.FREEZE",
-};
-const unFreezeRows = {
-    name: _lt("No rows"),
-    execute: (env) => env.model.dispatch("UNFREEZE_ROWS", {
-        sheetId: env.model.getters.getActiveSheetId(),
-    }),
-    isReadonlyAllowed: true,
-    isVisible: (env) => !!env.model.getters.getPaneDivisions(env.model.getters.getActiveSheetId()).ySplit,
-};
-const freezeFirstRow = {
-    name: _lt("1 row"),
-    execute: (env) => interactiveFreezeColumnsRows(env, "ROW", 1),
-    isReadonlyAllowed: true,
-};
-const freezeSecondRow = {
-    name: _lt("2 rows"),
-    execute: (env) => interactiveFreezeColumnsRows(env, "ROW", 2),
-    isReadonlyAllowed: true,
-};
-const freezeCurrentRow = {
-    name: _lt("Up to current row"),
-    execute: (env) => {
-        const { bottom } = env.model.getters.getSelectedZone();
-        interactiveFreezeColumnsRows(env, "ROW", bottom + 1);
-    },
-    isReadonlyAllowed: true,
-};
-const unFreezeCols = {
-    name: _lt("No columns"),
-    execute: (env) => env.model.dispatch("UNFREEZE_COLUMNS", {
-        sheetId: env.model.getters.getActiveSheetId(),
-    }),
-    isReadonlyAllowed: true,
-    isVisible: (env) => !!env.model.getters.getPaneDivisions(env.model.getters.getActiveSheetId()).xSplit,
-};
-const freezeFirstCol = {
-    name: _lt("1 column"),
-    execute: (env) => interactiveFreezeColumnsRows(env, "COL", 1),
-    isReadonlyAllowed: true,
-};
-const freezeSecondCol = {
-    name: _lt("2 columns"),
-    execute: (env) => interactiveFreezeColumnsRows(env, "COL", 2),
-    isReadonlyAllowed: true,
-};
-const freezeCurrentCol = {
-    name: _lt("Up to current column"),
-    execute: (env) => {
-        const { right } = env.model.getters.getSelectedZone();
-        interactiveFreezeColumnsRows(env, "COL", right + 1);
-    },
-    isReadonlyAllowed: true,
-};
-const viewGridlines = {
-    name: (env) => env.model.getters.getGridLinesVisibility(env.model.getters.getActiveSheetId())
-        ? _lt("Hide gridlines")
-        : _lt("Show gridlines"),
-    execute: (env) => {
-        const sheetId = env.model.getters.getActiveSheetId();
-        env.model.dispatch("SET_GRID_LINES_VISIBILITY", {
-            sheetId,
-            areGridLinesVisible: !env.model.getters.getGridLinesVisibility(sheetId),
-        });
-    },
-    icon: "o-spreadsheet-Icon.SHOW_HIDE_GRID",
-};
-const viewFormulas = {
-    name: (env) => env.model.getters.shouldShowFormulas() ? _lt("Hide formulas") : _lt("Show formulas"),
-    execute: (env) => env.model.dispatch("SET_FORMULA_VISIBILITY", { show: !env.model.getters.shouldShowFormulas() }),
-    isReadonlyAllowed: true,
-    icon: "o-spreadsheet-Icon.SHOW_HIDE_FORMULA",
-};
-const createRemoveFilter = {
-    name: (env) => selectionContainsFilter(env) ? _lt("Remove selected filters") : _lt("Create filter"),
-    isActive: (env) => selectionContainsFilter(env),
-    isEnabled: (env) => !cannotCreateFilter(env),
-    execute: (env) => createRemoveFilterAction(env),
-    icon: "o-spreadsheet-Icon.FILTER_ICON_INACTIVE",
-};
-function selectionContainsFilter(env) {
-    const sheetId = env.model.getters.getActiveSheetId();
-    const selectedZones = env.model.getters.getSelectedZones();
-    return env.model.getters.doesZonesContainFilter(sheetId, selectedZones);
-}
-function cannotCreateFilter(env) {
-    return !areZonesContinuous(...env.model.getters.getSelectedZones());
-}
-function createRemoveFilterAction(env) {
-    if (selectionContainsFilter(env)) {
-        env.model.dispatch("REMOVE_FILTER_TABLE", {
-            sheetId: env.model.getters.getActiveSheetId(),
-            target: env.model.getters.getSelectedZones(),
-        });
-        return;
-    }
-    if (cannotCreateFilter(env)) {
-        return;
-    }
-    env.model.selection.selectTableAroundSelection();
-    const sheetId = env.model.getters.getActiveSheetId();
-    const selection = env.model.getters.getSelectedZones();
-    interactiveAddFilter(env, sheetId, selection);
-}
-
-var ACTION_VIEW = /*#__PURE__*/Object.freeze({
-  __proto__: null,
-  hideCols: hideCols,
-  unhideCols: unhideCols,
-  unhideAllCols: unhideAllCols,
-  hideRows: hideRows,
-  unhideRows: unhideRows,
-  unhideAllRows: unhideAllRows,
-  unFreezePane: unFreezePane,
-  freezePane: freezePane,
-  unFreezeRows: unFreezeRows,
-  freezeFirstRow: freezeFirstRow,
-  freezeSecondRow: freezeSecondRow,
-  freezeCurrentRow: freezeCurrentRow,
-  unFreezeCols: unFreezeCols,
-  freezeFirstCol: freezeFirstCol,
-  freezeSecondCol: freezeSecondCol,
-  freezeCurrentCol: freezeCurrentCol,
-  viewGridlines: viewGridlines,
-  viewFormulas: viewFormulas,
-  createRemoveFilter: createRemoveFilter
-});
-
 const colMenuRegistry = new MenuItemRegistry();
 colMenuRegistry
     .add("cut", {
@@ -20578,12 +20563,8 @@ topbarMenuRegistry
     sequence: 20,
     separator: true,
 })
-    .addChild("add_data_filter", ["data"], {
-    ...addDataFilter,
-    sequence: 30,
-})
-    .addChild("remove_data_filter", ["data"], {
-    ...removeDataFilter,
+    .addChild("add_remove_data_filter", ["data"], {
+    ...addRemoveDataFilter,
     sequence: 30,
 });
 
@@ -24466,6 +24447,11 @@ class Composer extends owl.Component {
             }
         }
     }
+    onContextMenu(ev) {
+        if (this.env.model.getters.getEditionMode() === "inactive") {
+            this.props.onInputContextMenu?.(ev);
+        }
+    }
     // ---------------------------------------------------------------------------
     // Private
     // ---------------------------------------------------------------------------
@@ -24690,6 +24676,7 @@ Composer.props = {
     onComposerCellFocused: { type: Function, optional: true },
     onComposerContentFocused: Function,
     isDefaultFocus: { type: Boolean, optional: true },
+    onInputContextMenu: { type: Function, optional: true },
 };
 
 const COMPOSER_BORDER_WIDTH = 3 * 0.4 * window.devicePixelRatio || 1;
@@ -24766,6 +24753,7 @@ class GridComposer extends owl.Component {
             isDefaultFocus: true,
             onComposerContentFocused: this.props.onComposerContentFocused,
             onComposerCellFocused: this.props.onComposerCellFocused,
+            onInputContextMenu: this.props.onInputContextMenu,
         };
     }
     get containerStyle() {
@@ -24854,6 +24842,7 @@ GridComposer.props = {
     onComposerContentFocused: Function,
     gridDims: Object,
     onComposerCellFocused: Function,
+    onInputContextMenu: Function,
 };
 
 const CSS$1 = css /* scss */ `
@@ -27203,8 +27192,8 @@ class Grid extends owl.Component {
         else if (this.env.model.getters.getActiveRows().has(row)) {
             type = "ROW";
         }
-        const { x, y, width, height } = this.env.model.getters.getVisibleRect(lastZone);
-        this.toggleContextMenu(type, x + width, y + height);
+        const { x, y, width } = this.env.model.getters.getVisibleRect(lastZone);
+        this.toggleContextMenu(type, this.canvasPosition.x + x + width, this.canvasPosition.y + y);
     }
     onCellRightClicked(col, row, { x, y }) {
         const zones = this.env.model.getters.getSelectedZones();
@@ -28494,29 +28483,12 @@ function convertWidthFromExcel(width) {
         return width;
     return Math.round((width / WIDTH_FACTOR) * 100) / 100;
 }
-function convertBorderDescr(descr) {
-    if (!descr) {
-        return undefined;
-    }
-    return {
-        style: descr.style,
-        color: { rgb: descr.color },
-    };
-}
 function extractStyle(cell, data) {
     let style = {};
     if (cell.style) {
         style = data.styles[cell.style];
     }
     const format = extractFormat(cell, data);
-    const exportedBorder = {};
-    if (cell.border) {
-        const border = data.borders[cell.border];
-        exportedBorder.left = convertBorderDescr(border.left);
-        exportedBorder.right = convertBorderDescr(border.right);
-        exportedBorder.bottom = convertBorderDescr(border.bottom);
-        exportedBorder.top = convertBorderDescr(border.top);
-    }
     const styles = {
         font: {
             size: style?.fontSize || DEFAULT_FONT_SIZE,
@@ -28530,7 +28502,7 @@ function extractStyle(cell, data) {
             }
             : { reservedAttribute: "none" },
         numFmt: format ? { format: format, id: 0 /* id not used for export */ } : undefined,
-        border: exportedBorder || {},
+        border: cell.border || 0,
         alignment: {
             horizontal: style.align,
             vertical: style.verticalAlign
@@ -28552,15 +28524,12 @@ function extractFormat(cell, data) {
     return undefined;
 }
 function normalizeStyle(construct, styles) {
-    const { id: fontId } = pushElement(styles["font"], construct.fonts);
-    const { id: fillId } = pushElement(styles["fill"], construct.fills);
-    const { id: borderId } = pushElement(styles["border"], construct.borders);
     // Normalize this
     const numFmtId = convertFormat(styles["numFmt"], construct.numFmts);
     const style = {
-        fontId,
-        fillId,
-        borderId,
+        fontId: pushElement(styles.font, construct.fonts),
+        fillId: pushElement(styles.fill, construct.fills),
+        borderId: styles.border,
         numFmtId,
         alignment: {
             vertical: styles.alignment.vertical,
@@ -28568,8 +28537,7 @@ function normalizeStyle(construct, styles) {
             wrapText: styles.alignment.wrapText,
         },
     };
-    const { id } = pushElement(style, construct.styles);
-    return id;
+    return pushElement(style, construct.styles);
 }
 function convertFormat(format, numFmtStructure) {
     if (!format) {
@@ -28577,8 +28545,7 @@ function convertFormat(format, numFmtStructure) {
     }
     let formatId = XLSX_FORMAT_MAP[format.format];
     if (!formatId) {
-        const { id } = pushElement(format, numFmtStructure);
-        formatId = id + FIRST_NUMFMT_ID;
+        formatId = pushElement(format, numFmtStructure) + FIRST_NUMFMT_ID;
     }
     return formatId;
 }
@@ -28603,20 +28570,15 @@ function addRelsToFile(relsFiles, path, rel) {
     return id;
 }
 function pushElement(property, propertyList) {
-    for (let [key, value] of Object.entries(propertyList)) {
-        if (JSON.stringify(value) === JSON.stringify(property)) {
-            return { id: parseInt(key, 10), list: propertyList };
+    let len = propertyList.length;
+    const operator = typeof property === "object" ? deepEquals : (a, b) => a === b;
+    for (let i = 0; i < len; i++) {
+        if (operator(property, propertyList[i])) {
+            return i;
         }
     }
-    let elemId = propertyList.findIndex((elem) => JSON.stringify(elem) === JSON.stringify(property));
-    if (elemId === -1) {
-        propertyList.push(property);
-        elemId = propertyList.length - 1;
-    }
-    return {
-        id: elemId,
-        list: propertyList,
-    };
+    propertyList[propertyList.length] = property;
+    return propertyList.length - 1;
 }
 const chartIds = [];
 /**
@@ -29337,7 +29299,25 @@ function parseXML(xmlString, mimeType = "text/xml") {
     }
     return document;
 }
-function getDefaultXLSXStructure() {
+function convertBorderDescr(descr) {
+    if (!descr) {
+        return undefined;
+    }
+    return {
+        style: descr.style,
+        color: { rgb: descr.color },
+    };
+}
+function getDefaultXLSXStructure(data) {
+    const xlsxBorders = Object.values(data.borders).map((border) => {
+        return {
+            left: convertBorderDescr(border.left),
+            right: convertBorderDescr(border.right),
+            bottom: convertBorderDescr(border.bottom),
+            top: convertBorderDescr(border.top),
+        };
+    });
+    const borders = [{}, ...xlsxBorders];
     return {
         relsFiles: [],
         sharedStrings: [],
@@ -29360,7 +29340,7 @@ function getDefaultXLSXStructure() {
             },
         ],
         fills: [{ reservedAttribute: "none" }, { reservedAttribute: "gray125" }],
-        borders: [{}],
+        borders,
         numFmts: [],
         dxfs: [],
     };
@@ -33425,7 +33405,17 @@ class FiltersPlugin extends CorePlugin {
         }
     }
     exportForExcel(data) {
-        this.export(data);
+        for (const sheet of data.sheets) {
+            for (const filterTable of this.getFilterTables(sheet.id)) {
+                if (zoneToDimension(filterTable.zone).numberOfRows === 1) {
+                    continue;
+                }
+                sheet.filterTables.push({
+                    range: zoneToXc(filterTable.zone),
+                    filters: [],
+                });
+            }
+        }
     }
 }
 
@@ -36719,7 +36709,9 @@ class Evaluator {
         this.blockedArrayFormulas = new Set();
         this.spreadingRelations = new SpreadingRelation();
         this.formulaDependencies = lazy(() => {
-            const dependencies = [...this.getAllCells()].flatMap((positionId) => this.getDirectDependencies(positionId).map((range) => ({
+            const dependencies = [...this.getAllCells()].flatMap((positionId) => this.getDirectDependencies(positionId)
+                .filter((range) => !range.invalidSheetName && !range.invalidXc)
+                .map((range) => ({
                 data: positionId,
                 boundingBox: {
                     zone: range.zone,
@@ -45254,13 +45246,14 @@ class SheetViewPlugin extends UIPlugin {
         }
     }
     handleEvent(event) {
+        const sheetId = this.getters.getActiveSheetId();
         if (event.options.scrollIntoView) {
             let { col, row } = findCellInNewZone(event.previousAnchor.zone, event.anchor.zone);
             if (event.mode === "updateAnchor") {
                 const oldZone = event.previousAnchor.zone;
                 const newZone = event.anchor.zone;
                 // altering a zone should not move the viewport in a dimension that wasn't changed
-                const { top, bottom, left, right } = this.getters.getActiveMainViewport();
+                const { top, bottom, left, right } = this.getMainInternalViewport(sheetId);
                 if (oldZone.left === newZone.left && oldZone.right === newZone.right) {
                     col = left > col || col > right ? left : col;
                 }
@@ -45268,7 +45261,6 @@ class SheetViewPlugin extends UIPlugin {
                     row = top > row || row > bottom ? top : row;
                 }
             }
-            const sheetId = this.getters.getActiveSheetId();
             col = Math.min(col, this.getters.getNumberCols(sheetId) - 1);
             row = Math.min(row, this.getters.getNumberRows(sheetId) - 1);
             this.refreshViewport(this.getters.getActiveSheetId(), { col, row });
@@ -45294,16 +45286,16 @@ class SheetViewPlugin extends UIPlugin {
                 this.setSheetViewOffset(cmd.offsetX, cmd.offsetY);
                 break;
             case "SHIFT_VIEWPORT_DOWN":
-                const { top } = this.getActiveMainViewport();
                 const sheetId = this.getters.getActiveSheetId();
-                const shiftedOffsetY = this.clipOffsetY(this.getters.getRowDimensions(sheetId, top).start + this.sheetViewHeight);
-                this.shiftVertically(shiftedOffsetY);
+                const { top, viewportHeight, offsetCorrectionY } = this.getMainInternalViewport(sheetId);
+                const topRowDims = this.getters.getRowDimensions(sheetId, top);
+                this.shiftVertically(topRowDims.start + viewportHeight - offsetCorrectionY);
                 break;
             case "SHIFT_VIEWPORT_UP": {
-                const { top } = this.getActiveMainViewport();
                 const sheetId = this.getters.getActiveSheetId();
-                const shiftedOffsetY = this.clipOffsetY(this.getters.getRowDimensions(sheetId, top).end - this.sheetViewHeight);
-                this.shiftVertically(shiftedOffsetY);
+                const { top, viewportHeight, offsetCorrectionY } = this.getMainInternalViewport(sheetId);
+                const topRowDims = this.getters.getRowDimensions(sheetId, top);
+                this.shiftVertically(topRowDims.end - offsetCorrectionY - viewportHeight);
                 break;
             }
             case "REMOVE_COLUMNS_ROWS":
@@ -45665,17 +45657,6 @@ class SheetViewPlugin extends UIPlugin {
         const { maxOffsetX, maxOffsetY } = this.getMaximumSheetOffset();
         Object.values(this.getSubViewports(sheetId)).forEach((viewport) => viewport.setViewportOffset(clip(offsetX, 0, maxOffsetX), clip(offsetY, 0, maxOffsetY)));
     }
-    /**
-     * Clip the vertical offset within the allowed range.
-     * Not above the sheet, nor below the sheet.
-     */
-    clipOffsetY(offsetY) {
-        const { height } = this.getMainViewportRect();
-        const maxOffset = height - this.sheetViewHeight;
-        offsetY = Math.min(offsetY, maxOffset);
-        offsetY = Math.max(offsetY, 0);
-        return offsetY;
-    }
     getViewportOffset(sheetId) {
         return {
             x: this.viewports[sheetId]?.bottomRight.offsetScrollbarX || 0,
@@ -45731,12 +45712,15 @@ class SheetViewPlugin extends UIPlugin {
      * viewport top.
      */
     shiftVertically(offset) {
-        const { top } = this.getActiveMainViewport();
+        const sheetId = this.getters.getActiveSheetId();
+        const { top } = this.getMainInternalViewport(sheetId);
         const { scrollX } = this.getActiveSheetScrollInfo();
         this.setSheetViewOffset(scrollX, offset);
         const { anchor } = this.getters.getSelection();
-        const deltaRow = this.getActiveMainViewport().top - top;
-        this.selection.selectCell(anchor.cell.col, anchor.cell.row + deltaRow);
+        if (anchor.cell.row >= this.getters.getPaneDivisions(sheetId).ySplit) {
+            const deltaRow = this.getMainInternalViewport(sheetId).top - top;
+            this.selection.selectCell(anchor.cell.col, anchor.cell.row + deltaRow);
+        }
     }
     getVisibleFigures() {
         const sheetId = this.getters.getActiveSheetId();
@@ -46752,7 +46736,6 @@ css /* scss */ `
     cursor: pointer;
   }
 `;
-let tKey = 1;
 class SpreadsheetDashboard extends owl.Component {
     static template = "o-spreadsheet-SpreadsheetDashboard";
     static components = {
@@ -46830,13 +46813,9 @@ class SpreadsheetDashboard extends owl.Component {
                     coordinates: rect,
                     position: { col, row },
                     action,
-                    // we can't rely on position only because a row or a column could
-                    // be inserted at any time.
-                    tKey: `${tKey}-${col}-${row}`,
                 });
             }
         }
-        tKey++;
         return cells;
     }
     getClickableAction(position) {
@@ -49993,8 +49972,7 @@ function addContent(content, sharedStrings, forceString = false) {
         attrs.push(["t", "b"]);
     }
     else if (forceString || !isNumber(value, DEFAULT_LOCALE)) {
-        const { id } = pushElement(content, sharedStrings);
-        value = id.toString();
+        value = pushElement(content, sharedStrings);
         attrs.push(["t", "s"]);
     }
     return { attrs, node: escapeXml /*xml*/ `<v>${value}</v>` };
@@ -50119,8 +50097,7 @@ function addCellIsRule(cf, rule, dxfs) {
     if (rule.style.fillColor) {
         dxf.fill = { fgColor: { rgb: rule.style.fillColor } };
     }
-    const { id } = pushElement(dxf, dxfs);
-    ruleAttributes.push(["dxfId", id]);
+    ruleAttributes.push(["dxfId", pushElement(dxf, dxfs)]);
     return escapeXml /*xml*/ `
     <conditionalFormatting sqref="${cf.ranges.join(" ")}">
       <cfRule ${formatAttributes(ruleAttributes)}>
@@ -50929,7 +50906,7 @@ function addSheetViews(sheet) {
  */
 function getXLSX(data) {
     const files = [];
-    const construct = getDefaultXLSXStructure();
+    const construct = getDefaultXLSXStructure(data);
     files.push(createWorkbook(data, construct));
     files.push(...createWorksheets(data, construct));
     files.push(createStylesSheet(construct));
@@ -51784,6 +51761,6 @@ exports.setTranslationMethod = setTranslationMethod;
 exports.tokenize = tokenize;
 
 
-__info__.version = '16.4.28';
-__info__.date = '2024-04-05T13:59:39.997Z';
-__info__.hash = '7127826';
+__info__.version = '16.4.30';
+__info__.date = '2024-04-18T16:39:04.255Z';
+__info__.hash = '39b015c';