@odoo/o-spreadsheet 16.4.26 → 16.4.28

package/dist/o-spreadsheet.cjs.js

@@ -526,7 +526,7 @@ function getItemId(item, itemsDic) {
     }
     // Generate new Id if the item didn't exist in the dictionary
     const ids = Object.keys(itemsDic);
-    const maxId = ids.length === 0 ? 0 : Math.max(...ids.map((id) => parseInt(id, 10)));
+    const maxId = ids.length === 0 ? 0 : largeMax(ids.map((id) => parseInt(id, 10)));
     itemsDic[maxId + 1] = item;
     return maxId + 1;
 }
@@ -742,6 +742,34 @@ function insertItemsAtIndex(array, items, index) {
     const newArray = [...array];
     newArray.splice(index, 0, ...items);
     return newArray;
+}
+/**
+ * Alternative to Math.max that works with large arrays.
+ * Typically useful for arrays bigger than 100k elements.
+ */
+function largeMax(array) {
+    let len = array.length;
+    if (len < 100000)
+        return Math.max(...array);
+    let max = -Infinity;
+    while (len--) {
+        max = array[len] > max ? array[len] : max;
+    }
+    return max;
+}
+/**
+ * Alternative to Math.min that works with large arrays.
+ * Typically useful for arrays bigger than 100k elements.
+ */
+function largeMin(array) {
+    let len = array.length;
+    if (len < 100000)
+        return Math.min(...array);
+    let min = +Infinity;
+    while (len--) {
+        min = array[len] < min ? array[len] : min;
+    }
+    return min;
 }
 
 const RBA_REGEX = /rgba?\(|\s+|\)/gi;
@@ -16338,10 +16366,10 @@ function aggregateDataForLabels(labels, datasets) {
         }
     }
     return {
-        labels: Object.keys(labelMap),
+        labels: Array.from(labelSet),
         dataSetsValues: datasets.map((dataset, indexOfDataset) => ({
             ...dataset,
-            data: Object.values(labelMap).map((dataOfLabel) => dataOfLabel[indexOfDataset]),
+            data: Array.from(labelSet).map((label) => labelMap[label][indexOfDataset]),
         })),
     };
 }
@@ -17062,7 +17090,7 @@ function getBestTimeUnitForScale(labels, format, locale) {
         return undefined;
     }
     const labelsTimestamps = labelDates.map((date) => date.getTime());
-    const period = Math.max(...labelsTimestamps) - Math.min(...labelsTimestamps);
+    const period = largeMax(labelsTimestamps) - largeMin(labelsTimestamps);
     const minUnit = getFormatMinDisplayUnit(format);
     if (UNIT_LENGTH.second >= UNIT_LENGTH[minUnit] && Milliseconds.inSeconds(period) < 180) {
         return "second";
@@ -17504,7 +17532,7 @@ function getPieConfiguration(chart, labels, localeFormat) {
 }
 function getPieColors(colors, dataSetsValues) {
     const pieColors = [];
-    const maxLength = Math.max(...dataSetsValues.map((ds) => ds.data.length));
+    const maxLength = largeMax(dataSetsValues.map((ds) => ds.data.length));
     for (let i = 0; i <= maxLength; i++) {
         pieColors.push(colors.next());
     }
@@ -18321,8 +18349,8 @@ const DELETE_CONTENT_ROWS_NAME = (env) => {
     let last;
     const activesRows = env.model.getters.getActiveRows();
     if (activesRows.size !== 0) {
-        first = Math.min(...activesRows);
-        last = Math.max(...activesRows);
+        first = largeMin([...activesRows]);
+        last = largeMax([...activesRows]);
     }
     else {
         const zone = env.model.getters.getSelectedZones()[0];
@@ -18350,8 +18378,8 @@ const DELETE_CONTENT_COLUMNS_NAME = (env) => {
     let last;
     const activeCols = env.model.getters.getActiveCols();
     if (activeCols.size !== 0) {
-        first = Math.min(...activeCols);
-        last = Math.max(...activeCols);
+        first = largeMin([...activeCols]);
+        last = largeMax([...activeCols]);
     }
     else {
         const zone = env.model.getters.getSelectedZones()[0];
@@ -18379,8 +18407,8 @@ const REMOVE_ROWS_NAME = (env) => {
     let last;
     const activesRows = env.model.getters.getActiveRows();
     if (activesRows.size !== 0) {
-        first = Math.min(...activesRows);
-        last = Math.max(...activesRows);
+        first = largeMin([...activesRows]);
+        last = largeMax([...activesRows]);
     }
     else {
         const zone = env.model.getters.getSelectedZones()[0];
@@ -18421,8 +18449,8 @@ const REMOVE_COLUMNS_NAME = (env) => {
     let last;
     const activeCols = env.model.getters.getActiveCols();
     if (activeCols.size !== 0) {
-        first = Math.min(...activeCols);
-        last = Math.max(...activeCols);
+        first = largeMin([...activeCols]);
+        last = largeMax([...activeCols]);
     }
     else {
         const zone = env.model.getters.getSelectedZones()[0];
@@ -18463,7 +18491,7 @@ const INSERT_ROWS_BEFORE_ACTION = (env) => {
     let row;
     let quantity;
     if (activeRows.size) {
-        row = Math.min(...activeRows);
+        row = largeMin([...activeRows]);
         quantity = activeRows.size;
     }
     else {
@@ -18484,7 +18512,7 @@ const INSERT_ROWS_AFTER_ACTION = (env) => {
     let row;
     let quantity;
     if (activeRows.size) {
-        row = Math.max(...activeRows);
+        row = largeMax([...activeRows]);
         quantity = activeRows.size;
     }
     else {
@@ -18505,7 +18533,7 @@ const INSERT_COLUMNS_BEFORE_ACTION = (env) => {
     let column;
     let quantity;
     if (activeCols.size) {
-        column = Math.min(...activeCols);
+        column = largeMin([...activeCols]);
         quantity = activeCols.size;
     }
     else {
@@ -18526,7 +18554,7 @@ const INSERT_COLUMNS_AFTER_ACTION = (env) => {
     let column;
     let quantity;
     if (activeCols.size) {
-        column = Math.max(...activeCols);
+        column = largeMax([...activeCols]);
         quantity = activeCols.size;
     }
     else {
@@ -19042,14 +19070,19 @@ const categorieFunctionAll = {
     children: [allFunctionListMenuBuilder],
 };
 function allFunctionListMenuBuilder() {
-    const fnNames = functionRegistry.getKeys();
+    const fnNames = functionRegistry.getKeys().filter((key) => !functionRegistry.get(key).hidden);
     return createFormulaFunctions(fnNames);
 }
 const categoriesFunctionListMenuBuilder = () => {
     const functions = functionRegistry.content;
-    const categories = [...new Set(functionRegistry.getAll().map((fn) => fn.category))].filter(isDefined$1);
+    const categories = [
+        ...new Set(functionRegistry
+            .getAll()
+            .filter((fn) => !fn.hidden)
+            .map((fn) => fn.category)),
+    ].filter(isDefined$1);
     return categories.sort().map((category, i) => {
-        const functionsInCategory = Object.keys(functions).filter((key) => functions[key].category === category);
+        const functionsInCategory = Object.keys(functions).filter((key) => functions[key].category === category && !functions[key].hidden);
         return {
             name: category,
             children: createFormulaFunctions(functionsInCategory),
@@ -23390,6 +23423,9 @@ class FigureComponent extends owl.Component {
                 el?.focus({ preventScroll: true });
             }
         }, () => [this.env.model.getters.getSelectedFigureId(), this.props.figure.id, this.figureRef.el]);
+        owl.onWillUnmount(() => {
+            this.props.onFigureDeleted();
+        });
     }
     clickAnchor(dirX, dirY, ev) {
         this.props.onClickAnchor(dirX, dirY, ev);
@@ -23408,6 +23444,7 @@ class FigureComponent extends owl.Component {
                 this.props.onFigureDeleted();
                 ev.stopPropagation();
                 ev.preventDefault();
+                ev.stopPropagation();
                 break;
             case "ArrowDown":
             case "ArrowLeft":
@@ -23428,6 +23465,7 @@ class FigureComponent extends owl.Component {
                 });
                 ev.stopPropagation();
                 ev.preventDefault();
+                ev.stopPropagation();
                 break;
         }
     }
@@ -24030,6 +24068,9 @@ class FunctionDescriptionProvider extends owl.Component {
             this.assistantState.allowCellSelectionBehind = false;
         }, 2000);
     }
+    get formulaArgSeparator() {
+        return this.env.model.getters.getLocale().formulaArgSeparator + " ";
+    }
 }
 FunctionDescriptionProvider.props = {
     functionName: String,
@@ -24164,6 +24205,12 @@ class Composer extends owl.Component {
         owl.useEffect(() => {
             this.processContent();
         });
+        owl.onPatched(() => {
+            // Required because typing '=SUM' and double-clicking another cell leaves ShowProvider/ShowDescription true
+            if (this.env.model.getters.getEditionMode() === "inactive") {
+                this.processTokenAtCursor();
+            }
+        });
     }
     // ---------------------------------------------------------------------------
     // Handlers
@@ -29021,7 +29068,7 @@ function convertHyperlink(link, cellValue, warningManager) {
 function getSheetDims(sheet) {
     const dims = [0, 0];
     for (let row of sheet.rows) {
-        dims[0] = Math.max(dims[0], ...row.cells.map((cell) => toCartesian(cell.xc).col));
+        dims[0] = Math.max(dims[0], largeMax(row.cells.map((cell) => toCartesian(cell.xc).col)));
         dims[1] = Math.max(dims[1], row.index);
     }
     dims[0] = Math.max(dims[0], EXCEL_IMPORT_DEFAULT_NUMBER_OF_COLS);
@@ -33518,7 +33565,7 @@ class HeaderVisibilityPlugin extends CorePlugin {
                 if (hiddenElements.size >= elements) {
                     return 69 /* CommandResult.TooManyHiddenElements */;
                 }
-                else if (Math.min(...cmd.elements) < 0 || Math.max(...cmd.elements) > elements) {
+                else if (largeMin(cmd.elements) < 0 || largeMax(cmd.elements) > elements) {
                     return 89 /* CommandResult.InvalidHeaderIndex */;
                 }
                 else {
@@ -34312,8 +34359,8 @@ class RangeAdapter {
                     let newRange = range;
                     let changeType = "NONE";
                     for (let group of groups) {
-                        const min = Math.min(...group);
-                        const max = Math.max(...group);
+                        const min = largeMin(group);
+                        const max = largeMax(group);
                         if (range.zone[start] <= min && min <= range.zone[end]) {
                             const toRemove = Math.min(range.zone[end], max) - min + 1;
                             changeType = "RESIZE";
@@ -34740,7 +34787,7 @@ class SheetPlugin extends CorePlugin {
                 const elements = cmd.dimension === "COL"
                     ? this.getNumberCols(cmd.sheetId)
                     : this.getNumberRows(cmd.sheetId);
-                if (Math.min(...cmd.elements) < 0 || Math.max(...cmd.elements) > elements) {
+                if (largeMin(cmd.elements) < 0 || largeMax(cmd.elements) > elements) {
                     return 89 /* CommandResult.InvalidHeaderIndex */;
                 }
                 else if (this.checkElementsIncludeAllNonFrozenHeaders(cmd.sheetId, cmd.dimension, cmd.elements)) {
@@ -37616,13 +37663,13 @@ class EvaluationConditionalFormatPlugin extends UIPlugin {
             .map((cell) => cell.value);
         switch (threshold.type) {
             case "value":
-                const result = functionName === "max" ? Math.max(...rangeValues) : Math.min(...rangeValues);
+                const result = functionName === "max" ? largeMax(rangeValues) : largeMin(rangeValues);
                 return result;
             case "number":
                 return Number(threshold.value);
             case "percentage":
-                const min = Math.min(...rangeValues);
-                const max = Math.max(...rangeValues);
+                const min = largeMin(rangeValues);
+                const max = largeMax(rangeValues);
                 const delta = max - min;
                 return min + (delta * Number(threshold.value)) / 100;
             case "percentile":
@@ -38505,13 +38552,13 @@ class AutomaticSumPlugin extends UIPlugin {
         const cells = this.getters.getEvaluatedCellsInZone(sheet.id, zone);
         const cellPositions = range(end, -1, -1);
         const invalidCells = cellPositions.filter((position) => cells[position] && !cells[position].isAutoSummable);
-        const maxValidPosition = Math.max(...invalidCells);
+        const maxValidPosition = largeMax(invalidCells);
         const numberSequences = groupConsecutive(cellPositions.filter((position) => this.isNumber(cells[position])));
         const firstSequence = numberSequences[0] || [];
-        if (Math.max(...firstSequence) < maxValidPosition) {
+        if (largeMax(firstSequence) < maxValidPosition) {
             return Infinity;
         }
-        return Math.min(...firstSequence);
+        return largeMin(firstSequence);
     }
     shouldFindData(sheetId, zone) {
         return this.getters.isEmpty(sheetId, zone) || this.getters.isSingleCellOrMerge(sheetId, zone);
@@ -40100,7 +40147,7 @@ class RendererPlugin extends UIPlugin {
      * column of the current viewport
      */
     getColDimensionsInViewport(sheetId, col) {
-        const left = Math.min(...this.getters.getSheetViewVisibleCols());
+        const left = largeMin(this.getters.getSheetViewVisibleCols());
         const start = this.getters.getColRowOffsetInViewport("COL", left, col);
         const size = this.getters.getColSize(sheetId, col);
         const isColHidden = this.getters.isColHidden(sheetId, col);
@@ -40115,7 +40162,7 @@ class RendererPlugin extends UIPlugin {
      * of the current viewport
      */
     getRowDimensionsInViewport(sheetId, row) {
-        const top = Math.min(...this.getters.getSheetViewVisibleRows());
+        const top = largeMin(this.getters.getSheetViewVisibleRows());
         const start = this.getters.getColRowOffsetInViewport("ROW", top, row);
         const size = this.getters.getRowSize(sheetId, row);
         const isRowHidden = this.getters.isRowHidden(sheetId, row);
@@ -41612,7 +41659,7 @@ class SheetUIPlugin extends UIPlugin {
     getColMaxWidth(sheetId, index) {
         const cellsPositions = positions(this.getters.getColsZone(sheetId, index, index));
         const sizes = cellsPositions.map((position) => this.getCellWidth({ sheetId, ...position }));
-        return Math.max(0, ...sizes);
+        return Math.max(0, largeMax(sizes));
     }
     /**
      * Check that any "sheetId" in the command matches an existing
@@ -42914,7 +42961,7 @@ class ClipboardOsState extends ClipboardCellsAbstractState {
     }
     getPasteZone(target) {
         const height = this.values.length;
-        const width = Math.max(...this.values.map((a) => a.length));
+        const width = largeMax(this.values.map((a) => a.length));
         const { left: activeCol, top: activeRow } = target[0];
         return {
             top: activeRow,
@@ -44400,6 +44447,7 @@ class GridSelectionPlugin extends UIPlugin {
                 this.gridSelection.zones = this.gridSelection.zones.map((z) => this.getters.expandZone(sheetId, z));
                 this.gridSelection.anchor.zone = this.getters.expandZone(sheetId, this.gridSelection.anchor.zone);
                 this.setSelectionMixin(this.gridSelection.anchor, this.gridSelection.zones);
+                this.selectedFigureId = null;
                 break;
         }
         /** Any change to the selection has to be  reflected in the selection processor. */
@@ -46134,12 +46182,14 @@ class BottomBarSheet extends owl.Component {
         this.editionState = "initializing";
     }
     stopEdition() {
-        if (!this.state.isEditing)
+        const input = this.sheetNameRef.el;
+        if (!this.state.isEditing || !input)
             return;
         this.state.isEditing = false;
         this.editionState = "initializing";
-        this.sheetNameRef.el?.blur();
+        input.blur();
         const inputValue = this.getInputContent() || "";
+        input.innerText = inputValue;
         interactiveRenameSheet(this.env, this.props.sheetId, inputValue, () => this.startEdition());
     }
     cancelEdition() {
@@ -46601,7 +46651,7 @@ class BottomBar extends owl.Component {
         this.sheetListRef.el.scrollTo({ top: 0, left: scroll, behavior: "smooth" });
     }
     onSheetMouseDown(sheetId, event) {
-        if (event.button !== 0)
+        if (event.button !== 0 || this.env.model.getters.isReadonly())
             return;
         this.closeMenu();
         const mouseX = event.clientX;
@@ -49805,7 +49855,7 @@ function addLineChart(chart) {
 }
 function addDoughnutChart(chart, chartSheetIndex, data, { holeSize } = { holeSize: 50 }) {
     const colors = new ChartColors();
-    const maxLength = Math.max(...chart.dataSets.map((ds) => getRangeSize(ds.range, chartSheetIndex, data)));
+    const maxLength = largeMax(chart.dataSets.map((ds) => getRangeSize(ds.range, chartSheetIndex, data)));
     const doughnutColors = range(0, maxLength).map(() => toXlsxHexColor(colors.next()));
     const dataSetsNodes = [];
     for (const [dsIndex, dataset] of Object.entries(chart.dataSets).reverse()) {
@@ -51734,6 +51784,6 @@ exports.setTranslationMethod = setTranslationMethod;
 exports.tokenize = tokenize;
 
 
-__info__.version = '16.4.26';
-__info__.date = '2024-03-15T10:58:33.088Z';
-__info__.hash = 'b8caa0f';
+__info__.version = '16.4.28';
+__info__.date = '2024-04-05T13:59:39.997Z';
+__info__.hash = '7127826';

package/dist/o-spreadsheet.d.ts

@@ -6663,13 +6663,14 @@ interface Props$a {
 interface AssistantState {
     allowCellSelectionBehind: boolean;
 }
-declare class FunctionDescriptionProvider extends Component<Props$a> {
+declare class FunctionDescriptionProvider extends Component<Props$a, SpreadsheetChildEnv> {
     static template: string;
     assistantState: AssistantState;
     private timeOutId;
     setup(): void;
     getContext(): Props$a;
     onMouseMove(): void;
+    get formulaArgSeparator(): string;
 }
 
 type HtmlContent = {