@odoo/o-spreadsheet 16.3.25 → 16.3.26

package/dist/o-spreadsheet.cjs.js

@@ -9436,6 +9436,12 @@ const INSERT_LINK = (env) => {
     let { col, row } = env.model.getters.getActivePosition();
     env.model.dispatch("OPEN_CELL_POPOVER", { col, row, popoverType: "LinkEditor" });
 };
+const INSERT_LINK_NAME = (env) => {
+    const sheetId = env.model.getters.getActiveSheetId();
+    const { col, row } = env.model.getters.getActivePosition();
+    const cell = env.model.getters.getEvaluatedCell({ sheetId, col, row });
+    return cell && cell.link ? _lt("Edit link") : _lt("Insert link");
+};
 //------------------------------------------------------------------------------
 // Filters action
 //------------------------------------------------------------------------------
@@ -16660,7 +16666,7 @@ cellMenuRegistry
 })
     .add("insert_link", {
     ...insertLink,
-    name: _lt("Insert link"),
+    name: INSERT_LINK_NAME,
     sequence: 150,
     separator: true,
 });
@@ -29688,9 +29694,9 @@ class CellPlugin extends CorePlugin {
     allowDispatch(cmd) {
         switch (cmd.type) {
             case "UPDATE_CELL":
-                return this.checkCellOutOfSheet(cmd);
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
             case "CLEAR_CELL":
-                return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
             default:
                 return 0 /* CommandResult.Success */;
         }
@@ -29984,7 +29990,7 @@ class CellPlugin extends CorePlugin {
         else {
             style = before ? before.style : undefined;
         }
-        let format = ("format" in after ? after.format : before && before.format) || detectFormat(afterContent);
+        const format = "format" in after ? after.format : before && before.format;
         /* Read the following IF as:
          * we need to remove the cell if it is completely empty, but we can know if it completely empty if:
          * - the command says the new content is empty and has no border/format/style
@@ -30028,7 +30034,7 @@ class CellPlugin extends CorePlugin {
             id,
             content,
             style,
-            format,
+            format: format || detectFormat(content),
             isFormula: false,
         };
     }
@@ -30105,6 +30111,18 @@ class CellPlugin extends CorePlugin {
         }
         return 0 /* CommandResult.Success */;
     }
+    checkUselessUpdateCell(cmd) {
+        const cell = this.getters.getCell(cmd);
+        const hasContent = "content" in cmd || "formula" in cmd;
+        const hasStyle = "style" in cmd;
+        const hasFormat = "format" in cmd;
+        if ((!hasContent || cell?.content === cmd.content) &&
+            (!hasStyle || deepEquals(cell?.style, cmd.style)) &&
+            (!hasFormat || cell?.format === cmd.format)) {
+            return 94 /* CommandResult.NoChanges */;
+        }
+        return 0 /* CommandResult.Success */;
+    }
 }
 
 class ChartPlugin extends CorePlugin {
@@ -35768,8 +35786,7 @@ class AutofillPlugin extends UIPlugin {
         let row = zone.bottom;
         if (col > 0) {
             let leftPosition = { sheetId, col: col - 1, row };
-            while (this.getters.getEvaluatedCell(leftPosition).type !== CellValueType.empty ||
-                this.getters.getCell(leftPosition)?.content) {
+            while (this.getters.getCell(leftPosition)?.content) {
                 row += 1;
                 leftPosition = { sheetId, col: col - 1, row };
             }
@@ -35778,8 +35795,7 @@ class AutofillPlugin extends UIPlugin {
             col = zone.right;
             if (col <= this.getters.getNumberCols(sheetId)) {
                 let rightPosition = { sheetId, col: col + 1, row };
-                while (this.getters.getEvaluatedCell(rightPosition).type !== CellValueType.empty ||
-                    this.getters.getCell(rightPosition)?.content) {
+                while (this.getters.getCell(rightPosition)?.content) {
                     row += 1;
                     rightPosition = { sheetId, col: col + 1, row };
                 }
@@ -45704,11 +45720,10 @@ class SelectionStreamProcessorImpl {
      * next cluster if the given cell is outside a cluster or at the border of a cluster in the given direction.
      */
     getEndOfCluster(startPosition, dim, dir) {
-        const sheet = this.getters.getActiveSheet();
         let currentPosition = startPosition;
         // If both the current cell and the next cell are not empty, we want to go to the end of the cluster
         const nextCellPosition = this.getNextCellPosition(startPosition, dim, dir);
-        let mode = !this.isCellEmpty(currentPosition, sheet.id) && !this.isCellEmpty(nextCellPosition, sheet.id)
+        let mode = !this.isEvaluatedCellEmpty(currentPosition) && !this.isEvaluatedCellEmpty(nextCellPosition)
             ? "endOfCluster"
             : "nextCluster";
         while (true) {
@@ -45718,7 +45733,7 @@ class SelectionStreamProcessorImpl {
                 currentPosition.row === nextCellPosition.row) {
                 break;
             }
-            const isNextCellEmpty = this.isCellEmpty(nextCellPosition, sheet.id);
+            const isNextCellEmpty = this.isEvaluatedCellEmpty(nextCellPosition);
             if (mode === "endOfCluster" && isNextCellEmpty) {
                 break;
             }
@@ -45732,14 +45747,24 @@ class SelectionStreamProcessorImpl {
         return dim === "cols" ? currentPosition.col : currentPosition.row;
     }
     /**
-     * Check if a cell is empty or undefined in the model. If the cell is part of a merge,
-     * check if the merge containing the cell is empty.
+     * Check if a cell evaluated value is empty. If the cell is part of a merge,
+     * the check applies to the main cell of the merge.
      */
-    isCellEmpty({ col, row }, sheetId = this.getters.getActiveSheetId()) {
+    isEvaluatedCellEmpty({ col, row }) {
+        const sheetId = this.getters.getActiveSheetId();
         const position = this.getters.getMainCellPosition({ sheetId, col, row });
         const cell = this.getters.getEvaluatedCell(position);
         return cell.type === CellValueType.empty;
     }
+    /**
+     * Checks if a cell is empty (i.e. does not have a content). If the cell is part of a merge,
+     * the check applies to the main cell of the merge.
+     */
+    isCellEmpty({ col, row }) {
+        const sheetId = this.getters.getActiveSheetId();
+        const position = this.getters.getMainCellPosition({ sheetId, col, row });
+        return !this.getters.getCell(position)?.content;
+    }
     /** Computes the next cell position in the given direction by crossing through merges and skipping hidden cells.
      *
      * This has the same behaviour as getNextAvailablePosition() for certain arguments, but use this method instead
@@ -48008,6 +48033,6 @@ exports.setTranslationMethod = setTranslationMethod;
 exports.tokenize = tokenize;
 
 
-__info__.version = '16.3.25';
-__info__.date = '2024-02-09T13:07:06.947Z';
-__info__.hash = 'b53bf1b';
+__info__.version = '16.3.26';
+__info__.date = '2024-02-16T14:22:11.270Z';
+__info__.hash = 'ab9abb6';

package/dist/o-spreadsheet.d.ts

@@ -3197,6 +3197,7 @@ declare class CellPlugin extends CorePlugin<CoreState> implements CoreState {
     private createErrorFormula;
     private checkCellOutOfSheet;
     private checkUselessClearCell;
+    private checkUselessUpdateCell;
 }
 
 /**

package/dist/o-spreadsheet.esm.js

@@ -9432,6 +9432,12 @@ const INSERT_LINK = (env) => {
     let { col, row } = env.model.getters.getActivePosition();
     env.model.dispatch("OPEN_CELL_POPOVER", { col, row, popoverType: "LinkEditor" });
 };
+const INSERT_LINK_NAME = (env) => {
+    const sheetId = env.model.getters.getActiveSheetId();
+    const { col, row } = env.model.getters.getActivePosition();
+    const cell = env.model.getters.getEvaluatedCell({ sheetId, col, row });
+    return cell && cell.link ? _lt("Edit link") : _lt("Insert link");
+};
 //------------------------------------------------------------------------------
 // Filters action
 //------------------------------------------------------------------------------
@@ -16656,7 +16662,7 @@ cellMenuRegistry
 })
     .add("insert_link", {
     ...insertLink,
-    name: _lt("Insert link"),
+    name: INSERT_LINK_NAME,
     sequence: 150,
     separator: true,
 });
@@ -29684,9 +29690,9 @@ class CellPlugin extends CorePlugin {
     allowDispatch(cmd) {
         switch (cmd.type) {
             case "UPDATE_CELL":
-                return this.checkCellOutOfSheet(cmd);
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
             case "CLEAR_CELL":
-                return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
             default:
                 return 0 /* CommandResult.Success */;
         }
@@ -29980,7 +29986,7 @@ class CellPlugin extends CorePlugin {
         else {
             style = before ? before.style : undefined;
         }
-        let format = ("format" in after ? after.format : before && before.format) || detectFormat(afterContent);
+        const format = "format" in after ? after.format : before && before.format;
         /* Read the following IF as:
          * we need to remove the cell if it is completely empty, but we can know if it completely empty if:
          * - the command says the new content is empty and has no border/format/style
@@ -30024,7 +30030,7 @@ class CellPlugin extends CorePlugin {
             id,
             content,
             style,
-            format,
+            format: format || detectFormat(content),
             isFormula: false,
         };
     }
@@ -30101,6 +30107,18 @@ class CellPlugin extends CorePlugin {
         }
         return 0 /* CommandResult.Success */;
     }
+    checkUselessUpdateCell(cmd) {
+        const cell = this.getters.getCell(cmd);
+        const hasContent = "content" in cmd || "formula" in cmd;
+        const hasStyle = "style" in cmd;
+        const hasFormat = "format" in cmd;
+        if ((!hasContent || cell?.content === cmd.content) &&
+            (!hasStyle || deepEquals(cell?.style, cmd.style)) &&
+            (!hasFormat || cell?.format === cmd.format)) {
+            return 94 /* CommandResult.NoChanges */;
+        }
+        return 0 /* CommandResult.Success */;
+    }
 }
 
 class ChartPlugin extends CorePlugin {
@@ -35764,8 +35782,7 @@ class AutofillPlugin extends UIPlugin {
         let row = zone.bottom;
         if (col > 0) {
             let leftPosition = { sheetId, col: col - 1, row };
-            while (this.getters.getEvaluatedCell(leftPosition).type !== CellValueType.empty ||
-                this.getters.getCell(leftPosition)?.content) {
+            while (this.getters.getCell(leftPosition)?.content) {
                 row += 1;
                 leftPosition = { sheetId, col: col - 1, row };
             }
@@ -35774,8 +35791,7 @@ class AutofillPlugin extends UIPlugin {
             col = zone.right;
             if (col <= this.getters.getNumberCols(sheetId)) {
                 let rightPosition = { sheetId, col: col + 1, row };
-                while (this.getters.getEvaluatedCell(rightPosition).type !== CellValueType.empty ||
-                    this.getters.getCell(rightPosition)?.content) {
+                while (this.getters.getCell(rightPosition)?.content) {
                     row += 1;
                     rightPosition = { sheetId, col: col + 1, row };
                 }
@@ -45700,11 +45716,10 @@ class SelectionStreamProcessorImpl {
      * next cluster if the given cell is outside a cluster or at the border of a cluster in the given direction.
      */
     getEndOfCluster(startPosition, dim, dir) {
-        const sheet = this.getters.getActiveSheet();
         let currentPosition = startPosition;
         // If both the current cell and the next cell are not empty, we want to go to the end of the cluster
         const nextCellPosition = this.getNextCellPosition(startPosition, dim, dir);
-        let mode = !this.isCellEmpty(currentPosition, sheet.id) && !this.isCellEmpty(nextCellPosition, sheet.id)
+        let mode = !this.isEvaluatedCellEmpty(currentPosition) && !this.isEvaluatedCellEmpty(nextCellPosition)
             ? "endOfCluster"
             : "nextCluster";
         while (true) {
@@ -45714,7 +45729,7 @@ class SelectionStreamProcessorImpl {
                 currentPosition.row === nextCellPosition.row) {
                 break;
             }
-            const isNextCellEmpty = this.isCellEmpty(nextCellPosition, sheet.id);
+            const isNextCellEmpty = this.isEvaluatedCellEmpty(nextCellPosition);
             if (mode === "endOfCluster" && isNextCellEmpty) {
                 break;
             }
@@ -45728,14 +45743,24 @@ class SelectionStreamProcessorImpl {
         return dim === "cols" ? currentPosition.col : currentPosition.row;
     }
     /**
-     * Check if a cell is empty or undefined in the model. If the cell is part of a merge,
-     * check if the merge containing the cell is empty.
+     * Check if a cell evaluated value is empty. If the cell is part of a merge,
+     * the check applies to the main cell of the merge.
      */
-    isCellEmpty({ col, row }, sheetId = this.getters.getActiveSheetId()) {
+    isEvaluatedCellEmpty({ col, row }) {
+        const sheetId = this.getters.getActiveSheetId();
         const position = this.getters.getMainCellPosition({ sheetId, col, row });
         const cell = this.getters.getEvaluatedCell(position);
         return cell.type === CellValueType.empty;
     }
+    /**
+     * Checks if a cell is empty (i.e. does not have a content). If the cell is part of a merge,
+     * the check applies to the main cell of the merge.
+     */
+    isCellEmpty({ col, row }) {
+        const sheetId = this.getters.getActiveSheetId();
+        const position = this.getters.getMainCellPosition({ sheetId, col, row });
+        return !this.getters.getCell(position)?.content;
+    }
     /** Computes the next cell position in the given direction by crossing through merges and skipping hidden cells.
      *
      * This has the same behaviour as getNextAvailablePosition() for certain arguments, but use this method instead
@@ -47976,6 +48001,6 @@ function addFunction(functionName, functionDescription) {
 export { AbstractChart, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, UIPlugin, __info__, addFunction, astToFormula, compile, components, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, invalidateEvaluationCommands, links, load, parse, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, tokenize };
 
 
-__info__.version = '16.3.25';
-__info__.date = '2024-02-09T13:07:06.947Z';
-__info__.hash = 'b53bf1b';
+__info__.version = '16.3.26';
+__info__.date = '2024-02-16T14:22:11.270Z';
+__info__.hash = 'ab9abb6';

package/dist/o-spreadsheet.iife.js

@@ -9433,6 +9433,12 @@
       let { col, row } = env.model.getters.getActivePosition();
       env.model.dispatch("OPEN_CELL_POPOVER", { col, row, popoverType: "LinkEditor" });
   };
+  const INSERT_LINK_NAME = (env) => {
+      const sheetId = env.model.getters.getActiveSheetId();
+      const { col, row } = env.model.getters.getActivePosition();
+      const cell = env.model.getters.getEvaluatedCell({ sheetId, col, row });
+      return cell && cell.link ? _lt("Edit link") : _lt("Insert link");
+  };
   //------------------------------------------------------------------------------
   // Filters action
   //------------------------------------------------------------------------------
@@ -16657,7 +16663,7 @@
   })
       .add("insert_link", {
       ...insertLink,
-      name: _lt("Insert link"),
+      name: INSERT_LINK_NAME,
       sequence: 150,
       separator: true,
   });
@@ -29685,9 +29691,9 @@
       allowDispatch(cmd) {
           switch (cmd.type) {
               case "UPDATE_CELL":
-                  return this.checkCellOutOfSheet(cmd);
+                  return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
               case "CLEAR_CELL":
-                  return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                  return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
               default:
                   return 0 /* CommandResult.Success */;
           }
@@ -29981,7 +29987,7 @@
           else {
               style = before ? before.style : undefined;
           }
-          let format = ("format" in after ? after.format : before && before.format) || detectFormat(afterContent);
+          const format = "format" in after ? after.format : before && before.format;
           /* Read the following IF as:
            * we need to remove the cell if it is completely empty, but we can know if it completely empty if:
            * - the command says the new content is empty and has no border/format/style
@@ -30025,7 +30031,7 @@
               id,
               content,
               style,
-              format,
+              format: format || detectFormat(content),
               isFormula: false,
           };
       }
@@ -30102,6 +30108,18 @@
           }
           return 0 /* CommandResult.Success */;
       }
+      checkUselessUpdateCell(cmd) {
+          const cell = this.getters.getCell(cmd);
+          const hasContent = "content" in cmd || "formula" in cmd;
+          const hasStyle = "style" in cmd;
+          const hasFormat = "format" in cmd;
+          if ((!hasContent || cell?.content === cmd.content) &&
+              (!hasStyle || deepEquals(cell?.style, cmd.style)) &&
+              (!hasFormat || cell?.format === cmd.format)) {
+              return 94 /* CommandResult.NoChanges */;
+          }
+          return 0 /* CommandResult.Success */;
+      }
   }
 
   class ChartPlugin extends CorePlugin {
@@ -35765,8 +35783,7 @@
           let row = zone.bottom;
           if (col > 0) {
               let leftPosition = { sheetId, col: col - 1, row };
-              while (this.getters.getEvaluatedCell(leftPosition).type !== CellValueType.empty ||
-                  this.getters.getCell(leftPosition)?.content) {
+              while (this.getters.getCell(leftPosition)?.content) {
                   row += 1;
                   leftPosition = { sheetId, col: col - 1, row };
               }
@@ -35775,8 +35792,7 @@
               col = zone.right;
               if (col <= this.getters.getNumberCols(sheetId)) {
                   let rightPosition = { sheetId, col: col + 1, row };
-                  while (this.getters.getEvaluatedCell(rightPosition).type !== CellValueType.empty ||
-                      this.getters.getCell(rightPosition)?.content) {
+                  while (this.getters.getCell(rightPosition)?.content) {
                       row += 1;
                       rightPosition = { sheetId, col: col + 1, row };
                   }
@@ -45701,11 +45717,10 @@
        * next cluster if the given cell is outside a cluster or at the border of a cluster in the given direction.
        */
       getEndOfCluster(startPosition, dim, dir) {
-          const sheet = this.getters.getActiveSheet();
           let currentPosition = startPosition;
           // If both the current cell and the next cell are not empty, we want to go to the end of the cluster
           const nextCellPosition = this.getNextCellPosition(startPosition, dim, dir);
-          let mode = !this.isCellEmpty(currentPosition, sheet.id) && !this.isCellEmpty(nextCellPosition, sheet.id)
+          let mode = !this.isEvaluatedCellEmpty(currentPosition) && !this.isEvaluatedCellEmpty(nextCellPosition)
               ? "endOfCluster"
               : "nextCluster";
           while (true) {
@@ -45715,7 +45730,7 @@
                   currentPosition.row === nextCellPosition.row) {
                   break;
               }
-              const isNextCellEmpty = this.isCellEmpty(nextCellPosition, sheet.id);
+              const isNextCellEmpty = this.isEvaluatedCellEmpty(nextCellPosition);
               if (mode === "endOfCluster" && isNextCellEmpty) {
                   break;
               }
@@ -45729,14 +45744,24 @@
           return dim === "cols" ? currentPosition.col : currentPosition.row;
       }
       /**
-       * Check if a cell is empty or undefined in the model. If the cell is part of a merge,
-       * check if the merge containing the cell is empty.
+       * Check if a cell evaluated value is empty. If the cell is part of a merge,
+       * the check applies to the main cell of the merge.
        */
-      isCellEmpty({ col, row }, sheetId = this.getters.getActiveSheetId()) {
+      isEvaluatedCellEmpty({ col, row }) {
+          const sheetId = this.getters.getActiveSheetId();
           const position = this.getters.getMainCellPosition({ sheetId, col, row });
           const cell = this.getters.getEvaluatedCell(position);
           return cell.type === CellValueType.empty;
       }
+      /**
+       * Checks if a cell is empty (i.e. does not have a content). If the cell is part of a merge,
+       * the check applies to the main cell of the merge.
+       */
+      isCellEmpty({ col, row }) {
+          const sheetId = this.getters.getActiveSheetId();
+          const position = this.getters.getMainCellPosition({ sheetId, col, row });
+          return !this.getters.getCell(position)?.content;
+      }
       /** Computes the next cell position in the given direction by crossing through merges and skipping hidden cells.
        *
        * This has the same behaviour as getNextAvailablePosition() for certain arguments, but use this method instead
@@ -48007,9 +48032,9 @@
   Object.defineProperty(exports, '__esModule', { value: true });
 
 
-  __info__.version = '16.3.25';
-  __info__.date = '2024-02-09T13:07:06.947Z';
-  __info__.hash = 'b53bf1b';
+  __info__.version = '16.3.26';
+  __info__.date = '2024-02-16T14:22:11.270Z';
+  __info__.hash = 'ab9abb6';
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);