@odoo/o-spreadsheet 16.3.0-alpha.8 → 16.3.1

package/dist/o-spreadsheet.cjs.js

@@ -4400,6 +4400,7 @@ exports.CommandResult = void 0;
     CommandResult[CommandResult["EmptySplitSeparator"] = 89] = "EmptySplitSeparator";
     CommandResult[CommandResult["SplitWillOverwriteContent"] = 90] = "SplitWillOverwriteContent";
     CommandResult[CommandResult["NoSplitSeparatorInSelection"] = 91] = "NoSplitSeparatorInSelection";
+    CommandResult[CommandResult["NoActiveSheet"] = 92] = "NoActiveSheet";
 })(exports.CommandResult || (exports.CommandResult = {}));
 
 const borderStyles = ["thin", "medium", "thick", "dashed", "dotted"];
@@ -16872,6 +16873,7 @@ const unFreezePane = {
     execute: (env) => env.model.dispatch("UNFREEZE_COLUMNS_ROWS", {
         sheetId: env.model.getters.getActiveSheetId(),
     }),
+    icon: "o-spreadsheet-Icon.UNFREEZE",
 };
 const freezePane = {
     name: _lt("Freeze"),
@@ -17549,7 +17551,7 @@ topbarMenuRegistry
 })
     .addChild("sort_range", ["data"], {
     ...sortRange,
-    sequence: 20,
+    sequence: 10,
     separator: true,
 })
     .addChild("sort_ascending", ["data", "sort_range"], {
@@ -17562,16 +17564,16 @@ topbarMenuRegistry
 })
     .addChild("split_to_columns", ["data"], {
     ...splitToColumns,
-    sequence: 10,
+    sequence: 20,
     separator: true,
 })
     .addChild("add_data_filter", ["data"], {
     ...addDataFilter,
-    sequence: 10,
+    sequence: 30,
 })
     .addChild("remove_data_filter", ["data"], {
     ...removeDataFilter,
-    sequence: 10,
+    sequence: 30,
 });
 
 class OTRegistry extends Registry {
@@ -17943,6 +17945,18 @@ css /* scss */ `
       grid-template-columns: repeat(${ITEMS_PER_LINE}, 1fr);
       grid-gap: ${ITEM_HORIZONTAL_MARGIN * 2}px;
     }
+    .o-color-picker-toggler-button {
+      display: flex;
+      .o-color-picker-toggler-sign {
+        margin: auto auto;
+        width: 55%;
+        height: 55%;
+        .o-icon {
+          width: 100%;
+          height: 100%;
+        }
+      }
+    }
     .o-color-picker-line-item {
       width: ${ITEM_EDGE_LENGTH}px;
       height: ${ITEM_EDGE_LENGTH}px;
@@ -18678,6 +18692,18 @@ ChartPanel.props = {
     onCloseSidePanel: Function,
 };
 
+css /* scss */ `
+  .o-spreadsheet {
+    .o-icon {
+      .small-text {
+        font: bold 9px sans-serif;
+      }
+      .heavy-text {
+        font: bold 16px sans-serif;
+      }
+    }
+  }
+`;
 // -----------------------------------------------------------------------------
 // We need here the svg of the icons that we need to convert to images for the renderer
 // -----------------------------------------------------------------------------
@@ -20603,7 +20629,14 @@ class ContentEditableHelper {
             current = it.next();
         }
         if (current.value !== nodeToFind) {
-            throw new Error("Cannot find the node in the children of the element");
+            /** This situation can happen if the code is called while the selection is not currently on the ContentEditableHelper.
+             * In this case, we return 0 because we don't know the size of the text before the selection.
+             *
+             * A known occurence is triggered since the introduction of commit d4663158 (PR #2038).
+             *
+             * FIXME: find a way to test eventhough the selection API is not available in jsDOM.
+             */
+            return 0;
         }
         else {
             if (!current.value.hasChildNodes()) {
@@ -32194,6 +32227,8 @@ class SheetPlugin extends CorePlugin {
         "getSheetSize",
         "getSheetZone",
         "getPaneDivisions",
+        "checkZonesExistInSheet",
+        "getCommandZones",
     ];
     sheetIdsMapName = {};
     orderedSheetIds = [];
@@ -32203,7 +32238,7 @@ class SheetPlugin extends CorePlugin {
     // Command Handling
     // ---------------------------------------------------------------------------
     allowDispatch(cmd) {
-        const genericChecks = this.chainValidations(this.checkSheetExists, this.checkZones)(cmd);
+        const genericChecks = this.chainValidations(this.checkSheetExists, this.checkZonesAreInSheet)(cmd);
         if (genericChecks !== 0 /* CommandResult.Success */) {
             return genericChecks;
         }
@@ -32543,6 +32578,37 @@ class SheetPlugin extends CorePlugin {
             .map(({ col, row }) => this.getCell({ sheetId, col, row }))
             .every((cell) => !cell || cell.content === "");
     }
+    getCommandZones(cmd) {
+        const zones = [];
+        if ("zone" in cmd) {
+            zones.push(cmd.zone);
+        }
+        if ("target" in cmd) {
+            zones.push(...cmd.target);
+        }
+        if ("ranges" in cmd) {
+            zones.push(...cmd.ranges.map((rangeData) => this.getters.getRangeFromRangeData(rangeData).zone));
+        }
+        if ("col" in cmd && "row" in cmd) {
+            zones.push({ top: cmd.row, left: cmd.col, bottom: cmd.row, right: cmd.col });
+        }
+        return zones;
+    }
+    /**
+     * Check if zones in the command are well formed and
+     * not outside the sheet.
+     */
+    checkZonesExistInSheet(sheetId, zones) {
+        if (!zones.every(isZoneValid))
+            return 25 /* CommandResult.InvalidRange */;
+        if (zones.length) {
+            const sheetZone = this.getSheetZone(sheetId);
+            return zones.every((zone) => isZoneInside(zone, sheetZone))
+                ? 0 /* CommandResult.Success */
+                : 18 /* CommandResult.TargetOutOfSheet */;
+        }
+        return 0 /* CommandResult.Success */;
+    }
     updateCellPosition(cmd) {
         const { sheetId, cellId, col, row } = cmd;
         if (cellId) {
@@ -32991,9 +33057,6 @@ class SheetPlugin extends CorePlugin {
         }
         return { rowNumber, colNumber };
     }
-    // ----------------------------------------------------
-    //  HIDE / SHOW
-    // ----------------------------------------------------
     /**
      * Check that any "sheetId" in the command matches an existing
      * sheet.
@@ -33011,27 +33074,10 @@ class SheetPlugin extends CorePlugin {
      * Check if zones in the command are well formed and
      * not outside the sheet.
      */
-    checkZones(cmd) {
-        const zones = [];
-        if ("zone" in cmd) {
-            zones.push(cmd.zone);
-        }
-        if ("target" in cmd && Array.isArray(cmd.target)) {
-            zones.push(...cmd.target);
-        }
-        if ("ranges" in cmd && Array.isArray(cmd.ranges)) {
-            zones.push(...cmd.ranges.map((rangeData) => this.getters.getRangeFromRangeData(rangeData).zone));
-        }
-        if (!zones.every(isZoneValid)) {
-            return 25 /* CommandResult.InvalidRange */;
-        }
-        else if (zones.length && "sheetId" in cmd) {
-            const sheetZone = this.getSheetZone(cmd.sheetId);
-            return zones.every((zone) => isZoneInside(zone, sheetZone))
-                ? 0 /* CommandResult.Success */
-                : 18 /* CommandResult.TargetOutOfSheet */;
-        }
-        return 0 /* CommandResult.Success */;
+    checkZonesAreInSheet(cmd) {
+        if (!("sheetId" in cmd))
+            return 0 /* CommandResult.Success */;
+        return this.checkZonesExistInSheet(cmd.sheetId, this.getCommandZones(cmd));
     }
 }
 
@@ -33622,7 +33668,7 @@ class EvaluationConditionalFormatPlugin extends UIPlugin {
                 }
                 break;
             case "PASTE_CONDITIONAL_FORMAT":
-                this.pasteCf(cmd.origin, cmd.target, cmd.operation);
+                this.pasteCf(cmd.originPosition, cmd.targetPosition, cmd.operation);
                 break;
         }
     }
@@ -38607,18 +38653,7 @@ class SheetUIPlugin extends UIPlugin {
     // Command Handling
     // ---------------------------------------------------------------------------
     allowDispatch(cmd) {
-        switch (cmd.type) {
-            case "AUTORESIZE_ROWS":
-            case "AUTORESIZE_COLUMNS":
-                try {
-                    this.getters.getSheet(cmd.sheetId);
-                    break;
-                }
-                catch (error) {
-                    return 27 /* CommandResult.InvalidSheetId */;
-                }
-        }
-        return 0 /* CommandResult.Success */;
+        return this.chainValidations(this.checkSheetExists, this.checkZonesAreInSheet)(cmd);
     }
     handle(cmd) {
         switch (cmd.type) {
@@ -38653,7 +38688,8 @@ class SheetUIPlugin extends UIPlugin {
     getCellWidth(position) {
         const text = this.getCellText(position);
         const style = this.getters.getCellComputedStyle(position);
-        let contentWidth = this.getTextWidth(text, style);
+        const multiLineText = text.split(NEWLINE);
+        let contentWidth = Math.max(...multiLineText.map((line) => this.getTextWidth(line, style)));
         const icon = this.getters.getConditionalIcon(position);
         if (icon) {
             contentWidth += computeIconWidth(this.getters.getCellStyle(position));
@@ -38818,6 +38854,31 @@ class SheetUIPlugin extends UIPlugin {
         splitWord.push(wordPart);
         return splitWord;
     }
+    /**
+     * Check that any "sheetId" in the command matches an existing
+     * sheet.
+     */
+    checkSheetExists(cmd) {
+        if ("sheetId" in cmd && this.getters.tryGetSheet(cmd.sheetId) === undefined) {
+            return 27 /* CommandResult.InvalidSheetId */;
+        }
+        return 0 /* CommandResult.Success */;
+    }
+    /**
+     * Check if zones in the command are well formed and
+     * not outside the sheet.
+     */
+    checkZonesAreInSheet(cmd) {
+        const sheetId = "sheetId" in cmd ? cmd.sheetId : this.getters.tryGetActiveSheetId();
+        const zones = this.getters.getCommandZones(cmd);
+        if (!sheetId && zones.length > 0) {
+            return 92 /* CommandResult.NoActiveSheet */;
+        }
+        if (sheetId && zones.length > 0) {
+            return this.getters.checkZonesExistInSheet(sheetId, zones);
+        }
+        return 0 /* CommandResult.Success */;
+    }
 }
 
 const genericRepeatsTransforms = [
@@ -39642,8 +39703,8 @@ class ClipboardCellsState extends ClipboardCellsAbstractState {
                 this.pasteCell(origin, position, this.operation, clipboardOptions);
                 if (shouldPasteCF) {
                     this.dispatch("PASTE_CONDITIONAL_FORMAT", {
-                        origin: origin.position,
-                        target: position,
+                        originPosition: origin.position,
+                        targetPosition: position,
                         operation: this.operation,
                     });
                 }
@@ -40034,7 +40095,7 @@ class ClipboardPlugin extends UIPlugin {
     allowDispatch(cmd) {
         switch (cmd.type) {
             case "CUT":
-                const zones = cmd.target || this.getters.getSelectedZones();
+                const zones = cmd.cutTarget || this.getters.getSelectedZones();
                 const state = this.getClipboardState(zones, cmd.type);
                 return state.isCutAllowed(zones);
             case "PASTE":
@@ -40064,7 +40125,7 @@ class ClipboardPlugin extends UIPlugin {
         switch (cmd.type) {
             case "COPY":
             case "CUT":
-                const zones = ("target" in cmd && cmd.target) || this.getters.getSelectedZones();
+                const zones = ("cutTarget" in cmd && cmd.cutTarget) || this.getters.getSelectedZones();
                 this.state = this.getClipboardState(zones, cmd.type);
                 this.status = "visible";
                 break;
@@ -41020,6 +41081,7 @@ class GridSelectionPlugin extends UIPlugin {
         "isSelected",
         "isSingleColSelected",
         "getElementsFromSelection",
+        "tryGetActiveSheetId",
     ];
     gridSelection = {
         anchor: {
@@ -41235,6 +41297,9 @@ class GridSelectionPlugin extends UIPlugin {
     getActiveSheetId() {
         return this.activeSheet.id;
     }
+    tryGetActiveSheetId() {
+        return this.activeSheet?.id;
+    }
     getActiveCell() {
         return this.getters.getEvaluatedCell(this.getActivePosition());
     }
@@ -41481,7 +41546,7 @@ class GridSelectionPlugin extends UIPlugin {
         const deltaCol = isBasedBefore && isCol ? thickness : 0;
         const deltaRow = isBasedBefore && !isCol ? thickness : 0;
         this.dispatch("CUT", {
-            target: [
+            cutTarget: [
                 {
                     left: isCol ? start + deltaCol : 0,
                     right: isCol ? end + deltaCol : this.getters.getNumberCols(cmd.sheetId) - 1,
@@ -43753,6 +43818,10 @@ class Spreadsheet extends owl.Component {
     }
     checkViewportSize() {
         const { xRatio, yRatio } = this.env.model.getters.getFrozenSheetViewRatio(this.env.model.getters.getActiveSheetId());
+        if (!isFinite(xRatio) || !isFinite(yRatio)) {
+            // before mounting, the ratios can be NaN or Infinity if the viewport size is 0
+            return;
+        }
         if (yRatio > MAXIMAL_FREEZABLE_RATIO || xRatio > MAXIMAL_FREEZABLE_RATIO) {
             if (this.isViewportTooSmall) {
                 return;
@@ -46975,6 +47044,7 @@ class Model extends EventBus {
     coreGetters;
     uuidGenerator;
     handlers = [];
+    uiHandlers = [];
     coreHandlers = [];
     constructor(data = {}, config = {}, stateUpdateMessages = [], uuidGenerator = new UuidGenerator(), verboseImport = true) {
         super();
@@ -47014,17 +47084,20 @@ class Model extends EventBus {
             const plugin = this.setupUiPlugin(Plugin);
             this.statefulUIPlugins.push(plugin);
             this.handlers.push(plugin);
+            this.uiHandlers.push(plugin);
         }
         for (let Plugin of coreViewsPluginRegistry.getAll()) {
             const plugin = this.setupUiPlugin(Plugin);
             this.coreViewsPlugins.push(plugin);
             this.handlers.push(plugin);
+            this.uiHandlers.push(plugin);
             this.coreHandlers.push(plugin);
         }
         for (let Plugin of featurePluginRegistry.getAll()) {
             const plugin = this.setupUiPlugin(Plugin);
             this.featurePlugins.push(plugin);
             this.handlers.push(plugin);
+            this.uiHandlers.push(plugin);
         }
         this.uuidGenerator.setIsFastStrategy(false);
         // starting plugins
@@ -47193,7 +47266,7 @@ class Model extends EventBus {
         return new DispatchResult(results.flat());
     }
     checkDispatchAllowedLocalCommand(command) {
-        const results = this.handlers.map((handler) => handler.allowDispatch(command));
+        const results = this.uiHandlers.map((handler) => handler.allowDispatch(command));
         return new DispatchResult(results.flat());
     }
     finalize() {
@@ -47510,6 +47583,6 @@ exports.setTranslationMethod = setTranslationMethod;
 exports.tokenize = tokenize;
 
 
-__info__.version = '16.3.0-alpha.8';
-__info__.date = '2023-05-12T10:59:42.550Z';
-__info__.hash = 'afee7d5';
+__info__.version = '16.3.1';
+__info__.date = '2023-05-25T13:00:27.320Z';
+__info__.hash = 'b3cfd2c';

package/dist/o-spreadsheet.d.ts

@@ -1179,6 +1179,7 @@ declare class Model extends EventBus<any> implements CommandDispatcher {
     private coreGetters;
     uuidGenerator: UuidGenerator;
     private readonly handlers;
+    private readonly uiHandlers;
     private readonly coreHandlers;
     constructor(data?: any, config?: Partial<ModelConfig>, stateUpdateMessages?: StateUpdateMessage[], uuidGenerator?: UuidGenerator, verboseImport?: boolean);
     joinSession(): void;
@@ -1880,7 +1881,7 @@ interface CopyCommand {
 interface CutCommand {
     type: "CUT";
     /** Zones to cut. If none were given, will copy the zones in the selection*/
-    target?: Zone[];
+    cutTarget?: Zone[];
 }
 interface PasteCommand {
     type: "PASTE";
@@ -2191,8 +2192,8 @@ interface InsertCellCommand {
 }
 interface PasteCFCommand {
     type: "PASTE_CONDITIONAL_FORMAT";
-    origin: CellPosition;
-    target: CellPosition;
+    originPosition: CellPosition;
+    targetPosition: CellPosition;
     operation: "CUT" | "COPY";
 }
 interface ActivateNextSheetCommand {
@@ -2353,7 +2354,8 @@ declare const enum CommandResult {
     MoreThanOneColumnSelected = 88,
     EmptySplitSeparator = 89,
     SplitWillOverwriteContent = 90,
-    NoSplitSeparatorInSelection = 91
+    NoSplitSeparatorInSelection = 91,
+    NoActiveSheet = 92
 }
 interface CommandHandler<T> {
     allowDispatch(command: T): CommandResult | CommandResult[];
@@ -3543,7 +3545,7 @@ interface SheetState$1 {
     readonly cellPosition: Record<UID, CellPosition | undefined>;
 }
 declare class SheetPlugin extends CorePlugin<SheetState$1> implements SheetState$1 {
-    static getters: readonly ["getSheetName", "tryGetSheetName", "getSheet", "tryGetSheet", "getSheetIdByName", "getSheetIds", "getVisibleSheetIds", "isSheetVisible", "getEvaluationSheets", "doesHeaderExist", "getCell", "getCellPosition", "getColsZone", "getRowCells", "getRowsZone", "getNumberCols", "getNumberRows", "getNumberHeaders", "getGridLinesVisibility", "getNextSheetName", "isEmpty", "getSheetSize", "getSheetZone", "getPaneDivisions"];
+    static getters: readonly ["getSheetName", "tryGetSheetName", "getSheet", "tryGetSheet", "getSheetIdByName", "getSheetIds", "getVisibleSheetIds", "isSheetVisible", "getEvaluationSheets", "doesHeaderExist", "getCell", "getCellPosition", "getColsZone", "getRowCells", "getRowsZone", "getNumberCols", "getNumberRows", "getNumberHeaders", "getGridLinesVisibility", "getNextSheetName", "isEmpty", "getSheetSize", "getSheetZone", "getPaneDivisions", "checkZonesExistInSheet", "getCommandZones"];
     readonly sheetIdsMapName: Record<string, UID | undefined>;
     readonly orderedSheetIds: UID[];
     readonly sheets: Record<UID, Sheet | undefined>;
@@ -3589,6 +3591,12 @@ declare class SheetPlugin extends CorePlugin<SheetState$1> implements SheetState
      * Check if a zone only contains empty cells
      */
     isEmpty(sheetId: UID, zone: Zone): boolean;
+    getCommandZones(cmd: Command): Zone[];
+    /**
+     * Check if zones in the command are well formed and
+     * not outside the sheet.
+     */
+    checkZonesExistInSheet(sheetId: UID, zones: Zone[]): CommandResult;
     private updateCellPosition;
     /**
      * Set the cell at a new position and clear its previous position.
@@ -3682,7 +3690,7 @@ declare class SheetPlugin extends CorePlugin<SheetState$1> implements SheetState
      * Check if zones in the command are well formed and
      * not outside the sheet.
      */
-    private checkZones;
+    private checkZonesAreInSheet;
 }
 
 /**
@@ -4562,7 +4570,7 @@ declare class UIOptionsPlugin extends UIPlugin {
 declare class SheetUIPlugin extends UIPlugin {
     static getters: readonly ["getCellWidth", "getTextWidth", "getCellText", "getCellMultiLineText", "getColDimensions", "getRowDimensions", "getColRowOffset"];
     private ctx;
-    allowDispatch(cmd: LocalCommand): CommandResult;
+    allowDispatch(cmd: LocalCommand): CommandResult | CommandResult[];
     handle(cmd: Command): void;
     getCellWidth(position: CellPosition): number;
     getTextWidth(text: string, style: Style): Pixel;
@@ -4590,6 +4598,16 @@ declare class SheetUIPlugin extends UIPlugin {
     getColRowOffset(dimension: Dimension, referenceIndex: HeaderIndex, index: HeaderIndex, sheetId?: UID): Pixel;
     private getColMaxWidth;
     private splitWordToSpecificWidth;
+    /**
+     * Check that any "sheetId" in the command matches an existing
+     * sheet.
+     */
+    private checkSheetExists;
+    /**
+     * Check if zones in the command are well formed and
+     * not outside the sheet.
+     */
+    private checkZonesAreInSheet;
 }
 
 /**
@@ -4637,7 +4655,7 @@ declare class ClipboardPlugin extends UIPlugin {
  */
 declare class GridSelectionPlugin extends UIPlugin {
     static layers: LAYERS[];
-    static getters: readonly ["getActiveSheet", "getActiveSheetId", "getActiveCell", "getActiveCols", "getActiveRows", "getCurrentStyle", "getSelectedZones", "getSelectedZone", "getSelectedCells", "getStatisticFnResults", "getAggregate", "getSelectedFigureId", "getSelection", "getActivePosition", "getSheetPosition", "isSelected", "isSingleColSelected", "getElementsFromSelection"];
+    static getters: readonly ["getActiveSheet", "getActiveSheetId", "getActiveCell", "getActiveCols", "getActiveRows", "getCurrentStyle", "getSelectedZones", "getSelectedZone", "getSelectedCells", "getStatisticFnResults", "getAggregate", "getSelectedFigureId", "getSelection", "getActivePosition", "getSheetPosition", "isSelected", "isSingleColSelected", "getElementsFromSelection", "tryGetActiveSheetId"];
     private gridSelection;
     private selectedFigureId;
     private sheetsData;
@@ -4649,6 +4667,7 @@ declare class GridSelectionPlugin extends UIPlugin {
     handle(cmd: Command): void;
     getActiveSheet(): Readonly<Sheet>;
     getActiveSheetId(): UID;
+    tryGetActiveSheetId(): UID | undefined;
     getActiveCell(): EvaluatedCell;
     getActiveCols(): Set<number>;
     getActiveRows(): Set<number>;