@odoo/o-spreadsheet 16.1.33 → 16.1.37

package/dist/o-spreadsheet.iife.js

@@ -204,7 +204,7 @@
   const BOTTOMBAR_HEIGHT = 36;
   const DEFAULT_CELL_WIDTH = 96;
   const DEFAULT_CELL_HEIGHT = 23;
-  const SCROLLBAR_WIDTH$1 = 15;
+  const SCROLLBAR_WIDTH = 15;
   const AUTOFILL_EDGE_LENGTH = 8;
   const ICON_EDGE_LENGTH = 18;
   const UNHIDE_ICON_EDGE_LENGTH = 14;
@@ -1673,6 +1673,9 @@
   function formatValue(value, format) {
       switch (typeof value) {
           case "string":
+              if (value.includes('\\"')) {
+                  return value.replace(/\\"/g, '"');
+              }
               return value;
           case "boolean":
               return value ? "TRUE" : "FALSE";
@@ -3875,14 +3878,8 @@
                       : undefined));
               }
           }
-          else if (zone.left === zone.right && zone.top === zone.bottom) {
-              // A single cell. If it's only the title, the dataset is not added.
-              if (!dataSetsHaveTitle) {
-                  dataSets.push(createDataSet(getters, dataSetSheetId, zone, undefined));
-              }
-          }
           else {
-              /* 1 row or 1 column */
+              /* 1 cell, 1 row or 1 column */
               dataSets.push(createDataSet(getters, dataSetSheetId, zone, dataSetsHaveTitle
                   ? {
                       top: zone.top,
@@ -3932,8 +3929,10 @@
       }
       const dataRange = ds.dataRange.clone({ zone: dataZone });
       return {
-          label: ds.labelCell ? getters.getRangeString(ds.labelCell, "forceSheetReference") : undefined,
-          range: getters.getRangeString(dataRange, "forceSheetReference"),
+          label: ds.labelCell
+              ? getters.getRangeString(ds.labelCell, "forceSheetReference", true)
+              : undefined,
+          range: getters.getRangeString(dataRange, "forceSheetReference", true),
       };
   }
   /**
@@ -4430,6 +4429,9 @@
               .filter((ds) => ds.range !== ""); // && range !== INCORRECT_RANGE_STRING ? show incorrect #ref ?
           return {
               ...this.getDefinition(),
+              labelRange: this.labelRange
+                  ? this.getters.getRangeString(this.labelRange, this.sheetId, true)
+                  : undefined,
               backgroundColor: toXlsxHexColor(this.background || BACKGROUND_CHART_COLOR),
               fontColor: toXlsxHexColor(chartFontColor(this.background)),
               dataSets,
@@ -4988,6 +4990,9 @@
               .filter((ds) => ds.range !== ""); // && range !== INCORRECT_RANGE_STRING ? show incorrect #ref ?
           return {
               ...this.getDefinition(),
+              labelRange: this.labelRange
+                  ? this.getters.getRangeString(this.labelRange, this.sheetId, true)
+                  : undefined,
               backgroundColor: toXlsxHexColor(this.background || BACKGROUND_CHART_COLOR),
               fontColor: toXlsxHexColor(chartFontColor(this.background)),
               dataSets,
@@ -5251,6 +5256,9 @@
               .filter((ds) => ds.range !== ""); // && range !== INCORRECT_RANGE_STRING ? show incorrect #ref ?
           return {
               ...this.getDefinition(),
+              labelRange: this.labelRange
+                  ? this.getters.getRangeString(this.labelRange, this.sheetId, true)
+                  : undefined,
               backgroundColor: toXlsxHexColor(this.background || BACKGROUND_CHART_COLOR),
               fontColor: toXlsxHexColor(chartFontColor(this.background)),
               verticalAxisPosition: "left",
@@ -7256,6 +7264,12 @@
       let { col, row } = env.model.getters.getActivePosition();
       env.model.dispatch("OPEN_CELL_POPOVER", { col, row, popoverType: "LinkEditor" });
   };
+  const INSERT_LINK_NAME = (env) => {
+      const sheetId = env.model.getters.getActiveSheetId();
+      const { col, row } = env.model.getters.getActivePosition();
+      const cell = env.model.getters.getEvaluatedCell({ sheetId, col, row });
+      return cell && cell.link ? _lt("Edit link") : _lt("Insert link");
+  };
   //------------------------------------------------------------------------------
   // Filters action
   //------------------------------------------------------------------------------
@@ -7393,7 +7407,7 @@
       action: DELETE_CELL_SHIFT_LEFT,
   })
       .add("insert_link", {
-      name: _lt("Insert link"),
+      name: INSERT_LINK_NAME,
       separator: true,
       sequence: 150,
       action: INSERT_LINK,
@@ -16552,9 +16566,6 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
                   break;
           }
       }
-      unsubscribe() {
-          this.mode = "inactive";
-      }
       // ---------------------------------------------------------------------------
       // Getters
       // ---------------------------------------------------------------------------
@@ -17447,13 +17458,12 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
       setup() {
           owl.onMounted(() => {
               const el = this.composerRef.el;
+              if (this.props.isDefaultFocus) {
+                  this.env.focusableElement.setFocusableElement(el);
+              }
               this.contentHelper.updateEl(el);
               this.processContent();
           });
-          owl.onWillUnmount(() => {
-              var _a, _b;
-              (_b = (_a = this.props).onComposerUnmounted) === null || _b === void 0 ? void 0 : _b.call(_a);
-          });
           owl.onPatched(() => {
               if (!this.isKeyStillDown) {
                   this.processContent();
@@ -17464,7 +17474,8 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
       // Handlers
       // ---------------------------------------------------------------------------
       processArrowKeys(ev) {
-          if (this.env.model.getters.isSelectingForComposer()) {
+          if (this.env.model.getters.isSelectingForComposer() ||
+              this.env.model.getters.getEditionMode() === "inactive") {
               this.functionDescriptionState.showDescription = false;
               // Prevent the default content editable behavior which moves the cursor
               ev.preventDefault();
@@ -17505,21 +17516,23 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           var _a;
           ev.preventDefault();
           ev.stopPropagation();
-          if (this.autoCompleteState.showProvider) {
-              const autoCompleteValue = (_a = this.autoCompleteState.values[this.autoCompleteState.selectedIndex]) === null || _a === void 0 ? void 0 : _a.text;
-              if (autoCompleteValue) {
-                  this.autoComplete(autoCompleteValue);
-                  return;
+          if (this.env.model.getters.getEditionMode() !== "inactive") {
+              if (this.autoCompleteState.showProvider) {
+                  const autoCompleteValue = (_a = this.autoCompleteState.values[this.autoCompleteState.selectedIndex]) === null || _a === void 0 ? void 0 : _a.text;
+                  if (autoCompleteValue) {
+                      this.autoComplete(autoCompleteValue);
+                      return;
+                  }
               }
-          }
-          else {
-              // when completing with tab, if there is no value to complete, the active cell will be moved to the right.
-              // we can't let the model think that it is for a ref selection.
-              // todo: check if this can be removed someday
-              this.env.model.dispatch("STOP_COMPOSER_RANGE_SELECTION");
+              else {
+                  // when completing with tab, if there is no value to complete, the active cell will be moved to the right.
+                  // we can't let the model think that it is for a ref selection.
+                  // todo: check if this can be removed someday
+                  this.env.model.dispatch("STOP_COMPOSER_RANGE_SELECTION");
+              }
+              this.env.model.dispatch("STOP_EDITION");
           }
           const direction = ev.shiftKey ? "left" : "right";
-          this.env.model.dispatch("STOP_EDITION");
           this.env.model.selection.moveAnchorCell(direction, 1);
       }
       processEnterKey(ev) {
@@ -17552,6 +17565,9 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           this.compositionActive = false;
       }
       onKeydown(ev) {
+          if (this.env.model.getters.getEditionMode() === "inactive") {
+              return;
+          }
           let handler = this.keyMapping[ev.key];
           if (handler) {
               handler.call(this, ev);
@@ -17562,23 +17578,46 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           }
       }
       updateCursorIfNeeded() {
-          if (!this.env.model.getters.isSelectingForComposer()) {
+          const moveCursor = !this.env.model.getters.isSelectingForComposer() &&
+              !(this.env.model.getters.getEditionMode() === "inactive");
+          if (moveCursor) {
               const { start, end } = this.contentHelper.getCurrentSelection();
               this.env.model.dispatch("CHANGE_COMPOSER_CURSOR_SELECTION", { start, end });
               this.isKeyStillDown = true;
           }
       }
+      onPaste(ev) {
+          if (this.env.model.getters.getEditionMode() !== "inactive") {
+              ev.stopPropagation();
+          }
+      }
       /*
        * Triggered automatically by the content-editable between the keydown and key up
        * */
-      onInput() {
-          if (this.props.focus === "inactive" || !this.shouldProcessInputEvents) {
+      onInput(ev) {
+          var _a, _b;
+          if (!this.shouldProcessInputEvents) {
               return;
           }
+          if (ev.inputType === "insertFromPaste" &&
+              this.env.model.getters.getEditionMode() === "inactive") {
+              return;
+          }
+          ev.stopPropagation();
+          let content;
+          if (this.env.model.getters.getEditionMode() === "inactive") {
+              content = ev.data || "";
+          }
+          else {
+              const el = this.composerRef.el;
+              content = el.childNodes.length ? el.textContent : "";
+          }
+          if (this.props.focus === "inactive") {
+              return (_b = (_a = this.props).onComposerCellFocused) === null || _b === void 0 ? void 0 : _b.call(_a, content);
+          }
           this.env.model.dispatch("STOP_COMPOSER_RANGE_SELECTION");
-          const el = this.composerRef.el;
           this.env.model.dispatch("SET_CURRENT_CONTENT", {
-              content: el.childNodes.length ? el.textContent : "",
+              content,
               selection: this.contentHelper.getCurrentSelection(),
           });
       }
@@ -17638,9 +17677,8 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           }
           const newSelection = this.contentHelper.getCurrentSelection();
           this.env.model.dispatch("STOP_COMPOSER_RANGE_SELECTION");
-          if (this.props.focus === "inactive") {
-              this.props.onComposerContentFocused(newSelection);
-          }
+          this.props.onComposerContentFocused();
+          if (this.props.focus === "inactive") ;
           this.env.model.dispatch("CHANGE_COMPOSER_CURSOR_SELECTION", newSelection);
           this.processTokenAtCursor();
       }
@@ -17657,6 +17695,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           this.contentHelper.removeAll(); // removes the content of the composer, to be added just after
           this.shouldProcessInputEvents = false;
           if (this.props.focus !== "inactive") {
+              this.contentHelper.el.focus();
               this.contentHelper.selectRange(0, 0); // move the cursor inside the composer at 0 0.
           }
           const content = this.getContent();
@@ -17823,18 +17862,18 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
   Composer.components = { TextValueProvider, FunctionDescriptionProvider };
   Composer.defaultProps = {
       inputStyle: "",
+      isDefaultFocus: false,
   };
   Composer.props = {
       inputStyle: { type: String, optional: true },
       rect: { type: Object, optional: true },
       delimitation: { type: Object, optional: true },
       focus: { validate: (value) => ["inactive", "cellFocus", "contentFocus"].includes(value) },
-      onComposerUnmounted: { type: Function, optional: true },
+      onComposerCellFocused: { type: Function, optional: true },
       onComposerContentFocused: Function,
+      isDefaultFocus: { type: Boolean, optional: true },
   };
 
-  const SCROLLBAR_WIDTH = 14;
-  const SCROLLBAR_HIGHT = 15;
   const COMPOSER_BORDER_WIDTH = 3 * 0.4 * window.devicePixelRatio || 1;
   css /* scss */ `
   div.o-grid-composer {
@@ -17849,35 +17888,52 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
    * It also applies the style of the cell to the composer input.
    */
   class GridComposer extends owl.Component {
+      constructor() {
+          super(...arguments);
+          this.rect = undefined;
+          this.isEditing = false;
+      }
+      get defaultRect() {
+          return { x: 0, y: 0, width: 0, height: 0 };
+      }
       setup() {
-          this.gridComposerRef = owl.useRef("gridComposer");
-          this.composerState = owl.useState({
-              rect: undefined,
-              delimitation: undefined,
-          });
-          const { sheetId, col, row } = this.env.model.getters.getActivePosition();
-          this.zone = this.env.model.getters.expandZone(sheetId, positionToZone({ col, row }));
-          this.rect = this.env.model.getters.getVisibleRect(this.zone);
-          owl.onMounted(() => {
-              const el = this.gridComposerRef.el;
-              //TODO Should be more correct to have a props that give the parent's clientHeight and clientWidth
-              const maxHeight = el.parentElement.clientHeight - this.rect.y - SCROLLBAR_HIGHT;
-              el.style.maxHeight = (maxHeight + "px");
-              const maxWidth = el.parentElement.clientWidth - this.rect.x - SCROLLBAR_WIDTH;
-              el.style.maxWidth = (maxWidth + "px");
-              this.composerState.rect = {
-                  x: this.rect.x,
-                  y: this.rect.y,
-                  width: el.clientWidth,
-                  height: el.clientHeight,
-              };
-              this.composerState.delimitation = {
-                  width: el.parentElement.clientWidth,
-                  height: el.parentElement.clientHeight,
-              };
+          owl.onWillUpdateProps(() => {
+              const isEditing = this.env.model.getters.getEditionMode() !== "inactive";
+              if (this.isEditing !== isEditing) {
+                  this.isEditing = isEditing;
+                  if (!isEditing) {
+                      this.rect = undefined;
+                      this.env.focusableElement.focus();
+                      return;
+                  }
+                  const position = this.env.model.getters.getActivePosition();
+                  const zone = this.env.model.getters.expandZone(position.sheetId, positionToZone(position));
+                  this.rect = this.env.model.getters.getVisibleRect(zone);
+              }
           });
       }
+      get composerProps() {
+          const { width, height } = this.env.model.getters.getSheetViewDimensionWithHeaders();
+          return {
+              rect: this.rect && { ...this.rect },
+              delimitation: {
+                  width,
+                  height,
+              },
+              inputStyle: this.composerStyle,
+              focus: this.props.focus,
+              isDefaultFocus: true,
+              onComposerContentFocused: this.props.onComposerContentFocused,
+              onComposerCellFocused: this.props.onComposerCellFocused,
+          };
+      }
       get containerStyle() {
+          if (this.env.model.getters.getEditionMode() === "inactive" || !this.rect) {
+              return `
+        position: absolute;
+        z-index: -1000;
+      `;
+          }
           const isFormula = this.env.model.getters.getCurrentContent().startsWith("=");
           const cell = this.env.model.getters.getActiveCell();
           const position = this.env.model.getters.getActivePosition();
@@ -17897,12 +17953,18 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           if (!isFormula) {
               textAlign = style.align || cell.defaultAlign;
           }
+          const sheetDimensions = this.env.model.getters.getSheetViewDimensionWithHeaders();
+          const maxWidth = sheetDimensions.width - this.rect.x;
+          const maxHeight = sheetDimensions.height - this.rect.y;
           return `
       left: ${left - 1}px;
       top: ${top}px;
       min-width: ${width + 2}px;
       min-height: ${height + 1}px;
 
+      max-width: ${maxWidth}px;
+      max-height: ${maxHeight}px;
+
       background: ${background};
       color: ${color};
 
@@ -17926,8 +17988,8 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
   GridComposer.components = { Composer };
   GridComposer.props = {
       focus: { validate: (value) => ["inactive", "cellFocus", "contentFocus"].includes(value) },
-      onComposerUnmounted: Function,
       onComposerContentFocused: Function,
+      onComposerCellFocused: Function,
   };
 
   const CSS$2 = css /* scss */ `
@@ -18339,8 +18401,8 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           if (x === cell) {
               found = true;
           }
-          const cellValue = evaluateLiteral(x === null || x === void 0 ? void 0 : x.content);
-          if (cellValue.type === CellValueType.number) {
+          const cellValue = (x === null || x === void 0 ? void 0 : x.isFormula) ? undefined : evaluateLiteral(x === null || x === void 0 ? void 0 : x.content);
+          if ((cellValue === null || cellValue === void 0 ? void 0 : cellValue.type) === CellValueType.number) {
               group.push(cellValue.value);
           }
           else {
@@ -22689,7 +22751,6 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           this.props.onCellDoubleClicked(col, row);
       }
       onContextMenu(ev) {
-          ev.preventDefault();
           const [col, row] = this.getCartesianCoordinates(ev);
           this.props.onCellRightClicked(col, row, { x: ev.clientX, y: ev.clientY });
       }
@@ -23623,8 +23684,8 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
     &.corner {
       right: 0px;
       bottom: 0px;
-      height: ${SCROLLBAR_WIDTH$1}px;
-      width: ${SCROLLBAR_WIDTH$1}px;
+      height: ${SCROLLBAR_WIDTH}px;
+      width: ${SCROLLBAR_WIDTH}px;
       border-top: 1px solid #e2e3e3;
       border-left: 1px solid #e2e3e3;
     }
@@ -23697,7 +23758,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           return {
               left: `${this.props.leftOffset + x}px`,
               bottom: "0px",
-              height: `${SCROLLBAR_WIDTH$1}px`,
+              height: `${SCROLLBAR_WIDTH}px`,
               right: `0px`,
           };
       }
@@ -23742,7 +23803,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           return {
               top: `${this.props.topOffset + y}px`,
               right: "0px",
-              width: `${SCROLLBAR_WIDTH$1}px`,
+              width: `${SCROLLBAR_WIDTH}px`,
               bottom: `0px`,
           };
       }
@@ -23916,17 +23977,16 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
               menuItems: [],
           });
           this.gridRef = owl.useRef("grid");
-          this.hiddenInput = owl.useRef("hiddenInput");
           this.canvasPosition = useAbsoluteBoundingRect(this.gridRef);
           this.hoveredCell = owl.useState({ col: undefined, row: undefined });
           owl.useChildSubEnv({ getPopoverContainerRect: () => this.getGridRect() });
           owl.useExternalListener(document.body, "cut", this.copy.bind(this, true));
           owl.useExternalListener(document.body, "copy", this.copy.bind(this, false));
           owl.useExternalListener(document.body, "paste", this.paste);
-          owl.onMounted(() => this.focus());
-          this.props.exposeFocus(() => this.focus());
+          owl.onMounted(() => this.focusDefaultElement());
+          this.props.exposeFocus(() => this.focusDefaultElement());
           useGridDrawing("canvas", this.env.model, () => this.env.model.getters.getSheetViewDimensionWithHeaders());
-          owl.useEffect(() => this.focus(), () => [this.env.model.getters.getActiveSheetId()]);
+          owl.useEffect(() => this.focusDefaultElement(), () => [this.env.model.getters.getActiveSheetId()]);
           this.onMouseWheel = useWheelHandler((deltaX, deltaY) => {
               this.moveCanvas(deltaX, deltaY);
               this.hoveredCell.col = undefined;
@@ -23941,21 +24001,20 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           return `
       top: ${HEADER_HEIGHT}px;
       left: ${HEADER_WIDTH}px;
-      height: calc(100% - ${HEADER_HEIGHT + SCROLLBAR_WIDTH$1}px);
-      width: calc(100% - ${HEADER_WIDTH + SCROLLBAR_WIDTH$1}px);
+      height: calc(100% - ${HEADER_HEIGHT + SCROLLBAR_WIDTH}px);
+      width: calc(100% - ${HEADER_WIDTH + SCROLLBAR_WIDTH}px);
     `;
       }
       onClosePopover() {
           if (this.env.model.getters.hasOpenedPopover()) {
               this.closeOpenedPopover();
           }
-          this.focus();
+          this.focusDefaultElement();
       }
-      focus() {
-          var _a;
+      focusDefaultElement() {
           if (!this.env.model.getters.getSelectedFigureId() &&
               this.env.model.getters.getEditionMode() === "inactive") {
-              (_a = this.hiddenInput.el) === null || _a === void 0 ? void 0 : _a.focus();
+              this.env.focusableElement.focus();
           }
       }
       get gridEl() {
@@ -24100,19 +24159,6 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
               return;
           }
       }
-      onInput(ev) {
-          // the user meant to paste in the sheet, not open the composer with the pasted content
-          if (!ev.isComposing && ev.inputType === "insertFromPaste") {
-              return;
-          }
-          if (ev.data) {
-              // if the user types a character on the grid, it means he wants to start composing the selected cell with that
-              // character
-              ev.preventDefault();
-              ev.stopPropagation();
-              this.props.onGridComposerCellFocused(ev.data);
-          }
-      }
       // ---------------------------------------------------------------------------
       // Context Menu
       // ---------------------------------------------------------------------------
@@ -24209,7 +24255,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
       }
       closeMenu() {
           this.menuState.isOpen = false;
-          this.focus();
+          this.focusDefaultElement();
       }
   }
   Grid.template = "o-spreadsheet-Grid";
@@ -27522,7 +27568,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
    * a breaking change is made in the way the state is handled, and an upgrade
    * function should be defined
    */
-  const CURRENT_VERSION = 12;
+  const CURRENT_VERSION = 12.5;
   const INITIAL_SHEET_ID = "Sheet1";
   /**
    * This function tries to load anything that could look like a valid
@@ -27788,6 +27834,31 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
               return data;
           },
       },
+      {
+          description: "Fix datafilter duplication",
+          from: 12,
+          to: 12.5,
+          applyMigration(data) {
+              for (let sheet of data.sheets || []) {
+                  let knownDataFilterZones = [];
+                  for (let filterTable of sheet.filterTables || []) {
+                      const zone = toZone(filterTable.range);
+                      // See commit message for the details
+                      const intersectZoneIndex = knownDataFilterZones.findIndex((knownZone) => overlap(knownZone, zone));
+                      if (intersectZoneIndex !== -1) {
+                          knownDataFilterZones[intersectZoneIndex] = zone;
+                      }
+                      else {
+                          knownDataFilterZones.push(zone);
+                      }
+                  }
+                  sheet.filterTables = knownDataFilterZones.map((zone) => ({
+                      range: zoneToXc(zone),
+                  }));
+              }
+              return data;
+          },
+      },
   ];
   /**
    * This function is used to repair faulty data independently of the migration.
@@ -28552,9 +28623,9 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
       allowDispatch(cmd) {
           switch (cmd.type) {
               case "UPDATE_CELL":
-                  return this.checkCellOutOfSheet(cmd);
+                  return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
               case "CLEAR_CELL":
-                  return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                  return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
               default:
                   return 0 /* CommandResult.Success */;
           }
@@ -28720,13 +28791,13 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
       /*
        * Reconstructs the original formula string based on a normalized form and its dependencies
        */
-      buildFormulaContent(sheetId, cell, dependencies) {
+      buildFormulaContent(sheetId, cell, dependencies, useFixedZone = false) {
           const ranges = dependencies || cell.dependencies;
           let rangeIndex = 0;
           return concat(cell.compiledFormula.tokens.map((token) => {
               if (token.type === "REFERENCE") {
                   const range = ranges[rangeIndex++];
-                  return this.getters.getRangeString(range, sheetId);
+                  return this.getters.getRangeString(range, sheetId, useFixedZone);
               }
               return token.value;
           }));
@@ -28973,6 +29044,18 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           }
           return 0 /* CommandResult.Success */;
       }
+      checkUselessUpdateCell(cmd) {
+          const cell = this.getters.getCell(cmd);
+          const hasContent = "content" in cmd || "formula" in cmd;
+          const hasStyle = "style" in cmd;
+          const hasFormat = "format" in cmd;
+          if ((!hasContent || (cell === null || cell === void 0 ? void 0 : cell.content) === cmd.content) &&
+              (!hasStyle || deepEquals(cell === null || cell === void 0 ? void 0 : cell.style, cmd.style)) &&
+              (!hasFormat || (cell === null || cell === void 0 ? void 0 : cell.format) === cmd.format)) {
+              return 89 /* CommandResult.NoChanges */;
+          }
+          return 0 /* CommandResult.Success */;
+      }
   }
   CellPlugin.getters = [
       "zoneToXC",
@@ -29299,7 +29382,13 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           }
       }
       exportForExcel(data) {
-          this.export(data);
+          if (data.sheets) {
+              for (let sheet of data.sheets) {
+                  if (this.cfRules[sheet.id]) {
+                      sheet.conditionalFormats = this.cfRules[sheet.id].map((rule) => this.mapToConditionalFormat(sheet.id, rule, { useFixedReference: true }));
+                  }
+              }
+          }
       }
       // ---------------------------------------------------------------------------
       // Getters
@@ -29349,11 +29438,11 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
       // ---------------------------------------------------------------------------
       // Private
       // ---------------------------------------------------------------------------
-      mapToConditionalFormat(sheetId, cf) {
+      mapToConditionalFormat(sheetId, cf, options = { useFixedReference: false }) {
           return {
               ...cf,
               ranges: cf.ranges.map((range) => {
-                  return this.getters.getRangeString(range, sheetId);
+                  return this.getters.getRangeString(range, sheetId, options.useFixedReference);
               }),
           };
       }
@@ -31264,8 +31353,9 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
        *
        * @param range the range (received from getRangeFromXC or getRangeFromZone)
        * @param forSheetId the id of the sheet where the range string is supposed to be used.
+       * @param [useFixedZone=false] if true, the range will be returned with fixed row and column
        */
-      getRangeString(range, forSheetId) {
+      getRangeString(range, forSheetId, useFixedZone = false) {
           if (!range) {
               return INCORRECT_RANGE_STRING;
           }
@@ -31292,7 +31382,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           if (prefixSheet && !sheetName) {
               return INCORRECT_RANGE_STRING;
           }
-          let rangeString = this.getRangePartString(rangeImpl, 0);
+          let rangeString = this.getRangePartString(rangeImpl, 0, useFixedZone);
           if (rangeImpl.parts && rangeImpl.parts.length === 2) {
               // this if converts A2:A2 into A2 except if any part of the original range had fixed row or column (with $)
               if (rangeImpl.zone.top !== rangeImpl.zone.bottom ||
@@ -31302,7 +31392,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
                   rangeImpl.parts[1].rowFixed ||
                   rangeImpl.parts[1].colFixed) {
                   rangeString += ":";
-                  rangeString += this.getRangePartString(rangeImpl, 1);
+                  rangeString += this.getRangePartString(rangeImpl, 1, useFixedZone);
               }
           }
           return `${prefixSheet ? sheetName + "!" : ""}${rangeString}`;
@@ -31332,14 +31422,14 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
       /**
        * Get a Xc string that represent a part of a range
        */
-      getRangePartString(range, part) {
+      getRangePartString(range, part, useFixedZone = false) {
           var _a, _b;
           const colFixed = range.parts && ((_a = range.parts[part]) === null || _a === void 0 ? void 0 : _a.colFixed) ? "$" : "";
           const col = part === 0 ? numberToLetters(range.zone.left) : numberToLetters(range.zone.right);
           const rowFixed = range.parts && ((_b = range.parts[part]) === null || _b === void 0 ? void 0 : _b.rowFixed) ? "$" : "";
           const row = part === 0 ? String(range.zone.top + 1) : String(range.zone.bottom + 1);
           let str = "";
-          if (range.isFullCol) {
+          if (range.isFullCol && !useFixedZone) {
               if (part === 0 && range.unboundedZone.hasHeader) {
                   str = colFixed + col + rowFixed + row;
               }
@@ -31347,7 +31437,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
                   str = colFixed + col;
               }
           }
-          else if (range.isFullRow) {
+          else if (range.isFullRow && !useFixedZone) {
               if (part === 0 && range.unboundedZone.hasHeader) {
                   str = colFixed + col + rowFixed + row;
               }
@@ -32722,6 +32812,10 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
                       if (cell.format !== evaluatedCell.format) {
                           exportedCellData.computedFormat = evaluatedCell.format;
                       }
+                      // if there is a formula but no dependencies (maybe because the cell is in error), no need to recompute the formula text
+                      if (cell.isFormula && cell.dependencies.length) {
+                          exportedCellData.content = this.getters.buildFormulaContent(sheet.id, cell, cell.dependencies, true);
+                      }
                   }
               }
           }
@@ -34582,8 +34676,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           let row = zone.bottom;
           if (col > 0) {
               let leftPosition = { sheetId, col: col - 1, row };
-              while (this.getters.getEvaluatedCell(leftPosition).type !== CellValueType.empty ||
-                  ((_a = this.getters.getCell(leftPosition)) === null || _a === void 0 ? void 0 : _a.content)) {
+              while ((_a = this.getters.getCell(leftPosition)) === null || _a === void 0 ? void 0 : _a.content) {
                   row += 1;
                   leftPosition = { sheetId, col: col - 1, row };
               }
@@ -34592,8 +34685,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
               col = zone.right;
               if (col <= this.getters.getNumberCols(sheetId)) {
                   let rightPosition = { sheetId, col: col + 1, row };
-                  while (this.getters.getEvaluatedCell(rightPosition).type !== CellValueType.empty ||
-                      ((_b = this.getters.getCell(rightPosition)) === null || _b === void 0 ? void 0 : _b.content)) {
+                  while ((_b = this.getters.getCell(rightPosition)) === null || _b === void 0 ? void 0 : _b.content) {
                       row += 1;
                       rightPosition = { sheetId, col: col + 1, row };
                   }
@@ -36285,9 +36377,6 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
               }
           }
       }
-      unsubscribe() {
-          this.unfocus();
-      }
       // ---------------------------------------------------------------------------
       // Getters || only callable by the parent
       // ---------------------------------------------------------------------------
@@ -36494,9 +36583,9 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
                   break;
               case "FOCUS_RANGE":
               case "CHANGE_RANGE":
-                  if (cmd.id !== this.focusedInputId) {
-                      const input = this.inputs[cmd.id];
-                      const range = input.ranges.find((range) => range.id === cmd.rangeId);
+                  const input = this.inputs[cmd.id];
+                  const range = input.ranges.find((range) => range.id === cmd.rangeId);
+                  if (range) {
                       const sheetId = this.getters.getActiveSheetId();
                       const zone = this.getters.getRangeFromSheetXC(sheetId, (range === null || range === void 0 ? void 0 : range.xc) || "A1").zone;
                       this.selection.capture(input, { cell: { col: zone.left, row: zone.top }, zone }, { handleEvent: input.handleEvent.bind(input) });
@@ -36506,9 +36595,6 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           }
           (_a = this.currentInput) === null || _a === void 0 ? void 0 : _a.handle(cmd);
       }
-      unsubscribe() {
-          this.unfocus();
-      }
       // ---------------------------------------------------------------------------
       // Getters
       // ---------------------------------------------------------------------------
@@ -39579,6 +39665,19 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
       }
   }
 
+  class FocusableElement {
+      constructor() {
+          this.focusableElement = undefined;
+      }
+      setFocusableElement(element) {
+          this.focusableElement = element;
+      }
+      focus() {
+          var _a;
+          (_a = this.focusableElement) === null || _a === void 0 ? void 0 : _a.focus();
+      }
+  }
+
   // -----------------------------------------------------------------------------
   // SpreadSheet
   // -----------------------------------------------------------------------------
@@ -40822,8 +40921,8 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
       &.corner {
         right: 0px;
         bottom: 0px;
-        height: ${SCROLLBAR_WIDTH$1}px;
-        width: ${SCROLLBAR_WIDTH$1}px;
+        height: ${SCROLLBAR_WIDTH}px;
+        width: ${SCROLLBAR_WIDTH}px;
         border-top: 1px solid #e2e3e3;
         border-left: 1px solid #e2e3e3;
       }
@@ -40870,6 +40969,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
               toggleSidePanel: this.toggleSidePanel.bind(this),
               _t: Spreadsheet._t,
               clipboard: this.env.clipboard || instantiateClipboard(),
+              focusableElement: new FocusableElement(),
           });
           owl.useExternalListener(window, "resize", () => this.render(true));
           owl.useExternalListener(window, "beforeunload", this.unbindModelEvents.bind(this));
@@ -40968,17 +41068,18 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           this.model.dispatch("UNFOCUS_SELECTION_INPUT");
           this.composer.topBarFocus = "contentFocus";
           this.composer.gridFocusMode = "inactive";
-          this.setComposerContent({ selection } || {});
+          this.setComposerContent({ selection });
       }
-      onGridComposerContentFocused() {
+      onGridComposerContentFocused(selection) {
           if (this.model.getters.isReadonly()) {
               return;
           }
           this.model.dispatch("UNFOCUS_SELECTION_INPUT");
           this.composer.topBarFocus = "inactive";
           this.composer.gridFocusMode = "contentFocus";
-          this.setComposerContent({});
+          this.setComposerContent({ selection });
       }
+      // TODO: either both are defined or none of them. change those args to an object
       onGridComposerCellFocused(content, selection) {
           if (this.model.getters.isReadonly()) {
               return;
@@ -41959,18 +42060,17 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           if (this.observers.find((sub) => sub.owner === owner)) {
               throw new Error("You are already subscribed forever");
           }
-          if ((_a = this.mainSubscription) === null || _a === void 0 ? void 0 : _a.owner) {
+          if (((_a = this.mainSubscription) === null || _a === void 0 ? void 0 : _a.owner) && this.mainSubscription.owner !== owner) {
               (_c = (_b = this.mainSubscription.callbacks).release) === null || _c === void 0 ? void 0 : _c.call(_b);
           }
           this.mainSubscription = { owner, callbacks };
       }
       release(owner) {
-          var _a, _b, _c, _d;
+          var _a;
           if (((_a = this.mainSubscription) === null || _a === void 0 ? void 0 : _a.owner) !== owner ||
               this.observers.find((sub) => sub.owner === owner)) {
               return;
           }
-          (_d = (_b = this.mainSubscription) === null || _b === void 0 ? void 0 : (_c = _b.callbacks).release) === null || _d === void 0 ? void 0 : _d.call(_c);
           this.mainSubscription = this.defaultSubscription;
       }
       /**
@@ -42438,11 +42538,10 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
        * next cluster if the given cell is outside a cluster or at the border of a cluster in the given direction.
        */
       getEndOfCluster(startPosition, dim, dir) {
-          const sheet = this.getters.getActiveSheet();
           let currentPosition = startPosition;
           // If both the current cell and the next cell are not empty, we want to go to the end of the cluster
           const nextCellPosition = this.getNextCellPosition(startPosition, dim, dir);
-          let mode = !this.isCellEmpty(currentPosition, sheet.id) && !this.isCellEmpty(nextCellPosition, sheet.id)
+          let mode = !this.isEvaluatedCellEmpty(currentPosition) && !this.isEvaluatedCellEmpty(nextCellPosition)
               ? "endOfCluster"
               : "nextCluster";
           while (true) {
@@ -42452,7 +42551,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
                   currentPosition.row === nextCellPosition.row) {
                   break;
               }
-              const isNextCellEmpty = this.isCellEmpty(nextCellPosition, sheet.id);
+              const isNextCellEmpty = this.isEvaluatedCellEmpty(nextCellPosition);
               if (mode === "endOfCluster" && isNextCellEmpty) {
                   break;
               }
@@ -42466,14 +42565,25 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           return dim === "cols" ? currentPosition.col : currentPosition.row;
       }
       /**
-       * Check if a cell is empty or undefined in the model. If the cell is part of a merge,
-       * check if the merge containing the cell is empty.
+       * Check if a cell evaluated value is empty. If the cell is part of a merge,
+       * the check applies to the main cell of the merge.
        */
-      isCellEmpty({ col, row }, sheetId = this.getters.getActiveSheetId()) {
+      isEvaluatedCellEmpty({ col, row }) {
+          const sheetId = this.getters.getActiveSheetId();
           const position = this.getters.getMainCellPosition({ sheetId, col, row });
           const cell = this.getters.getEvaluatedCell(position);
           return cell.type === CellValueType.empty;
       }
+      /**
+       * Checks if a cell is empty (i.e. does not have a content). If the cell is part of a merge,
+       * the check applies to the main cell of the merge.
+       */
+      isCellEmpty({ col, row }) {
+          var _a;
+          const sheetId = this.getters.getActiveSheetId();
+          const position = this.getters.getMainCellPosition({ sheetId, col, row });
+          return !((_a = this.getters.getCell(position)) === null || _a === void 0 ? void 0 : _a.content);
+      }
       /** Computes the next cell position in the given direction by crossing through merges and skipping hidden cells.
        *
        * This has the same behaviour as getNextAvailablePosition() for certain arguments, but use this method instead
@@ -42952,12 +43062,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
               attrs.push(["t", "str"]);
               cycle = escapeXml /*xml*/ `<v>${cell.value}</v>`;
           }
-          node = escapeXml /*xml*/ `
-      <f>
-        ${XlsxFormula}
-      </f>
-      ${cycle}
-    `;
+          node = escapeXml /*xml*/ `<f> ${XlsxFormula} </f> ${cycle}`;
           return { attrs, node };
       }
       else {
@@ -43698,11 +43803,10 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
                       ({ attrs: additionalAttrs, node: cellNode } = addContent(cell.content, construct.sharedStrings, isTableHeader));
                   }
                   attributes.push(...additionalAttrs);
-                  cellNodes.push(escapeXml /*xml*/ `
-          <c ${formatAttributes(attributes)}>
-            ${cellNode}
-          </c>
-        `);
+                  // prettier-ignore
+                  cellNodes.push(escapeXml /*xml*/ `<c ${formatAttributes(attributes)}>
+  ${cellNode}
+</c>`);
               }
           }
           if (cellNodes.length || row.size !== DEFAULT_CELL_HEIGHT || row.isHidden) {
@@ -44459,7 +44563,7 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
       BOTTOMBAR_HEIGHT,
       DEFAULT_CELL_WIDTH,
       DEFAULT_CELL_HEIGHT,
-      SCROLLBAR_WIDTH: SCROLLBAR_WIDTH$1,
+      SCROLLBAR_WIDTH,
   };
   const registries = {
       autofillModifiersRegistry,
@@ -44576,9 +44680,9 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
   Object.defineProperty(exports, '__esModule', { value: true });
 
 
-  __info__.version = '16.1.33';
-  __info__.date = '2024-01-29T13:49:43.259Z';
-  __info__.hash = 'd3b27dd';
+  __info__.version = '16.1.37';
+  __info__.date = '2024-02-28T12:25:26.784Z';
+  __info__.hash = '499b3b2';
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);