@odoo/o-spreadsheet 16.0.6 → 16.0.8

package/dist/o-spreadsheet.cjs.js

@@ -1027,6 +1027,10 @@ function deepEquals(o1, o2) {
     }
     return true;
 }
+/** Check if the given array contains all the values of the other array. */
+function includesAll(arr, values) {
+    return values.every((value) => arr.includes(value));
+}
 /**
  * Return an object with all the keys in the object that have a falsy value removed.
  */
@@ -1572,12 +1576,77 @@ const numberRepresentation = [];
  * - all digit stored in the decimal part of the number
  *
  * The 'maxDecimal' parameter allows to indicate the number of digits to not
- * exceed in the decimal part, in which case digits are rounded
+ * exceed in the decimal part, in which case digits are rounded.
  *
- * Intl.Numberformat is used to properly handle all the roundings.
- * e.g. 1234.7  with format ### (<> maxDecimals=0) should become 1235, not 1234
  **/
 function splitNumber(value, maxDecimals = MAX_DECIMAL_PLACES) {
+    const asString = value.toString();
+    if (asString.includes("e"))
+        return splitNumberIntl(value, maxDecimals);
+    if (Number.isInteger(value)) {
+        return { integerDigits: asString, decimalDigits: undefined };
+    }
+    const indexOfDot = asString.indexOf(".");
+    let integerDigits = asString.substring(0, indexOfDot);
+    let decimalDigits = asString.substring(indexOfDot + 1);
+    if (maxDecimals === 0) {
+        if (Number(decimalDigits[0]) >= 5) {
+            integerDigits = (Number(integerDigits) + 1).toString();
+        }
+        return { integerDigits, decimalDigits: undefined };
+    }
+    if (decimalDigits.length > maxDecimals) {
+        const { integerDigits: roundedIntegerDigits, decimalDigits: roundedDecimalDigits } = limitDecimalDigits(decimalDigits, maxDecimals);
+        decimalDigits = roundedDecimalDigits;
+        if (roundedIntegerDigits !== "0") {
+            integerDigits = (Number(integerDigits) + Number(roundedIntegerDigits)).toString();
+        }
+    }
+    return { integerDigits, decimalDigits: removeTrailingZeroes(decimalDigits || "") };
+}
+/**
+ *  Return the given string minus the trailing "0" characters.
+ *
+ * @param numberString : a string of integers
+ * @returns the numberString, minus the eventual zeroes at the end
+ */
+function removeTrailingZeroes(numberString) {
+    let i = numberString.length - 1;
+    while (i >= 0 && numberString[i] === "0") {
+        i--;
+    }
+    return numberString.slice(0, i + 1) || undefined;
+}
+/**
+ * Limit the size of the decimal part of a number to the given number of digits.
+ */
+function limitDecimalDigits(decimalDigits, maxDecimals) {
+    let integerDigits = "0";
+    let resultDecimalDigits = decimalDigits;
+    // Note : we'd want to simply use number.toFixed() to handle the max digits & rounding,
+    // but it has very strange behaviour. Ex: 12.345.toFixed(2) => "12.35", but 1.345.toFixed(2) => "1.34"
+    let slicedDecimalDigits = decimalDigits.slice(0, maxDecimals);
+    const i = maxDecimals;
+    if (Number(Number(decimalDigits[i]) < 5)) {
+        return { integerDigits, decimalDigits: slicedDecimalDigits };
+    }
+    // round up
+    const slicedRoundedUp = (Number(slicedDecimalDigits) + 1).toString();
+    if (slicedRoundedUp.length > slicedDecimalDigits.length) {
+        integerDigits = (Number(integerDigits) + 1).toString();
+        resultDecimalDigits = undefined;
+    }
+    else {
+        resultDecimalDigits = slicedRoundedUp;
+    }
+    return { integerDigits, decimalDigits: resultDecimalDigits };
+}
+/**
+ * Split numbers into decimal/integer digits using Intl.NumberFormat.
+ * Supports numbers with a lot of digits that are transformed to scientific notation by
+ * number.toString(), but is slow.
+ */
+function splitNumberIntl(value, maxDecimals = MAX_DECIMAL_PLACES) {
     let formatter = numberRepresentation[maxDecimals];
     if (!formatter) {
         formatter = new Intl.NumberFormat("en-US", {
@@ -3974,13 +4043,16 @@ class Menu extends owl.Component {
             }
         });
     }
+    get visibleMenuItems() {
+        return this.props.menuItems.filter((x) => x.isVisible(this.env));
+    }
     get subMenuPosition() {
         const position = Object.assign({}, this.subMenu.position);
         position.y -= this.subMenu.scrollOffset || 0;
         return position;
     }
     get menuHeight() {
-        return this.menuComponentHeight(this.props.menuItems);
+        return this.menuComponentHeight(this.visibleMenuItems);
     }
     get subMenuHeight() {
         return this.menuComponentHeight(this.subMenu.menuItems);
@@ -4016,7 +4088,7 @@ class Menu extends owl.Component {
      * and the menu item at a given index.
      */
     subMenuVerticalPosition(position) {
-        const menusAbove = this.props.menuItems.slice(0, position);
+        const menusAbove = this.visibleMenuItems.slice(0, position);
         return this.menuComponentHeight(menusAbove) + this.position.y;
     }
     onExternalClick(ev) {
@@ -5549,6 +5621,11 @@ colMenuRegistry
     name: REMOVE_COLUMNS_NAME,
     sequence: 90,
     action: REMOVE_COLUMNS_ACTION,
+    isVisible: (env) => {
+        const sheetId = env.model.getters.getActiveSheetId();
+        const selectedCols = env.model.getters.getElementsFromSelection("COL");
+        return env.model.getters.canRemoveHeaders(sheetId, "COL", selectedCols);
+    },
 })
     .add("clear_column", {
     name: DELETE_CONTENT_COLUMNS_NAME,
@@ -5561,9 +5638,8 @@ colMenuRegistry
     action: HIDE_COLUMNS_ACTION,
     isVisible: (env) => {
         const sheetId = env.model.getters.getActiveSheetId();
-        const hiddenCols = env.model.getters.getHiddenColsGroups(sheetId).flat();
-        return (env.model.getters.getNumberCols(sheetId) >
-            hiddenCols.length + env.model.getters.getElementsFromSelection("COL").length);
+        const selectedCols = env.model.getters.getElementsFromSelection("COL");
+        return env.model.getters.canRemoveHeaders(sheetId, "COL", selectedCols);
     },
     separator: true,
 })
@@ -5637,6 +5713,11 @@ rowMenuRegistry
     name: REMOVE_ROWS_NAME,
     sequence: 70,
     action: REMOVE_ROWS_ACTION,
+    isVisible: (env) => {
+        const sheetId = env.model.getters.getActiveSheetId();
+        const selectedRows = env.model.getters.getElementsFromSelection("ROW");
+        return env.model.getters.canRemoveHeaders(sheetId, "ROW", selectedRows);
+    },
 })
     .add("clear_row", {
     name: DELETE_CONTENT_ROWS_NAME,
@@ -5649,9 +5730,8 @@ rowMenuRegistry
     action: HIDE_ROWS_ACTION,
     isVisible: (env) => {
         const sheetId = env.model.getters.getActiveSheetId();
-        const hiddenRows = env.model.getters.getHiddenRowsGroups(sheetId).flat();
-        return (env.model.getters.getNumberRows(sheetId) >
-            hiddenRows.length + env.model.getters.getElementsFromSelection("ROW").length);
+        const selectedRows = env.model.getters.getElementsFromSelection("ROW");
+        return env.model.getters.canRemoveHeaders(sheetId, "ROW", selectedRows);
     },
     separator: true,
 })
@@ -10313,7 +10393,7 @@ class ChartFigure extends owl.Component {
     openContextMenu(position) {
         const registry = this.getMenuItemRegistry();
         this.menuState.isOpen = true;
-        this.menuState.menuItems = registry.getAll().filter((x) => x.isVisible(this.env));
+        this.menuState.menuItems = registry.getAll();
         this.menuState.position = position;
     }
     get chartComponent() {
@@ -19833,14 +19913,31 @@ class ContentEditableHelper {
      * */
     getCurrentSelection() {
         let { startElement, endElement, startSelectionOffset, endSelectionOffset } = this.getStartAndEndSelection();
-        let startSizeBefore = this.findSizeBeforeElement(startElement);
-        let endSizeBefore = this.findSizeBeforeElement(endElement);
+        let startSizeBefore = this.findSelectionIndex(startElement, startSelectionOffset);
+        let endSizeBefore = this.findSelectionIndex(endElement, endSelectionOffset);
         return {
-            start: startSizeBefore + startSelectionOffset,
-            end: endSizeBefore + endSelectionOffset,
+            start: startSizeBefore,
+            end: endSizeBefore,
         };
     }
-    findSizeBeforeElement(nodeToFind) {
+    /**
+     * Computes the text 'index' inside this.el based on the currently selected node and its offset.
+     * The selected node is either a Text node or an Element node.
+     *
+     * case 1 -Text node:
+     * the offset is the number of characters from the start of the node. We have to add this offset to the
+     * content length of all previous nodes.
+     *
+     * case 2 - Element node:
+     * the offset is the number of child nodes before the selected node. We have to add the content length of
+     * all the bnodes prior to the selected node as well as the content of the child node before the offset.
+     *
+     * See the MDN documentation for more details.
+     * https://developer.mozilla.org/en-US/docs/Web/API/Range/startOffset
+     * https://developer.mozilla.org/en-US/docs/Web/API/Range/endOffset
+     *
+     */
+    findSelectionIndex(nodeToFind, nodeOffset) {
         let it = this.iterateChildren(this.el);
         let usedCharacters = 0;
         let current = it.next();
@@ -19852,6 +19949,19 @@ class ContentEditableHelper {
             }
             current = it.next();
         }
+        if (current.value === nodeToFind) {
+            if (!current.value.hasChildNodes()) {
+                usedCharacters += nodeOffset;
+            }
+            else {
+                const children = [...current.value.childNodes].slice(0, nodeOffset);
+                for (const child of children) {
+                    if (!child.textContent)
+                        continue;
+                    usedCharacters += child.textContent.length;
+                }
+            }
+        }
         return usedCharacters;
     }
     getStartAndEndSelection() {
@@ -22337,8 +22447,8 @@ class Grid extends owl.Component {
             },
             "CTRL+END": () => {
                 const sheetId = this.env.model.getters.getActiveSheetId();
-                const col = this.env.model.getters.findVisibleHeader(sheetId, "COL", range(0, this.env.model.getters.getNumberCols(sheetId)).reverse());
-                const row = this.env.model.getters.findVisibleHeader(sheetId, "ROW", range(0, this.env.model.getters.getNumberRows(sheetId)).reverse());
+                const col = this.env.model.getters.findVisibleHeader(sheetId, "COL", this.env.model.getters.getNumberCols(sheetId) - 1, 0);
+                const row = this.env.model.getters.findVisibleHeader(sheetId, "ROW", this.env.model.getters.getNumberRows(sheetId) - 1, 0);
                 this.env.model.selection.selectCell(col, row);
             },
             "SHIFT+ ": () => {
@@ -22414,9 +22524,10 @@ class Grid extends owl.Component {
         this.focus();
     }
     focus() {
+        var _a;
         if (!this.env.model.getters.getSelectedFigureId() &&
             this.env.model.getters.getEditionMode() === "inactive") {
-            this.hiddenInput.el.focus();
+            (_a = this.hiddenInput.el) === null || _a === void 0 ? void 0 : _a.focus();
         }
     }
     get gridEl() {
@@ -22620,9 +22731,7 @@ class Grid extends owl.Component {
         this.closeOpenedPopover();
         this.menuState.isOpen = true;
         this.menuState.position = { x, y };
-        this.menuState.menuItems = registries$1[type]
-            .getAll()
-            .filter((item) => !item.isVisible || item.isVisible(this.env));
+        this.menuState.menuItems = registries$1[type].getAll();
     }
     copy(cut, ev) {
         if (!this.gridEl.contains(document.activeElement)) {
@@ -26360,7 +26469,7 @@ function load(data, verboseImport) {
             }
         }
     }
-    data = JSON.parse(JSON.stringify(data));
+    data = deepCopy(data);
     // apply migrations, if needed
     if ("version" in data) {
         if (data.version < CURRENT_VERSION) {
@@ -28945,7 +29054,7 @@ class HeaderVisibilityPlugin extends CorePlugin {
     allowDispatch(cmd) {
         switch (cmd.type) {
             case "HIDE_COLUMNS_ROWS": {
-                if (!this.hiddenHeaders[cmd.sheetId]) {
+                if (!this.getters.tryGetSheet(cmd.sheetId)) {
                     return 27 /* CommandResult.InvalidSheetId */;
                 }
                 const hiddenGroup = cmd.dimension === "COL"
@@ -28958,6 +29067,14 @@ class HeaderVisibilityPlugin extends CorePlugin {
                     ? 0 /* CommandResult.Success */
                     : 65 /* CommandResult.TooManyHiddenElements */;
             }
+            case "REMOVE_COLUMNS_ROWS":
+                if (!this.getters.tryGetSheet(cmd.sheetId)) {
+                    return 27 /* CommandResult.InvalidSheetId */;
+                }
+                if (!this.canRemoveHeaders(cmd.sheetId, cmd.dimension, cmd.elements)) {
+                    return 8 /* CommandResult.NotEnoughElements */;
+                }
+                return 0 /* CommandResult.Success */;
         }
         return 0 /* CommandResult.Success */;
     }
@@ -29004,6 +29121,10 @@ class HeaderVisibilityPlugin extends CorePlugin {
         }
         return;
     }
+    canRemoveHeaders(sheetId, dimension, elements) {
+        const visibleHeaders = this.getAllVisibleHeaders(sheetId, dimension);
+        return !includesAll(elements, visibleHeaders);
+    }
     isRowHiddenByUser(sheetId, index) {
         return this.hiddenHeaders[sheetId].ROW[index];
     }
@@ -29048,6 +29169,9 @@ class HeaderVisibilityPlugin extends CorePlugin {
         }
         return consecutiveIndexes;
     }
+    getAllVisibleHeaders(sheetId, dimension) {
+        return range(0, this.hiddenHeaders[sheetId][dimension].length).filter((i) => !this.hiddenHeaders[sheetId][dimension][i]);
+    }
     import(data) {
         var _a, _b;
         for (let sheet of data.sheets) {
@@ -29095,6 +29219,7 @@ class HeaderVisibilityPlugin extends CorePlugin {
     }
 }
 HeaderVisibilityPlugin.getters = [
+    "canRemoveHeaders",
     "getHiddenColsGroups",
     "getHiddenRowsGroups",
     "isRowHiddenByUser",
@@ -29595,14 +29720,6 @@ class SheetPlugin extends CorePlugin {
                 return this.orderedSheetIds.length > 1
                     ? 0 /* CommandResult.Success */
                     : 9 /* CommandResult.NotEnoughSheets */;
-            case "REMOVE_COLUMNS_ROWS": {
-                const length = cmd.dimension === "COL"
-                    ? this.getNumberCols(cmd.sheetId)
-                    : this.getNumberRows(cmd.sheetId);
-                return length > cmd.elements.length
-                    ? 0 /* CommandResult.Success */
-                    : 8 /* CommandResult.NotEnoughElements */;
-            }
             case "FREEZE_ROWS": {
                 return this.checkValidations(cmd, this.checkRowFreezeQuantity, this.checkRowFreezeOverlapMerge);
             }
@@ -30086,7 +30203,7 @@ class SheetPlugin extends CorePlugin {
     duplicateSheet(fromId, toId) {
         const sheet = this.getSheet(fromId);
         const toName = this.getDuplicateSheetName(sheet.name);
-        const newSheet = JSON.parse(JSON.stringify(sheet));
+        const newSheet = deepCopy(sheet);
         newSheet.id = toId;
         newSheet.name = toName;
         for (let col = 0; col <= newSheet.numberOfCols; col++) {
@@ -30213,10 +30330,10 @@ class SheetPlugin extends CorePlugin {
         }
     }
     moveCellOnColumnsDeletion(sheet, deletedColumn) {
-        for (let [index, row] of Object.entries(sheet.rows)) {
-            const rowIndex = parseInt(index, 10);
+        for (let rowIndex = 0; rowIndex < sheet.rows.length; rowIndex++) {
+            const row = sheet.rows[rowIndex];
             for (let i in row.cells) {
-                const colIndex = parseInt(i, 10);
+                const colIndex = Number(i);
                 const cellId = row.cells[i];
                 if (cellId) {
                     if (colIndex === deletedColumn) {
@@ -30243,11 +30360,11 @@ class SheetPlugin extends CorePlugin {
      */
     moveCellsOnAddition(sheet, addedElement, quantity, dimension) {
         const commands = [];
-        for (const [index, row] of Object.entries(sheet.rows)) {
-            const rowIndex = parseInt(index, 10);
+        for (let rowIndex = 0; rowIndex < sheet.rows.length; rowIndex++) {
+            const row = sheet.rows[rowIndex];
             if (dimension !== "rows" || rowIndex >= addedElement) {
                 for (let i in row.cells) {
-                    const colIndex = parseInt(i, 10);
+                    const colIndex = Number(i);
                     const cellId = row.cells[i];
                     if (cellId) {
                         if (dimension === "rows" || colIndex >= addedElement) {
@@ -30277,11 +30394,11 @@ class SheetPlugin extends CorePlugin {
      */
     moveCellOnRowsDeletion(sheet, deleteFromRow, deleteToRow) {
         const numberRows = deleteToRow - deleteFromRow + 1;
-        for (let [index, row] of Object.entries(sheet.rows)) {
-            const rowIndex = parseInt(index, 10);
+        for (let rowIndex = 0; rowIndex < sheet.rows.length; rowIndex++) {
+            const row = sheet.rows[rowIndex];
             if (rowIndex >= deleteFromRow && rowIndex <= deleteToRow) {
                 for (let i in row.cells) {
-                    const colIndex = parseInt(i, 10);
+                    const colIndex = Number(i);
                     const cellId = row.cells[i];
                     if (cellId) {
                         this.dispatch("CLEAR_CELL", {
@@ -30294,7 +30411,7 @@ class SheetPlugin extends CorePlugin {
             }
             if (rowIndex > deleteToRow) {
                 for (let i in row.cells) {
-                    const colIndex = parseInt(i, 10);
+                    const colIndex = Number(i);
                     const cellId = row.cells[i];
                     if (cellId) {
                         this.dispatch("UPDATE_CELL_POSITION", {
@@ -30312,7 +30429,7 @@ class SheetPlugin extends CorePlugin {
         const rows = [];
         const cellsQueue = sheet.rows.map((row) => row.cells);
         for (let i in sheet.rows) {
-            if (parseInt(i, 10) === index) {
+            if (Number(i) === index) {
                 continue;
             }
             rows.push({
@@ -32948,13 +33065,11 @@ class FilterEvaluationPlugin extends UIPlugin {
         return Boolean(id && ((_b = (_a = this.filterValues[sheetId]) === null || _a === void 0 ? void 0 : _a[id]) === null || _b === void 0 ? void 0 : _b.length));
     }
     intersectZoneWithViewport(sheetId, zone) {
-        const colsRange = range(zone.left, zone.right + 1);
-        const rowsRange = range(zone.top, zone.bottom + 1);
         return {
-            left: this.getters.findVisibleHeader(sheetId, "COL", colsRange),
-            right: this.getters.findVisibleHeader(sheetId, "COL", colsRange.reverse()),
-            top: this.getters.findVisibleHeader(sheetId, "ROW", rowsRange),
-            bottom: this.getters.findVisibleHeader(sheetId, "ROW", rowsRange.reverse()),
+            left: this.getters.findVisibleHeader(sheetId, "COL", zone.left, zone.right),
+            right: this.getters.findVisibleHeader(sheetId, "COL", zone.right, zone.left),
+            top: this.getters.findVisibleHeader(sheetId, "ROW", zone.top, zone.bottom),
+            bottom: this.getters.findVisibleHeader(sheetId, "ROW", zone.bottom, zone.top),
         };
     }
     updateFilter({ col, row, values, sheetId }) {
@@ -33396,13 +33511,33 @@ class HeaderVisibilityUIPlugin extends UIPlugin {
     }
     getNextVisibleCellPosition(sheetId, col, row) {
         return {
-            col: this.findVisibleHeader(sheetId, "COL", range(col, this.getters.getNumberCols(sheetId))),
-            row: this.findVisibleHeader(sheetId, "ROW", range(row, this.getters.getNumberRows(sheetId))),
+            col: this.findVisibleHeader(sheetId, "COL", col, this.getters.getNumberCols(sheetId) - 1),
+            row: this.findVisibleHeader(sheetId, "ROW", row, this.getters.getNumberRows(sheetId) - 1),
         };
     }
-    findVisibleHeader(sheetId, dimension, indexes) {
-        return indexes.find((index) => this.getters.doesHeaderExist(sheetId, dimension, index) &&
-            !this.isHeaderHidden(sheetId, dimension, index));
+    /**
+     * Find the first visible header in the range [`from` => `to`].
+     *
+     * Both `from` and `to` are inclusive.
+     */
+    findVisibleHeader(sheetId, dimension, from, to) {
+        if (from <= to) {
+            for (let i = from; i <= to; i++) {
+                if (this.getters.doesHeaderExist(sheetId, dimension, i) &&
+                    !this.isHeaderHidden(sheetId, dimension, i)) {
+                    return i;
+                }
+            }
+        }
+        if (from > to) {
+            for (let i = from; i >= to; i--) {
+                if (this.getters.doesHeaderExist(sheetId, dimension, i) &&
+                    !this.isHeaderHidden(sheetId, dimension, i)) {
+                    return i;
+                }
+            }
+        }
+        return undefined;
     }
     findLastVisibleColRowIndex(sheetId, dimension, indexes) {
         let lastIndex;
@@ -33415,7 +33550,7 @@ class HeaderVisibilityUIPlugin extends UIPlugin {
     }
     findFirstVisibleColRowIndex(sheetId, dimension) {
         const numberOfHeaders = this.getters.getNumberHeaders(sheetId, dimension);
-        for (let i = 0; i < numberOfHeaders - 1; i++) {
+        for (let i = 0; i < numberOfHeaders; i++) {
             if (dimension === "COL" && !this.isColHidden(sheetId, i)) {
                 return i;
             }
@@ -35989,48 +36124,66 @@ class InternalViewport {
             this.adjustPositionY(row);
         }
     }
-    adjustPositionX(col) {
+    adjustPositionX(targetCol) {
         const sheetId = this.sheetId;
-        const { start, end } = this.getters.getColDimensions(sheetId, col);
-        while (end > this.offsetX + this.offsetCorrectionX + this.viewportWidth &&
-            this.offsetX + this.offsetCorrectionX < start) {
-            this.offsetX = this.getters.getColDimensions(sheetId, this.left).end - this.offsetCorrectionX;
-            this.offsetScrollbarX = this.offsetX;
-            this.adjustViewportZoneX();
-        }
-        while (col < this.left) {
-            let leftCol;
-            for (leftCol = this.left; leftCol >= 0; leftCol--) {
-                if (!this.getters.isColHidden(sheetId, leftCol)) {
+        const { end } = this.getters.getColDimensions(sheetId, targetCol);
+        const maxCol = this.getters.getNumberCols(sheetId);
+        if (this.offsetX + this.offsetCorrectionX + this.viewportWidth < end) {
+            for (let col = this.left; this.offsetX + this.offsetCorrectionX + this.viewportWidth < end; col++) {
+                if (col > maxCol) {
+                    break;
+                }
+                if (this.getters.isColHidden(sheetId, col)) {
+                    continue;
+                }
+                this.offsetX = this.getters.getColDimensions(sheetId, col).end - this.offsetCorrectionX;
+                this.offsetScrollbarX = this.offsetX;
+                this.adjustViewportZoneX();
+            }
+        }
+        else if (this.left > targetCol) {
+            for (let col = this.left; col >= targetCol; col--) {
+                if (col < 0) {
                     break;
                 }
+                if (this.getters.isColHidden(sheetId, col)) {
+                    continue;
+                }
+                this.offsetX = this.getters.getColDimensions(sheetId, col).start - this.offsetCorrectionX;
+                this.offsetScrollbarX = this.offsetX;
+                this.adjustViewportZoneX();
             }
-            this.offsetX =
-                this.getters.getColDimensions(sheetId, leftCol - 1).start - this.offsetCorrectionX;
-            this.offsetScrollbarX = this.offsetX;
-            this.adjustViewportZoneX();
         }
     }
-    adjustPositionY(row) {
+    adjustPositionY(targetRow) {
         const sheetId = this.sheetId;
-        while (this.getters.getRowDimensions(sheetId, row).end >
-            this.offsetY + this.viewportHeight + this.offsetCorrectionY &&
-            this.offsetY + this.offsetCorrectionY < this.getters.getRowDimensions(sheetId, row).start) {
-            this.offsetY = this.getters.getRowDimensions(sheetId, this.top).end - this.offsetCorrectionY;
-            this.offsetScrollbarY = this.offsetY;
-            this.adjustViewportZoneY();
-        }
-        while (row < this.top) {
-            let topRow;
-            for (topRow = this.top; topRow >= 0; topRow--) {
-                if (!this.getters.isRowHidden(sheetId, topRow)) {
+        const { end } = this.getters.getRowDimensions(sheetId, targetRow);
+        const maxRow = this.getters.getNumberRows(sheetId);
+        if (this.offsetY + this.viewportHeight + this.offsetCorrectionY < end) {
+            for (let row = this.top; this.offsetY + this.viewportHeight + this.offsetCorrectionY < end; row++) {
+                if (row > maxRow) {
+                    break;
+                }
+                if (this.getters.isRowHidden(sheetId, row)) {
+                    continue;
+                }
+                this.offsetY = this.getters.getRowDimensions(sheetId, row).end - this.offsetCorrectionY;
+                this.offsetScrollbarY = this.offsetY;
+                this.adjustViewportZoneY();
+            }
+        }
+        else if (this.top > targetRow) {
+            for (let row = this.top; row >= targetRow; row--) {
+                if (row < 0) {
                     break;
                 }
+                if (this.getters.isRowHidden(sheetId, row)) {
+                    continue;
+                }
+                this.offsetY = this.getters.getRowDimensions(sheetId, row).start - this.offsetCorrectionY;
+                this.offsetScrollbarY = this.offsetY;
+                this.adjustViewportZoneY();
             }
-            this.offsetY =
-                this.getters.getRowDimensions(sheetId, topRow - 1).start - this.offsetCorrectionY;
-            this.offsetScrollbarY = this.offsetY;
-            this.adjustViewportZoneY();
         }
     }
     setViewportOffset(offsetX, offsetY) {
@@ -37524,7 +37677,7 @@ class BottomBar extends owl.Component {
     }
     openContextMenu(x, y, registry, menuId) {
         this.menuState.isOpen = true;
-        this.menuState.menuItems = registry.getAll().filter((x) => x.isVisible(this.env));
+        this.menuState.menuItems = registry.getAll();
         this.menuState.position = { x, y };
         this.menuState.menuId = menuId;
     }
@@ -38285,7 +38438,7 @@ class TopBar extends owl.Component {
         const { left, top, height } = ev.target.getBoundingClientRect();
         this.state.menuState.isOpen = true;
         this.state.menuState.position = { x: left, y: top + height };
-        this.state.menuState.menuItems = getMenuChildren(menu, this.env).filter((item) => !item.isVisible || item.isVisible(this.env));
+        this.state.menuState.menuItems = getMenuChildren(menu, this.env);
         this.state.menuState.parentMenu = menu;
         this.isSelectingMenu = true;
         this.openedEl = ev.target;
@@ -38334,9 +38487,7 @@ class TopBar extends owl.Component {
         this.style.align = this.style.align || (cell === null || cell === void 0 ? void 0 : cell.defaultAlign);
         this.fillColor = this.style.fillColor || "#ffffff";
         this.textColor = this.style.textColor || "#000000";
-        this.menus = topbarMenuRegistry
-            .getAll()
-            .filter((item) => !item.isVisible || item.isVisible(this.env));
+        this.menus = topbarMenuRegistry.getAll();
     }
     getMenuName(menu) {
         return getMenuName(menu, this.env);
@@ -40402,8 +40553,8 @@ class SelectionStreamProcessor {
         }
         const { left, right, top, bottom } = zone;
         const sheetId = this.getters.getActiveSheetId();
-        const refCol = this.getters.findVisibleHeader(sheetId, "COL", range(left, right + 1));
-        const refRow = this.getters.findVisibleHeader(sheetId, "ROW", range(top, bottom + 1));
+        const refCol = this.getters.findVisibleHeader(sheetId, "COL", left, right);
+        const refRow = this.getters.findVisibleHeader(sheetId, "ROW", top, bottom);
         if (refRow === undefined || refCol === undefined) {
             return 17 /* CommandResult.SelectionOutOfBound */;
         }
@@ -40478,10 +40629,10 @@ class SelectionStreamProcessor {
         const { col: anchorCol, row: anchorRow } = anchor.cell;
         return {
             col: this.getters.isColHidden(sheetId, anchorCol)
-                ? this.getters.findVisibleHeader(sheetId, "COL", range(left, right + 1)) || anchorCol
+                ? this.getters.findVisibleHeader(sheetId, "COL", left, right) || anchorCol
                 : anchorCol,
             row: this.getters.isRowHidden(sheetId, anchorRow)
-                ? this.getters.findVisibleHeader(sheetId, "ROW", range(top, bottom + 1)) || anchorRow
+                ? this.getters.findVisibleHeader(sheetId, "ROW", top, bottom) || anchorRow
                 : anchorRow,
         };
     }
@@ -42121,6 +42272,8 @@ class Model extends EventBus {
          * Internal status of the model. Important for command handling coordination
          */
         this.status = 0 /* Status.Ready */;
+        this.handlers = [];
+        this.coreHandlers = [];
         /**
          * The dispatch method is the only entry point to manipulate data in the model.
          * This is through this method that commands are dispatched most of the time
@@ -42193,7 +42346,7 @@ class Model extends EventBus {
             const command = { type, ...payload };
             const previousStatus = this.status;
             this.status = 2 /* Status.RunningCore */;
-            const handlers = this.isReplayingCommand ? [this.range, ...this.corePlugins] : this.handlers;
+            const handlers = this.isReplayingCommand ? this.coreHandlers : this.handlers;
             this.dispatchToHandlers(handlers, command);
             this.status = previousStatus;
             return DispatchResult.Success;
@@ -42227,6 +42380,8 @@ class Model extends EventBus {
         this.uuidGenerator.setIsFastStrategy(true);
         // Initiate stream processor
         this.selection = new SelectionStreamProcessor(this.getters);
+        this.coreHandlers.push(this.range);
+        this.handlers.push(this.range);
         // registering plugins
         for (let Plugin of corePluginRegistry.getAll()) {
             this.setupCorePlugin(Plugin, workbookData);
@@ -42236,6 +42391,7 @@ class Model extends EventBus {
             this.setupUiPlugin(Plugin);
         }
         this.uuidGenerator.setIsFastStrategy(false);
+        this.handlers.push(this.history);
         // starting plugins
         this.dispatch("START");
         // Model should be the last permanent subscriber in the list since he should render
@@ -42256,9 +42412,6 @@ class Model extends EventBus {
         // by owl, since we do not rely on reactivity
         owl.markRaw(this);
     }
-    get handlers() {
-        return [this.range, ...this.corePlugins, ...this.uiPlugins, this.history];
-    }
     joinSession() {
         this.session.join(this.config.client);
     }
@@ -42277,6 +42430,7 @@ class Model extends EventBus {
             this.getters[name] = plugin[name].bind(plugin);
         }
         this.uiPlugins.push(plugin);
+        this.handlers.push(plugin);
         const layers = Plugin.layers.map((l) => [plugin, l]);
         this.renderers.push(...layers);
         this.renderers.sort((p1, p2) => p1[1] - p2[1]);
@@ -42300,6 +42454,8 @@ class Model extends EventBus {
         }
         plugin.import(data);
         this.corePlugins.push(plugin);
+        this.coreHandlers.push(plugin);
+        this.handlers.push(plugin);
     }
     onRemoteRevisionReceived({ commands }) {
         for (let command of commands) {
@@ -42317,7 +42473,7 @@ class Model extends EventBus {
                 return;
             }
             this.isReplayingCommand = true;
-            this.dispatchToHandlers([this.range, ...this.corePlugins], command);
+            this.dispatchToHandlers(this.coreHandlers, command);
             this.isReplayingCommand = false;
         }), this.config.transportService, revisionId);
         return session;
@@ -42417,7 +42573,7 @@ class Model extends EventBus {
             }
         }
         data.revisionId = this.session.getRevisionId() || DEFAULT_REVISION_ID;
-        data = JSON.parse(JSON.stringify(data));
+        data = deepCopy(data);
         return data;
     }
     updateMode(mode) {
@@ -42444,7 +42600,7 @@ class Model extends EventBus {
                 handler.exportForExcel(data);
             }
         }
-        data = JSON.parse(JSON.stringify(data));
+        data = deepCopy(data);
         return getXLSX(data);
     }
 }
@@ -42576,6 +42732,6 @@ exports.setTranslationMethod = setTranslationMethod;
 exports.tokenize = tokenize;
 
 
-__info__.version = '16.0.6';
-__info__.date = '2023-04-13T08:30:26.954Z';
-__info__.hash = '8d60b5c';
+__info__.version = '16.0.8';
+__info__.date = '2023-04-21T07:29:33.894Z';
+__info__.hash = 'dbd7aa4';