@odoo/o-spreadsheet 16.0.32 → 16.0.34

package/dist/o-spreadsheet.cjs.js

@@ -5928,17 +5928,20 @@ rowMenuRegistry
 });
 
 function interactiveRenameSheet(env, sheetId, errorText) {
+    if (env.model.getters.isReadonly()) {
+        return;
+    }
     const placeholder = env.model.getters.getSheetName(sheetId);
     const title = _lt("Rename Sheet");
     const callback = (name) => {
         if (name === null || name === placeholder) {
             return;
         }
-        if (name === "") {
-            interactiveRenameSheet(env, sheetId, _lt("The sheet name cannot be empty."));
-        }
         const result = env.model.dispatch("RENAME_SHEET", { sheetId, name });
         if (!result.isSuccessful) {
+            if (result.reasons.includes(10 /* CommandResult.MissingSheetName */)) {
+                interactiveRenameSheet(env, sheetId, _lt("The sheet name cannot be empty."));
+            }
             if (result.reasons.includes(11 /* CommandResult.DuplicatedSheetName */)) {
                 interactiveRenameSheet(env, sheetId, _lt("A sheet with the name %s already exists. Please select another name.", name));
             }
@@ -27821,9 +27824,9 @@ class CellPlugin extends CorePlugin {
     allowDispatch(cmd) {
         switch (cmd.type) {
             case "UPDATE_CELL":
-                return this.checkCellOutOfSheet(cmd);
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
             case "CLEAR_CELL":
-                return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
             default:
                 return 0 /* CommandResult.Success */;
         }
@@ -28182,6 +28185,18 @@ class CellPlugin extends CorePlugin {
         }
         return 0 /* CommandResult.Success */;
     }
+    checkUselessUpdateCell(cmd) {
+        const cell = this.getters.getCell(cmd.sheetId, cmd.col, cmd.row);
+        const hasContent = "content" in cmd || "formula" in cmd;
+        const hasStyle = "style" in cmd;
+        const hasFormat = "format" in cmd;
+        if ((!hasContent || (cell === null || cell === void 0 ? void 0 : cell.content) === cmd.content) &&
+            (!hasStyle || deepEquals(cell === null || cell === void 0 ? void 0 : cell.style, cmd.style)) &&
+            (!hasFormat || (cell === null || cell === void 0 ? void 0 : cell.format) === cmd.format)) {
+            return 88 /* CommandResult.NoChanges */;
+        }
+        return 0 /* CommandResult.Success */;
+    }
 }
 CellPlugin.getters = [
     "zoneToXC",
@@ -43259,6 +43274,6 @@ exports.setTranslationMethod = setTranslationMethod;
 exports.tokenize = tokenize;
 
 
-__info__.version = '16.0.32';
-__info__.date = '2024-02-09T13:05:36.074Z';
-__info__.hash = '452dce2';
+__info__.version = '16.0.34';
+__info__.date = '2024-03-12T07:54:05.304Z';
+__info__.hash = 'e923ddd';

package/dist/o-spreadsheet.d.ts

@@ -3176,6 +3176,7 @@ declare class CellPlugin extends CorePlugin<CoreState> implements CoreState {
     private updateCell;
     private checkCellOutOfSheet;
     private checkUselessClearCell;
+    private checkUselessUpdateCell;
 }
 
 /**

package/dist/o-spreadsheet.esm.js

@@ -5924,17 +5924,20 @@ rowMenuRegistry
 });
 
 function interactiveRenameSheet(env, sheetId, errorText) {
+    if (env.model.getters.isReadonly()) {
+        return;
+    }
     const placeholder = env.model.getters.getSheetName(sheetId);
     const title = _lt("Rename Sheet");
     const callback = (name) => {
         if (name === null || name === placeholder) {
             return;
         }
-        if (name === "") {
-            interactiveRenameSheet(env, sheetId, _lt("The sheet name cannot be empty."));
-        }
         const result = env.model.dispatch("RENAME_SHEET", { sheetId, name });
         if (!result.isSuccessful) {
+            if (result.reasons.includes(10 /* CommandResult.MissingSheetName */)) {
+                interactiveRenameSheet(env, sheetId, _lt("The sheet name cannot be empty."));
+            }
             if (result.reasons.includes(11 /* CommandResult.DuplicatedSheetName */)) {
                 interactiveRenameSheet(env, sheetId, _lt("A sheet with the name %s already exists. Please select another name.", name));
             }
@@ -27817,9 +27820,9 @@ class CellPlugin extends CorePlugin {
     allowDispatch(cmd) {
         switch (cmd.type) {
             case "UPDATE_CELL":
-                return this.checkCellOutOfSheet(cmd);
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
             case "CLEAR_CELL":
-                return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
             default:
                 return 0 /* CommandResult.Success */;
         }
@@ -28178,6 +28181,18 @@ class CellPlugin extends CorePlugin {
         }
         return 0 /* CommandResult.Success */;
     }
+    checkUselessUpdateCell(cmd) {
+        const cell = this.getters.getCell(cmd.sheetId, cmd.col, cmd.row);
+        const hasContent = "content" in cmd || "formula" in cmd;
+        const hasStyle = "style" in cmd;
+        const hasFormat = "format" in cmd;
+        if ((!hasContent || (cell === null || cell === void 0 ? void 0 : cell.content) === cmd.content) &&
+            (!hasStyle || deepEquals(cell === null || cell === void 0 ? void 0 : cell.style, cmd.style)) &&
+            (!hasFormat || (cell === null || cell === void 0 ? void 0 : cell.format) === cmd.format)) {
+            return 88 /* CommandResult.NoChanges */;
+        }
+        return 0 /* CommandResult.Success */;
+    }
 }
 CellPlugin.getters = [
     "zoneToXC",
@@ -43227,6 +43242,6 @@ function addFunction(functionName, functionDescription) {
 export { AbstractChart, CommandResult, CorePlugin, DATETIME_FORMAT, DispatchResult, EvaluationError, Model, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, UIPlugin, __info__, addFunction, astToFormula, cellTypes, compile, components, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, invalidateEvaluationCommands, load, parse, readonlyAllowedCommands, registries, setTranslationMethod, tokenize };
 
 
-__info__.version = '16.0.32';
-__info__.date = '2024-02-09T13:05:36.074Z';
-__info__.hash = '452dce2';
+__info__.version = '16.0.34';
+__info__.date = '2024-03-12T07:54:05.304Z';
+__info__.hash = 'e923ddd';

package/dist/o-spreadsheet.iife.js

@@ -5925,17 +5925,20 @@
   });
 
   function interactiveRenameSheet(env, sheetId, errorText) {
+      if (env.model.getters.isReadonly()) {
+          return;
+      }
       const placeholder = env.model.getters.getSheetName(sheetId);
       const title = _lt("Rename Sheet");
       const callback = (name) => {
           if (name === null || name === placeholder) {
               return;
           }
-          if (name === "") {
-              interactiveRenameSheet(env, sheetId, _lt("The sheet name cannot be empty."));
-          }
           const result = env.model.dispatch("RENAME_SHEET", { sheetId, name });
           if (!result.isSuccessful) {
+              if (result.reasons.includes(10 /* CommandResult.MissingSheetName */)) {
+                  interactiveRenameSheet(env, sheetId, _lt("The sheet name cannot be empty."));
+              }
               if (result.reasons.includes(11 /* CommandResult.DuplicatedSheetName */)) {
                   interactiveRenameSheet(env, sheetId, _lt("A sheet with the name %s already exists. Please select another name.", name));
               }
@@ -27818,9 +27821,9 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
       allowDispatch(cmd) {
           switch (cmd.type) {
               case "UPDATE_CELL":
-                  return this.checkCellOutOfSheet(cmd);
+                  return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
               case "CLEAR_CELL":
-                  return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                  return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
               default:
                   return 0 /* CommandResult.Success */;
           }
@@ -28179,6 +28182,18 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
           }
           return 0 /* CommandResult.Success */;
       }
+      checkUselessUpdateCell(cmd) {
+          const cell = this.getters.getCell(cmd.sheetId, cmd.col, cmd.row);
+          const hasContent = "content" in cmd || "formula" in cmd;
+          const hasStyle = "style" in cmd;
+          const hasFormat = "format" in cmd;
+          if ((!hasContent || (cell === null || cell === void 0 ? void 0 : cell.content) === cmd.content) &&
+              (!hasStyle || deepEquals(cell === null || cell === void 0 ? void 0 : cell.style, cmd.style)) &&
+              (!hasFormat || (cell === null || cell === void 0 ? void 0 : cell.format) === cmd.format)) {
+              return 88 /* CommandResult.NoChanges */;
+          }
+          return 0 /* CommandResult.Success */;
+      }
   }
   CellPlugin.getters = [
       "zoneToXC",
@@ -43258,9 +43273,9 @@ day_count_convention (number, default=${DEFAULT_DAY_COUNT_CONVENTION} ) ${_lt("A
   Object.defineProperty(exports, '__esModule', { value: true });
 
 
-  __info__.version = '16.0.32';
-  __info__.date = '2024-02-09T13:05:36.074Z';
-  __info__.hash = '452dce2';
+  __info__.version = '16.0.34';
+  __info__.date = '2024-03-12T07:54:05.304Z';
+  __info__.hash = 'e923ddd';
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);