@odoo/o-spreadsheet 15.2.11 → 15.2.13

package/dist/o-spreadsheet.cjs.js

@@ -2709,13 +2709,6 @@ for (let font of fontSizes) {
 }
 
 //------------------------------------------------------------------------------
-/**
- * Stringify an object, like JSON.stringify, except that the first level of keys
- * is ordered.
- */
-function stringify(obj) {
-    return JSON.stringify(obj, Object.keys(obj).sort());
-}
 /**
  * Remove quotes from a quoted string
  * ```js
@@ -2940,7 +2933,7 @@ const DEBUG = {};
  */
 function getItemId(item, itemsDic) {
     for (let [key, value] of Object.entries(itemsDic)) {
-        if (stringify(value) === stringify(item)) {
+        if (deepEquals(value, item)) {
             return parseInt(key, 10);
         }
     }
@@ -9405,7 +9398,7 @@ class BordersPlugin extends CorePlugin {
          */
         function getBorderId(border) {
             for (let [key, value] of Object.entries(borders)) {
-                if (stringify(value) === stringify(border)) {
+                if (deepEquals(value, border)) {
                     return parseInt(key, 10);
                 }
             }
@@ -9643,12 +9636,10 @@ class CellPlugin extends CorePlugin {
      * starting an async evaluation even if it has been moved or re-allocated
      */
     getCellById(cellId) {
-        for (const sheet of Object.values(this.cells)) {
-            if (sheet[cellId]) {
-                return sheet[cellId];
-            }
-        }
-        return undefined;
+        // this must be as fast as possible
+        const position = this.getters.getCellPosition(cellId);
+        const sheet = this.cells[position.sheetId];
+        return sheet[cellId];
     }
     /**
      * Try to infer the cell format based on the formula dependencies.
@@ -15876,7 +15867,7 @@ const CSS$i = css$k /* scss */ `
       }
       .o-input-count {
         width: fit-content;
-        padding: 4 0 4 4;
+        padding: 4px 0 4px 4px;
       }
     }
   }
@@ -23413,9 +23404,9 @@ function revertChanges(revisions) {
  * Apply the changes of the given HistoryChange to the state
  */
 function applyChange(change, target) {
-    let val = change.root;
-    let key = change.path[change.path.length - 1];
-    for (let pathIndex = 0; pathIndex < change.path.slice(0, -1).length; pathIndex++) {
+    let val = change.path[0];
+    const key = change.path[change.path.length - 1];
+    for (let pathIndex = 1; pathIndex < change.path.slice(0, -1).length; pathIndex++) {
         const p = change.path[pathIndex];
         if (val[p] === undefined) {
             const nextPath = change.path[pathIndex + 1];
@@ -23871,13 +23862,14 @@ class StateObserver {
     }
     addChange(...args) {
         const val = args.pop();
-        const [root, ...path] = args;
+        const root = args[0];
         let value = root;
-        let key = path[path.length - 1];
-        for (let pathIndex = 0; pathIndex <= path.length - 2; pathIndex++) {
-            const p = path[pathIndex];
+        let key = args[args.length - 1];
+        const pathLength = args.length - 2;
+        for (let pathIndex = 1; pathIndex <= pathLength; pathIndex++) {
+            const p = args[pathIndex];
             if (value[p] === undefined) {
-                const nextPath = path[pathIndex + 1];
+                const nextPath = args[pathIndex + 1];
                 value[p] = createEmptyStructure(nextPath);
             }
             value = value[p];
@@ -23886,8 +23878,7 @@ class StateObserver {
             return;
         }
         this.changes.push({
-            root,
-            path,
+            path: args,
             before: value[key],
             after: val,
         });
@@ -25927,7 +25918,10 @@ class Model extends owl__namespace.core.EventBus {
      */
     checkDispatchAllowed(command) {
         const results = this.handlers.map((handler) => handler.allowDispatch(command));
-        return new DispatchResult(results.flat());
+        if (results.some((r) => r !== 0 /* Success */)) {
+            return new DispatchResult(results.flat());
+        }
+        return DispatchResult.Success;
     }
     finalize() {
         this.status = 3 /* Finalizing */;
@@ -26090,10 +26084,13 @@ class Popover extends owl.Component {
         super(...arguments);
         this.getters = this.env.getters;
     }
+    get maxHeight() {
+        return Math.max(0, this.viewportDimension.height - BOTTOMBAR_HEIGHT - SCROLLBAR_WIDTH$1);
+    }
     get style() {
         const horizontalPosition = `left:${this.horizontalPosition()}`;
         const verticalPosition = `top:${this.verticalPosition()}`;
-        const height = `max-height:${this.viewportDimension.height - BOTTOMBAR_HEIGHT - SCROLLBAR_WIDTH$1}`;
+        const height = `max-height:${this.maxHeight}`;
         return `
       position: absolute;
       z-index: 5;
@@ -26115,7 +26112,8 @@ class Popover extends owl.Component {
     }
     get shouldRenderBottom() {
         const { y } = this.props.position;
-        return y + this.props.childHeight < this.viewportDimension.height + TOPBAR_HEIGHT;
+        return (y + Math.min(this.props.childHeight, this.maxHeight) <
+            this.viewportDimension.height + TOPBAR_HEIGHT);
     }
     horizontalPosition() {
         const { x } = this.props.position;
@@ -31385,6 +31383,6 @@ exports.registries = registries;
 exports.setTranslationMethod = setTranslationMethod;
 
 
-__info__.version = '15.2.11';
-__info__.date = '2023-10-19T14:17:12.583Z';
-__info__.hash = 'e13740a';
+__info__.version = '15.2.13';
+__info__.date = '2023-11-24T13:06:49.659Z';
+__info__.hash = 'ea82269';

package/dist/o-spreadsheet.d.ts

@@ -888,7 +888,7 @@ declare class StateObserver {
         commands: CoreCommand[];
     };
     addCommand(command: CoreCommand): void;
-    addChange(...args: any[]): void;
+    addChange(...args: [...HistoryChange["path"], any]): void;
 }
 
 /**
@@ -3803,8 +3803,7 @@ declare type EvalContext = {
 };
 
 interface HistoryChange {
-    root: any;
-    path: (string | number)[];
+    path: [any, ...(number | string)[]];
     before: any;
     after: any;
 }
@@ -4088,6 +4087,7 @@ declare class Popover extends Component<Props$g, SpreadsheetEnv> {
         marginTop: number;
     };
     private getters;
+    get maxHeight(): number;
     get style(): string;
     private get viewportDimension();
     private get shouldRenderRight();

package/dist/o-spreadsheet.esm.js

@@ -2686,13 +2686,6 @@ for (let font of fontSizes) {
 }
 
 //------------------------------------------------------------------------------
-/**
- * Stringify an object, like JSON.stringify, except that the first level of keys
- * is ordered.
- */
-function stringify(obj) {
-    return JSON.stringify(obj, Object.keys(obj).sort());
-}
 /**
  * Remove quotes from a quoted string
  * ```js
@@ -2917,7 +2910,7 @@ const DEBUG = {};
  */
 function getItemId(item, itemsDic) {
     for (let [key, value] of Object.entries(itemsDic)) {
-        if (stringify(value) === stringify(item)) {
+        if (deepEquals(value, item)) {
             return parseInt(key, 10);
         }
     }
@@ -9382,7 +9375,7 @@ class BordersPlugin extends CorePlugin {
          */
         function getBorderId(border) {
             for (let [key, value] of Object.entries(borders)) {
-                if (stringify(value) === stringify(border)) {
+                if (deepEquals(value, border)) {
                     return parseInt(key, 10);
                 }
             }
@@ -9620,12 +9613,10 @@ class CellPlugin extends CorePlugin {
      * starting an async evaluation even if it has been moved or re-allocated
      */
     getCellById(cellId) {
-        for (const sheet of Object.values(this.cells)) {
-            if (sheet[cellId]) {
-                return sheet[cellId];
-            }
-        }
-        return undefined;
+        // this must be as fast as possible
+        const position = this.getters.getCellPosition(cellId);
+        const sheet = this.cells[position.sheetId];
+        return sheet[cellId];
     }
     /**
      * Try to infer the cell format based on the formula dependencies.
@@ -15853,7 +15844,7 @@ const CSS$i = css$k /* scss */ `
       }
       .o-input-count {
         width: fit-content;
-        padding: 4 0 4 4;
+        padding: 4px 0 4px 4px;
       }
     }
   }
@@ -23390,9 +23381,9 @@ function revertChanges(revisions) {
  * Apply the changes of the given HistoryChange to the state
  */
 function applyChange(change, target) {
-    let val = change.root;
-    let key = change.path[change.path.length - 1];
-    for (let pathIndex = 0; pathIndex < change.path.slice(0, -1).length; pathIndex++) {
+    let val = change.path[0];
+    const key = change.path[change.path.length - 1];
+    for (let pathIndex = 1; pathIndex < change.path.slice(0, -1).length; pathIndex++) {
         const p = change.path[pathIndex];
         if (val[p] === undefined) {
             const nextPath = change.path[pathIndex + 1];
@@ -23848,13 +23839,14 @@ class StateObserver {
     }
     addChange(...args) {
         const val = args.pop();
-        const [root, ...path] = args;
+        const root = args[0];
         let value = root;
-        let key = path[path.length - 1];
-        for (let pathIndex = 0; pathIndex <= path.length - 2; pathIndex++) {
-            const p = path[pathIndex];
+        let key = args[args.length - 1];
+        const pathLength = args.length - 2;
+        for (let pathIndex = 1; pathIndex <= pathLength; pathIndex++) {
+            const p = args[pathIndex];
             if (value[p] === undefined) {
-                const nextPath = path[pathIndex + 1];
+                const nextPath = args[pathIndex + 1];
                 value[p] = createEmptyStructure(nextPath);
             }
             value = value[p];
@@ -23863,8 +23855,7 @@ class StateObserver {
             return;
         }
         this.changes.push({
-            root,
-            path,
+            path: args,
             before: value[key],
             after: val,
         });
@@ -25904,7 +25895,10 @@ class Model extends owl.core.EventBus {
      */
     checkDispatchAllowed(command) {
         const results = this.handlers.map((handler) => handler.allowDispatch(command));
-        return new DispatchResult(results.flat());
+        if (results.some((r) => r !== 0 /* Success */)) {
+            return new DispatchResult(results.flat());
+        }
+        return DispatchResult.Success;
     }
     finalize() {
         this.status = 3 /* Finalizing */;
@@ -26067,10 +26061,13 @@ class Popover extends Component {
         super(...arguments);
         this.getters = this.env.getters;
     }
+    get maxHeight() {
+        return Math.max(0, this.viewportDimension.height - BOTTOMBAR_HEIGHT - SCROLLBAR_WIDTH$1);
+    }
     get style() {
         const horizontalPosition = `left:${this.horizontalPosition()}`;
         const verticalPosition = `top:${this.verticalPosition()}`;
-        const height = `max-height:${this.viewportDimension.height - BOTTOMBAR_HEIGHT - SCROLLBAR_WIDTH$1}`;
+        const height = `max-height:${this.maxHeight}`;
         return `
       position: absolute;
       z-index: 5;
@@ -26092,7 +26089,8 @@ class Popover extends Component {
     }
     get shouldRenderBottom() {
         const { y } = this.props.position;
-        return y + this.props.childHeight < this.viewportDimension.height + TOPBAR_HEIGHT;
+        return (y + Math.min(this.props.childHeight, this.maxHeight) <
+            this.viewportDimension.height + TOPBAR_HEIGHT);
     }
     horizontalPosition() {
         const { x } = this.props.position;
@@ -31339,6 +31337,6 @@ const helpers = {
 export { CommandResult, CorePlugin, DATETIME_FORMAT, DataSource, DispatchResult, Model, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, UIPlugin, DEBUG as __DEBUG__, __info__, astToFormula, cellTypes, compile, convertAstNodes, coreTypes, functionCache, helpers, invalidateEvaluationCommands, parse, readonlyAllowedCommands, registries, setTranslationMethod };
 
 
-__info__.version = '15.2.11';
-__info__.date = '2023-10-19T14:17:12.583Z';
-__info__.hash = 'e13740a';
+__info__.version = '15.2.13';
+__info__.date = '2023-11-24T13:06:49.659Z';
+__info__.hash = 'ea82269';

package/dist/o-spreadsheet.iife.js

@@ -2706,13 +2706,6 @@
   }
 
   //------------------------------------------------------------------------------
-  /**
-   * Stringify an object, like JSON.stringify, except that the first level of keys
-   * is ordered.
-   */
-  function stringify(obj) {
-      return JSON.stringify(obj, Object.keys(obj).sort());
-  }
   /**
    * Remove quotes from a quoted string
    * ```js
@@ -2937,7 +2930,7 @@
    */
   function getItemId(item, itemsDic) {
       for (let [key, value] of Object.entries(itemsDic)) {
-          if (stringify(value) === stringify(item)) {
+          if (deepEquals(value, item)) {
               return parseInt(key, 10);
           }
       }
@@ -9402,7 +9395,7 @@
            */
           function getBorderId(border) {
               for (let [key, value] of Object.entries(borders)) {
-                  if (stringify(value) === stringify(border)) {
+                  if (deepEquals(value, border)) {
                       return parseInt(key, 10);
                   }
               }
@@ -9640,12 +9633,10 @@
        * starting an async evaluation even if it has been moved or re-allocated
        */
       getCellById(cellId) {
-          for (const sheet of Object.values(this.cells)) {
-              if (sheet[cellId]) {
-                  return sheet[cellId];
-              }
-          }
-          return undefined;
+          // this must be as fast as possible
+          const position = this.getters.getCellPosition(cellId);
+          const sheet = this.cells[position.sheetId];
+          return sheet[cellId];
       }
       /**
        * Try to infer the cell format based on the formula dependencies.
@@ -15873,7 +15864,7 @@
       }
       .o-input-count {
         width: fit-content;
-        padding: 4 0 4 4;
+        padding: 4px 0 4px 4px;
       }
     }
   }
@@ -23410,9 +23401,9 @@
    * Apply the changes of the given HistoryChange to the state
    */
   function applyChange(change, target) {
-      let val = change.root;
-      let key = change.path[change.path.length - 1];
-      for (let pathIndex = 0; pathIndex < change.path.slice(0, -1).length; pathIndex++) {
+      let val = change.path[0];
+      const key = change.path[change.path.length - 1];
+      for (let pathIndex = 1; pathIndex < change.path.slice(0, -1).length; pathIndex++) {
           const p = change.path[pathIndex];
           if (val[p] === undefined) {
               const nextPath = change.path[pathIndex + 1];
@@ -23868,13 +23859,14 @@
       }
       addChange(...args) {
           const val = args.pop();
-          const [root, ...path] = args;
+          const root = args[0];
           let value = root;
-          let key = path[path.length - 1];
-          for (let pathIndex = 0; pathIndex <= path.length - 2; pathIndex++) {
-              const p = path[pathIndex];
+          let key = args[args.length - 1];
+          const pathLength = args.length - 2;
+          for (let pathIndex = 1; pathIndex <= pathLength; pathIndex++) {
+              const p = args[pathIndex];
               if (value[p] === undefined) {
-                  const nextPath = path[pathIndex + 1];
+                  const nextPath = args[pathIndex + 1];
                   value[p] = createEmptyStructure(nextPath);
               }
               value = value[p];
@@ -23883,8 +23875,7 @@
               return;
           }
           this.changes.push({
-              root,
-              path,
+              path: args,
               before: value[key],
               after: val,
           });
@@ -25924,7 +25915,10 @@
        */
       checkDispatchAllowed(command) {
           const results = this.handlers.map((handler) => handler.allowDispatch(command));
-          return new DispatchResult(results.flat());
+          if (results.some((r) => r !== 0 /* Success */)) {
+              return new DispatchResult(results.flat());
+          }
+          return DispatchResult.Success;
       }
       finalize() {
           this.status = 3 /* Finalizing */;
@@ -26087,10 +26081,13 @@
           super(...arguments);
           this.getters = this.env.getters;
       }
+      get maxHeight() {
+          return Math.max(0, this.viewportDimension.height - BOTTOMBAR_HEIGHT - SCROLLBAR_WIDTH$1);
+      }
       get style() {
           const horizontalPosition = `left:${this.horizontalPosition()}`;
           const verticalPosition = `top:${this.verticalPosition()}`;
-          const height = `max-height:${this.viewportDimension.height - BOTTOMBAR_HEIGHT - SCROLLBAR_WIDTH$1}`;
+          const height = `max-height:${this.maxHeight}`;
           return `
       position: absolute;
       z-index: 5;
@@ -26112,7 +26109,8 @@
       }
       get shouldRenderBottom() {
           const { y } = this.props.position;
-          return y + this.props.childHeight < this.viewportDimension.height + TOPBAR_HEIGHT;
+          return (y + Math.min(this.props.childHeight, this.maxHeight) <
+              this.viewportDimension.height + TOPBAR_HEIGHT);
       }
       horizontalPosition() {
           const { x } = this.props.position;
@@ -31384,9 +31382,9 @@
   Object.defineProperty(exports, '__esModule', { value: true });
 
 
-  __info__.version = '15.2.11';
-  __info__.date = '2023-10-19T14:17:12.583Z';
-  __info__.hash = 'e13740a';
+  __info__.version = '15.2.13';
+  __info__.date = '2023-11-24T13:06:49.659Z';
+  __info__.hash = 'ea82269';
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);