@odla-ai/chapter 0.10.1 → 0.12.0

package/README.md

@@ -156,18 +156,46 @@ These bite silently — a smoke test won't catch them:
   ready), `"none"` skips it — all need `clerk_secret_key` in the tenant vault. A
   site that wants server-side create must set `account: "create"`; inheriting the
   default silently changes the model.
-- **What lands on the Clerk account.** Both models write `public_metadata` as
-  `{ applicationId, profile }`, where `profile` is every configured
+- **What lands on the Clerk account (and its `public_metadata` is
+  client-readable).** Both models write `public_metadata` as
+  `{ applicationId, profile }`. By default `profile` is every configured
   `application.required`/`optional` field Clerk doesn't already carry natively
-  (so *not* email/firstName/lastName), plus `focus`. It follows your field names —
-  `applicantProfile(chapter, fields)` is exported if you want to assert the exact
-  shape in a test before deleting a local override.
+  (so *not* email/firstName/lastName), plus `focus` — **which means free-text or
+  third-party fields like `message` or `referral` are exposed to the browser
+  unless you curate.** Set `application: { profileFields: ["phone", "state",
+  "focus", ...] }` to an allowlist and everything else stays db-only. Array fields
+  (`focus`) are clamped to `maxArrayLen` (default 100) and non-primitive elements
+  dropped, so a client can't post an unbounded array into metadata.
+  `applicantProfile(chapter, fields)` is exported to assert the exact shape in a
+  test before deleting a local override. (Default is back-compat today; expected
+  to tighten at 1.0.)
+- **Email + input validation.** The field literally named `email` is checked
+  against a permissive email shape (400 on `"notanemail"`, so it fails cleanly
+  here rather than at the downstream Clerk create) — set
+  `application: { validateEmail: false }` to opt out; `isValidEmail` is exported.
+  A valid application is never newly rejected.
+- **CRM enrichment.** `projectApplicant` writes the base identity/contact person.
+  To carry more of the application into the CRM, list `application: { crmFields:
+  [...] }` — each must be a field on your crm person type, else that field is
+  dropped and the base person still projects (it is never lost). Stage mirroring,
+  billing snapshots and Clerk-identity linking stay yours as host routes.
 - **Disclaimer acknowledgement.** A truthy `disclaimerAck` on the submit body
   (boolean or the string a plain form posts) stamps `disclaimerAckAt` from the
   *server* clock; no ack leaves the attr absent, and a client-supplied
-  `disclaimerAckAt` is ignored. If your join page collects consent, post the flag —
-  an unstamped row is the honest record that nobody acked, so a missing flag
-  fails silently in exactly the way a compliance record must not.
+  `disclaimerAckAt` is ignored.
+
+  Unlike most data loss this is **unreconstructible** — you cannot later
+  determine whether someone checked a box — so the submit response always echoes
+  `disclaimerAckAt` (a number, or `null` when nothing was recorded). Assert it in
+  one integration test and a join page that quietly stops posting the flag can't
+  go unnoticed.
+
+  **If the disclaimer is a compliance record, set
+  `application: { requireDisclaimerAck: true }`** and a submit with no ack is a
+  400 instead of a row with no consent. It defaults to `false` so an upgrade
+  never starts rejecting traffic; enabling it fails *deterministically* on your
+  first test submit, not intermittently in production. Expect this to default to
+  `true` at 1.0.
 - **CRM projection points.** chapter projects the person on application submit
   (`projectApplicant`), not on booking or on webhook status change. If you mirror
   pipeline stage into the CRM, keep those routes.
@@ -177,6 +205,13 @@ These bite silently — a smoke test won't catch them:
 
 ### Install + scope notes
 
+- **Your first admin is seeded in odla Studio, by hand — and the email must be
+  lowercased.** Neither `admins` nor `superAdmins` is ever written by a worker
+  route or a provisioning seed; that is deliberate, so nothing running in the app
+  (or injected into a page) can grant admin. The gate looks the email up
+  lowercased, so a row saved as `Ada@Example.com` matches nothing and the account
+  silently isn't an admin — with no error to tell you. Save it lowercase, then
+  confirm by signing in, not by looking at the row.
 - **`@odla-ai/auth-clerk` is not a chapter peer.** It is deliberately absent from
   this package's manifest, because only one entry imports it: the worker verifies
   JWTs with `jose` via `ctx.verifyUser`, and `@odla-ai/chapter/ui/member` is
@@ -201,6 +236,11 @@ These bite silently — a smoke test won't catch them:
   per-person comms, people list, role changes, approve and refund are out of
   scope** — they are yours as host routes via the seam. Don't plan around them
   shipping.
+- **`onboardingInvite` is a template with no built-in caller.** It is seeded into
+  the group's email settings (so you can edit its copy) but chapter never fires
+  it, because the moment it would fire — approval — is a host route (approval is
+  out of scope, above). Send it from your own approve handler via `sendTemplated`;
+  the seed existing does not mean the built-ins send it.
 
 ### Verify from the types, not this file
 

package/dist/index.cjs

@@ -33,6 +33,7 @@ __export(index_exports, {
   canTransition: () => canTransition,
   canceledPatch: () => canceledPatch,
   chapterDb: () => chapterDb,
+  clampArray: () => clampArray,
   clerkInviteRequest: () => clerkInviteRequest,
   clerkUserRequest: () => clerkUserRequest,
   createChapterIntegration: () => createChapterIntegration,
@@ -45,11 +46,13 @@ __export(index_exports, {
   findApplicationRef: () => findApplicationRef,
   firstPaymentPatch: () => firstPaymentPatch,
   getVaultSecret: () => getVaultSecret,
+  hasDisclaimerAck: () => hasDisclaimerAck,
   introIdempotencyKey: () => introIdempotencyKey,
   isAdminRole: () => isAdminRole,
   isAlreadySent: () => isAlreadySent,
   isReconcilable: () => isReconcilable,
   isSlotAvailable: () => isSlotAvailable,
+  isValidEmail: () => isValidEmail,
   joinConfig: () => joinConfig,
   meetingCreateRow: () => meetingCreateRow,
   meetingRescheduleUpdate: () => meetingRescheduleUpdate,
@@ -481,23 +484,47 @@ function resolveApplication(a) {
       throw new Error(`defineChapter.application.${name}: must be an array of field-name strings`);
     }
   }
+  if (a?.profileFields !== void 0 && (!Array.isArray(a.profileFields) || !a.profileFields.every((f) => typeof f === "string" && f !== ""))) {
+    throw new Error("defineChapter.application.profileFields: must be an array of field-name strings");
+  }
+  if (a?.crmFields !== void 0 && (!Array.isArray(a.crmFields) || !a.crmFields.every((f) => typeof f === "string" && f !== ""))) {
+    throw new Error("defineChapter.application.crmFields: must be an array of field-name strings");
+  }
   return {
     required,
     optional,
     maxLen: a?.maxLen ?? {},
     defaultMaxLen: a?.defaultMaxLen ?? 2e3,
-    bodyCap: a?.bodyCap ?? 32768
+    bodyCap: a?.bodyCap ?? 32768,
+    requireDisclaimerAck: a?.requireDisclaimerAck ?? false,
+    profileFields: a?.profileFields ?? null,
+    crmFields: a?.crmFields ?? [],
+    maxArrayLen: a?.maxArrayLen ?? 100,
+    validateEmail: a?.validateEmail ?? true
   };
 }
+var EMAIL_RE = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
+function isValidEmail(value) {
+  return typeof value === "string" && EMAIL_RE.test(value);
+}
+function clampArray(value, max) {
+  if (!Array.isArray(value)) return value;
+  return value.filter((x) => typeof x === "string" || typeof x === "number" || typeof x === "boolean").slice(0, max);
+}
+function hasDisclaimerAck(fields) {
+  return fields.disclaimerAck === true || fields.disclaimerAck === "true";
+}
 var IDENTITY_FIELDS = /* @__PURE__ */ new Set(["email", "firstName", "lastName"]);
 function applicantProfile(chapter, fields) {
+  const app = chapter.application;
+  const allowed = (f) => app.profileFields === null || app.profileFields.includes(f);
   const profile = {};
-  for (const f of [...chapter.application.required, ...chapter.application.optional]) {
-    if (IDENTITY_FIELDS.has(f)) continue;
+  for (const f of [...app.required, ...app.optional]) {
+    if (IDENTITY_FIELDS.has(f) || !allowed(f)) continue;
     const v = fields[f];
     if (typeof v === "string" && v.trim() !== "") profile[f] = v.trim();
   }
-  if (fields.focus !== void 0) profile.focus = fields.focus;
+  if (fields.focus !== void 0 && allowed("focus")) profile.focus = clampArray(fields.focus, app.maxArrayLen);
   return Object.keys(profile).length > 0 ? profile : void 0;
 }
 async function submitApplication(db, chapter, fields, opts) {
@@ -511,19 +538,26 @@ async function submitApplication(db, chapter, fields, opts) {
     const cap = app.maxLen[f] ?? app.defaultMaxLen;
     if (typeof v === "string" && v.length > cap) return { ok: false, error: `${f} exceeds ${cap} characters` };
   }
+  if (app.validateEmail && typeof fields.email === "string" && !isValidEmail(fields.email)) {
+    return { ok: false, error: "email must be a valid email address" };
+  }
+  const acked = hasDisclaimerAck(fields);
+  if (app.requireDisclaimerAck && !acked) {
+    return { ok: false, error: "disclaimerAck is required" };
+  }
   const id2 = opts.newId();
   const row = { id: id2, status: chapter.pipeline.initial, createdAt: opts.now };
   for (const f of [...app.required, ...app.optional]) {
     if (typeof fields[f] === "string") row[f] = fields[f].trim();
   }
-  if (fields.focus !== void 0) row.focus = fields.focus;
+  if (fields.focus !== void 0) row.focus = clampArray(fields.focus, app.maxArrayLen);
   if (opts.groupId) row.groupId = opts.groupId;
-  if (fields.disclaimerAck === true || fields.disclaimerAck === "true") row.disclaimerAckAt = opts.now;
+  if (acked) row.disclaimerAckAt = opts.now;
   const { duplicate } = await db.transact(
     [{ t: "update", ns: "applications", id: id2, attrs: row }],
     opts.submissionId ? { mutationId: `join:${opts.submissionId}` } : void 0
   );
-  return { ok: true, id: id2, duplicate, status: chapter.pipeline.initial };
+  return { ok: true, id: id2, duplicate, status: chapter.pipeline.initial, disclaimerAckAt: acked ? opts.now : null };
 }
 function joinConfig(group, paymentsReady2) {
   return {
@@ -858,7 +892,7 @@ async function projectSharedRecord(deps, person) {
   return upsertPerson(deps, { email: person.email, input: sharedPersonInput(person), mutationId: `share:${person.hubRecordId}` });
 }
 async function projectApplicant(deps, applicant) {
-  const input = sharedPersonInput({
+  const base = sharedPersonInput({
     email: applicant.email,
     firstName: applicant.firstName,
     lastName: applicant.lastName,
@@ -866,7 +900,14 @@ async function projectApplicant(deps, applicant) {
     linkedin: applicant.linkedin,
     hubRecordId: applicant.applicationId
   });
-  return upsertPerson(deps, { email: applicant.email, input, mutationId: `apply:${applicant.applicationId}` });
+  const mutationId = `apply:${applicant.applicationId}`;
+  const extra = applicant.extra ?? {};
+  if (Object.keys(extra).length === 0) return upsertPerson(deps, { email: applicant.email, input: base, mutationId });
+  try {
+    return await upsertPerson(deps, { email: applicant.email, input: { ...base, ...extra }, mutationId });
+  } catch {
+    return upsertPerson(deps, { email: applicant.email, input: base, mutationId });
+  }
 }
 
 // src/clerk.ts