@od-oneapp/config 2026.2.2001-canary.1

package/eslint/node.mjs

@@ -0,0 +1,106 @@
+/**
+ * @fileoverview ESLint configuration for Node.js projects
+ *
+ * Extends base config and adds Node.js 22+ specific rules and globals.
+ * Includes native Fetch API, WebSocket, and Node.js best practices.
+ *
+ * **Use cases**:
+ * - Node.js servers and APIs
+ * - CLI tools and scripts
+ * - Build tools and utilities
+ *
+ * **Note**: Do NOT combine with `react.mjs` - they both define the unicorn plugin.
+ * Use `node.mjs` for backend/Node.js projects, `react.mjs` for frontend projects.
+ *
+ * @example
+ * ```javascript
+ * // eslint.config.mjs
+ * import nodeConfig from '@od-oneapp/config/eslint/node';
+ * export default nodeConfig;
+ * ```
+ */
+
+import importPlugin from 'eslint-plugin-import';
+import nodePlugin from 'eslint-plugin-n';
+import unicorn from 'eslint-plugin-unicorn';
+import tseslint from 'typescript-eslint';
+
+import baseConfig from './base.mjs';
+import { NODE_22_GLOBALS } from './shared/node-globals.mjs';
+import { createValidatedConfig } from './utils/create-validated-config.mjs';
+
+/**
+ * Node.js ESLint configuration
+ *
+ * @type {import('typescript-eslint').ConfigArray}
+ */
+const config = tseslint.config(...baseConfig, {
+  files: ['**/*.{ts,tsx,js,jsx,mjs}'],
+  languageOptions: {
+    globals: NODE_22_GLOBALS,
+  },
+  plugins: {
+    unicorn,
+    n: nodePlugin,
+    import: importPlugin,
+  },
+  rules: {
+    // Node.js specific best practices
+    'unicorn/prefer-node-protocol': 'error', // Use 'node:fs' instead of 'fs'
+    'unicorn/no-process-exit': 'off', // Allow process.exit in Node.js scripts
+
+    // Node.js specific patterns (using eslint-plugin-n)
+    'n/prefer-global/console': 'off', // Node.js has console
+    'n/prefer-global/process': 'off', // Node.js has process
+
+    // Node.js security
+    'n/no-sync': 'off', // Sync functions are sometimes needed in Node.js
+
+    // Additional Unicorn rules for Node.js
+    'unicorn/no-new-buffer': 'error',
+
+    // Allow Node.js convention variables __dirname and __filename
+    'no-used-underscore-vars/no-used-underscore-vars': [
+      'error',
+      {
+        allow: ['__dirname', '__filename'],
+      },
+    ],
+
+    // Import plugin - Import organization
+    'import/order': [
+      'error',
+      {
+        groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index', 'object', 'type'],
+        pathGroups: [
+          {
+            pattern: 'react',
+            group: 'external',
+            position: 'before',
+          },
+          {
+            pattern: 'next',
+            group: 'external',
+            position: 'before',
+          },
+        ],
+        pathGroupsExcludedImportTypes: ['react', 'next'],
+        'newlines-between': 'always',
+        alphabetize: {
+          order: 'asc',
+          caseInsensitive: true,
+        },
+      },
+    ],
+    'import/no-duplicates': 'error',
+    'import/no-self-import': 'error',
+    'import/no-useless-path-segments': ['error', { noUselessIndex: true }],
+  },
+  settings: {
+    node: {
+      tryExtensions: ['.js', '.mjs', '.json', '.node', '.ts', '.tsx'],
+    },
+  },
+});
+
+export default createValidatedConfig(config, 'node');

package/eslint/react.mjs

@@ -0,0 +1,313 @@
+/**
+ * @fileoverview ESLint configuration for React 19.2 projects
+ *
+ * Extends base config and adds React-specific rules optimized for React 19.2.
+ * Includes support for new React 19 hooks (`use`, `useActionState`, `useFormStatus`, `useOptimistic`).
+ *
+ * **Features**:
+ * - React 19.2 optimizations and best practices
+ * - JSX accessibility rules (jsx-a11y)
+ * - React Hooks rules with React 19 support
+ * - Import organization and validation
+ * - Code quality rules (Unicorn plugin)
+ * - Regex and secret detection
+ *
+ * **Use cases**:
+ * - React applications (standalone)
+ * - React libraries and components
+ * - Extend for Next.js or Expo projects
+ *
+ * @example
+ * ```javascript
+ * // eslint.config.mjs
+ * import reactConfig from '@od-oneapp/config/eslint/react';
+ * export default reactConfig;
+ * ```
+ */
+
+import importPlugin from 'eslint-plugin-import';
+import jsxA11y from 'eslint-plugin-jsx-a11y';
+import noSecretsPlugin from 'eslint-plugin-no-secrets';
+import react from 'eslint-plugin-react';
+import reactHooks from 'eslint-plugin-react-hooks';
+import regexpPlugin from 'eslint-plugin-regexp';
+import unicorn from 'eslint-plugin-unicorn';
+import tseslint from 'typescript-eslint';
+
+import baseConfig from './base.mjs';
+import { createValidatedConfig } from './utils/create-validated-config.mjs';
+
+/**
+ * React ESLint configuration
+ *
+ * @type {import('typescript-eslint').ConfigArray}
+ */
+const config = tseslint.config(
+  ...baseConfig,
+  {
+    files: ['**/*.{ts,tsx,js,jsx,mjs}'],
+    plugins: {
+      react,
+      'react-hooks': reactHooks,
+      unicorn,
+      import: importPlugin,
+      'jsx-a11y': jsxA11y,
+    },
+    languageOptions: {
+      parserOptions: {
+        ecmaFeatures: {
+          jsx: true,
+        },
+        ecmaVersion: 'latest',
+      },
+      globals: {
+        React: 'readonly',
+      },
+    },
+    settings: {
+      react: {
+        version: '19.2.0', // Fixed React version for React 19.2
+      },
+    },
+    rules: {
+      // React plugin recommended rules for React 19.2
+      ...react.configs.recommended.rules,
+      'react/jsx-uses-react': 'error',
+      'react/jsx-uses-vars': 'error',
+      'react/react-in-jsx-scope': 'off', // Not needed in React 17+ (automatic JSX runtime)
+      'react/prop-types': 'off', // TypeScript handles prop validation
+
+      // React 19.2 specific optimizations
+      'react/jsx-key': [
+        'error',
+        {
+          checkFragmentShorthand: true,
+          checkKeyMustBeforeSpread: true,
+          warnOnDuplicates: true,
+        },
+      ],
+
+      // React 19 concurrent features and performance
+      'react/jsx-no-leaked-render': 'error', // Prevent conditional rendering issues
+      'react/jsx-no-target-blank': 'warn', // Security for external links
+      'react/no-array-index-key': 'warn', // Discourage array index as key
+      'react/no-danger': 'warn', // Discourage dangerouslySetInnerHTML
+      'react/self-closing-comp': [
+        'error',
+        {
+          component: true,
+          html: true,
+        },
+      ],
+
+      // Additional React performance and best practice rules
+      'react/jsx-no-useless-fragment': ['error', { allowExpressions: true }],
+      'react/jsx-fragments': ['error', 'syntax'],
+      'react/no-unstable-nested-components': 'warn',
+      'react/jsx-no-constructed-context-values': 'warn',
+      'react/no-unused-prop-types': 'warn',
+      'react/button-has-type': 'warn',
+      'react/no-children-prop': 'error',
+      'react/no-danger-with-children': 'error',
+      'react/no-deprecated': 'warn',
+      'react/no-direct-mutation-state': 'error',
+      'react/no-find-dom-node': 'warn',
+      'react/no-is-mounted': 'error',
+      'react/no-render-return-value': 'warn',
+      'react/no-string-refs': 'error',
+      'react/no-unescaped-entities': 'warn',
+      'react/no-unknown-property': [
+        'error',
+        {
+          ignore: ['css'], // Styled-jsx support
+        },
+      ],
+      'react/prefer-es6-class': ['error', 'always'],
+      'react/void-dom-elements-no-children': 'error',
+
+      // Accessibility rules (jsx-a11y) - Essential for web accessibility
+      ...jsxA11y.configs.recommended.rules,
+      'jsx-a11y/anchor-is-valid': [
+        'error',
+        {
+          components: ['Link'],
+          specialLink: ['hrefLeft', 'hrefRight'],
+          aspects: ['invalidHref', 'preferButton'],
+        },
+      ],
+      'jsx-a11y/click-events-have-key-events': 'warn',
+      'jsx-a11y/no-static-element-interactions': 'warn',
+      'jsx-a11y/no-noninteractive-element-interactions': 'warn',
+
+      // React Hooks plugin recommended rules (optimized for React 19.2)
+      ...reactHooks.configs.recommended.rules,
+      'react-hooks/rules-of-hooks': 'error', // Enforce Rules of Hooks
+      'react-hooks/exhaustive-deps': 'off', // Disabled - can produce false positives with complex deps
+
+      // ============================================================================
+      // XO-Inspired Rules (Selectively copied for code quality)
+      // ============================================================================
+
+      // Unicorn plugin - Code quality improvements (from XO)
+      // Note: Some unicorn rules overlap with @typescript-eslint rules (prefer-includes,
+      // prefer-string-starts-ends-with). The TS rules are type-aware for .ts files;
+      // unicorn rules provide coverage for .js files where TS rules are disabled.
+      'unicorn/better-regex': 'error',
+      'unicorn/consistent-function-scoping': 'warn',
+      'unicorn/no-array-callback-reference': 'error',
+      'unicorn/no-array-method-this-argument': 'error',
+      'unicorn/no-array-push-push': 'error',
+      'unicorn/no-console-spaces': 'warn',
+      'unicorn/no-lonely-if': 'warn',
+      'unicorn/no-useless-length-check': 'error',
+      'unicorn/no-useless-spread': 'error',
+      'unicorn/prefer-array-find': 'error',
+      'unicorn/prefer-array-some': 'error',
+      'unicorn/prefer-array-flat-map': 'error',
+      'unicorn/prefer-includes': 'error',
+      'unicorn/prefer-module': 'off', // We use ESM, but keep off for compatibility
+      'unicorn/prefer-number-properties': 'error',
+      'unicorn/prefer-optional-catch-binding': 'error',
+      'unicorn/prefer-regexp-test': 'error',
+      'unicorn/prefer-string-starts-ends-with': 'error',
+      'unicorn/prefer-string-trim-start-end': 'error',
+      'unicorn/prefer-type-error': 'error',
+
+      // Additional Unicorn rules (low priority additions)
+      'unicorn/no-abusive-eslint-disable': 'warn',
+      'unicorn/no-array-for-each': 'off', // forEach is sometimes clearer
+      'unicorn/no-array-reduce': 'off', // Reduce is useful for accumulators
+      'unicorn/no-keyword-prefix': 'off', // Too opinionated for React
+      'unicorn/no-nested-ternary': 'warn',
+      'unicorn/no-new-array': 'warn',
+      'unicorn/no-new-buffer': 'error',
+      'unicorn/no-null': 'off', // null is valid in TypeScript/React
+      'unicorn/no-object-as-default-parameter': 'error',
+      'unicorn/no-process-exit': 'off', // Needed for Node.js scripts
+      'unicorn/no-thenable': 'error',
+      'unicorn/no-this-assignment': 'error',
+      'unicorn/no-useless-undefined': 'warn',
+      'unicorn/no-zero-fractions': 'error',
+      'unicorn/number-literal-case': 'error',
+      'unicorn/numeric-separators-style': ['error', { onlyIfContainsSeparator: true }],
+      'unicorn/prefer-array-index-of': 'error',
+      'unicorn/prefer-code-point': 'error',
+      'unicorn/prefer-date-now': 'error',
+      'unicorn/prefer-default-parameters': 'warn',
+      'unicorn/prefer-export-from': ['error', { ignoreUsedVariables: true }],
+      'unicorn/prefer-logical-operator-over-ternary': 'warn',
+      'unicorn/prefer-math-trunc': 'error',
+      'unicorn/prefer-modern-math-apis': 'error',
+      'unicorn/prefer-negative-index': 'warn',
+      'unicorn/prefer-node-protocol': 'off', // Only for Node.js, not React
+      'unicorn/prefer-object-from-entries': 'error',
+      'unicorn/prefer-prototype-methods': 'error',
+      'unicorn/prefer-reflect-apply': 'off', // Not commonly needed
+      'unicorn/escape-case': 'error',
+      'unicorn/prefer-set-has': 'error',
+      'unicorn/prefer-set-size': 'error',
+      'unicorn/prefer-spread': 'error',
+      'unicorn/prefer-string-replace-all': 'error',
+      'unicorn/prefer-string-slice': 'error',
+      'unicorn/prefer-top-level-await': 'off', // Requires ES2022 modules, use carefully
+      'unicorn/relative-url-style': ['error', 'always'],
+      'unicorn/require-array-join-separator': 'error',
+      'unicorn/require-number-to-fixed-digits-argument': 'error',
+      'unicorn/require-post-message-target-origin': 'warn',
+      'unicorn/string-content': 'off', // Too strict
+      'unicorn/switch-case-braces': ['error', 'avoid'],
+      'unicorn/template-indent': ['error', { tags: ['html', 'css', 'styled'] }],
+      'unicorn/text-encoding-identifier-case': 'error',
+
+      // Import plugin - Import organization (from XO, adapted for Next.js)
+      // Changed to 'error' since this is now the sole import sorter (prettier-plugin-organize-imports removed)
+      'import/order': [
+        'error',
+        {
+          groups: [
+            'builtin',
+            'external',
+            'internal',
+            'parent',
+            'sibling',
+            'index',
+            'object',
+            'type',
+          ],
+          pathGroups: [
+            {
+              pattern: 'react',
+              group: 'external',
+              position: 'before',
+            },
+            {
+              pattern: 'next',
+              group: 'external',
+              position: 'before',
+            },
+          ],
+          pathGroupsExcludedImportTypes: ['react', 'next'],
+          'newlines-between': 'always',
+          alphabetize: {
+            order: 'asc',
+            caseInsensitive: true,
+          },
+        },
+      ],
+      'import/no-duplicates': 'error',
+      'import/no-unused-modules': 'off', // Too strict for monorepo
+      'import/no-cycle': ['warn', { maxDepth: 10 }],
+      'import/no-self-import': 'error',
+      'import/no-useless-path-segments': ['error', { noUselessIndex: true }],
+      // Note: General best practices (prefer-const, prefer-template, etc.)
+      // are inherited from base.mjs - no need to redefine here
+    },
+  },
+  {
+    // Regexp and Secret Detection
+    files: ['**/*.{ts,tsx,js,jsx}'],
+    plugins: {
+      regexp: regexpPlugin,
+      'no-secrets': noSecretsPlugin,
+    },
+    rules: {
+      // Regexp
+      'regexp/no-unused-capturing-group': 'warn',
+      'regexp/prefer-character-class': 'warn',
+      'regexp/prefer-quantifier': 'warn',
+
+      // Secret detection
+      'no-secrets/no-secrets': ['error', { tolerance: 4.5 }],
+    },
+  },
+  {
+    // Config files - allow dev dependencies (import plugin registered here, not in base.mjs)
+    files: [
+      '**/*.config.{js,ts,mjs}',
+      '**/eslint.config.{js,mjs}',
+      '**/vitest.config.{ts,js,mjs}',
+      '**/playwright.config.{ts,js,mjs}',
+    ],
+    rules: {
+      'import/no-extraneous-dependencies': 'off',
+    },
+  },
+  {
+    // Type definition files - allow import duplicates
+    files: ['**/*.d.ts'],
+    rules: {
+      'import/no-duplicates': 'off',
+    },
+  },
+  {
+    // TypeScript files - disable unicorn rules that overlap with @typescript-eslint
+    // The TS-eslint versions are type-aware and more accurate for .ts/.tsx files
+    files: ['**/*.ts', '**/*.tsx'],
+    rules: {
+      'unicorn/prefer-includes': 'off', // Use @typescript-eslint/prefer-includes
+      'unicorn/prefer-string-starts-ends-with': 'off', // Use @typescript-eslint/prefer-string-starts-ends-with
+    },
+  },
+);
+
+export default createValidatedConfig(config, 'react');

package/eslint/rules/__tests__/no-used-underscore-vars.test.mjs

@@ -0,0 +1,147 @@
+/**
+ * @fileoverview no-used-underscore-vars.test.mjs
+ */
+
+import { RuleTester } from 'eslint';
+import tseslint from 'typescript-eslint';
+import { describe, it } from 'vitest';
+
+import rule from '../no-used-underscore-vars.mjs';
+
+describe('no-used-underscore-vars', () => {
+  const ruleTester = new RuleTester({
+    languageOptions: {
+      parser: tseslint.parser,
+      ecmaVersion: 2022,
+      sourceType: 'module',
+    },
+  });
+
+  it('should validate underscore-prefixed variables', () => {
+    ruleTester.run('no-used-underscore-vars', rule, {
+      valid: [
+        // Allowed: underscore prefix in declarations
+        'const _unused = 1;',
+        'let _helper = () => {};',
+        'var _temp = null;',
+        'function _helper() {}',
+        'const { _prop } = obj;',
+        'const [_item] = array;',
+        'const { _key: value } = obj;',
+        'const [..._rest] = array;',
+
+        // Allowed: property access (not variable usage)
+        'obj._id',
+        'obj._private',
+        'obj._internal',
+        'obj._privateMethod()',
+        'obj._prop = value',
+
+        // Allowed: type definitions
+        'interface Foo { _prop: string; }',
+        'type Bar = { _field: number; }',
+        'interface Test { _optional?: string; }',
+
+        // Allowed: function parameters (declaration context)
+        'function test(_param) {}',
+        'const fn = (_arg) => {};',
+        'function test(..._rest) {}',
+
+        // Edge case: null parent guard (defensive programming)
+        // Top-level declarations may have null parents in certain AST configurations
+        // These test cases verify the rule's null parent guard (line 81-83 in rule)
+        // prevents crashes when processing nodes without parents
+        'const _config = {};',
+        'let _state;',
+        'var _global;',
+      ],
+      invalid: [
+        {
+          code: 'const x = _unused;',
+          errors: [
+            {
+              message:
+                'Variable names starting with underscore should not be used (convention for unused variables)',
+            },
+          ],
+        },
+        {
+          code: 'function test() { return _value; }',
+          errors: [
+            {
+              message:
+                'Variable names starting with underscore should not be used (convention for unused variables)',
+            },
+          ],
+        },
+        {
+          code: 'if (_condition) {}',
+          errors: [
+            {
+              message:
+                'Variable names starting with underscore should not be used (convention for unused variables)',
+            },
+          ],
+        },
+        {
+          code: 'const result = _helper();',
+          errors: [
+            {
+              message:
+                'Variable names starting with underscore should not be used (convention for unused variables)',
+            },
+          ],
+        },
+        {
+          code: 'while (_flag) { break; }',
+          errors: [
+            {
+              message:
+                'Variable names starting with underscore should not be used (convention for unused variables)',
+            },
+          ],
+        },
+        {
+          code: 'const arr = [_item, _other];',
+          errors: [
+            {
+              message:
+                'Variable names starting with underscore should not be used (convention for unused variables)',
+            },
+            {
+              message:
+                'Variable names starting with underscore should not be used (convention for unused variables)',
+            },
+          ],
+        },
+        {
+          code: 'const obj = { key: _value };',
+          errors: [
+            {
+              message:
+                'Variable names starting with underscore should not be used (convention for unused variables)',
+            },
+          ],
+        },
+        {
+          code: 'const obj = { _value };',
+          errors: [
+            {
+              message:
+                'Variable names starting with underscore should not be used (convention for unused variables)',
+            },
+          ],
+        },
+        {
+          code: 'console.log(_data);',
+          errors: [
+            {
+              message:
+                'Variable names starting with underscore should not be used (convention for unused variables)',
+            },
+          ],
+        },
+      ],
+    });
+  });
+});