@oculum/scanner 1.0.14 → 1.0.15

package/src/__tests__/taint/cross-file-index.test.ts

@@ -0,0 +1,683 @@
+/**
+ * Tests for Cross-File Function Index (Phase 3, Part 1)
+ *
+ * Verifies that the CrossFileIndex correctly resolves imported function
+ * names to their actual definitions across files, handles re-exports,
+ * barrel files, aliased imports, CJS require, namespace imports, etc.
+ */
+
+import type { ScanFile } from '../../shared/types'
+import { parseFiles, clearASTCache } from '../../parse/ast'
+import { buildModuleGraph } from '../../model/module-graph'
+import { buildCrossFileIndex, type CrossFileIndex } from '../../taint/cross-file-index'
+
+// ============================================================================
+// Helpers
+// ============================================================================
+
+let fileCounter = 0
+
+function makeFile(path: string, content: string): ScanFile {
+  return {
+    path,
+    content,
+    language: path.endsWith('.js') ? 'javascript' : 'typescript',
+    size: content.length,
+  }
+}
+
+function buildIndex(files: ScanFile[]): CrossFileIndex {
+  const asts = parseFiles(files.map(f => ({ path: f.path, content: f.content })))
+  const moduleGraph = buildModuleGraph(files)
+  return buildCrossFileIndex(files, asts, moduleGraph)
+}
+
+beforeEach(() => {
+  clearASTCache()
+  fileCounter++
+})
+
+// ============================================================================
+// Basic Import Resolution
+// ============================================================================
+
+describe('Cross-File Index: Basic import resolution', () => {
+  it('resolves named import to function definition', () => {
+    const files = [
+      makeFile('src/routes.ts', `
+        import { query } from './db'
+        function handler(req, res) {
+          const input = req.body
+          query(input)
+        }
+      `),
+      makeFile('src/db.ts', `
+        export function query(sql) {
+          return db.execute(sql)
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const def = index.resolveImport.get('src/routes.ts:query')
+    expect(def).toBeDefined()
+    expect(def!.filePath).toBe('src/db.ts')
+    expect(def!.functionName).toBe('query')
+    expect(def!.params).toContain('sql')
+    expect(def!.isExported).toBe(true)
+  })
+
+  it('resolves default import to default export', () => {
+    const files = [
+      makeFile('src/app.ts', `
+        import createApp from './server'
+        createApp()
+      `),
+      makeFile('src/server.ts', `
+        export default function createApp() {
+          return { start: () => {} }
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const def = index.resolveImport.get('src/app.ts:createApp')
+    expect(def).toBeDefined()
+    expect(def!.filePath).toBe('src/server.ts')
+    expect(def!.functionName).toBe('createApp')
+  })
+
+  it('resolves aliased import: import { query as q }', () => {
+    const files = [
+      makeFile('src/routes.ts', `
+        import { query as q } from './db'
+        function handler(req, res) {
+          q(req.body)
+        }
+      `),
+      makeFile('src/db.ts', `
+        export function query(sql) {
+          return db.execute(sql)
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    // Should be resolvable under the alias name
+    const def = index.resolveImport.get('src/routes.ts:q')
+    expect(def).toBeDefined()
+    expect(def!.filePath).toBe('src/db.ts')
+    expect(def!.functionName).toBe('query')
+  })
+
+  it('resolves multiple named imports from same file', () => {
+    const files = [
+      makeFile('src/routes.ts', `
+        import { findOne, insertOne } from './db'
+        function handler(req, res) {
+          insertOne(req.body)
+          findOne(req.query.id)
+        }
+      `),
+      makeFile('src/db.ts', `
+        export function findOne(query) {
+          return db.find(query)
+        }
+        export function insertOne(doc) {
+          return db.insert(doc)
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const findOneDef = index.resolveImport.get('src/routes.ts:findOne')
+    expect(findOneDef).toBeDefined()
+    expect(findOneDef!.functionName).toBe('findOne')
+
+    const insertOneDef = index.resolveImport.get('src/routes.ts:insertOne')
+    expect(insertOneDef).toBeDefined()
+    expect(insertOneDef!.functionName).toBe('insertOne')
+  })
+})
+
+// ============================================================================
+// Re-exports and Barrel Files
+// ============================================================================
+
+describe('Cross-File Index: Re-exports and barrel files', () => {
+  it('resolves through a barrel file re-export', () => {
+    const files = [
+      makeFile('src/routes.ts', `
+        import { query } from './db'
+        function handler(req, res) {
+          query(req.body)
+        }
+      `),
+      makeFile('src/db/index.ts', `
+        export { query } from './queries'
+      `),
+      makeFile('src/db/queries.ts', `
+        export function query(sql) {
+          return pool.query(sql)
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const def = index.resolveImport.get('src/routes.ts:query')
+    expect(def).toBeDefined()
+    expect(def!.filePath).toBe('src/db/queries.ts')
+    expect(def!.functionName).toBe('query')
+  })
+
+  it('resolves two-hop re-export chain: A -> B -> C', () => {
+    const files = [
+      makeFile('src/app.ts', `
+        import { handler } from './api'
+        handler()
+      `),
+      makeFile('src/api/index.ts', `
+        export { handler } from './routes'
+      `),
+      makeFile('src/api/routes/index.ts', `
+        export { handler } from './users'
+      `),
+      makeFile('src/api/routes/users.ts', `
+        export function handler(req, res) {
+          return res.json({ ok: true })
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const def = index.resolveImport.get('src/app.ts:handler')
+    expect(def).toBeDefined()
+    expect(def!.filePath).toBe('src/api/routes/users.ts')
+    expect(def!.functionName).toBe('handler')
+  })
+})
+
+// ============================================================================
+// CJS Require
+// ============================================================================
+
+describe('Cross-File Index: CJS require', () => {
+  it('resolves destructured require', () => {
+    const files = [
+      makeFile('src/routes.js', `
+        const { query } = require('./db')
+        function handler(req, res) {
+          query(req.body)
+        }
+      `),
+      makeFile('src/db.js', `
+        function query(sql) {
+          return pool.query(sql)
+        }
+        module.exports = { query }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const def = index.resolveImport.get('src/routes.js:query')
+    expect(def).toBeDefined()
+    expect(def!.filePath).toBe('src/db.js')
+    expect(def!.functionName).toBe('query')
+  })
+
+  it('resolves default require as namespace for member access', () => {
+    const files = [
+      makeFile('src/app.js', `
+        const db = require('./db')
+        db.query('SELECT 1')
+      `),
+      makeFile('src/db.js', `
+        function query(sql) {
+          return pool.query(sql)
+        }
+        module.exports = { query }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    // Default CJS require doesn't resolve to a function (it's an object).
+    // But the individual functions from the target file are registered in functionDefs.
+    expect(index.functionDefs.has('src/db.js:query')).toBe(true)
+    // The `const db = require('./db')` resolves `db` as a default import;
+    // since db.js has no function called 'default', this is undefined.
+    // Member access `db.query()` would be resolved via namespace resolution.
+  })
+})
+
+// ============================================================================
+// Namespace Imports
+// ============================================================================
+
+describe('Cross-File Index: Namespace imports', () => {
+  it('resolves namespace import: import * as db then db.query()', () => {
+    const files = [
+      makeFile('src/routes.ts', `
+        import * as db from './database'
+        function handler(req, res) {
+          db.query(req.body)
+        }
+      `),
+      makeFile('src/database.ts', `
+        export function query(sql) {
+          return pool.query(sql)
+        }
+        export function connect() {
+          return pool.connect()
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const queryDef = index.resolveImport.get('src/routes.ts:db.query')
+    expect(queryDef).toBeDefined()
+    expect(queryDef!.filePath).toBe('src/database.ts')
+    expect(queryDef!.functionName).toBe('query')
+
+    const connectDef = index.resolveImport.get('src/routes.ts:db.connect')
+    expect(connectDef).toBeDefined()
+    expect(connectDef!.functionName).toBe('connect')
+  })
+})
+
+// ============================================================================
+// Path Aliases (@/)
+// ============================================================================
+
+describe('Cross-File Index: Path aliases', () => {
+  it('resolves @/ alias imports', () => {
+    const files = [
+      makeFile('src/routes/users.ts', `
+        import { getUser } from '@/services/user-service'
+        function handler(req, res) {
+          getUser(req.params.id)
+        }
+      `),
+      makeFile('src/services/user-service.ts', `
+        export function getUser(id) {
+          return db.findById(id)
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const def = index.resolveImport.get('src/routes/users.ts:getUser')
+    expect(def).toBeDefined()
+    expect(def!.filePath).toBe('src/services/user-service.ts')
+    expect(def!.functionName).toBe('getUser')
+  })
+})
+
+// ============================================================================
+// Function Definition Registry
+// ============================================================================
+
+describe('Cross-File Index: functionDefs registry', () => {
+  it('registers all functions from all files', () => {
+    const files = [
+      makeFile('src/a.ts', `
+        export function alpha(x) { return x }
+        function beta() { return 1 }
+      `),
+      makeFile('src/b.ts', `
+        export function gamma(y) { return y * 2 }
+        const delta = (z) => z + 1
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    expect(index.functionDefs.has('src/a.ts:alpha')).toBe(true)
+    expect(index.functionDefs.has('src/a.ts:beta')).toBe(true)
+    expect(index.functionDefs.has('src/b.ts:gamma')).toBe(true)
+    expect(index.functionDefs.has('src/b.ts:delta')).toBe(true)
+  })
+
+  it('captures parameter names correctly', () => {
+    const files = [
+      makeFile('src/service.ts', `
+        export function processData(input, options, callback) {
+          callback(transform(input, options))
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const def = index.functionDefs.get('src/service.ts:processData')
+    expect(def).toBeDefined()
+    expect(def!.params).toEqual(['input', 'options', 'callback'])
+  })
+
+  it('detects async functions', () => {
+    const files = [
+      makeFile('src/api.ts', `
+        export async function fetchData(url) {
+          return fetch(url)
+        }
+        export function syncOp(x) {
+          return x
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const asyncDef = index.functionDefs.get('src/api.ts:fetchData')
+    expect(asyncDef).toBeDefined()
+    expect(asyncDef!.isAsync).toBe(true)
+
+    const syncDef = index.functionDefs.get('src/api.ts:syncOp')
+    expect(syncDef).toBeDefined()
+    expect(syncDef!.isAsync).toBe(false)
+  })
+
+  it('tracks arrow function definitions', () => {
+    const files = [
+      makeFile('src/utils.ts', `
+        export const transform = (data) => {
+          return data.map(x => x * 2)
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const def = index.functionDefs.get('src/utils.ts:transform')
+    expect(def).toBeDefined()
+    expect(def!.params).toContain('data')
+  })
+})
+
+// ============================================================================
+// Call Site Tracking (calledFrom) — REMOVED
+// calledFrom construction was removed in Phase 8 perf fix (dead code).
+// The calledFrom field remains on CrossFileIndex for backward compat but is always empty.
+// ============================================================================
+
+describe('Cross-File Index: calledFrom is empty (Step 3 removed)', () => {
+  it('returns empty calledFrom map', () => {
+    const files = [
+      makeFile('src/routes.ts', `
+        import { query } from './db'
+        function handler(req, res) {
+          const result = query(req.body.sql)
+          res.json(result)
+        }
+      `),
+      makeFile('src/db.ts', `
+        export function query(sql) {
+          return pool.execute(sql)
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+    expect(index.calledFrom.size).toBe(0)
+  })
+})
+
+// ============================================================================
+// Edge Cases
+// ============================================================================
+
+describe('Cross-File Index: Edge cases', () => {
+  it('handles unresolvable imports gracefully (node_modules)', () => {
+    const files = [
+      makeFile('src/app.ts', `
+        import express from 'express'
+        const app = express()
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    // No crash, and no resolution for express (it's from node_modules)
+    const def = index.resolveImport.get('src/app.ts:express')
+    expect(def).toBeUndefined()
+  })
+
+  it('handles circular imports without infinite loop', () => {
+    const files = [
+      makeFile('src/a.ts', `
+        import { b } from './b'
+        export function a() { return b() }
+      `),
+      makeFile('src/b.ts', `
+        import { a } from './a'
+        export function b() { return a() }
+      `),
+    ]
+
+    // Should not infinite loop
+    const index = buildIndex(files)
+
+    // Both functions should be in the registry
+    expect(index.functionDefs.has('src/a.ts:a')).toBe(true)
+    expect(index.functionDefs.has('src/b.ts:b')).toBe(true)
+  })
+
+  it('handles files with no functions', () => {
+    const files = [
+      makeFile('src/constants.ts', `
+        export const API_URL = 'https://api.example.com'
+        export const MAX_RETRIES = 3
+      `),
+      makeFile('src/app.ts', `
+        import { API_URL } from './constants'
+        console.log(API_URL)
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    // No crash, constants are not functions
+    const def = index.resolveImport.get('src/app.ts:API_URL')
+    expect(def).toBeUndefined()
+  })
+
+  it('handles empty files', () => {
+    const files = [
+      makeFile('src/empty.ts', ''),
+      makeFile('src/app.ts', `
+        import { foo } from './empty'
+      `),
+    ]
+
+    const index = buildIndex(files)
+    expect(index.functionDefs.size).toBe(0)
+  })
+
+  it('handles class methods as function definitions', () => {
+    const files = [
+      makeFile('src/routes.ts', `
+        import { UserService } from './user-service'
+        function handler(req, res) {
+          const svc = new UserService()
+          svc.findById(req.params.id)
+        }
+      `),
+      makeFile('src/user-service.ts', `
+        export class UserService {
+          findById(id) {
+            return db.query('SELECT * FROM users WHERE id = ' + id)
+          }
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    // Class method should be registered as ClassName.methodName
+    const def = index.functionDefs.get('src/user-service.ts:UserService.findById')
+    expect(def).toBeDefined()
+    expect(def!.params).toContain('id')
+  })
+
+  it('handles multiple importers of same function', () => {
+    const files = [
+      makeFile('src/a.ts', `
+        import { helper } from './shared'
+        function doA() { helper('a') }
+      `),
+      makeFile('src/b.ts', `
+        import { helper } from './shared'
+        function doB() { helper('b') }
+      `),
+      makeFile('src/shared.ts', `
+        export function helper(data) {
+          console.log(data)
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    // Both files should resolve to the same definition
+    const defA = index.resolveImport.get('src/a.ts:helper')
+    const defB = index.resolveImport.get('src/b.ts:helper')
+    expect(defA).toBeDefined()
+    expect(defB).toBeDefined()
+    expect(defA!.filePath).toBe('src/shared.ts')
+    expect(defB!.filePath).toBe('src/shared.ts')
+  })
+
+  it('resolves through a deep re-export chain up to 5 hops', () => {
+    const files = [
+      makeFile('src/app.ts', `
+        import { deepFn } from './l1'
+        deepFn()
+      `),
+      makeFile('src/l1.ts', `export { deepFn } from './l2'`),
+      makeFile('src/l2.ts', `export { deepFn } from './l3'`),
+      makeFile('src/l3.ts', `export { deepFn } from './l4'`),
+      makeFile('src/l4.ts', `export { deepFn } from './l5'`),
+      makeFile('src/l5.ts', `
+        export function deepFn() {
+          return 'deep'
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const def = index.resolveImport.get('src/app.ts:deepFn')
+    expect(def).toBeDefined()
+    expect(def!.filePath).toBe('src/l5.ts')
+  })
+
+  it('handles mixed export styles in same file', () => {
+    const files = [
+      makeFile('src/consumer.ts', `
+        import { alpha, beta } from './mixed'
+        alpha()
+        beta()
+      `),
+      makeFile('src/mixed.ts', `
+        export function alpha() { return 1 }
+        const beta = () => 2
+        export { beta }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    const alphaDef = index.resolveImport.get('src/consumer.ts:alpha')
+    expect(alphaDef).toBeDefined()
+    expect(alphaDef!.functionName).toBe('alpha')
+
+    const betaDef = index.resolveImport.get('src/consumer.ts:beta')
+    expect(betaDef).toBeDefined()
+    expect(betaDef!.functionName).toBe('beta')
+  })
+})
+
+// ============================================================================
+// Integration: Real-world patterns
+// ============================================================================
+
+describe('Cross-File Index: Real-world patterns', () => {
+  it('resolves route -> service -> repository pattern', () => {
+    const files = [
+      makeFile('src/routes/users.ts', `
+        import { createUser } from '../services/user-service'
+        function handler(req, res) {
+          const result = createUser(req.body)
+          res.json(result)
+        }
+      `),
+      makeFile('src/services/user-service.ts', `
+        import { insertUser } from '../repositories/user-repo'
+        export function createUser(data) {
+          return insertUser(data)
+        }
+      `),
+      makeFile('src/repositories/user-repo.ts', `
+        export function insertUser(data) {
+          return db.query('INSERT INTO users VALUES (' + data.name + ')')
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    // Routes file should resolve createUser -> service
+    const createUserDef = index.resolveImport.get('src/routes/users.ts:createUser')
+    expect(createUserDef).toBeDefined()
+    expect(createUserDef!.filePath).toBe('src/services/user-service.ts')
+
+    // Service file should resolve insertUser -> repository
+    const insertUserDef = index.resolveImport.get('src/services/user-service.ts:insertUser')
+    expect(insertUserDef).toBeDefined()
+    expect(insertUserDef!.filePath).toBe('src/repositories/user-repo.ts')
+  })
+
+  it('resolves Express-style module structure', () => {
+    const files = [
+      makeFile('src/server.ts', `
+        import { loginHandler } from './routes/auth'
+        app.post('/login', loginHandler)
+      `),
+      makeFile('src/routes/auth.ts', `
+        import { validateCredentials } from '../services/auth-service'
+        export function loginHandler(req, res) {
+          const result = validateCredentials(req.body.username, req.body.password)
+          res.json(result)
+        }
+      `),
+      makeFile('src/services/auth-service.ts', `
+        export function validateCredentials(username, password) {
+          return db.query('SELECT * FROM users WHERE username = ' + username)
+        }
+      `),
+    ]
+
+    const index = buildIndex(files)
+
+    // Server resolves loginHandler
+    const handlerDef = index.resolveImport.get('src/server.ts:loginHandler')
+    expect(handlerDef).toBeDefined()
+    expect(handlerDef!.filePath).toBe('src/routes/auth.ts')
+    expect(handlerDef!.params).toEqual(['req', 'res'])
+
+    // Auth route resolves validateCredentials
+    const validateDef = index.resolveImport.get('src/routes/auth.ts:validateCredentials')
+    expect(validateDef).toBeDefined()
+    expect(validateDef!.filePath).toBe('src/services/auth-service.ts')
+    expect(validateDef!.params).toEqual(['username', 'password'])
+  })
+})