@oclif/plugin-update 4.7.44 → 4.7.46

package/README.md

@@ -81,7 +81,7 @@ EXAMPLES
     $ oclif-example update --available
 ```
 
-_See code: [src/commands/update.ts](https://github.com/oclif/plugin-update/blob/4.7.44/src/commands/update.ts)_
+_See code: [src/commands/update.ts](https://github.com/oclif/plugin-update/blob/4.7.46/src/commands/update.ts)_
 <!-- commandsstop -->
 
 # Contributing

package/dist/update.js

@@ -8,7 +8,7 @@ import { mkdir, readdir, readFile, rm, stat, symlink, utimes, writeFile } from '
 import { basename, dirname, join } from 'node:path';
 import { ProxyAgent } from 'proxy-agent';
 import { Extractor } from './tar.js';
-import { ls, wait } from './util.js';
+import { ls } from './util.js';
 const debug = makeDebug('oclif:update');
 const filesize = (n) => {
     const [num, suffix] = fileSize(n, { output: 'array' });
@@ -144,8 +144,12 @@ get_script_dir () {
   DIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
   echo "$DIR"
 }
-DIR=$(get_script_dir)
-${binPathEnvVar}="\$DIR/${bin}" ${redirectedEnvVar}=1 "$DIR/../${version}/bin/${bin}" "$@"
+
+# Ensure everything is read at once before execution to avoid race conditions when updating versions
+{
+  DIR=$(get_script_dir)
+  ${binPathEnvVar}="\$DIR/${bin}" ${redirectedEnvVar}=1 "$DIR/../${version}/bin/${bin}" "$@"
+}; exit
 `;
             /* eslint-enable no-useless-escape */
             await writeFile(dst, body, { mode: 0o755 });
@@ -283,25 +287,52 @@ const s3VersionManifestKey = ({ config, hash, version }) => {
     const s3SubDir = composeS3SubDir(config);
     return join(s3SubDir, 'versions', version, hash, `${bin}-v${version}-${hash}-${determinePlatform(config)}-${arch}-buildmanifest`);
 };
-// when autoupdating, wait until the CLI isn't active
-const debounce = async (cacheDir) => {
-    let output = false;
+// When autoupdating, wait until the CLI isn't active (lastrun mtime > 1 hour old).
+//
+// IMPORTANT: every CLI invocation touches lastrun before this function runs, so
+// while the user is actively using the CLI, `lastrun + 1hr` keeps shifting
+// forward and this wait never naturally resolves. The previous implementation
+// recursed forever in that scenario, leaving each spawned autoupdate child
+// pinned in memory as a full node process for the entire active session. When
+// combined with the race documented in hooks/init.ts (which could spawn
+// multiple such children per debounce window), the leaked children compounded
+// until OOM on machines doing heavy CLI setup.
+//
+// Fix: cap the wait at a sensible wall-clock max. If the user is still active
+// after that, abandon this autoupdate run — the next CLI invocation will fire
+// a new one when it's again "needed".
+const MAX_DEBOUNCE_WAIT_MS = 6 * 60 * 60 * 1000; // 6 hours
+const DEBOUNCE_POLL_INTERVAL_MS = 60 * 1000; // 1 minute
+const debounce = (cacheDir) => {
     const lastrunfile = join(cacheDir, 'lastrun');
-    const m = await mtime(lastrunfile);
-    m.setHours(m.getHours() + 1);
-    if (m > new Date()) {
-        const msg = `waiting until ${m.toISOString()} to update`;
-        if (output) {
-            debug(msg);
-        }
-        else {
-            ux.stdout(msg);
-            output = true;
-        }
-        await wait(60 * 1000); // wait 1 minute
-        return debounce(cacheDir);
-    }
-    ux.stdout('time to update');
+    const startedAt = Date.now();
+    let announced = false;
+    return new Promise((resolve) => {
+        const check = async () => {
+            const m = await mtime(lastrunfile);
+            m.setHours(m.getHours() + 1);
+            if (m <= new Date()) {
+                ux.stdout('time to update');
+                resolve();
+                return;
+            }
+            if (Date.now() - startedAt >= MAX_DEBOUNCE_WAIT_MS) {
+                ux.stdout('autoupdate: debounce wait exceeded; abandoning this run');
+                resolve();
+                return;
+            }
+            const msg = `waiting until ${m.toISOString()} to update`;
+            if (announced) {
+                debug(msg);
+            }
+            else {
+                ux.stdout(msg);
+                announced = true;
+            }
+            setTimeout(check, DEBOUNCE_POLL_INTERVAL_MS);
+        };
+        check();
+    });
 };
 const setChannel = async (channel, dataDir) => writeFile(join(dataDir, 'channel'), channel, 'utf8');
 const fetchChannelManifest = async (channel, config) => {

package/oclif.manifest.json

@@ -106,5 +106,5 @@
       ]
     }
   },
-  "version": "4.7.44"
+  "version": "4.7.46"
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oclif/plugin-update",
-  "version": "4.7.44",
+  "version": "4.7.46",
   "author": "Salesforce",
   "bugs": "https://github.com/oclif/plugin-update/issues",
   "dependencies": {