@oclif/core 1.11.0 → 1.12.0

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [1.12.0](https://github.com/oclif/core/compare/v1.11.0...v1.12.0) (2022-07-20)
+
+
+### Features
+
+* improve the instantiation of global flags ([#445](https://github.com/oclif/core/issues/445)) ([d264535](https://github.com/oclif/core/commit/d2645358ccf1cddd0bb65d236e73ecf4c5ac7c0c))
+
 ## [1.11.0](https://github.com/oclif/core/compare/v1.10.0...v1.11.0) (2022-07-18)
 
 

package/lib/command.d.ts

@@ -55,7 +55,9 @@ export default abstract class Command {
      */
     static examples: Interfaces.Example[];
     static parserOptions: {};
-    static enableJsonFlag: boolean;
+    static _enableJsonFlag: boolean;
+    static get enableJsonFlag(): boolean;
+    static set enableJsonFlag(value: boolean);
     /**
      * instantiate and run the command
      * @param {Interfaces.Command.Class} this Class

package/lib/command.js

@@ -39,19 +39,25 @@ class Command {
             this.debug = () => { };
         }
     }
+    static get enableJsonFlag() {
+        return this._enableJsonFlag;
+    }
+    static set enableJsonFlag(value) {
+        this._enableJsonFlag = value;
+        if (value)
+            this.globalFlags = jsonFlag;
+    }
     static get globalFlags() {
         return this._globalFlags;
     }
     static set globalFlags(flags) {
-        this._globalFlags = this.enableJsonFlag ?
-            Object.assign({}, jsonFlag, this.globalFlags, flags) :
-            Object.assign({}, this.globalFlags, flags);
+        this._globalFlags = Object.assign({}, this.globalFlags, flags);
+        this.flags = this.globalFlags;
     }
     static get flags() {
         return this._flags;
     }
     static set flags(flags) {
-        this.globalFlags = {};
         this._flags = Object.assign({}, this.globalFlags, flags);
     }
     get ctor() {
@@ -123,7 +129,7 @@ class Command {
             options = this.constructor;
         const opts = { context: this, ...options };
         // the spread operator doesn't work with getters so we have to manually add it here
-        opts.flags = options === null || options === void 0 ? void 0 : options.flags;
+        opts.flags = Object.assign({}, options === null || options === void 0 ? void 0 : options.flags, options === null || options === void 0 ? void 0 : options.globalFlags);
         return Parser.parse(argv, opts);
     }
     async catch(err) {
@@ -169,7 +175,7 @@ Command.aliases = [];
 Command.strict = true;
 Command.parse = true;
 Command.parserOptions = {};
-Command.enableJsonFlag = false;
+Command._enableJsonFlag = false;
 // eslint-disable-next-line valid-jsdoc
 /**
  * instantiate and run the command

package/lib/interfaces/parser.d.ts

@@ -160,6 +160,7 @@ export declare type EnumFlagOptions<T> = Partial<OptionFlag<T>> & {
 export declare type Flag<T> = BooleanFlag<T> | OptionFlag<T>;
 export declare type Input<TFlags extends FlagOutput> = {
     flags?: FlagInput<TFlags>;
+    globalFlags?: FlagInput<TFlags>;
     args?: ArgInput;
     strict?: boolean;
     context?: any;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@oclif/core",
   "description": "base library for oclif CLIs",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "author": "Salesforce",
   "bugs": "https://github.com/oclif/core/issues",
   "dependencies": {