@oclif/core 0.5.34 → 0.5.38

package/CHANGELOG.md

@@ -2,6 +2,34 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [0.5.38](https://github.com/oclif/core/compare/v0.5.37...v0.5.38) (2021-09-15)
+
+
+### Features
+
+* have --json global flag disabled by default ([#252](https://github.com/oclif/core/issues/252)) ([c2a7799](https://github.com/oclif/core/commit/c2a7799ce036697c77917a830a12bce5db6c68a7))
+
+### [0.5.37](https://github.com/oclif/core/compare/v0.5.36...v0.5.37) (2021-09-15)
+
+
+### Bug Fixes
+
+* don't warn on hook errors ([#246](https://github.com/oclif/core/issues/246)) ([ba4be4b](https://github.com/oclif/core/commit/ba4be4b010f5f861e44b43ac31f33ce4b749982e))
+
+### [0.5.36](https://github.com/oclif/core/compare/v0.5.35...v0.5.36) (2021-09-14)
+
+
+### Bug Fixes
+
+* move ctor for command help class to its own function ([#244](https://github.com/oclif/core/issues/244)) ([26f2445](https://github.com/oclif/core/commit/26f24457c71276c38f86821c2b1498ecb8e4e2a4))
+
+### [0.5.35](https://github.com/oclif/core/compare/v0.5.34...v0.5.35) (2021-09-08)
+
+
+### Bug Fixes
+
+* clear hook timeout ([#243](https://github.com/oclif/core/issues/243)) ([0c32c65](https://github.com/oclif/core/commit/0c32c65c5c30b02bc3ea6e36b0598adfc5b23ec1))
+
 ### [0.5.34](https://github.com/oclif/core/compare/v0.5.33...v0.5.34) (2021-08-30)
 
 

package/lib/command.d.ts

@@ -54,7 +54,7 @@ export default abstract class Command {
      */
     static examples: Interfaces.Example[];
     static parserOptions: {};
-    static disableJsonFlag: boolean | undefined;
+    static enableJsonFlag: boolean;
     /**
      * instantiate and run the command
      * @param {Interfaces.Command.Class} this Class

package/lib/command.js

@@ -38,7 +38,7 @@ class Command {
         return this._flags;
     }
     static set flags(flags) {
-        this._flags = this.disableJsonFlag || settings_1.settings.disableJsonFlag ? flags : Object.assign({}, Command.globalFlags, flags);
+        this._flags = this.enableJsonFlag || settings_1.settings.enableJsonFlag ? Object.assign({}, Command.globalFlags, flags) : flags;
     }
     get ctor() {
         return this.constructor;
@@ -81,7 +81,7 @@ class Command {
         }
     }
     jsonEnabled() {
-        return !this.ctor.disableJsonFlag && this.argv.includes('--json');
+        return this.ctor.enableJsonFlag && this.argv.includes('--json');
     }
     async init() {
         this.debug('init version: %s argv: %o', this.ctor._base, this.argv);
@@ -149,6 +149,7 @@ Command.aliases = [];
 Command.strict = true;
 Command.parse = true;
 Command.parserOptions = {};
+Command.enableJsonFlag = false;
 // eslint-disable-next-line valid-jsdoc
 /**
  * instantiate and run the command

package/lib/config/config.js

@@ -137,8 +137,16 @@ class Config {
             return Object.values(m).find((m) => typeof m === 'function');
         };
         const withTimeout = async (ms, promise) => {
-            const timeout = new Promise((_, reject) => setTimeout(() => reject(new Error(`Timed out after ${ms} ms.`)), ms));
-            return Promise.race([promise, timeout]);
+            let id;
+            const timeout = new Promise((_, reject) => {
+                id = setTimeout(() => {
+                    reject(new Error(`Timed out after ${ms} ms.`));
+                }, ms).unref();
+            });
+            return Promise.race([promise, timeout]).then(result => {
+                clearTimeout(id);
+                return result;
+            });
         };
         const successes = [];
         const failures = [];
@@ -173,10 +181,9 @@ class Config {
                     debug('done');
                 }
                 catch (error) {
-                    failures.push({ plugin: p, error });
+                    failures.push({ plugin: p, error: error });
                     if (error && error.oclif && error.oclif.exit !== undefined)
                         throw error;
-                    this.warn(error, `runHook ${event}`);
                 }
             }
         }

package/lib/help/index.d.ts

@@ -30,6 +30,7 @@ export declare class Help extends HelpBase {
     protected showTopicHelp(topic: Interfaces.Topic): Promise<void>;
     protected formatRoot(): string;
     protected formatCommand(command: Interfaces.Command): string;
+    protected getCommandHelpClass(command: Interfaces.Command): CommandHelp;
     protected formatCommands(commands: Interfaces.Command[]): string;
     protected summary(c: Interfaces.Command): string | undefined;
     protected description(c: Interfaces.Command): string;

package/lib/help/index.js

@@ -73,6 +73,7 @@ class Help extends HelpBase {
         return topics;
     }
     async showHelp(argv) {
+        argv = argv.filter(arg => !getHelpFlagAdditions(this.config).includes(arg));
         if (this.config.topicSeparator !== ':')
             argv = util_2.standardizeIDFromArgv(argv, this.config);
         const subject = getHelpSubject(argv, this.config);
@@ -172,9 +173,12 @@ class Help extends HelpBase {
             command.id = command.id.replace(/:/g, this.config.topicSeparator);
             command.aliases = command.aliases && command.aliases.map(a => a.replace(/:/g, this.config.topicSeparator));
         }
-        const help = new this.CommandHelpClass(command, this.config, this.opts);
+        const help = this.getCommandHelpClass(command);
         return help.generate();
     }
+    getCommandHelpClass(command) {
+        return new this.CommandHelpClass(command, this.config, this.opts);
+    }
     formatCommands(commands) {
         if (commands.length === 0)
             return '';

package/lib/interfaces/hooks.d.ts

@@ -90,7 +90,7 @@ export declare namespace Hook {
             plugin: Plugin;
         }>;
         failures: Array<{
-            error: typeof Error;
+            error: Error;
             plugin: Plugin;
         }>;
     }

package/lib/main.js

@@ -49,7 +49,6 @@ async function run(argv = process.argv.slice(2), options) {
     }
     // display help version if applicable
     if (exports.helpAddition(argv, config)) {
-        argv = argv.filter(arg => !help_1.getHelpFlagAdditions(config).includes(arg));
         const Help = await help_1.loadHelpClass(config);
         const help = new Help(config, config.pjson.helpOptions);
         await help.showHelp(argv);

package/lib/settings.d.ts

@@ -31,8 +31,8 @@ export declare type Settings = {
      */
     tsnodeEnabled?: boolean;
     /**
-     * Disable the --json flag for all commands
+     * Enable the --json flag for all commands
      */
-    disableJsonFlag?: boolean;
+    enableJsonFlag?: boolean;
 };
 export declare const settings: Settings;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@oclif/core",
   "description": "base library for oclif CLIs",
-  "version": "0.5.34",
+  "version": "0.5.38",
   "author": "Jeff Dickey @jdxcode",
   "bugs": "https://github.com/oclif/core/issues",
   "dependencies": {