@ocap/tx-protocols 1.14.8 → 1.14.9

package/lib/protocols/asset/update.js

@@ -1,3 +1,4 @@
+const deepDiff = require('deep-diff');
 const Error = require('@ocap/util/lib/error');
 const Joi = require('@ocap/validator');
 const { Runner, pipes } = require('@ocap/tx-pipeline');
@@ -18,19 +19,23 @@ const schema = Joi.object({
   moniker: Joi.string().min(2).max(255).required(),
   data: Joi.any().optional(),
 }).options({ stripUnknown: true, noDefaults: false });
-runner.use(({ itx }, next) => {
+runner.use((context, next) => {
+  const { itx } = context;
   const { error } = schema.validate(itx);
   if (error) {
     return next(new Error('INVALID_TX', `Invalid itx: ${error.message}`));
   }
+
+  context.newData = decodeAnySafe(itx.data);
   return next();
 });
 
-// Ensure asset exist owned by sender and can be modified
-runner.use(pipes.ExtractState({ from: 'itx.address', to: 'assetState', status: 'INVALID_ASSET' }));
+// Ensure asset exist
+runner.use(pipes.ExtractState({ from: 'itx.address', to: 'assetState', status: 'INVALID_ASSET', table: 'asset' }));
+runner.use(pipes.ExtractState({ from: 'assetState.issuer', to: 'issuerState', status: 'OK', table: 'account' }));
 
 // Ensure sender exist
-runner.use(pipes.ExtractState({ from: 'tx.from', to: 'senderState', status: 'INVALID_SENDER_STATE' }));
+runner.use(pipes.ExtractState({ from: 'tx.from', to: 'senderState', status: 'INVALID_SENDER_STATE', table: 'account' })); // prettier-ignore
 runner.use(pipes.VerifyAccountMigration({ senderKey: 'senderState' }));
 
 // Ensure asset owned by sender and can be modified
@@ -46,10 +51,30 @@ runner.use(
   ])
 );
 
+// Ensure we are in append-only mode update proposed by issuer
+runner.use(async (context, next) => {
+  const { itx, newData, senderState, assetState, issuerState } = context;
+  if (issuerState && senderState.address === issuerState.address) {
+    if (itx.moniker !== assetState.moniker) {
+      return next(new Error('FORBIDDEN', 'Asset moniker can only be updated by owner'));
+    }
+    if (newData.type !== assetState.data.type) {
+      return next(new Error('FORBIDDEN', 'Asset data type can only be updated by owner'));
+    }
+    const dataDiff = deepDiff(assetState.data.value, newData.value);
+    const appendOnly = dataDiff.every((x) => x.kind === 'N' || (x.kind === 'A' && x.item.kind === 'N'));
+    if (appendOnly === false) {
+      return next(new Error('APPEND_ONLY', 'Asset data value can only be updated in append only mode'));
+    }
+  }
+
+  return next();
+});
+
 // Update asset state
 runner.use(
   async (context, next) => {
-    const { tx, itx, statedb, senderState, assetState } = context;
+    const { tx, itx, newData, statedb, senderState, assetState } = context;
 
     const [newSenderState, newAssetState] = await Promise.all([
       // update owner state
@@ -62,7 +87,7 @@ runner.use(
       // update asset state
       statedb.asset.update(
         itx.address,
-        asset.update(assetState, { moniker: itx.moniker, data: decodeAnySafe(itx.data) }, context),
+        asset.update(assetState, { moniker: itx.moniker, data: newData }, context),
         context
       ),
     ]);

package/package.json

@@ -3,7 +3,7 @@
   "publishConfig": {
     "access": "public"
   },
-  "version": "1.14.8",
+  "version": "1.14.9",
   "description": "Predefined tx pipeline sets to execute certain type of transactions",
   "main": "lib/index.js",
   "files": [
@@ -21,18 +21,19 @@
   "author": "wangshijun <wangshijun2010@gmail.com> (http://github.com/wangshijun)",
   "license": "MIT",
   "dependencies": {
-    "@arcblock/did": "1.14.8",
-    "@arcblock/did-util": "1.14.8",
-    "@ocap/asset": "1.14.8",
-    "@ocap/mcrypto": "1.14.8",
-    "@ocap/merkle-tree": "1.14.8",
-    "@ocap/message": "1.14.8",
-    "@ocap/state": "1.14.8",
-    "@ocap/tx-pipeline": "1.14.8",
-    "@ocap/util": "1.14.8",
-    "@ocap/validator": "1.14.8",
-    "@ocap/wallet": "1.14.8",
+    "@arcblock/did": "1.14.9",
+    "@arcblock/did-util": "1.14.9",
+    "@ocap/asset": "1.14.9",
+    "@ocap/mcrypto": "1.14.9",
+    "@ocap/merkle-tree": "1.14.9",
+    "@ocap/message": "1.14.9",
+    "@ocap/state": "1.14.9",
+    "@ocap/tx-pipeline": "1.14.9",
+    "@ocap/util": "1.14.9",
+    "@ocap/validator": "1.14.9",
+    "@ocap/wallet": "1.14.9",
     "debug": "^4.3.2",
+    "deep-diff": "^1.0.2",
     "empty-value": "^1.0.1",
     "lodash": "^4.17.21",
     "url-join": "^4.0.1"
@@ -45,5 +46,5 @@
     "jest": "^27.3.1",
     "start-server-and-test": "^1.14.0"
   },
-  "gitHead": "1d41025b5e00840e7cba0887c3b60adc4f388b7a"
+  "gitHead": "19fd75486457b972da40d7d1d043f389738aa1da"
 }