@ocap/state 1.18.137 → 1.18.138

package/lib/states/tx.js

@@ -7,8 +7,12 @@ const camelCase = require('lodash/camelCase');
 const { fromTypeUrl, formatMessage, decodeAny } = require('@ocap/message');
 const { toBase64, BN, isBN } = require('@ocap/util');
 const { getListField } = require('@ocap/util/lib/get-list-field');
+const { CustomError: Error } = require('@ocap/util/lib/error');
+const { getRelatedAddresses } = require('@ocap/util/lib/get-related-addr');
+const { toTypeInfo, types } = require('@arcblock/did');
 
 const ZERO = new BN(0);
+const { RoleType } = types;
 
 // Receiver = Whose asset have net gain
 const getTxReceiver = ({ tx, itx, typeUrl }) => {
@@ -323,6 +327,106 @@ const mergeTxReceipts = (receipts) => {
   return Object.values(merged);
 };
 
+/**
+ * Get list of accounts with migration history
+ * @param {Object} ctx - transaction execution context
+ * @returns {Promise<string[][]>} adress[][]
+ */
+const getAccountMigrationsFromContext = (ctx) => {
+  const migrationAddresses = [];
+  for (const [key, state] of Object.entries(ctx)) {
+    if (key.endsWith('State') && state?.address) {
+      migrationAddresses.push(getRelatedAddresses(state));
+    }
+    if (key.endsWith('States') && Array.isArray(state)) {
+      state.forEach((x) => {
+        if (x?.address) {
+          migrationAddresses.push(getRelatedAddresses(x));
+        }
+      });
+    }
+  }
+  return migrationAddresses;
+};
+
+/**
+ * Group receipts by target
+ * @param {Object[]} receipts - transaction receipts
+ * @returns {Record<string, { address: string, value: BN, action: string }[]>}
+ */
+const groupReceiptsByTarget = (receipts) => {
+  const targets = {};
+
+  for (const { address, changes } of receipts) {
+    for (const { target, value, action } of changes) {
+      if (!targets[target]) {
+        targets[target] = [];
+      }
+      targets[target].push({ address, value: new BN(value), action });
+    }
+  }
+  return targets;
+};
+
+/**
+ * Verify transaction receipts
+ * @param {Object[]} receipts - transaction receipts
+ * @param {String} typeUrl - transaction type
+ * @param {Object} ctx - transaction execution context
+ * @returns {Promise<boolean>}
+ */
+const verifyTxReceipts = (receipts, typeUrl, ctx = {}) => {
+  const targets = groupReceiptsByTarget(receipts);
+  const accountsWithMigration = getAccountMigrationsFromContext(ctx);
+  const skipActions =
+    {
+      MintAssetTx: ['mint', 'consume'],
+      AcquireAssetV2Tx: ['mint', 'consume'],
+      AcquireAssetV3Tx: ['mint', 'consume'],
+      CreateAssetTx: ['create'],
+      CreateTokenTx: ['mint'],
+      CreateRollupBlockTx: ['burn', 'mint'],
+    }[typeUrl] || [];
+
+  for (const [target, changes] of Object.entries(targets)) {
+    // These actions will skip zero-sum calculation
+    const filteredChanges = changes.filter(({ action }) => {
+      if (!skipActions.includes(action)) return true;
+      if (action === 'consume' && toTypeInfo(target).role !== RoleType.ROLE_ASSET) return true;
+      return false;
+    });
+
+    // Ensure token/asset amounts are zero-sum
+    const sum = filteredChanges.reduce((prev, current) => prev.add(current.value), new BN(0));
+    if (!sum.eq(ZERO)) {
+      throw new Error('INVALID_RECEIPTS_VALUE', `Receipts are not zero-sum, target: ${target}, sum: ${sum}`);
+    }
+
+    // Ensure address is unique
+    const accountValue = {};
+    for (const { address, value, action } of filteredChanges) {
+      const accounts = accountsWithMigration.find((x) => x.includes(address)) || [address];
+      for (const account of accounts) {
+        const key = `${action}-${account}`;
+        const existingValue = accountValue[key];
+        if (
+          existingValue &&
+          ((existingValue.gt(ZERO) && value.lt(ZERO)) || (existingValue.lt(ZERO) && value.gt(ZERO)))
+        ) {
+          throw new Error(
+            'INVALID_RECEIPTS_ADDRESS',
+            `Duplicate accounts in receipts, target: ${target}, address: ${address}, action: ${action}`
+          );
+        }
+
+        accountValue[key] = value;
+      }
+    }
+  }
+
+  return true;
+};
+
 /**
  * Create transaction receipts, each receipt has following properties:
  *
@@ -440,6 +544,10 @@ const create = (context, code = 'OK') => {
 
   result.receipts = getTxReceipts(result, context);
 
+  if (code === 'OK') {
+    verifyTxReceipts(result.receipts, typeUrl, context);
+  }
+
   // determine gasPaid
   attachPaidTxGas(result);
 
@@ -475,4 +583,5 @@ module.exports = {
   getTxReceipts,
   mergeTxReceipts,
   attachPaidTxGas,
+  verifyTxReceipts,
 };

package/package.json

@@ -3,7 +3,7 @@
   "publishConfig": {
     "access": "public"
   },
-  "version": "1.18.137",
+  "version": "1.18.138",
   "description": "",
   "main": "lib/index.js",
   "files": [
@@ -12,24 +12,28 @@
   "scripts": {
     "lint": "eslint tests lib",
     "lint:fix": "eslint --fix tests lib",
+    "start": "node tools/start-chain.js",
     "test": "jest --forceExit --detectOpenHandles",
-    "coverage": "npm run test -- --coverage"
+    "test:ci": "jest --forceExit --detectOpenHandles --coverage",
+    "coverage": "start-server-and-test start http://127.0.0.1:4001 test:ci"
   },
   "dependencies": {
-    "@arcblock/did": "1.18.137",
-    "@arcblock/validator": "1.18.137",
-    "@ocap/contract": "1.18.137",
-    "@ocap/mcrypto": "1.18.137",
-    "@ocap/message": "1.18.137",
-    "@ocap/util": "1.18.137",
+    "@arcblock/did": "1.18.138",
+    "@arcblock/validator": "1.18.138",
+    "@ocap/contract": "1.18.138",
+    "@ocap/mcrypto": "1.18.138",
+    "@ocap/message": "1.18.138",
+    "@ocap/util": "1.18.138",
+    "@ocap/wallet": "1.18.138",
     "bloom-filters": "^1.3.9",
     "lodash": "^4.17.21"
   },
   "devDependencies": {
-    "jest": "^29.7.0"
+    "jest": "^29.7.0",
+    "start-server-and-test": "^1.14.0"
   },
   "keywords": [],
   "author": "wangshijun <wangshijun2010@gmail.com> (http://github.com/wangshijun)",
   "license": "MIT",
-  "gitHead": "e9ebb514f4dfde8347992f0ab275b9d269d443c5"
+  "gitHead": "61ab154a7f575a2e3eb1c9ce86e1cdd2ce18e928"
 }