@obsunified/collector 2.2.3 → 2.3.0

package/src/lib/eval-cases-store.test.ts

@@ -91,7 +91,7 @@ describe("EvalCasesStore", () => {
 				expect.objectContaining({
 					entityKind: "span",
 					entityId: "trace-1:span-1",
-					route: "#/traces/trace-1#span=span-1",
+					route: "#/traces?trace=trace-1&span=span-1",
 				}),
 			]),
 		);

package/src/lib/eval-cases-store.ts

@@ -3,7 +3,10 @@ import type {
 	EvidenceReferenceContract as EvidenceReferenceContractType,
 	JsonValue,
 } from "@obsunified/types";
-import { EVIDENCE_REFERENCE_CONTRACT } from "@obsunified/types";
+import {
+	dashboardRouteToHref,
+	EVIDENCE_REFERENCE_CONTRACT,
+} from "@obsunified/types";
 import { sourceLinkEvidenceReferences } from "./evidence-references";
 import { randomHex } from "./hash";
 import { parseJsonArray, parseJsonValue } from "./json";
@@ -345,7 +348,10 @@ const evalCaseEvidenceReferences = (evalCase: EvalCase): EvidenceReference[] =>
 			sourceLabel: `Eval case "${evalCase.name}"`,
 			sourceId: evalCase.id,
 			sourceKind: "eval_case",
-			sourceRoute: `#/evaluations?case=${encodeURIComponent(evalCase.id)}`,
+			sourceRoute: dashboardRouteToHref({
+				tab: "evaluations",
+				evaluationId: evalCase.id,
+			}),
 			sourceName: evalCase.name,
 		},
 		evalCase,
@@ -384,7 +390,10 @@ const evalRunEvidenceReferences = (run: EvalRun): EvidenceReference[] => {
 			sourceLabel: `Eval run "${run.id}"`,
 			sourceId: run.id,
 			sourceKind: "eval_run",
-			sourceRoute: `#/evaluations?run=${encodeURIComponent(run.id)}`,
+			sourceRoute: dashboardRouteToHref({
+				tab: "evaluations",
+				evaluationId: run.evalCaseId ?? run.id,
+			}),
 			sourceName: run.sourceEvalCase.name,
 		},
 		run.sourceEvalCase,
@@ -413,7 +422,10 @@ const rowToEvalRun = (row: EvalRunRow): EvalRun => {
 				sourceLabel: `Eval case "${sourceEvalCase.name}"`,
 				sourceId: sourceEvalCase.id,
 				sourceKind: "eval_case",
-				sourceRoute: `#/evaluations?case=${encodeURIComponent(sourceEvalCase.id)}`,
+				sourceRoute: dashboardRouteToHref({
+					tab: "evaluations",
+					evaluationId: sourceEvalCase.id,
+				}),
 				sourceName: sourceEvalCase.name,
 			},
 			sourceEvalCase,

package/src/lib/evidence-references.ts

@@ -10,9 +10,10 @@ import type {
 	EvidenceReference,
 	JsonValue,
 } from "@obsunified/types";
+import { dashboardRouteToHref, hrefForEntity } from "@obsunified/types";
 
 const analysisRoute = (analysisId: string) =>
-	`#/investigate/${encodeURIComponent(analysisId)}`;
+	dashboardRouteToHref({ tab: "investigate", investigationId: analysisId });
 
 export const analysisEvidenceReference = (
 	evidence: AskEvidence,
@@ -103,10 +104,10 @@ const valueFor = (
 };
 
 const traceRoute = (traceId: string) =>
-	`#/traces/${encodeURIComponent(traceId)}`;
+	dashboardRouteToHref({ tab: "traces", traceId });
 
 const spanRoute = (traceId: string, spanId: string) =>
-	`${traceRoute(traceId)}#span=${encodeURIComponent(spanId)}`;
+	dashboardRouteToHref({ tab: "traces", traceId, spanId });
 
 export const evidenceRouteFor = (
 	entityKind: EvidenceEntityKind,
@@ -117,41 +118,48 @@ export const evidenceRouteFor = (
 		case "analysis":
 			return analysisRoute(entityId);
 		case "action":
-			return `#/actions/${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({ tab: "actions", actionId: entityId });
 		case "alert":
-			return `#/alerts?alert=${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({ tab: "alerts", alertId: entityId });
 		case "agent_run":
-			return `#/agent-runs/${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({ tab: "agent-runs", agentRunId: entityId });
 		case "ai_call":
-			return `#/ai/calls/${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({ tab: "ai", aiCallId: entityId });
 		case "eval":
-			return `#/evals/${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({
+				tab: "evaluations",
+				evaluationId: entityId,
+			});
 		case "log":
-			return `#/logs?id=${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({ tab: "logs", logId: entityId });
 		case "profile":
-			return traceId
-				? `#/profiles/${encodeURIComponent(entityId)}?trace_id=${encodeURIComponent(traceId)}`
-				: `#/profiles/${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({
+				tab: "profiles",
+				profileId: entityId,
+				...(traceId ? { traceId } : {}),
+			});
 		case "replay":
-			return `#/replay?session=${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({ tab: "replay", sessionId: entityId });
 		case "service":
-			return `#/traces?service=${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({ tab: "service-map", service: entityId });
 		case "span": {
 			const [tracePart, spanPart] = entityId.split(":");
-			return spanPart ? spanRoute(tracePart, spanPart) : `#/spans/${entityId}`;
+			return spanPart
+				? spanRoute(tracePart, spanPart)
+				: hrefForEntity("span", entityId, traceId ? { traceId } : undefined);
 		}
 		case "tool_call":
-			return `#/tool-calls/${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({ tab: "tool-calls", toolCallId: entityId });
 		case "trace":
 			return traceRoute(entityId);
 		case "docs":
-			return entityId.startsWith("#/") ? entityId : `#/docs/${entityId}`;
+			return hrefForEntity("docs", entityId);
 		case "change":
-			return `#/changes/${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({ tab: "changes", changeId: entityId });
 		case "finding":
-			return `#/findings/${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({ tab: "findings", findingId: entityId });
 		case "incident":
-			return `#/incidents/${encodeURIComponent(entityId)}`;
+			return dashboardRouteToHref({ tab: "incidents", incidentId: entityId });
 	}
 	const exhaustive: never = entityKind;
 	return exhaustive;
@@ -232,7 +240,7 @@ const instrumentationGapEvidenceReferences = (
 			const thresholdText = thresholdVersion
 				? ` Thresholds: ${thresholdVersion}.`
 				: "";
-			const docsRoute = "#/docs/howto/ebpf";
+			const docsRoute = hrefForEntity("docs", "howto/ebpf");
 			return {
 				evidenceId: `analysis:${result.analysisId}:instrumentation-gap:${index}:span:${entityId}`,
 				entityKind: "span",
@@ -262,7 +270,7 @@ const instrumentationGapEvidenceReferences = (
 						label: "Open trace gap data",
 						entityKind: "trace",
 						entityId: traceId,
-						route: `${traceRoute(traceId)}/gaps`,
+						route: traceRoute(traceId),
 						reason:
 							"Review all structured instrumentation blindspots for this trace.",
 					},

package/src/lib/stage6.test.ts

@@ -201,7 +201,7 @@ describe("AlertsStore.listEvaluations evidence references", () => {
 				evidenceId: "alert:rule-1:rule",
 				entityKind: "alert",
 				entityId: "rule-1",
-				route: "#/alerts?alert=rule-1",
+				route: "#/alerts?id=rule-1",
 				source: "alerts.rule_evaluation_preview",
 			}),
 			expect.objectContaining({

package/src/migrations/parity.test.ts

@@ -8,6 +8,7 @@
 
 import { readdirSync, readFileSync } from "node:fs";
 import path from "node:path";
+import { DatabaseSync } from "node:sqlite";
 import { fileURLToPath } from "node:url";
 import { describe, expect, it } from "vitest";
 
@@ -34,13 +35,74 @@ const RETENTION_TABLES = [
 	"remediation_proposals",
 ];
 
+export function checkMigrationFilePairings(
+	sqliteFiles: readonly string[],
+	postgresFiles: readonly string[],
+): string[] {
+	const errors: string[] = [];
+	const sqliteSet = new Set(sqliteFiles);
+	const pgSet = new Set(postgresFiles);
+	for (const f of sqliteFiles) {
+		if (!pgSet.has(f)) {
+			errors.push(`Missing Postgres migration counterpart for ${f}`);
+		}
+	}
+	for (const f of postgresFiles) {
+		if (!sqliteSet.has(f)) {
+			errors.push(`Missing SQLite migration counterpart for ${f}`);
+		}
+	}
+	const seenPrefixes = new Set<string>();
+	for (const f of sqliteFiles) {
+		const prefix = f.slice(0, 3);
+		if (seenPrefixes.has(prefix)) {
+			errors.push(`Duplicate migration prefix ${prefix} in ${f}`);
+		}
+		seenPrefixes.add(prefix);
+	}
+	return errors;
+}
+
+const extractCreatedTables = (sql: string): string[] => {
+	const names: string[] = [];
+	for (const m of sql.matchAll(
+		/CREATE\s+TABLE(?:\s+IF\s+NOT\s+EXISTS)?\s+([a-zA-Z0-9_]+)/gi,
+	)) {
+		const table = m[1].toLowerCase();
+		if (!table.endsWith("_new")) {
+			names.push(table);
+		}
+	}
+	return [...new Set(names)].sort();
+};
+
+const extractAddedColumns = (sql: string): string[] => {
+	const cols: string[] = [];
+	for (const m of sql.matchAll(
+		/ALTER\s+TABLE\s+([a-zA-Z0-9_]+)\s+ADD\s+COLUMN(?:\s+IF\s+NOT\s+EXISTS)?\s+([a-zA-Z0-9_]+)/gi,
+	)) {
+		cols.push(`${m[1].toLowerCase()}.${m[2].toLowerCase()}`);
+	}
+	return [...new Set(cols)].sort();
+};
+
 describe("migration parity", () => {
-	it("has the same numbered files on SQLite/D1 and Postgres", () => {
+	it("has the same numbered files on SQLite/D1 and Postgres and catches missing pairs", () => {
 		const sqlite = sqlFiles(sqliteDir);
 		const postgres = sqlFiles(postgresDir);
 		expect(postgres).toEqual(sqlite);
-		const prefixes = sqlite.map((f) => f.slice(0, 3));
-		expect(new Set(prefixes).size).toBe(prefixes.length);
+		expect(sqlite.length).toBeGreaterThanOrEqual(53);
+		expect(checkMigrationFilePairings(sqlite, postgres)).toEqual([]);
+
+		// Regression check: missing or duplicate migration files must be flagged.
+		expect(
+			checkMigrationFilePairings([...sqlite, "099_new_feature.sql"], postgres),
+		).toEqual([
+			"Missing Postgres migration counterpart for 099_new_feature.sql",
+		]);
+		expect(
+			checkMigrationFilePairings(sqlite, [...postgres, "099_pg_only.sql"]),
+		).toEqual(["Missing SQLite migration counterpart for 099_pg_only.sql"]);
 	});
 
 	it("declares retention timestamps as TEXT in every Postgres CREATE TABLE", () => {
@@ -65,4 +127,44 @@ describe("migration parity", () => {
 		}
 		expect(offenders).toEqual([]);
 	});
+
+	it("creates and alters the same tables and columns per migration file", () => {
+		const mismatches: string[] = [];
+		for (const file of sqlFiles(sqliteDir)) {
+			const sqliteSql = readFileSync(path.join(sqliteDir, file), "utf8");
+			const pgSql = readFileSync(path.join(postgresDir, file), "utf8");
+			const sTables = extractCreatedTables(sqliteSql);
+			const pTables = extractCreatedTables(pgSql);
+			if (JSON.stringify(sTables) !== JSON.stringify(pTables)) {
+				mismatches.push(
+					`${file} CREATE TABLE mismatch: sqlite=${JSON.stringify(sTables)} pg=${JSON.stringify(pTables)}`,
+				);
+			}
+			const sCols = extractAddedColumns(sqliteSql);
+			const pCols = extractAddedColumns(pgSql);
+			if (JSON.stringify(sCols) !== JSON.stringify(pCols)) {
+				mismatches.push(
+					`${file} ALTER TABLE ADD COLUMN mismatch: sqlite=${JSON.stringify(sCols)} pg=${JSON.stringify(pCols)}`,
+				);
+			}
+		}
+		expect(mismatches).toEqual([]);
+	});
+
+	it("applies all SQLite migrations cleanly in-memory without leftover staging tables", () => {
+		const db = new DatabaseSync(":memory:");
+		try {
+			for (const file of sqlFiles(sqliteDir)) {
+				db.exec(readFileSync(path.join(sqliteDir, file), "utf8"));
+			}
+			const leftover = db
+				.prepare(
+					"SELECT name FROM sqlite_master WHERE type = 'table' AND name LIKE '%_new'",
+				)
+				.all();
+			expect(leftover).toEqual([]);
+		} finally {
+			db.close();
+		}
+	});
 });

package/src/plugins/ai-receiver.ts

@@ -16,6 +16,7 @@ import { AIStore, type IngestEvaluation } from "../lib/ai-store";
 import { sqlDbFor } from "../lib/sql-db";
 import { getProjectId } from "./_context";
 import { readJsonObject } from "./_json";
+import { respondWithContract } from "./autosre-routes";
 
 export const aiReceiverPlugin: CollectorPlugin = {
 	name: "ai-receiver",
@@ -104,7 +105,11 @@ export const aiReceiverPlugin: CollectorPlugin = {
 			const store = new AIStore(sqlDbFor(c.env));
 			const call = await store.getAICall(projectId, c.req.param("callId"));
 			if (!call) return c.json({ error: "AI call not found" }, 404);
-			return c.json({ call, traceId: call.traceId, spanId: call.spanId });
+			return respondWithContract(c, "GET /internal/ai/calls/:callId", {
+				call,
+				traceId: call.traceId,
+				spanId: call.spanId,
+			});
 		});
 
 		// OpenInference-kind spans (LLM/TOOL/RETRIEVER/CHAIN/AGENT/...) joined