@obsunified/collector 2.2.0 → 2.2.3

package/src/plugins/connected-routes.ts

@@ -15,8 +15,12 @@
  * RFC 0006 § Connected rail / Empty-state.
  */
 
+import type { CausalProofTier } from "@obsunified/types";
 import { ActionConfidence } from "@obsunified/types/constants";
 import type { CollectorPlugin } from "../framework/collector";
+import { getChangeEvent } from "../lib/autosre-change-correlation";
+import { getInvestigationFinding } from "../lib/autosre-findings";
+import { getIncidentInvestigation } from "../lib/autosre-remediation-gate";
 import { IdentityIndex } from "../lib/identity-index";
 import {
 	mapAction,
@@ -38,6 +42,7 @@ import {
 	type ActionContextLinkMetadata,
 	type ConnectedEntityKind,
 	type ConnectedManifest,
+	hrefForEntity,
 	KNOWN_KINDS,
 	linksFromActions,
 	linksFromAi,
@@ -55,6 +60,7 @@ import {
 	linkToTrace,
 	MAX_LINKS_INLINE,
 	profileLinksForTrace,
+	resolveFaultLocusTarget,
 } from "./connected-routes/manifest";
 
 export type {
@@ -1051,30 +1057,20 @@ export const connectedRoutesPlugin: CollectorPlugin = {
 				}
 			} else if (kind === "change") {
 				const db = sqlDbFor(c.env);
-				const changeRow = await db
-					.prepare(
-						`SELECT * FROM change_events WHERE project_id = ? AND id = ? LIMIT 1`,
-					)
-					.bind(projectId, id)
-					.first<{
-						id: string;
-						environment: string;
-						kind: string;
-						target_node_id: string;
-						service_name: string | null;
-						version: string | null;
-						previous_version: string | null;
-						commit_sha: string | null;
-						summary: string;
-					}>();
+				const changeRow = await getChangeEvent(
+					db,
+					projectId,
+					id,
+					c.req.query("environment") || undefined,
+				);
 				if (changeRow) {
 					manifest.up = [
 						{
 							label: "Target Ontology Node",
 							links: [
 								{
-									label: `${changeRow.target_node_id} (${changeRow.environment})`,
-									href: `#/health?node=${encodeURIComponent(changeRow.target_node_id)}`,
+									label: `${changeRow.targetNodeId} (${changeRow.environment})`,
+									href: `#/health?node=${encodeURIComponent(changeRow.targetNodeId)}`,
 									relationshipCertainty: "exact",
 									reason: "Target node mutated by this change event.",
 								},
@@ -1107,8 +1103,7 @@ export const connectedRoutesPlugin: CollectorPlugin = {
 								entityKind: "finding",
 								entityId: f.id,
 								relationshipCertainty: "exact",
-								causalProofTier:
-									f.causal_proof_tier as import("@obsunified/types").CausalProofTier,
+								causalProofTier: f.causal_proof_tier as CausalProofTier,
 								confidence: f.confidence,
 								reason: "Finding attributes this change event.",
 							})),
@@ -1122,10 +1117,11 @@ export const connectedRoutesPlugin: CollectorPlugin = {
 					const spans = changeRow.version
 						? await db
 								.prepare(
-									`SELECT DISTINCT trace_id, span_id, service_name, span_name
+									`SELECT trace_id, span_id, service_name, span_name
 									 FROM telemetry_spans
 									 WHERE project_id = ? AND environment = ? AND service_version = ? AND status_code = 2
-									 ORDER BY start_time DESC LIMIT 5`,
+									 GROUP BY trace_id, span_id, service_name, span_name
+									 ORDER BY MAX(start_time) DESC LIMIT 5`,
 								)
 								.bind(projectId, changeRow.environment, changeRow.version)
 								.all<{
@@ -1156,54 +1152,39 @@ export const connectedRoutesPlugin: CollectorPlugin = {
 				}
 			} else if (kind === "finding") {
 				const db = sqlDbFor(c.env);
-				const findingRow = await db
-					.prepare(
-						`SELECT * FROM investigation_findings WHERE project_id = ? AND id = ? LIMIT 1`,
-					)
-					.bind(projectId, id)
-					.first<{
-						id: string;
-						environment: string;
-						incident_id: string | null;
-						title: string;
-						causal_proof_tier: string;
-						confidence: number;
-						symptom_entity_kind: string;
-						symptom_entity_id: string;
-						fault_locus_entity_kind: string;
-						fault_locus_entity_id: string;
-						contributing_change_id: string | null;
-						contending_trace_id: string | null;
-						agent_run_id: string | null;
-					}>();
+				const findingRow = await getInvestigationFinding(
+					db,
+					projectId,
+					id,
+					c.req.query("environment") || undefined,
+				);
 				if (findingRow) {
-					const proofTier =
-						findingRow.causal_proof_tier as import("@obsunified/types").CausalProofTier;
+					const proofTier = findingRow.causalProofTier as CausalProofTier;
 					manifest.up = [];
-					if (findingRow.incident_id) {
+					if (findingRow.incidentId) {
 						manifest.up.push({
 							label: "Incident Investigation",
 							links: [
 								{
-									label: `incident ${findingRow.incident_id}`,
-									href: `#/incidents/${encodeURIComponent(findingRow.incident_id)}`,
+									label: `incident ${findingRow.incidentId}`,
+									href: `#/incidents/${encodeURIComponent(findingRow.incidentId)}`,
 									entityKind: "incident",
-									entityId: findingRow.incident_id,
+									entityId: findingRow.incidentId,
 									relationshipCertainty: "exact",
 									causalProofTier: proofTier,
 								},
 							],
 						});
 					}
-					if (findingRow.contributing_change_id) {
+					if (findingRow.contributingChangeId) {
 						manifest.up.push({
 							label: "Contributing Change",
 							links: [
 								{
-									label: `change ${findingRow.contributing_change_id}`,
-									href: `#/changes/${encodeURIComponent(findingRow.contributing_change_id)}`,
+									label: `change ${findingRow.contributingChangeId}`,
+									href: `#/changes/${encodeURIComponent(findingRow.contributingChangeId)}`,
 									entityKind: "change",
-									entityId: findingRow.contributing_change_id,
+									entityId: findingRow.contributingChangeId,
 									relationshipCertainty: "exact",
 									causalProofTier: proofTier,
 									confidence: findingRow.confidence,
@@ -1216,18 +1197,18 @@ export const connectedRoutesPlugin: CollectorPlugin = {
 							label: "Fault Locus & Symptom",
 							links: [
 								{
-									label: `fault locus: ${findingRow.fault_locus_entity_id}`,
-									href: `#/traces?q=${encodeURIComponent(findingRow.fault_locus_entity_id)}`,
+									label: `fault locus: ${findingRow.faultLocusEntityId}`,
+									...resolveFaultLocusTarget(findingRow.faultLocusEntityId),
 									relationshipCertainty: "exact",
 									causalProofTier: proofTier,
 								},
-								...(findingRow.contending_trace_id
+								...(findingRow.contendingTraceId
 									? [
 											{
-												label: `contending trace ${findingRow.contending_trace_id}`,
-												href: `#/traces/${encodeURIComponent(findingRow.contending_trace_id)}`,
+												label: `contending trace ${findingRow.contendingTraceId}`,
+												href: `#/traces/${encodeURIComponent(findingRow.contendingTraceId)}`,
 												entityKind: "trace" as const,
-												entityId: findingRow.contending_trace_id,
+												entityId: findingRow.contendingTraceId,
 												relationshipCertainty: "inferred" as const,
 												causalProofTier: proofTier,
 											},
@@ -1240,17 +1221,17 @@ export const connectedRoutesPlugin: CollectorPlugin = {
 						{
 							label: "Agent Lineage",
 							links: [
-								...(findingRow.agent_run_id
+								...(findingRow.agentRunId
 									? [
 											{
-												...linkToAgentRun(findingRow.agent_run_id),
+												...linkToAgentRun(findingRow.agentRunId),
 												relationshipCertainty: "exact" as const,
 												causalProofTier: proofTier,
 											},
 										]
 									: []),
 							],
-							emptyReason: !findingRow.agent_run_id
+							emptyReason: !findingRow.agentRunId
 								? "No agent run linked to this finding."
 								: undefined,
 						},
@@ -1258,32 +1239,25 @@ export const connectedRoutesPlugin: CollectorPlugin = {
 				}
 			} else if (kind === "incident") {
 				const db = sqlDbFor(c.env);
-				const incRow = await db
-					.prepare(
-						`SELECT * FROM incident_investigations WHERE project_id = ? AND id = ? LIMIT 1`,
-					)
-					.bind(projectId, id)
-					.first<{
-						id: string;
-						environment: string;
-						target_node_id: string;
-						symptom_anchor_kind: string;
-						symptom_anchor_id: string;
-						status: string;
-					}>();
+				const incRow = await getIncidentInvestigation(
+					db,
+					projectId,
+					id,
+					c.req.query("environment") || undefined,
+				);
 				if (incRow) {
 					manifest.up = [
 						{
 							label: "Trigger Signal",
 							links: [
 								{
-									label: `${incRow.symptom_anchor_kind}: ${incRow.symptom_anchor_id}`,
-									href: `#/alerts?id=${encodeURIComponent(incRow.symptom_anchor_id)}`,
-									entityKind:
-										incRow.symptom_anchor_kind === "analysis"
-											? "analysis"
-											: "alert",
-									entityId: incRow.symptom_anchor_id,
+									label: `${incRow.symptomAnchorKind}: ${incRow.symptomAnchorId}`,
+									href: hrefForEntity(
+										incRow.symptomAnchorKind,
+										incRow.symptomAnchorId,
+									),
+									entityKind: incRow.symptomAnchorKind,
+									entityId: incRow.symptomAnchorId,
 									relationshipCertainty: "exact",
 								},
 							],
@@ -1310,8 +1284,7 @@ export const connectedRoutesPlugin: CollectorPlugin = {
 								entityKind: "finding" as const,
 								entityId: f.id,
 								relationshipCertainty: "exact" as const,
-								causalProofTier:
-									f.causal_proof_tier as import("@obsunified/types").CausalProofTier,
+								causalProofTier: f.causal_proof_tier as CausalProofTier,
 							})),
 							emptyReason:
 								incFindings.results.length > 0

package/src/plugins/evidence-retrieval-routes.test.ts

@@ -519,6 +519,38 @@ describe("evidenceRetrievalRoutesPlugin", () => {
 		return (await bundleRes.json()) as EvidenceBundle;
 	};
 
+	it("attaches the AutoSRE triage section only for intent triage_incident", async () => {
+		const { app, env } = setup();
+		const post = async (intent: string, targetTokens = 4000) => {
+			const res = await app.request(
+				"/internal/evidence/bundle",
+				{
+					method: "POST",
+					body: JSON.stringify({
+						anchor: { entityKind: "trace", entityId: "trace-1" },
+						intent,
+						budget: { targetTokens, detailLevel: "standard" },
+					}),
+					headers: { "content-type": "application/json" },
+				},
+				env,
+			);
+			expect(res.status).toBe(200);
+			return (await res.json()) as EvidenceBundle;
+		};
+
+		const debug = await post("debug_failure");
+		expect(debug.autosre).toBeUndefined();
+
+		const triage = await post("triage_incident");
+		expect(triage.autosre).toBeDefined();
+		// No unfiltered prior-findings fallback: an empty memory yields none.
+		expect(triage.autosre?.priorFindings).toEqual([]);
+		expect(triage.autosre?.faultLocus?.isBlackoutSuspected ?? false).toBe(
+			false,
+		);
+	});
+
 	it("returns an incident-local trace bundle with log compaction provenance", async () => {
 		const { app, env } = setup();
 		const res = await app.request(