@objectstack/plugin-approvals 9.0.1 → 9.2.0

package/.turbo/turbo-build.log

@@ -1,5 +1,5 @@
 
-> @objectstack/plugin-approvals@9.0.1 build /home/runner/work/framework/framework/packages/plugins/plugin-approvals
+> @objectstack/plugin-approvals@9.2.0 build /home/runner/work/framework/framework/packages/plugins/plugin-approvals
 > tsup --config ../../../tsup.config.ts
 
 CLI Building entry: src/index.ts
@@ -10,13 +10,13 @@
 CLI Cleaning output folder
 ESM Build start
 CJS Build start
-CJS dist/index.js     64.93 KB
-CJS dist/index.js.map 113.45 KB
-CJS ⚡️ Build success in 189ms
-ESM dist/index.mjs     63.58 KB
-ESM dist/index.mjs.map 112.27 KB
-ESM ⚡️ Build success in 190ms
+ESM dist/index.mjs     67.42 KB
+ESM dist/index.mjs.map 119.54 KB
+ESM ⚡️ Build success in 167ms
+CJS dist/index.js     68.76 KB
+CJS dist/index.js.map 120.72 KB
+CJS ⚡️ Build success in 169ms
 DTS Build start
-DTS ⚡️ Build success in 24542ms
-DTS dist/index.d.mts 334.31 KB
-DTS dist/index.d.ts  334.31 KB
+DTS ⚡️ Build success in 24561ms
+DTS dist/index.d.mts 334.84 KB
+DTS dist/index.d.ts  334.84 KB

package/CHANGELOG.md

@@ -1,5 +1,28 @@
 # @objectstack/plugin-approvals
 
+## 9.2.0
+
+### Patch Changes
+
+- Updated dependencies [2f57b75]
+- Updated dependencies [2f57b75]
+  - @objectstack/spec@9.2.0
+  - @objectstack/core@9.2.0
+  - @objectstack/formula@9.2.0
+  - @objectstack/metadata-core@9.2.0
+  - @objectstack/platform-objects@9.2.0
+
+## 9.1.0
+
+### Patch Changes
+
+- Updated dependencies [b9062c9]
+  - @objectstack/spec@9.1.0
+  - @objectstack/core@9.1.0
+  - @objectstack/formula@9.1.0
+  - @objectstack/metadata-core@9.1.0
+  - @objectstack/platform-objects@9.1.0
+
 ## 9.0.1
 
 ### Patch Changes

package/dist/index.d.mts

@@ -7550,10 +7550,21 @@ declare class ApprovalService implements IApprovalService {
     private resolveDisplayField;
     private static pickTitle;
     /**
-     * Attach inbox display fields (`record_title`, `submitter_name`) to rows.
-     * Batched: one query per distinct target object plus one `sys_user` lookup.
-     * Best-effort — a deleted record falls back to the payload snapshot, and a
-     * lookup failure leaves the field unset rather than failing the list.
+     * Batch-resolve `sys_user` display names for identifiers that may be user
+     * ids or emails. Best-effort — failures leave entries unresolved.
+     */
+    private resolveUserNames;
+    /** Lookup-typed fields (key + referenced object) of an object's schema. */
+    private resolveLookupFields;
+    /**
+     * Attach inbox display fields to rows so clients never render a raw
+     * identifier: `record_title`, `submitter_name`, `object_label`,
+     * `pending_approver_names` (user-id approvers), and `payload_display`
+     * (lookup foreign keys in the snapshot → referenced record titles).
+     * Batched: one query per distinct object (target + referenced) plus one
+     * `sys_user` lookup. Best-effort — a deleted record falls back to the
+     * payload snapshot, and any failure leaves the field unset rather than
+     * failing the list.
      */
     private enrichRows;
     listRequests(filter: {

package/dist/index.d.ts

@@ -7550,10 +7550,21 @@ declare class ApprovalService implements IApprovalService {
     private resolveDisplayField;
     private static pickTitle;
     /**
-     * Attach inbox display fields (`record_title`, `submitter_name`) to rows.
-     * Batched: one query per distinct target object plus one `sys_user` lookup.
-     * Best-effort — a deleted record falls back to the payload snapshot, and a
-     * lookup failure leaves the field unset rather than failing the list.
+     * Batch-resolve `sys_user` display names for identifiers that may be user
+     * ids or emails. Best-effort — failures leave entries unresolved.
+     */
+    private resolveUserNames;
+    /** Lookup-typed fields (key + referenced object) of an object's schema. */
+    private resolveLookupFields;
+    /**
+     * Attach inbox display fields to rows so clients never render a raw
+     * identifier: `record_title`, `submitter_name`, `object_label`,
+     * `pending_approver_names` (user-id approvers), and `payload_display`
+     * (lookup foreign keys in the snapshot → referenced record titles).
+     * Batched: one query per distinct object (target + referenced) plus one
+     * `sys_user` lookup. Best-effort — a deleted record falls back to the
+     * payload snapshot, and any failure leaves the field unset rather than
+     * failing the list.
      */
     private enrichRows;
     listRequests(filter: {

package/dist/index.js

@@ -1464,10 +1464,67 @@ var ApprovalService = class _ApprovalService {
     return void 0;
   }
   /**
-   * Attach inbox display fields (`record_title`, `submitter_name`) to rows.
-   * Batched: one query per distinct target object plus one `sys_user` lookup.
-   * Best-effort — a deleted record falls back to the payload snapshot, and a
-   * lookup failure leaves the field unset rather than failing the list.
+   * Batch-resolve `sys_user` display names for identifiers that may be user
+   * ids or emails. Best-effort — failures leave entries unresolved.
+   */
+  async resolveUserNames(identifiers) {
+    const names = /* @__PURE__ */ new Map();
+    const targets = Array.from(new Set(identifiers.filter(Boolean)));
+    if (!targets.length) return names;
+    try {
+      const users = await this.engine.find("sys_user", {
+        where: { id: { $in: targets } },
+        fields: ["id", "name", "email"],
+        limit: targets.length,
+        context: SYSTEM_CTX
+      });
+      for (const u of users ?? []) {
+        if (u?.id && (u.name || u.email)) names.set(String(u.id), String(u.name ?? u.email));
+      }
+    } catch {
+    }
+    const unresolvedEmails = targets.filter((t) => !names.has(t) && t.includes("@"));
+    if (unresolvedEmails.length) {
+      try {
+        const users = await this.engine.find("sys_user", {
+          where: { email: { $in: unresolvedEmails } },
+          fields: ["email", "name"],
+          limit: unresolvedEmails.length,
+          context: SYSTEM_CTX
+        });
+        for (const u of users ?? []) {
+          if (u?.email && u.name) names.set(String(u.email), String(u.name));
+        }
+      } catch {
+      }
+    }
+    return names;
+  }
+  /** Lookup-typed fields (key + referenced object) of an object's schema. */
+  resolveLookupFields(object) {
+    try {
+      const schema = this.engine.getSchema?.(object);
+      const fields = schema?.fields ?? {};
+      const out = [];
+      for (const [key, f] of Object.entries(fields)) {
+        if ((f?.type === "lookup" || f?.type === "master_detail") && f?.reference) {
+          out.push({ key, reference: String(f.reference) });
+        }
+      }
+      return out;
+    } catch {
+      return [];
+    }
+  }
+  /**
+   * Attach inbox display fields to rows so clients never render a raw
+   * identifier: `record_title`, `submitter_name`, `object_label`,
+   * `pending_approver_names` (user-id approvers), and `payload_display`
+   * (lookup foreign keys in the snapshot → referenced record titles).
+   * Batched: one query per distinct object (target + referenced) plus one
+   * `sys_user` lookup. Best-effort — a deleted record falls back to the
+   * payload snapshot, and any failure leaves the field unset rather than
+   * failing the list.
    */
   async enrichRows(rows) {
     if (!rows.length) return;
@@ -1482,7 +1539,13 @@ var ApprovalService = class _ApprovalService {
       set.add(r.record_id);
     }
     const titles = /* @__PURE__ */ new Map();
+    const objectLabels = /* @__PURE__ */ new Map();
     for (const [object, idSet] of byObject) {
+      try {
+        const schema = this.engine.getSchema?.(object);
+        if (schema?.label) objectLabels.set(object, String(schema.label));
+      } catch {
+      }
       const ids = Array.from(idSet);
       const displayField = this.resolveDisplayField(object);
       try {
@@ -1493,47 +1556,81 @@ var ApprovalService = class _ApprovalService {
         });
         for (const rec of recs ?? []) {
           const title = _ApprovalService.pickTitle(rec, displayField);
-          if (rec?.id && title) titles.set(`${object}\0${rec.id}`, title);
+          if (rec?.id && title) titles.set(`${object} ${rec.id}`, title);
         }
       } catch {
       }
     }
-    const submitters = Array.from(new Set(rows.map((r) => r.submitter_id).filter(Boolean)));
-    const names = /* @__PURE__ */ new Map();
-    if (submitters.length) {
+    const lookupFieldsByObject = /* @__PURE__ */ new Map();
+    for (const object of byObject.keys()) {
+      const lookups = this.resolveLookupFields(object);
+      if (lookups.length) lookupFieldsByObject.set(object, lookups);
+    }
+    const refIds = /* @__PURE__ */ new Map();
+    for (const r of rows) {
+      const lookups = lookupFieldsByObject.get(r.object_name);
+      const payload = r.payload;
+      if (!lookups || !payload || typeof payload !== "object") continue;
+      for (const { key, reference } of lookups) {
+        const v = payload[key];
+        if (v == null || typeof v === "object" || !String(v).trim()) continue;
+        let set = refIds.get(reference);
+        if (!set) {
+          set = /* @__PURE__ */ new Set();
+          refIds.set(reference, set);
+        }
+        set.add(String(v));
+      }
+    }
+    const refTitles = /* @__PURE__ */ new Map();
+    for (const [object, idSet] of refIds) {
+      const ids = Array.from(idSet);
+      const displayField = this.resolveDisplayField(object);
       try {
-        const users = await this.engine.find("sys_user", {
-          where: { id: { $in: submitters } },
-          fields: ["id", "name", "email"],
-          limit: submitters.length,
+        const recs = await this.engine.find(object, {
+          where: { id: { $in: ids } },
+          limit: ids.length,
           context: SYSTEM_CTX
         });
-        for (const u of users ?? []) {
-          if (u?.id && (u.name || u.email)) names.set(String(u.id), String(u.name ?? u.email));
+        for (const rec of recs ?? []) {
+          const title = _ApprovalService.pickTitle(rec, displayField);
+          if (rec?.id && title) refTitles.set(`${object} ${rec.id}`, title);
         }
       } catch {
       }
-      const unresolvedEmails = submitters.filter((s) => !names.has(s) && s.includes("@"));
-      if (unresolvedEmails.length) {
-        try {
-          const users = await this.engine.find("sys_user", {
-            where: { email: { $in: unresolvedEmails } },
-            fields: ["email", "name"],
-            limit: unresolvedEmails.length,
-            context: SYSTEM_CTX
-          });
-          for (const u of users ?? []) {
-            if (u?.email && u.name) names.set(String(u.email), String(u.name));
-          }
-        } catch {
-        }
+    }
+    const userIdentifiers = [];
+    for (const r of rows) {
+      userIdentifiers.push(r.submitter_id);
+      for (const a of r.pending_approvers ?? []) {
+        if (a && !a.includes(":")) userIdentifiers.push(a);
       }
     }
+    const names = await this.resolveUserNames(userIdentifiers);
     for (const r of rows) {
-      const title = titles.get(`${r.object_name}\0${r.record_id}`) ?? _ApprovalService.pickTitle(r.payload, void 0);
+      const title = titles.get(`${r.object_name} ${r.record_id}`) ?? _ApprovalService.pickTitle(r.payload, void 0);
       if (title) r.record_title = title;
       const name = r.submitter_id ? names.get(String(r.submitter_id)) : void 0;
       if (name) r.submitter_name = name;
+      const label = objectLabels.get(r.object_name);
+      if (label) r.object_label = label;
+      const approverNames = {};
+      for (const a of r.pending_approvers ?? []) {
+        const n = names.get(String(a));
+        if (n) approverNames[a] = n;
+      }
+      if (Object.keys(approverNames).length) r.pending_approver_names = approverNames;
+      const lookups = lookupFieldsByObject.get(r.object_name);
+      if (lookups && r.payload && typeof r.payload === "object") {
+        const display = {};
+        for (const { key, reference } of lookups) {
+          const v = r.payload[key];
+          if (v == null) continue;
+          const t = refTitles.get(`${reference} ${String(v)}`);
+          if (t) display[key] = t;
+        }
+        if (Object.keys(display).length) r.payload_display = display;
+      }
     }
   }
   // ── Read API ─────────────────────────────────────────────────
@@ -1592,7 +1689,15 @@ var ApprovalService = class _ApprovalService {
       orderBy: [{ field: "created_at", direction: "asc" }],
       context: SYSTEM_CTX
     });
-    return Array.isArray(rows) ? rows.map(rowFromAction) : [];
+    const actions = Array.isArray(rows) ? rows.map(rowFromAction) : [];
+    const names = await this.resolveUserNames(
+      actions.map((a) => a.actor_id).filter((id) => id && !id.includes(":"))
+    );
+    for (const a of actions) {
+      const n = a.actor_id ? names.get(String(a.actor_id)) : void 0;
+      if (n) a.actor_name = n;
+    }
+    return actions;
   }
 };