@objectstack/plugin-approvals 17.0.0-rc.5 → 17.0.0

package/dist/index.mjs

@@ -51,11 +51,11 @@ var init_en_objects_generated = __esm({
             label: "Status",
             help: "Lifecycle state of the request",
             options: {
-              pending: "pending",
-              approved: "approved",
-              rejected: "rejected",
-              recalled: "recalled",
-              returned: "returned"
+              pending: "Pending",
+              approved: "Approved",
+              rejected: "Rejected",
+              recalled: "Recalled",
+              returned: "Returned"
             }
           },
           current_step: {
@@ -128,7 +128,7 @@ var init_en_objects_generated = __esm({
           },
           approval_reject: {
             label: "Reject",
-            confirmText: "Reject this request? A rejection is final for every approver.",
+            description: "Reject this request? A rejection is final for every approver.",
             successMessage: "Rejected.",
             params: {
               comment: {
@@ -181,7 +181,7 @@ var init_en_objects_generated = __esm({
           },
           approval_recall: {
             label: "Recall",
-            confirmText: "Recall this request? Approvers can no longer act on it and the record is unlocked.",
+            description: "Recall this request? Approvers can no longer act on it and the record is unlocked.",
             successMessage: "Recalled.",
             params: {
               comment: {
@@ -225,18 +225,18 @@ var init_en_objects_generated = __esm({
           action: {
             label: "Action",
             options: {
-              submit: "submit",
-              approve: "approve",
-              reject: "reject",
-              recall: "recall",
-              escalate: "escalate",
-              reassign: "reassign",
-              remind: "remind",
-              request_info: "request_info",
-              comment: "comment",
-              revise: "revise",
-              resubmit: "resubmit",
-              ooo_substitute: "ooo_substitute"
+              submit: "Submit",
+              approve: "Approve",
+              reject: "Reject",
+              recall: "Recall",
+              escalate: "Escalate",
+              reassign: "Reassign",
+              remind: "Remind",
+              request_info: "Request Info",
+              comment: "Comment",
+              revise: "Revise",
+              resubmit: "Resubmit",
+              ooo_substitute: "Out-of-Office Substitution"
             }
           },
           actor_id: {
@@ -372,7 +372,7 @@ var init_zh_CN_objects_generated = __esm({
             label: "\u72B6\u6001",
             help: "\u8BF7\u6C42\u7684\u751F\u547D\u5468\u671F\u72B6\u6001",
             options: {
-              pending: "\u5F85\u5904\u7406",
+              pending: "\u5F85\u5BA1\u6279",
               approved: "\u5DF2\u6279\u51C6",
               rejected: "\u5DF2\u62D2\u7EDD",
               recalled: "\u5DF2\u64A4\u56DE",
@@ -418,9 +418,9 @@ var init_zh_CN_objects_generated = __esm({
         },
         _views: {
           my_pending: {
-            label: "\u6211\u7684\u5F85\u529E",
+            label: "\u5F85\u6211\u5BA1\u6279",
             emptyState: {
-              title: "\u6682\u65E0\u5F85\u529E\u5BA1\u6279",
+              title: "\u6682\u65E0\u5F85\u5BA1\u6279\u7684\u8BF7\u6C42",
               message: "\u5168\u90E8\u5904\u7406\u5B8C\u6BD5\uFF0C\u6CA1\u6709\u7B49\u5F85\u4F60\u5BA1\u6279\u7684\u8BF7\u6C42\u3002"
             }
           },
@@ -449,7 +449,7 @@ var init_zh_CN_objects_generated = __esm({
           },
           approval_reject: {
             label: "\u62D2\u7EDD",
-            confirmText: "\u62D2\u7EDD\u8BE5\u8BF7\u6C42\uFF1F\u62D2\u7EDD\u5BF9\u6240\u6709\u5BA1\u6279\u4EBA\u7ACB\u5373\u751F\u6548\u3002",
+            description: "\u62D2\u7EDD\u8BE5\u8BF7\u6C42\uFF1F\u62D2\u7EDD\u5BF9\u6240\u6709\u5BA1\u6279\u4EBA\u7ACB\u5373\u751F\u6548\u3002",
             successMessage: "\u5DF2\u62D2\u7EDD\u3002",
             params: {
               comment: {
@@ -502,7 +502,7 @@ var init_zh_CN_objects_generated = __esm({
           },
           approval_recall: {
             label: "\u64A4\u56DE",
-            confirmText: "\u64A4\u56DE\u8BE5\u8BF7\u6C42\uFF1F\u64A4\u56DE\u540E\u5BA1\u6279\u4EBA\u5C06\u65E0\u6CD5\u7EE7\u7EED\u5904\u7406\uFF0C\u8BB0\u5F55\u968F\u5373\u89E3\u9501\u3002",
+            description: "\u64A4\u56DE\u8BE5\u8BF7\u6C42\uFF1F\u64A4\u56DE\u540E\u5BA1\u6279\u4EBA\u5C06\u65E0\u6CD5\u7EE7\u7EED\u5904\u7406\uFF0C\u8BB0\u5F55\u968F\u5373\u89E3\u9501\u3002",
             successMessage: "\u5DF2\u64A4\u56DE\u3002",
             params: {
               comment: {
@@ -739,7 +739,7 @@ var init_ja_JP_objects_generated = __esm({
         },
         _views: {
           my_pending: {
-            label: "\u81EA\u5206\u306E\u4FDD\u7559\u4E2D",
+            label: "\u627F\u8A8D\u5F85\u3061",
             emptyState: {
               title: "\u627F\u8A8D\u5F85\u3061\u306F\u3042\u308A\u307E\u305B\u3093",
               message: "\u3059\u3079\u3066\u51E6\u7406\u6E08\u307F\u3067\u3059\u3002\u3042\u306A\u305F\u306E\u627F\u8A8D\u3092\u5F85\u3064\u30EA\u30AF\u30A8\u30B9\u30C8\u306F\u3042\u308A\u307E\u305B\u3093\u3002"
@@ -770,7 +770,7 @@ var init_ja_JP_objects_generated = __esm({
           },
           approval_reject: {
             label: "\u5374\u4E0B",
-            confirmText: "\u3053\u306E\u30EA\u30AF\u30A8\u30B9\u30C8\u3092\u5374\u4E0B\u3057\u307E\u3059\u304B\uFF1F\u5374\u4E0B\u306F\u3059\u3079\u3066\u306E\u627F\u8A8D\u8005\u306B\u5BFE\u3057\u3066\u6700\u7D42\u6C7A\u5B9A\u306B\u306A\u308A\u307E\u3059\u3002",
+            description: "\u3053\u306E\u30EA\u30AF\u30A8\u30B9\u30C8\u3092\u5374\u4E0B\u3057\u307E\u3059\u304B\uFF1F\u5374\u4E0B\u306F\u3059\u3079\u3066\u306E\u627F\u8A8D\u8005\u306B\u5BFE\u3057\u3066\u6700\u7D42\u6C7A\u5B9A\u306B\u306A\u308A\u307E\u3059\u3002",
             successMessage: "\u5374\u4E0B\u3057\u307E\u3057\u305F\u3002",
             params: {
               comment: {
@@ -823,7 +823,7 @@ var init_ja_JP_objects_generated = __esm({
           },
           approval_recall: {
             label: "\u53D6\u308A\u4E0B\u3052",
-            confirmText: "\u3053\u306E\u30EA\u30AF\u30A8\u30B9\u30C8\u3092\u53D6\u308A\u4E0B\u3052\u307E\u3059\u304B\uFF1F\u627F\u8A8D\u8005\u306F\u64CD\u4F5C\u3067\u304D\u306A\u304F\u306A\u308A\u3001\u30EC\u30B3\u30FC\u30C9\u306E\u30ED\u30C3\u30AF\u304C\u89E3\u9664\u3055\u308C\u307E\u3059\u3002",
+            description: "\u3053\u306E\u30EA\u30AF\u30A8\u30B9\u30C8\u3092\u53D6\u308A\u4E0B\u3052\u307E\u3059\u304B\uFF1F\u627F\u8A8D\u8005\u306F\u64CD\u4F5C\u3067\u304D\u306A\u304F\u306A\u308A\u3001\u30EC\u30B3\u30FC\u30C9\u306E\u30ED\u30C3\u30AF\u304C\u89E3\u9664\u3055\u308C\u307E\u3059\u3002",
             successMessage: "\u53D6\u308A\u4E0B\u3052\u307E\u3057\u305F\u3002",
             params: {
               comment: {
@@ -1060,7 +1060,7 @@ var init_es_ES_objects_generated = __esm({
         },
         _views: {
           my_pending: {
-            label: "Mis pendientes",
+            label: "Aprobaciones pendientes",
             emptyState: {
               title: "Sin aprobaciones pendientes",
               message: "Est\xE1s al d\xEDa: nada espera tu aprobaci\xF3n."
@@ -1091,7 +1091,7 @@ var init_es_ES_objects_generated = __esm({
           },
           approval_reject: {
             label: "Rechazar",
-            confirmText: "\xBFRechazar esta solicitud? Un rechazo es definitivo para todos los aprobadores.",
+            description: "\xBFRechazar esta solicitud? Un rechazo es definitivo para todos los aprobadores.",
             successMessage: "Rechazada.",
             params: {
               comment: {
@@ -1144,7 +1144,7 @@ var init_es_ES_objects_generated = __esm({
           },
           approval_recall: {
             label: "Retirar",
-            confirmText: "\xBFRetirar esta solicitud? Los aprobadores ya no podr\xE1n actuar sobre ella y el registro se desbloquear\xE1.",
+            description: "\xBFRetirar esta solicitud? Los aprobadores ya no podr\xE1n actuar sobre ella y el registro se desbloquear\xE1.",
             successMessage: "Retirada.",
             params: {
               comment: {
@@ -1321,7 +1321,7 @@ var init_translations = __esm({
 
 // src/sys-approval-request.object.ts
 import { ObjectSchema, Field } from "@objectstack/spec/data";
-import { APPROVAL_STATUSES } from "@objectstack/spec/contracts";
+import { APPROVAL_STATUSES, APPROVAL_STATUS_LABELS } from "@objectstack/spec/contracts";
 var SysApprovalRequest = ObjectSchema.create({
   name: "sys_approval_request",
   label: "Approval Request",
@@ -1420,10 +1420,13 @@ var SysApprovalRequest = ObjectSchema.create({
       group: "Target"
     }),
     status: Field.select(
-      // Spread from the contract, not re-typed (#3786). `APPROVAL_STATUSES` is
+      // Derived from the contract, not re-typed (#3786). `APPROVAL_STATUSES` is
       // where the list and the reason for each entry live; `ApprovalStatus` is
-      // derived from it, so this column and the contract cannot disagree.
-      [...APPROVAL_STATUSES],
+      // derived from it, so this column and the contract cannot disagree. The
+      // authored English label per entry lives beside it in
+      // `APPROVAL_STATUS_LABELS` (#8543) — mapped here, never re-typed, so the
+      // `en` bundle regenerates from the contract's own text.
+      APPROVAL_STATUSES.map((value) => ({ value, label: APPROVAL_STATUS_LABELS[value] })),
       {
         label: "Status",
         required: true,
@@ -1555,6 +1558,15 @@ var SysApprovalRequest = ObjectSchema.create({
     {
       name: "approval_reject",
       label: "Reject",
+      // The confirm question lives HERE, not in `confirmText`: this action
+      // collects params, so the console would otherwise chain a confirm dialog
+      // and then the param dialog for one decision — and the first one already
+      // reads as "the action ran" (#7278, maintainer ruling 2026-08-10). The
+      // param dialog renders this as its description, and nothing is POSTed
+      // until its own Confirm: one condition, one wording, one dialog.
+      // NB: the top-level action `description` (#7367), never `ai.description`
+      // — that one is the LLM-facing tool contract and is not shown to anyone.
+      description: "Reject this request? A rejection is final for every approver.",
       icon: "x-circle",
       // Destructive decision — rendered in the console's danger styling so it
       // reads as the irreversible action it is (objectui#2762 P1-5).
@@ -1567,7 +1579,6 @@ var SysApprovalRequest = ObjectSchema.create({
         { name: "attachments", label: "Attachments", type: "file", multiple: true, required: false }
       ],
       visible: "record.viewer.can_act || record.viewer.can_override",
-      confirmText: "Reject this request? A rejection is final for every approver.",
       locations: ["record_section", "list_item"],
       successMessage: "Rejected.",
       refreshAfter: true
@@ -1651,6 +1662,9 @@ var SysApprovalRequest = ObjectSchema.create({
     {
       name: "approval_recall",
       label: "Recall",
+      // Confirm question as the param dialog's description, not `confirmText`
+      // — same one-decision-one-dialog rule as `approval_reject` above (#7278).
+      description: "Recall this request? Approvers can no longer act on it and the record is unlocked.",
       icon: "undo-2",
       type: "api",
       method: "POST",
@@ -1661,7 +1675,6 @@ var SysApprovalRequest = ObjectSchema.create({
       // Recall applies while the request is live for the submitter — pending
       // (withdraw) or returned (abandon the revision instead of resubmitting).
       visible: '(record.status == "pending" || record.status == "returned") && record.viewer.is_submitter',
-      confirmText: "Recall this request? Approvers can no longer act on it and the record is unlocked.",
       locations: ["record_section"],
       successMessage: "Recalled.",
       refreshAfter: true
@@ -1692,7 +1705,7 @@ var SysApprovalRequest = ObjectSchema.create({
 
 // src/sys-approval-action.object.ts
 import { ObjectSchema as ObjectSchema2, Field as Field2 } from "@objectstack/spec/data";
-import { APPROVAL_ACTION_KINDS } from "@objectstack/spec/contracts";
+import { APPROVAL_ACTION_KINDS, APPROVAL_ACTION_KIND_LABELS } from "@objectstack/spec/contracts";
 var SysApprovalAction = ObjectSchema2.create({
   name: "sys_approval_action",
   label: "Approval Action",
@@ -1771,11 +1784,14 @@ var SysApprovalAction = ObjectSchema2.create({
       group: "Target"
     }),
     action: Field2.select(
-      // Spread from the contract, not re-typed (#3786). `APPROVAL_ACTION_KINDS`
+      // Derived from the contract, not re-typed (#3786). `APPROVAL_ACTION_KINDS`
       // is where the list and the per-kind notes live (which kinds move the flow
       // and which are thread-only); `ApprovalActionKind` is derived from it, so
-      // this column and the contract cannot disagree.
-      [...APPROVAL_ACTION_KINDS],
+      // this column and the contract cannot disagree. The authored English label
+      // per kind lives beside it in `APPROVAL_ACTION_KIND_LABELS` (#8580 — the
+      // #7232 humanization pass missed this field) — mapped here, never
+      // re-typed, so the `en` bundle regenerates from the contract's own text.
+      APPROVAL_ACTION_KINDS.map((value) => ({ value, label: APPROVAL_ACTION_KIND_LABELS[value] })),
       {
         label: "Action",
         required: true,
@@ -4386,10 +4402,14 @@ var _ApprovalService = class _ApprovalService {
    * class of failure stayed silent.
    *
    * It also could not have answered the question even if it looked: its
-   * liveness oracle is `getRun`, which reads the execution LOG, and after a
-   * restart that returns `null` for a perfectly ALIVE suspended run. It treats
-   * `null` as alive (conservative, correct) — but that means it has no way to
-   * say "this run is really gone".
+   * liveness oracle is `getRun`, which treats both `null` and `paused` as alive
+   * (conservative, correct) — so it has no way to say "this run is really
+   * gone". (Until #8050 that oracle was weaker still: after a restart it
+   * returned `null` for a perfectly ALIVE suspended run, so "alive" and
+   * "unknown" were the same answer. It now reports such a run as `paused`,
+   * which does not change any branch here — both already meant "leave alone" —
+   * but it is why the sweep below needs `hasSuspendedRun` as a second oracle
+   * rather than a sharper reading of the first.)
    *
    * So this uses BOTH oracles, and a row must fail both to be reported:
    *
@@ -5749,7 +5769,7 @@ function registerApprovalReviseNode(automation, logger) {
       paradigms: ["flow"],
       source: "plugin",
       supportsPause: true,
-      isAsync: true,
+      // (`isAsync` stood here — retired in #6748, ADR-0049: nothing read it)
       // #3823 / amended ADR-0044: THE point of this node type. The revise
       // window is a service-owned continuation, so the #3801 gate must refuse
       // a raw resume of it — which it does for any node type declaring this.
@@ -5801,7 +5821,7 @@ function registerApprovalNode(automation, service, logger) {
       source: "plugin",
       // Human decision: the run suspends here awaiting an external reply.
       supportsPause: true,
-      isAsync: true,
+      // (`isAsync` stood here — retired in #6748, ADR-0049: nothing read it)
       // #3801: this pause is NOT resumable through the generic run-resume
       // route. Continuing an approval is a side effect of a DECISION, and the
       // decision is the thing that must be authorized (the approver slate),
@@ -5852,6 +5872,17 @@ function registerApprovalNode(automation, service, logger) {
         }, {
           ...SYSTEM_CTX4,
           userId: context?.userId,
+          // [#7135] ⚠️ This assertion SURVIVES the annotation widening, and it
+          // is `as ExecutionContext` rather than the `as unknown as
+          // SharingExecutionContext` double cast it replaces. The sole reason
+          // a cast is still needed is `organizationId`, which is not a field
+          // of the envelope at ALL — that spelling has its own history (#5858
+          // / `check:org-identifier`) and was explicitly held out of this
+          // change (#7070), so removing the key here would be a RUNTIME change
+          // belonging to that card. Dropping the second hop matters: `as
+          // unknown as` erases the value entirely, while a single assertion
+          // still requires the literal to be comparable to the envelope, so a
+          // `userId: 42` here is once again a compile error.
           organizationId: context?.organizationId,
           tenantId: context?.tenantId
         });
@@ -5903,12 +5934,23 @@ var ApprovalsServicePlugin = class {
       // ADR-0029 D7 — contribute the Approvals entries into the Setup app's
       // `group_approvals` slot. This plugin owns these objects (K2.b), so it
       // ships their menu too; when the plugin isn't installed the slot is empty.
+      //
+      // #7234 — order inside the slot is ARRAY ORDER: `applyNavContributions`
+      // does `group.children.push(...c.items)` per contribution (sorted by
+      // `priority`), so the inbox being first in this array is what puts it
+      // above the raw tables. Do not reorder without meaning to.
+      //
+      // The inbox entry is the working surface (decision actions, node
+      // progress, drawer); the three object entries below stay as the
+      // admin/diagnostic view of the engine's own tables — reachable only here,
+      // behind `group_approvals`' `manage_platform_settings` gate.
       navigationContributions: [
         {
           app: "setup",
           group: "group_approvals",
           priority: 100,
           items: [
+            { id: "nav_approvals_inbox", type: "component", label: "Approvals Inbox", componentRef: "approvals:inbox", icon: "list-checks" },
             { id: "nav_approval_requests", type: "object", label: "Requests", objectName: "sys_approval_request", icon: "inbox", requiresObject: "sys_approval_request" },
             { id: "nav_approval_actions", type: "object", label: "Action History", objectName: "sys_approval_action", icon: "history", requiresObject: "sys_approval_action" },
             { id: "nav_approval_delegations", type: "object", label: "Delegations (OOO)", objectName: "sys_approval_delegation", icon: "user-clock", requiresObject: "sys_approval_delegation" }
@@ -6021,7 +6063,14 @@ var ApprovalsServicePlugin = class {
     };
     const mountActionPages = async () => {
       try {
-        const http = ctx.getService("http-server");
+        const readServer = (name) => {
+          try {
+            return ctx.getService(name);
+          } catch {
+            return void 0;
+          }
+        };
+        const http = readServer("http.server") ?? readServer("http-server");
         const rawApp = http && typeof http.getRawApp === "function" ? http.getRawApp() : null;
         if (!rawApp || !this.service) return;
         const svc = this.service;