@objectstack/plugin-approvals 17.0.0-rc.5 → 17.0.0-rc.6

package/dist/index.js

@@ -63,11 +63,11 @@ var init_en_objects_generated = __esm({
             label: "Status",
             help: "Lifecycle state of the request",
             options: {
-              pending: "pending",
-              approved: "approved",
-              rejected: "rejected",
-              recalled: "recalled",
-              returned: "returned"
+              pending: "Pending",
+              approved: "Approved",
+              rejected: "Rejected",
+              recalled: "Recalled",
+              returned: "Returned"
             }
           },
           current_step: {
@@ -384,7 +384,7 @@ var init_zh_CN_objects_generated = __esm({
             label: "\u72B6\u6001",
             help: "\u8BF7\u6C42\u7684\u751F\u547D\u5468\u671F\u72B6\u6001",
             options: {
-              pending: "\u5F85\u5904\u7406",
+              pending: "\u5F85\u5BA1\u6279",
               approved: "\u5DF2\u6279\u51C6",
               rejected: "\u5DF2\u62D2\u7EDD",
               recalled: "\u5DF2\u64A4\u56DE",
@@ -430,9 +430,9 @@ var init_zh_CN_objects_generated = __esm({
         },
         _views: {
           my_pending: {
-            label: "\u6211\u7684\u5F85\u529E",
+            label: "\u5F85\u6211\u5BA1\u6279",
             emptyState: {
-              title: "\u6682\u65E0\u5F85\u529E\u5BA1\u6279",
+              title: "\u6682\u65E0\u5F85\u5BA1\u6279\u7684\u8BF7\u6C42",
               message: "\u5168\u90E8\u5904\u7406\u5B8C\u6BD5\uFF0C\u6CA1\u6709\u7B49\u5F85\u4F60\u5BA1\u6279\u7684\u8BF7\u6C42\u3002"
             }
           },
@@ -751,7 +751,7 @@ var init_ja_JP_objects_generated = __esm({
         },
         _views: {
           my_pending: {
-            label: "\u81EA\u5206\u306E\u4FDD\u7559\u4E2D",
+            label: "\u627F\u8A8D\u5F85\u3061",
             emptyState: {
               title: "\u627F\u8A8D\u5F85\u3061\u306F\u3042\u308A\u307E\u305B\u3093",
               message: "\u3059\u3079\u3066\u51E6\u7406\u6E08\u307F\u3067\u3059\u3002\u3042\u306A\u305F\u306E\u627F\u8A8D\u3092\u5F85\u3064\u30EA\u30AF\u30A8\u30B9\u30C8\u306F\u3042\u308A\u307E\u305B\u3093\u3002"
@@ -1072,7 +1072,7 @@ var init_es_ES_objects_generated = __esm({
         },
         _views: {
           my_pending: {
-            label: "Mis pendientes",
+            label: "Aprobaciones pendientes",
             emptyState: {
               title: "Sin aprobaciones pendientes",
               message: "Est\xE1s al d\xEDa: nada espera tu aprobaci\xF3n."
@@ -5756,7 +5756,7 @@ function registerApprovalReviseNode(automation, logger) {
       paradigms: ["flow"],
       source: "plugin",
       supportsPause: true,
-      isAsync: true,
+      // (`isAsync` stood here — retired in #6748, ADR-0049: nothing read it)
       // #3823 / amended ADR-0044: THE point of this node type. The revise
       // window is a service-owned continuation, so the #3801 gate must refuse
       // a raw resume of it — which it does for any node type declaring this.
@@ -5808,7 +5808,7 @@ function registerApprovalNode(automation, service, logger) {
       source: "plugin",
       // Human decision: the run suspends here awaiting an external reply.
       supportsPause: true,
-      isAsync: true,
+      // (`isAsync` stood here — retired in #6748, ADR-0049: nothing read it)
       // #3801: this pause is NOT resumable through the generic run-resume
       // route. Continuing an approval is a side effect of a DECISION, and the
       // decision is the thing that must be authorized (the approver slate),
@@ -5859,6 +5859,17 @@ function registerApprovalNode(automation, service, logger) {
         }, {
           ...SYSTEM_CTX4,
           userId: context?.userId,
+          // [#7135] ⚠️ This assertion SURVIVES the annotation widening, and it
+          // is `as ExecutionContext` rather than the `as unknown as
+          // SharingExecutionContext` double cast it replaces. The sole reason
+          // a cast is still needed is `organizationId`, which is not a field
+          // of the envelope at ALL — that spelling has its own history (#5858
+          // / `check:org-identifier`) and was explicitly held out of this
+          // change (#7070), so removing the key here would be a RUNTIME change
+          // belonging to that card. Dropping the second hop matters: `as
+          // unknown as` erases the value entirely, while a single assertion
+          // still requires the literal to be comparable to the envelope, so a
+          // `userId: 42` here is once again a compile error.
           organizationId: context?.organizationId,
           tenantId: context?.tenantId
         });
@@ -5910,12 +5921,23 @@ var ApprovalsServicePlugin = class {
       // ADR-0029 D7 — contribute the Approvals entries into the Setup app's
       // `group_approvals` slot. This plugin owns these objects (K2.b), so it
       // ships their menu too; when the plugin isn't installed the slot is empty.
+      //
+      // #7234 — order inside the slot is ARRAY ORDER: `applyNavContributions`
+      // does `group.children.push(...c.items)` per contribution (sorted by
+      // `priority`), so the inbox being first in this array is what puts it
+      // above the raw tables. Do not reorder without meaning to.
+      //
+      // The inbox entry is the working surface (decision actions, node
+      // progress, drawer); the three object entries below stay as the
+      // admin/diagnostic view of the engine's own tables — reachable only here,
+      // behind `group_approvals`' `manage_platform_settings` gate.
       navigationContributions: [
         {
           app: "setup",
           group: "group_approvals",
           priority: 100,
           items: [
+            { id: "nav_approvals_inbox", type: "component", label: "Approvals Inbox", componentRef: "approvals:inbox", icon: "list-checks" },
             { id: "nav_approval_requests", type: "object", label: "Requests", objectName: "sys_approval_request", icon: "inbox", requiresObject: "sys_approval_request" },
             { id: "nav_approval_actions", type: "object", label: "Action History", objectName: "sys_approval_action", icon: "history", requiresObject: "sys_approval_action" },
             { id: "nav_approval_delegations", type: "object", label: "Delegations (OOO)", objectName: "sys_approval_delegation", icon: "user-clock", requiresObject: "sys_approval_delegation" }
@@ -6028,7 +6050,14 @@ var ApprovalsServicePlugin = class {
     };
     const mountActionPages = async () => {
       try {
-        const http = ctx.getService("http-server");
+        const readServer = (name) => {
+          try {
+            return ctx.getService(name);
+          } catch {
+            return void 0;
+          }
+        };
+        const http = readServer("http.server") ?? readServer("http-server");
         const rawApp = http && typeof http.getRawApp === "function" ? http.getRawApp() : null;
         if (!rawApp || !this.service) return;
         const svc = this.service;