@objectstack/plugin-approvals 16.1.0 → 17.0.0-rc.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@objectstack/plugin-approvals",
-  "version": "16.1.0",
+  "version": "17.0.0-rc.1",
   "license": "Apache-2.0",
   "description": "Multi-step approval engine for ObjectStack — sys_approval_process + sys_approval_request + sys_approval_action + IApprovalService.",
   "main": "dist/index.js",
@@ -13,17 +13,20 @@
     }
   },
   "dependencies": {
-    "@objectstack/core": "16.1.0",
-    "@objectstack/formula": "16.1.0",
-    "@objectstack/metadata-core": "16.1.0",
-    "@objectstack/platform-objects": "16.1.0",
-    "@objectstack/spec": "16.1.0"
+    "@objectstack/core": "17.0.0-rc.1",
+    "@objectstack/formula": "17.0.0-rc.1",
+    "@objectstack/metadata-core": "17.0.0-rc.1",
+    "@objectstack/platform-objects": "17.0.0-rc.1",
+    "@objectstack/spec": "17.0.0-rc.1",
+    "@objectstack/types": "17.0.0-rc.1"
   },
   "devDependencies": {
     "@types/node": "^26.1.1",
     "typescript": "^6.0.3",
     "vitest": "^4.1.10",
-    "@objectstack/service-automation": "16.1.0"
+    "@objectstack/objectql": "17.0.0-rc.1",
+    "@objectstack/service-automation": "17.0.0-rc.1",
+    "@objectstack/trigger-record-change": "17.0.0-rc.1"
   },
   "keywords": [
     "objectstack",
@@ -32,8 +35,14 @@
     "workflow",
     "process"
   ],
+  "files": [
+    "dist",
+    "README.md",
+    "CHANGELOG.md"
+  ],
   "scripts": {
     "build": "tsup --config ../../../tsup.config.ts",
+    "typecheck": "tsc --noEmit",
     "test": "vitest run --passWithNoTests"
   }
 }

package/.turbo/turbo-build.log

@@ -1,22 +0,0 @@
-
-> @objectstack/plugin-approvals@16.1.0 build /home/runner/work/objectstack/objectstack/packages/plugins/plugin-approvals
-> tsup --config ../../../tsup.config.ts
-
-CLI Building entry: src/index.ts
-CLI Using tsconfig: tsconfig.json
-CLI tsup v8.5.1
-CLI Using tsup config: /home/runner/work/objectstack/objectstack/tsup.config.ts
-CLI Target: es2020
-CLI Cleaning output folder
-ESM Build start
-CJS Build start
-ESM dist/index.mjs     156.89 KB
-ESM dist/index.mjs.map 275.84 KB
-ESM ⚡️ Build success in 357ms
-CJS dist/index.js     158.72 KB
-CJS dist/index.js.map 277.08 KB
-CJS ⚡️ Build success in 372ms
-DTS Build start
-DTS ⚡️ Build success in 22467ms
-DTS dist/index.d.mts 420.38 KB
-DTS dist/index.d.ts  420.38 KB

package/scripts/i18n-extract.config.ts

@@ -1,33 +0,0 @@
-// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license.
-
-/**
- * Build-time only config for `os i18n extract` (ADR-0029 D8). Not deployed.
- * The plugin owns the i18n extraction for the objects it owns; the
- * `translations` baseline is this plugin's OWN generated bundles so re-running
- * `--merge` preserves every hand-translated string. (Initial zh-CN/ja-JP/es-ES
- * strings were seeded from @objectstack/platform-objects.)
- *
- *   os i18n extract packages/plugins/plugin-approvals/scripts/i18n-extract.config.ts \
- *     --locales=zh-CN,ja-JP,es-ES --fill=default --objects-only \
- *     --out=packages/plugins/plugin-approvals/src/translations
- */
-
-import { defineStack } from '@objectstack/spec';
-import { SysApprovalRequest } from '../src/sys-approval-request.object.js';
-import { SysApprovalAction } from '../src/sys-approval-action.object.js';
-import { SysApprovalDelegation } from '../src/sys-approval-delegation.object.js';
-import { enObjects } from '../src/translations/en.objects.generated.js';
-import { zhCNObjects } from '../src/translations/zh-CN.objects.generated.js';
-import { jaJPObjects } from '../src/translations/ja-JP.objects.generated.js';
-import { esESObjects } from '../src/translations/es-ES.objects.generated.js';
-
-export default defineStack({
-  name: 'plugin-approvals-i18n-extract',
-  objects: [SysApprovalRequest, SysApprovalAction, SysApprovalDelegation] as any,
-  translations: [
-    { en: { objects: enObjects } },
-    { 'zh-CN': { objects: zhCNObjects } },
-    { 'ja-JP': { objects: jaJPObjects } },
-    { 'es-ES': { objects: esESObjects } },
-  ],
-});

package/src/action-link-pages.ts

@@ -1,102 +0,0 @@
-// Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.
-
-/**
- * Session-less HTML for the actionable-link confirm/result pages (ADR-0043).
- *
- * Deliberately tiny and dependency-free: these pages are reached from an
- * email or IM message by a bearer with no session, so they must not assume
- * the Console bundle, auth state, or client-side i18n. Static bilingual
- * (EN / 中文) copy keeps them readable for the demo audience without a
- * locale negotiation step.
- *
- * The GET page NEVER mutates — the decision happens only on the POST form
- * submit (mail-gateway link prefetchers must not approve requests).
- */
-
-import type { ApprovalRequestRow, ApprovalActionKind } from '@objectstack/spec/contracts';
-
-function esc(s: unknown): string {
-  return String(s ?? '')
-    .replaceAll('&', '&amp;').replaceAll('<', '&lt;').replaceAll('>', '&gt;')
-    .replaceAll('"', '&quot;').replaceAll("'", '&#39;');
-}
-
-function shell(title: string, body: string): string {
-  return `<!doctype html>
-<html lang="en"><head><meta charset="utf-8">
-<meta name="viewport" content="width=device-width, initial-scale=1">
-<meta name="robots" content="noindex">
-<title>${esc(title)}</title>
-<style>
-  body{font:15px/1.6 -apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"PingFang SC","Microsoft YaHei",sans-serif;
-       background:#f6f7f9;color:#1a202c;margin:0;display:flex;min-height:100vh;align-items:center;justify-content:center}
-  .card{background:#fff;border:1px solid #e2e8f0;border-radius:12px;max-width:440px;width:calc(100% - 32px);
-        padding:28px 32px;box-shadow:0 1px 3px rgba(0,0,0,.06)}
-  h1{font-size:18px;margin:0 0 4px}
-  .sub{color:#64748b;font-size:13px;margin:0 0 20px}
-  .row{display:flex;justify-content:space-between;gap:12px;padding:7px 0;border-bottom:1px solid #f1f5f9;font-size:14px}
-  .row b{font-weight:600;text-align:right}
-  .k{color:#64748b}
-  .actions{margin-top:22px;display:flex;gap:10px}
-  button{flex:1;padding:10px 16px;border-radius:8px;border:1px solid transparent;font-size:15px;font-weight:600;cursor:pointer}
-  .approve{background:#059669;color:#fff}
-  .reject{background:#fff;color:#dc2626;border-color:#fca5a5}
-  .badge{display:inline-block;padding:2px 10px;border-radius:999px;font-size:12px;font-weight:600;margin-bottom:14px}
-  .ok{background:#ecfdf5;color:#047857}.warn{background:#fffbeb;color:#b45309}.err{background:#fef2f2;color:#b91c1c}
-  a{color:#2563eb;text-decoration:none}
-  .foot{margin-top:18px;font-size:12px;color:#94a3b8}
-</style></head><body><div class="card">${body}</div></body></html>`;
-}
-
-function summaryRows(req: ApprovalRequestRow): string {
-  const rows: Array<[string, string]> = [
-    ['Process · 流程', req.process_label || req.process_name],
-    ['Step · 步骤', req.step_label || req.current_step || '—'],
-    ['Record · 记录', req.record_title || req.record_id],
-    ['Object · 对象', req.object_label || req.object_name],
-    ['Requester · 申请人', req.submitter_name || req.submitter_id || '—'],
-  ];
-  return rows.map(([k, v]) => `<div class="row"><span class="k">${esc(k)}</span><b>${esc(v)}</b></div>`).join('');
-}
-
-/** GET page: summary + a POST form. Rendering only — no mutation. */
-export function renderConfirmPage(input: {
-  request: ApprovalRequestRow;
-  action: Extract<ApprovalActionKind, 'approve' | 'reject'>;
-  approverId: string;
-  token: string;
-  actPath: string;
-}): string {
-  const approving = input.action === 'approve';
-  const verb = approving ? 'Approve · 通过' : 'Reject · 拒绝';
-  return shell(`${verb} — Approval`, `
-    <h1>${approving ? '✅ Approve this request?' : '⛔ Reject this request?'}</h1>
-    <p class="sub">${approving ? '确认通过该审批请求？' : '确认拒绝该审批请求？'}
-      Acting as · 操作身份：<b>${esc(input.approverId)}</b></p>
-    ${summaryRows(input.request)}
-    <form method="post" action="${esc(input.actPath)}" class="actions">
-      <input type="hidden" name="token" value="${esc(input.token)}">
-      <button type="submit" class="${approving ? 'approve' : 'reject'}">${verb}</button>
-    </form>
-    <p class="foot">This link is single-use and expires automatically. · 此链接一次有效，过期自动失效。</p>`);
-}
-
-const RESULT_COPY: Record<string, { cls: string; title: string; body: string }> = {
-  approved:     { cls: 'ok',   title: '✅ Approved · 已通过',  body: 'The decision was recorded. · 审批结果已记录。' },
-  rejected:     { cls: 'ok',   title: '⛔ Rejected · 已拒绝',  body: 'The decision was recorded. · 审批结果已记录。' },
-  invalid:      { cls: 'err',  title: 'Invalid link · 链接无效', body: 'This link is not recognized. · 无法识别该链接。' },
-  expired:      { cls: 'warn', title: 'Link expired · 链接已过期', body: 'Ask the requester to send a new reminder. · 请让申请人重新发送催办。' },
-  consumed:     { cls: 'warn', title: 'Already used · 链接已使用', body: 'This link was already used once. · 该链接已被使用过。' },
-  not_pending:  { cls: 'warn', title: 'Already decided · 请求已处理', body: 'This request is no longer pending. · 该请求已不在待审批状态。' },
-  not_approver: { cls: 'warn', title: 'No longer your approval · 已不在你名下', body: 'This approval was handed to someone else. · 该审批已转由他人处理。' },
-};
-
-/** Terminal page for every redemption outcome (and stale GETs). */
-export function renderResultPage(kind: keyof typeof RESULT_COPY, request?: ApprovalRequestRow): string {
-  const copy = RESULT_COPY[kind] ?? RESULT_COPY.invalid;
-  return shell(copy.title, `
-    <span class="badge ${copy.cls}">${esc(copy.title)}</span>
-    ${request ? summaryRows(request) : ''}
-    <p>${esc(copy.body)}</p>
-    <p class="foot"><a href="/system/approvals">Open the Approvals Inbox · 打开审批中心</a></p>`);
-}

package/src/approval-node.test.ts

@@ -1,196 +0,0 @@
-// Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.
-
-import { describe, it, expect, beforeEach } from 'vitest';
-import { AutomationEngine } from '@objectstack/service-automation';
-import { ApprovalService } from './approval-service.js';
-import { registerApprovalNode } from './approval-node.js';
-
-const SYSTEM_CTX = { isSystem: true, positions: [], permissions: [] } as any;
-
-const noopLogger = {
-  info() {}, warn() {}, error() {}, debug() {},
-};
-
-/**
- * Tiny in-memory ObjectQL stand-in — supports the `where`-equality + `$in`
- * queries the approval service issues, enough to drive the node bridge.
- */
-function makeFakeEngine() {
-  const tables = new Map<string, any[]>();
-  const rows = (o: string) => (tables.get(o) ?? (tables.set(o, []), tables.get(o)!));
-  const matches = (row: any, where: any) => Object.entries(where ?? {}).every(([k, v]) => {
-    if (v && typeof v === 'object' && '$in' in (v as any)) return (v as any).$in.includes(row[k]);
-    if (v && typeof v === 'object' && '$ne' in (v as any)) return row[k] !== (v as any).$ne;
-    return row[k] === v;
-  });
-  return {
-    tables,
-    async find(object: string, opts: any = {}) {
-      const where = opts.where ?? opts.filter ?? {};
-      let out = rows(object).filter(r => matches(r, where));
-      if (opts.limit) out = out.slice(0, opts.limit);
-      return out.map(r => ({ ...r }));
-    },
-    async insert(object: string, data: any) {
-      rows(object).push({ ...data });
-      return { ...data };
-    },
-    async update(object: string, idOrData: any) {
-      const id = idOrData.id;
-      const row = rows(object).find(r => r.id === id);
-      if (row) Object.assign(row, idOrData);
-      return row ? { ...row } : null;
-    },
-    async delete(object: string, opts: any = {}) {
-      const where = opts.where ?? {};
-      const list = rows(object);
-      for (let i = list.length - 1; i >= 0; i--) if (matches(list[i], where)) list.splice(i, 1);
-      return { affected: 1 };
-    },
-  };
-}
-
-function registerDecisionFlow(engine: AutomationEngine, approvers: Array<{ type: string; value?: string }>, behavior?: 'first_response' | 'unanimous') {
-  engine.registerFlow('deal_approval', {
-    name: 'deal_approval',
-    label: 'Deal Approval',
-    type: 'autolaunched',
-    nodes: [
-      { id: 'start', type: 'start', label: 'Start' },
-      { id: 'approve_step', type: 'approval', label: 'Manager Approval', config: { approvers, behavior } },
-      { id: 'on_approved', type: 'mark', label: 'Approved' },
-      { id: 'on_rejected', type: 'mark', label: 'Rejected' },
-      { id: 'end', type: 'end', label: 'End' },
-    ],
-    edges: [
-      { id: 'e1', source: 'start', target: 'approve_step' },
-      { id: 'e2', source: 'approve_step', target: 'on_approved', label: 'approve' },
-      { id: 'e3', source: 'approve_step', target: 'on_rejected', label: 'reject' },
-      { id: 'e4', source: 'on_approved', target: 'end' },
-      { id: 'e5', source: 'on_rejected', target: 'end' },
-    ],
-  });
-}
-
-describe('Approval node bridge (ADR-0019)', () => {
-  let automation: AutomationEngine;
-  let service: ApprovalService;
-  let fake: ReturnType<typeof makeFakeEngine>;
-  const marks: string[] = [];
-
-  beforeEach(() => {
-    marks.length = 0;
-    automation = new AutomationEngine(noopLogger as any);
-    fake = makeFakeEngine();
-    service = new ApprovalService({ engine: fake as any, logger: noopLogger });
-    // The contract `decide()` resumes via the attached automation surface.
-    service.attachAutomation(automation);
-    registerApprovalNode(automation, service, noopLogger);
-    // A terminal "mark" node records which branch ran.
-    automation.registerNodeExecutor({
-      type: 'mark',
-      async execute(node: any) { marks.push(node.id); return { success: true }; },
-    });
-  });
-
-  it('publishes an approval action descriptor that supports pause', () => {
-    const descriptors = automation.getActionDescriptors();
-    const approval = descriptors.find(d => d.type === 'approval');
-    expect(approval).toBeDefined();
-    expect(approval!.supportsPause).toBe(true);
-    expect(approval!.category).toBe('human');
-  });
-
-  it('suspends the run on entry and opens a pending request', async () => {
-    registerDecisionFlow(automation, [{ type: 'user', value: 'u1' }]);
-    const result = await automation.execute('deal_approval', {
-      object: 'crm_deal',
-      record: { id: 'd1', amount: 100 },
-      userId: 'submitter',
-    });
-    expect(result.status).toBe('paused');
-    expect(result.runId).toBeDefined();
-    expect(marks).toHaveLength(0);
-
-    const requests = await fake.find('sys_approval_request', { where: { status: 'pending' } });
-    expect(requests).toHaveLength(1);
-    expect(requests[0]).toMatchObject({
-      object_name: 'crm_deal', record_id: 'd1', flow_run_id: result.runId, flow_node_id: 'approve_step',
-    });
-    // Surfaced as a suspended run with the request id as correlation.
-    const suspended = automation.listSuspendedRuns();
-    expect(suspended[0]).toMatchObject({ nodeId: 'approve_step', correlation: requests[0].id });
-  });
-
-  it('carries the flow name + authored labels onto the request row', async () => {
-    registerDecisionFlow(automation, [{ type: 'user', value: 'u1' }]);
-    await automation.execute('deal_approval', {
-      object: 'crm_deal', record: { id: 'd1', amount: 100 }, userId: 'submitter',
-    });
-    const [raw] = await fake.find('sys_approval_request', { where: { status: 'pending' } });
-    // Engine-seeded `$flowName` (not the node id) names the source…
-    expect(raw.process_name).toBe('flow:deal_approval');
-    // …and authored labels ride the config snapshot for inbox display.
-    const req = (await service.listRequests({ status: 'pending' }, { isSystem: true } as any))[0];
-    expect(req.process_label).toBe('Deal Approval');
-    expect(req.step_label).toBe('Manager Approval');
-  });
-
-  it('resumes down the approve branch on approval', async () => {
-    registerDecisionFlow(automation, [{ type: 'user', value: 'u1' }]);
-    const paused = await automation.execute('deal_approval', {
-      object: 'crm_deal', record: { id: 'd1' }, userId: 'submitter',
-    });
-    const request = (await fake.find('sys_approval_request', { where: { status: 'pending' } }))[0];
-
-    const out = await service.decide(request.id, { decision: 'approve', actorId: 'u1' }, SYSTEM_CTX);
-
-    expect(out).toMatchObject({ finalized: true, decision: 'approve', resumed: true });
-    expect(marks).toEqual(['on_approved']);
-    expect(automation.listSuspendedRuns()).toHaveLength(0);
-
-    const finalReq = (await fake.find('sys_approval_request', { where: { id: request.id } }))[0];
-    expect(finalReq.status).toBe('approved');
-    expect(paused.runId).toBeDefined();
-  });
-
-  it('resumes down the reject branch on rejection', async () => {
-    registerDecisionFlow(automation, [{ type: 'user', value: 'u1' }]);
-    await automation.execute('deal_approval', { object: 'crm_deal', record: { id: 'd1' } });
-    const request = (await fake.find('sys_approval_request', { where: { status: 'pending' } }))[0];
-
-    const out = await service.decide(request.id, { decision: 'reject', actorId: 'u1' }, SYSTEM_CTX);
-
-    expect(out).toMatchObject({ finalized: true, decision: 'reject', resumed: true });
-    expect(marks).toEqual(['on_rejected']);
-  });
-
-  it('holds a unanimous step until every approver acts, then resumes', async () => {
-    registerDecisionFlow(automation, [
-      { type: 'user', value: 'u1' },
-      { type: 'user', value: 'u2' },
-    ], 'unanimous');
-    await automation.execute('deal_approval', { object: 'crm_deal', record: { id: 'd1' } });
-    const request = (await fake.find('sys_approval_request', { where: { status: 'pending' } }))[0];
-
-    const first = await service.decide(request.id, { decision: 'approve', actorId: 'u1' }, SYSTEM_CTX);
-    expect(first.finalized).toBe(false);
-    expect(first.resumed).toBe(false);
-    expect(marks).toHaveLength(0);
-
-    const second = await service.decide(request.id, { decision: 'approve', actorId: 'u2' }, SYSTEM_CTX);
-    expect(second.finalized).toBe(true);
-    expect(second.resumed).toBe(true);
-    expect(marks).toEqual(['on_approved']);
-  });
-
-  it('rejects a decision from a non-approver', async () => {
-    registerDecisionFlow(automation, [{ type: 'user', value: 'u1' }]);
-    await automation.execute('deal_approval', { object: 'crm_deal', record: { id: 'd1' } });
-    const request = (await fake.find('sys_approval_request', { where: { status: 'pending' } }))[0];
-
-    await expect(
-      service.decideNode(request.id, { decision: 'approve', actorId: 'intruder' }, { isSystem: false, positions: [], permissions: [] } as any),
-    ).rejects.toThrow(/FORBIDDEN/);
-  });
-});

package/src/approval-node.ts

@@ -1,139 +0,0 @@
-// Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.
-
-/**
- * Approval-as-flow-node provider (ADR-0019).
- *
- * Registers an `approval` node executor on the automation engine so an approval
- * rides the one flow engine as a durable-pause node:
- *
- *   1. On entry the node opens a `sys_approval_request` (reusing the mature
- *      approver-resolution / audit / lock / status-mirror machinery) and returns
- *      `{ suspend: true }` — the engine persists the run and stops traversal.
- *   2. A decision (`ApprovalService.decide`) finalizes the request and resumes
- *      the run down the matching `approve` / `reject` out-edge.
- *
- * The approval *state* (request/action rows) stays first-class and owned by this
- * plugin — a flow-run log can't drive an inbox / recall / audit. Only the
- * orchestration (when to pause, which branch to take) moves onto the engine.
- */
-
-import {
-  defineActionDescriptor,
-  ApprovalNodeConfigSchema,
-  getApprovalNodeConfigJsonSchema,
-  APPROVAL_NODE_TYPE,
-  type ApprovalNodeConfig,
-} from '@objectstack/spec/automation';
-import type { SharingExecutionContext } from '@objectstack/spec/contracts';
-import type { ApprovalService } from './approval-service.js';
-
-/** Minimal surface of the automation engine this provider depends on. */
-export interface ApprovalAutomationSurface {
-  registerNodeExecutor(executor: {
-    type: string;
-    descriptor?: unknown;
-    execute(node: any, variables: Map<string, unknown>, context: any): Promise<{
-      success: boolean;
-      output?: Record<string, unknown>;
-      error?: string;
-      suspend?: boolean;
-      correlation?: string;
-    }>;
-  }): void;
-  resume?(runId: string, signal?: { output?: Record<string, unknown>; branchLabel?: string }): Promise<unknown>;
-}
-
-interface MinimalLogger {
-  info?: (msg: any, ...rest: any[]) => void;
-  warn?: (msg: any, ...rest: any[]) => void;
-}
-
-const SYSTEM_CTX = { isSystem: true, positions: [], permissions: [] } as const;
-
-/**
- * Register the `approval` node executor on the automation engine. Idempotent at
- * the engine level (re-registering replaces). Safe to skip when no automation
- * service is present.
- */
-export function registerApprovalNode(
-  automation: ApprovalAutomationSurface,
-  service: ApprovalService,
-  logger?: MinimalLogger,
-): void {
-  automation.registerNodeExecutor({
-    type: APPROVAL_NODE_TYPE,
-    descriptor: defineActionDescriptor({
-      type: APPROVAL_NODE_TYPE,
-      version: '1.0.0',
-      name: 'Approval',
-      description: 'Route a record for human approval; suspends the flow until a decision, '
-        + 'then continues down the approve / reject branch.',
-      icon: 'check-circle',
-      category: 'human',
-      paradigms: ['flow'],
-      source: 'plugin',
-      // Human decision: the run suspends here awaiting an external reply.
-      supportsPause: true,
-      isAsync: true,
-      // Publish the node's config contract (ADR-0018 §configSchema) so the
-      // Studio flow designer renders the Approval property form from the engine
-      // rather than a hardcoded client form — the engine owns the shape.
-      configSchema: getApprovalNodeConfigJsonSchema(),
-    }),
-    async execute(node, variables, context) {
-      const parsed = ApprovalNodeConfigSchema.safeParse(node.config ?? {});
-      if (!parsed.success) {
-        const msg = parsed.error.issues.map(i => `${i.path.join('.')}: ${i.message}`).join('; ');
-        return { success: false, error: `Approval node '${node.id}' has invalid config: ${msg}` };
-      }
-      const config = parsed.data as ApprovalNodeConfig;
-
-      const runId = variables.get('$runId');
-      const record = (variables.get('$record') ?? context?.record ?? {}) as Record<string, unknown>;
-      const object = (context?.object ?? (record as any)?.object_name) as string | undefined;
-      const recordId = (record as any)?.id as string | undefined;
-
-      if (!runId) return { success: false, error: `Approval node '${node.id}': missing $runId` };
-      if (!object) return { success: false, error: `Approval node '${node.id}': no target object in context` };
-      if (!recordId) return { success: false, error: `Approval node '${node.id}': no record id in $record` };
-
-      // Flow identity comes from engine-seeded variables (`$flowName` /
-      // `$flowLabel`) so the request row can carry a human-readable origin;
-      // `context.flowName` is a legacy fallback for direct callers.
-      const flowName = (variables.get('$flowName') as string | undefined) ?? context?.flowName;
-      const flowLabel = variables.get('$flowLabel') as string | undefined;
-
-      try {
-        const request = await service.openNodeRequest({
-          object,
-          recordId: String(recordId),
-          runId: String(runId),
-          nodeId: node.id,
-          config,
-          flowName,
-          flowLabel,
-          nodeLabel: typeof node.label === 'string' ? node.label : undefined,
-          submitterId: context?.userId ?? null,
-          record,
-          organizationId: context?.organizationId ?? context?.tenantId ?? null,
-        }, {
-          ...SYSTEM_CTX,
-          userId: context?.userId,
-          organizationId: context?.organizationId,
-          tenantId: context?.tenantId,
-        } as unknown as SharingExecutionContext);
-
-        logger?.info?.('[approvals] approval node suspended run', {
-          node: node.id, request: request.id, run: String(runId),
-        });
-        // Suspend the run; the request id is the correlation key surfaced on
-        // the suspended-run record for lookup.
-        return { success: true, suspend: true, correlation: request.id };
-      } catch (err: any) {
-        return { success: false, error: `Approval node '${node.id}': ${err?.message ?? String(err)}` };
-      }
-    },
-  });
-
-  logger?.info?.('[approvals] approval node executor registered');
-}