@objectstack/metadata 17.0.0 → 17.2.0

package/dist/node.cjs

@@ -4538,7 +4538,10 @@ var ARTIFACT_FIELD_TO_TYPE = {
   dashboards: "dashboard",
   reports: "report",
   actions: "action",
-  themes: "theme",
+  // `themes: 'theme'` removed at #10485 (ADR-0049): the carrier key is
+  // retired, so a parsed artifact can no longer carry the field — and the
+  // ingest half of the dead pipeline (items stored, read by nothing) goes
+  // with the authoring half rather than surviving it as drift.
   workflows: "workflow",
   flows: "flow",
   // ADR-0090 D3: stacks declare `positions` (stack.zod.ts); the retired
@@ -4591,6 +4594,7 @@ var MetadataPlugin = class {
      */
     this.optionalDependencies = ["com.objectstack.engine.objectql"];
     this.init = async (ctx) => {
+      this.initCtx = ctx;
       ctx.logger.info("Initializing Metadata Manager", {
         root: this.options.rootDir || process.cwd(),
         watch: this.options.watch,
@@ -4772,7 +4776,22 @@ var MetadataPlugin = class {
         console.warn("[MetadataPlugin] Failed to register HMR endpoint", e?.message);
       }
     };
-    this.stop = async (ctx) => {
+    /**
+     * Teardown — the kernel's ONLY teardown hook.
+     *
+     * [#10772] This body used to be spelled `stop(ctx)`. `Plugin`
+     * (`@objectstack/core`'s `types.ts`) declares `init()`, `start?(ctx)` and
+     * `destroy?()` and no `stop()`, and `ObjectKernel.performShutdown()` /
+     * `LiteKernel.destroy()` walk the plugins in reverse calling
+     * `plugin.destroy()` — so the artifact watcher, the manager and the
+     * repository were all still held after `await kernel.shutdown()` had
+     * RESOLVED. The `start`/`stop` pair read symmetric to a reviewer because
+     * `start()` really is on the interface; only one half was ever called.
+     *
+     * Idempotent: every handle is cleared as it is released, so a second
+     * teardown is a no-op rather than a second close.
+     */
+    this.destroy = async () => {
       if (this.artifactWatcher) {
         try {
           await this.artifactWatcher.close();
@@ -4783,7 +4802,7 @@ var MetadataPlugin = class {
       try {
         await this.manager.dispose();
       } catch (e) {
-        ctx.logger.warn("[MetadataPlugin] manager.dispose() failed", { error: e?.message });
+        this.initCtx?.logger?.warn?.("[MetadataPlugin] manager.dispose() failed", { error: e?.message });
       }
       const repo = this.repository;
       if (repo && typeof repo.close === "function") {
@@ -4794,13 +4813,25 @@ var MetadataPlugin = class {
       }
       this.repository = void 0;
     };
+    /**
+     * Retained alias for {@link destroy}. Kept because it is public API of an
+     * exported class: an embedder may have learned to call it directly
+     * precisely BECAUSE the kernel never did, and deleting it would break them.
+     * Still an arrow property, so a detached `const { stop } = plugin` call
+     * keeps working too. The parameter is now optional and ignored —
+     * `destroy()` takes no context, so teardown logs through the context
+     * captured in `init()`.
+     */
+    this.stop = async (_ctx) => {
+      await this.destroy();
+    };
     this.options = {
-      watch: true,
-      ...options
+      ...options,
+      watch: options.watch ?? false
     };
     const rootDir = this.options.rootDir || process.cwd();
     const bootstrapMode = this.options.config?.bootstrap ?? "eager";
-    const effectiveWatch = bootstrapMode === "artifact-only" ? false : this.options.watch ?? true;
+    const effectiveWatch = bootstrapMode === "artifact-only" ? false : this.options.watch ?? false;
     this.manager = new NodeMetadataManager({
       rootDir,
       watch: effectiveWatch,