@objectstack/lint 15.1.0 → 16.0.0-rc.0

package/dist/index.js

@@ -7,6 +7,18 @@ var CHART_FIELD_UNKNOWN = "chart-field-unknown";
 var CHART_CONFIG_MISSING = "chart-config-missing";
 var TABLE_COUNT_ONLY = "table-count-only";
 var MEASURE_AGGREGATE_INCOHERENT = "measure-aggregate-incoherent";
+var WIDGET_LEGACY_ANALYTICS_SHAPE = "widget-legacy-analytics-shape";
+var WIDGET_LEGACY_ANALYTICS_UNRENDERABLE = "widget-legacy-analytics-unrenderable";
+var LEGACY_ANALYTICS_KEYS = [
+  "categoryField",
+  "valueField",
+  "xAxisField",
+  "yAxisFields",
+  "aggregate",
+  "aggregation",
+  "rowField",
+  "columnField"
+];
 function asArray(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
@@ -128,6 +140,29 @@ function validateWidgetBindings(stack) {
         if (f.severity === "warning" && suppressed(f.rule)) return;
         findings.push({ ...f, where, path });
       };
+      const legacyUsed = LEGACY_ANALYTICS_KEYS.filter((k) => w[k] !== void 0);
+      if (legacyUsed.length > 0) {
+        const optionsData = typeof w.options === "object" && w.options !== null && w.options.data !== void 0;
+        const hasDataSource = w.dataset !== void 0 || w.object !== void 0 || w.data !== void 0 || optionsData;
+        const keyList = legacyUsed.map((k) => `\`${k}\``).join(", ");
+        const plural = legacyUsed.length > 1;
+        const datasetHint = `Bind a semantic dataset and select fields BY NAME: \`dataset: '<name>', dimensions: [...], values: [...]\`. Dataset-bound widgets render through DatasetWidget (pivot rows/cols come from \`dimensions\`, cell values from \`values\`).`;
+        if (!hasDataSource) {
+          push({
+            severity: "error",
+            rule: WIDGET_LEGACY_ANALYTICS_UNRENDERABLE,
+            message: `sets legacy analytics key${plural ? "s" : ""} ${keyList} (removed by the ADR-0021 single-form cutover) and binds no data source (no \`dataset\`, \`object\`, or inline \`data\`) \u2014 it renders nothing.`,
+            hint: `${datasetHint} The renderer ignores the legacy keys, so without a data source this widget has no data at all.`
+          });
+        } else {
+          push({
+            severity: "warning",
+            rule: WIDGET_LEGACY_ANALYTICS_SHAPE,
+            message: `sets legacy analytics key${plural ? "s" : ""} ${keyList} that the ADR-0021 single-form cutover removed \u2014 the dashboard renderer ignores ${plural ? "them" : "it"}.`,
+            hint: `${datasetHint} These inline keys are a no-op. Suppress with suppressWarnings: ['${WIDGET_LEGACY_ANALYTICS_SHAPE}'] if intentional.`
+          });
+        }
+      }
       const dsName = typeof w.dataset === "string" ? w.dataset : void 0;
       const dataset = dsName ? datasets.get(dsName) : void 0;
       if (dsName && !dataset) {
@@ -248,17 +283,42 @@ function buildFieldIndex(objects) {
   }
   return idx;
 }
+function buildFieldTypeIndex(objects) {
+  const idx = /* @__PURE__ */ new Map();
+  for (const obj of objects) {
+    const name = typeof obj.name === "string" ? obj.name : void 0;
+    if (!name) continue;
+    const fields = obj.fields;
+    const types = {};
+    if (Array.isArray(fields)) {
+      for (const f of fields) {
+        const fn = f?.name;
+        const ft = f?.type;
+        if (typeof fn === "string" && typeof ft === "string") types[fn] = ft;
+      }
+    } else if (fields && typeof fields === "object") {
+      for (const [fn, def] of Object.entries(fields)) {
+        const ft = def?.type;
+        if (typeof ft === "string") types[fn] = ft;
+      }
+    }
+    idx.set(name, types);
+  }
+  return idx;
+}
 function validateStackExpressions(stack) {
   const issues = [];
   const objects = asArray2(stack.objects);
   const fieldIndex = buildFieldIndex(objects);
+  const fieldTypeIndex = buildFieldTypeIndex(objects);
   const check = (where, raw, objectName, scope = "flattened") => {
     if (raw == null) return;
     const fields = objectName ? fieldIndex.get(objectName) : void 0;
+    const fieldTypes = objectName ? fieldTypeIndex.get(objectName) : void 0;
     const res = validateExpression(
       "predicate",
       raw,
-      objectName ? { objectName, fields, scope } : { scope }
+      objectName ? { objectName, fields, fieldTypes, scope } : { scope }
     );
     for (const e of res.errors) issues.push({ where, message: e.message, source: e.source, severity: "error" });
     for (const w of res.warnings) issues.push({ where, message: w.message, source: w.source, severity: "warning" });
@@ -306,19 +366,6 @@ function validateStackExpressions(stack) {
     }
     const fields = obj.fields;
     const fieldList = Array.isArray(fields) ? fields : fields && typeof fields === "object" ? Object.values(fields) : [];
-    if (obj.external != null) {
-      const fieldEntries = Array.isArray(fields) ? fields.map((f) => [f?.name ?? "?", f]) : fields && typeof fields === "object" ? Object.entries(fields) : [];
-      for (const [fname, fdef] of fieldEntries) {
-        if (fdef && typeof fdef === "object" && fdef.columnName != null) {
-          issues.push({
-            where: `object '${objectName}' \xB7 field '${fname}'`,
-            message: `external object '${objectName}': field '${fname}' sets columnName='${String(fdef.columnName)}', which is not supported on federated objects (ADR-0062 D7). The driver's query pipeline ignores field.columnName for external objects; map remote columns via the datasource's external.columnMap instead.`,
-            source: `columnName='${String(fdef.columnName)}'`,
-            severity: "error"
-          });
-        }
-      }
-    }
     for (const f of fieldList) {
       if (f && typeof f === "object") {
         const fname = f.name ?? "?";
@@ -330,7 +377,7 @@ function validateStackExpressions(stack) {
         const res = validateExpression(
           "value",
           f.formula,
-          objectName ? { objectName, fields: fieldIndex.get(objectName), scope: "record" } : { scope: "record" }
+          objectName ? { objectName, fields: fieldIndex.get(objectName), fieldTypes: fieldTypeIndex.get(objectName), scope: "record" } : { scope: "record" }
         );
         const fieldWhere = `object '${objectName}' \xB7 field '${f.name ?? "?"}' formula`;
         for (const e of res.errors) issues.push({ where: fieldWhere, message: e.message, source: e.source, severity: "error" });
@@ -437,6 +484,117 @@ function validateListViewMode(stack) {
   return out;
 }
 
+// src/validate-flow-trigger-readiness.ts
+var FLOW_TRIGGER_UNKNOWN_OBJECT = "flow-trigger-unknown-object";
+var FLOW_DRAFT_STATUS_AMBIGUOUS = "flow-draft-status-ambiguous";
+function asArray4(v) {
+  if (Array.isArray(v)) return v;
+  if (v && typeof v === "object") {
+    return Object.entries(v).map(([name, def]) => ({
+      name,
+      ...def
+    }));
+  }
+  return [];
+}
+function startNodeOf(flow) {
+  const nodes = Array.isArray(flow.nodes) ? flow.nodes : [];
+  const index = nodes.findIndex((n) => n?.type === "start");
+  return index >= 0 ? { node: nodes[index], index } : void 0;
+}
+function validateFlowTriggerReadiness(stack) {
+  const findings = [];
+  const flows = asArray4(stack.flows);
+  if (flows.length === 0) return findings;
+  const objectNames = new Set(
+    asArray4(stack.objects).map((o) => typeof o.name === "string" ? o.name : void 0).filter((n) => !!n)
+  );
+  flows.forEach((flow, flowIndex) => {
+    const flowName = typeof flow.name === "string" ? flow.name : `#${flowIndex}`;
+    const start = startNodeOf(flow);
+    const config = start?.node.config ?? {};
+    const triggerType = typeof config.triggerType === "string" ? config.triggerType : void 0;
+    const isRecordTriggered = !!triggerType && triggerType.startsWith("record-");
+    const isTimeRelative = config.timeRelative != null && typeof config.timeRelative === "object";
+    const isAutoTriggered = isRecordTriggered || triggerType === "api" || config.schedule != null || isTimeRelative || flow.type === "schedule" || flow.type === "api";
+    if (isRecordTriggered && start) {
+      const objectName = typeof config.objectName === "string" ? config.objectName : void 0;
+      if (objectName && !objectNames.has(objectName) && !objectName.startsWith("sys_")) {
+        findings.push({
+          severity: "warning",
+          rule: FLOW_TRIGGER_UNKNOWN_OBJECT,
+          where: `flow "${flowName}" \u203A start node`,
+          path: `flows[${flowIndex}].nodes[${start.index}].config.objectName`,
+          message: `targets object '${objectName}', which this stack does not define \u2014 if the name is wrong, the flow will never fire (and the runtime stays silent about it).`,
+          hint: `Object names match exactly. Check config.objectName against the object's registered name (e.g. 'app_candidate', not 'candidate'). If the object comes from another installed package, this warning can be ignored.`
+        });
+      }
+    }
+    if (isTimeRelative && start) {
+      const tr = config.timeRelative;
+      const objectName = typeof tr.object === "string" ? tr.object : void 0;
+      if (objectName && !objectNames.has(objectName) && !objectName.startsWith("sys_")) {
+        findings.push({
+          severity: "warning",
+          rule: FLOW_TRIGGER_UNKNOWN_OBJECT,
+          where: `flow "${flowName}" \u203A start node`,
+          path: `flows[${flowIndex}].nodes[${start.index}].config.timeRelative.object`,
+          message: `sweeps object '${objectName}', which this stack does not define \u2014 if the name is wrong, the sweep will match nothing (and the runtime stays quiet about it).`,
+          hint: `Object names match exactly. Check config.timeRelative.object against the object's registered name. If the object comes from another installed package, this warning can be ignored.`
+        });
+      }
+    }
+    if (isAutoTriggered && (flow.status == null || flow.status === "draft")) {
+      findings.push({
+        severity: "warning",
+        rule: FLOW_DRAFT_STATUS_AMBIGUOUS,
+        where: `flow "${flowName}"`,
+        path: `flows[${flowIndex}].status`,
+        message: `has status 'draft' (the default when none is authored). Draft flows DO still fire their triggers (only 'obsolete'/'invalid' disable), so the intent is ambiguous.`,
+        hint: `Declare status: 'active' to arm it deliberately, or status: 'obsolete' to disable it.`
+      });
+    }
+  });
+  return findings;
+}
+
+// src/validate-view-containers.ts
+var VIEW_CONTAINER_SHAPE = "view-container-shape";
+var CONTAINER_SLOT_KEYS = ["list", "form", "listViews", "formViews"];
+function asEntries(v) {
+  if (Array.isArray(v)) return v.map((value, i) => ({ key: `[${i}]`, value }));
+  if (v && typeof v === "object") {
+    return Object.entries(v).map(([name, value]) => ({ key: `.${name}`, value }));
+  }
+  return [];
+}
+function containerViewCount(rec) {
+  const named = (slot) => slot && typeof slot === "object" && !Array.isArray(slot) ? Object.keys(slot).length : 0;
+  return (rec.list ? 1 : 0) + (rec.form ? 1 : 0) + named(rec.listViews) + named(rec.formViews);
+}
+function validateViewContainers(stack) {
+  const out = [];
+  if (!stack || typeof stack !== "object") return out;
+  for (const { key, value } of asEntries(stack.views)) {
+    if (!value || typeof value !== "object" || Array.isArray(value)) continue;
+    const rec = value;
+    if (rec.viewKind != null) continue;
+    if (containerViewCount(rec) > 0) continue;
+    const label = typeof rec.name === "string" ? ` ("${rec.name}")` : "";
+    const hasContainerSlot = CONTAINER_SLOT_KEYS.some((k) => k in rec);
+    const looksFlat = !hasContainerSlot && ["type", "columns", "data", "filter", "sort"].some((k) => k in rec);
+    out.push({
+      severity: "error",
+      rule: VIEW_CONTAINER_SHAPE,
+      where: `views${key}${label}`,
+      path: `views${key}`,
+      message: looksFlat ? "Flat list-view object is not a view container: `ViewSchema` strips its keys, so it parses to an EMPTY container \u2014 zero views register and the Console renders no view for it." : "View container defines no views \u2014 all of `list` / `form` / `listViews` / `formViews` are absent or empty, so nothing registers.",
+      hint: "Wrap every view in a defineView container: defineView({ list: { type, data, columns, ... }, listViews: { ... }, formViews: { ... } }). See examples/app-showcase/src/ui/views/task.view.ts."
+    });
+  }
+  return out;
+}
+
 // src/validate-responsive-styles.ts
 var STYLE_NODE_MISSING_ID = "style-node-missing-id";
 var STYLE_CLASSNAME_TAILWIND = "style-classname-tailwind";
@@ -640,7 +798,7 @@ function looksLikeTailwind(className) {
     return false;
   });
 }
-function asArray4(v) {
+function asArray5(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -733,13 +891,13 @@ function checkNode(node, pageName, path, findings) {
 }
 function validateResponsiveStyles(stack) {
   const findings = [];
-  const pages = asArray4(stack.pages);
+  const pages = asArray5(stack.pages);
   for (let p = 0; p < pages.length; p++) {
     const page = pages[p];
     const pageName = typeof page.name === "string" ? page.name : `pages[${p}]`;
-    const regions = asArray4(page.regions);
+    const regions = asArray5(page.regions);
     for (let r = 0; r < regions.length; r++) {
-      const components = asArray4(regions[r].components);
+      const components = asArray5(regions[r].components);
       for (let c = 0; c < components.length; c++) {
         checkNode(components[c], pageName, `pages[${p}].regions[${r}].components[${c}]`, findings);
       }
@@ -750,10 +908,10 @@ function validateResponsiveStyles(stack) {
 
 // src/validate-jsx-pages.ts
 import { parseJsx, compile } from "@objectstack/sdui-parser";
-var asArray5 = (v) => Array.isArray(v) ? v : [];
+var asArray6 = (v) => Array.isArray(v) ? v : [];
 function validateJsxPages(stack, opts = {}) {
   const findings = [];
-  const pages = asArray5(stack.pages);
+  const pages = asArray6(stack.pages);
   for (let p = 0; p < pages.length; p++) {
     const page = pages[p];
     if (!page || page.kind !== "html" && page.kind !== "jsx") continue;
@@ -800,10 +958,10 @@ function loadSucraseTransform() {
   }
   return cachedTransform;
 }
-var asArray6 = (v) => Array.isArray(v) ? v : [];
+var asArray7 = (v) => Array.isArray(v) ? v : [];
 function validateReactPages(stack) {
   const findings = [];
-  const pages = asArray6(stack.pages);
+  const pages = asArray7(stack.pages);
   for (let p = 0; p < pages.length; p++) {
     const page = pages[p];
     if (!page || page.kind !== "react") continue;
@@ -854,7 +1012,7 @@ function loadTypeScript() {
   }
   return cachedTs;
 }
-var asArray7 = (v) => Array.isArray(v) ? v : [];
+var asArray8 = (v) => Array.isArray(v) ? v : [];
 var BLOCKS = new Map(
   REACT_BLOCKS.map((b) => [
     b.tag,
@@ -893,7 +1051,7 @@ function nearestKnown(prop, known) {
 }
 function validateReactPageProps(stack) {
   const findings = [];
-  const pages = asArray7(stack.pages);
+  const pages = asArray8(stack.pages);
   for (let p = 0; p < pages.length; p++) {
     const page = pages[p];
     if (!page || page.kind !== "react") continue;
@@ -961,11 +1119,11 @@ function validateReactPageProps(stack) {
 
 // src/validate-page-source-styling.ts
 var PAGE_SOURCE_CLASSNAME = "page-source-className-tailwind";
-var asArray8 = (v) => Array.isArray(v) ? v : [];
+var asArray9 = (v) => Array.isArray(v) ? v : [];
 var CLASSNAME_ATTR = /\bclassName\s*=\s*["'{]/g;
 function validatePageSourceStyling(stack) {
   const findings = [];
-  const pages = asArray8(stack.pages);
+  const pages = asArray9(stack.pages);
   for (let p = 0; p < pages.length; p++) {
     const page = pages[p];
     if (!page) continue;
@@ -994,7 +1152,7 @@ function validatePageSourceStyling(stack) {
 import { objectTitleCompleteness } from "@objectstack/spec/data";
 var TITLE_FORMAT_RETIRED = "title-format-retired";
 var TITLE_UNRESOLVABLE = "title-unresolvable";
-function asArray9(v) {
+function asArray10(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -1003,7 +1161,7 @@ function asArray9(v) {
 }
 function validateRecordTitle(stack) {
   const findings = [];
-  const objects = asArray9(stack.objects);
+  const objects = asArray10(stack.objects);
   for (let i = 0; i < objects.length; i++) {
     const obj = objects[i];
     const objName = typeof obj.name === "string" ? obj.name : `(object ${i})`;
@@ -1039,7 +1197,7 @@ var FIELD_GROUP_UNDECLARED = "field-group-undeclared";
 var FIELD_GROUP_EMPTY = "field-group-empty";
 var FIELD_GROUP_SHADOWED = "field-group-shadowed";
 var SEMANTIC_ROLE_FIELD_UNKNOWN = "semantic-role-field-unknown";
-function asArray10(v) {
+function asArray11(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -1048,7 +1206,7 @@ function asArray10(v) {
 }
 function validateSemanticRoles(stack) {
   const findings = [];
-  const objects = asArray10(stack.objects);
+  const objects = asArray11(stack.objects);
   for (let i = 0; i < objects.length; i++) {
     const obj = objects[i];
     if (!obj || typeof obj !== "object") continue;
@@ -1143,7 +1301,7 @@ function validateSemanticRoles(stack) {
 // src/validate-form-layout.ts
 var FORM_FIELD_UNKNOWN = "form-field-unknown";
 var FORM_COLSPAN_ABSOLUTE = "absolute-colspan-discouraged";
-function asArray11(v) {
+function asArray12(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -1168,13 +1326,13 @@ function boundObject(view) {
 function validateFormLayout(stack) {
   const findings = [];
   const objectFields = /* @__PURE__ */ new Map();
-  for (const obj of asArray11(stack.objects)) {
+  for (const obj of asArray12(stack.objects)) {
     const name = typeof obj.name === "string" ? obj.name : void 0;
     if (!name) continue;
     const fields = obj.fields && typeof obj.fields === "object" && !Array.isArray(obj.fields) ? Object.keys(obj.fields) : [];
     objectFields.set(name, new Set(fields));
   }
-  const views = asArray11(stack.views);
+  const views = asArray12(stack.views);
   for (let i = 0; i < views.length; i++) {
     const view = views[i];
     if (!view || typeof view !== "object") continue;
@@ -1224,7 +1382,7 @@ var VISIBILITY_ALIAS_DEPRECATED = "visibility-alias-deprecated";
 var VISIBILITY_ROOT_MISLAYERED = "visibility-root-mislayered";
 var CANONICAL = "visibleWhen";
 var ALIASES = ["visibleOn", "visibility"];
-function asArray12(v) {
+function asArray13(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -1286,7 +1444,7 @@ function isFieldObject(entry) {
 function validateVisibilityPredicates(stack, opts = {}) {
   const layer = opts.layer ?? "runtime";
   const findings = [];
-  const views = asArray12(stack.views);
+  const views = asArray13(stack.views);
   for (let i = 0; i < views.length; i++) {
     const view = views[i];
     if (!view || typeof view !== "object") continue;
@@ -1309,7 +1467,7 @@ function validateVisibilityPredicates(stack, opts = {}) {
       }
     }
   }
-  const pages = asArray12(stack.pages);
+  const pages = asArray13(stack.pages);
   for (let i = 0; i < pages.length; i++) {
     const page = pages[i];
     if (!page || typeof page !== "object") continue;
@@ -1333,7 +1491,7 @@ function validateVisibilityPredicates(stack, opts = {}) {
 // src/validate-capability-references.ts
 import { PLATFORM_CAPABILITY_NAMES } from "@objectstack/spec/security";
 var CAPABILITY_REFERENCE_UNKNOWN = "capability-reference-unknown";
-function asArray13(v) {
+function asArray14(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -1358,13 +1516,13 @@ function validateCapabilityReferences(stack) {
   const findings = [];
   if (!stack || typeof stack !== "object") return findings;
   const known = new Set(PLATFORM_CAPABILITY_NAMES);
-  for (const cap of asArray13(stack.capabilities)) {
+  for (const cap of asArray14(stack.capabilities)) {
     if (typeof cap.name === "string" && cap.name.length > 0) known.add(cap.name);
   }
-  for (const ps of asArray13(stack.permissions)) {
+  for (const ps of asArray14(stack.permissions)) {
     for (const cap of asCapArray(ps.systemPermissions)) known.add(cap);
   }
-  for (const seed of asArray13(stack.data)) {
+  for (const seed of asArray14(stack.data)) {
     if (seed.object !== "sys_capability") continue;
     for (const rec of Array.isArray(seed.records) ? seed.records : []) {
       const name = rec?.name;
@@ -1383,7 +1541,7 @@ function validateCapabilityReferences(stack) {
       hint
     });
   };
-  const objects = asArray13(stack.objects);
+  const objects = asArray14(stack.objects);
   for (let i = 0; i < objects.length; i++) {
     const obj = objects[i];
     if (!obj || typeof obj !== "object") continue;
@@ -1392,27 +1550,27 @@ function validateCapabilityReferences(stack) {
     for (const { cap, key } of flattenObjectRequired(obj.requiredPermissions)) {
       flag(cap, `object "${objName}"`, `${objPath}.requiredPermissions${key ? `.${key}` : ""}`);
     }
-    const fields = asArray13(obj.fields);
+    const fields = asArray14(obj.fields);
     for (const f of fields) {
       const fname = typeof f.name === "string" ? f.name : "(field)";
       for (const cap of asCapArray(f.requiredPermissions)) {
         flag(cap, `field "${objName}.${fname}"`, `${objPath}.fields.${fname}.requiredPermissions`);
       }
     }
-    for (const [ai, action] of asArray13(obj.actions).entries()) {
+    for (const [ai, action] of asArray14(obj.actions).entries()) {
       const aName = typeof action.name === "string" ? action.name : `(action ${ai})`;
       for (const cap of asCapArray(action.requiredPermissions)) {
         flag(cap, `action "${objName}.${aName}"`, `${objPath}.actions[${ai}].requiredPermissions`);
       }
     }
   }
-  for (const [i, action] of asArray13(stack.actions).entries()) {
+  for (const [i, action] of asArray14(stack.actions).entries()) {
     const aName = typeof action.name === "string" ? action.name : `(action ${i})`;
     for (const cap of asCapArray(action.requiredPermissions)) {
       flag(cap, `action "${aName}"`, `actions[${i}].requiredPermissions`);
     }
   }
-  const apps = asArray13(stack.apps);
+  const apps = asArray14(stack.apps);
   for (let i = 0; i < apps.length; i++) {
     const app = apps[i];
     if (!app || typeof app !== "object") continue;
@@ -1439,8 +1597,14 @@ function validateCapabilityReferences(stack) {
 }
 
 // src/validate-approval-approvers.ts
-import { ApproverType, APPROVAL_NODE_TYPE } from "@objectstack/spec/automation";
-var APPROVAL_ROLE_NOT_MEMBERSHIP_TIER = "approval-role-not-membership-tier";
+import {
+  ApproverType,
+  APPROVAL_NODE_TYPE,
+  DEPRECATED_APPROVER_TYPES,
+  canonicalApproverType
+} from "@objectstack/spec/automation";
+var APPROVAL_APPROVER_NOT_MEMBERSHIP_TIER = "approval-approver-not-membership-tier";
+var APPROVAL_APPROVER_TYPE_DEPRECATED = "approval-approver-type-deprecated";
 var APPROVAL_APPROVER_TYPE_UNKNOWN = "approval-approver-type-unknown";
 var APPROVAL_ESCALATION_REASSIGN_NO_TARGET = "approval-escalation-reassign-no-target";
 var MEMBERSHIP_TIERS = /* @__PURE__ */ new Set(["owner", "admin", "member", "guest"]);
@@ -1448,7 +1612,7 @@ var TYPE_FIX = {
   business_unit: "department",
   bu: "department"
 };
-function asArray14(v) {
+function asArray15(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -1458,7 +1622,7 @@ function asArray14(v) {
 function validateApprovalApprovers(stack) {
   const findings = [];
   if (!stack || typeof stack !== "object") return findings;
-  const flows = asArray14(stack.flows);
+  const flows = asArray15(stack.flows);
   const validTypes = new Set(ApproverType.options);
   for (let fi = 0; fi < flows.length; fi++) {
     const flow = flows[fi];
@@ -1490,14 +1654,25 @@ function validateApprovalApprovers(stack) {
           });
           continue;
         }
-        if (type === "role" && value && !MEMBERSHIP_TIERS.has(value.toLowerCase())) {
+        const canonical = canonicalApproverType(type);
+        if (canonical === "org_membership_level" && value && !MEMBERSHIP_TIERS.has(value.toLowerCase())) {
           findings.push({
             severity: "warning",
-            rule: APPROVAL_ROLE_NOT_MEMBERSHIP_TIER,
+            rule: APPROVAL_APPROVER_NOT_MEMBERSHIP_TIER,
             where,
             path: `${path}.value`,
-            message: `approver { type: 'role', value: '${value}' } resolves against the better-auth org-membership tier (sys_member.role: owner/admin/member) \u2014 '${value}' is not a membership tier, so this approver matches nobody and the request stalls.`,
-            hint: `If '${value}' is an org position, author { type: 'position', value: '${value}' } (resolved via sys_user_position, ADR-0090 D3). Keep type 'role' only for membership tiers (owner/admin/member).`
+            message: `approver { type: '${type}', value: '${value}' } resolves against the better-auth org-membership tier (sys_member.role: owner/admin/member) \u2014 '${value}' is not a membership tier, so this approver matches nobody and the request stalls.`,
+            hint: `If '${value}' is an org position, author { type: 'position', value: '${value}' } (resolved via sys_user_position, ADR-0090 D3). Keep type 'org_membership_level' only for membership tiers (owner/admin/member).`
+          });
+        } else if (type in DEPRECATED_APPROVER_TYPES) {
+          const fix = canonicalApproverType(type);
+          findings.push({
+            severity: "warning",
+            rule: APPROVAL_APPROVER_TYPE_DEPRECATED,
+            where,
+            path: `${path}.type`,
+            message: `approver type '${type}' is the deprecated spelling of '${fix}' (ADR-0090 D3) and is removed in the next major.`,
+            hint: `Author { type: '${fix}', value: '${value}' }. It resolves identically today.`
           });
         }
       }
@@ -1546,7 +1721,7 @@ var OWD_WIDTH = {
   public_read: 1,
   public_read_write: 2
 };
-function asArray15(v) {
+function asArray16(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -1572,7 +1747,7 @@ function refOf(def) {
   return typeof r === "string" && r ? r : void 0;
 }
 function firstMasterDetailField(obj) {
-  for (const f of asArray15(obj.fields)) {
+  for (const f of asArray16(obj.fields)) {
     if (f.type === "master_detail") {
       return { name: String(f.name ?? "?"), parent: refOf(f) };
     }
@@ -1585,8 +1760,8 @@ function grantsObjectAccess(p) {
 function validateSecurityPosture(stack, opts) {
   const findings = [];
   if (!stack || typeof stack !== "object") return findings;
-  const objects = asArray15(stack.objects);
-  const permissionSets = asArray15(stack.permissions);
+  const objects = asArray16(stack.objects);
+  const permissionSets = asArray16(stack.permissions);
   for (let i = 0; i < objects.length; i++) {
     const obj = objects[i];
     if (!obj || typeof obj !== "object") continue;
@@ -1715,10 +1890,10 @@ function validateSecurityPosture(stack, opts) {
     if (!obj || typeof obj !== "object" || isSystemObject(obj)) continue;
     const objName = typeof obj.name === "string" ? obj.name : `(object ${i})`;
     flagRole("object", obj.name, obj.label, `object "${objName}"`, `objects[${i}].name`);
-    for (const f of asArray15(obj.fields)) {
+    for (const f of asArray16(obj.fields)) {
       flagRole("field", f.name, f.label, `field "${objName}.${String(f.name ?? "?")}"`, `objects[${i}].fields.${String(f.name ?? "?")}.name`);
     }
-    for (const [ai, action] of asArray15(obj.actions).entries()) {
+    for (const [ai, action] of asArray16(obj.actions).entries()) {
       flagRole("action", action.name, action.label, `action "${objName}.${String(action.name ?? "?")}"`, `objects[${i}].actions[${ai}].name`);
     }
   }
@@ -1727,19 +1902,19 @@ function validateSecurityPosture(stack, opts) {
     if (!ps || typeof ps !== "object") continue;
     flagRole("permission set", ps.name, ps.label, `permission set "${String(ps.name ?? i)}"`, `permissions[${i}].name`);
   }
-  for (const [i, pos] of asArray15(stack.positions).entries()) {
+  for (const [i, pos] of asArray16(stack.positions).entries()) {
     flagRole("position", pos.name, pos.label, `position "${String(pos.name ?? i)}"`, `positions[${i}].name`);
   }
-  for (const [i, app] of asArray15(stack.apps).entries()) {
+  for (const [i, app] of asArray16(stack.apps).entries()) {
     flagRole("app", app.name, app.label, `app "${String(app.name ?? i)}"`, `apps[${i}].name`);
   }
-  for (const [i, book] of asArray15(stack.books).entries()) {
+  for (const [i, book] of asArray16(stack.books).entries()) {
     flagRole("book", book.name, book.label, `book "${String(book.name ?? i)}"`, `books[${i}].name`);
   }
   const stackSetNames = new Set(
     permissionSets.map((ps) => typeof ps.name === "string" ? ps.name : void 0).filter((n) => !!n)
   );
-  for (const [i, book] of asArray15(stack.books).entries()) {
+  for (const [i, book] of asArray16(stack.books).entries()) {
     const audience = book.audience;
     if (!audience || typeof audience !== "object") continue;
     const setName = audience.permissionSet;
@@ -1817,7 +1992,7 @@ function validateSecurityPosture(stack, opts) {
   }
   const GRANT_SEED_OBJECTS = /* @__PURE__ */ new Set(["sys_user_position", "sys_user_permission_set"]);
   const nowMs = opts?.nowMs ?? Date.now();
-  for (const [i, seed] of asArray15(stack.data).entries()) {
+  for (const [i, seed] of asArray16(stack.data).entries()) {
     const seedObject = typeof seed.object === "string" ? seed.object : "";
     if (!GRANT_SEED_OBJECTS.has(seedObject)) continue;
     const records = Array.isArray(seed.records) ? seed.records : [];
@@ -1858,7 +2033,7 @@ function validateSecurityPosture(stack, opts) {
 }
 
 // src/build-access-matrix.ts
-function asArray16(v) {
+function asArray17(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -1869,13 +2044,13 @@ function buildAccessMatrix(stack) {
   const entries = [];
   if (!stack || typeof stack !== "object") return { version: 1, entries };
   const owdByObject = /* @__PURE__ */ new Map();
-  for (const obj of asArray16(stack.objects)) {
+  for (const obj of asArray17(stack.objects)) {
     const name = typeof obj.name === "string" ? obj.name : "";
     if (!name) continue;
     const owd = obj.sharingModel ?? obj.security?.sharingModel;
     if (typeof owd === "string") owdByObject.set(name, owd);
   }
-  for (const ps of asArray16(stack.permissions)) {
+  for (const ps of asArray17(stack.permissions)) {
     const psName = typeof ps.name === "string" ? ps.name : "";
     if (!psName) continue;
     const objects = ps.objects && typeof ps.objects === "object" ? ps.objects : {};
@@ -1946,14 +2121,17 @@ function diffAccessMatrix(before, after) {
   return lines;
 }
 export {
+  APPROVAL_APPROVER_NOT_MEMBERSHIP_TIER,
+  APPROVAL_APPROVER_TYPE_DEPRECATED,
   APPROVAL_APPROVER_TYPE_UNKNOWN,
   APPROVAL_ESCALATION_REASSIGN_NO_TARGET,
-  APPROVAL_ROLE_NOT_MEMBERSHIP_TIER,
   CAPABILITY_REFERENCE_UNKNOWN,
   CHART_CONFIG_MISSING,
   CHART_FIELD_UNKNOWN,
   FIELD_GROUP_EMPTY,
   FIELD_GROUP_UNDECLARED,
+  FLOW_DRAFT_STATUS_AMBIGUOUS,
+  FLOW_TRIGGER_UNKNOWN_OBJECT,
   FORM_COLSPAN_ABSOLUTE,
   FORM_FIELD_UNKNOWN,
   LIST_VIEW_FILTERS_IN_VIEWS_MODE,
@@ -1979,6 +2157,7 @@ export {
   TABLE_COUNT_ONLY,
   TITLE_FORMAT_RETIRED,
   TITLE_UNRESOLVABLE,
+  VIEW_CONTAINER_SHAPE,
   VISIBILITY_ALIAS_DEPRECATED,
   VISIBILITY_ROOT_MISLAYERED,
   WIDGET_DATASET_UNKNOWN,
@@ -1988,6 +2167,7 @@ export {
   diffAccessMatrix,
   validateApprovalApprovers,
   validateCapabilityReferences,
+  validateFlowTriggerReadiness,
   validateFormLayout,
   validateJsxPages,
   validateListViewMode,
@@ -1999,6 +2179,7 @@ export {
   validateSecurityPosture,
   validateSemanticRoles,
   validateStackExpressions,
+  validateViewContainers,
   validateVisibilityPredicates,
   validateWidgetBindings
 };