@objectstack/lint 11.9.0 → 12.0.0

package/dist/index.js

@@ -371,6 +371,60 @@ function validateStackExpressions(stack) {
   return issues;
 }
 
+// src/validate-list-view-mode.ts
+var LIST_VIEW_FILTERS_IN_VIEWS_MODE = "list-view-filters-in-views-mode";
+var FORBIDDEN_FIELDS = ["userFilters", "quickFilters"];
+function asArray3(v) {
+  if (Array.isArray(v)) return v;
+  if (v && typeof v === "object") {
+    return Object.entries(v).map(([name, def]) => ({
+      name,
+      ...def
+    }));
+  }
+  return [];
+}
+function scanView(view, where, path, out) {
+  if (!view || typeof view !== "object") return;
+  const rec = view;
+  for (const field of FORBIDDEN_FIELDS) {
+    if (rec[field] == null) continue;
+    out.push({
+      severity: "error",
+      rule: LIST_VIEW_FILTERS_IN_VIEWS_MODE,
+      where,
+      path: `${path}.${field}`,
+      message: `\`${field}\` is a page filters-mode control and is ignored on an object list view ("views" mode) \u2014 the ViewTabBar is the only nav control here.`,
+      hint: `Move \`${field}\` to a page list (InterfaceListPage, "filters" mode), or remove it. See ADR-0053.`
+    });
+  }
+}
+function scanListViews(listViews, wherePrefix, pathPrefix, out) {
+  if (!listViews || typeof listViews !== "object") return;
+  for (const [name, view] of Object.entries(listViews)) {
+    scanView(
+      view,
+      `${wherePrefix} \u203A listViews.${name}`,
+      `${pathPrefix}.listViews.${name}`,
+      out
+    );
+  }
+}
+function validateListViewMode(stack) {
+  const out = [];
+  asArray3(stack.objects).forEach((obj, i) => {
+    const label = typeof obj.name === "string" ? `object "${obj.name}"` : `objects[${i}]`;
+    scanListViews(obj.listViews, label, `objects[${i}]`, out);
+  });
+  asArray3(stack.views).forEach((view, i) => {
+    const named = typeof view.objectName === "string" ? view.objectName : typeof view.name === "string" ? view.name : void 0;
+    const label = named ? `view "${named}"` : `views[${i}]`;
+    scanView(view.list, `${label} \u203A list`, `views[${i}].list`, out);
+    scanListViews(view.listViews, label, `views[${i}]`, out);
+  });
+  return out;
+}
+
 // src/validate-responsive-styles.ts
 var STYLE_NODE_MISSING_ID = "style-node-missing-id";
 var STYLE_CLASSNAME_TAILWIND = "style-classname-tailwind";
@@ -574,7 +628,7 @@ function looksLikeTailwind(className) {
     return false;
   });
 }
-function asArray3(v) {
+function asArray4(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -667,13 +721,13 @@ function checkNode(node, pageName, path, findings) {
 }
 function validateResponsiveStyles(stack) {
   const findings = [];
-  const pages = asArray3(stack.pages);
+  const pages = asArray4(stack.pages);
   for (let p = 0; p < pages.length; p++) {
     const page = pages[p];
     const pageName = typeof page.name === "string" ? page.name : `pages[${p}]`;
-    const regions = asArray3(page.regions);
+    const regions = asArray4(page.regions);
     for (let r = 0; r < regions.length; r++) {
-      const components = asArray3(regions[r].components);
+      const components = asArray4(regions[r].components);
       for (let c = 0; c < components.length; c++) {
         checkNode(components[c], pageName, `pages[${p}].regions[${r}].components[${c}]`, findings);
       }
@@ -684,10 +738,10 @@ function validateResponsiveStyles(stack) {
 
 // src/validate-jsx-pages.ts
 import { parseJsx, compile } from "@objectstack/sdui-parser";
-var asArray4 = (v) => Array.isArray(v) ? v : [];
+var asArray5 = (v) => Array.isArray(v) ? v : [];
 function validateJsxPages(stack, opts = {}) {
   const findings = [];
-  const pages = asArray4(stack.pages);
+  const pages = asArray5(stack.pages);
   for (let p = 0; p < pages.length; p++) {
     const page = pages[p];
     if (!page || page.kind !== "html" && page.kind !== "jsx") continue;
@@ -720,11 +774,24 @@ function validateJsxPages(stack, opts = {}) {
 }
 
 // src/validate-react-pages.ts
-import { transform } from "sucrase";
-var asArray5 = (v) => Array.isArray(v) ? v : [];
+import { createRequire } from "module";
+var cachedTransform = null;
+function loadSucraseTransform() {
+  if (cachedTransform) return cachedTransform;
+  const anchor = typeof import.meta !== "undefined" && import.meta.url ? import.meta.url : typeof __filename !== "undefined" ? __filename : process.cwd() + "/";
+  try {
+    cachedTransform = createRequire(anchor)("sucrase").transform;
+  } catch (err) {
+    throw new Error(
+      `@objectstack/lint: validating a kind:'react' page requires the "sucrase" package, which could not be loaded (${err instanceof Error ? err.message : String(err)}). It is a declared dependency of @objectstack/lint \u2014 if this deployment prunes packages, keep "sucrase" in the image; it is only loaded when a react-source page is validated.`
+    );
+  }
+  return cachedTransform;
+}
+var asArray6 = (v) => Array.isArray(v) ? v : [];
 function validateReactPages(stack) {
   const findings = [];
-  const pages = asArray5(stack.pages);
+  const pages = asArray6(stack.pages);
   for (let p = 0; p < pages.length; p++) {
     const page = pages[p];
     if (!page || page.kind !== "react") continue;
@@ -741,6 +808,7 @@ function validateReactPages(stack) {
       });
       continue;
     }
+    const transform = loadSucraseTransform();
     try {
       transform(source, { transforms: ["jsx", "typescript"], production: true });
     } catch (err) {
@@ -759,9 +827,22 @@ function validateReactPages(stack) {
 }
 
 // src/validate-react-page-props.ts
-import ts from "typescript";
+import { createRequire as createRequire2 } from "module";
 import { REACT_BLOCKS } from "@objectstack/spec/ui";
-var asArray6 = (v) => Array.isArray(v) ? v : [];
+var cachedTs = null;
+function loadTypeScript() {
+  if (cachedTs) return cachedTs;
+  const anchor = typeof import.meta !== "undefined" && import.meta.url ? import.meta.url : typeof __filename !== "undefined" ? __filename : process.cwd() + "/";
+  try {
+    cachedTs = createRequire2(anchor)("typescript");
+  } catch (err) {
+    throw new Error(
+      `@objectstack/lint: validating a kind:'react' page requires the "typescript" package, which could not be loaded (${err instanceof Error ? err.message : String(err)}). It is a declared dependency of @objectstack/lint \u2014 if this deployment prunes packages, keep "typescript" in the image; it is only loaded when a react-source page is validated.`
+    );
+  }
+  return cachedTs;
+}
+var asArray7 = (v) => Array.isArray(v) ? v : [];
 var BLOCKS = new Map(
   REACT_BLOCKS.map((b) => [
     b.tag,
@@ -800,32 +881,33 @@ function nearestKnown(prop, known) {
 }
 function validateReactPageProps(stack) {
   const findings = [];
-  const pages = asArray6(stack.pages);
+  const pages = asArray7(stack.pages);
   for (let p = 0; p < pages.length; p++) {
     const page = pages[p];
     if (!page || page.kind !== "react") continue;
     const source = page.source;
     if (typeof source !== "string" || source.trim() === "") continue;
     const name = String(page.name ?? `#${p}`);
+    const tsc = loadTypeScript();
     let sf;
     try {
-      sf = ts.createSourceFile("page.tsx", source, ts.ScriptTarget.Latest, true, ts.ScriptKind.TSX);
+      sf = tsc.createSourceFile("page.tsx", source, tsc.ScriptTarget.Latest, true, tsc.ScriptKind.TSX);
     } catch {
       continue;
     }
     const visit = (node) => {
-      if (ts.isJsxOpeningElement(node) || ts.isJsxSelfClosingElement(node)) {
+      if (tsc.isJsxOpeningElement(node) || tsc.isJsxSelfClosingElement(node)) {
         const tag = node.tagName.getText(sf);
         const block = BLOCKS.get(tag);
         if (block) {
           let hasSpread = false;
           const used = /* @__PURE__ */ new Set();
           for (const a of node.attributes.properties) {
-            if (ts.isJsxSpreadAttribute(a)) {
+            if (tsc.isJsxSpreadAttribute(a)) {
               hasSpread = true;
               continue;
             }
-            if (ts.isJsxAttribute(a)) used.add(a.name.getText(sf));
+            if (tsc.isJsxAttribute(a)) used.add(a.name.getText(sf));
           }
           const where = `page "${name}" \u203A <${tag}>`;
           const path = `pages[${p}].source`;
@@ -858,7 +940,7 @@ function validateReactPageProps(stack) {
           }
         }
       }
-      ts.forEachChild(node, visit);
+      tsc.forEachChild(node, visit);
     };
     visit(sf);
   }
@@ -867,11 +949,11 @@ function validateReactPageProps(stack) {
 
 // src/validate-page-source-styling.ts
 var PAGE_SOURCE_CLASSNAME = "page-source-className-tailwind";
-var asArray7 = (v) => Array.isArray(v) ? v : [];
+var asArray8 = (v) => Array.isArray(v) ? v : [];
 var CLASSNAME_ATTR = /\bclassName\s*=\s*["'{]/g;
 function validatePageSourceStyling(stack) {
   const findings = [];
-  const pages = asArray7(stack.pages);
+  const pages = asArray8(stack.pages);
   for (let p = 0; p < pages.length; p++) {
     const page = pages[p];
     if (!page) continue;
@@ -900,7 +982,7 @@ function validatePageSourceStyling(stack) {
 import { objectTitleCompleteness } from "@objectstack/spec/data";
 var TITLE_FORMAT_RETIRED = "title-format-retired";
 var TITLE_UNRESOLVABLE = "title-unresolvable";
-function asArray8(v) {
+function asArray9(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -909,7 +991,7 @@ function asArray8(v) {
 }
 function validateRecordTitle(stack) {
   const findings = [];
-  const objects = asArray8(stack.objects);
+  const objects = asArray9(stack.objects);
   for (let i = 0; i < objects.length; i++) {
     const obj = objects[i];
     const objName = typeof obj.name === "string" ? obj.name : `(object ${i})`;
@@ -944,7 +1026,7 @@ function validateRecordTitle(stack) {
 var FIELD_GROUP_UNDECLARED = "field-group-undeclared";
 var FIELD_GROUP_EMPTY = "field-group-empty";
 var SEMANTIC_ROLE_FIELD_UNKNOWN = "semantic-role-field-unknown";
-function asArray9(v) {
+function asArray10(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -953,7 +1035,7 @@ function asArray9(v) {
 }
 function validateSemanticRoles(stack) {
   const findings = [];
-  const objects = asArray9(stack.objects);
+  const objects = asArray10(stack.objects);
   for (let i = 0; i < objects.length; i++) {
     const obj = objects[i];
     if (!obj || typeof obj !== "object") continue;
@@ -1019,11 +1101,93 @@ function validateSemanticRoles(stack) {
   }
   return findings;
 }
+
+// src/validate-form-layout.ts
+var FORM_FIELD_UNKNOWN = "form-field-unknown";
+var FORM_COLSPAN_ABSOLUTE = "absolute-colspan-discouraged";
+function asArray11(v) {
+  if (Array.isArray(v)) return v;
+  if (v && typeof v === "object") {
+    return Object.entries(v).map(([name, def]) => ({ name, ...def }));
+  }
+  return [];
+}
+function fieldNameOf(entry) {
+  if (typeof entry === "string") return entry.length > 0 ? entry : null;
+  if (entry && typeof entry === "object" && !Array.isArray(entry)) {
+    const f = entry.field;
+    return typeof f === "string" && f.length > 0 ? f : null;
+  }
+  return null;
+}
+function boundObject(view) {
+  const data = view.data;
+  if (data && typeof data === "object" && typeof data.object === "string") {
+    return data.object;
+  }
+  return typeof view.objectName === "string" ? view.objectName : void 0;
+}
+function validateFormLayout(stack) {
+  const findings = [];
+  const objectFields = /* @__PURE__ */ new Map();
+  for (const obj of asArray11(stack.objects)) {
+    const name = typeof obj.name === "string" ? obj.name : void 0;
+    if (!name) continue;
+    const fields = obj.fields && typeof obj.fields === "object" && !Array.isArray(obj.fields) ? Object.keys(obj.fields) : [];
+    objectFields.set(name, new Set(fields));
+  }
+  const views = asArray11(stack.views);
+  for (let i = 0; i < views.length; i++) {
+    const view = views[i];
+    if (!view || typeof view !== "object") continue;
+    const sections = Array.isArray(view.sections) ? view.sections : null;
+    if (!sections) continue;
+    const viewName = typeof view.name === "string" ? view.name : `(view ${i})`;
+    const objName = boundObject(view);
+    const known = objName ? objectFields.get(objName) : void 0;
+    const where = `view "${viewName}"`;
+    const base = `views[${i}]`;
+    for (let s = 0; s < sections.length; s++) {
+      const sec = sections[s];
+      const secFields = sec && typeof sec === "object" && Array.isArray(sec.fields) ? sec.fields : [];
+      for (let f = 0; f < secFields.length; f++) {
+        const entry = secFields[f];
+        const fname = fieldNameOf(entry);
+        const fpath = `${base}.sections[${s}].fields[${f}]`;
+        if (fname && known && !known.has(fname)) {
+          findings.push({
+            severity: "warning",
+            rule: FORM_FIELD_UNKNOWN,
+            where,
+            path: fpath,
+            message: `${viewName}: field "${fname}" is not a field on object "${objName}" \u2014 it is silently skipped and never renders on the form`,
+            hint: `Fix the field name, or add "${fname}" to ${objName}. Section field references must match the object's field names exactly.`
+          });
+        }
+        const colSpan = entry && typeof entry === "object" && !Array.isArray(entry) ? entry.colSpan : void 0;
+        if (colSpan != null) {
+          findings.push({
+            severity: "warning",
+            rule: FORM_COLSPAN_ABSOLUTE,
+            where,
+            path: `${fpath}.colSpan`,
+            message: `${viewName}: field "${fname ?? "?"}" sets absolute colSpan ${String(colSpan)} \u2014 the form's column count is derived per surface (mobile 1 / modal 2 / page 3-4), so a fixed span only aligns at one width`,
+            hint: `Prefer span: 'full' (whole row at any column count), or omit for auto width. The renderer clamps colSpan to the current column count.`
+          });
+        }
+      }
+    }
+  }
+  return findings;
+}
 export {
   CHART_CONFIG_MISSING,
   CHART_FIELD_UNKNOWN,
   FIELD_GROUP_EMPTY,
   FIELD_GROUP_UNDECLARED,
+  FORM_COLSPAN_ABSOLUTE,
+  FORM_FIELD_UNKNOWN,
+  LIST_VIEW_FILTERS_IN_VIEWS_MODE,
   MEASURE_AGGREGATE_INCOHERENT,
   PAGE_SOURCE_CLASSNAME,
   SEMANTIC_ROLE_FIELD_UNKNOWN,
@@ -1038,7 +1202,9 @@ export {
   WIDGET_DATASET_UNKNOWN,
   WIDGET_DIMENSION_UNKNOWN,
   WIDGET_MEASURE_UNKNOWN,
+  validateFormLayout,
   validateJsxPages,
+  validateListViewMode,
   validatePageSourceStyling,
   validateReactPageProps,
   validateReactPages,