@objectstack/lint 11.4.0 → 11.5.0

package/dist/index.d.ts

@@ -69,7 +69,7 @@ interface WidgetBindingFinding {
     /** How to fix (or deliberately suppress) it. */
     hint: string;
 }
-type AnyRec$5 = Record<string, unknown>;
+type AnyRec$7 = Record<string, unknown>;
 /**
  * Validate every dashboard widget's dataset binding. Returns the list of
  * findings (empty = clean). Caller decides how to surface them: `error`
@@ -77,7 +77,7 @@ type AnyRec$5 = Record<string, unknown>;
  * should fail validate/build; `warning` findings are advisory and must
  * never fail the build on their own.
  */
-declare function validateWidgetBindings(stack: AnyRec$5): WidgetBindingFinding[];
+declare function validateWidgetBindings(stack: AnyRec$7): WidgetBindingFinding[];
 
 interface ExprIssue {
     where: string;
@@ -90,12 +90,12 @@ interface ExprIssue {
      */
     severity?: 'error' | 'warning';
 }
-type AnyRec$4 = Record<string, unknown>;
+type AnyRec$6 = Record<string, unknown>;
 /**
  * Validate every predicate in the stack. Returns the list of issues (empty =
  * clean). Caller decides how to surface / whether to fail the build.
  */
-declare function validateStackExpressions(stack: AnyRec$4): ExprIssue[];
+declare function validateStackExpressions(stack: AnyRec$6): ExprIssue[];
 
 type StyleSeverity = 'error' | 'warning';
 interface StyleFinding {
@@ -113,14 +113,14 @@ declare const STYLE_CLASSNAME_TAILWIND = "style-classname-tailwind";
 declare const STYLE_RESPONSIVE_NO_BASE = "style-responsive-no-base";
 declare const STYLE_UNKNOWN_CSS_PROPERTY = "style-unknown-css-property";
 declare const STYLE_UNKNOWN_TOKEN = "style-unknown-token";
-type AnyRec$3 = Record<string, unknown>;
+type AnyRec$5 = Record<string, unknown>;
 /**
  * Validate every page's component tree for SDUI styling correctness (ADR-0065).
  * Returns findings (empty = clean). `error` findings describe styles that are
  * silently dropped and should fail validate/build; `warning` findings are
  * advisory (typos, drift, footguns).
  */
-declare function validateResponsiveStyles(stack: AnyRec$3): StyleFinding[];
+declare function validateResponsiveStyles(stack: AnyRec$5): StyleFinding[];
 
 type JsxPageSeverity = 'error' | 'warning';
 interface JsxPageFinding {
@@ -133,8 +133,8 @@ interface JsxPageFinding {
     message: string;
     hint: string;
 }
-type AnyRec$2 = Record<string, unknown>;
-declare function validateJsxPages(stack: AnyRec$2, opts?: {
+type AnyRec$4 = Record<string, unknown>;
+declare function validateJsxPages(stack: AnyRec$4, opts?: {
     manifest?: Manifest;
 }): JsxPageFinding[];
 
@@ -147,8 +147,33 @@ interface ReactPageFinding {
     message: string;
     hint: string;
 }
+type AnyRec$3 = Record<string, unknown>;
+declare function validateReactPages(stack: AnyRec$3): ReactPageFinding[];
+
+type ReactPropSeverity = 'error' | 'warning';
+interface ReactPropFinding {
+    severity: ReactPropSeverity;
+    rule: string;
+    where: string;
+    path: string;
+    message: string;
+    hint: string;
+}
+type AnyRec$2 = Record<string, unknown>;
+declare function validateReactPageProps(stack: AnyRec$2): ReactPropFinding[];
+
+type SourceStyleSeverity = 'error' | 'warning';
+interface SourceStyleFinding {
+    severity: SourceStyleSeverity;
+    rule: string;
+    where: string;
+    path: string;
+    message: string;
+    hint: string;
+}
+declare const PAGE_SOURCE_CLASSNAME = "page-source-className-tailwind";
 type AnyRec$1 = Record<string, unknown>;
-declare function validateReactPages(stack: AnyRec$1): ReactPageFinding[];
+declare function validatePageSourceStyling(stack: AnyRec$1): SourceStyleFinding[];
 
 /**
  * Build-time record-title diagnostics (ADR-0079).
@@ -201,4 +226,4 @@ type AnyRec = Record<string, unknown>;
  */
 declare function validateRecordTitle(stack: AnyRec): RecordTitleFinding[];
 
-export { CHART_CONFIG_MISSING, CHART_FIELD_UNKNOWN, type ExprIssue, type JsxPageFinding, type JsxPageSeverity, MEASURE_AGGREGATE_INCOHERENT, type ReactPageFinding, type ReactPageSeverity, type RecordTitleFinding, type RecordTitleSeverity, STYLE_CLASSNAME_TAILWIND, STYLE_NODE_MISSING_ID, STYLE_RESPONSIVE_NO_BASE, STYLE_UNKNOWN_CSS_PROPERTY, STYLE_UNKNOWN_TOKEN, type StyleFinding, type StyleSeverity, TABLE_COUNT_ONLY, TITLE_FORMAT_RETIRED, TITLE_UNRESOLVABLE, WIDGET_DATASET_UNKNOWN, WIDGET_DIMENSION_UNKNOWN, WIDGET_MEASURE_UNKNOWN, type WidgetBindingFinding, type WidgetBindingSeverity, validateJsxPages, validateReactPages, validateRecordTitle, validateResponsiveStyles, validateStackExpressions, validateWidgetBindings };
+export { CHART_CONFIG_MISSING, CHART_FIELD_UNKNOWN, type ExprIssue, type JsxPageFinding, type JsxPageSeverity, MEASURE_AGGREGATE_INCOHERENT, PAGE_SOURCE_CLASSNAME, type ReactPageFinding, type ReactPageSeverity, type ReactPropFinding, type ReactPropSeverity, type RecordTitleFinding, type RecordTitleSeverity, STYLE_CLASSNAME_TAILWIND, STYLE_NODE_MISSING_ID, STYLE_RESPONSIVE_NO_BASE, STYLE_UNKNOWN_CSS_PROPERTY, STYLE_UNKNOWN_TOKEN, type SourceStyleFinding, type SourceStyleSeverity, type StyleFinding, type StyleSeverity, TABLE_COUNT_ONLY, TITLE_FORMAT_RETIRED, TITLE_UNRESOLVABLE, WIDGET_DATASET_UNKNOWN, WIDGET_DIMENSION_UNKNOWN, WIDGET_MEASURE_UNKNOWN, type WidgetBindingFinding, type WidgetBindingSeverity, validateJsxPages, validatePageSourceStyling, validateReactPageProps, validateReactPages, validateRecordTitle, validateResponsiveStyles, validateStackExpressions, validateWidgetBindings };

package/dist/index.js

@@ -758,11 +758,149 @@ function validateReactPages(stack) {
   return findings;
 }
 
+// src/validate-react-page-props.ts
+import ts from "typescript";
+import { REACT_BLOCKS } from "@objectstack/spec/ui";
+var asArray6 = (v) => Array.isArray(v) ? v : [];
+var BLOCKS = new Map(
+  REACT_BLOCKS.map((b) => [
+    b.tag,
+    {
+      requiredBindings: b.interactions.filter((i) => i.required).map((i) => i.name),
+      knownProps: new Set(b.interactions.map((i) => i.name))
+    }
+  ])
+);
+function editDistance(a, b, cap = 2) {
+  if (Math.abs(a.length - b.length) > cap) return cap + 1;
+  const dp = Array.from({ length: a.length + 1 }, (_, i) => i);
+  for (let j = 1; j <= b.length; j++) {
+    let prev = dp[0];
+    dp[0] = j;
+    for (let i = 1; i <= a.length; i++) {
+      const tmp = dp[i];
+      dp[i] = Math.min(dp[i] + 1, dp[i - 1] + 1, prev + (a[i - 1] === b[j - 1] ? 0 : 1));
+      prev = tmp;
+    }
+  }
+  return dp[a.length];
+}
+function nearestKnown(prop, known) {
+  if (known.has(prop)) return null;
+  let best = null;
+  let bestD = 3;
+  for (const k of known) {
+    const d = editDistance(prop, k);
+    if (d < bestD) {
+      bestD = d;
+      best = k;
+    }
+  }
+  return bestD <= 2 ? best : null;
+}
+function validateReactPageProps(stack) {
+  const findings = [];
+  const pages = asArray6(stack.pages);
+  for (let p = 0; p < pages.length; p++) {
+    const page = pages[p];
+    if (!page || page.kind !== "react") continue;
+    const source = page.source;
+    if (typeof source !== "string" || source.trim() === "") continue;
+    const name = String(page.name ?? `#${p}`);
+    let sf;
+    try {
+      sf = ts.createSourceFile("page.tsx", source, ts.ScriptTarget.Latest, true, ts.ScriptKind.TSX);
+    } catch {
+      continue;
+    }
+    const visit = (node) => {
+      if (ts.isJsxOpeningElement(node) || ts.isJsxSelfClosingElement(node)) {
+        const tag = node.tagName.getText(sf);
+        const block = BLOCKS.get(tag);
+        if (block) {
+          let hasSpread = false;
+          const used = /* @__PURE__ */ new Set();
+          for (const a of node.attributes.properties) {
+            if (ts.isJsxSpreadAttribute(a)) {
+              hasSpread = true;
+              continue;
+            }
+            if (ts.isJsxAttribute(a)) used.add(a.name.getText(sf));
+          }
+          const where = `page "${name}" \u203A <${tag}>`;
+          const path = `pages[${p}].source`;
+          if (!hasSpread) {
+            for (const req of block.requiredBindings) {
+              if (!used.has(req)) {
+                findings.push({
+                  severity: "error",
+                  rule: "react-prop-missing-required",
+                  where,
+                  path,
+                  message: `<${tag}> is missing the required prop "${req}".`,
+                  hint: `Pass ${req}={\u2026}. See the react-tier component contract.`
+                });
+              }
+            }
+          }
+          for (const u of used) {
+            const near = nearestKnown(u, block.knownProps);
+            if (near) {
+              findings.push({
+                severity: "warning",
+                rule: "react-prop-typo",
+                where,
+                path,
+                message: `<${tag}> has prop "${u}" \u2014 did you mean "${near}"?`,
+                hint: "Likely a typo of a contract prop. Fix it or remove it."
+              });
+            }
+          }
+        }
+      }
+      ts.forEachChild(node, visit);
+    };
+    visit(sf);
+  }
+  return findings;
+}
+
+// src/validate-page-source-styling.ts
+var PAGE_SOURCE_CLASSNAME = "page-source-className-tailwind";
+var asArray7 = (v) => Array.isArray(v) ? v : [];
+var CLASSNAME_ATTR = /\bclassName\s*=\s*["'{]/g;
+function validatePageSourceStyling(stack) {
+  const findings = [];
+  const pages = asArray7(stack.pages);
+  for (let p = 0; p < pages.length; p++) {
+    const page = pages[p];
+    if (!page) continue;
+    const kind = page.kind;
+    if (kind !== "html" && kind !== "react" && kind !== "jsx") continue;
+    const source = page.source;
+    if (typeof source !== "string" || source.trim() === "") continue;
+    const name = String(page.name ?? `#${p}`);
+    CLASSNAME_ATTR.lastIndex = 0;
+    let count = 0;
+    while (CLASSNAME_ATTR.exec(source) !== null) count++;
+    if (count === 0) continue;
+    findings.push({
+      severity: "warning",
+      rule: PAGE_SOURCE_CLASSNAME,
+      where: `page "${name}"`,
+      path: `pages[${p}].source`,
+      message: `${count} \`className\` attribute${count > 1 ? "s" : ""} in ${String(kind)}-source page \u2014 Tailwind utilities in page source silently produce no CSS (the build never scans authored metadata; ADR-0065).`,
+      hint: kind === "react" ? `Style with inline style={{}} using hsl(var(--token)) theme colors (e.g. color:'hsl(var(--foreground))', background:'hsl(var(--card))'); render drawer/modal via <ObjectForm formType="drawer"|"modal"> instead of hand-rolled overlays.` : `Lay out with the components' structured props (<flex direction gap>, <grid columns>) and add CSS via a JSON style object style={{"color":"hsl(var(--foreground))"}}; do not use Tailwind className.`
+    });
+  }
+  return findings;
+}
+
 // src/validate-record-title.ts
 import { objectTitleCompleteness } from "@objectstack/spec/data";
 var TITLE_FORMAT_RETIRED = "title-format-retired";
 var TITLE_UNRESOLVABLE = "title-unresolvable";
-function asArray6(v) {
+function asArray8(v) {
   if (Array.isArray(v)) return v;
   if (v && typeof v === "object") {
     return Object.entries(v).map(([name, def]) => ({ name, ...def }));
@@ -771,7 +909,7 @@ function asArray6(v) {
 }
 function validateRecordTitle(stack) {
   const findings = [];
-  const objects = asArray6(stack.objects);
+  const objects = asArray8(stack.objects);
   for (let i = 0; i < objects.length; i++) {
     const obj = objects[i];
     const objName = typeof obj.name === "string" ? obj.name : `(object ${i})`;
@@ -805,6 +943,7 @@ export {
   CHART_CONFIG_MISSING,
   CHART_FIELD_UNKNOWN,
   MEASURE_AGGREGATE_INCOHERENT,
+  PAGE_SOURCE_CLASSNAME,
   STYLE_CLASSNAME_TAILWIND,
   STYLE_NODE_MISSING_ID,
   STYLE_RESPONSIVE_NO_BASE,
@@ -817,6 +956,8 @@ export {
   WIDGET_DIMENSION_UNKNOWN,
   WIDGET_MEASURE_UNKNOWN,
   validateJsxPages,
+  validatePageSourceStyling,
+  validateReactPageProps,
   validateReactPages,
   validateRecordTitle,
   validateResponsiveStyles,