@objectstack/lint 11.2.0 → 11.4.0

package/dist/index.d.cts

@@ -69,7 +69,7 @@ interface WidgetBindingFinding {
     /** How to fix (or deliberately suppress) it. */
     hint: string;
 }
-type AnyRec$3 = Record<string, unknown>;
+type AnyRec$5 = Record<string, unknown>;
 /**
  * Validate every dashboard widget's dataset binding. Returns the list of
  * findings (empty = clean). Caller decides how to surface them: `error`
@@ -77,7 +77,7 @@ type AnyRec$3 = Record<string, unknown>;
  * should fail validate/build; `warning` findings are advisory and must
  * never fail the build on their own.
  */
-declare function validateWidgetBindings(stack: AnyRec$3): WidgetBindingFinding[];
+declare function validateWidgetBindings(stack: AnyRec$5): WidgetBindingFinding[];
 
 interface ExprIssue {
     where: string;
@@ -90,12 +90,12 @@ interface ExprIssue {
      */
     severity?: 'error' | 'warning';
 }
-type AnyRec$2 = Record<string, unknown>;
+type AnyRec$4 = Record<string, unknown>;
 /**
  * Validate every predicate in the stack. Returns the list of issues (empty =
  * clean). Caller decides how to surface / whether to fail the build.
  */
-declare function validateStackExpressions(stack: AnyRec$2): ExprIssue[];
+declare function validateStackExpressions(stack: AnyRec$4): ExprIssue[];
 
 type StyleSeverity = 'error' | 'warning';
 interface StyleFinding {
@@ -113,14 +113,14 @@ declare const STYLE_CLASSNAME_TAILWIND = "style-classname-tailwind";
 declare const STYLE_RESPONSIVE_NO_BASE = "style-responsive-no-base";
 declare const STYLE_UNKNOWN_CSS_PROPERTY = "style-unknown-css-property";
 declare const STYLE_UNKNOWN_TOKEN = "style-unknown-token";
-type AnyRec$1 = Record<string, unknown>;
+type AnyRec$3 = Record<string, unknown>;
 /**
  * Validate every page's component tree for SDUI styling correctness (ADR-0065).
  * Returns findings (empty = clean). `error` findings describe styles that are
  * silently dropped and should fail validate/build; `warning` findings are
  * advisory (typos, drift, footguns).
  */
-declare function validateResponsiveStyles(stack: AnyRec$1): StyleFinding[];
+declare function validateResponsiveStyles(stack: AnyRec$3): StyleFinding[];
 
 type JsxPageSeverity = 'error' | 'warning';
 interface JsxPageFinding {
@@ -133,9 +133,72 @@ interface JsxPageFinding {
     message: string;
     hint: string;
 }
-type AnyRec = Record<string, unknown>;
-declare function validateJsxPages(stack: AnyRec, opts?: {
+type AnyRec$2 = Record<string, unknown>;
+declare function validateJsxPages(stack: AnyRec$2, opts?: {
     manifest?: Manifest;
 }): JsxPageFinding[];
 
-export { CHART_CONFIG_MISSING, CHART_FIELD_UNKNOWN, type ExprIssue, type JsxPageFinding, type JsxPageSeverity, MEASURE_AGGREGATE_INCOHERENT, STYLE_CLASSNAME_TAILWIND, STYLE_NODE_MISSING_ID, STYLE_RESPONSIVE_NO_BASE, STYLE_UNKNOWN_CSS_PROPERTY, STYLE_UNKNOWN_TOKEN, type StyleFinding, type StyleSeverity, TABLE_COUNT_ONLY, WIDGET_DATASET_UNKNOWN, WIDGET_DIMENSION_UNKNOWN, WIDGET_MEASURE_UNKNOWN, type WidgetBindingFinding, type WidgetBindingSeverity, validateJsxPages, validateResponsiveStyles, validateStackExpressions, validateWidgetBindings };
+type ReactPageSeverity = 'error' | 'warning';
+interface ReactPageFinding {
+    severity: ReactPageSeverity;
+    rule: string;
+    where: string;
+    path: string;
+    message: string;
+    hint: string;
+}
+type AnyRec$1 = Record<string, unknown>;
+declare function validateReactPages(stack: AnyRec$1): ReactPageFinding[];
+
+/**
+ * Build-time record-title diagnostics (ADR-0079).
+ *
+ * A record's human title is a structural invariant: every object resolves a
+ * primary title from a real STORED field via `nameField` (the canonical
+ * pointer; `displayNameField` is the deprecated alias) or a deterministic
+ * derivation. Two authoring smells are flagged here so `os build`/`os lint`,
+ * the MCP authoring surface, and hand-authoring all get the coverage cloud
+ * graph-lint already has (the ADR-0078 "not cloud-only" principle):
+ *
+ * - `title-format-retired` — the object declares a `titleFormat`. That field
+ *   is a RENDER-ONLY template the server can neither return nor query; ADR-0079
+ *   retires it in favour of `nameField`. The schema still parses it (existing
+ *   metadata keeps loading), so this is advisory, not an error.
+ * - `title-unresolvable` — `objectTitleCompleteness` reports `status: 'none'`:
+ *   no `nameField`/`displayNameField` pointer and no title-eligible field to
+ *   derive one from. Records will have no meaningful title (the runtime falls
+ *   back to the auto-provisioned primary / `Record #<id>` floor), so this is a
+ *   warning, not an error — nothing is fully broken.
+ *
+ * Both are warnings: the auto-provision transform and the id floor mean a
+ * green build never ships a fully title-less object. Reuses the shared spec
+ * predicate (`@objectstack/spec/data` → display-name) so cloud and framework
+ * classify titles identically.
+ */
+declare const TITLE_FORMAT_RETIRED = "title-format-retired";
+declare const TITLE_UNRESOLVABLE = "title-unresolvable";
+type RecordTitleSeverity = 'error' | 'warning';
+interface RecordTitleFinding {
+    /** Always `warning` today — both rules are advisory (see module note). */
+    severity: RecordTitleSeverity;
+    /** Diagnostic rule id (registry entry), e.g. `title-format-retired`. */
+    rule: string;
+    /** Human-readable location, e.g. `object "invoice"`. */
+    where: string;
+    /** Config path, e.g. `objects[3]`. */
+    path: string;
+    /** What is wrong. */
+    message: string;
+    /** How to fix it. */
+    hint: string;
+}
+type AnyRec = Record<string, unknown>;
+/**
+ * Validate every object's record-title declaration. Returns the list of
+ * findings (empty = clean). Both rules are advisory (`warning`): the caller
+ * must never fail the build on them alone — auto-provision + the `Record #<id>`
+ * floor guarantee a resolvable title at runtime.
+ */
+declare function validateRecordTitle(stack: AnyRec): RecordTitleFinding[];
+
+export { CHART_CONFIG_MISSING, CHART_FIELD_UNKNOWN, type ExprIssue, type JsxPageFinding, type JsxPageSeverity, MEASURE_AGGREGATE_INCOHERENT, type ReactPageFinding, type ReactPageSeverity, type RecordTitleFinding, type RecordTitleSeverity, STYLE_CLASSNAME_TAILWIND, STYLE_NODE_MISSING_ID, STYLE_RESPONSIVE_NO_BASE, STYLE_UNKNOWN_CSS_PROPERTY, STYLE_UNKNOWN_TOKEN, type StyleFinding, type StyleSeverity, TABLE_COUNT_ONLY, TITLE_FORMAT_RETIRED, TITLE_UNRESOLVABLE, WIDGET_DATASET_UNKNOWN, WIDGET_DIMENSION_UNKNOWN, WIDGET_MEASURE_UNKNOWN, type WidgetBindingFinding, type WidgetBindingSeverity, validateJsxPages, validateReactPages, validateRecordTitle, validateResponsiveStyles, validateStackExpressions, validateWidgetBindings };

package/dist/index.d.ts

@@ -69,7 +69,7 @@ interface WidgetBindingFinding {
     /** How to fix (or deliberately suppress) it. */
     hint: string;
 }
-type AnyRec$3 = Record<string, unknown>;
+type AnyRec$5 = Record<string, unknown>;
 /**
  * Validate every dashboard widget's dataset binding. Returns the list of
  * findings (empty = clean). Caller decides how to surface them: `error`
@@ -77,7 +77,7 @@ type AnyRec$3 = Record<string, unknown>;
  * should fail validate/build; `warning` findings are advisory and must
  * never fail the build on their own.
  */
-declare function validateWidgetBindings(stack: AnyRec$3): WidgetBindingFinding[];
+declare function validateWidgetBindings(stack: AnyRec$5): WidgetBindingFinding[];
 
 interface ExprIssue {
     where: string;
@@ -90,12 +90,12 @@ interface ExprIssue {
      */
     severity?: 'error' | 'warning';
 }
-type AnyRec$2 = Record<string, unknown>;
+type AnyRec$4 = Record<string, unknown>;
 /**
  * Validate every predicate in the stack. Returns the list of issues (empty =
  * clean). Caller decides how to surface / whether to fail the build.
  */
-declare function validateStackExpressions(stack: AnyRec$2): ExprIssue[];
+declare function validateStackExpressions(stack: AnyRec$4): ExprIssue[];
 
 type StyleSeverity = 'error' | 'warning';
 interface StyleFinding {
@@ -113,14 +113,14 @@ declare const STYLE_CLASSNAME_TAILWIND = "style-classname-tailwind";
 declare const STYLE_RESPONSIVE_NO_BASE = "style-responsive-no-base";
 declare const STYLE_UNKNOWN_CSS_PROPERTY = "style-unknown-css-property";
 declare const STYLE_UNKNOWN_TOKEN = "style-unknown-token";
-type AnyRec$1 = Record<string, unknown>;
+type AnyRec$3 = Record<string, unknown>;
 /**
  * Validate every page's component tree for SDUI styling correctness (ADR-0065).
  * Returns findings (empty = clean). `error` findings describe styles that are
  * silently dropped and should fail validate/build; `warning` findings are
  * advisory (typos, drift, footguns).
  */
-declare function validateResponsiveStyles(stack: AnyRec$1): StyleFinding[];
+declare function validateResponsiveStyles(stack: AnyRec$3): StyleFinding[];
 
 type JsxPageSeverity = 'error' | 'warning';
 interface JsxPageFinding {
@@ -133,9 +133,72 @@ interface JsxPageFinding {
     message: string;
     hint: string;
 }
-type AnyRec = Record<string, unknown>;
-declare function validateJsxPages(stack: AnyRec, opts?: {
+type AnyRec$2 = Record<string, unknown>;
+declare function validateJsxPages(stack: AnyRec$2, opts?: {
     manifest?: Manifest;
 }): JsxPageFinding[];
 
-export { CHART_CONFIG_MISSING, CHART_FIELD_UNKNOWN, type ExprIssue, type JsxPageFinding, type JsxPageSeverity, MEASURE_AGGREGATE_INCOHERENT, STYLE_CLASSNAME_TAILWIND, STYLE_NODE_MISSING_ID, STYLE_RESPONSIVE_NO_BASE, STYLE_UNKNOWN_CSS_PROPERTY, STYLE_UNKNOWN_TOKEN, type StyleFinding, type StyleSeverity, TABLE_COUNT_ONLY, WIDGET_DATASET_UNKNOWN, WIDGET_DIMENSION_UNKNOWN, WIDGET_MEASURE_UNKNOWN, type WidgetBindingFinding, type WidgetBindingSeverity, validateJsxPages, validateResponsiveStyles, validateStackExpressions, validateWidgetBindings };
+type ReactPageSeverity = 'error' | 'warning';
+interface ReactPageFinding {
+    severity: ReactPageSeverity;
+    rule: string;
+    where: string;
+    path: string;
+    message: string;
+    hint: string;
+}
+type AnyRec$1 = Record<string, unknown>;
+declare function validateReactPages(stack: AnyRec$1): ReactPageFinding[];
+
+/**
+ * Build-time record-title diagnostics (ADR-0079).
+ *
+ * A record's human title is a structural invariant: every object resolves a
+ * primary title from a real STORED field via `nameField` (the canonical
+ * pointer; `displayNameField` is the deprecated alias) or a deterministic
+ * derivation. Two authoring smells are flagged here so `os build`/`os lint`,
+ * the MCP authoring surface, and hand-authoring all get the coverage cloud
+ * graph-lint already has (the ADR-0078 "not cloud-only" principle):
+ *
+ * - `title-format-retired` — the object declares a `titleFormat`. That field
+ *   is a RENDER-ONLY template the server can neither return nor query; ADR-0079
+ *   retires it in favour of `nameField`. The schema still parses it (existing
+ *   metadata keeps loading), so this is advisory, not an error.
+ * - `title-unresolvable` — `objectTitleCompleteness` reports `status: 'none'`:
+ *   no `nameField`/`displayNameField` pointer and no title-eligible field to
+ *   derive one from. Records will have no meaningful title (the runtime falls
+ *   back to the auto-provisioned primary / `Record #<id>` floor), so this is a
+ *   warning, not an error — nothing is fully broken.
+ *
+ * Both are warnings: the auto-provision transform and the id floor mean a
+ * green build never ships a fully title-less object. Reuses the shared spec
+ * predicate (`@objectstack/spec/data` → display-name) so cloud and framework
+ * classify titles identically.
+ */
+declare const TITLE_FORMAT_RETIRED = "title-format-retired";
+declare const TITLE_UNRESOLVABLE = "title-unresolvable";
+type RecordTitleSeverity = 'error' | 'warning';
+interface RecordTitleFinding {
+    /** Always `warning` today — both rules are advisory (see module note). */
+    severity: RecordTitleSeverity;
+    /** Diagnostic rule id (registry entry), e.g. `title-format-retired`. */
+    rule: string;
+    /** Human-readable location, e.g. `object "invoice"`. */
+    where: string;
+    /** Config path, e.g. `objects[3]`. */
+    path: string;
+    /** What is wrong. */
+    message: string;
+    /** How to fix it. */
+    hint: string;
+}
+type AnyRec = Record<string, unknown>;
+/**
+ * Validate every object's record-title declaration. Returns the list of
+ * findings (empty = clean). Both rules are advisory (`warning`): the caller
+ * must never fail the build on them alone — auto-provision + the `Record #<id>`
+ * floor guarantee a resolvable title at runtime.
+ */
+declare function validateRecordTitle(stack: AnyRec): RecordTitleFinding[];
+
+export { CHART_CONFIG_MISSING, CHART_FIELD_UNKNOWN, type ExprIssue, type JsxPageFinding, type JsxPageSeverity, MEASURE_AGGREGATE_INCOHERENT, type ReactPageFinding, type ReactPageSeverity, type RecordTitleFinding, type RecordTitleSeverity, STYLE_CLASSNAME_TAILWIND, STYLE_NODE_MISSING_ID, STYLE_RESPONSIVE_NO_BASE, STYLE_UNKNOWN_CSS_PROPERTY, STYLE_UNKNOWN_TOKEN, type StyleFinding, type StyleSeverity, TABLE_COUNT_ONLY, TITLE_FORMAT_RETIRED, TITLE_UNRESOLVABLE, WIDGET_DATASET_UNKNOWN, WIDGET_DIMENSION_UNKNOWN, WIDGET_MEASURE_UNKNOWN, type WidgetBindingFinding, type WidgetBindingSeverity, validateJsxPages, validateReactPages, validateRecordTitle, validateResponsiveStyles, validateStackExpressions, validateWidgetBindings };

package/dist/index.js

@@ -690,7 +690,7 @@ function validateJsxPages(stack, opts = {}) {
   const pages = asArray4(stack.pages);
   for (let p = 0; p < pages.length; p++) {
     const page = pages[p];
-    if (!page || page.kind !== "jsx") continue;
+    if (!page || page.kind !== "html" && page.kind !== "jsx") continue;
     const name = String(page.name ?? `#${p}`);
     const source = page.source;
     if (typeof source !== "string" || source.trim() === "") {
@@ -699,7 +699,7 @@ function validateJsxPages(stack, opts = {}) {
         rule: "jsx-page-empty-source",
         where: `page "${name}"`,
         path: `pages[${p}].source`,
-        message: "kind:'jsx' page has no `source`.",
+        message: `kind:'${page.kind}' page has no \`source\`.`,
         hint: "Author the page as a constrained JSX/Tailwind string in `source`."
       });
       continue;
@@ -718,6 +718,89 @@ function validateJsxPages(stack, opts = {}) {
   }
   return findings;
 }
+
+// src/validate-react-pages.ts
+import { transform } from "sucrase";
+var asArray5 = (v) => Array.isArray(v) ? v : [];
+function validateReactPages(stack) {
+  const findings = [];
+  const pages = asArray5(stack.pages);
+  for (let p = 0; p < pages.length; p++) {
+    const page = pages[p];
+    if (!page || page.kind !== "react") continue;
+    const name = String(page.name ?? `#${p}`);
+    const source = page.source;
+    if (typeof source !== "string" || source.trim() === "") {
+      findings.push({
+        severity: "error",
+        rule: "react-page-empty-source",
+        where: `page "${name}"`,
+        path: `pages[${p}].source`,
+        message: "kind:'react' page has no `source`.",
+        hint: "Author the page as a real React component string in `source`."
+      });
+      continue;
+    }
+    try {
+      transform(source, { transforms: ["jsx", "typescript"], production: true });
+    } catch (err) {
+      const message = err instanceof Error ? err.message : String(err);
+      findings.push({
+        severity: "error",
+        rule: "react-page-syntax",
+        where: `page "${name}"`,
+        path: `pages[${p}].source`,
+        message: `kind:'react' source has a syntax error: ${message.split("\n")[0]}`,
+        hint: "The source is transpiled (never executed) at build to catch syntax errors early \u2014 fix the JS/JSX."
+      });
+    }
+  }
+  return findings;
+}
+
+// src/validate-record-title.ts
+import { objectTitleCompleteness } from "@objectstack/spec/data";
+var TITLE_FORMAT_RETIRED = "title-format-retired";
+var TITLE_UNRESOLVABLE = "title-unresolvable";
+function asArray6(v) {
+  if (Array.isArray(v)) return v;
+  if (v && typeof v === "object") {
+    return Object.entries(v).map(([name, def]) => ({ name, ...def }));
+  }
+  return [];
+}
+function validateRecordTitle(stack) {
+  const findings = [];
+  const objects = asArray6(stack.objects);
+  for (let i = 0; i < objects.length; i++) {
+    const obj = objects[i];
+    const objName = typeof obj.name === "string" ? obj.name : `(object ${i})`;
+    const where = `object "${objName}"`;
+    const path = `objects[${i}]`;
+    if (obj.titleFormat !== void 0 && obj.titleFormat !== null && obj.titleFormat !== "") {
+      findings.push({
+        severity: "warning",
+        rule: TITLE_FORMAT_RETIRED,
+        where,
+        path,
+        message: `${objName}: titleFormat is retired (ADR-0079) \u2014 migrate to nameField (single field) or a formula field designated nameField`,
+        hint: `titleFormat is a render-only template the server cannot return or query, and an explicit nameField now takes precedence. For a single-field title set nameField: '<field>'. For a composite title, add a formula field (returnType: 'text') and designate it via nameField.`
+      });
+    }
+    const completeness = objectTitleCompleteness(obj);
+    if (completeness.status === "none") {
+      findings.push({
+        severity: "warning",
+        rule: TITLE_UNRESOLVABLE,
+        where,
+        path,
+        message: `${objName}: no resolvable record title \u2014 records will have no meaningful name (no nameField and no title-eligible field to derive one)`,
+        hint: `Set nameField to a text/email field (or a formula field with returnType: 'text'), or add a text field named "name"/"title". The runtime auto-provisions a primary and falls back to "Record #<id>", but an explicit title is far more useful.`
+      });
+    }
+  }
+  return findings;
+}
 export {
   CHART_CONFIG_MISSING,
   CHART_FIELD_UNKNOWN,
@@ -728,10 +811,14 @@ export {
   STYLE_UNKNOWN_CSS_PROPERTY,
   STYLE_UNKNOWN_TOKEN,
   TABLE_COUNT_ONLY,
+  TITLE_FORMAT_RETIRED,
+  TITLE_UNRESOLVABLE,
   WIDGET_DATASET_UNKNOWN,
   WIDGET_DIMENSION_UNKNOWN,
   WIDGET_MEASURE_UNKNOWN,
   validateJsxPages,
+  validateReactPages,
+  validateRecordTitle,
   validateResponsiveStyles,
   validateStackExpressions,
   validateWidgetBindings