@object-ui/runner 16.0.0 → 17.1.0

package/CHANGELOG.md

@@ -1,5 +1,276 @@
 # @object-ui/runner
 
+## 17.1.0
+
+### Patch Changes
+
+- Updated dependencies [62311b6]
+- Updated dependencies [fc0272a]
+- Updated dependencies [9e7349e]
+- Updated dependencies [8864971]
+- Updated dependencies [c785740]
+- Updated dependencies [b41f401]
+- Updated dependencies [19e9fa0]
+- Updated dependencies [95b7214]
+- Updated dependencies [7d9734d]
+- Updated dependencies [6ae818e]
+- Updated dependencies [f1c04b6]
+- Updated dependencies [9eb932b]
+- Updated dependencies [746dd00]
+- Updated dependencies [aebfa4f]
+- Updated dependencies [38ca8be]
+- Updated dependencies [68ef584]
+- Updated dependencies [4952edf]
+- Updated dependencies [7f0252e]
+- Updated dependencies [c4d7b20]
+- Updated dependencies [c769d3d]
+- Updated dependencies [7639a61]
+- Updated dependencies [94e63ef]
+- Updated dependencies [c735bf7]
+- Updated dependencies [02aef0c]
+- Updated dependencies [6f29aa5]
+- Updated dependencies [c4db402]
+- Updated dependencies [5319bf1]
+- Updated dependencies [49e5671]
+- Updated dependencies [9a04d25]
+- Updated dependencies [b5b97e2]
+- Updated dependencies [f59f2c1]
+- Updated dependencies [07de839]
+- Updated dependencies [2a40b5e]
+- Updated dependencies [df613fa]
+- Updated dependencies [4874117]
+- Updated dependencies [ad0183a]
+- Updated dependencies [ce08d55]
+- Updated dependencies [eb4b740]
+- Updated dependencies [5b084eb]
+- Updated dependencies [aa1240a]
+- Updated dependencies [2374a49]
+- Updated dependencies [390c071]
+- Updated dependencies [d10f526]
+- Updated dependencies [2d5d594]
+- Updated dependencies [ea7f477]
+- Updated dependencies [379728f]
+- Updated dependencies [7f23cd0]
+- Updated dependencies [0ded602]
+- Updated dependencies [24e0e0a]
+- Updated dependencies [3a6cf24]
+- Updated dependencies [aa35561]
+- Updated dependencies [03bd53b]
+- Updated dependencies [3c1f321]
+- Updated dependencies [a045a32]
+- Updated dependencies [912496d]
+- Updated dependencies [80edbd4]
+- Updated dependencies [9867281]
+  - @object-ui/core@17.1.0
+  - @object-ui/components@17.1.0
+  - @object-ui/react@17.1.0
+  - @object-ui/types@17.1.0
+  - @object-ui/plugin-charts@17.1.0
+  - @object-ui/plugin-kanban@17.1.0
+
+## 17.0.0
+
+### Patch Changes
+
+- b076050: fix(console,runner): the approvals inbox renders against one ticking clock, and both packages now run ESLint
+
+  `apps/console` and `packages/runner` had no `lint` script, so `turbo run lint`
+  skipped them silently and their 17 ESLint **errors** had never been seen
+  (#2923 declared them as DEBT; this closes the gap). Both now carry
+  `"lint": "eslint ."` and the `DEBT` list in `scripts/check-lint-coverage.mjs`
+  is empty — every workspace package is linted.
+
+  What the errors actually were, once read one by one:
+
+  - **8x `react-hooks/purity` — real, and user-visible.** The approvals inbox
+    read `Date.now()` mid-render for every age tint, "5m ago" label and SLA chip.
+    Render must be pure: the output depended on when React happened to render, so
+    it disagreed with itself under StrictMode's double render and then **froze** —
+    an inbox left open kept saying "just now" and an SLA countdown never counted
+    down. The page now renders against a single `now` held in state and advanced
+    once a minute (the finest granularity anything here displays), so render is a
+    pure function of props+state _and_ the figures actually tick.
+  - Alongside that, `sla_due_at` is now parsed through a guard. A due date the
+    backend sends in a shape `Date.parse` can't read used to render as
+    "SLA NaNh left"; it now renders nothing.
+  - **1x `react-hooks/static-components` — real.** `StatusBadge` was declared
+    inside `ApprovalsInboxPage`, making it a brand-new component type on every
+    render, so React unmounted and remounted every status chip in the table each
+    time the page re-rendered. Hoisted to module scope, with the translated label
+    passed as a prop.
+  - **6x `react-hooks/static-components` — false positives** (3 in the console's
+    settings pages, 3 in the runner's `LayoutRenderer`). All six render the result
+    of `getIcon`/`getLazyIcon`, which memoises per name in a module-level cache —
+    the component reference is stable across renders and nothing is created during
+    render. The rule cannot see through the call, so these carry the same targeted
+    `eslint-disable-next-line` + justification the repo already uses at a dozen
+    icon-registry sites, and the resolvers themselves now say so in a comment.
+    (Verified rather than assumed: typing into a settings field keeps focus and
+    every character, so no state was ever being reset there.)
+  - **2 minor.** A dead `token` initializer on the console's auth preflight path
+    (`no-useless-assignment` — read, not blind-deleted: no intended write was
+    missing, every path out of the try/catch either assigns or returns), and a
+    `prefer-const` in the SDUI workbench preview.
+
+- b39f4b3: fix(runner): type-check the package at all, and fix the `DataSource` contract violation that hid behind a broken import (#2917)
+
+  `@object-ui/runner` was the worst-covered package in the repo: `build` is
+  `vite build` (transpile only), it had no `type-check` script, and — uniquely —
+  **no `tsconfig.json` at all**. Nothing had ever type-checked it, despite it being
+  a published package.
+
+  **It was not broken at runtime.** The two bad imports were `import type`, so they
+  were erased before they could fail, and the one value import
+  (`emulateBatchTransaction`) does exist. `MockDataSource` is also unreferenced
+  anywhere in the repo. So this is a correctness and reference-quality fix, not an
+  outage.
+
+  **What the missing check actually hid.** `DataSource` and
+  `BatchTransactionOperation` were imported from `@object-ui/core`, which does not
+  export them — they live in `@object-ui/types`. Because that import never
+  resolved, `class MockDataSource implements DataSource` was silently a no-op, and
+  three separate commits maintained the class _as if_ it were being verified
+  (`62b9ab510` added `batchTransaction`, `09d9669c7` made `getObjectSchema`
+  required, `5527388b0` added input validation). With the `implements` clause
+  inert, a real contract violation survived all three:
+
+  ```ts
+  async find(resource: string, params?: any): Promise<any[]> { return []; }
+  ```
+
+  `DataSource.find` returns a `QueryResult` envelope, not a bare array. Anyone
+  copying this mock as the starting point for their own adapter — which is exactly
+  what its doc comment invites — would hand every consumer an array where `.data`
+  and `.total` are `undefined`. Now typed as `Promise<QueryResult>` and returning
+  `{ data: [], total: 0 }`.
+
+  Also in this change:
+
+  - `packages/runner/tsconfig.json` added, mirroring `apps/console` rather than the
+    library packages: `runner` is a Vite app, so it wants `bundler` resolution,
+    `allowImportingTsExtensions` (for `./App.tsx`) and `types: ["vite/client"]`
+    (for `import.meta.glob` in `MetadataLoader` and the `./index.css` side-effect
+    import). Keeping it standalone instead of extending the root config also means
+    it never inherits the root `paths`, so workspace deps resolve through built
+    `.d.ts` and the TS6059 `rootDir` class of error cannot appear.
+  - unused parameters prefixed with `_` (6x in `mockDataSource`), and an unused
+    `Circle` icon import dropped from `LayoutRenderer`.
+  - `"type-check": "tsc --noEmit"` added, and the package's `DEBT` entry deleted
+    from `scripts/check-type-check-coverage.mjs`. Coverage goes 35 -> 36 of 45 and
+    outstanding errors 46 -> 32.
+
+  Verified the gate genuinely covers the package now, rather than trusting the
+  green: injecting a type error into `runner/src/App.tsx` makes `pnpm type-check`
+  fail with `Failed: @object-ui/runner#type-check`, which was impossible before
+  this change.
+
+- Updated dependencies [7b21891]
+- Updated dependencies [952b978]
+- Updated dependencies [de5e40c]
+- Updated dependencies [aa88056]
+- Updated dependencies [1767124]
+- Updated dependencies [8ecf5a6]
+- Updated dependencies [7b35e4b]
+- Updated dependencies [8fb1295]
+- Updated dependencies [e16ed2d]
+- Updated dependencies [f9bbddb]
+- Updated dependencies [dfd3705]
+- Updated dependencies [c77108c]
+- Updated dependencies [2735de6]
+- Updated dependencies [c19ac11]
+- Updated dependencies [6dee2cb]
+- Updated dependencies [c7cff19]
+- Updated dependencies [ba73a02]
+- Updated dependencies [cd09a7b]
+- Updated dependencies [f1abf0e]
+- Updated dependencies [f05b84e]
+- Updated dependencies [2f947e4]
+- Updated dependencies [7d46648]
+- Updated dependencies [6e8fd3c]
+- Updated dependencies [9b53d72]
+- Updated dependencies [662bdf9]
+- Updated dependencies [059a052]
+- Updated dependencies [53642d4]
+- Updated dependencies [8aae006]
+- Updated dependencies [c6cfdf1]
+- Updated dependencies [d147a13]
+- Updated dependencies [c6aaed8]
+- Updated dependencies [dc334da]
+  - @object-ui/components@17.0.0
+  - @object-ui/react@17.0.0
+  - @object-ui/plugin-charts@17.0.0
+  - @object-ui/types@17.0.0
+  - @object-ui/core@17.0.0
+  - @object-ui/plugin-kanban@17.0.0
+
+## 16.1.0
+
+### Minor Changes
+
+- 62b9ab5: feat(data): unify master-detail saves behind `DataSource.batchTransaction`, isolate the non-atomic fallback in the adapter (#2679)
+
+  Master-detail saves (`MasterDetailForm`, `LineItemsPanel`) now always persist
+  through `dataSource.batchTransaction(operations)` — one ordered cross-object
+  operation list, with `{ $ref: <op index> }` linking a child to a parent created
+  in the same batch. The form no longer contains any client-side orchestration or
+  best-effort compensation-delete; that atomicity anti-pattern is gone from the UI
+  layer (framework #1604 / framework ADR-0034 item 4).
+
+  - **`@object-ui/types`** — `batchTransaction?` is now a first-class (optional)
+    method on the `DataSource` contract, typed via `BatchTransactionOperation` /
+    `BatchRef`. Replaces the previous `(dataSource as any).batchTransaction`
+    method-sniffing.
+  - **`@object-ui/core`** — new `emulateBatchTransaction(dataSource, operations)`
+    (sequential writes, `$ref` resolution, best-effort reverse-order compensation)
+    and `runBatchTransaction(dataSource, operations)` (prefers the adapter's method,
+    emulates otherwise). `ApiDataSource` / `ValueDataSource` implement
+    `batchTransaction` via the emulation.
+  - **`@object-ui/data-objectstack`** — `ObjectStackAdapter.batchTransaction` uses
+    the server's atomic `POST /api/v1/batch`, prefers the typed
+    `client.data.batchTransaction` SDK method when the installed client exposes it,
+    and degrades to the client-side emulation ONLY when the endpoint is missing
+    (404/405) or the runtime can't do transactions (501). Real errors (400/401/403/
+    409/500) still surface. This is the isolated, tested home of the non-atomic
+    fallback.
+  - **`@object-ui/plugin-form`** — removed `applyDetail` / `createMany` /
+    `ApplyDetailResult` from `masterDetailTx.ts`; `MasterDetailForm` and
+    `LineItemsPanel` build ops and call `runBatchTransaction`. `LineItemsPanel`
+    saves are now atomic on a capable backend, with the rollup folded into the same
+    batch.
+
+  No behavior change on a current ObjectStack backend (it has `/api/v1/batch`);
+  older/limited backends keep a working — now clearly non-atomic — save path.
+
+### Patch Changes
+
+- Updated dependencies [1c8935a]
+- Updated dependencies [8b8b744]
+- Updated dependencies [7cf4051]
+- Updated dependencies [803558e]
+- Updated dependencies [2e7d7f0]
+- Updated dependencies [ef14f69]
+- Updated dependencies [94d4876]
+- Updated dependencies [69fa5d1]
+- Updated dependencies [549c67d]
+- Updated dependencies [ebe6494]
+- Updated dependencies [2b17339]
+- Updated dependencies [31b77d4]
+- Updated dependencies [6d4fbe6]
+- Updated dependencies [0a3710b]
+- Updated dependencies [62b9ab5]
+- Updated dependencies [1629313]
+- Updated dependencies [29c6040]
+- Updated dependencies [faebac3]
+- Updated dependencies [2331ac9]
+- Updated dependencies [199fa83]
+- Updated dependencies [eee4ded]
+  - @object-ui/core@16.1.0
+  - @object-ui/types@16.1.0
+  - @object-ui/react@16.1.0
+  - @object-ui/components@16.1.0
+  - @object-ui/plugin-kanban@16.1.0
+  - @object-ui/plugin-charts@16.1.0
+
 ## 16.0.0
 
 ### Patch Changes