@object-ui/plugin-view 3.1.1 → 3.1.3

package/src/ObjectView.tsx

@@ -384,7 +384,7 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
       return;
     }
     if (layout === 'page' && schema.onNavigate) {
-      const recordId = record._id || record.id;
+      const recordId = record.id || record._id;
       schema.onNavigate(recordId as string | number, 'edit');
     } else {
       setFormMode('edit');
@@ -396,7 +396,7 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
   // Handle view action (read a record)
   const handleView = useCallback((record: Record<string, unknown>) => {
     if (layout === 'page' && schema.onNavigate) {
-      const recordId = record._id || record.id;
+      const recordId = record.id || record._id;
       schema.onNavigate(recordId as string | number, 'view');
     } else {
       setFormMode('view');
@@ -418,8 +418,8 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
         return; // Do nothing
       }
       if (navigationConfig.mode === 'new_window' || navigationConfig.openNewTab) {
-        const recordId = record._id || record.id;
-        const url = `/${schema.objectName}/${recordId}`;
+        const recordId = record.id || record._id;
+        const url = `/${schema.objectName}/${encodeURIComponent(String(recordId))}`;
         window.open(url, '_blank');
         return;
       }
@@ -436,7 +436,7 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
         return;
       }
       if (navigationConfig.mode === 'page') {
-        const recordId = record._id || record.id;
+        const recordId = record.id || record._id;
         if (schema.onNavigate) {
           schema.onNavigate(recordId as string | number, 'view');
         }
@@ -727,7 +727,7 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
   // Build form schema
   const buildFormSchema = (): ObjectFormSchema => {
     const recordId = selectedRecord
-      ? ((selectedRecord._id || selectedRecord.id) as string | number | undefined)
+      ? ((selectedRecord.id || selectedRecord._id) as string | number | undefined)
       : undefined;
 
     return {
@@ -882,6 +882,7 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
           addRecord: activeView?.addRecord ?? (schema as any).addRecord,
           conditionalFormatting: activeView?.conditionalFormatting ?? (schema as any).conditionalFormatting,
           quickFilters: activeView?.quickFilters ?? (schema as any).quickFilters,
+          userFilters: activeView?.userFilters ?? (schema as any).userFilters,
           showRecordCount: activeView?.showRecordCount ?? (schema as any).showRecordCount,
           allowPrinting: activeView?.allowPrinting ?? (schema as any).allowPrinting,
           virtualScroll: activeView?.virtualScroll ?? (schema as any).virtualScroll,

package/src/__tests__/ObjectView.test.tsx

@@ -25,7 +25,7 @@ vi.mock('@object-ui/react', () => ({
 vi.mock('@object-ui/plugin-grid', () => ({
   ObjectGrid: ({ schema, onRowClick }: any) => (
     <div data-testid="object-grid" data-object={schema?.objectName}>
-      <button data-testid="grid-row" onClick={() => onRowClick?.({ _id: '1', name: 'Test' })}>
+      <button data-testid="grid-row" onClick={() => onRowClick?.({ id: '1', name: 'Test' })}>
         Row 1
       </button>
     </div>
@@ -661,5 +661,45 @@ describe('ObjectView', () => {
       expect(callSchema?.showFilters).toBe(false);
       expect(callSchema?.showSort).toBe(false);
     });
+
+    it('should propagate userFilters from activeView in renderListView', async () => {
+      const schema: ObjectViewSchema = {
+        type: 'object-view',
+        objectName: 'contacts',
+      };
+
+      const renderListViewSpy = vi.fn(({ schema: listSchema }: any) => (
+        <div data-testid="custom-list">Custom ListView</div>
+      ));
+
+      const views = [
+        {
+          id: 'v1',
+          label: 'View 1',
+          type: 'grid' as const,
+          userFilters: {
+            element: 'dropdown' as const,
+            fields: [{ field: 'status' }],
+          },
+        },
+      ];
+
+      render(
+        <ObjectView
+          schema={schema}
+          dataSource={mockDataSource}
+          views={views}
+          activeViewId="v1"
+          renderListView={renderListViewSpy}
+        />,
+      );
+
+      expect(renderListViewSpy).toHaveBeenCalled();
+      const callSchema = renderListViewSpy.mock.calls[0]?.[0]?.schema;
+      expect(callSchema?.userFilters).toEqual({
+        element: 'dropdown',
+        fields: [{ field: 'status' }],
+      });
+    });
   });
 });

package/src/__tests__/config-sync-integration.test.tsx

@@ -32,7 +32,7 @@ vi.mock('@object-ui/react', () => ({
 vi.mock('@object-ui/plugin-grid', () => ({
   ObjectGrid: ({ schema, onRowClick }: any) => (
     <div data-testid="object-grid" data-object={schema?.objectName}>
-      <button data-testid="grid-row" onClick={() => onRowClick?.({ _id: '1', name: 'Test' })}>
+      <button data-testid="grid-row" onClick={() => onRowClick?.({ id: '1', name: 'Test' })}>
         Row 1
       </button>
     </div>

package/src/__tests__/registration.test.tsx

@@ -1,32 +0,0 @@
-/**
- * ObjectUI
- * Copyright (c) 2024-present ObjectStack Inc.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-import { describe, it, expect } from 'vitest';
-import { ObjectView, ViewSwitcher, FilterUI, SortUI } from '../index';
-
-describe('Plugin View Registration', () => {
-  it('exports ObjectView component', () => {
-    expect(ObjectView).toBeDefined();
-    expect(typeof ObjectView).toBe('function');
-  });
-
-  it('exports ViewSwitcher component', () => {
-    expect(ViewSwitcher).toBeDefined();
-    expect(typeof ViewSwitcher).toBe('function');
-  });
-
-  it('exports FilterUI component', () => {
-    expect(FilterUI).toBeDefined();
-    expect(typeof FilterUI).toBe('function');
-  });
-
-  it('exports SortUI component', () => {
-    expect(SortUI).toBeDefined();
-    expect(typeof SortUI).toBe('function');
-  });
-});